Project

General

Profile

Activity

From 08/09/2022 to 09/07/2022

09/08/2022

10:38 PM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
Code Review scopeable_6650_patch_20220901a.patch:
I did not find a revised patch with the #6650-14 changes after G...
Eric Faulhaber

09/07/2022

01:25 PM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
> Greg: I haven't yet decoupled TransactionManager from the direct references to BufferManager/LogicalTerminal, I'll ... Greg Shah

09/06/2022

02:25 PM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
The latest patch is attached, built on top of 3821c/14225. I need to finish testing with other apps, there is an iss... Constantin Asofiei
08:53 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
There is an inherent feature of @ScopedDictionary@, where 'global' scope is used: this is not something created by th... Constantin Asofiei

09/05/2022

04:22 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
I think you can go ahead and check in your first pass changes from #6650-14. Or did you plan to check it in with the... Greg Shah

09/02/2022

10:47 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
> LT will still exist, but TC will be on the server-side. If we remove LT, this would mean frames are no longer being... Greg Shah
07:37 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
Greg Shah wrote:
> Code Review scopeable_6650_patch_20220901a.patch
>
> Overall, I think the changes are quite go...
Constantin Asofiei
06:39 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
Eric Faulhaber wrote:
> > Something I forgot to mention - there are some methods in BufferManager which are never ca...
Constantin Asofiei
06:27 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
Code Review scopeable_6650_patch_20220901a.patch
Overall, I think the changes are quite good.
My concern is m...
Greg Shah
06:22 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
Constantin Asofiei wrote:
> Eric: if you can give me some hints at extracting BufferManager's tx scope support, I ca...
Eric Faulhaber
04:20 AM Feature #1970: improve ControlFlowOps method resolution by reflection
This makes sense. Greg Shah

09/01/2022

11:48 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
Eric: if you can give me some hints at extracting BufferManager's tx scope support, I can give it a try. To me, it l... Constantin Asofiei
09:37 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
You can apply the patch using:... Constantin Asofiei
09:37 AM Feature #6650 (WIP): improve performance of Scopeable notification in TM.processScopeNotifications
The changes are attach. Greg/Eric: please review and let me know if you see something dangerous.
The patch is on ...
Constantin Asofiei
11:01 AM Feature #1970: improve ControlFlowOps method resolution by reflection
Greg Shah wrote:
> The tricky part is that at the call site, we would have some configuration/data that is dynamic o...
Constantin Asofiei

08/29/2022

02:53 PM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
I can not find a good way to limit BufferManager/ChangeBroker. I have changes which sync them (so they are always no... Constantin Asofiei

08/23/2022

01:56 AM Bug #6693: StringFormat fixes - finish up and merge branch 4880a|b|c
Although the main fix for a @<complex_gui_application>@ is done (see #4880), a lot of improvements have already been ... Tijs Wickardt
01:52 AM Bug #6693 (New): StringFormat fixes - finish up and merge branch 4880a|b|c
Tijs Wickardt

08/22/2022

04:11 PM Bug #6640: parsing bug for initial ",0000" for decimal variables or fields
> Also, we need to check if this must be configured in p2j.cfg.xml or not (i.e. if it must consider -numsep at the 4G... Greg Shah

08/16/2022

03:25 PM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
Constantin Asofiei wrote:
> * @DatabaseTriggerManager@ - the problem here is that the context-local instance is refe...
Ovidiu Maxiniuc
02:55 PM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
Ovidiu and Eric: Please review the persistence related Scopeables in #6650-2 and see if you can offer some guidance. Greg Shah
02:54 PM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
> For some cases (like UnnamedStreams and SharedVariableManager), the decision is easy - if the context-local WorkAre... Greg Shah
09:01 AM Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
The complex part of the task is to determine where and when to register a Scopeable with the next (or current) block.... Constantin Asofiei
07:07 AM Feature #4065: server-side processing of client platform dependencies
Yes, this is a flaw but it is better than the alternative.
Can we detect when the same lvalue is re-assigned a new...
Greg Shah
06:57 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> We don't actually allocate any additional memory, but there will be an extra entry in our registr...
Constantin Asofiei
06:56 AM Feature #4065: server-side processing of client platform dependencies
> FWD will keep it allocated in the context's address space, as it 'allocated' this address space when the RETURN or ... Greg Shah
06:47 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> > My point is if the memory is not deallocated on FWD server, this will lead to a memory leak in ...
Constantin Asofiei
06:45 AM Feature #4065: server-side processing of client platform dependencies
> I understand, but I have at least a case in #6277 where the RETURN parameter is not being deallocated on the FWD se... Greg Shah
06:28 AM Feature #4065: server-side processing of client platform dependencies
Constantin Asofiei wrote:
> ... in this case, the library call is https://www.openssl.org/docs/man1.1.1/man3/EVP_sha...
Constantin Asofiei
06:26 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> In this case, we can augment the RETURN or OUTPUT parameter with additional size information. Ac...
Constantin Asofiei
06:21 AM Feature #4065: server-side processing of client platform dependencies
> The only solution I see is to disable the address space check for RETURN and OUTPUT parameters, in the FWD runtime.... Greg Shah
05:46 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Perhaps we should require that the 4GL code is modified to tell us the size of the returned point...
Constantin Asofiei
05:39 AM Feature #4065: server-side processing of client platform dependencies
> But the deregistration of this pointer from the FWD context's address space may not happen, if the memptr is not de... Greg Shah
05:06 AM Feature #4065: server-side processing of client platform dependencies
Another approach would be to allow memptr to be assigned addresses returned by the native API calls, and not register... Constantin Asofiei
05:05 AM Feature #4065: server-side processing of client platform dependencies
There is an issue with server-side memptr which affects #6277. The problem is related to memptr used at @define retu... Constantin Asofiei
 

Also available in: Atom