Project

General

Profile

Activity

From 03/12/2023 to 04/10/2023

04/10/2023

10:53 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
This task isn't a priority right now. Greg Shah
10:49 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
Constantin Asofiei wrote:
> > # calling the @unknown.instantiateUnknown()@, this function just returns the @unknow...
Vladimir Tsichevski
10:45 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
Vladimir Tsichevski wrote:
> I can take this task.
Greg?
> # calling @new unknown()@, we want to get rid of thi...
Constantin Asofiei
10:02 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
I can take this task.
A question: currently there is 3 ways to obtain the @unknown@ value:
# calling @new unkno...
Vladimir Tsichevski
08:24 AM Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
Greg Shah
07:55 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
7199b/14533 was merged to trunk rev 14528 and archived. Constantin Asofiei
08:23 AM Bug #7243 (Closed): collision between YEAR function and a perm table abbreviated name
Greg Shah
07:55 AM Bug #7243: collision between YEAR function and a perm table abbreviated name
7199b/14533 was merged to trunk rev 14528 and archived. Constantin Asofiei
08:23 AM Bug #7240 (Closed): conversion problem related to ENTERED in a IF expr
Greg Shah
07:55 AM Bug #7240: conversion problem related to ENTERED in a IF expr
7199b/14533 was merged to trunk rev 14528 and archived. Constantin Asofiei

04/06/2023

10:46 AM Feature #4065: server-side processing of client platform dependencies
Greg/Hynek: for server-side memptrs, we still have the problem when the memory address is incoming from a OS library ... Constantin Asofiei

04/05/2023

04:04 PM Bug #7250 (Test): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
Code Review Task Branch 7199b Revision 14529
No objection.
Greg Shah
04:02 PM Bug #7243 (Test): collision between YEAR function and a perm table abbreviated name
Code Review Task Branch 7199b Revision 14526
No objection.
Greg Shah
03:55 PM Bug #7240 (Test): conversion problem related to ENTERED in a IF expr
Greg Shah
03:55 PM Bug #7240: conversion problem related to ENTERED in a IF expr
Code Review Task Branch 7199b Revisions 14524, 14527 and 14528
No objections.
Greg Shah
03:42 PM Feature #4065: server-side processing of client platform dependencies
In regard to the shell commands, I think it is OK if we require that the commands meet one of these criteria:
* It...
Greg Shah
02:51 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
In 4GL, the CPINTERNAL attribute is rather a constant than a variable. It is configured when the application is execu... Ovidiu Maxiniuc
12:37 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
I think we have this same problem for all of our I18N tests, many of which still need to be written.
> Because it...
Greg Shah
10:57 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
I've hit a wall here, as I misunderstood some Progress behaviour. During my initial exploration on the OpenEdge syste... Joe Davis
12:51 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
We have a customer that needs to be able to set UTF-8 or CP963 as the @CPINTERNAL@. We may have some problems with d... Greg Shah
12:43 PM Bug #4766: fix CHR and ASC
What is left to do in this task? Please note that in #6428 Joe is fixing an issue related to lead-byte processing in... Greg Shah
10:17 AM Feature #6425: SESSION handle features
I created some tests under @testcases/session/session_features.p@. Please review. Theodoros Theodorou
07:01 AM Feature #6410: implement additional built-in OO classes/interfaces
Greg Shah wrote:
> Marian: Please summarize the current level of conversion support for all of the classes #6410-1. ...
Marian Edu

04/04/2023

03:43 PM Feature #4065 (Review): server-side processing of client platform dependencies
Hynek Cihlar
03:42 PM Feature #4065: server-side processing of client platform dependencies
The server-side shell execution will require more thought. For the file system it is straightforward to get a canonic... Hynek Cihlar
03:38 PM Feature #4065: server-side processing of client platform dependencies
4065a revision 14527 implements server side file-system and file-based stream (based on @FileStream@ and @DirStream@)... Hynek Cihlar
12:37 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
Greg Shah wrote:
> No, you haven't missed anything. See #3827. The related code in 3827a is close to merging to tr...
Vladimir Tsichevski
11:50 AM Feature #6411 (Closed): LOB-DIR I/O option support
3821c replaced trunk in trunk revision 14472 (we copied over trunk with 3821c rev 14472). Greg Shah
11:28 AM Feature #6411: LOB-DIR I/O option support
Greg Shah wrote:
> In what revision of trunk can these changes be found?
>
It was in last commit of the @3821c@...
Eugenie Lyzenko
10:55 AM Feature #6411: LOB-DIR I/O option support
In what revision of trunk can these changes be found?
Are there any open items?
Greg Shah
10:36 AM Feature #6411 (Review): LOB-DIR I/O option support
Eugenie Lyzenko
10:36 AM Feature #6411 (WIP): LOB-DIR I/O option support
Eugenie Lyzenko
10:24 AM Feature #6411: LOB-DIR I/O option support
Greg Shah wrote:
> Didn't we implement this recently?
Yes, we did.
Eugenie Lyzenko
10:19 AM Feature #6411: LOB-DIR I/O option support
Didn't we implement this recently? Greg Shah
10:33 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian: Please summarize the current level of conversion support for all of the classes #6410-1. We need all of thes... Greg Shah
10:08 AM Feature #6300 (Closed): class definitions with USE-WIDGET-POOL
Greg Shah
09:56 AM Bug #7250 (Review): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
I've fixed this in 7199b/14529 Constantin Asofiei
09:33 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
Greg Shah wrote:
> The warning is because the code as written is useless.
It's not entirely useless - the customer'...
Constantin Asofiei
09:15 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
The warning is because the code as written is useless. The user will go into edit mode, make changes and then the cha... Greg Shah
09:04 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
There is a weird behavior in OpenEdge. This test:... Constantin Asofiei
09:02 AM Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
Constantin Asofiei
06:56 AM Feature #6425: SESSION handle features
Theodoros Theodorou wrote:
> The task is ready for review. Should I also create a test in testcases?
Yes, please do.
Greg Shah
03:18 AM Bug #7240: conversion problem related to ENTERED in a IF expr
Another issue is related to @frame f1 ... not entered@ version - the fix is in 7199b/14528. Constantin Asofiei

04/03/2023

05:09 PM Feature #6425: SESSION handle features
The task is ready for review. Should I also create a test in testcases? Theodoros Theodorou
05:06 PM Feature #6425 (Review): SESSION handle features
Theodoros Theodorou
04:53 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Vladimir Tsichevski wrote:
> Igor, would you take a look at #7247, please. I think, both issues are closely related....
Igor Skornyakov
04:43 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor, would you take a look at #7247, please. I think, both issues are closely related. Vladimir Tsichevski
04:50 PM Bug #7247: Dataset:READ-XML does nothing
Vladimir Tsichevski wrote:
> The test case is:
> [...]
>
> The test compiles and runs OK. But in FWD the @READ-X...
Igor Skornyakov
04:40 PM Bug #7247: Dataset:READ-XML does nothing
The test case is:... Vladimir Tsichevski
04:36 PM Bug #7247 (Closed): Dataset:READ-XML does nothing
Vladimir Tsichevski
04:22 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> I think the solution would be in literals.rules on line 371:
> to add a @!(isNote("wrap...
Vladimir Tsichevski
10:34 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> It means they are added by the parser. I assume you see other @byrule-@ annotations i...
Vladimir Tsichevski
09:34 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
>
> > OTOH, we should find who sets the @wrap@ annotation ...
Constantin Asofiei
09:31 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> OTOH, we should find who sets the @wrap@ annotation for the literal - did you convert ...
Vladimir Tsichevski
09:12 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
The repo 7184a was created for the fix, and the regression test task #7245. Vladimir Tsichevski
02:45 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
No, you haven't missed anything. See #3827. The related code in 3827a is close to merging to trunk. Vladimir is wr... Greg Shah
02:39 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
I had misread the current docs, and didn't use ABLUnit for tests (instead writing standalone tests). I'm in the proce... Joe Davis
06:11 AM Feature #3853: implement LOG-MANAGER runtime
@LOG-ENTRY-TYPES@ and @LOGGING-LEVEL@ are @LOG-MANAGER@ attributes that can be changed in the internal procedure runn... Galya B
05:34 AM Feature #3853: implement LOG-MANAGER runtime
Appservers have the following logging configs in OE Explorer:
* srvrLogFile - by default @{WorkPath}\%appservername%...
Galya B
03:47 AM Feature #3853: implement LOG-MANAGER runtime
Answering to #5753#note-113 :
Constantin Asofiei wrote:
> From this, we know:
> * changing @LOGFILE-NAME@ does n...
Galya B
01:41 AM Bug #7240: conversion problem related to ENTERED in a IF expr
The fix is in 7199b/14527 Constantin Asofiei

04/02/2023

03:41 PM Bug #7240: conversion problem related to ENTERED in a IF expr
There is another issue related to INPUT/ENTERED - fields need to be treated the same way as vars in @input_functions.... Constantin Asofiei

03/31/2023

06:21 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
> but without knowing why that check was there in the first place I'd be hesitant to remove it.
If I recall correc...
Greg Shah
05:24 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
Summary of findings for today:
* I've confirmed that @character.chr@ behaves differently to Progress' @CHR@ for mu...
Joe Davis
12:26 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
Good work, yes this makes sense. Greg Shah
03:02 PM Bug #7243 (Review): collision between YEAR function and a perm table abbreviated name
The fix is in 7199b/14526. Constantin Asofiei
01:57 PM Bug #7243 (WIP): collision between YEAR function and a perm table abbreviated name
Constantin Asofiei
01:55 PM Bug #7243: collision between YEAR function and a perm table abbreviated name
The patch for this seems to be:... Constantin Asofiei
01:36 PM Bug #7243: collision between YEAR function and a perm table abbreviated name
This test fails to convert:... Constantin Asofiei
01:35 PM Bug #7243 (Closed): collision between YEAR function and a perm table abbreviated name
Constantin Asofiei
11:51 AM Bug #7240 (Review): conversion problem related to ENTERED in a IF expr
The fix is in 7199b/14524 Constantin Asofiei
03:19 AM Bug #7240: conversion problem related to ENTERED in a IF expr
The recreate is this:... Constantin Asofiei
03:19 AM Bug #7240 (Closed): conversion problem related to ENTERED in a IF expr
Constantin Asofiei
07:53 AM Feature #4065: server-side processing of client platform dependencies
From email:
>>> Hynek wrote:
>>>
>>> I meant the loading resources for the UI (icons, bitmaps). I got your point...
Greg Shah
07:22 AM Feature #4065: server-side processing of client platform dependencies
> what do you think?
I think this is a discussion that is unrelated to this task. Yes, we probably have a bug in ...
Greg Shah
07:15 AM Feature #4065: server-side processing of client platform dependencies
> but server-side processing is required only by legacy streams (used by INPUT/OUTPUT statements) and other cases whe... Greg Shah
03:08 AM Feature #4065: server-side processing of client platform dependencies
Roger Borrello wrote:
> I have a question about this task... In #4938-52 I need to configure the web client such tha...
Hynek Cihlar

03/30/2023

03:09 PM Feature #4065: server-side processing of client platform dependencies
I have a question about this task... In #4938-52 I need to configure the web client such that we have this in the dir... Roger Borrello
01:15 PM Feature #4065: server-side processing of client platform dependencies
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, see #4065-59 and the related where we discussed thi...
Hynek Cihlar
11:16 AM Feature #4065: server-side processing of client platform dependencies
Hynek Cihlar wrote:
> Constantin, see #4065-59 and the related where we discussed this.
OK, but when server-side st...
Constantin Asofiei
03:12 AM Feature #4065: server-side processing of client platform dependencies
Constantin Asofiei wrote:
> Greg, correct me if I'm wrong, but server-side processing is required only by legacy str...
Hynek Cihlar
03:08 AM Feature #4065: server-side processing of client platform dependencies
Greg, correct me if I'm wrong, but server-side processing is required only by legacy streams (used by INPUT/OUTPUT st... Constantin Asofiei
03:02 AM Feature #4065: server-side processing of client platform dependencies
Constantin Asofiei wrote:
> From Hynek via email:
> > Changing the direct IO in the client process to go through a ...
Hynek Cihlar
02:59 AM Feature #4065: server-side processing of client platform dependencies
From Hynek via email:
> Changing the direct IO in the client process to go through a remoted object on the server wi...
Constantin Asofiei
02:25 AM Feature #4065: server-side processing of client platform dependencies
I rebased 4065a against trunk revision 14520. Hynek Cihlar
12:33 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
Here's a short summary of findings from today, I'll follow up with a status update shortly.
Greg Shah wrote:
> ...
Joe Davis
02:40 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
Roughly, this seems right.
# Before you go very far, please implement the 4GL testcase(s) to ensure we understand ...
Greg Shah
11:39 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> # convert (wrap) values to the expected type is cases the usage requires it (to use val...
Constantin Asofiei
11:34 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> I think the solution would be in literals.rules on line 371:
> [...]
> to add a @!(isN...
Vladimir Tsichevski
11:20 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
I think the solution would be in literals.rules on line 371:... Constantin Asofiei
07:16 AM Feature #6497: add equivalent support for the -T command line option
The branch 6497a has been rebased to trunk 14521. The new rev no is 14526.
Please review it and let me know if I c...
Theodoros Theodorou
04:25 AM Feature #3853: implement LOG-MANAGER runtime
The tests Constantin did for #5701#note-86 made me think about the appserver agent logs.
The implementation in #57...
Galya B

03/29/2023

04:59 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
First time the literal is wrapped as a parameter in @expression.rules@:... Vladimir Tsichevski
03:17 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
If I remove the "wrap_parameter" annotation from the literal, both OO method and function calls convert correctly wit... Vladimir Tsichevski
02:28 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> > * we will need to regression test the conversion of the original app where this was ...
Constantin Asofiei
02:19 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> OK, lets back-track a little. Sorry I was so abrupt in the initial note, I was expectin...
Vladimir Tsichevski
12:41 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
OK, lets back-track a little. Sorry I was so abrupt in the initial note, I was expecting a pin-point fix, not a full... Constantin Asofiei
12:01 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> Vladimir Tsichevski wrote:
> > Constantin Asofiei wrote:
> > > There can be nested PLU...
Vladimir Tsichevski
11:53 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > There can be nested PLUS ASTs, with complex expression w...
Constantin Asofiei
11:51 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> There can be nested PLUS ASTs, with complex expression with or without STRING literal.
...
Vladimir Tsichevski
11:34 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Why did you remove the @descent-rules@ portion? There can be nested PLUS ASTs, with complex expression with or witho... Constantin Asofiei
11:30 AM Bug #7184 (Review): Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> Vladimir Tsichevski wrote:
> > Constantin Asofiei wrote:
> >
> > > * copy all annota...
Vladimir Tsichevski
11:00 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
>
> > * copy all annotations from @ref2@ to the @ref@ AST
...
Constantin Asofiei
10:58 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> * copy all annotations from @ref2@ to the @ref@ AST
Is there a nice way to do this ...
Vladimir Tsichevski
10:56 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> Seems, we need to transfer the annotations from the @PLUS@ node, not from the first arg...
Constantin Asofiei
10:55 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> Vladimir Tsichevski wrote:
> > The question is which of 3 ways of *fixing* this problem...
Vladimir Tsichevski
10:41 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> The question is which of 3 ways of *fixing* this problem to choose? :-(
First, you nee...
Constantin Asofiei
10:33 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> Somewhere in TRPL (I think annotations) we transform this AST:
> [...]
> to this AST:
...
Vladimir Tsichevski
10:27 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Somewhere in TRPL (I think annotations) we transform this AST:... Constantin Asofiei
10:23 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> Please attach also the AST from the F2 phase (after parsing) and also the .cache for t...
Vladimir Tsichevski
10:18 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > What's the full AST for the method call @testMethod("asd...
Constantin Asofiei
10:17 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Constantin Asofiei wrote:
> What's the full AST for the method call @testMethod("asdf" + "qwerty").@?
I've attach...
Vladimir Tsichevski
10:12 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
What's the full AST for the method call @testMethod("asdf" + "qwerty").@? Constantin Asofiei
10:11 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
I need some help from TRPL gurus in deciding how to solve this issue. I see the following variants:
# explicitly c...
Vladimir Tsichevski
03:14 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
It's taken me a bit of time to grok the @Text@ class, and how ABL codepages correspond to JVM ones, but I believe I h... Joe Davis
06:19 AM Feature #6497: add equivalent support for the -T command line option
The branch 6497a has been rebased to trunk 14519. The new rev no is 14524. Theodoros Theodorou
02:29 AM Feature #6497: add equivalent support for the -T command line option
Theodoros Theodorou wrote:
> Please review (6497a/14502)
Looks good, thanks.
Constantin Asofiei

03/28/2023

07:38 PM Bug #7184 (WIP): Incorrect conversion of concatenated string literals to a LONGCHAR
In the course of string literal concatenation the original annotation info is lost.
Here is how a string literal e...
Vladimir Tsichevski
10:21 AM Feature #6497: add equivalent support for the -T command line option
Please review (6497a/14502) Theodoros Theodorou
03:49 AM Feature #6497: add equivalent support for the -T command line option
Review for 6497a/14501:
* ClientCore, ClientParameters, StandardServer - please add history entries
* @Utils.getTmp...
Constantin Asofiei
02:54 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
This task is to implement the runtime support for @IS-LEAD-BYTE()@. Conversion support is already complete (search o... Greg Shah

03/27/2023

04:08 PM Feature #6497: add equivalent support for the -T command line option
Please review again (6497a/14501) Theodoros Theodorou
11:59 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Fixed READ-JSON for static DATA-SET with NESTED/FOREIGN-KEY-HIDDEN relations.
Committed to 7193a/14508.
Working i...
Igor Skornyakov
04:19 AM Bug #7202 (Closed): 'accum' frame-level widget can have widget options
Greg Shah
04:18 AM Bug #7203 (Closed): INIT clause for datetime var copied from 'like' phrase
Greg Shah
04:18 AM Bug #7204 (Closed): method overload with dataset/temp-table parameters uses the index at the para...
Greg Shah
04:18 AM Bug #7206 (Closed): shared frame defined with the same name but different widgets
Greg Shah
04:18 AM Bug #7215 (Closed): 'display v @ ch' - v gets added to the ch's frame
Greg Shah
03:37 AM Feature #4382 (Closed): implement configurable directory override for PROGRESS global variable
Greg Shah
03:36 AM Feature #6421 (Closed): finish GENERATE-RANDOM-KEY support
Greg Shah

03/26/2023

01:15 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
I'm working now on READ-JSON for relations with FOREIGN-KEY-HIDDEN.
Please note that the support for this is broken ...
Igor Skornyakov

03/25/2023

08:53 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Fixed source validation for READ-JSON to work with MEMPTR, LONGCHAR and FILE for TEMP-TABLE and rejects STREAM as a s... Igor Skornyakov
03:43 AM Feature #6497: add equivalent support for the -T command line option
In other words, @defaultFwdTempFolder@ needs to be used in both cases, implicit temp folder and explicit '-T' folder;... Constantin Asofiei
03:21 AM Feature #6497: add equivalent support for the -T command line option
Theodoros, this is the review for 6497a/14500:
* please add history entries and javadoc for all new methods or param...
Constantin Asofiei

03/24/2023

03:51 PM Feature #6497: add equivalent support for the -T command line option
Kind reminder for a review Theodoros Theodorou
12:42 PM Bug #7202: 'accum' frame-level widget can have widget options
7199a was merged to trunk rev 14514 and archived. Constantin Asofiei
12:42 PM Bug #7203: INIT clause for datetime var copied from 'like' phrase
7199a was merged to trunk rev 14514 and archived. Constantin Asofiei
12:42 PM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
7199a was merged to trunk rev 14514 and archived. Constantin Asofiei
12:42 PM Bug #7206: shared frame defined with the same name but different widgets
7199a was merged to trunk rev 14514 and archived. Constantin Asofiei
12:42 PM Bug #7215: 'display v @ ch' - v gets added to the ch's frame
7199a was merged to trunk rev 14514 and archived. Constantin Asofiei
10:19 AM Feature #4382: implement configurable directory override for PROGRESS global variable
4382a was merged to trunk as revision 14510. It was archived. Theodoros Theodorou
06:44 AM Feature #4382: implement configurable directory override for PROGRESS global variable
4382a has been rebased to trunk 14509 Theodoros Theodorou
10:00 AM Feature #6421: finish GENERATE-RANDOM-KEY support
6421a was merged to trunk as revision 14509. It was archived. Theodoros Theodorou

03/23/2023

02:22 PM Feature #6421: finish GENERATE-RANDOM-KEY support
Thanks, go ahead with merging 6421a to trunk. Please follow the merge steps in #7027-48 Constantin Asofiei
02:18 PM Feature #6421: finish GENERATE-RANDOM-KEY support
Done Theodoros Theodorou
01:59 PM Feature #6421: finish GENERATE-RANDOM-KEY support
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > SecurityOps is missing a history number, like this:
> > [.....
Constantin Asofiei
01:58 PM Feature #6421: finish GENERATE-RANDOM-KEY support
Constantin Asofiei wrote:
> SecurityOps is missing a history number, like this:
> [...]
I do believe that saying...
Igor Skornyakov
01:53 PM Feature #6421: finish GENERATE-RANDOM-KEY support
SecurityOps is missing a history number, like this:... Constantin Asofiei
01:49 PM Feature #6421: finish GENERATE-RANDOM-KEY support
6421a has been rebased to trunk 14508 Theodoros Theodorou
12:42 PM Feature #6421 (Review): finish GENERATE-RANDOM-KEY support
I've uncommitted rev 14509 from trunk. Let's follow the normal process. Greg Shah
12:39 PM Feature #6421: finish GENERATE-RANDOM-KEY support
I noticed that in my branch 6421a I have accidentally pushed changes from another task and, therefore I recreated the... Theodoros Theodorou

03/22/2023

11:01 AM Feature #3853: implement LOG-MANAGER runtime
Note: To check if entry types are case-sensitive in configs. Galya B
08:59 AM Bug #7204 (Test): method overload with dataset/temp-table parameters uses the index at the parame...
Greg Shah
04:16 AM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
Greg Shah wrote:
> Code Review Task Branch 7199a Revision 14509
>
> In @schema.g@ line 1073, please change the na...
Constantin Asofiei
08:58 AM Bug #7203 (Test): INIT clause for datetime var copied from 'like' phrase
Greg Shah
04:13 AM Bug #7203: INIT clause for datetime var copied from 'like' phrase
Greg Shah wrote:
> Code Review Task Branch 7199a Revision 14508
>
> In @schema.g@, on line 1703, isn't @content.g...
Constantin Asofiei
08:58 AM Bug #7202 (Test): 'accum' frame-level widget can have widget options
Greg Shah
03:58 AM Bug #7202: 'accum' frame-level widget can have widget options
Greg Shah wrote:
> In regard to the @accumulate.rules@ change, what is the @display count with frame f1.@ supposed t...
Constantin Asofiei

03/21/2023

07:21 PM Bug #7202: 'accum' frame-level widget can have widget options
Code Review Task Branch 7199a Revision 14512
Overall I don't have an objection.
In regard to the @accumulate....
Greg Shah
11:33 AM Bug #7202 (Review): 'accum' frame-level widget can have widget options
This is fixed in 7199a rev 14512. Constantin Asofiei
06:32 PM Bug #7206 (Test): shared frame defined with the same name but different widgets
Code Review Task Branch 7199a Revision 14511
No objections.
Greg Shah
11:25 AM Bug #7206 (Review): shared frame defined with the same name but different widgets
This is fixed in 7199a rev 14511. Constantin Asofiei
03:46 PM Bug #7215 (Test): 'display v @ ch' - v gets added to the ch's frame
Greg Shah
03:46 PM Bug #7215: 'display v @ ch' - v gets added to the ch's frame
Code Review Task Branch 7199a Revision 14510
This one is tough to evaluate. On the surface, I want the added bypa...
Greg Shah
11:18 AM Bug #7215 (Review): 'display v @ ch' - v gets added to the ch's frame
This is fixed in 7199a rev 14510. Constantin Asofiei
03:29 PM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
Code Review Task Branch 7199a Revision 14509
In @schema.g@ line 1073, please change the name of @if@ to something ...
Greg Shah
11:10 AM Bug #7204 (Review): method overload with dataset/temp-table parameters uses the index at the para...
This is fixed in 7199a rev 14509. Constantin Asofiei
03:18 PM Bug #7203: INIT clause for datetime var copied from 'like' phrase
Code Review Task Branch 7199a Revision 14508
In @schema.g@, on line 1703, isn't @content.getType() == STRING@ alwa...
Greg Shah
11:06 AM Bug #7203 (Review): INIT clause for datetime var copied from 'like' phrase
This is fixed in 7199a/14508 Constantin Asofiei
11:43 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
Greg Shah wrote:
> Do you want to put this into 7199a instead?
No.
> Should we set this to Review?
There is more ...
Constantin Asofiei
11:36 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
Do you want to put this into 7199a instead?
Should we set this to Review?
Greg Shah

03/20/2023

03:03 PM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
Another issue is that the index name must be part of the signature. Constantin Asofiei
08:20 AM Feature #6497: add equivalent support for the -T command line option
Yes, it matches the 4GL behavior Theodoros Theodorou
06:50 AM Feature #6497: add equivalent support for the -T command line option
Does it match the 4GL behavior?
Constantin: Please review.
Greg Shah
07:10 AM Feature #6425: SESSION handle features
We are working on the initial creation of our CI/CD environment but it is going to take some weeks before it is in pl... Greg Shah
05:04 AM Bug #7215 (WIP): 'display v @ ch' - v gets added to the ch's frame
In this testcase, 'v' gets added to frame f1, and @input v@ will resolve it from frame f1, instead of frame f2.
<pre...
Constantin Asofiei
05:03 AM Bug #7215 (Closed): 'display v @ ch' - v gets added to the ch's frame
Constantin Asofiei

03/18/2023

02:58 AM Bug #7202 (WIP): 'accum' frame-level widget can have widget options
Constantin Asofiei

03/17/2023

01:27 PM Bug #7206: shared frame defined with the same name but different widgets
A recreated bug is this:
* first program defines a shared frame but it doesn't use it:...
Constantin Asofiei
01:13 PM Bug #7206: shared frame defined with the same name but different widgets
The example programs for this task are incorrect: they both give @This ** Shared frame f1 field v1 must first appear ... Constantin Asofiei
10:39 AM Bug #7206 (WIP): shared frame defined with the same name but different widgets
Greg Shah wrote:
> Is the issue that we need a 2nd frame or just that we are incorrectly using the frame?
I'm not s...
Constantin Asofiei
09:14 AM Bug #7206: shared frame defined with the same name but different widgets
Is the issue that we need a 2nd frame or just that we are incorrectly using the frame? Greg Shah
12:52 PM Feature #6425: SESSION handle features
I am doing some modifications in the java method @message()@. Is there a way to check that I haven't broken anything? Theodoros Theodorou
05:35 AM Bug #7204 (WIP): method overload with dataset/temp-table parameters uses the index at the paramet...
Constantin Asofiei
05:34 AM Bug #7203 (WIP): INIT clause for datetime var copied from 'like' phrase
Constantin Asofiei

03/16/2023

07:00 AM Bug #7206: shared frame defined with the same name but different widgets
You can have the same @f1@ shared frame defined in two programs, but with different widgets:
* program A:...
Constantin Asofiei
06:59 AM Bug #7206 (Closed): shared frame defined with the same name but different widgets
Constantin Asofiei
06:24 AM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
This class defines two @m1@ methods, and a single @dataset@ parameter. The temp-tables are the same, except @tt1@ ha... Constantin Asofiei
06:23 AM Bug #7204 (Closed): method overload with dataset/temp-table parameters uses the index at the para...
Constantin Asofiei
06:11 AM Bug #7203: INIT clause for datetime var copied from 'like' phrase
This testcase shows two problems:... Constantin Asofiei
06:09 AM Bug #7203 (Closed): INIT clause for datetime var copied from 'like' phrase
Constantin Asofiei
06:08 AM Bug #7202: 'accum' frame-level widget can have widget options
This testcase shows that a 'accum' frame widget can have widget options:... Constantin Asofiei
06:06 AM Bug #7202 (Closed): 'accum' frame-level widget can have widget options
Constantin Asofiei
02:07 AM Bug #7193 (WIP): READ-JSON is not supported for the "LONGCHAR" source type
Created task branch 7193a from the trunk. Igor Skornyakov

03/15/2023

01:38 PM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
Greg Shah wrote:
> I thought we already handled this at one point.
I thought so, too, but the only thing I found wa...
Constantin Asofiei
12:53 PM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
I thought we already handled this at one point. Greg Shah
12:40 PM Bug #7198 (WIP): conversion of empty UPDATE/SET/PROMPT-FOR statements
Created task branch 7198a from trunk rev 14506.
7198a/14507 fixes this for UPDATE/SET/PROMPT-FOR. We need to test...
Constantin Asofiei
11:42 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
Empty @UPDATE.@, @SET.@ or @PROMPT-FOR.@ statements seem to be a no-op in OE. FWD fails at conversion phase.
Test...
Constantin Asofiei
11:39 AM Bug #7198 (Test): conversion of empty UPDATE/SET/PROMPT-FOR statements
Constantin Asofiei
01:32 PM Bug #7200: fix INIT and LABEL for LIKE defined fields or variables
Testcases are checked into old testcases and attached.
Interestingly, the code using the fields as the "model" (@i...
Roger Borrello
01:19 PM Bug #7200 (New): fix INIT and LABEL for LIKE defined fields or variables
Roger Borrello
12:52 PM Feature #6425: SESSION handle features
Hmmm, it requires ChUI.
> I noticed that the progress developer studio (eclipse) opens a different window on the...
Greg Shah
11:32 AM Feature #6425: SESSION handle features
I usually use the VM1. Today I used VM2 because the VM1 was occupied. I tried to run... Theodoros Theodorou

03/14/2023

04:52 PM Feature #6497 (Review): add equivalent support for the -T command line option
I implemented the following functionality:
If a temp directory is is explicitly provided, then I check if it is in...
Theodoros Theodorou
09:52 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Greg Shah wrote:
> Then we must already have testcases that fail. Point us to the code that fails.
The attached ...
Igor Skornyakov
09:36 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Are these testcases checked in to the [[p2j:Testcases]] project? (thi...
Greg Shah
09:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
That is OK if they fail. We should fix this now. Greg Shah
09:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Greg Shah wrote:
> Are these testcases checked in to the [[p2j:Testcases]] project? (this is a question for both of ...
Igor Skornyakov
09:30 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Greg Shah wrote:
> Are these testcases checked in to the [[p2j:Testcases]] project? (this is a question for both of ...
Vladimir Tsichevski
09:26 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Are these testcases checked in to the [[p2j:Testcases]] project? (this is a question for both of you) Greg Shah
07:31 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> Actually READ-JSON is not supported for "file" source type as well.
> For TEMP-TABLE it ex...
Vladimir Tsichevski
07:23 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Actually READ-JSON is not supported for "file" source type as well.
For TEMP-TABLE it explicitly reports error 19079...
Igor Skornyakov
07:04 AM Bug #7193 (Closed): READ-JSON is not supported for the "LONGCHAR" source type
Vladimir Tsichevski

03/13/2023

04:06 PM Feature #6497: add equivalent support for the -T command line option
> Also, when @-T@ is set, there must be a check if this folder really exists - if it doesn't exist, log a message and... Theodoros Theodorou
03:37 PM Feature #6497: add equivalent support for the -T command line option
... Theodoros Theodorou
08:47 AM Feature #6497: add equivalent support for the -T command line option
> Greg, another idea: we automatically create this root folder if it doesn't exist. Also, permissions should be chec... Greg Shah
 

Also available in: Atom