Activity
From 04/02/2023 to 05/01/2023
05/01/2023
- 06:04 PM Bug #7317 (Test): accumulator using another accumulator as expression
- Code review 7199c/14566: the changes look good. This should go into wider testing.
- 04:44 PM Bug #7317: accumulator using another accumulator as expression
- Eric: Please review.
- 06:57 AM Bug #7317 (Review): accumulator using another accumulator as expression
- 4GL allows an accumulator function to be used in the expression of an accumulator statement:...
- 06:48 AM Bug #7317 (Closed): accumulator using another accumulator as expression
- 04:35 PM Bug #7316 (Test): regression in 'ACCUM ... extVar' expansion - subscript not emitted
- Code Review Task Branch 7199c Revision 14565
No objections. - 06:47 AM Bug #7316 (Review): regression in 'ACCUM ... extVar' expansion - subscript not emitted
- This test:...
- 06:38 AM Bug #7316 (Closed): regression in 'ACCUM ... extVar' expansion - subscript not emitted
- 04:31 PM Bug #7315 (Test): unknown literal passed as an argument to a 'object' parameter
- Code Review Task Branch 7199c Revision 14564
No objections. - 06:35 AM Bug #7315 (Review): unknown literal passed as an argument to a 'object' parameter
- This case:...
- 06:31 AM Bug #7315 (Closed): unknown literal passed as an argument to a 'object' parameter
- 04:23 PM Bug #7314 (Test): conversion issue for FIRST-OF(f1) when there is a collision between the field n...
- Code Review Task Branch 7199c Revision 14563
No objections. - 06:30 AM Bug #7314: conversion issue for FIRST-OF(f1) when there is a collision between the field name and...
- Fixed in 7199c rev 14563.
- 06:30 AM Bug #7314 (Review): conversion issue for FIRST-OF(f1) when there is a collision between the field...
- The problem is described by this test:...
- 06:26 AM Bug #7314 (Closed): conversion issue for FIRST-OF(f1) when there is a collision between the field...
- 04:18 PM Bug #7313 (Test): regression in '<record-phrase> USING FRAME f field'
- Code Review Task Branch 7199c Revision 14562
No objections. - 06:23 AM Bug #7313 (Review): regression in '<record-phrase> USING FRAME f field'
- A @find tt1 using frame f1 tt1.f1@ was refactoring the @frame f1 tt1.f1@ to an @INPUT@ function, which is done separa...
- 06:20 AM Bug #7313 (Closed): regression in '<record-phrase> USING FRAME f field'
- 04:14 PM Bug #7312 (Test): mtime(character) is allowed in 4GL
- Code Review Task Branch 7199c Revision 14561
No objections. - 06:18 AM Bug #7312 (Review): mtime(character) is allowed in 4GL
- @mtime(character)@ will raise a @Unacceptable datatype for MTIME argument. 12117@ ERROR condition.
Committed to 71... - 06:15 AM Bug #7312 (Closed): mtime(character) is allowed in 4GL
- 04:11 PM Bug #7311 (Test): abs(integer) must return int64
- Code Review Task Branch 7199c Revision 14560
No objections. - 06:14 AM Bug #7311 (Review): abs(integer) must return int64
- ...
- 05:58 AM Bug #7311 (Closed): abs(integer) must return int64
- 04:07 PM Bug #7310 (Test): buffer scope in constructor/destructor is not computed correctly
- Code Review Task Branch 7199c Revision 14558
No objections. - 05:52 AM Bug #7310 (Review): buffer scope in constructor/destructor is not computed correctly
- The fix is in 7199c/14558
- 04:23 AM Bug #7310: buffer scope in constructor/destructor is not computed correctly
- The issue is when there is an explicit buffer defined with the same name as a buffer in a constructor or destructor:
... - 04:21 AM Bug #7310 (Closed): buffer scope in constructor/destructor is not computed correctly
- 03:48 PM Bug #7308 (Test): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, wh...
- Code Review Task Branch 7199c Revision 14557
No objections. - 05:49 AM Bug #7308 (Review): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, ...
- The fix is in 7199c rev 14557
- 12:38 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > So when @invokeFailure@ is reached you know that this is a c... - 12:36 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Constantin Asofiei wrote:
> So when @invokeFailure@ is reached you know that this is a case of an external program.
... - 12:31 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Galya, @invokeFailure@ is ever only called for a failure of a @RUN externalprogram.p@ statement; it never gets called...
- 12:21 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- On line 7159 in @ControlFlowOps.invokeImpl@ the error is to be displayed with @invokeFailure(name)@:...
- 11:57 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Constantin Asofiei wrote:
> I think it may be possible to disable silent error processing in @ControlFlowOps.invokeF... - 11:32 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Galya Bogdanova wrote:
> This should not be considered @silent@ in FWD - it should display an alert and fill in ER... - 11:31 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Constantin Asofiei wrote:
> Regarding #7272-16 - please solve also the missing alert - if with NO-ERROR OpenEdge sti... - 11:24 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Galya Bogdanova wrote:
> > > I believe the stop condition is always raised. @must not show@ message is never shown i... - 11:20 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > Constantin Asofiei wrote:
> > > Galya, please focus on @Con... - 11:19 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Constantin Asofiei wrote:
> * properly add the error message to ERROR-STATUS and also display it.
Just to make it... - 11:17 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > Galya, please focus on @ControlFlowOps.invokeFailure@ - the ... - 11:16 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Constantin Asofiei wrote:
> Galya, please focus on @ControlFlowOps.invokeFailure@ - the problem is there, we need to... - 11:07 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Galya, please focus on @ControlFlowOps.invokeFailure@ - the problem is there, we need to adjust that code to:
* keep... - 11:06 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- I think the issue is in the converted code that considers it a silent invokation:...
- 10:20 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- I'll focus on 1. for this task. Starting to debug.
- 10:15 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Check the diff in batch output redirect files in the attached diff file, shown here as an image:
!OE-vs-FWD-batch-ou... - 09:43 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Complete test results for the procedure in #7272#note-7:
*1.* executed as batch in Progress results in this output... - 08:26 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Constantin, I'm testing it now. I just wanted to make clear it's not related to the above mentioned change.
- 08:24 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Galya, this is not a bug related to your changes. This is an existing bug which we need to fix; please see this test...
- 07:57 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- Constantin Asofiei wrote:
> Also, with 5753d, @ControlFlowOps.invokeFailure@ was changed from this:
> [...]
> to t... - 10:11 AM Bug #7206: shared frame defined with the same name but different widgets
- The fix for this 'unused shared frame' must apply to @NEW SHARED@ frames, too. Fixed in 7199c/14567
- 06:33 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- > If you believe that we have to reproduce the quirks mentioned above I suggest to deeal with it in sce scope of #724...
- 05:57 AM Feature #6410: implement additional built-in OO classes/interfaces
- 7199c rev 14559 contains the implementation for @OpenEdge.Core.System.ArgumentError@. Required by #7199
- 05:16 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- 7250a changes were committed to 7199c rev 14556.
7250a was dead-archived. - 05:14 AM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- 7304a changes were committed to 7199c rev 14555.
7304a was dead-archived. - 05:11 AM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- Greg Shah wrote:
> It seems that this logic may be broken if the @recordName@ is a qualified name. Otherwise I have... - 04:50 AM Bug #7240: conversion problem related to ENTERED in a IF expr
- Constantin Asofiei wrote:
> Another case somehow related to #7178 - @tt1.f1 [not] entered@ must not produce a buffe...
04/29/2023
- 06:05 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> Implemented DATA-SET:WRITE-XMLSCHEMA with SERIALIZE-HIDDEN = true.
> Committed to 7193a/1...
04/28/2023
- 04:11 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Implemented DATA-SET:WRITE-XMLSCHEMA with SERIALIZE-HIDDEN = true.
Committed to 7193a/14566.
This provides the ... - 11:31 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- > > I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now and then check t...
- 08:32 AM Feature #4065: server-side processing of client platform dependencies
- I think this discussion qualifies as defining the requirements for the "reduce package name text in stack trace outpu...
- 08:23 AM Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> I would hope that we can integrate these changes together without moving all logging work to Hyne... - 07:52 AM Feature #4065: server-side processing of client platform dependencies
- It is not uncommon for us to implement small changes to unrelated areas in tasks that are otherwise addressing a diff...
- 03:15 AM Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> The code doesn't matter. It's important so that we keep the product good. If it means you need... - 03:03 AM Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> Hynek Cihlar wrote:
> > The changes are so minimal that I don't see how it can cause issue... - 02:46 AM Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> The changes are so minimal that I don't see how it can cause issues during merging with your w... - 02:34 AM Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> Hynek Cihlar wrote:
> > @Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 145... - 01:18 AM Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> @Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 14563. Galya, please review.
... - 08:04 AM Bug #7308: 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, where v1 ...
- For function parameters, the LBRACKET is completely ignored. For procedure parameters, it works as a DEF VAR:...
- 07:38 AM Bug #7308: 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, where v1 ...
- This test works fine in 4GL:...
- 07:38 AM Bug #7308 (Closed): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, ...
- 07:06 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- I think that the table @_aud-audit-data@ holds the records only for the @SET-APPL-CONTEXT@ command. In progress docum...
- 04:52 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Theodoros Theodorou wrote:
> I found also some hidden tables regarding auditing: @_aud-*@. I tried to use @LOG-APP...
04/27/2023
- 04:17 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Hello Marian, I am trying to find the exact usage of the commands @LOG-AUDIT-EVENT@, @CLEAR-APPL-CONTEXT@ and @SET-AP...
- 01:41 PM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- Code Review Task Branch 7250a Revision 14553
No objections. - 01:10 PM Bug #7250 (Review): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- Branch 7250a was created trunk 14552.
The change in previous note is in rev 14553. - 07:46 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- There is another case related to PROMPT-FOR: when a record reference is used instead of individual fields. I'm testi...
- 01:40 PM Feature #4065: server-side processing of client platform dependencies
- @Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 14563. Galya, please review.
- 01:37 PM Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> The change related to the reduction of package names seems to be useful.
Wasn't a requirement ... - 01:35 PM Feature #4065: server-side processing of client platform dependencies
- The change related to the reduction of package names seems to be useful.
- 01:34 PM Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> Hynek, I will obviously have to resolve the conflicts caused by all the changes you do to l... - 01:33 PM Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> AFAIK Galya has successfully rebased with the logging changes. They are really minimal anyway ... - 01:32 PM Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> Let's ensure that they don't cause conflicts with the upcoming merge of 5703a.
AFAIK Galya has... - 01:28 PM Feature #4065: server-side processing of client platform dependencies
- Hynek, I will obviously have to resolve the conflicts caused by all the changes you do to logging and then delete the...
- 01:26 PM Feature #4065: server-side processing of client platform dependencies
- Let's ensure that they don't cause conflicts with the upcoming merge of 5703a.
Also, we definitely should be using... - 01:23 PM Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> Code Review Task branch 4065a Revisions 14560 through 14562
>
> No objections. Weren't the lo... - 10:45 AM Feature #4065: server-side processing of client platform dependencies
- Constantin Asofiei wrote:
> Review for 4065a rev 14527:
> * @HighLevelObject.LOG@ - we are replacing @java.util.log... - 10:33 AM Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> Galya: Please review the logging changes in rev 14560.
The changes are indeed unexpected. - 10:21 AM Feature #4065: server-side processing of client platform dependencies
- Code Review Task branch 4065a Revisions 14560 through 14562
No objections. Weren't the logging changes removed on... - 07:54 AM Feature #4065: server-side processing of client platform dependencies
- The points raised during the reviews are resolved in 4065a revision 14561. File history entries added in revision 145...
- 04:32 AM Feature #4065: server-side processing of client platform dependencies
- I rebased 4065a against the latest trunk.
- 12:28 PM Feature #6410: implement additional built-in OO classes/interfaces
- Branch 6410a has been branched from trunk 14552. I've pushed it to xfer (@/opt/fwd/6410a@).
04/26/2023
- 03:56 PM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- Code Review Task Branch 7301a Revision 14552
It seems that this logic may be broken if the @recordName@ is a quali... - 02:58 PM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- Code Review Task Branch 7304a Revision 14552
No objections. - 08:02 AM Bug #7304 (Review): UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- 7304a rev 14552 contains the implementation for the idea in note #7304-2.
- 07:51 AM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- Created task branch 7304a from trunk rev 14551.
- 02:30 AM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- I think in OpenEdge there is a runtime check if an expression argument is int64 instead of the integer parameter set ...
- 01:27 AM Bug #7304 (Closed): UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
- 12:04 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian: Please have your team review the documentation on method overloading in #3751-492 and look at the code in @oo...
- 07:52 AM Feature #4065: server-side processing of client platform dependencies
- > I agree this could be merged together under a file-system resource. Greg, what do you think?
Agreed. - 07:17 AM Feature #4065: server-side processing of client platform dependencies
- Constantin Asofiei wrote:
> Review for 4065a rev 14527:
> * @ConcurrentResource.resourceTypeName@ - the javadoc was... - 07:09 AM Feature #4065: server-side processing of client platform dependencies
- Review for 4065a rev 14527:
* @ConcurrentResource.resourceTypeName@ - the javadoc was indented right
* @HighLevelOb... - 05:14 AM Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> Code Review Task Branch 4065a Revisions 14521 through 14527
>
> Overall this is a really nice ...
04/25/2023
- 04:05 PM Feature #4065: server-side processing of client platform dependencies
- Constantin: Please review.
- 04:04 PM Feature #4065: server-side processing of client platform dependencies
- Code Review Task Branch 4065a Revisions 14521 through 14527
Overall this is a really nice update! I think the app... - 02:37 PM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- Created task branch 7301a from trunk rev 14551.
The patch in previous note is in rev 14552. - 09:51 AM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- The previous patch is not correct, it regresses this case:...
- 07:14 AM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- In pre-scan, no scope is pushed for top-level blocks (as we can't track them). This case fails to parse in pre-scan:...
- 07:06 AM Bug #7301 (Closed): pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
- 12:48 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- We convert compilable code, which this is. hIt is used heavily in a customer project so we need to get it right.
- 12:36 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin Asofiei wrote:
> Marian, we need more tests to determine how OE behaves in this case. The problem here i... - 12:27 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Greg Shah wrote:
> I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now ... - 12:24 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now and then check the t...
- 12:22 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Code Review Task Branch 7299a Revision 14551
No objections. - 07:19 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Created task branch 7299a from trunk rev 14550. The patch is in rev 14551. Greg, please review.
- 05:39 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin, will do... as a side note, imho this should not have been allowed in 4GL, it completely break any strong ...
04/24/2023
- 02:11 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian, we need more tests to determine how OE behaves in this case. The problem here is when there are multiple ove...
- 01:49 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- In #7261, this test was found to not work properly:...
- 01:48 PM Bug #7299 (Test): resolution of the target OO method in chained calls with poly arguments
- 12:57 PM Bug #7240: conversion problem related to ENTERED in a IF expr
- Another case somehow related to #7178 - @tt1.f1 [not] entered@ must not produce a buffer reference. A fix for this ...
- 10:45 AM Bug #5276: resolve issues with multi-byte character processing
- Status on this: I'm in the middle of converting @character.java@ to use @codePointAt@ instead of @charAt@ where appro...
04/21/2023
- 10:37 AM Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> The initial support was put in as branch 3821c revision 13885/13886.
Ah, I see... it should be... - 10:36 AM Feature #4065: server-side processing of client platform dependencies
- Constantin Asofiei wrote:
> When a 3821c revision is mentioned, that is a trunk revision. 3821c became trunk some ti... - 10:34 AM Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> Greg Shah wrote:
> > But you can look at the existing code for the model.
> If I don't kn... - 10:33 AM Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> But you can look at the existing code for the model.
If I don't know the revision, how do I know... - 10:32 AM Feature #4065: server-side processing of client platform dependencies
- The initial support was put in as branch 3821c revision 13885/13886.
Additional support is written in 4065a but ha... - 10:30 AM Feature #4065: server-side processing of client platform dependencies
- Galya Bogdanova wrote:
> There is no email @merge notification for task branch 4065@ and no comment which revision i... - 10:25 AM Feature #4065: server-side processing of client platform dependencies
- There is no email @merge notification for task branch 4065@ and no comment which revision it was on trunk. How do I f...
- 09:20 AM Feature #4065: server-side processing of client platform dependencies
- Thank you for the help. I'll find the configs now on trunk.
- 09:02 AM Feature #4065: server-side processing of client platform dependencies
- Take a look at the library manager support (or memptr) in trunk.
- 08:38 AM Feature #4065: server-side processing of client platform dependencies
- When a client process accesses the server, how do you know if its a local client (on the same host) or a remote one w...
04/20/2023
- 01:55 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- I've created a more complete test for inferring empty dynamic DATA-SET from JSON data w/o root element (#7193-27).
N... - 06:48 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Ovidiu Maxiniuc wrote:
> Review of 7193a/14544.
> * @AbstractTempTable.java@: please set the number in H entry (21)... - 05:12 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- The task branch 7193a was rebased to the trunk/14543.
Pushed up to revision 14551.
04/19/2023
- 04:13 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> As far as I understand the 7193a is not reabsed to lasterst trunk.
> > No, I've extracte... - 04:05 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Vladimir Tsichevski wrote:
> Igor Skornyakov wrote:
>
> > The @{ "Customer": [ { "customerName": "John Smith", "... - 03:53 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> The @{ "Customer": [ { "customerName": "John Smith", "customerNum": 10}, { "customerNam... - 03:48 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Ovidiu Maxiniuc wrote:
> Review of 7193a/14544.
>
> Good job! A lot of code with adjustments for existing feature... - 03:36 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Review of 7193a/14544.
Good job! A lot of code with adjustments for existing features. Here are some notes, most o... - 02:45 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Vladimir Tsichevski wrote:
> I am running OEUnit fixture test class:
>
> [...]
>
> In this class a fixture is ... - 02:20 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- I am running OEUnit fixture test class:...
04/18/2023
- 05:52 PM Feature #6422 (WIP): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- 11:02 AM Bug #7247: Dataset:READ-XML does nothing
- Created task branch 7247a.
- 09:58 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
- Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > > I think, the unit testing for the function can be done in the f... - 08:29 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
- Greg Shah wrote:
> > I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tes... - 08:25 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
- > I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tests at the Java level...
- 07:36 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Well, all tests passed.
Committed to 7193a/14544.
Please review.
Thank you. - 06:42 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > However these additional testes reveal a strange problem with W... - 04:47 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> However these additional testes reveal a strange problem with WRITE-XML for the PARENT-ID-R...
04/17/2023
- 04:11 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
- I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tests at the Java level, ...
- 11:22 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Fixed issues with READ-JSON for empty dynamic DATA-SET revealed by additional tests.
Committed to 7193a/14543.
Ho... - 03:32 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Just noticed.
When running the attached test I see multiple message like this...
04/16/2023
- 02:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> Added support for inferring empty dynamic DATA-SET from JSON data. Fixed support for PARENT...
04/15/2023
- 02:32 PM Bug #7247 (WIP): Dataset:READ-XML does nothing
- 02:31 PM Bug #7193 (Review): READ-JSON is not supported for the "LONGCHAR" source type
- Added support for inferring empty dynamic DATA-SET from JSON data. Fixed support for PARENT-ID-RELATION in WRITE-JSON...
- 12:19 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- I've encountered the following problem.
On inferring @DATA-SET@ from JSON data with @READ-JSON@ the @NESTED@ @DATA-R...
04/14/2023
- 01:02 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Inferring empty dynamic DATA-SET from JSON data is mostly finished.
Committed to 7193a/14539.
The tables looks th... - 09:02 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Please do the following:
* Review #6422 and the 4GL facilities it is intended to implement.
* Write testcases and... - 09:02 AM Feature #6420: implement the AUDIT-ENABLED() built-in function
- This is meant to report on whether the 4GL-compatible auditing support is activated. That means it is dependent upon...
04/13/2023
- 05:17 PM Feature #6420 (WIP): implement the AUDIT-ENABLED() built-in function
- 04:52 PM Feature #6420: implement the AUDIT-ENABLED() built-in function
- How should we implement this feature? Should we just add a flag into @directory/client.xml@ or should we replicate th...
04/12/2023
- 02:14 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- This bug already exists in trunk, it came up in a discussion when debugging a customer's application.
- 02:12 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- I mentioned 'log' in the title and previous entry, but this is also about displaying the error message to the user. ...
- 02:00 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
- This program:...
- 01:53 PM Bug #7272 (Closed): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
04/10/2023
- 10:53 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- This task isn't a priority right now.
- 10:49 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- Constantin Asofiei wrote:
> > # calling the @unknown.instantiateUnknown()@, this function just returns the @unknow... - 10:45 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- Vladimir Tsichevski wrote:
> I can take this task.
Greg?
> # calling @new unknown()@, we want to get rid of thi... - 10:02 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- I can take this task.
A question: currently there is 3 ways to obtain the @unknown@ value:
# calling @new unkno... - 08:24 AM Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- 07:55 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- 7199b/14533 was merged to trunk rev 14528 and archived.
- 08:23 AM Bug #7243 (Closed): collision between YEAR function and a perm table abbreviated name
- 07:55 AM Bug #7243: collision between YEAR function and a perm table abbreviated name
- 7199b/14533 was merged to trunk rev 14528 and archived.
- 08:23 AM Bug #7240 (Closed): conversion problem related to ENTERED in a IF expr
- 07:55 AM Bug #7240: conversion problem related to ENTERED in a IF expr
- 7199b/14533 was merged to trunk rev 14528 and archived.
04/06/2023
- 10:46 AM Feature #4065: server-side processing of client platform dependencies
- Greg/Hynek: for server-side memptrs, we still have the problem when the memory address is incoming from a OS library ...
04/05/2023
- 04:04 PM Bug #7250 (Test): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- Code Review Task Branch 7199b Revision 14529
No objection. - 04:02 PM Bug #7243 (Test): collision between YEAR function and a perm table abbreviated name
- Code Review Task Branch 7199b Revision 14526
No objection. - 03:55 PM Bug #7240 (Test): conversion problem related to ENTERED in a IF expr
- 03:55 PM Bug #7240: conversion problem related to ENTERED in a IF expr
- Code Review Task Branch 7199b Revisions 14524, 14527 and 14528
No objections. - 03:42 PM Feature #4065: server-side processing of client platform dependencies
- In regard to the shell commands, I think it is OK if we require that the commands meet one of these criteria:
* It... - 02:51 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
- In 4GL, the CPINTERNAL attribute is rather a constant than a variable. It is configured when the application is execu...
- 12:37 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
- I think we have this same problem for all of our I18N tests, many of which still need to be written.
> Because it... - 10:57 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
- I've hit a wall here, as I misunderstood some Progress behaviour. During my initial exploration on the OpenEdge syste...
- 12:51 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
- We have a customer that needs to be able to set UTF-8 or CP963 as the @CPINTERNAL@. We may have some problems with d...
- 12:43 PM Bug #4766: fix CHR and ASC
- What is left to do in this task? Please note that in #6428 Joe is fixing an issue related to lead-byte processing in...
- 10:17 AM Feature #6425: SESSION handle features
- I created some tests under @testcases/session/session_features.p@. Please review.
- 07:01 AM Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> Marian: Please summarize the current level of conversion support for all of the classes #6410-1. ...
04/04/2023
- 03:43 PM Feature #4065 (Review): server-side processing of client platform dependencies
- 03:42 PM Feature #4065: server-side processing of client platform dependencies
- The server-side shell execution will require more thought. For the file system it is straightforward to get a canonic...
- 03:38 PM Feature #4065: server-side processing of client platform dependencies
- 4065a revision 14527 implements server side file-system and file-based stream (based on @FileStream@ and @DirStream@)...
- 12:37 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
- Greg Shah wrote:
> No, you haven't missed anything. See #3827. The related code in 3827a is close to merging to tr... - 11:50 AM Feature #6411 (Closed): LOB-DIR I/O option support
- 3821c replaced trunk in trunk revision 14472 (we copied over trunk with 3821c rev 14472).
- 11:28 AM Feature #6411: LOB-DIR I/O option support
- Greg Shah wrote:
> In what revision of trunk can these changes be found?
>
It was in last commit of the @3821c@... - 10:55 AM Feature #6411: LOB-DIR I/O option support
- In what revision of trunk can these changes be found?
Are there any open items? - 10:36 AM Feature #6411 (Review): LOB-DIR I/O option support
- 10:36 AM Feature #6411 (WIP): LOB-DIR I/O option support
- 10:24 AM Feature #6411: LOB-DIR I/O option support
- Greg Shah wrote:
> Didn't we implement this recently?
Yes, we did. - 10:19 AM Feature #6411: LOB-DIR I/O option support
- Didn't we implement this recently?
- 10:33 AM Feature #6410: implement additional built-in OO classes/interfaces
- Marian: Please summarize the current level of conversion support for all of the classes #6410-1. We need all of thes...
- 10:08 AM Feature #6300 (Closed): class definitions with USE-WIDGET-POOL
- 09:56 AM Bug #7250 (Review): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- I've fixed this in 7199b/14529
- 09:33 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- Greg Shah wrote:
> The warning is because the code as written is useless.
It's not entirely useless - the customer'... - 09:15 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- The warning is because the code as written is useless. The user will go into edit mode, make changes and then the cha...
- 09:04 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- There is a weird behavior in OpenEdge. This test:...
- 09:02 AM Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
- 06:56 AM Feature #6425: SESSION handle features
- Theodoros Theodorou wrote:
> The task is ready for review. Should I also create a test in testcases?
Yes, please do. - 03:18 AM Bug #7240: conversion problem related to ENTERED in a IF expr
- Another issue is related to @frame f1 ... not entered@ version - the fix is in 7199b/14528.
04/03/2023
- 05:09 PM Feature #6425: SESSION handle features
- The task is ready for review. Should I also create a test in testcases?
- 05:06 PM Feature #6425 (Review): SESSION handle features
- 04:53 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Vladimir Tsichevski wrote:
> Igor, would you take a look at #7247, please. I think, both issues are closely related.... - 04:43 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor, would you take a look at #7247, please. I think, both issues are closely related.
- 04:50 PM Bug #7247: Dataset:READ-XML does nothing
- Vladimir Tsichevski wrote:
> The test case is:
> [...]
>
> The test compiles and runs OK. But in FWD the @READ-X... - 04:40 PM Bug #7247: Dataset:READ-XML does nothing
- The test case is:...
- 04:36 PM Bug #7247 (Closed): Dataset:READ-XML does nothing
- 04:22 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- Constantin Asofiei wrote:
> I think the solution would be in literals.rules on line 371:
> to add a @!(isNote("wrap... - 10:34 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- Constantin Asofiei wrote:
> It means they are added by the parser. I assume you see other @byrule-@ annotations i... - 09:34 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
>
> > OTOH, we should find who sets the @wrap@ annotation ... - 09:31 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- Constantin Asofiei wrote:
> OTOH, we should find who sets the @wrap@ annotation for the literal - did you convert ... - 09:12 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- The repo 7184a was created for the fix, and the regression test task #7245.
- 02:45 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
- No, you haven't missed anything. See #3827. The related code in 3827a is close to merging to trunk. Vladimir is wr...
- 02:39 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
- I had misread the current docs, and didn't use ABLUnit for tests (instead writing standalone tests). I'm in the proce...
- 06:11 AM Feature #3853: implement LOG-MANAGER runtime
- @LOG-ENTRY-TYPES@ and @LOGGING-LEVEL@ are @LOG-MANAGER@ attributes that can be changed in the internal procedure runn...
- 05:34 AM Feature #3853: implement LOG-MANAGER runtime
- Appservers have the following logging configs in OE Explorer:
* srvrLogFile - by default @{WorkPath}\%appservername%... - 03:47 AM Feature #3853: implement LOG-MANAGER runtime
- Answering to #5753#note-113 :
Constantin Asofiei wrote:
> From this, we know:
> * changing @LOGFILE-NAME@ does n... - 01:41 AM Bug #7240: conversion problem related to ENTERED in a IF expr
- The fix is in 7199b/14527
04/02/2023
- 03:41 PM Bug #7240: conversion problem related to ENTERED in a IF expr
- There is another issue related to INPUT/ENTERED - fields need to be treated the same way as vars in @input_functions....
Also available in: Atom