Project

General

Profile

Activity

From 04/06/2023 to 05/05/2023

05/05/2023

05:48 AM Bug #7193 (WIP): READ-JSON is not supported for the "LONGCHAR" source type
Greg Shah
05:48 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Agreed. Greg Shah
05:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Greg Shah wrote:
> > Before merging this branch to trunk we should test it against Z/POC application.
>
> Ovidiu:... Igor Skornyakov
05:25 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
> Before merging this branch to trunk we should test it against Z/POC application.
Ovidiu: Yes, please do. Greg Shah
02:57 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Rebased 7193a from the trunk/14560.
Pushed up to revision 14578.
Re-testing. Igor Skornyakov
10:28 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Review of 7193a/14570 (compared to previous iteration, 14567).
* @JsonImport.java@
** line 914: you replaced @relat... Ovidiu Maxiniuc

05/04/2023

02:44 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor: Please set the % Done. Greg Shah
02:43 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Ovidiu: Please review. Greg Shah
02:43 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Greg Shah wrote:
> Please remove the streams usage.
Done.
Committed to 7193a/14570. Igor Skornyakov
02:33 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Please remove the streams usage. Greg Shah
10:41 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> Greg Shah wrote:
> > We've found that runtime code measurably slows down when one uses 5 s... Igor Skornyakov
10:26 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Greg Shah wrote:
> We've found that runtime code measurably slows down when one uses 5 stacks (or any large number) ... Igor Skornyakov
07:50 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
> I do not think that JsonImport is called very often in real apps
JSON processing will be very heavily used in RE... Greg Shah
04:41 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Ovidiu Maxiniuc wrote:
> Review of 7193a/14567, (re-)based on trunk 14552:
> * @TemporaryBuffer.java@: The H note m... Igor Skornyakov
10:53 AM Bug #7272 (Test): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Greg Shah
10:11 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Task branch 7272a was merged to the trunk as rev 14555 and archived. Galya B
09:49 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Go ahead with the merge. Greg Shah
09:40 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Thanks, I think we are OK with what we wanted to solve in this task. Regarding appserver - I see messages being logg... Constantin Asofiei
09:39 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
For appserver do we somehow narrow down the condition in Window further by excluding appserver. Galya B
09:37 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Tested in FWD.
*Batch:*
output.txt... Galya B
09:10 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Please provide a status of how it works with 7272a:
* in ChUI (terminal) - if the message on the screen and in the f... Constantin Asofiei
08:20 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
OK, I get confused by all the garbage output from System.err (hopefully some day it will go away). It's indeed a chan... Galya B
08:06 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya Bogdanova wrote:
> What is chui terminal in OE? In FWD it doesn't have that message area on the bottom, so it ... Constantin Asofiei
08:02 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
What is chui terminal in OE? In FWD it doesn't have that message area on the bottom, so it looks like batch. Galya B
08:00 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Then this condition is not right @boolean switchedOnChui = tc.isChui() && switched; @.
Batch is a kind of ChUI cli... Constantin Asofiei
07:58 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Our "message" ends up straight on the terminal with batch and chui-terminal, while it's not expected there. Galya B
07:57 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
In OE if you run the procedure as batch: @pro -b -p proc.p@, this is what I'm referring to chui (probably not the rig... Galya B
07:54 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya, I don't understand the Window.java change - in ChUI, this code emits the error message, in OpenEdge, in the te... Constantin Asofiei
01:30 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> Galya, please add your changes to the 7272a branch.
Up in 7272a r14554-14556.
 Galya B
01:21 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya, please add your changes to the 7272a branch. Constantin Asofiei
01:17 AM Bug #7272 (Review): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya B
01:16 AM Bug #7272 (WIP): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya B
09:42 AM Feature #6649: improve the performance or SourceNameMapper runtime
Joe, I suggest you go with Greg's idea in #6649-17 first. This is relatively simple change and will be a good opportu... Hynek Cihlar
09:19 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Eric: Please review this task in regard to @_aud-audit-data@ and provide guidance. Greg Shah
09:09 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Sorry for the mistake in the email, this task is not ready for review yet.
As I wrote in 7027, the commands @AUDIT... Theodoros Theodorou
06:30 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Code Review Task Branch 6422a Revision 14547
The initial changes seem OK. There may be some slight deviations fro... Greg Shah

05/03/2023

07:50 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Review of 7193a/14567, (re-)based on trunk 14552:
* @TemporaryBuffer.java@: The H note mentions "processed _errors_"... Ovidiu Maxiniuc
03:29 PM Feature #4065 (WIP): server-side processing of client platform dependencies
Hynek Cihlar
03:29 PM Feature #4065: server-side processing of client platform dependencies
4065a merged in to trunk revision 14554 and archived. Hynek Cihlar
03:05 PM Feature #4065: server-side processing of client platform dependencies
Please merge 4065a to trunk. Greg Shah
02:49 PM Feature #4065: server-side processing of client platform dependencies
I reverted the log changes introduced in trunk revision 14535 in 4065a revision 14565. Hynek Cihlar
10:44 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Please remove all the logging changes from rev 14563. Attach a patch for the package name abbrev... Hynek Cihlar
12:57 PM Feature #6410 (Review): implement additional built-in OO classes/interfaces
Attached the patches for skeleton and FWD stubs for #6410a.
There are methods name change in @JsonArray@ that lead... Marian Edu

05/02/2023

05:50 PM Feature #6497: add equivalent support for the -T command line option
The branch 6497a has been rebased to trunk 14553. The new rev no is 14558.
 Theodoros Theodorou
09:00 AM Feature #6497: add equivalent support for the -T command line option
Please rebase from the latest trunk and we will review this. Greg Shah
04:57 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
4GL and FWD format ouput JSON files in not exactly the same way. To simplify comparision of 4GL and FWD results I use... Igor Skornyakov
02:09 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Ovidiu: Please review. Greg Shah
02:07 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Finished support for DATA-SET:SERIALIZE-HIDDEN.
Committed to 7193a/14567.
Now FWD provides exactly the same outpu... Igor Skornyakov
03:35 PM Feature #4065: server-side processing of client platform dependencies
After 4065a is merged to trunk the following resources still need a server-side implementation:
* process launchin... Greg Shah
03:26 PM Feature #4065: server-side processing of client platform dependencies
Please remove all the logging changes from rev 14563. Attach a patch for the package name abbreviation code to #7279... Greg Shah
01:15 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
About the extra output:
Basically the problem was in:
@Window.java@ states in @message(String message, Color cs, ... Galya B
11:42 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya Bogdanova wrote:
> Can I run .p file in Progress in GUI? I wonder if the system bar messages are even displaye... Constantin Asofiei
11:34 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Can I run .p file in Progress in GUI? I wonder if the system bar messages are even displayed after the redirect to th... Galya B
11:13 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya Bogdanova wrote:
> Do we create a separate task? This one will get some time if I need to address all of the i... Constantin Asofiei
11:12 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Do we create a separate task? This one will get some time if I need to address all of the issues. Not sure how urgent... Galya B
11:11 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
@session:system-alert-boxes = true.@ works for both ChUI and GUI OpenEdge clients (displays dialog-box). Constantin Asofiei
10:50 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> Also, is @system-alert-boxes@ behavior working OK?
It works only in gui, where errors... Galya B
07:07 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
I think we need to restore the silent mode, something like this:... Constantin Asofiei
06:55 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
This patch produces the following output in batch:... Galya B
06:04 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Run the test with @session:system-alert-boxes = false.@ or @session:system-alert-boxes = true.@, in ChUI and GUI, an... Constantin Asofiei
04:49 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Do we expect to see alert boxes?
This code always receives @noMessageBox = false@ and transforms it in @true@ wit... Galya B
10:47 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> What is the status of this?
This is in 7156a for the customer. What's left is Marian's tests, v... Constantin Asofiei
10:45 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
What is the status of this? Greg Shah
10:36 AM Feature #6649: improve the performance or SourceNameMapper runtime
Greg Shah wrote:
> It seems to me that nearly all the time in all projects the unqualified filename has very few con... Hynek Cihlar
10:31 AM Feature #6649: improve the performance or SourceNameMapper runtime
It seems to me that nearly all the time in all projects the unqualified filename has very few conflicts in the overal... Greg Shah
09:14 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
I was finally able to understand how it works. So custom events (@eventId >= 32000@) should be added manually using t... Theodoros Theodorou
03:01 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Theodoros Theodorou wrote:
> I think that the table @_aud-audit-data@ holds the records only for the @SET-APPL-CONTE... Marian Edu
08:52 AM Bug #7206: shared frame defined with the same name but different widgets
Code Review Task Branch 7199c Revision 14567
No objections. Greg Shah
05:14 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Done in 6410a/14553. Please review.
Got it, thanks, will see if there is anything miss... Marian Edu
03:06 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> Constantin Asofiei wrote:
> > 7199c rev 14559 contains the implementation for @OpenEdge.Core.Sy... Constantin Asofiei
02:49 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> 7199c rev 14559 contains the implementation for @OpenEdge.Core.System.ArgumentError@. R... Marian Edu
02:46 AM Feature #6410: implement additional built-in OO classes/interfaces
When converting skeleton classes there seems to be some issue with classes that implements interfaces with properties... Marian Edu

05/01/2023

06:04 PM Bug #7317 (Test): accumulator using another accumulator as expression
Code review 7199c/14566: the changes look good. This should go into wider testing. Eric Faulhaber
04:44 PM Bug #7317: accumulator using another accumulator as expression
Eric: Please review. Greg Shah
06:57 AM Bug #7317 (Review): accumulator using another accumulator as expression
4GL allows an accumulator function to be used in the expression of an accumulator statement:... Constantin Asofiei
06:48 AM Bug #7317 (Closed): accumulator using another accumulator as expression
Constantin Asofiei
04:35 PM Bug #7316 (Test): regression in 'ACCUM ... extVar' expansion - subscript not emitted
Code Review Task Branch 7199c Revision 14565
No objections. Greg Shah
06:47 AM Bug #7316 (Review): regression in 'ACCUM ... extVar' expansion - subscript not emitted
This test:... Constantin Asofiei
06:38 AM Bug #7316 (Closed): regression in 'ACCUM ... extVar' expansion - subscript not emitted
Constantin Asofiei
04:31 PM Bug #7315 (Test): unknown literal passed as an argument to a 'object' parameter
Code Review Task Branch 7199c Revision 14564
No objections. Greg Shah
06:35 AM Bug #7315 (Review): unknown literal passed as an argument to a 'object' parameter
This case:... Constantin Asofiei
06:31 AM Bug #7315 (Closed): unknown literal passed as an argument to a 'object' parameter
Constantin Asofiei
04:23 PM Bug #7314 (Test): conversion issue for FIRST-OF(f1) when there is a collision between the field n...
Code Review Task Branch 7199c Revision 14563
No objections. Greg Shah
06:30 AM Bug #7314: conversion issue for FIRST-OF(f1) when there is a collision between the field name and...
Fixed in 7199c rev 14563. Constantin Asofiei
06:30 AM Bug #7314 (Review): conversion issue for FIRST-OF(f1) when there is a collision between the field...
The problem is described by this test:... Constantin Asofiei
06:26 AM Bug #7314 (Closed): conversion issue for FIRST-OF(f1) when there is a collision between the field...
Constantin Asofiei
04:18 PM Bug #7313 (Test): regression in '<record-phrase> USING FRAME f field'
Code Review Task Branch 7199c Revision 14562
No objections. Greg Shah
06:23 AM Bug #7313 (Review): regression in '<record-phrase> USING FRAME f field'
A @find tt1 using frame f1 tt1.f1@ was refactoring the @frame f1 tt1.f1@ to an @INPUT@ function, which is done separa... Constantin Asofiei
06:20 AM Bug #7313 (Closed): regression in '<record-phrase> USING FRAME f field'
Constantin Asofiei
04:14 PM Bug #7312 (Test): mtime(character) is allowed in 4GL
Code Review Task Branch 7199c Revision 14561
No objections. Greg Shah
06:18 AM Bug #7312 (Review): mtime(character) is allowed in 4GL
@mtime(character)@ will raise a @Unacceptable datatype for MTIME argument. 12117@ ERROR condition.
Committed to 71... Constantin Asofiei
06:15 AM Bug #7312 (Closed): mtime(character) is allowed in 4GL
Constantin Asofiei
04:11 PM Bug #7311 (Test): abs(integer) must return int64
Code Review Task Branch 7199c Revision 14560
No objections. Greg Shah
06:14 AM Bug #7311 (Review): abs(integer) must return int64
... Constantin Asofiei
05:58 AM Bug #7311 (Closed): abs(integer) must return int64
Constantin Asofiei
04:07 PM Bug #7310 (Test): buffer scope in constructor/destructor is not computed correctly
Code Review Task Branch 7199c Revision 14558
No objections. Greg Shah
05:52 AM Bug #7310 (Review): buffer scope in constructor/destructor is not computed correctly
The fix is in 7199c/14558 Constantin Asofiei
04:23 AM Bug #7310: buffer scope in constructor/destructor is not computed correctly
The issue is when there is an explicit buffer defined with the same name as a buffer in a constructor or destructor:
... Constantin Asofiei
04:21 AM Bug #7310 (Closed): buffer scope in constructor/destructor is not computed correctly
Constantin Asofiei
03:48 PM Bug #7308 (Test): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, wh...
Code Review Task Branch 7199c Revision 14557
No objections. Greg Shah
05:49 AM Bug #7308 (Review): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, ...
The fix is in 7199c rev 14557 Constantin Asofiei
12:38 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > So when @invokeFailure@ is reached you know that this is a c... Constantin Asofiei
12:36 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> So when @invokeFailure@ is reached you know that this is a case of an external program.
... Galya B
12:31 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya, @invokeFailure@ is ever only called for a failure of a @RUN externalprogram.p@ statement; it never gets called... Constantin Asofiei
12:21 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
On line 7159 in @ControlFlowOps.invokeImpl@ the error is to be displayed with @invokeFailure(name)@:... Galya B
11:57 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> I think it may be possible to disable silent error processing in @ControlFlowOps.invokeF... Galya B
11:32 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya Bogdanova wrote:
> This should not be considered @silent@ in FWD - it should display an alert and fill in ER... Constantin Asofiei
11:31 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> Regarding #7272-16 - please solve also the missing alert - if with NO-ERROR OpenEdge sti... Galya B
11:24 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya Bogdanova wrote:
> > > I believe the stop condition is always raised. @must not show@ message is never shown i... Constantin Asofiei
11:20 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > Constantin Asofiei wrote:
> > > Galya, please focus on @Con... Galya B
11:19 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> * properly add the error message to ERROR-STATUS and also display it.
Just to make it... Galya B
11:17 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > Galya, please focus on @ControlFlowOps.invokeFailure@ - the ... Constantin Asofiei
11:16 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> Galya, please focus on @ControlFlowOps.invokeFailure@ - the problem is there, we need to... Galya B
11:07 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya, please focus on @ControlFlowOps.invokeFailure@ - the problem is there, we need to adjust that code to:
* keep... Constantin Asofiei
11:06 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
I think the issue is in the converted code that considers it a silent invokation:... Galya B
10:20 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
I'll focus on 1. for this task. Starting to debug. Galya B
10:15 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Check the diff in batch output redirect files in the attached diff file, shown here as an image:
!OE-vs-FWD-batch-ou... Galya B
09:43 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Complete test results for the procedure in #7272#note-7:
*1.* executed as batch in Progress results in this output... Galya B
08:26 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin, I'm testing it now. I just wanted to make clear it's not related to the above mentioned change. Galya B
08:24 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Galya, this is not a bug related to your changes. This is an existing bug which we need to fix; please see this test... Constantin Asofiei
07:57 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei wrote:
> Also, with 5753d, @ControlFlowOps.invokeFailure@ was changed from this:
> [...]
> to t... Galya B
10:11 AM Bug #7206: shared frame defined with the same name but different widgets
The fix for this 'unused shared frame' must apply to @NEW SHARED@ frames, too. Fixed in 7199c/14567 Constantin Asofiei
06:33 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
> If you believe that we have to reproduce the quirks mentioned above I suggest to deeal with it in sce scope of #724... Greg Shah
05:57 AM Feature #6410: implement additional built-in OO classes/interfaces
7199c rev 14559 contains the implementation for @OpenEdge.Core.System.ArgumentError@. Required by #7199 Constantin Asofiei
05:16 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
7250a changes were committed to 7199c rev 14556.
7250a was dead-archived. Constantin Asofiei
05:14 AM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
7304a changes were committed to 7199c rev 14555.
7304a was dead-archived. Constantin Asofiei
05:11 AM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
Greg Shah wrote:
> It seems that this logic may be broken if the @recordName@ is a qualified name. Otherwise I have... Constantin Asofiei
04:50 AM Bug #7240: conversion problem related to ENTERED in a IF expr
Constantin Asofiei wrote:
> Another case somehow related to #7178 - @tt1.f1 [not] entered@ must not produce a buffe... Constantin Asofiei

04/29/2023

06:05 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> Implemented DATA-SET:WRITE-XMLSCHEMA with SERIALIZE-HIDDEN = true.
> Committed to 7193a/1... Igor Skornyakov

04/28/2023

04:11 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Implemented DATA-SET:WRITE-XMLSCHEMA with SERIALIZE-HIDDEN = true.
Committed to 7193a/14566.
This provides the ... Igor Skornyakov
11:31 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
> > I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now and then check t... Greg Shah
08:32 AM Feature #4065: server-side processing of client platform dependencies
I think this discussion qualifies as defining the requirements for the "reduce package name text in stack trace outpu... Greg Shah
08:23 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> I would hope that we can integrate these changes together without moving all logging work to Hyne... Galya B
07:52 AM Feature #4065: server-side processing of client platform dependencies
It is not uncommon for us to implement small changes to unrelated areas in tasks that are otherwise addressing a diff... Greg Shah
03:15 AM Feature #4065: server-side processing of client platform dependencies
Hynek Cihlar wrote:
> The code doesn't matter. It's important so that we keep the product good. If it means you need... Galya B
03:03 AM Feature #4065: server-side processing of client platform dependencies
Galya Bogdanova wrote:
> Hynek Cihlar wrote:
> > The changes are so minimal that I don't see how it can cause issue... Hynek Cihlar
02:46 AM Feature #4065: server-side processing of client platform dependencies
Hynek Cihlar wrote:
> The changes are so minimal that I don't see how it can cause issues during merging with your w... Galya B
02:34 AM Feature #4065: server-side processing of client platform dependencies
Galya Bogdanova wrote:
> Hynek Cihlar wrote:
> > @Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 145... Hynek Cihlar
01:18 AM Feature #4065: server-side processing of client platform dependencies
Hynek Cihlar wrote:
> @Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 14563. Galya, please review.
... Galya B
08:04 AM Bug #7308: 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, where v1 ...
For function parameters, the LBRACKET is completely ignored. For procedure parameters, it works as a DEF VAR:... Constantin Asofiei
07:38 AM Bug #7308: 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, where v1 ...
This test works fine in 4GL:... Constantin Asofiei
07:38 AM Bug #7308 (Closed): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, ...
Constantin Asofiei
07:06 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
I think that the table @_aud-audit-data@ holds the records only for the @SET-APPL-CONTEXT@ command. In progress docum... Theodoros Theodorou
04:52 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Theodoros Theodorou wrote:
> I found also some hidden tables regarding auditing: @_aud-*@. I tried to use @LOG-APP... Marian Edu

04/27/2023

04:17 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Hello Marian, I am trying to find the exact usage of the commands @LOG-AUDIT-EVENT@, @CLEAR-APPL-CONTEXT@ and @SET-AP... Theodoros Theodorou
01:41 PM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
Code Review Task Branch 7250a Revision 14553
No objections. Greg Shah
01:10 PM Bug #7250 (Review): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
Branch 7250a was created trunk 14552.
The change in previous note is in rev 14553. Constantin Asofiei
07:46 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
There is another case related to PROMPT-FOR: when a record reference is used instead of individual fields. I'm testi... Constantin Asofiei
01:40 PM Feature #4065: server-side processing of client platform dependencies
@Logger.getLogger@ replaced with @LogHelper@ in 4065a revision 14563. Galya, please review. Hynek Cihlar
01:37 PM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> The change related to the reduction of package names seems to be useful.
Wasn't a requirement ... Galya B
01:35 PM Feature #4065: server-side processing of client platform dependencies
The change related to the reduction of package names seems to be useful. Greg Shah
01:34 PM Feature #4065: server-side processing of client platform dependencies
Galya Bogdanova wrote:
> Hynek, I will obviously have to resolve the conflicts caused by all the changes you do to l... Hynek Cihlar
01:33 PM Feature #4065: server-side processing of client platform dependencies
Hynek Cihlar wrote:
> AFAIK Galya has successfully rebased with the logging changes. They are really minimal anyway ... Galya B
01:32 PM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Let's ensure that they don't cause conflicts with the upcoming merge of 5703a.
AFAIK Galya has... Hynek Cihlar
01:28 PM Feature #4065: server-side processing of client platform dependencies
Hynek, I will obviously have to resolve the conflicts caused by all the changes you do to logging and then delete the... Galya B
01:26 PM Feature #4065: server-side processing of client platform dependencies
Let's ensure that they don't cause conflicts with the upcoming merge of 5703a.
Also, we definitely should be using... Greg Shah
01:23 PM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Code Review Task branch 4065a Revisions 14560 through 14562
>
> No objections. Weren't the lo... Hynek Cihlar
10:45 AM Feature #4065: server-side processing of client platform dependencies
Constantin Asofiei wrote:
> Review for 4065a rev 14527:
> * @HighLevelObject.LOG@ - we are replacing @java.util.log... Galya B
10:33 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Galya: Please review the logging changes in rev 14560.
The changes are indeed unexpected. Galya B
10:21 AM Feature #4065: server-side processing of client platform dependencies
Code Review Task branch 4065a Revisions 14560 through 14562
No objections. Weren't the logging changes removed on... Greg Shah
07:54 AM Feature #4065: server-side processing of client platform dependencies
The points raised during the reviews are resolved in 4065a revision 14561. File history entries added in revision 145... Hynek Cihlar
04:32 AM Feature #4065: server-side processing of client platform dependencies
I rebased 4065a against the latest trunk. Hynek Cihlar
12:28 PM Feature #6410: implement additional built-in OO classes/interfaces
Branch 6410a has been branched from trunk 14552. I've pushed it to xfer (@/opt/fwd/6410a@). Greg Shah

04/26/2023

03:56 PM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
Code Review Task Branch 7301a Revision 14552
It seems that this logic may be broken if the @recordName@ is a quali... Greg Shah
02:58 PM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
Code Review Task Branch 7304a Revision 14552
No objections. Greg Shah
08:02 AM Bug #7304 (Review): UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
7304a rev 14552 contains the implementation for the idea in note #7304-2. Constantin Asofiei
07:51 AM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
Created task branch 7304a from trunk rev 14551. Constantin Asofiei
02:30 AM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
I think in OpenEdge there is a runtime check if an expression argument is int64 instead of the integer parameter set ... Constantin Asofiei
01:27 AM Bug #7304 (Closed): UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker
Constantin Asofiei
12:04 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian: Please have your team review the documentation on method overloading in #3751-492 and look at the code in @oo... Greg Shah
07:52 AM Feature #4065: server-side processing of client platform dependencies
> I agree this could be merged together under a file-system resource. Greg, what do you think?
Agreed. Greg Shah
07:17 AM Feature #4065: server-side processing of client platform dependencies
Constantin Asofiei wrote:
> Review for 4065a rev 14527:
> * @ConcurrentResource.resourceTypeName@ - the javadoc was... Hynek Cihlar
07:09 AM Feature #4065: server-side processing of client platform dependencies
Review for 4065a rev 14527:
* @ConcurrentResource.resourceTypeName@ - the javadoc was indented right
* @HighLevelOb... Constantin Asofiei
05:14 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Code Review Task Branch 4065a Revisions 14521 through 14527
>
> Overall this is a really nice ... Hynek Cihlar

04/25/2023

04:05 PM Feature #4065: server-side processing of client platform dependencies
Constantin: Please review. Greg Shah
04:04 PM Feature #4065: server-side processing of client platform dependencies
Code Review Task Branch 4065a Revisions 14521 through 14527
Overall this is a really nice update! I think the app... Greg Shah
02:37 PM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
Created task branch 7301a from trunk rev 14551.
The patch in previous note is in rev 14552. Constantin Asofiei
09:51 AM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
The previous patch is not correct, it regresses this case:... Constantin Asofiei
07:14 AM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
In pre-scan, no scope is pushed for top-level blocks (as we can't track them). This case fails to parse in pre-scan:... Constantin Asofiei
07:06 AM Bug #7301 (Closed): pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method
Constantin Asofiei
12:48 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
We convert compilable code, which this is. hIt is used heavily in a customer project so we need to get it right. Greg Shah
12:36 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> Marian, we need more tests to determine how OE behaves in this case. The problem here i... Marian Edu
12:27 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now ... Constantin Asofiei
12:24 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
I think this fix is needed urgently by one project. Should we merge this to trunk and 7156a now and then check the t... Greg Shah
12:22 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299a Revision 14551
No objections. Greg Shah
07:19 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Created task branch 7299a from trunk rev 14550. The patch is in rev 14551. Greg, please review. Constantin Asofiei
05:39 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin, will do... as a side note, imho this should not have been allowed in 4GL, it completely break any strong ... Marian Edu

04/24/2023

02:11 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian, we need more tests to determine how OE behaves in this case. The problem here is when there are multiple ove... Constantin Asofiei
01:49 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
In #7261, this test was found to not work properly:... Constantin Asofiei
01:48 PM Bug #7299 (Test): resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei
12:57 PM Bug #7240: conversion problem related to ENTERED in a IF expr
Another case somehow related to #7178 - @tt1.f1 [not] entered@ must not produce a buffer reference. A fix for this ... Constantin Asofiei
10:45 AM Bug #5276: resolve issues with multi-byte character processing
Status on this: I'm in the middle of converting @character.java@ to use @codePointAt@ instead of @charAt@ where appro... Joe Davis

04/21/2023

10:37 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> The initial support was put in as branch 3821c revision 13885/13886.
Ah, I see... it should be... Galya B
10:36 AM Feature #4065: server-side processing of client platform dependencies
Constantin Asofiei wrote:
> When a 3821c revision is mentioned, that is a trunk revision. 3821c became trunk some ti... Galya B
10:34 AM Feature #4065: server-side processing of client platform dependencies
Galya Bogdanova wrote:
> Greg Shah wrote:
> > But you can look at the existing code for the model.
> If I don't kn... Constantin Asofiei
10:33 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> But you can look at the existing code for the model.
If I don't know the revision, how do I know... Galya B
10:32 AM Feature #4065: server-side processing of client platform dependencies
The initial support was put in as branch 3821c revision 13885/13886.
Additional support is written in 4065a but ha... Greg Shah
10:30 AM Feature #4065: server-side processing of client platform dependencies
Galya Bogdanova wrote:
> There is no email @merge notification for task branch 4065@ and no comment which revision i... Constantin Asofiei
10:25 AM Feature #4065: server-side processing of client platform dependencies
There is no email @merge notification for task branch 4065@ and no comment which revision it was on trunk. How do I f... Galya B
09:20 AM Feature #4065: server-side processing of client platform dependencies
Thank you for the help. I'll find the configs now on trunk. Galya B
09:02 AM Feature #4065: server-side processing of client platform dependencies
Take a look at the library manager support (or memptr) in trunk. Greg Shah
08:38 AM Feature #4065: server-side processing of client platform dependencies
When a client process accesses the server, how do you know if its a local client (on the same host) or a remote one w... Galya B

04/20/2023

01:55 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
I've created a more complete test for inferring empty dynamic DATA-SET from JSON data w/o root element (#7193-27).
N... Igor Skornyakov
06:48 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Ovidiu Maxiniuc wrote:
> Review of 7193a/14544.
> * @AbstractTempTable.java@: please set the number in H entry (21)... Igor Skornyakov
05:12 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
The task branch 7193a was rebased to the trunk/14543.
Pushed up to revision 14551. Igor Skornyakov

04/19/2023

04:13 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> As far as I understand the 7193a is not reabsed to lasterst trunk.
> > No, I've extracte... Vladimir Tsichevski
04:05 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Vladimir Tsichevski wrote:
> Igor Skornyakov wrote:
>
> > The @{ "Customer": [ { "customerName": "John Smith", "... Igor Skornyakov
03:53 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> The @{ "Customer": [ { "customerName": "John Smith", "customerNum": 10}, { "customerNam... Vladimir Tsichevski
03:48 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Ovidiu Maxiniuc wrote:
> Review of 7193a/14544.
>
> Good job! A lot of code with adjustments for existing feature... Igor Skornyakov
03:36 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Review of 7193a/14544.
Good job! A lot of code with adjustments for existing features. Here are some notes, most o... Ovidiu Maxiniuc
02:45 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Vladimir Tsichevski wrote:
> I am running OEUnit fixture test class:
>
> [...]
>
> In this class a fixture is ... Igor Skornyakov
02:20 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
I am running OEUnit fixture test class:... Vladimir Tsichevski

04/18/2023

05:52 PM Feature #6422 (WIP): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Theodoros Theodorou
11:02 AM Bug #7247: Dataset:READ-XML does nothing
Created task branch 7247a. Igor Skornyakov
09:58 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > > I think, the unit testing for the function can be done in the f... Greg Shah
08:29 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
Greg Shah wrote:
> > I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tes... Vladimir Tsichevski
08:25 AM Feature #6428: implement IS-LEAD-BYTE() built-in function
> I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tests at the Java level... Greg Shah
07:36 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Well, all tests passed.
Committed to 7193a/14544.
Please review.
Thank you. Igor Skornyakov
06:42 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > However these additional testes reveal a strange problem with W... Igor Skornyakov
04:47 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> However these additional testes reveal a strange problem with WRITE-XML for the PARENT-ID-R... Igor Skornyakov

04/17/2023

04:11 PM Feature #6428: implement IS-LEAD-BYTE() built-in function
I think, the unit testing for the function can be done in the form of JUnit5 Jupiter engine tests at the Java level, ... Vladimir Tsichevski
11:22 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Fixed issues with READ-JSON for empty dynamic DATA-SET revealed by additional tests.
Committed to 7193a/14543.
Ho... Igor Skornyakov
03:32 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Just noticed.
When running the attached test I see multiple message like this... Igor Skornyakov

04/16/2023

02:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Igor Skornyakov wrote:
> Added support for inferring empty dynamic DATA-SET from JSON data. Fixed support for PARENT... Igor Skornyakov

04/15/2023

02:32 PM Bug #7247 (WIP): Dataset:READ-XML does nothing
Igor Skornyakov
02:31 PM Bug #7193 (Review): READ-JSON is not supported for the "LONGCHAR" source type
Added support for inferring empty dynamic DATA-SET from JSON data. Fixed support for PARENT-ID-RELATION in WRITE-JSON... Igor Skornyakov
12:19 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
I've encountered the following problem.
On inferring @DATA-SET@ from JSON data with @READ-JSON@ the @NESTED@ @DATA-R... Igor Skornyakov

04/14/2023

01:02 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
Inferring empty dynamic DATA-SET from JSON data is mostly finished.
Committed to 7193a/14539.
The tables looks th... Igor Skornyakov
09:02 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Please do the following:
* Review #6422 and the 4GL facilities it is intended to implement.
* Write testcases and... Greg Shah
09:02 AM Feature #6420: implement the AUDIT-ENABLED() built-in function
This is meant to report on whether the 4GL-compatible auditing support is activated. That means it is dependent upon... Greg Shah

04/13/2023

05:17 PM Feature #6420 (WIP): implement the AUDIT-ENABLED() built-in function
Theodoros Theodorou
04:52 PM Feature #6420: implement the AUDIT-ENABLED() built-in function
How should we implement this feature? Should we just add a flag into @directory/client.xml@ or should we replicate th... Theodoros Theodorou

04/12/2023

02:14 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
This bug already exists in trunk, it came up in a discussion when debugging a customer's application. Constantin Asofiei
02:12 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
I mentioned 'log' in the title and previous entry, but this is also about displaying the error message to the user. ... Constantin Asofiei
02:00 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
This program:... Constantin Asofiei
01:53 PM Bug #7272 (Closed): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Constantin Asofiei

04/10/2023

10:53 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
This task isn't a priority right now. Greg Shah
10:49 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
Constantin Asofiei wrote:
> > # calling the @unknown.instantiateUnknown()@, this function just returns the @unknow... Vladimir Tsichevski
10:45 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
Vladimir Tsichevski wrote:
> I can take this task.
Greg?
> # calling @new unknown()@, we want to get rid of thi... Constantin Asofiei
10:02 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
I can take this task.
A question: currently there is 3 ways to obtain the @unknown@ value:
# calling @new unkno... Vladimir Tsichevski
08:24 AM Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
Greg Shah
07:55 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge
7199b/14533 was merged to trunk rev 14528 and archived. Constantin Asofiei
08:23 AM Bug #7243 (Closed): collision between YEAR function and a perm table abbreviated name
Greg Shah
07:55 AM Bug #7243: collision between YEAR function and a perm table abbreviated name
7199b/14533 was merged to trunk rev 14528 and archived. Constantin Asofiei
08:23 AM Bug #7240 (Closed): conversion problem related to ENTERED in a IF expr
Greg Shah
07:55 AM Bug #7240: conversion problem related to ENTERED in a IF expr
7199b/14533 was merged to trunk rev 14528 and archived. Constantin Asofiei

04/06/2023

10:46 AM Feature #4065: server-side processing of client platform dependencies
Greg/Hynek: for server-side memptrs, we still have the problem when the memory address is incoming from a OS library ... Constantin Asofiei
 

Also available in: Atom