FWD » Core Development » Base Language

05/28/2023

11:58 AM Feature #4065: server-side processing of client platform dependencies

I implemented server sockets to be a distinct resource from client sockets. So currently one can define server socket... Hynek Cihlar

05/26/2023

03:27 PM Feature #6420: implement the AUDIT-ENABLED() built-in function

> There is already another boolean for the other audit implementation: @security/aduit/enabled@.
No, the two audit... Greg Shah

03:20 PM Feature #6420: implement the AUDIT-ENABLED() built-in function

How should I implement this feature? Should I add a boolean in @server/directory.xml@? There is already another boole... Theodoros Theodorou

07:48 AM Feature #6420: implement the AUDIT-ENABLED() built-in function

When this is implemented, please put it in branch 6422a. Greg Shah

01:21 PM Bug #7247: Dataset:READ-XML does nothing

Greg Shah wrote:
> What is left to do in this task? Please set the %Done. Also, move it to review status if it is ... Igor Skornyakov

01:06 PM Bug #7247: Dataset:READ-XML does nothing

What is left to do in this task? Please set the %Done. Also, move it to review status if it is ready for review. Greg Shah

11:33 AM Bug #7247: Dataset:READ-XML does nothing

Rebased 7247a to trunk/14590.
Pushed up to revision 14592. Igor Skornyakov

11:26 AM Bug #7247: Dataset:READ-XML does nothing

Implemented inferring temp-table structure from XML.
Committed to 7247a/14588. Igor Skornyakov

12:08 PM Feature #6649: improve the performance or SourceNameMapper runtime

Joe Davis wrote:
> Greg Shah wrote:
> > Joe: Where does this work stand? I'd like to get the early review done as ... Hynek Cihlar

11:57 AM Feature #6649: improve the performance or SourceNameMapper runtime

Greg Shah wrote:
> Joe: Where does this work stand? I'd like to get the early review done as well as get an update ... Joe Davis

07:52 AM Feature #7386: predefined auditing events support and a better persistence approach for auditing ...

Implement 4GL auditing capability for predefined events (@event_id < 32000@).
Rework the simplistic persistence ap... Greg Shah

07:50 AM Feature #7386 (New): predefined auditing events support and a better persistence approach for aud...

Greg Shah

07:47 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

I've confirmed with the customer that they do not need the predefined events support. At this time, let's just get t... Greg Shah

05/25/2023

12:36 PM Feature #4065: server-side processing of client platform dependencies

Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Hynek, there is a regression in trunk rev 14580 - this se... Hynek Cihlar

12:36 PM Feature #4065: server-side processing of client platform dependencies

Constantin Asofiei wrote:
> Hynek, there is a regression in trunk rev 14580 - this seems to fix it, I need to finish... Constantin Asofiei

11:45 AM Feature #6649: improve the performance or SourceNameMapper runtime

Joe: Where does this work stand? I'd like to get the early review done as well as get an update on your subsequent o... Greg Shah

10:17 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Theodoros Theodorou wrote:
> 5. As Igor stated, we can use @Kafka@ to store these messages and use something like @k... Igor Skornyakov

09:56 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Igor/Theodoros: These are good analyses.
> Leave it as it is for now because just 2 commands are adding in this ta... Greg Shah

09:42 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

I agree with Igor.
I investigated the classes a bit and as I understand they keep some info in memory instead of u... Theodoros Theodorou

08:43 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

The idea of the optimization of the @_Lock@ and @_Usertablestat@ VST support is to postpone updating the correspondin... Igor Skornyakov

02:14 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Eric Faulhaber wrote:
> As 6422a currently is implemented, we are taking a round trip to the database to insert a re... Igor Skornyakov

05/24/2023

03:50 PM Bug #7247: Dataset:READ-XML does nothing

Extracted common code in XmlImport/JsonImport to a base class.
Committed to 7247a/14585. Igor Skornyakov

12:14 PM Feature #4065: server-side processing of client platform dependencies

Hynek, there is a regression in trunk rev 14580 - this seems to fix it, I need to finish ETF testing to confirm.
<pr... Constantin Asofiei

11:09 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

As 6422a currently is implemented, we are taking a round trip to the database to insert a record into the @meta_aud_a... Eric Faulhaber

06:24 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> > Also, 6410a branch is on xfer - do you still have problems using bzr on xfersrv01? If not, pl... Constantin Asofiei

06:23 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Marian, something else to note: I'm looking at the patch, and I don't understand somethi... Marian Edu

06:20 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Marian, what skeleton revision did you use for the skeleton patch? I can't apply it clea... Marian Edu

06:05 AM Feature #6649: improve the performance or SourceNameMapper runtime

Joe Davis wrote:
> Hynek Cihlar wrote:
> > Joe, I see you changed the status of this issue to Review. Are the chang... Hynek Cihlar

05/23/2023

05:59 PM Feature #6649: improve the performance or SourceNameMapper runtime

Hynek Cihlar wrote:
> Joe, I see you changed the status of this issue to Review. Are the changes checked in anywhere... Joe Davis

11:14 AM Feature #6649: improve the performance or SourceNameMapper runtime

Joe, I see you changed the status of this issue to Review. Are the changes checked in anywhere? Hynek Cihlar

03:57 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Hello Eric and Ovidiu. Greg asked me to ask for a review regarding my implementation of meta_aud_audit_data. To test ... Theodoros Theodorou

07:04 AM Feature #4065: server-side processing of client platform dependencies

4065b merged to trunk as revision 14580 and archived. Hynek Cihlar

06:46 AM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> Go ahead.
In progress. Hynek Cihlar

06:00 AM Feature #4065: server-side processing of client platform dependencies

Go ahead. Greg Shah

03:08 AM Feature #4065: server-side processing of client platform dependencies

Greg, I'd like to merge 4065b to trunk to address the regressions. Hynek Cihlar

05/22/2023

07:01 PM Feature #6649 (Review): improve the performance or SourceNameMapper runtime

Joe Davis

12:26 PM Feature #4065: server-side processing of client platform dependencies

> > Are you working on process launching and server-sockets?
>
> No, I switched to my other priority tasks.
Let... Greg Shah

12:16 PM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> Are you working on process launching and server-sockets?
No, I switched to my other priority t... Hynek Cihlar

12:14 PM Feature #4065: server-side processing of client platform dependencies

> I named the "resource" just "webservice". It would probably make sense to rename it to @webservice-client@ and dist... Greg Shah

11:45 AM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> Code Review Task Branch 4065b Revisions 14576 and 14577
>
> 1. Doesn't @ClientSideResourceMana... Hynek Cihlar

08:32 AM Feature #4065: server-side processing of client platform dependencies

Code Review Task Branch 4065b Revisions 14576 and 14577
1. Doesn't @ClientSideResourceManager.initialize()@ need a... Greg Shah

05:03 AM Feature #4065: server-side processing of client platform dependencies

I checked in a fix for another client initialization problem in 4065b revision 14577. @StreamDaemon@ initialization m... Hynek Cihlar

05/19/2023

03:49 PM Feature #4065: server-side processing of client platform dependencies

4065b revision 14576 implements server-side web service calling. Please review.
I named the "resource" just "webse... Hynek Cihlar

09:47 AM Feature #4065: server-side processing of client platform dependencies

Code Review Task Branch 4065b Revision 14571
No objections. Greg Shah

11:23 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian, something else to note: I'm looking at the patch, and I don't understand something: the Java method name for ... Constantin Asofiei

10:20 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian, what skeleton revision did you use for the skeleton patch? I can't apply it cleanly. I've pushed skeleton re... Constantin Asofiei

05/17/2023

11:12 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Yes Greg Shah

10:55 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

I am thinking of creating a persistent metadata table similar to @meta_user@ for the @_aud-audit-data@. Something lik... Theodoros Theodorou

05/15/2023

12:53 PM Feature #4065: server-side processing of client platform dependencies

Hynek Cihlar wrote:
> I created task branch 4065b and checked in a fix for the regression reported in #5731-856.
> ... Hynek Cihlar

09:34 AM Feature #4065: server-side processing of client platform dependencies

Constantin Asofiei wrote:
> Greg, also, something else to note: there is code in @p2j.oo@ for client sockets and a... Marian Edu

06:51 AM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> I thought we already supported regular 4GL client sockets on the server side,
Yes, 4GL client s... Constantin Asofiei

06:11 AM Feature #4065: server-side processing of client platform dependencies

I thought we already supported regular 4GL client sockets on the server side, but the missing part was the web servic... Greg Shah

05:41 AM Feature #4065: server-side processing of client platform dependencies

Hynek, I think there is some confusion: REST/SOAP/WebHandler are for the FWD web service support (server-side deploym... Constantin Asofiei

05/13/2023

06:30 PM Feature #4065: server-side processing of client platform dependencies

I created task branch 4065b and checked in a fix for the regression reported in #5731-856.
ThinClient must be inst... Hynek Cihlar

05/12/2023

04:12 PM Feature #4065: server-side processing of client platform dependencies

It is the client side (calling) only. Greg Shah

04:00 PM Feature #4065: server-side processing of client platform dependencies

Greg, is the scope of the server-side web-services only the invocation part (i.e. @WebServiceHelper@, @WebServiceImpl... Hynek Cihlar

03:54 PM Feature #4065: server-side processing of client platform dependencies

Yes, until #6082 is complete. Greg Shah

03:25 PM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> Is @oo/serialization/SerializeAll.cls@ included in the conversion list? All referenced OO classe... Hynek Cihlar

03:03 PM Feature #4065: server-side processing of client platform dependencies

Is @oo/serialization/SerializeAll.cls@ included in the conversion list? All referenced OO classes/interfaces/enums i... Greg Shah

02:10 PM Feature #4065: server-side processing of client platform dependencies

Constantin Asofiei wrote:
> The wiki is here: [[p2j:Testcases#Running-Web-tests|Running Web Tests]]. You will need ... Hynek Cihlar

05:52 AM Feature #4065: server-side processing of client platform dependencies

XML load/save is already handled with the server-side file access. It is enough to activate server-side file resource. Hynek Cihlar

05/11/2023

01:53 PM Feature #7348: mutable proxy implementation

I've looked at the profiling data and the count is this:
* @ReferenceProxy.invoke@ - 600k via 44k instances and 12k ... Constantin Asofiei

10:52 AM Feature #7348: mutable proxy implementation

For certain use cases (currently only for DMO proxies), we currently proxy an existing DMO proxy to redirect method i... Eric Faulhaber

10:47 AM Feature #7348 (New): mutable proxy implementation

Eric Faulhaber

12:43 PM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

So, I've expanded 6819b to use 'public static' lambdas defined only once, in a distinct @$__<type>Lambda@ class. The... Constantin Asofiei

12:08 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

> Theodoros wrote:
> Will I need to implement the database functionality?
Yes. Since the 4GL just exposes audit... Greg Shah

10:19 AM Feature #4065: server-side processing of client platform dependencies

The wiki is here: [[p2j:Testcases#Running-Web-tests|Running Web Tests]]. You will need SoapUI, and possible need to ... Constantin Asofiei

10:11 AM Feature #4065: server-side processing of client platform dependencies

Constantin, what is currently the least stressful way to test web-services? Hynek Cihlar

06:09 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Greg Shah wrote:
> Igor: Please create a new task for this and post the recreate, link it here as a Related Task.
>... Igor Skornyakov

06:05 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Greg Shah wrote:
> > can I merge the task branch to the trunk?
>
> Yes
The branch 7123a was merged to the trun... Igor Skornyakov

05:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

> I understand that the issue from note #7193-60 is irrelevant to this task (the @memptr@ deallocation attempt after ... Greg Shah

02:24 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Ovidiu Maxiniuc wrote:
> I reviewed 7193a/14580 and found no problems in this last commit.
>
> I understand that ... Igor Skornyakov

10:04 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

I reviewed 7193a/14580 and found no problems in this last commit.
I understand that the issue from note #7193-60 i... Ovidiu Maxiniuc

06:08 AM Bug #7345: The memptr deallocation attempt after the connection to client is interrupted/suspended

Recently I started to see the following exception at the end of the test session close:... Igor Skornyakov

06:06 AM Bug #7345 (New): The memptr deallocation attempt after the connection to client is interrupted/su...

Igor Skornyakov

05/10/2023

09:02 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Branch 6819a was created from trunk rev 14563. Rev 14564 contains the @(MethodAccess, index)@ arguments at the prox... Constantin Asofiei

01:52 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Greg Shah wrote:
> Is this the core idea: you edit the @_aud-event@ to add/change events that should be audited? ... Marian Edu

05/09/2023

03:42 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

> @Audit Policy Maintenance@ tools is supposed to be used for defining the audit policies - [[https://docs.progress.c... Greg Shah

03:11 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Greg Shah wrote:
> Theodoros: Is there any 4GL code which can be used to enable these default audit events? I don... Marian Edu

02:49 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Yes, the features in [[p2j:Auditing]] are what I was referring to above in #6422-5 as the "SecurityManager Auditing".... Greg Shah

01:42 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Greg/Eric, there is this documentation in OpenEdge: https://docs.progress.com/bundle/openedge-security-auditing-intro... Constantin Asofiei

01:16 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

The auditing is about recording important events. I found a wiki page regarding auditing [[p2j:Auditing]]. It looks l... Theodoros Theodorou

05/08/2023

02:14 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Greg Shah wrote:
> > Recently I started to see the following exception at the end of the test session close:
> > [.... Igor Skornyakov

01:55 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

> Recently I started to see the following exception at the end of the test session close:
> [...]
>
> This happen... Greg Shah

12:39 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Greg Shah wrote:
> Eric: Please review this task in regard to @_aud-audit-data@ and provide guidance.
I am not fa... Eric Faulhaber

11:32 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Good. Please keep going with tests and documentation for the behavior of the rest of the features. I'd like all of ... Greg Shah

10:40 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

There are tests under @testcases/security/audit_control@.
The command @APPL-CONTEXT-ID@ is @?@ by default. The com... Theodoros Theodorou

05/06/2023

01:53 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Recently I started to see the following exception at the end of the test session close:... Igor Skornyakov

01:49 PM Bug #7193 (Review): READ-JSON is not supported for the "LONGCHAR" source type

Ovidiu Maxiniuc wrote:
> Review of 7193a/14570 (compared to previous iteration, 14567).
> * @JsonImport.java@
> **... Igor Skornyakov

05/05/2023

05:48 AM Bug #7193 (WIP): READ-JSON is not supported for the "LONGCHAR" source type

Greg Shah

05:48 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Agreed. Greg Shah

05:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Greg Shah wrote:
> > Before merging this branch to trunk we should test it against Z/POC application.
>
> Ovidiu:... Igor Skornyakov

05:25 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

> Before merging this branch to trunk we should test it against Z/POC application.
Ovidiu: Yes, please do. Greg Shah

02:57 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Rebased 7193a from the trunk/14560.
Pushed up to revision 14578.
Re-testing. Igor Skornyakov

10:28 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Review of 7193a/14570 (compared to previous iteration, 14567).
* @JsonImport.java@
** line 914: you replaced @relat... Ovidiu Maxiniuc

05/04/2023

02:44 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Igor: Please set the % Done. Greg Shah

02:43 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Ovidiu: Please review. Greg Shah

02:43 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Greg Shah wrote:
> Please remove the streams usage.
Done.
Committed to 7193a/14570. Igor Skornyakov

02:33 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Please remove the streams usage. Greg Shah

10:41 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Igor Skornyakov wrote:
> Greg Shah wrote:
> > We've found that runtime code measurably slows down when one uses 5 s... Igor Skornyakov

10:26 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Greg Shah wrote:
> We've found that runtime code measurably slows down when one uses 5 stacks (or any large number) ... Igor Skornyakov

07:50 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

> I do not think that JsonImport is called very often in real apps
JSON processing will be very heavily used in RE... Greg Shah

04:41 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Ovidiu Maxiniuc wrote:
> Review of 7193a/14567, (re-)based on trunk 14552:
> * @TemporaryBuffer.java@: The H note m... Igor Skornyakov

10:53 AM Bug #7272 (Test): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Greg Shah

10:11 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Task branch 7272a was merged to the trunk as rev 14555 and archived. Galya B

09:49 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Go ahead with the merge. Greg Shah

09:40 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Thanks, I think we are OK with what we wanted to solve in this task. Regarding appserver - I see messages being logg... Constantin Asofiei

09:39 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

For appserver do we somehow narrow down the condition in Window further by excluding appserver. Galya B

09:37 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Tested in FWD.
*Batch:*
output.txt... Galya B

09:10 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Please provide a status of how it works with 7272a:
* in ChUI (terminal) - if the message on the screen and in the f... Constantin Asofiei

08:20 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

OK, I get confused by all the garbage output from System.err (hopefully some day it will go away). It's indeed a chan... Galya B

08:06 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya Bogdanova wrote:
> What is chui terminal in OE? In FWD it doesn't have that message area on the bottom, so it ... Constantin Asofiei

08:02 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

What is chui terminal in OE? In FWD it doesn't have that message area on the bottom, so it looks like batch. Galya B

08:00 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Then this condition is not right @boolean switchedOnChui = tc.isChui() && switched; @.
Batch is a kind of ChUI cli... Constantin Asofiei

07:58 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Our "message" ends up straight on the terminal with batch and chui-terminal, while it's not expected there. Galya B

07:57 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

In OE if you run the procedure as batch: @pro -b -p proc.p@, this is what I'm referring to chui (probably not the rig... Galya B

07:54 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya, I don't understand the Window.java change - in ChUI, this code emits the error message, in OpenEdge, in the te... Constantin Asofiei

01:30 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> Galya, please add your changes to the 7272a branch.
Up in 7272a r14554-14556.
Galya B

01:21 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya, please add your changes to the 7272a branch. Constantin Asofiei

01:17 AM Bug #7272 (Review): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya B

01:16 AM Bug #7272 (WIP): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya B

09:42 AM Feature #6649: improve the performance or SourceNameMapper runtime

Joe, I suggest you go with Greg's idea in #6649-17 first. This is relatively simple change and will be a good opportu... Hynek Cihlar

09:19 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Eric: Please review this task in regard to @_aud-audit-data@ and provide guidance. Greg Shah

09:09 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Sorry for the mistake in the email, this task is not ready for review yet.
As I wrote in 7027, the commands @AUDIT... Theodoros Theodorou

06:30 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Code Review Task Branch 6422a Revision 14547
The initial changes seem OK. There may be some slight deviations fro... Greg Shah

05/03/2023

07:50 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Review of 7193a/14567, (re-)based on trunk 14552:
* @TemporaryBuffer.java@: The H note mentions "processed _errors_"... Ovidiu Maxiniuc

03:29 PM Feature #4065 (WIP): server-side processing of client platform dependencies

Hynek Cihlar

03:29 PM Feature #4065: server-side processing of client platform dependencies

4065a merged in to trunk revision 14554 and archived. Hynek Cihlar

03:05 PM Feature #4065: server-side processing of client platform dependencies

Please merge 4065a to trunk. Greg Shah

02:49 PM Feature #4065: server-side processing of client platform dependencies

I reverted the log changes introduced in trunk revision 14535 in 4065a revision 14565. Hynek Cihlar

10:44 AM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> Please remove all the logging changes from rev 14563. Attach a patch for the package name abbrev... Hynek Cihlar

12:57 PM Feature #6410 (Review): implement additional built-in OO classes/interfaces

Attached the patches for skeleton and FWD stubs for #6410a.
There are methods name change in @JsonArray@ that lead... Marian Edu

05/02/2023

05:50 PM Feature #6497: add equivalent support for the -T command line option

The branch 6497a has been rebased to trunk 14553. The new rev no is 14558.
Theodoros Theodorou

09:00 AM Feature #6497: add equivalent support for the -T command line option

Please rebase from the latest trunk and we will review this. Greg Shah

04:57 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

4GL and FWD format ouput JSON files in not exactly the same way. To simplify comparision of 4GL and FWD results I use... Igor Skornyakov

02:09 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Ovidiu: Please review. Greg Shah

02:07 PM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Finished support for DATA-SET:SERIALIZE-HIDDEN.
Committed to 7193a/14567.
Now FWD provides exactly the same outpu... Igor Skornyakov

03:35 PM Feature #4065: server-side processing of client platform dependencies

After 4065a is merged to trunk the following resources still need a server-side implementation:
* process launchin... Greg Shah

03:26 PM Feature #4065: server-side processing of client platform dependencies

Please remove all the logging changes from rev 14563. Attach a patch for the package name abbreviation code to #7279... Greg Shah

01:15 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

About the extra output:
Basically the problem was in:
@Window.java@ states in @message(String message, Color cs, ... Galya B

11:42 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya Bogdanova wrote:
> Can I run .p file in Progress in GUI? I wonder if the system bar messages are even displaye... Constantin Asofiei

11:34 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Can I run .p file in Progress in GUI? I wonder if the system bar messages are even displayed after the redirect to th... Galya B

11:13 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya Bogdanova wrote:
> Do we create a separate task? This one will get some time if I need to address all of the i... Constantin Asofiei

11:12 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Do we create a separate task? This one will get some time if I need to address all of the issues. Not sure how urgent... Galya B

11:11 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

@session:system-alert-boxes = true.@ works for both ChUI and GUI OpenEdge clients (displays dialog-box). Constantin Asofiei

10:50 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> Also, is @system-alert-boxes@ behavior working OK?
It works only in gui, where errors... Galya B

07:07 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

I think we need to restore the silent mode, something like this:... Constantin Asofiei

06:55 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

This patch produces the following output in batch:... Galya B

06:04 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Run the test with @session:system-alert-boxes = false.@ or @session:system-alert-boxes = true.@, in ChUI and GUI, an... Constantin Asofiei

04:49 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Do we expect to see alert boxes?
This code always receives @noMessageBox = false@ and transforms it in @true@ wit... Galya B

10:47 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments

Greg Shah wrote:
> What is the status of this?
This is in 7156a for the customer. What's left is Marian's tests, v... Constantin Asofiei

10:45 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments

What is the status of this? Greg Shah

10:36 AM Feature #6649: improve the performance or SourceNameMapper runtime

Greg Shah wrote:
> It seems to me that nearly all the time in all projects the unqualified filename has very few con... Hynek Cihlar

10:31 AM Feature #6649: improve the performance or SourceNameMapper runtime

It seems to me that nearly all the time in all projects the unqualified filename has very few conflicts in the overal... Greg Shah

09:14 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

I was finally able to understand how it works. So custom events (@eventId >= 32000@) should be added manually using t... Theodoros Theodorou

03:01 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Theodoros Theodorou wrote:
> I think that the table @_aud-audit-data@ holds the records only for the @SET-APPL-CONTE... Marian Edu

08:52 AM Bug #7206: shared frame defined with the same name but different widgets

Code Review Task Branch 7199c Revision 14567
No objections. Greg Shah

05:14 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Done in 6410a/14553. Please review.
Got it, thanks, will see if there is anything miss... Marian Edu

03:06 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> Constantin Asofiei wrote:
> > 7199c rev 14559 contains the implementation for @OpenEdge.Core.Sy... Constantin Asofiei

02:49 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> 7199c rev 14559 contains the implementation for @OpenEdge.Core.System.ArgumentError@. R... Marian Edu

02:46 AM Feature #6410: implement additional built-in OO classes/interfaces

When converting skeleton classes there seems to be some issue with classes that implements interfaces with properties... Marian Edu

05/01/2023

06:04 PM Bug #7317 (Test): accumulator using another accumulator as expression

Code review 7199c/14566: the changes look good. This should go into wider testing. Eric Faulhaber

04:44 PM Bug #7317: accumulator using another accumulator as expression

Eric: Please review. Greg Shah

06:57 AM Bug #7317 (Review): accumulator using another accumulator as expression

4GL allows an accumulator function to be used in the expression of an accumulator statement:... Constantin Asofiei

06:48 AM Bug #7317 (Closed): accumulator using another accumulator as expression

Constantin Asofiei

04:35 PM Bug #7316 (Test): regression in 'ACCUM ... extVar' expansion - subscript not emitted

Code Review Task Branch 7199c Revision 14565
No objections. Greg Shah

06:47 AM Bug #7316 (Review): regression in 'ACCUM ... extVar' expansion - subscript not emitted

This test:... Constantin Asofiei

06:38 AM Bug #7316 (Closed): regression in 'ACCUM ... extVar' expansion - subscript not emitted

Constantin Asofiei

04:31 PM Bug #7315 (Test): unknown literal passed as an argument to a 'object' parameter

Code Review Task Branch 7199c Revision 14564
No objections. Greg Shah

06:35 AM Bug #7315 (Review): unknown literal passed as an argument to a 'object' parameter

This case:... Constantin Asofiei

06:31 AM Bug #7315 (Closed): unknown literal passed as an argument to a 'object' parameter

Constantin Asofiei

04:23 PM Bug #7314 (Test): conversion issue for FIRST-OF(f1) when there is a collision between the field n...

Code Review Task Branch 7199c Revision 14563
No objections. Greg Shah

06:30 AM Bug #7314: conversion issue for FIRST-OF(f1) when there is a collision between the field name and...

Fixed in 7199c rev 14563. Constantin Asofiei

06:30 AM Bug #7314 (Review): conversion issue for FIRST-OF(f1) when there is a collision between the field...

The problem is described by this test:... Constantin Asofiei

06:26 AM Bug #7314 (Closed): conversion issue for FIRST-OF(f1) when there is a collision between the field...

Constantin Asofiei

04:18 PM Bug #7313 (Test): regression in '<record-phrase> USING FRAME f field'

Code Review Task Branch 7199c Revision 14562
No objections. Greg Shah

06:23 AM Bug #7313 (Review): regression in '<record-phrase> USING FRAME f field'

A @find tt1 using frame f1 tt1.f1@ was refactoring the @frame f1 tt1.f1@ to an @INPUT@ function, which is done separa... Constantin Asofiei

06:20 AM Bug #7313 (Closed): regression in '<record-phrase> USING FRAME f field'

Constantin Asofiei

04:14 PM Bug #7312 (Test): mtime(character) is allowed in 4GL

Code Review Task Branch 7199c Revision 14561
No objections. Greg Shah

06:18 AM Bug #7312 (Review): mtime(character) is allowed in 4GL

@mtime(character)@ will raise a @Unacceptable datatype for MTIME argument. 12117@ ERROR condition.
Committed to 71... Constantin Asofiei

06:15 AM Bug #7312 (Closed): mtime(character) is allowed in 4GL

Constantin Asofiei

04:11 PM Bug #7311 (Test): abs(integer) must return int64

Code Review Task Branch 7199c Revision 14560
No objections. Greg Shah

06:14 AM Bug #7311 (Review): abs(integer) must return int64

... Constantin Asofiei

05:58 AM Bug #7311 (Closed): abs(integer) must return int64

Constantin Asofiei

04:07 PM Bug #7310 (Test): buffer scope in constructor/destructor is not computed correctly

Code Review Task Branch 7199c Revision 14558
No objections. Greg Shah

05:52 AM Bug #7310 (Review): buffer scope in constructor/destructor is not computed correctly

The fix is in 7199c/14558 Constantin Asofiei

04:23 AM Bug #7310: buffer scope in constructor/destructor is not computed correctly

The issue is when there is an explicit buffer defined with the same name as a buffer in a constructor or destructor:
... Constantin Asofiei

04:21 AM Bug #7310 (Closed): buffer scope in constructor/destructor is not computed correctly

Constantin Asofiei

03:48 PM Bug #7308 (Test): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, wh...

Code Review Task Branch 7199c Revision 14557
No objections. Greg Shah

05:49 AM Bug #7308 (Review): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, ...

The fix is in 7199c rev 14557 Constantin Asofiei

12:38 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > So when @invokeFailure@ is reached you know that this is a c... Constantin Asofiei

12:36 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> So when @invokeFailure@ is reached you know that this is a case of an external program.
... Galya B

12:31 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya, @invokeFailure@ is ever only called for a failure of a @RUN externalprogram.p@ statement; it never gets called... Constantin Asofiei

12:21 PM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

On line 7159 in @ControlFlowOps.invokeImpl@ the error is to be displayed with @invokeFailure(name)@:... Galya B

11:57 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> I think it may be possible to disable silent error processing in @ControlFlowOps.invokeF... Galya B

11:32 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya Bogdanova wrote:
> This should not be considered @silent@ in FWD - it should display an alert and fill in ER... Constantin Asofiei

11:31 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> Regarding #7272-16 - please solve also the missing alert - if with NO-ERROR OpenEdge sti... Galya B

11:24 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya Bogdanova wrote:
> > > I believe the stop condition is always raised. @must not show@ message is never shown i... Constantin Asofiei

11:20 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > Constantin Asofiei wrote:
> > > Galya, please focus on @Con... Galya B

11:19 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> * properly add the error message to ERROR-STATUS and also display it.
Just to make it... Galya B

11:17 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > Galya, please focus on @ControlFlowOps.invokeFailure@ - the ... Constantin Asofiei

11:16 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> Galya, please focus on @ControlFlowOps.invokeFailure@ - the problem is there, we need to... Galya B

11:07 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya, please focus on @ControlFlowOps.invokeFailure@ - the problem is there, we need to adjust that code to:
* keep... Constantin Asofiei

11:06 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

I think the issue is in the converted code that considers it a silent invokation:... Galya B

10:20 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

I'll focus on 1. for this task. Starting to debug. Galya B

10:15 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Check the diff in batch output redirect files in the attached diff file, shown here as an image:
!OE-vs-FWD-batch-ou... Galya B

09:43 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Complete test results for the procedure in #7272#note-7:
*1.* executed as batch in Progress results in this output... Galya B

08:26 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin, I'm testing it now. I just wanted to make clear it's not related to the above mentioned change. Galya B

08:24 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Galya, this is not a bug related to your changes. This is an existing bug which we need to fix; please see this test... Constantin Asofiei

07:57 AM Bug #7272: RUN ... NO-ERROR must log the 'missing.p was not found' message, always.

Constantin Asofiei wrote:
> Also, with 5753d, @ControlFlowOps.invokeFailure@ was changed from this:
> [...]
> to t... Galya B

10:11 AM Bug #7206: shared frame defined with the same name but different widgets

The fix for this 'unused shared frame' must apply to @NEW SHARED@ frames, too. Fixed in 7199c/14567 Constantin Asofiei

06:33 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

> If you believe that we have to reproduce the quirks mentioned above I suggest to deeal with it in sce scope of #724... Greg Shah

05:57 AM Feature #6410: implement additional built-in OO classes/interfaces

7199c rev 14559 contains the implementation for @OpenEdge.Core.System.ArgumentError@. Required by #7199 Constantin Asofiei

05:16 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge

7250a changes were committed to 7199c rev 14556.
7250a was dead-archived. Constantin Asofiei

05:14 AM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker

7304a changes were committed to 7199c rev 14555.
7304a was dead-archived. Constantin Asofiei

05:11 AM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method

Greg Shah wrote:
> It seems that this logic may be broken if the @recordName@ is a qualified name. Otherwise I have... Constantin Asofiei

04:50 AM Bug #7240: conversion problem related to ENTERED in a IF expr

Constantin Asofiei wrote:
> Another case somehow related to #7178 - @tt1.f1 [not] entered@ must not produce a buffe... Constantin Asofiei

04/29/2023

06:05 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type

Igor Skornyakov wrote:
> Implemented DATA-SET:WRITE-XMLSCHEMA with SERIALIZE-HIDDEN = true.
> Committed to 7193a/1... Igor Skornyakov