Activity
From 07/15/2023 to 08/13/2023
08/11/2023
- 10:56 AM Bug #5538 (Review): fix readByte() for DirStream, ProcessStream, and others
- 10:56 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others
- Once these items are addressed, what testing is needed before this can be merged?
- 10:55 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Eric: This needs your code review.
- 10:55 AM Feature #6420: implement the AUDIT-ENABLED() built-in function
- Eric: This needs your code review.
- 10:53 AM Feature #6425: SESSION handle features
- Some changes for this task were written in branch 4938b and were merged into trunk as revision 14688. Runtime suppor...
- 10:52 AM Feature #4391 (Closed): enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -l...
- The changes for this task were written in branch 4938b and were merged into trunk as revision 14688. Runtime support...
- 10:51 AM Feature #6497 (Closed): add equivalent support for the -T command line option
- The changes for this task were written in branch 4938b and were merged into trunk as revision 14688.
08/07/2023
- 07:01 PM Bug #5538 (Test): fix readByte() for DirStream, ProcessStream, and others
- Review of 5538a/14681.
I agree with the code. Just two notes about code:
* please move comments from lines 462 an... - 05:33 PM Feature #6425 (WIP): SESSION handle features
08/04/2023
- 05:48 PM Bug #5538 (Review): fix readByte() for DirStream, ProcessStream, and others
- The implementations of the abstract @Stream.readByte()@ are the following:
ClipboardStream:... - 08:30 PM Bug #5538 (WIP): fix readByte() for DirStream, ProcessStream, and others
- 02:09 PM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- Agreed! It is a really good find.
- 01:13 PM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- Greg, this looks promising.
The @access@ synthetic methods are a pitfall of using inner classes and assuming a pri... - 10:42 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- I've done the test. The results are quite good. I tested with 7156b/rev. 14663 and your changes are close to -0.5%.
08/03/2023
- 11:57 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- I've tested with ControlFlowOps, ProcedureManager and TransactionManager. I don't see a definite improvement, the ti...
- 08:23 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- Greg Shah wrote:
> Is it worth it to manually try the changes to TM so we know the benefit?
Yes, I think so. There... - 08:19 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- Is it worth it to manually try the changes to TM so we know the benefit?
- 08:13 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- Greg Shah wrote:
> Did you test the change for the TM to see what the performance difference is?
Not yet. I'm work... - 08:11 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- The lesson here is that compiler generated helpers are often costly.
- 08:10 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- Good find. This seems like it should have good potential.
Did you test the change for the TM to see what the perf... - 08:10 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- The same happens when accessing a private field: access to a private field from a non-defining class will be done via...
- 06:38 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
- In the profiler, I noticed that for i.e. @TransactionManager$TransactionHelper.deregisterOutputParameterAssigner@, th...
- 06:22 AM Bug #7656 (New): investigate performance of context-local helpers (e.g. TransactionManager.Transa...
- 11:17 AM Feature #6493: add equivalent support for the command line parameters -ucc and -utf8intatchar
- If this support requires "wide character" support in ncurses, then we may need some changes to ensure our support mat...
- 10:10 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
- > As I understand, we are trying to emulate a keyboard based on the -cpinternal?
Not exactly. In the 4GL, the @C...
08/02/2023
- 05:41 PM Feature #6431 (WIP): implement support to allow CPINTERNAL set to UTF-8 and CP936
- 05:36 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
- I would like to ask for some guidance for this task. As I understand, we are trying to emulate a keyboard based on th...
- 04:00 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Alexandru Lungu wrote:
> > There is another approach: in a FOR EACH block, is the navigation always done via query.n... - 03:55 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- > There is another approach: in a FOR EACH block, is the navigation always done via query.next()? If yes, we can:
> ...
08/01/2023
- 10:07 AM Support #4032: block/transaction processing context-local and other performance improvements
- Code Review Task Branch 4032a Revisions 14680 through 14682
The changes look good. They also seem fairly low risk. - 08:05 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- > Now that such iterating statement is removed, the block is unaware of the iteration type
I think I understand yo... - 07:46 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- *Created 7045b.*
Committed conversion changes to 7045b/rev. 14678. This is still a prototype as there is no run-ti...
07/31/2023
- 01:32 PM Feature #6410: implement additional built-in OO classes/interfaces
- OK, then let's get this patch into trunk using a different branch.
- 01:10 PM Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> Do you think we are ready to merge 6410a to trunk?
No. @Method:invoke@ and @Class:getMethod(s)@... - 12:47 PM Feature #6410: implement additional built-in OO classes/interfaces
- Do you think we are ready to merge 6410a to trunk?
- 11:30 AM Feature #6410: implement additional built-in OO classes/interfaces
- Greg, I have this patch for an issue with @Progress.Lang.Class:invoke@ - we need to re-throw the structured exception...
- 08:41 AM Bug #7643 (Test): memory leak in AssociatedThread
- 08:29 AM Bug #7643: memory leak in AssociatedThread
- Branch 7643a was merged to trunk rev 14677 and archived.
- 08:27 AM Bug #7643: memory leak in AssociatedThread
- Code Review Task Branch 7643a Revision 14677
It looks good.
You can merge to trunk. - 08:24 AM Bug #7643: memory leak in AssociatedThread
- Fixed in 7643a rev 14677.
- 08:18 AM Bug #7643: memory leak in AssociatedThread
- Agreed.
- 08:17 AM Bug #7643: memory leak in AssociatedThread
- I'm thinking of keeping this new ThreadLocal field set only once; previously, for a thread, the value got changed eac...
- 07:41 AM Bug #7643: memory leak in AssociatedThread
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Code Review Task Branch 7643a Revision 14676
> >
> > Shouldn't ... - 07:36 AM Bug #7643: memory leak in AssociatedThread
- Greg Shah wrote:
> Code Review Task Branch 7643a Revision 14676
>
> Shouldn't we just change @endContext()@ to re... - 07:23 AM Bug #7643: memory leak in AssociatedThread
- Code Review Task Branch 7643a Revision 14676
Shouldn't we just change @endContext()@ to remove the thread id as pa... - 05:56 AM Bug #7643 (Review): memory leak in AssociatedThread
- Created task branch 7643a from trunk rev 14675.
The fix is in 7643a rev 14676. - 08:41 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- > Constantin's solution looks clean, so I will start working around it.
Agreed. Go ahead. - 08:35 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg Shah wrote:
> > introduce a new lambda block between @Init@ and @Body@, namely @Iter@. This will be a boolean s... - 08:01 AM Bug #7644 (Test): load all legacy enums on FWD server startup
- 07:57 AM Bug #7644: load all legacy enums on FWD server startup
- Branch 7644a was merged to trunk rev 14676 and archived.
- 07:41 AM Bug #7644: load all legacy enums on FWD server startup
- If you want to merge 7644a to trunk, you can go ahead.
- 07:37 AM Bug #7644: load all legacy enums on FWD server startup
- Greg Shah wrote:
> Code Review Task Brnach 7644a Revision 14676
>
> I don't have an objection, however I do wonde... - 07:32 AM Bug #7644: load all legacy enums on FWD server startup
- Code Review Task Brnach 7644a Revision 14676
I don't have an objection, however I do wonder if there is a performa... - 06:20 AM Bug #7644 (Review): load all legacy enums on FWD server startup
- Created task branch 7644a from trunk rev 14675.
The fix is in rev 14676 - the @public static final@ field definiti...
07/28/2023
- 04:27 PM Bug #7644: load all legacy enums on FWD server startup
- The legacy enum values are defined as Java 'static final' - and created in a static constructor. The problem here is...
- 04:21 PM Bug #7644 (Test): load all legacy enums on FWD server startup
- 03:09 PM Bug #7643: memory leak in AssociatedThread
- In a large GUI application, in a thread dump @SecurityManager.threadIds@ is reported to have a size of 120k (for refe...
- 02:58 PM Bug #7643 (Test): memory leak in AssociatedThread
- 11:09 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Constantin Asofiei wrote:
> There is another approach: in a @FOR EACH@ block, is the navigation always done via @que... - 09:55 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- @FOR FIRST@ and @FOR LAST@ get converted to @forBlock@. I think it should work by injecting the @P2JQuery@ instance ...
- 09:48 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- There is another approach: in a @FOR EACH@ block, is the navigation always done via @query.next()@? If yes, we can:
... - 09:37 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- > introduce a new lambda block between @Init@ and @Body@, namely @Iter@. This will be a boolean supplier. If this boo...
- 08:59 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I analyzed the problem and understand most of the issue. I also have designed a solution here. However, I still have ...
07/27/2023
- 10:56 AM Bug #7604 (Test): Switch does not honor case sensitivity of character
- 10:54 AM Bug #7604 (Review): Switch does not honor case sensitivity of character
- Merged 7464a in trunk as rev. 14673. Archived 7464a.
07/25/2023
- 01:04 PM Bug #7460: implement Progress.Lang.Class:getMethods
- Did pushed local changes in #6410a - rev 14556, probably missed release notes.
The idea was to directly use the Ja... - 07:41 AM Feature #7045 (WIP): re-implement "normal" (non-abend) stack unwinding to avoid throwing an excep...
07/24/2023
- 07:36 AM Support #4032: block/transaction processing context-local and other performance improvements
- 4032a was created from trunk rev 14668.
4032a rev 14669 contains another batch of context-local improvements.
07/21/2023
- 10:47 AM Bug #7604: Switch does not honor case sensitivity of character
- Committed on 7464a revision 14664.
- 02:41 AM Bug #7604: Switch does not honor case sensitivity of character
- Alexandru Lungu wrote:
> This is quite "cryptic" :) Eduard, please make some second/third rechecks before Redmine po...
07/20/2023
- 05:14 PM Feature #6497: add equivalent support for the -T command line option
- Greg Shah wrote:
> What do you mean by this? Show some 4GL code and output to demonstrate.
> ...
> What do you me... - 11:17 AM Feature #6497: add equivalent support for the -T command line option
- Theodoros Theodorou wrote:
> OE throws an error if the temporary directory provided as a startup parameter is proble... - 11:13 AM Feature #6497: add equivalent support for the -T command line option
- > OE throws an error if
What do you mean by this? Show some 4GL code and output to demonstrate.
> It throws an... - 10:26 AM Feature #6497: add equivalent support for the -T command line option
- OE throws an error if the temporary directory provided as a startup parameter is problematic (e.g. permission issue o...
- 10:44 AM Bug #7604: Switch does not honor case sensitivity of character
- > offset and length paramentes from substring function, isCaseInsensitive method for ExpressionConversionWorker.java ...
- 10:05 AM Bug #7604: Switch does not honor case sensitivity of character
- ...
- 09:13 AM Bug #7604 (WIP): Switch does not honor case sensitivity of character
- 08:17 AM Bug #7604: Switch does not honor case sensitivity of character
- Please go ahead and fix this.
- 07:28 AM Bug #7604: Switch does not honor case sensitivity of character
- Tested @switch@ with following cases:
- character variable case-insensitive
- character variable case-sensitive
... - 05:49 AM Bug #7604: Switch does not honor case sensitivity of character
- ...
- 05:34 AM Bug #7604 (Closed): Switch does not honor case sensitivity of character
- 08:02 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg Shah wrote:
> * Insert code after each persistence call in the converted code which can generate @QueryOffEndEx... - 07:56 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I know it is late in the month to consider changes to our performance workplan. I do believe that this task has very...
07/19/2023
- 11:23 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian, from the @tests/oo@ @@TestSuite@ files I could run in OpenEdge, this one I had to manually change:...
- 10:27 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- I've ran @tests.oo.method_resolve.TestSuiteMethodResolve@ in OpenEdge 11.6.3 and the only test that fails is this:
... - 11:05 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- Task branch 4855b was merged to trunk as rev 14665 and archived.
- 10:22 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- You can merge to trunk.
- 08:29 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- Do I merge?
- 08:02 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- Review for 4855b/14665 - I'm OK with the changes.
- 07:22 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- 4855b r14665 ready for review.
This is the output of the test proc:... - 06:53 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- You need this code adjusted for SESSION-ID, in methods-attributes.rules, the section for SESSION handle:...
- 05:26 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- 4855b r14663-14664 I can't make it work:...
- 03:23 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- This test needs to work properly to validate the fix:...
- 03:05 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- Can I now have a different keyword like I wanted, or we'll make it writable although it makes no sense?
- 03:03 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- @SESSION:SESSION-ID@ will become writable.
- 02:58 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- Do I need to invent something or you can point me to an example or programming principle?
- 01:26 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- The changes in trunk rev 14661 are not OK. As SESSION-ID exists now at both CLIENT-PRINCIPAL and SESSION, we need th...
07/18/2023
- 02:23 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- I was thinking that instead of wrapping the POLY expr in a constructor with the expected type, emit a @Parameter.forT...
- 01:19 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- The most important part missing in FWD I think is this: at compile time, OpenEdge hard-links the call to invoke the e...
- 01:17 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > >Please run the test in #7299-30 i... - 01:17 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian Edu wrote:
> Constantin Asofiei wrote:
> >Please run the test in #7299-30 in your OpenEdge and let me know i... - 01:15 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin Asofiei wrote:
>Please run the test in #7299-30 in your OpenEdge and let me know if you see the same erro... - 12:11 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian Edu wrote:
> It might run fine but it's still wrong, this should not happen - the copile time resolution shou... - 12:08 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin Asofiei wrote:
> I'm running with 11.6.3.
Sadly the oldest we have available is @11.7@ and that will pro... - 11:59 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please run this on your side:
> Not sure, we have the @CTest@ in... - 11:46 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin Asofiei wrote:
> Please run this on your side:
Not sure, we have the @CTest@ in @tests.oo.support@ so ha... - 11:38 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Please run this on your side:...
- 11:26 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin Asofiei wrote:
> Marian, there is something wrong with the @TestLastMethodReturnTypeChainedCall.testLastO... - 09:29 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Marian, there is something wrong with the @TestLastMethodReturnTypeChainedCall.testLastOverloadHasDifferentReturnType...
- 07:51 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
- Constantin Asofiei wrote:
> -Created task branch 7229b from trunk rev 14661.-
This branch was physically removed, 7... - 05:18 AM Bug #7299 (WIP): resolution of the target OO method in chained calls with poly arguments
- -Created task branch 7229b from trunk rev 14661.-
- 11:47 AM Feature #6410: implement additional built-in OO classes/interfaces
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > > The problem here is that @Legacy... - 11:40 AM Feature #6410: implement additional built-in OO classes/interfaces
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > The problem here is that @LegacyClass.invoke@ resolves the target... - 11:33 AM Feature #6410: implement additional built-in OO classes/interfaces
- Constantin Asofiei wrote:
> The problem here is that @LegacyClass.invoke@ resolves the target at each invocation, de... - 09:14 AM Feature #6410: implement additional built-in OO classes/interfaces
- Marian Edu wrote:
> One question here, I'm looking at the 'invoke' method and that was implemented straight into the... - 09:07 AM Feature #6410: implement additional built-in OO classes/interfaces
- One question here, I'm looking at the 'invoke' method and that was implemented straight into the class (LegacyClass) ...
- 07:48 AM Feature #4855 (Closed): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID whi...
- 12:57 AM Feature #4855 (Test): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which...
- Task branch 4855a was merged to trunk as rev 14661 and archived. Email sent.
07/17/2023
- 03:43 PM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
- You can rebase and merge 4855a to trunk.
Also available in: Atom