FWD » Core Development » Base Language

09/11/2023

11:24 AM Bug #7460: implement Progress.Lang.Class:getMethods

Marian Edu wrote:
> > ** @ErrorManager.recordOrThrowError@ must be followed by a @return@.
> Will fix that, as said... Constantin Asofiei

10:52 AM Bug #7460: implement Progress.Lang.Class:getMethods

Constantin Asofiei wrote:
> Review for 6410a rev 14571:
> * @LegacyClass.java@
> ** we need to cache the @Legacy4G... Marian Edu

08:11 AM Bug #7460: implement Progress.Lang.Class:getMethods

Review for 6410a rev 14571:
* @LegacyClass.java@
** we need to cache the @Legacy4GLMethod@ instances and resolve th... Constantin Asofiei

08:09 AM Bug #7604 (Closed): Switch does not honor case sensitivity of character

Greg Shah

07:49 AM Bug #7604: Switch does not honor case sensitivity of character

Greg, we can close this. Alexandru Lungu

07:37 AM Bug #7604: Switch does not honor case sensitivity of character

Yes, conversion seems good. Eduard Soltan

07:30 AM Bug #7604: Switch does not honor case sensitivity of character

Eduard, now that the change reached customer applications (newer binaries), please check that conversion is OK, so we... Alexandru Lungu

09/07/2023

10:59 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

I've continued working on 7045b. I mostly covered some issues with @CompoundQuery@. Currently, I am still facing some... Alexandru Lungu

09/06/2023

05:24 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin: Please review.
We need to get our OO support to the 100% mark sooner rather than later. Otherwise we ... Greg Shah

09/05/2023

08:09 AM Feature #6410 (Review): implement additional built-in OO classes/interfaces

Completed most of getMethod/getMethods implementation, please review.
There are a few things remaining:
* package... Marian Edu

08/31/2023

10:56 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Agreed. Greg Shah

10:49 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Greg Shah wrote:
> Full changes.
OK, then I think we need this:
* for all inner classes which have fields accessed... Constantin Asofiei

10:43 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Full changes. Greg Shah

10:30 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Thank you, Alexandru.
Greg: how do you want to proceed? Get the full changes or just the critical classes?
Constantin Asofiei

10:22 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

I tested with 7156b/rev. 14732 (which was on 8.193s) patched with 7656a / rev. 14722 + 14723 and got 8.158ms. This me... Alexandru Lungu

04:51 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Alexandru, in 7656a rev 14723 I have the automated changes to modify 'private' to 'package private' fields/methods wh... Constantin Asofiei

06:34 AM Support #4032: block/transaction processing context-local and other performance improvements

4032b was rebased from trunk rev 14721.
4032b rev 14722 contains a small batch of performance improvements related... Constantin Asofiei

08/29/2023

05:01 PM Bug #7759: improve CASE statement for integer type

Constantin,
I was not aware of the 64 bit limitation of Java @switch@ statement. Probably we will need to use the... Ovidiu Maxiniuc

06:59 AM Bug #7759: improve CASE statement for integer type

What I had in mind (for integer type, as Java switch AFAIK works with 32 bit values, not 64, at least for Java 8), is... Constantin Asofiei

06:56 AM Bug #7759: improve CASE statement for integer type

From an email discussion:
Constantin Asofiei wrote:
> Quick question, I don't recall if this is how it is suppose... Constantin Asofiei

06:54 AM Bug #7759 (New): improve CASE statement for integer type

Constantin Asofiei

07:46 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Thanks, so we need what I mentioned before, we need to fix @B... Constantin Asofiei

07:45 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Thanks, so we need what I mentioned before, we need to fix @BaseObject.getNextSibling@... Marian Edu

07:45 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please check also what @Progress.Reflect.Method:next-sibling@ ret... Marian Edu

07:44 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please check also what @Progress.Reflect.Method:next-sibling@ ret... Constantin Asofiei

07:43 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Please check also what @Progress.Reflect.Method:next-sibling@ returns - is it always unk... Marian Edu

07:39 AM Feature #6410: implement additional built-in OO classes/interfaces

Please check also what @Progress.Reflect.Method:next-sibling@ returns - is it always unknown? If yes, maybe this (and... Constantin Asofiei

07:37 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Marian, can these be created outside of FWD runtime (i.e. by the application?) If these... Marian Edu

07:25 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian, can these be created outside of FWD runtime (i.e. by the application?) If these can only be created by FWD r... Constantin Asofiei

07:19 AM Feature #6410: implement additional built-in OO classes/interfaces

From Marian Edu:
> think I've stumbled upon the same problem before but can't remember exactly the use case nor the ... Constantin Asofiei

08/24/2023

10:07 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

This is an update on 7045b:
* I didn't faced any conversion issues in the meantime. Everything is good with #7045 ... Alexandru Lungu

07:45 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Constantin Asofiei wrote:
> Alexandru, there is a concern; if we compare case-insensitive, there is no guarantee th... Alexandru Lungu

06:00 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Alexandru, there is a concern; if we compare case-insensitive, there is no guarantee that a lowercase and an upperca... Constantin Asofiei

05:10 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Alexandru Lungu wrote:
> Danut, please get this done *asap*. I am planning to do a set of regression tests + profili... Dănuț Filimon

03:46 AM Bug #7722 (WIP): improve performance of equals/not equals when used with character/longchar

Alexandru Lungu

03:46 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Danut, please get this done *asap*. I am planning to do a set of regression tests + profiling. I am keen on getting t... Alexandru Lungu

08/22/2023

08:27 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

*Review of 7722a/rev.14704*
* Use Override annotation for @equals@ in @Text@. Make it return false if the paramete... Alexandru Lungu

06:58 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

*Committed 7722a/rev.14704*. Added Text.equals() method which uses @regionMatches@. The method is called in @CompareO... Dănuț Filimon

05:22 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Created 7722a. Alexandru Lungu

03:27 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Constantin Asofiei wrote:
> This only works with intern'ed strings, right?
Right. In FWD-H2 this short-circuit ha... Alexandru Lungu

07:28 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

How has it been tested? Greg Shah

08/21/2023

03:13 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

Can I get into the queue for merging this branch? Theodoros Theodorou

11:10 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Alexandru Lungu wrote:
> This makes sense. We have some recent implementation in FWD-H2 that was targeting this exac... Constantin Asofiei

08:46 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

This makes sense. We have some recent implementation in FWD-H2 that was targeting this exact issue. We can even compa... Alexandru Lungu

06:20 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

In a large app, there are ~350k calls of @Text.compareTo@ which originate from equals/not-equals operators (via @Comp... Constantin Asofiei

06:14 AM Bug #7722 (WIP): improve performance of equals/not equals when used with character/longchar

Constantin Asofiei

08/18/2023

05:38 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936

I think this task will drive me crazy.... Theodoros Theodorou

08/17/2023

04:49 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936

... Theodoros Theodorou

07:36 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936

Look at statements like @PUT@, @EXPORT@, @IMPORT@, @INPUT FROM@, @OUTPUT TO@. I/O in different character sets is the... Greg Shah

07:32 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936

Can you please help me by giving me a 4GL code to do I/O in different charsets? (UTF-8 / CP936) Theodoros Theodorou

08/16/2023

09:00 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

The branch 5538a has been rebased to trunk with rev no 14697. Theodoros Theodorou

06:20 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

Since the indeterminate order of input is an existing issue, we will ignore it here. Greg Shah

06:19 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

Anything using @INPUT THROUGH@, @INPUT-OUTPUT THROUGH@ or @OUTPUT THROUGH@ creates a child process and uses that as a... Greg Shah

06:18 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

... Greg Shah

08/15/2023

05:16 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

It looks like the developer who implemented the @ProcessStream@ was aware of the issue. I found in the javadoc (@Proc... Theodoros Theodorou

08/14/2023

05:41 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

In these situations we do our testcases and run them against 4GL to see the actual behaviour. Along the years we enco... Ovidiu Maxiniuc

04:13 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

Ovidiu Maxiniuc wrote:
> My point is that, instead of @WhileBlack@ the result would be @WBlackhite@. If I am right, ... Theodoros Theodorou

01:01 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

I had some thought about the implementation of this issue over the weekend. The current implementation scans both @ou... Ovidiu Maxiniuc

11:20 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

As with most of what we do, it makes most sense to implement 4GL code that can test this. Pure Java unit tests don't... Greg Shah

10:09 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

Ovidiu Maxiniuc wrote:
> Review of 5538a/14681.
>
> I agree with the code. Just two notes about code:
> * please... Theodoros Theodorou

03:12 PM Feature #6425: SESSION handle features

Greg Shah wrote:
> Theodoros: Please list those things that are complete and those things (other than the items in #... Theodoros Theodorou

06:26 AM Support #4032: block/transaction processing context-local and other performance improvements

Branch 4032a was merged to trunk rev 14689 and archived.
I've created 4032b from trunk rev 14689 where there will ... Constantin Asofiei

06:12 AM Support #4032: block/transaction processing context-local and other performance improvements

Please merge 4032a to trunk. Greg Shah