FWD » Core Development » Base Language

09/18/2023

03:24 PM Bug #7460: implement Progress.Lang.Class:getMethods

Tried the obvious choice @BaseDataType@ as return type and this could work if we update the blocks to create a proxy ... Marian Edu

03:08 PM Bug #7460: implement Progress.Lang.Class:getMethods

Constantin Asofiei wrote:
> what I mentioned about @invoke@ to use @BlockManager.functio@).
Yeah, as said the @invo... Marian Edu

02:04 PM Bug #7460: implement Progress.Lang.Class:getMethods

Marian, at this point, lets leave this behavior on the side for now. We need the implementation of @progress.lang.me... Constantin Asofiei

02:02 PM Bug #7460: implement Progress.Lang.Class:getMethods

All this doesn't look like expected behaviour imho and since those are all internal objects anyway let me know if you... Marian Edu

02:00 PM Bug #7460: implement Progress.Lang.Class:getMethods

Constantin Asofiei wrote:
> Marian, what happens if you use @=@ operator, and not Equals/ToString methods? If they ... Marian Edu

01:51 PM Bug #7460: implement Progress.Lang.Class:getMethods

Marian, what happens if you use @=@ operator, and not Equals/ToString methods? If they are the same reference, this ... Constantin Asofiei

01:18 PM Bug #7460: implement Progress.Lang.Class:getMethods

Constantin Asofiei wrote:
> These @Parameter@, @Legacy4GLMethod@, etc, instances are immutable, right?
There seem... Marian Edu

03:11 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR

Constantin, can we close this? Vladimir Tsichevski

03:39 AM Bug #5538 (WIP): fix readByte() for DirStream, ProcessStream, and others

Theodoros Theodorou

09/15/2023

01:41 PM Bug #7460: implement Progress.Lang.Class:getMethods

Greg Shah wrote:
> Marian: Are you close to committing the next version of this?
I’ll try to push that by Monday,... Marian Edu

11:13 AM Bug #7460: implement Progress.Lang.Class:getMethods

Marian: Are you close to committing the next version of this? Greg Shah

10:26 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

Eric: Please review. Greg Shah

10:18 AM Feature #6649: improve the performance or SourceNameMapper runtime

Another thing to consider with this "search inversion" idea is whether we can avoid the propath scanning process by r... Greg Shah

10:14 AM Feature #6649: improve the performance or SourceNameMapper runtime

I think the idea from #6649-17 has the greatest potential for improvement, though the caching from #6649-16 might als... Greg Shah

08:56 AM Feature #6649: improve the performance or SourceNameMapper runtime

From #6649-16, I understood that we should execute the lookup function with the unqualified filename, then resume sea... Dănuț Filimon

09/14/2023

08:17 AM Feature #6649: improve the performance or SourceNameMapper runtime

I did a test on a large customer application for #6649-16 where I got a total of *42846* calls to @SourceNameMapper.c... Dănuț Filimon

09/13/2023

08:16 AM Feature #6649 (WIP): improve the performance or SourceNameMapper runtime

Greg Shah

09/11/2023

11:24 AM Bug #7460: implement Progress.Lang.Class:getMethods

Marian Edu wrote:
> > ** @ErrorManager.recordOrThrowError@ must be followed by a @return@.
> Will fix that, as said... Constantin Asofiei

10:52 AM Bug #7460: implement Progress.Lang.Class:getMethods

Constantin Asofiei wrote:
> Review for 6410a rev 14571:
> * @LegacyClass.java@
> ** we need to cache the @Legacy4G... Marian Edu

08:11 AM Bug #7460: implement Progress.Lang.Class:getMethods

Review for 6410a rev 14571:
* @LegacyClass.java@
** we need to cache the @Legacy4GLMethod@ instances and resolve th... Constantin Asofiei

08:09 AM Bug #7604 (Closed): Switch does not honor case sensitivity of character

Greg Shah

07:49 AM Bug #7604: Switch does not honor case sensitivity of character

Greg, we can close this. Alexandru Lungu

07:37 AM Bug #7604: Switch does not honor case sensitivity of character

Yes, conversion seems good. Eduard Soltan

07:30 AM Bug #7604: Switch does not honor case sensitivity of character

Eduard, now that the change reached customer applications (newer binaries), please check that conversion is OK, so we... Alexandru Lungu

09/07/2023

10:59 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

I've continued working on 7045b. I mostly covered some issues with @CompoundQuery@. Currently, I am still facing some... Alexandru Lungu

09/06/2023

05:24 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin: Please review.
We need to get our OO support to the 100% mark sooner rather than later. Otherwise we ... Greg Shah

09/05/2023

08:09 AM Feature #6410 (Review): implement additional built-in OO classes/interfaces

Completed most of getMethod/getMethods implementation, please review.
There are a few things remaining:
* package... Marian Edu

08/31/2023

10:56 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Agreed. Greg Shah

10:49 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Greg Shah wrote:
> Full changes.
OK, then I think we need this:
* for all inner classes which have fields accessed... Constantin Asofiei

10:43 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Full changes. Greg Shah

10:30 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Thank you, Alexandru.
Greg: how do you want to proceed? Get the full changes or just the critical classes?
Constantin Asofiei

10:22 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

I tested with 7156b/rev. 14732 (which was on 8.193s) patched with 7656a / rev. 14722 + 14723 and got 8.158ms. This me... Alexandru Lungu

04:51 AM Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...

Alexandru, in 7656a rev 14723 I have the automated changes to modify 'private' to 'package private' fields/methods wh... Constantin Asofiei

06:34 AM Support #4032: block/transaction processing context-local and other performance improvements

4032b was rebased from trunk rev 14721.
4032b rev 14722 contains a small batch of performance improvements related... Constantin Asofiei

08/29/2023

05:01 PM Bug #7759: improve CASE statement for integer type

Constantin,
I was not aware of the 64 bit limitation of Java @switch@ statement. Probably we will need to use the... Ovidiu Maxiniuc

06:59 AM Bug #7759: improve CASE statement for integer type

What I had in mind (for integer type, as Java switch AFAIK works with 32 bit values, not 64, at least for Java 8), is... Constantin Asofiei

06:56 AM Bug #7759: improve CASE statement for integer type

From an email discussion:
Constantin Asofiei wrote:
> Quick question, I don't recall if this is how it is suppose... Constantin Asofiei

06:54 AM Bug #7759 (New): improve CASE statement for integer type

Constantin Asofiei

07:46 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Thanks, so we need what I mentioned before, we need to fix @B... Constantin Asofiei

07:45 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Thanks, so we need what I mentioned before, we need to fix @BaseObject.getNextSibling@... Marian Edu

07:45 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please check also what @Progress.Reflect.Method:next-sibling@ ret... Marian Edu

07:44 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please check also what @Progress.Reflect.Method:next-sibling@ ret... Constantin Asofiei

07:43 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Please check also what @Progress.Reflect.Method:next-sibling@ returns - is it always unk... Marian Edu

07:39 AM Feature #6410: implement additional built-in OO classes/interfaces

Please check also what @Progress.Reflect.Method:next-sibling@ returns - is it always unknown? If yes, maybe this (and... Constantin Asofiei

07:37 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Marian, can these be created outside of FWD runtime (i.e. by the application?) If these... Marian Edu

07:25 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian, can these be created outside of FWD runtime (i.e. by the application?) If these can only be created by FWD r... Constantin Asofiei

07:19 AM Feature #6410: implement additional built-in OO classes/interfaces

From Marian Edu:
> think I've stumbled upon the same problem before but can't remember exactly the use case nor the ... Constantin Asofiei

08/24/2023

10:07 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

This is an update on 7045b:
* I didn't faced any conversion issues in the meantime. Everything is good with #7045 ... Alexandru Lungu

07:45 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Constantin Asofiei wrote:
> Alexandru, there is a concern; if we compare case-insensitive, there is no guarantee th... Alexandru Lungu

06:00 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Alexandru, there is a concern; if we compare case-insensitive, there is no guarantee that a lowercase and an upperca... Constantin Asofiei

05:10 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Alexandru Lungu wrote:
> Danut, please get this done *asap*. I am planning to do a set of regression tests + profili... Dănuț Filimon

03:46 AM Bug #7722 (WIP): improve performance of equals/not equals when used with character/longchar

Alexandru Lungu

03:46 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Danut, please get this done *asap*. I am planning to do a set of regression tests + profiling. I am keen on getting t... Alexandru Lungu

08/22/2023

08:27 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

*Review of 7722a/rev.14704*
* Use Override annotation for @equals@ in @Text@. Make it return false if the paramete... Alexandru Lungu

06:58 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

*Committed 7722a/rev.14704*. Added Text.equals() method which uses @regionMatches@. The method is called in @CompareO... Dănuț Filimon

05:22 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Created 7722a. Alexandru Lungu

03:27 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Constantin Asofiei wrote:
> This only works with intern'ed strings, right?
Right. In FWD-H2 this short-circuit ha... Alexandru Lungu

07:28 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

How has it been tested? Greg Shah

08/21/2023

03:13 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others

Can I get into the queue for merging this branch? Theodoros Theodorou

11:10 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

Alexandru Lungu wrote:
> This makes sense. We have some recent implementation in FWD-H2 that was targeting this exac... Constantin Asofiei

08:46 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

This makes sense. We have some recent implementation in FWD-H2 that was targeting this exact issue. We can even compa... Alexandru Lungu

06:20 AM Bug #7722: improve performance of equals/not equals when used with character/longchar

In a large app, there are ~350k calls of @Text.compareTo@ which originate from equals/not-equals operators (via @Comp... Constantin Asofiei

06:14 AM Bug #7722 (WIP): improve performance of equals/not equals when used with character/longchar

Constantin Asofiei