Activity

From 09/06/2023 to 10/05/2023

10/05/2023

06:44 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Indeed, this is tricky. I think this is the first time I see @-cprcodein@ OE parameter. If I understand this paramete... Ovidiu Maxiniuc
06:27 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: I need help for understanding what needs to be done. Codepages look very tricky. Progress OE returns unexpected resul... Theodoros Theodorou
06:26 AM Bug #7873 (Test): conversion issues with dataset/table parameters for class events: Greg Shah
06:18 AM Bug #7873: conversion issues with dataset/table parameters for class events: 7873a was merged to trunk rev 14767 and archived. Constantin Asofiei
06:11 AM Bug #7873: conversion issues with dataset/table parameters for class events: Go ahead. Greg Shah
01:15 AM Bug #7873: conversion issues with dataset/table parameters for class events: Greg Shah wrote:
> What testing do you plan?
I've left overnight conversion for some projects and the result is OK.... Constantin Asofiei

10/04/2023

05:50 PM Feature #7875: Interactive child process launching is broken in GUI: A good amount of background can be found in #7676. Make sure to go through it first.
This required a simple testc... Roger Borrello
03:55 PM Feature #7875 (New): Interactive child process launching is broken in GUI: Roger Borrello
04:29 PM Bug #7873: conversion issues with dataset/table parameters for class events: Code Review Task Branch 7873a Revision 14767
I'm fine with the changes.
What testing do you plan? Greg Shah
01:45 PM Bug #7873 (Review): conversion issues with dataset/table parameters for class events: I've added support for DATASET, TABLE, DATASET-HANDLE, TABLE-HANDLE and BUFFER parameters for class events in 7873a r... Constantin Asofiei
10:19 AM Bug #7873 (WIP): conversion issues with dataset/table parameters for class events: Created task branch 7873a from trunk rev 14766. Constantin Asofiei
10:19 AM Bug #7873: conversion issues with dataset/table parameters for class events: FWD has problems converting class events with TABLE/DATASET parameters. This issue is meant to explore and fix all p... Constantin Asofiei
10:18 AM Bug #7873 (Test): conversion issues with dataset/table parameters for class events: Constantin Asofiei
05:44 AM Feature #6410: implement additional built-in OO classes/interfaces: Marian, I think we need 'invokeStandalone' to be emitted when the returned value is not read and 'invoke' in all othe... Constantin Asofiei

10/03/2023

08:16 AM Feature #6410: implement additional built-in OO classes/interfaces: Working on remaining issues on method @invoke@ and beside the known issue with @return extent@ I have a situation tha... Marian Edu

10/02/2023

10:44 AM Feature #6649: improve the performance or SourceNameMapper runtime: *Committed 6649b/rev.14742*.
* Added r-code file searching;
* Modified @PathLookup@ into an interface;
* Short-cir... Dănuț Filimon
08:17 AM Feature #6649: improve the performance or SourceNameMapper runtime: By removing unnecessary files from the lookup (files with an extension that don't match any legacy program name exten... Dănuț Filimon

09/29/2023

05:07 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Code Review Task Branch 7299a Revisions 14756 through 14763
Overall, it looks good. The refactoring made the revi... Greg Shah
12:33 PM Bug #5538 (Closed): fix readByte() for DirStream, ProcessStream, and others: Greg Shah
12:33 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Branch 5538a was merged to trunk rev. 14758 and archived. Theodoros Theodorou
11:16 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: You can merge to trunk now.
Should we set %Done to 100? Greg Shah
11:15 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Code Review Task Branch 5538a Revision 14758
No objections. Greg Shah
09:43 AM Feature #6410: implement additional built-in OO classes/interfaces: > what needs to be done beside finishing the method/invoke support.
Please do implement all the remaining items a... Greg Shah
06:15 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Created task branch 6410b from trunk rev 14756.
>
> The branch is available on xfer.
... Marian Edu
04:59 AM Feature #6410: implement additional built-in OO classes/interfaces: Created task branch 6410b from trunk rev 14756.
The branch is available on xfer. Constantin Asofiei
04:04 AM Feature #6410: implement additional built-in OO classes/interfaces: Greg Shah wrote:
> In addition to the remaining items in @getMethods()@, what work is left from #6410-1?
As far a... Marian Edu

09/28/2023

03:28 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Ovidiu Maxiniuc wrote:
> There are minor changes (only some comments) since my last review. One thing which I failed... Theodoros Theodorou
09:28 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Code Review Task Branch 5538a Revision 14756
It seems like we could rewrite the @@ as follows:... Greg Shah
12:24 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Constantin Asofiei wrote:
> ... At least, 'exact method matching' must be done in the entire hierarchy, before goin... Constantin Asofiei
11:57 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: The current changes are in 7299a rev 14758. I'll reconvert some projects and check real scenarios.
This adds @Obj... Constantin Asofiei
11:27 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Constantin Asofiei wrote:
> My assumption is that @h::f3@ doesn't set the type of the object returned (which would b... Constantin Asofiei
11:25 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: There is something which looks like a bug in the OpenEdge method resolution. Assume there is a method like this:
<p... Constantin Asofiei
07:06 AM Feature #6649: improve the performance or SourceNameMapper runtime: If the more generic approach of #6649-17 is still too costly, then we can certainly put some logic in to check for th... Greg Shah
06:55 AM Feature #6649: improve the performance or SourceNameMapper runtime: But wouldn't it be faster to rule out such searches based on the file extension? Since the original lookup is done on... Dănuț Filimon
06:27 AM Feature #6649: improve the performance or SourceNameMapper runtime: This is exactly the kind of thing that the idea in #6649-17 would optimize. There will be no @whatever.bmp@ in the m... Greg Shah
06:21 AM Feature #6649: improve the performance or SourceNameMapper runtime: Greg Shah wrote:
> These are all coming from @RUN@ statements?
No, I've looked up where a .bmp file is used and it ... Dănuț Filimon
06:16 AM Feature #6649: improve the performance or SourceNameMapper runtime: Lookup on the PROPATH can be done via the SEARCH function and IIRC even by runtime (i.e. when resolving images or ini... Constantin Asofiei
06:13 AM Feature #6649: improve the performance or SourceNameMapper runtime: These are all coming from @RUN@ statements? Greg Shah
06:12 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Danut, can you share some of these extensions and the context in which they are required? I... Dănuț Filimon
05:59 AM Feature #6649: improve the performance or SourceNameMapper runtime: Danut, can you share some of these extensions and the context in which they are required? I mean, what kind of files ... Alexandru Lungu
04:06 AM Feature #6649: improve the performance or SourceNameMapper runtime: I've noticed something for a while, but I am only bringing this up now because it might be important. While doing the... Dănuț Filimon

09/27/2023

07:58 PM Bug #5538 (Test): fix readByte() for DirStream, ProcessStream, and others: Review branch 5538a / 14756.
There are minor changes (only some comments) since my last review. One thing which I ... Ovidiu Maxiniuc
08:54 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Ovidiu: Please review. Greg Shah
08:52 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Please review branch 5538a rev no 14756. It has been rebased to trunk. Theodoros Theodorou
07:42 AM Feature #7842: Make FWD behave the same as OE regarding input through: Please recall that we never use the Description field of the Redmine header. The task details always go into the fir... Greg Shah

09/26/2023

05:52 PM Feature #7842 (New): Make FWD behave the same as OE regarding input through: Theodoros Theodorou
11:12 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Theodoros Theodorou wrote:
> Ok. Should we close this ticket? Should we create another ticket for implementing the s... Greg Shah
11:06 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Ok. Should we close this ticket? Should we create another ticket for implementing the same behavior with OE? Is the i... Theodoros Theodorou
09:28 AM Feature #6410: implement additional built-in OO classes/interfaces: In addition to the remaining items in @getMethods()@, what work is left from #6410-1? Greg Shah
05:46 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Branch 6410a was merged to trunk rev 14751 and archived.
>
> Marian: please let us kn... Marian Edu
09:24 AM Feature #6649: improve the performance or SourceNameMapper runtime: I've committed the implementation to -*6649a/rev.14741*- *6649b/rev.14741*. Please review and advise.
* propath can ... Dănuț Filimon
08:38 AM Feature #6649: improve the performance or SourceNameMapper runtime: > _The PROPATH may be found is in the file name (from name-map.xml)_, not in the search spec.
Yes, but a propath ... Greg Shah
08:31 AM Feature #6649: improve the performance or SourceNameMapper runtime: I retested #6649-30 using the new implementation and I got a total of *38119* calls to the new @SourceNameMapper.conv... Dănuț Filimon
05:36 AM Feature #6649: improve the performance or SourceNameMapper runtime: I think we can agree that the extension topic is fully understood now.
> Can you help me understand what you mean ... Alexandru Lungu

09/25/2023

05:32 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Although the natural instinct is to create good code, which behaves as one would expect (in this case to fully popula... Ovidiu Maxiniuc
05:23 PM Bug #5538 (Review): fix readByte() for DirStream, ProcessStream, and others: Theodoros Theodorou
01:55 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Thank you for confirming the bug Constantin and Ovidiu. I have created a test under @testcases\oo\progress\io\input_s... Theodoros Theodorou
04:32 PM Feature #6649: improve the performance or SourceNameMapper runtime: > 4GL supports the following file types: @.p@, @.r@, @.w@, @.cls@, @.i@. I've also found @.pf@ (parameter file), @.cf... Greg Shah
04:28 PM Feature #6649: improve the performance or SourceNameMapper runtime: During conversion, we have a copy of the file-system of the 4GL project. That project might have some arbitrary path... Greg Shah
09:51 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> It is normal not to be found right? I mean, if you are running start.p and the only start.p... Dănuț Filimon
06:25 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> I've also found a problem with this idea where the possible paths from a @SinglePathLookup@ c... Alexandru Lungu
06:16 AM Feature #6649: improve the performance or SourceNameMapper runtime: > The one place I differ is that I was not thinking we would store the propath variants in the *PathLookup helpers. I... Alexandru Lungu

09/22/2023

03:29 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Constantin Asofiei wrote:
> This is an example where 'something' ends up in the memptr:
> [...]
>
> Only first b... Ovidiu Maxiniuc
03:08 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: This is an example where 'something' ends up in the memptr:... Constantin Asofiei
02:38 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Indeed, in OE the content of @memptr@ variable is not filled with data from process stream. I do not know why. I trie... Ovidiu Maxiniuc
12:06 PM Bug #7460: implement Progress.Lang.Class:getMethods: For what we've been discussing about Progress.Reflect.Method related to caching (if is needed or not) and to the @=@ ... Constantin Asofiei
11:50 AM Bug #7460: implement Progress.Lang.Class:getMethods: Do we need a follow-up issue to resolve the remaining features/open items? Or should we clear them now, here? Greg Shah
11:12 AM Bug #7460: implement Progress.Lang.Class:getMethods: Branch 6410a was merged to trunk rev 14751 and archived. Constantin Asofiei
10:55 AM Bug #7460: implement Progress.Lang.Class:getMethods: Go ahead now. Greg Shah
10:52 AM Bug #7460: implement Progress.Lang.Class:getMethods: Greg, I think 6410a rev 14777 can be merged to trunk. Constantin Asofiei
11:12 AM Feature #6410: implement additional built-in OO classes/interfaces: Branch 6410a was merged to trunk rev 14751 and archived.
Marian: please let us know when we can create branch 6410b. Constantin Asofiei
06:33 AM Feature #6649: improve the performance or SourceNameMapper runtime: > # files ending in @.r@ or no extension will not be found if the simple name is @startproj.p@;
It's possible to sim... Dănuț Filimon

09/21/2023

10:32 AM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Greg Shah wrote:
> Try the @IMPORT@ statement with a @MEMPTR@ variable.
It worked for FWD, it triggered @ProcessS... Theodoros Theodorou
09:32 AM Feature #6410: implement additional built-in OO classes/interfaces: 6410a was rebased from trunk rev 14747 - new rev 14777.
I'm putting this into conversion testing of some projects. Constantin Asofiei
05:06 AM Feature #6649: improve the performance or SourceNameMapper runtime: I had to discard my initial implementation since it was going in the wrong direction and started again from scratch b... Dănuț Filimon

09/20/2023

05:14 PM Feature #6649: improve the performance or SourceNameMapper runtime: I think we are largely on the same page.
The one place I differ is that I was not thinking we would store the prop... Greg Shah
02:10 PM Bug #7460: implement Progress.Lang.Class:getMethods: Constantin Asofiei wrote:
> On a side note, I'm trying to run the tests from @tests.oo.progress.reflect@ for @constr... Marian Edu
10:12 AM Bug #7460: implement Progress.Lang.Class:getMethods: Marian, I'm working on the review. I'll do any required changes directly on the branch and will prepare it for merge... Constantin Asofiei

09/19/2023

04:39 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: > Can you please check if there is any way to check @ProcessStream.readByte()@?
Try the @IMPORT@ statement with a ... Greg Shah
03:41 PM Bug #5538: fix readByte() for DirStream, ProcessStream, and others: Greg Shah wrote:
> Anything using @INPUT THROUGH@, @INPUT-OUTPUT THROUGH@ or @OUTPUT THROUGH@ creates a child proces... Theodoros Theodorou
04:41 AM Feature #6649: improve the performance or SourceNameMapper runtime: Let me see if I understand your point correctly.
h3. Bootstrap
* We have a map with keys as unqualified procedu... Alexandru Lungu
04:00 AM Bug #7460 (Review): implement Progress.Lang.Class:getMethods: Please review. Marian Edu
03:59 AM Bug #7460 (WIP): implement Progress.Lang.Class:getMethods: Constantin Asofiei wrote:
> Marian, at this point, lets leave this behavior on the side for now. We need the implem... Marian Edu

09/18/2023

03:24 PM Bug #7460: implement Progress.Lang.Class:getMethods: Tried the obvious choice @BaseDataType@ as return type and this could work if we update the blocks to create a proxy ... Marian Edu
03:08 PM Bug #7460: implement Progress.Lang.Class:getMethods: Constantin Asofiei wrote:
> what I mentioned about @invoke@ to use @BlockManager.functio@).
Yeah, as said the @invo... Marian Edu
02:04 PM Bug #7460: implement Progress.Lang.Class:getMethods: Marian, at this point, lets leave this behavior on the side for now. We need the implementation of @progress.lang.me... Constantin Asofiei
02:02 PM Bug #7460: implement Progress.Lang.Class:getMethods: All this doesn't look like expected behaviour imho and since those are all internal objects anyway let me know if you... Marian Edu
02:00 PM Bug #7460: implement Progress.Lang.Class:getMethods: Constantin Asofiei wrote:
> Marian, what happens if you use @=@ operator, and not Equals/ToString methods? If they ... Marian Edu
01:51 PM Bug #7460: implement Progress.Lang.Class:getMethods: Marian, what happens if you use @=@ operator, and not Equals/ToString methods? If they are the same reference, this ... Constantin Asofiei
01:18 PM Bug #7460: implement Progress.Lang.Class:getMethods: Constantin Asofiei wrote:
> These @Parameter@, @Legacy4GLMethod@, etc, instances are immutable, right?
There seem... Marian Edu
03:11 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR: Constantin, can we close this? Vladimir Tsichevski
03:39 AM Bug #5538 (WIP): fix readByte() for DirStream, ProcessStream, and others: Theodoros Theodorou

09/15/2023

01:41 PM Bug #7460: implement Progress.Lang.Class:getMethods: Greg Shah wrote:
> Marian: Are you close to committing the next version of this?
I’ll try to push that by Monday,... Marian Edu
11:13 AM Bug #7460: implement Progress.Lang.Class:getMethods: Marian: Are you close to committing the next version of this? Greg Shah
10:26 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Eric: Please review. Greg Shah
10:18 AM Feature #6649: improve the performance or SourceNameMapper runtime: Another thing to consider with this "search inversion" idea is whether we can avoid the propath scanning process by r... Greg Shah
10:14 AM Feature #6649: improve the performance or SourceNameMapper runtime: I think the idea from #6649-17 has the greatest potential for improvement, though the caching from #6649-16 might als... Greg Shah
08:56 AM Feature #6649: improve the performance or SourceNameMapper runtime: From #6649-16, I understood that we should execute the lookup function with the unqualified filename, then resume sea... Dănuț Filimon

09/14/2023

08:17 AM Feature #6649: improve the performance or SourceNameMapper runtime: I did a test on a large customer application for #6649-16 where I got a total of *42846* calls to @SourceNameMapper.c... Dănuț Filimon

09/13/2023

08:16 AM Feature #6649 (WIP): improve the performance or SourceNameMapper runtime: Greg Shah

09/11/2023

11:24 AM Bug #7460: implement Progress.Lang.Class:getMethods: Marian Edu wrote:
> > ** @ErrorManager.recordOrThrowError@ must be followed by a @return@.
> Will fix that, as said... Constantin Asofiei
10:52 AM Bug #7460: implement Progress.Lang.Class:getMethods: Constantin Asofiei wrote:
> Review for 6410a rev 14571:
> * @LegacyClass.java@
> ** we need to cache the @Legacy4G... Marian Edu
08:11 AM Bug #7460: implement Progress.Lang.Class:getMethods: Review for 6410a rev 14571:
* @LegacyClass.java@
** we need to cache the @Legacy4GLMethod@ instances and resolve th... Constantin Asofiei
08:09 AM Bug #7604 (Closed): Switch does not honor case sensitivity of character: Greg Shah
07:49 AM Bug #7604: Switch does not honor case sensitivity of character: Greg, we can close this. Alexandru Lungu
07:37 AM Bug #7604: Switch does not honor case sensitivity of character: Yes, conversion seems good. Eduard Soltan
07:30 AM Bug #7604: Switch does not honor case sensitivity of character: Eduard, now that the change reached customer applications (newer binaries), please check that conversion is OK, so we... Alexandru Lungu

09/07/2023

10:59 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: I've continued working on 7045b. I mostly covered some issues with @CompoundQuery@. Currently, I am still facing some... Alexandru Lungu

09/06/2023

05:24 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin: Please review.
We need to get our OO support to the 100% mark sooner rather than later. Otherwise we ... Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Base Language

Activity

Activity

10/05/2023

10/04/2023

10/03/2023

10/02/2023

09/29/2023

09/28/2023

09/27/2023

09/26/2023

09/25/2023

09/22/2023

09/21/2023

09/20/2023

09/19/2023

09/18/2023

09/15/2023

09/14/2023

09/13/2023

09/11/2023

09/07/2023

09/06/2023