Project

General

Profile

Activity

From 10/01/2023 to 10/30/2023

10/30/2023

07:25 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> Theodoros: Please document your findings so far. Help to ensure that the tests written by Daniel... Theodoros Theodorou
07:30 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
If there is a reasonably small data set, then keeping it in the source code should be the standard approach. I agree... Greg Shah
06:54 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
BTW, Daniel is working on something more or less the same for the I18N part of the base language unit tests - not spe... Marian Edu
06:51 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:
> Greg Shah wrote:
> I prefer if that data is coded into the 4GL source, rather than as ... Marian Edu
03:48 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299d Revisions 14792 and 14793
In @oo_references.rules@ line 453, don't we need to remove... Greg Shah
03:04 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
The fixes for #7299-64 and #7976 are in 7299d rev 14793 - please review.
I'll need to go through conversion testin... Constantin Asofiei
11:48 AM Feature #6649: improve the performance or SourceNameMapper runtime
The first one is an expression, so a dynamic way to run a procedure. It can be disregarded for now. The following I t... Alexandru Lungu
10:24 AM Feature #6649: improve the performance or SourceNameMapper runtime
A few cases that I found while running a Hotel_GUI conversion and should be mentioned:
- @RUN VALUE(possiblePath) PE... Dănuț Filimon
08:41 AM Feature #6649: improve the performance or SourceNameMapper runtime
Danut:
* Not only RUN statements should be analyzed. Also anything that is going to be a path (like Hynek stated, IM... Alexandru Lungu
08:34 AM Feature #6649: improve the performance or SourceNameMapper runtime
A new @path_map.xml@ file should be created, similar to @name_map.xml@, with nodes that specify the paths for each RU... Dănuț Filimon
06:30 AM Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Unless I'm missing something using @RUN_CALL_SITE_*@ for the caching/precalculation isn't opti... Alexandru Lungu

10/27/2023

04:37 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
I prefer if that data is coded into the 4GL source, rather than as a data file. Data file access a... Theodoros Theodorou
11:10 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
The NPE is fixed now, but the regression tests I have still fail. Again, I don't have a replicate (just that the expe... Alexandru Lungu

10/26/2023

02:31 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Created task branch 7299d from trunk rev 14791.
7299d rev 14792 contains a regression fix for static poly calls - ... Constantin Asofiei

10/25/2023

12:47 PM Feature #6410: implement additional built-in OO classes/interfaces
6410b is now on trunk rev 14790 and was pushed to xfer. Constantin Asofiei
12:34 PM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian, please let me know when you have everything committed to 6410b, so I can get it ... Marian Edu
10:13 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian, please let me know when you have everything committed to 6410b, so I can get it from xfer, to rebase it. Constantin Asofiei
09:47 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, I see you fixed this (#7045-62) in a new revision. I will need to recompile the project I use for test in ord... Alexandru Lungu
04:27 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
PS: good news, a large customer application converted (~17 hours) and compiled (~1 hour) correctly. Also, it passed s... Alexandru Lungu
04:26 AM Feature #7045 (WIP): re-implement "normal" (non-abend) stack unwinding to avoid throwing an excep...
Eduard, I am facing some regressions with @CompoundQuery.retrieveImpl@ (mostly NPE). I see there is a duplicate code ... Alexandru Lungu

10/24/2023

09:33 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
> Eric: Please review.
The changes are quite extensive, so the review will take a bit :) I am converting a big app... Alexandru Lungu
09:28 AM Feature #7045 (Review): re-implement "normal" (non-abend) stack unwinding to avoid throwing an ex...
Greg Shah
09:27 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eric: Please review. Greg Shah
03:20 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Committed on 7045b, revision 14683.
Also tested changes to @forBlock@, @forEach@ blocks and also to @next@, @last@,... Eduard Soltan

10/23/2023

03:07 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299c was merged to trunk as rev. 14787 and archived. Constantin Asofiei
03:02 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299c Revision 14787
No objection. This seems pretty safe. Do you think it can be merged... Greg Shah
11:16 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Created task branch 7299c from trunk rev 14786.
7299c rev 14787 fixed another regression in trunk rev 14770, for u... Constantin Asofiei

10/20/2023

11:34 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Branch 7299b was merged to trunk rev 14779 and archived Constantin Asofiei
10:15 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299b Revisions 14778 through 14780
The changes are good. Greg Shah
08:31 AM Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> For the conversion side, do you mean preprocessing the path when converting to extract the ... Hynek Cihlar
08:25 AM Feature #6649: improve the performance or SourceNameMapper runtime
I've *committed 6649b/rev.14743* with the following changes:
* renamed @convertNameDynamically@ to @fastConvertName@... Dănuț Filimon
07:30 AM Feature #6649: improve the performance or SourceNameMapper runtime
For the conversion side, do you mean preprocessing the path when converting to extract the base name (@a.p@ from @x/y... Alexandru Lungu
07:28 AM Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Another idea I'm not sure you already considered is precalculating the denormalized Progress n... Dănuț Filimon
06:06 AM Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> The precalculated map would be stored per session and would have to be recalculated on input c... Hynek Cihlar
06:04 AM Feature #6649: improve the performance or SourceNameMapper runtime
Another idea I'm not sure you already considered is precalculating the denormalized Progress names passed in to the c... Hynek Cihlar
05:32 AM Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> I'm not that familiar with the anticipated test cases, but wouldn't the cache still be benefic... Dănuț Filimon

10/19/2023

11:38 AM Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> It seems that currently the @convertName@ method calls @getLegacyCaseS... Hynek Cihlar
09:51 AM Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> *convertNameDynamically:*
> * instead of
> [...]
> it would be more efficient to store cas... Dănuț Filimon
10:05 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg, please review 7299b (revs 14778 - 14780) - this contains regression fixes for #6501-359 and #7929 Constantin Asofiei
07:15 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299b rev 14776 will show linkage errors when resolving Java class names during conversion. The problem here is that... Constantin Asofiei

10/18/2023

05:52 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> We will be running these as unit tests using our ABLUnit support. At some point, your testcases ... Theodoros Theodorou
05:48 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Ovidiu Maxiniuc wrote:
> Theodoros Theodorou wrote:
> > I am trying to build a prorgam in OE that generates tests. ... Theodoros Theodorou
05:27 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:
> I am trying to build a prorgam in OE that generates tests. I generated a file located a... Ovidiu Maxiniuc
05:18 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:
> Greg Shah wrote:
> > You could make this data driven. The idea is to capture the inpu... Greg Shah
05:11 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
We will be running these as unit tests using our ABLUnit support. At some point, your testcases will be reworked to ... Greg Shah
05:02 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> > What do you think about my idea for testing asc() and chr() with different -cpinternals?
>
>... Theodoros Theodorou
04:56 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> You could make this data driven. The idea is to capture the inputs and results in an array even ... Theodoros Theodorou
04:19 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
> What do you think about my idea for testing asc() and chr() with different -cpinternals?
I think we must do that... Greg Shah
04:17 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
You could make this data driven. The idea is to capture the inputs and results in an array even in a data file. Then... Greg Shah
04:09 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
I am trying to build a prorgam in OE that generates tests. I generated a file located at testcases/cp/cpinternal/iso8... Theodoros Theodorou

10/17/2023

01:21 PM Feature #6649: improve the performance or SourceNameMapper runtime
Code review 6649b revision 14742 and 14741.
Functionally the changes look OK. I'm throwing in some random ideas fo... Hynek Cihlar
03:14 AM Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> There is a lot of documentation there, so from this POV I think the changes are clear enoug... Dănuț Filimon
10:20 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Committed on 7045b, revision 14682.
For now @QueryOffEnd@ exception is not throw in case a query is part of a @for... Eduard Soltan

10/16/2023

01:30 PM Feature #6649: improve the performance or SourceNameMapper runtime
Hynek: Please review. Greg Shah
10:22 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Committed on 7045b, revision 14681.
Because there are cases where an error still should be throw, I reintroduced ... Eduard Soltan
09:08 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, please make a separate issue for #7045-53 if this can be reproduced without 7045b changes. We need to focus o... Alexandru Lungu

10/14/2023

06:32 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> It seems pretty safe. I'm OK with you merging to trunk.
I'll delay this until I get the custome... Constantin Asofiei

10/13/2023

03:34 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
It seems pretty safe. I'm OK with you merging to trunk. Greg Shah
03:34 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299b Revison 14774
The change is good. Greg Shah
01:38 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
There is a regression in the conversion of #7156 project: a LPARENS can enclose an argument. I've created 7299b from... Constantin Asofiei
11:18 AM Feature #6649: improve the performance or SourceNameMapper runtime
I skimmed the changes in 6649b and they are quite robust. Well done!
There is a lot of documentation there, so from ... Alexandru Lungu
10:11 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
During some investigation I came across @QueryConstants.RETRIEVE_MODES@ used in @CompoundQuery@.
I tried to call @... Eduard Soltan

10/11/2023

07:54 AM Bug #7299 (Test): resolution of the target OO method in chained calls with poly arguments
Greg Shah
03:19 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299a was merged to trunk rev 14770 and archived. Constantin Asofiei

10/10/2023

03:17 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299a Revisions 14777 through 14784
No objections.
You can merge to trunk. Greg Shah
08:33 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
We have customer test environments that are 11.x so we can still access classic appserver for testing. Would that he... Greg Shah
02:28 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Greg Shah wrote:
> What parts of #3855-102 remain to be completed?
>
> Where are we with the testcases?
I thin... Marian Edu
08:31 AM Feature #4658: OO serialization support
> the object has no control of how it's data is being serialised, other than defining what is/isn't serialisable
P... Greg Shah
02:13 AM Feature #4658: OO serialization support
Greg Shah wrote:
> Marian: Do you know of any such feature (like Java's @Externalizable@) in the 4GL?
The keyword... Marian Edu
08:24 AM Feature #3310 (Closed): add support for the equivalent of the OpenEdge Web Services Adapter (and ...
Greg Shah
02:12 AM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Greg Shah wrote:
> Is there anything left to do on this task?
I don't think so. Constantin Asofiei
03:49 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, 7045b is in a "protoype" stage. There may be multiple such issues with it. In fact, the (first) implementatio... Alexandru Lungu
03:41 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
There is a problem with current implementation on 7045b.... Eduard Soltan

10/09/2023

03:54 PM Feature #4658: OO serialization support
> > > And here it shows that OE can have custom serializers: https://programinprogress.com/object-serialization-in-p... Greg Shah
02:46 PM Feature #4658: OO serialization support
Greg Shah wrote:
> > And here it shows that OE can have custom serializers: https://programinprogress.com/object-se... Constantin Asofiei
02:21 PM Feature #4658: OO serialization support
> And here it shows that OE can have custom serializers: https://programinprogress.com/object-serialization-in-progr... Greg Shah
03:51 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Is there anything left to do on this task? Greg Shah
02:43 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Greg Shah wrote:
> Is the "qualified prefixing" feature from #3310-93 the only remaining feature? I'm trying to und... Constantin Asofiei
02:38 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Is the "qualified prefixing" feature from #3310-93 the only remaining feature? I'm trying to understand what is left... Greg Shah
03:49 PM Feature #3854 (Closed): update appserver support with PASOE features
Greg Shah
02:36 PM Feature #3854: update appserver support with PASOE features
Greg Shah wrote:
> Is there any reason to leave this task open? As far as I understand it, all the remaining work i... Constantin Asofiei
02:35 PM Feature #3854: update appserver support with PASOE features
Is there any reason to leave this task open? As far as I understand it, all the remaining work is in #6417. Greg Shah
02:42 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
What parts of #3855-102 remain to be completed?
Where are we with the testcases? Greg Shah
09:22 AM Bug #7299 (Review): resolution of the target OO method in chained calls with poly arguments
Greg, please review 7299a starting from rev 14777 to 14784 (i.e. compared with 14776, the last reviewed revision).
... Constantin Asofiei

10/07/2023

01:57 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299a was rebased and rev 14777/14778 contains fixes to add @ObjectOps.poly(Object)Arg@ wrapper for cases when a dire... Constantin Asofiei

10/06/2023

12:17 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
> As far as I understand, using @-cprcodein UTF-8@ tells OE that the source file should be read as UTF-8.
No, I do... Greg Shah
12:10 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> Are all your notes from #6431-13 based on OE testing? I don't want to mix any FWD results togeth... Theodoros Theodorou
12:03 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Ovidiu Maxiniuc wrote:
> Indeed, this is tricky. I think this is the first time I see @-cprcodein@ OE parameter. If ... Theodoros Theodorou
09:05 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Are all your notes from #6431-13 based on OE testing? I don't want to mix any FWD results together at this point, it... Greg Shah
10:37 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, please focus on this task for the upcoming Sprint.
There is a lot of information here, so feel free to ask... Alexandru Lungu

10/05/2023

06:44 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Indeed, this is tricky. I think this is the first time I see @-cprcodein@ OE parameter. If I understand this paramete... Ovidiu Maxiniuc
06:27 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
I need help for understanding what needs to be done. Codepages look very tricky. Progress OE returns unexpected resul... Theodoros Theodorou
06:26 AM Bug #7873 (Test): conversion issues with dataset/table parameters for class events
Greg Shah
06:18 AM Bug #7873: conversion issues with dataset/table parameters for class events

7873a was merged to trunk rev 14767 and archived. Constantin Asofiei
06:11 AM Bug #7873: conversion issues with dataset/table parameters for class events
Go ahead. Greg Shah
01:15 AM Bug #7873: conversion issues with dataset/table parameters for class events
Greg Shah wrote:
> What testing do you plan?
I've left overnight conversion for some projects and the result is OK.... Constantin Asofiei

10/04/2023

05:50 PM Feature #7875: Interactive child process launching is broken in GUI
A good amount of background can be found in #7676. Make sure to go through it first.
This required a simple testc... Roger Borrello
03:55 PM Feature #7875 (New): Interactive child process launching is broken in GUI
Roger Borrello
04:29 PM Bug #7873: conversion issues with dataset/table parameters for class events
Code Review Task Branch 7873a Revision 14767
I'm fine with the changes.
What testing do you plan? Greg Shah
01:45 PM Bug #7873 (Review): conversion issues with dataset/table parameters for class events
I've added support for DATASET, TABLE, DATASET-HANDLE, TABLE-HANDLE and BUFFER parameters for class events in 7873a r... Constantin Asofiei
10:19 AM Bug #7873 (WIP): conversion issues with dataset/table parameters for class events
Created task branch 7873a from trunk rev 14766. Constantin Asofiei
10:19 AM Bug #7873: conversion issues with dataset/table parameters for class events
FWD has problems converting class events with TABLE/DATASET parameters. This issue is meant to explore and fix all p... Constantin Asofiei
10:18 AM Bug #7873 (Test): conversion issues with dataset/table parameters for class events
Constantin Asofiei
05:44 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian, I think we need 'invokeStandalone' to be emitted when the returned value is not read and 'invoke' in all othe... Constantin Asofiei

10/03/2023

08:16 AM Feature #6410: implement additional built-in OO classes/interfaces
Working on remaining issues on method @invoke@ and beside the known issue with @return extent@ I have a situation tha... Marian Edu

10/02/2023

10:44 AM Feature #6649: improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14742*.
* Added r-code file searching;
* Modified @PathLookup@ into an interface;
* Short-cir... Dănuț Filimon
08:17 AM Feature #6649: improve the performance or SourceNameMapper runtime
By removing unnecessary files from the lookup (files with an extension that don't match any legacy program name exten... Dănuț Filimon
 

Also available in: Atom