Activity

From 03/28/2024 to 04/26/2024

04/26/2024

11:27 AM Feature #6407: name_map.xml improvements: Greg Shah wrote:
> Constantin: Are we good to go?
My main concern with Windows was that jar file separator which ne... Constantin Asofiei
11:17 AM Feature #6407 (Internal Test): name_map.xml improvements: > do I need to make hotel_gui or testcases run on Windows as part of this task
No. The Windows situation will not... Greg Shah
10:38 AM Feature #6407: name_map.xml improvements: I don't know what's going on now, but the client doesn't even spawn and I can't stop it in the cmd prompt. No errors ... Galya B
08:29 AM Feature #6407: name_map.xml improvements: OK, the java command for the task @create.db.h2@ exceeds @8191@ chars (the max length of commands in windows) due to ... Galya B
08:00 AM Feature #6407: name_map.xml improvements: There is an issue with the file separators indeed. It's @\@ on Windows for the jars on the file system, but the resou... Galya B
06:26 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> Not sure what else to test in Win.
Try the Swing client for Hotel GUI on Windows. Constantin Asofiei
06:25 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Regarding the @Utils.packageToPath@ change - please check runtime on Windows for i.e. Ho... Galya B
02:37 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> With or without 6407a I get:
> [...]
>
> Not sure what it means.
There is ambiguity between th... Constantin Asofiei
02:34 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Galya B wrote:
> > Actually if a dir with name map file is in the classpath the name ma... Galya B
07:12 AM Feature #6410: implement additional built-in OO classes/interfaces: Marian Edu wrote:
> The code in `p2j.oo` almost exclusively use `returnNormal` and expect the execution to end there... Constantin Asofiei
07:04 AM Feature #6410: implement additional built-in OO classes/interfaces: The code in `p2j.oo` almost exclusively use `returnNormal` and expect the execution to end there instead of the `stor... Marian Edu
06:49 AM Feature #6410 (WIP): implement additional built-in OO classes/interfaces: I have a question on how is the proper way to return a value out of a OO method (really a function block), we've used... Marian Edu
04:40 AM Feature #8676: ABLUnit assert error messages are different in different OE versions: A quick search on testcases project shows we have 500 asserts on 'not null' error messages, for some tests of #6410 w... Marian Edu
03:57 AM Feature #8676: ABLUnit assert error messages are different in different OE versions: Greg Shah wrote:
> Marian: Please provide some more details on the specific changes that need to be made. Also, ple... Marian Edu

04/25/2024

02:24 PM Feature #6407: name_map.xml improvements: Galya B wrote:
> Actually if a dir with name map file is in the classpath the name map should have been found in the... Constantin Asofiei
07:53 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> You are correct, at this point, unless the current folder is in the classpath, @ClassLoa... Galya B
07:51 AM Feature #6407: name_map.xml improvements: With the @classNameExists@ in mind, these changes don't affect conversion. Constantin Asofiei
07:22 AM Feature #6407: name_map.xml improvements: You are correct, at this point, unless the current folder is in the classpath, @ClassLoader.getSystemResource(sb.toSt... Constantin Asofiei
06:16 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Galya B wrote:
> > > * @SourceNameMapper@ - @convertJavaProg@ is used during conversion... Galya B
05:32 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> > * @SourceNameMapper@ - @convertJavaProg@ is used during conversion via @NameMappingWorker.classNa... Constantin Asofiei
05:13 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Review for 6407a rev 15157:
> * @WebServer@ - please add a history entry
Fixed.
> * @... Galya B
04:01 AM Feature #6407: name_map.xml improvements: Review for 6407a rev 15157:
* @WebServer@ - please add a history entry
* @Utils.packageToPath@ - this replaces all ... Constantin Asofiei

04/24/2024

05:12 PM Feature #8676: ABLUnit assert error messages are different in different OE versions: Marian's team has written a large number of ABLUnit tests which relied upon OE (12.x?) error messages from the assert... Greg Shah
05:03 PM Feature #8676 (New): ABLUnit assert error messages are different in different OE versions: Greg Shah
08:34 AM Feature #4347: add runtime support for STOP-AFTER block option: > To replicate this in Java, we need all *converted* statements to check if there was a time-out or not, so it can ra... Greg Shah
04:30 AM Feature #4347: add runtime support for STOP-AFTER block option: Alexandru, the STOP AFTER needs to use a similar mechanism we have for CTRL-C support (which actually raises a STOP c... Constantin Asofiei
04:19 AM Feature #4347: add runtime support for STOP-AFTER block option: Eduard and I had a chat yesterday on this task an I took some "thinking" time on my own on this matter:
#4347-6 is... Alexandru Lungu

04/15/2024

07:03 AM Feature #6407: name_map.xml improvements: 6407a rebased on trunk r15146.
New r15156 with a minor fix for #8166-151. Galya B
02:19 AM Feature #6407: name_map.xml improvements: Reminder: The branch needs a review (at r15110). It also has minor changes for #8166-145 and #8166-150. Galya B

04/04/2024

05:26 PM Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework: Greg Shah
05:21 PM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework: Greg Shah wrote:
> You can merge 8579a to trunk now.
Done. Rev. 15123. Vladimir Tsichevski
04:23 PM Bug #8579 (Merge Pending): Unit and OEUnit conversion: ignore annotations from other framework: You can merge 8579a to trunk now. Greg Shah
01:14 PM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework: Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15121
>
> The change is good.
>
> What additional te... Vladimir Tsichevski
12:58 PM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework: Code Review Task Branch 8579a Revision 15121
The change is good.
What additional testing is needed? Greg Shah
11:20 AM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework: Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15120
>
> I think the code would be simpler and easier ... Vladimir Tsichevski
12:12 PM Feature #6407: name_map.xml improvements: I did replace the @Set@ with @List@ in r15108.
Tomorrow I'm testing again in testcases. A good list of different p... Galya B
11:45 AM Feature #6407: name_map.xml improvements: @MultiClassLoader@:... Galya B
11:43 AM Feature #6407: name_map.xml improvements: So what I'm saying is that there is no classpath order in my humble opinion. Iterating HashMap is not ordered. Galya B
11:39 AM Feature #6407: name_map.xml improvements: Greg Shah wrote:
> > > @MultiClassLoader@ finds the class by iterating @HashSet@.
> > Actually it's a collection, ... Galya B
11:32 AM Feature #6407: name_map.xml improvements: > > @MultiClassLoader@ finds the class by iterating @HashSet@.
> Actually it's a collection, backed by the @HashMap... Greg Shah
11:20 AM Feature #6407 (Review): name_map.xml improvements: 6407a r15107 based on trunk r15101 ready for review: adds support for reading mappings from multiple name_map.xml fil... Galya B
09:57 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> @MultiClassLoader@ finds the class by iterating @HashSet@.
Actually it's a collection, backed by ... Galya B
09:42 AM Feature #6407: name_map.xml improvements: We can rework it to iterate jars alphabetically. Galya B
09:39 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> My understanding is that JVM keeps the same order of jars as defined in classpath (it do... Galya B
09:37 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> Greg Shah wrote:
> > Do we really need an explicit list of precedence order? Why not implicitly t... Constantin Asofiei
09:29 AM Feature #6407: name_map.xml improvements: Greg Shah wrote:
> Do we really need an explicit list of precedence order? Why not implicitly take it from the clas... Galya B
09:28 AM Feature #6407: name_map.xml improvements: Do we really need an explicit list of precedence order? Why not implicitly take it from the classpath and honor the ... Greg Shah
09:21 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> From what you posted in #6407-56, only one concern: the granularity for the precedence o... Galya B
05:45 AM Feature #6407: name_map.xml improvements: From what you posted in #6407-56, only one concern: the granularity for the precedence order I think needs to be "thi... Constantin Asofiei
04:39 AM Feature #6407: name_map.xml improvements: P.S. The previous comment got updated. Galya B
04:36 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
>... Galya B

04/03/2024

06:05 PM Bug #8579 (Internal Test): Unit and OEUnit conversion: ignore annotations from other framework: Code Review Task Branch 8579a Revision 15120
I think the code would be simpler and easier to read if you create a ... Greg Shah
03:11 PM Bug #8579 (Review): Unit and OEUnit conversion: ignore annotations from other framework: Fixed in 8579a rev. 15120. Please, review. Vladimir Tsichevski
03:10 PM Bug #8579 (WIP): Unit and OEUnit conversion: ignore annotations from other framework: Vladimir Tsichevski
02:51 PM Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework: Currently, if a test 4gl source includes both ABLUnit annotations and OEUnit annotations, all these annotations are c... Vladimir Tsichevski
02:46 PM Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework: Vladimir Tsichevski
03:08 PM Feature #6407: name_map.xml improvements: And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
* in FWD, you would convert th... Constantin Asofiei
02:34 PM Feature #6407: name_map.xml improvements: Greg Shah wrote:
> > But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime co... Constantin Asofiei
02:29 PM Feature #6407: name_map.xml improvements: > But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime could use a .p from di... Greg Shah
02:26 PM Feature #6407: name_map.xml improvements: We had cases of the same OE qualified class name used in different modules. The qualified legacy name can't be chang... Constantin Asofiei
01:28 PM Feature #6407: name_map.xml improvements: To solve case 2. we need the precedence order to be fed to the jmv via startup args, so that the classloader can take... Galya B
01:09 PM Feature #6407: name_map.xml improvements: Galya B wrote:
> I speak about case 3: different maps for different files with different attributes. Obviously if yo... Galya B
01:08 PM Feature #6407: name_map.xml improvements: I speak about case 3: different maps for different files with different attributes, but same path. Obviously if you l... Galya B
01:02 PM Feature #6407: name_map.xml improvements: > This is not something we can decide even with configs and Constantin was right that it is a major issue.
Case 1 ... Greg Shah
12:58 PM Feature #6407: name_map.xml improvements: One pname corresponds to only one jname, because that's how conversion seems to work. The question is if the other at... Galya B
11:36 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> Other than that the jar can have a completely different package for the actual classes.
Actually n... Galya B
11:34 AM Feature #6407: name_map.xml improvements: If we need to load the jars in a specific order, we'll need explicit instructions, probably new config in directory. Galya B
11:32 AM Feature #6407: name_map.xml improvements: Case 2 is the same as java and can cause malfunctioning programs like in java, this is what I meant.
Case 1 is fine ... Galya B
11:20 AM Feature #6407: name_map.xml improvements: > In java this is the same as having multiple versions of the same dependency in the classpath.
Not exactly. In... Greg Shah
11:14 AM Feature #6407: name_map.xml improvements: > If you are saying that module M1 has a program foo/bar/F.p and module M2 has a program foo/bar/F.p. which are compl... Greg Shah
11:12 AM Feature #6407: name_map.xml improvements: This is actually more complicated than it looked at first. We're trying to combine different apps coming possibly fro... Galya B
11:03 AM Feature #6407: name_map.xml improvements: Greg Shah wrote:
> Let's consider this from the perspective of how it works for this multi-app case in OE. If both ... Constantin Asofiei
10:55 AM Feature #6407: name_map.xml improvements: Originally (currently) if multiple paths are found for the same filename when resolving the name map, the paths end u... Galya B
10:45 AM Feature #6407: name_map.xml improvements: > The 'pname' in @class-mapping@ is the full path relative to the @abl/@ folder
Yes, this is why I called them rel... Greg Shah
10:30 AM Feature #6407: name_map.xml improvements: Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a... Constantin Asofiei
10:26 AM Feature #6407: name_map.xml improvements: I don't have an actual example though. Not sure if the path is supposed to be the same in two different jars. Galya B
10:25 AM Feature #6407: name_map.xml improvements: Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a... Galya B
10:23 AM Feature #6407: name_map.xml improvements: > > And all of this just for a warning log? I would say it's more reasonable to log the warning always when a second ... Greg Shah
06:16 AM Feature #6407: name_map.xml improvements: > REST services written directly in Java can be configured via the 'rest-service' element.
So these nodes are not ... Constantin Asofiei
06:06 AM Feature #6407: name_map.xml improvements: OK, then I need one more clarification. Since there is a separate container @rest-service@, where programs get resolv... Galya B
06:00 AM Feature #6407: name_map.xml improvements: Yes. Constantin Asofiei
05:57 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Galya B wrote:
> > And all of this just for a warning log? I would say it's more reason... Galya B
05:57 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> And all of this just for a warning log? I would say it's more reasonable to log the warning always ... Constantin Asofiei
05:53 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin, maybe you've missed why I'm assigned to the task, that i... Galya B
05:49 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> Constantin, maybe you've missed why I'm assigned to the task, that is in #6407-4.
OK, thanks for t... Constantin Asofiei
05:49 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> The point was to move to annotations/other structures inside the .java
Constantin, ... Galya B
05:43 AM Feature #6407: name_map.xml improvements: The point was to move to annotations/other structures inside the .java, here I mean all info from name_map.xml; ideal... Constantin Asofiei
05:33 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> I don't mean the annotations in the .class - I mean the state from name_map.xml must mat... Galya B
05:22 AM Feature #6407: name_map.xml improvements: I don't mean the annotations in the .class - I mean the state from name_map.xml must match if there is an existing en... Constantin Asofiei
03:55 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> * load them into @SourceNameMapper@, one by one, and address conflicts - if there are co... Galya B
05:26 AM Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN: 8150a was merged to trunk rev 15116 and archived. Constantin Asofiei
05:26 AM Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN: Created task branch 8510a from trunk rev 15115. In rev 15116 I removed the @logical.of@ and @logical.UNKNOWN@ from R... Constantin Asofiei

04/01/2024

06:41 PM Bug #8154: refactor scopeable stacks: Code Review Task Branch 8154a Revision 15109
The changes look promising. There is clearly quite a bit more that c... Greg Shah
12:51 PM Bug #8154 (WIP): refactor scopeable stacks: Created task branch 8154a from trunk rev 15108.
Rev 15109 contains first pass at moving scoped stacks into (TopLev... Constantin Asofiei
04:00 AM Feature #6424: fill gaps in Java Open Client replacement (appserver client support): Galya, I've placed the project under @devsrv01:/tmp/open_client_example.zip@. There is a small readme.txt in the pro... Constantin Asofiei

03/29/2024

10:57 AM Feature #6407: name_map.xml improvements: Galya B wrote:
> @SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime m... Constantin Asofiei
10:20 AM Feature #6407 (WIP): name_map.xml improvements: 6407a created from trunk r15101. Galya B
10:03 AM Feature #6407: name_map.xml improvements: @SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime machine with a serv... Galya B
09:46 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Also, SourceNameMapper will not load the .class and annotations when the entry in @name_... Galya B
09:45 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Java has tools to read an archive.
If you mean the custom FWD's @JarClassLoader@, then ... Galya B
09:38 AM Feature #6407: name_map.xml improvements: You don't need to unzip the jar - Java has tools to read an archive. This just means we can't rely on @Class.getReso... Constantin Asofiei
09:37 AM Feature #6407: name_map.xml improvements: Why can't we use the same technique from @Utils.searchResourceJars()@? We don't need the propath part but we definit... Greg Shah
09:29 AM Feature #6407: name_map.xml improvements: That is of course if the check for the file listed by @jar tvf filename.jar@ gives positive. Galya B
09:27 AM Feature #6407: name_map.xml improvements: Constantin Asofiei wrote:
> Galya, what package would you use for looking into multiple jars? Look everywhere? The ... Galya B
08:41 AM Feature #6407: name_map.xml improvements: Galya, what package would you use for looking into multiple jars? Look everywhere? The problem with @name_map.xml@ i... Constantin Asofiei
08:31 AM Feature #6407: name_map.xml improvements: > @MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar t... Greg Shah
07:08 AM Feature #6407: name_map.xml improvements: @MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar tvf... Galya B
06:16 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: I know some work has happened to explore I18N testcases. Having proper testcases will be very important.
I want t... Greg Shah

03/28/2024

05:09 PM Feature #6407: name_map.xml improvements: > We had this discussion before - moving *everything* to annotations will mean the entire converted .class code needs... Greg Shah
03:58 PM Feature #6407: name_map.xml improvements: Greg Shah wrote:
> > another improvement would be to emit some kind of special constructs for the virtual functions/... Constantin Asofiei
03:50 PM Feature #6407: name_map.xml improvements: > another improvement would be to emit some kind of special constructs for the virtual functions/internal procedures ... Greg Shah
09:49 AM Feature #6417 (WIP): cleanup some known items in appserver support: Galya B
09:44 AM Feature #6417: cleanup some known items in appserver support: Test in OE for client type:
Procedure running in batch client:... Galya B

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Base Language

Activity

Activity

04/26/2024

04/25/2024

04/24/2024

04/22/2024

04/18/2024

04/17/2024

04/15/2024

04/04/2024

04/03/2024

04/01/2024

03/29/2024

03/28/2024