FWD » Core Development » Base Language

06/11/2024

05:44 PM Bug #8799 (Test): ON ERROR UNDO, THROW problems leading to infinite loops

Do you think that 40% is accurate for %Done? Greg Shah

05:37 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Branch 8799a was merged to trunk rev 15279 and archived. Constantin Asofiei

05:16 PM Bug #8799 (Merge Pending): ON ERROR UNDO, THROW problems leading to infinite loops

You can merge to trunk now. Greg Shah

04:59 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

8799a passed #7156 customer testing and other unit tests. Constantin Asofiei

09:19 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Code Review Task Branch 8799a Revision 15277
I'm good with the changes. Greg Shah

08:15 AM Bug #8799 (Internal Test): ON ERROR UNDO, THROW problems leading to infinite loops

Constantin Asofiei

04:12 PM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Greg Shah wrote:
> >7. Help me understand why the implementation of Control.setControl() is ... Greg Shah

07:27 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> 8. In @StopAfterTimer.addTimeOut()@, directly raising @NumberedException@ seems to be incorrect. ... Eduard Soltan

07:22 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
>7. Help me understand why the implementation of Control.setControl() is correct. In particular, do... Eduard Soltan

08:04 PM Feature #4347: add runtime support for STOP-AFTER block option

Code Review 4347a Revisions 15205 through 15208
1. The @BlockManager.LOG@ should not be initialized using @ErrorMa... Greg Shah

05:39 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Can you check r15302.
The changes look good. I was trying to get a standalone test with FWD clien... Constantin Asofiei

04:18 AM Feature #6417: cleanup some known items in appserver support

Can you check r15302. Galya B

04:09 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Also, the @server@ handle can also be assigned to @SESSION@ - in thi... Constantin Asofiei

04:00 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Also, the @server@ handle can also be assigned to @SESSION@ - in this case, @if (serverH... Galya B

03:18 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> by @throw on the Conversion thread@ you meant @throw on the Conversation thread@?
Yes. ... Galya B

02:41 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Client type is not done. It will have to be reviewed and tested further. It's way more complicated ... Constantin Asofiei

01:36 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Review for 6417a/15301 built on trunk rev 15276:
> * @src/com/goldencode/p2j/oo/lang/Oe... Galya B

06/10/2024

11:57 AM Feature #6417: cleanup some known items in appserver support

Review for 6417a/15301 built on trunk rev 15276:
* @src/com/goldencode/p2j/oo/lang/OeversionInfo.java@
** in the ja... Constantin Asofiei

07:45 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> The runtime needs to be regression tested with ChUI and other unit testing for customer ... Galya B

07:44 AM Feature #6417: cleanup some known items in appserver support

New r15301 of 6417a based on trunk r15276 ready for review. Galya B

07:29 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Other cases need to be fixed by calling a new server exported method, which I forgot and left in TO... Galya B

07:26 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> ** @recordOrThrowError@ can be called from FWD client, too - why @if (serverSide) { thro... Galya B

07:01 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> * @src/com/goldencode/p2j/util/SessionUtils.java@
> ** for @getClientType@, the value o... Galya B

06:46 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> It fixes a startup procedure being configured without startup params.
OK, just for clarification: ... Constantin Asofiei

06:43 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > The last example doesn't work. If you want me to revert the change, ... Galya B

06:40 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> The last example doesn't work. If you want me to revert the change, it will continue to fail agents... Constantin Asofiei

06:33 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> I'm talking about this code in @Agent.listen@:
> [...]
>
> This is executed when the... Galya B

06:28 AM Feature #6417: cleanup some known items in appserver support

I'm talking about this code in @Agent.listen@:... Constantin Asofiei

06:22 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> I don't understand - startup procedure defines an input parameter, always. FWD must pas... Galya B

06:16 AM Feature #6417: cleanup some known items in appserver support

I don't understand - startup procedure defines an input parameter, always. FWD must pass this argument, otherwise th... Constantin Asofiei

06:14 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> * @src/com/goldencode/p2j/util/Agent.java@
> ** Agent's startup-procedure signature alw... Galya B

05:19 AM Feature #6417: cleanup some known items in appserver support

Comment this line, at the time this was written I think there was a problem with the log:
> // generateRestTests(RES... Constantin Asofiei

02:51 AM Feature #6417: cleanup some known items in appserver support

@SoapUILog2Harness@ doesn't compile. Galya B

02:44 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, I don't think you need to setup OpenEdge to run the REST/SOAP tests.
>
> @webt... Galya B

02:37 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > I need confirmation if I got it right: I need to figure out by myself how to... Galya B

06/09/2024

10:46 AM Feature #6417: cleanup some known items in appserver support

Review for 6417a/15226 built on trunk rev 15202:
* branch needs rebase
* files with missing history entry:... Constantin Asofiei

02:39 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Created task branch 8799a from trunk rev 15266. Rev 15277 has:
* Once a structured exception is re-thrown, mark it ... Constantin Asofiei

06/07/2024

09:27 AM Feature #6417: cleanup some known items in appserver support

Galya, I don't think you need to setup OpenEdge to run the REST/SOAP tests.
@webtests_from_logs@ is meant to autom... Constantin Asofiei

09:19 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> I need confirmation if I got it right: I need to figure out by myself how to setup Progress classic... Marian Edu

08:46 AM Feature #6417: cleanup some known items in appserver support

I need confirmation if I got it right: I need to figure out by myself how to setup Progress classic appserver with RE... Galya B

08:21 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > The comment also says run all SoapUI tests. Am I supposed to set SOAP and REST api in Progress ... Galya B

08:14 AM Feature #6417: cleanup some known items in appserver support

> The comment also says run all SoapUI tests. Am I supposed to set SOAP and REST api in Progress corresponding to wha... Greg Shah

07:58 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Is this not what was documented in #6417-8 and following discussion?
The "documentation" is ex... Galya B

07:40 AM Feature #6417: cleanup some known items in appserver support

Is this not what was documented in #6417-8 and following discussion? Greg Shah

07:33 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Setup equivalent testing environments in both OE and FWD.
Hasn't this already been done / docume... Galya B

07:29 AM Feature #6417: cleanup some known items in appserver support

Can you start with this:
# Setup equivalent testing environments in both OE and FWD.
# Run the tests in both envi... Greg Shah

07:25 AM Feature #6417: cleanup some known items in appserver support

I can't proceed with fixing all tests or related issues in FWD appservers without clear documentation what has been d... Galya B

07:24 AM Feature #6417: cleanup some known items in appserver support

We should separate our artifacts from OE and FWD. Either by more specific name or by separate directories. Greg Shah

07:19 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > So @webtests_from_logs/results/20211112_201954_soap_classic/test_set... Galya B

07:17 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Galya, the @errorCode@ text from the @Error in SOAP parameter: error... Constantin Asofiei

06:27 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, the @errorCode@ text from the @Error in SOAP parameter: errorCode@ message is the... Galya B

06:22 AM Feature #6417: cleanup some known items in appserver support

Galya, the @errorCode@ text from the @Error in SOAP parameter: errorCode@ message is the first argument from @new App... Constantin Asofiei

06:12 AM Feature #6417: cleanup some known items in appserver support

I'm puzzled by @webtests_from_logs/results/20211112_201954_soap_classic/test_set_2_exceptions/test_5_throw_error_1.ht... Galya B

08:01 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

In #8308, it was discovered that errors related to the database are handled differently when a CATCH block is present... Dănuț Filimon

06/05/2024

03:10 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

For this test:... Constantin Asofiei

09:09 AM Feature #6417: cleanup some known items in appserver support

Marian may just be referencing your comment from #6417-160 where you said "I'm not testing OE.". Greg Shah

08:51 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> I still don't understand how do you plan to fix those tests without testing against a real Progr... Galya B

08:48 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Marian: Can you please list them here so that Galya knows not to touch those without discussing... Marian Edu

08:45 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Marian, the work on the tests seems disjointed. I'm trying to help the team coordinate their versio... Marian Edu

08:42 AM Feature #6417: cleanup some known items in appserver support

> > Galya: The failures you mention in #6417-162 are from the harness, probably something written by Constantin. The... Greg Shah

08:14 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Galya: The failures you mention in #6417-162 are from the harness, probably something written by ... Galya B

08:06 AM Feature #6417: cleanup some known items in appserver support

Galya: The failures you mention in #6417-162 are from the harness, probably something written by Constantin. These w... Greg Shah

08:05 AM Feature #6417: cleanup some known items in appserver support

Marian, I believe acorn.ro is familiar not only with the @*.log@ files, but also with the SoapUI tests:... Galya B

07:57 AM Feature #6417: cleanup some known items in appserver support

Marian, let me help you understand what I'm working on here:
Greg Shah wrote:
> These are items that can be found... Galya B

07:53 AM Feature #6417: cleanup some known items in appserver support

Marian, the work on the tests seems disjointed. I'm trying to help the team coordinate their versions to achieve a st... Galya B

07:30 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Well said. The asserts in the SoapUI tests indeed match those from the Progress runs, i.e. are fa... Marian Edu

07:02 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ ... Galya B

06:44 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > Greg please let me know if we should move those to ABLUnit as well.
>
> Yes
>
> > Not sur... Marian Edu

06:42 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ are based on the OE res... Marian Edu

06:28 AM Feature #6417: cleanup some known items in appserver support

> Greg please let me know if we should move those to ABLUnit as well.
Yes
> Not sure if FWD supports this (RPC,... Greg Shah

06:26 AM Feature #6417: cleanup some known items in appserver support

> > > I find it very weird that so many tests were failing in OE, but not fixed,
> >
> > Please be more specific ... Greg Shah

05:57 AM Feature #6417: cleanup some known items in appserver support

The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ are based on the OE results in @testcases... Galya B

05:18 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> I'm not testing OE.
Maybe we've got confused by your previous statement then... "I find it very... Marian Edu

12:43 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > I find it very weird that so many tests were failing in OE, but not fixed,
>
> Please be mo... Galya B

06/04/2024

04:54 PM Feature #6417: cleanup some known items in appserver support

> I find it very weird that so many tests were failing in OE, but not fixed,
Please be more specific about this. ... Greg Shah

09:39 AM Feature #4347: add runtime support for STOP-AFTER block option

We don't want a timer thread to exist if there is no @STOP-AFTER@ active. Greg Shah

08:51 AM Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15208. Eduard Soltan

08:14 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> * StopAfterTimer
> ** in the constructor, the @if (timer == null)@ is not needed - you ... Eduard Soltan

06/03/2024

08:12 AM Feature #6417: cleanup some known items in appserver support

I find it very weird that so many tests were failing in OE, but not fixed, instead directly ported to testcases and s... Galya B

03:13 AM Feature #4347: add runtime support for STOP-AFTER block option

Review for 4347a rev 15206:
* StandardServer
** only change is a 'bad import', revert this file to rev 15203.
* Bl... Constantin Asofiei

05/30/2024

08:46 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> Marian Edu wrote:
> > Some of them are just caused by the conversion when unknown (?) is passed... Greg Shah

08:45 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Artur: Please make all of these testcases work properly, including the conversion fixes. Constantin, Marian and I wi... Greg Shah

04:35 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> Some of them are just caused by the conversion when unknown (?) is passed directly as parameter ... Marian Edu

04:22 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> @undoReturnErrorTopLevel@ doesn't have an override using @ProError@.
This is for the @return ... Marian Edu

03:47 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> > I do not think we have tests for default error handling for all blocks but we can maybe add tho... Marian Edu

08:19 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> * I think if we need to have a way to disable @STOP-AFTER@, via a directory configuratio... Eduard Soltan

05/29/2024

02:18 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

> I do not think we have tests for default error handling for all blocks but we can maybe add those to somewhere if n... Greg Shah

04:16 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> Marian: Where are we with testcases for @ON ERROR UNDO, THROW@?
We have tests for error handling... Marian Edu

05/28/2024

02:15 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian: Where are we with testcases for @ON ERROR UNDO, THROW@?
Constantin: Do we have a standalone testcase to recr... Greg Shah

05/24/2024

01:47 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
>From my point of view yes. The inner blocks with on stop undo, ... does not respond to StopConditi... Eduard Soltan

05/23/2024

10:58 AM Feature #4347: add runtime support for STOP-AFTER block option

>> Is @STOP-AFTER@ essentially an @ON STOP UNDO, LEAVE@ but only matching a timeout and not other kinds of @STOP@?
>... Greg Shah

10:33 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> * 4GL syntax
> ** "time limit" value
> *** Test both literals and "complex" expressions (a vari... Eduard Soltan

09:35 AM Feature #4347: add runtime support for STOP-AFTER block option

> > Here a StopCondition is triggered on @outerBlock1@, however because the nested @innerBlock1@ which has a @on stop... Greg Shah

09:34 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Greg Shah wrote:
> > > I think there is some behavior related to blocking UI statements... Greg Shah

09:26 AM Feature #4347: add runtime support for STOP-AFTER block option

Eduard, Please do the following:
* In the testcase, add elapsed timers around each of the cases where you are expe... Greg Shah

09:20 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> > I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if th... Constantin Asofiei

09:16 AM Feature #4347: add runtime support for STOP-AFTER block option

> I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if these exist, then the ... Greg Shah

02:43 AM Feature #4347: add runtime support for STOP-AFTER block option

I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if these exist, then the ST... Constantin Asofiei

02:39 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Marian Edu wrote:
> > That one works as expected for me (OE12.2), what you can do so it... Marian Edu

02:33 AM Feature #4347: add runtime support for STOP-AFTER block option

Marian Edu wrote:
> That one works as expected for me (OE12.2), what you can do so it doesn't look like it's mining ... Constantin Asofiei

02:28 AM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Here a StopCondition is triggered on @outerBlock1@, however because the nested @innerBlock1... Marian Edu

05/22/2024

06:04 PM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Committed on 4347a, revision 15205.
I understand from today's meeting that this commit add... Eric Faulhaber

02:48 AM Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15205.
Created a suite of test cases.
Also find some scenarios which behaviours in 4... Eduard Soltan

11:01 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> May I get a confirmation that @webtests_from_logs/results@ are results from Progress?
Yes, this is... Constantin Asofiei

08:44 AM Feature #6417: cleanup some known items in appserver support

May I get a confirmation that @webtests_from_logs/results@ are results from Progress? Galya B

02:26 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

There are cases when even if an ERROR condition is supposed to be morphed into a structured exception, and re-thrown ... Constantin Asofiei

02:24 AM Bug #8799 (Test): ON ERROR UNDO, THROW problems leading to infinite loops

Constantin Asofiei

05/21/2024

10:38 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Branch 6161a was merged to trunk rev 15229 and archived. Constantin Asofiei

08:34 AM Feature #6161 (Merge Pending): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-P...

You can merge to trunk after 7417b. Greg Shah

08:04 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Greg Shah wrote:
> What testing do you propose?
DYNAMIC-PROPERTY is not being used in other projects than #8433. S... Constantin Asofiei

07:58 AM Feature #6161 (Internal Test): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-P...

What testing do you propose? Greg Shah

07:58 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I think we just watch it in case it becomes a hotspot. One solution would be to group all the details of a property ... Greg Shah

07:30 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I've moved the bulk getter/setter to be resolved only if no indexed setter/getter is resolved at all. I'm not sure w... Constantin Asofiei

08:38 AM Feature #4347: add runtime support for STOP-AFTER block option

That explains it. I was looking at the 12.x docs. Greg Shah

07:47 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> According to https://docs.progress.com/bundle/openedge-startup-and-parameter-reference-1... Marian Edu

05/20/2024

12:51 PM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Code Review Task Branch 6161a Revision 15222
The changes look good.
The only concern I have is about performa... Greg Shah

07:34 AM Feature #6161 (Review): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY...

Created task branch 6161a from trunk rev 15222. rev 15223 fixed validation of the DYNAMIC-PROPERTY arguments for stat... Constantin Asofiei

11:59 AM Feature #4347: add runtime support for STOP-AFTER block option

Good.
Eduard: Create a new task for the @-catchStop@ behavior. Focus your implementation for this task on the tr... Greg Shah

11:57 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> > Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown.
... Constantin Asofiei

11:40 AM Feature #4347: add runtime support for STOP-AFTER block option

> Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown.
Are you saying tha... Greg Shah

11:39 AM Feature #4347: add runtime support for STOP-AFTER block option

> I tried to run this code in Procedure Editor, but it does not work as expected.
Do not run any test code from in... Greg Shah

09:12 AM Feature #4347: add runtime support for STOP-AFTER block option

Marian Edu wrote:
> As Constantin said you have to move the @catch@ block out of the @stop-after@ one and also make ... Eduard Soltan

08:51 AM Feature #4347: add runtime support for STOP-AFTER block option

As Constantin said you have to move the @catch@ block out of the @stop-after@ one and also make sure you remove the @... Marian Edu

08:26 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown. Do we want to implement ... Constantin Asofiei

05:24 AM Feature #4347: add runtime support for STOP-AFTER block option

... Eduard Soltan

05/16/2024

09:48 AM Feature #6407: name_map.xml improvements

Greg Shah wrote:
> I thought that in #6407-71, this was changed to a @List@ approach which has proper FIFO ordering.... Galya B

09:31 AM Feature #6407: name_map.xml improvements

Greg Shah wrote:
> You can include it in 8667a.
The fix was merged to trunk as rev. 15216. Galya B

08:30 AM Feature #6407: name_map.xml improvements

You can include it in 8667a. Greg Shah

02:08 AM Feature #6407: name_map.xml improvements

The comparison in the condition is solid... if it wasn't for @extProg.ooname = ooname.isEmpty() ? null : ooname;@. @o... Galya B

05/15/2024

10:38 AM Feature #6407: name_map.xml improvements

> Greg, why would #6667-995 fail with this test (@(!resolvedProgram.pname.equals(pname) || !ooname.equals(resolvedPro... Greg Shah

08:43 AM Feature #6407: name_map.xml improvements

Greg, why would #6667-995 fail with this test (@(!resolvedProgram.pname.equals(pname) || !ooname.equals(resolvedProgr... Constantin Asofiei

08:30 AM Feature #6407: name_map.xml improvements

> Interesting. Most of the discussion in this task is about how map resolvement should work and it's implemented acco... Greg Shah

03:00 AM Feature #6407: name_map.xml improvements

And let me state again, if there is a discrepancy in the content of the maps of two jars in the classpath, this is a ... Galya B

02:44 AM Feature #6407: name_map.xml improvements

I think we should actually be happy to have found this discrepancy in the scripts. Every time such malfunction appear... Galya B

02:40 AM Feature #6407: name_map.xml improvements

Greg Shah wrote:
> In #6667-995, Tomasz found that the server failed to start after picking up trunk rev 15180. The... Galya B

05/14/2024

09:34 AM Feature #4347: add runtime support for STOP-AFTER block option

Code Review (Part 2) Task Branch 4347a Revision 15204
7. Should we (can we?) name the @Timer@ thread to make it cl... Greg Shah

09:21 AM Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15204
1. Please explain why @Control.blockInterrupt()@ adds a remote call a... Greg Shah

08:29 AM Feature #4347: add runtime support for STOP-AFTER block option

I'm reviewing the code now. After reviewing the 4GL docs, I do have some questions. I also added Marian to coordina... Greg Shah

06:20 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Ah, you are right, there is a single thread where the tasks are posted. So there is no ... Eduard Soltan

03:12 AM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Review for 4347a rev 15204:
> > * what happens if there are n... Constantin Asofiei

02:49 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Review for 4347a rev 15204:
> * what happens if there are nested blocks with @STOP-AFTE... Eduard Soltan

02:16 AM Feature #4347: add runtime support for STOP-AFTER block option

Review for 4347a rev 15204:
* we need a @SessionListener@ to clean up the @StopAfterTimer.stopAfterTimerOuts@ map. ... Constantin Asofiei

05/13/2024

03:04 PM Feature #4347: add runtime support for STOP-AFTER block option

Greg or Constantin: please review. Eric Faulhaber

09:56 AM Feature #4347 (Review): add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15204. Eduard Soltan

03:03 PM Feature #6407: name_map.xml improvements

In #6667-995, Tomasz found that the server failed to start after picking up trunk rev 15180. The issue turned out to... Greg Shah

05:10 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> I'm looking back at the responses (in webtests_from_logs folder) and it does look like the asser... Galya B

05:02 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Marian Edu wrote:
> > Gayla
> It's Galya.
Galya :)
I'm looking back at the responses (in we... Marian Edu

04:50 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Gayla
It's Galya. Galya B

04:49 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> @com.goldencode.p2j.util.decimal@ has:
>
> [...]
>
> But testcases test @pipe_decimal_decimal... Marian Edu

04:48 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > Marian, do you have any idea why this test executed as batch in 4GL gives th... Galya B

03:58 AM Feature #6417: cleanup some known items in appserver support

Greg, how is this going to work? I have more questions than the number of failing tests (quite a few and all over the... Galya B

03:26 AM Feature #6417: cleanup some known items in appserver support

@com.goldencode.p2j.util.decimal@ has:... Galya B