FWD » Core Development » Base Language

06/25/2024

10:28 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

I've rebased 7643a from trunk rev 15308.
The changes are in rev 15311. With this, the tests in #8308-397, #8308-3... Constantin Asofiei

03:12 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Committed *8643a/rev.15307* which contains the 15272 and 15273... Dănuț Filimon

08:46 AM Feature #6417: cleanup some known items in appserver support

Just a quick note to inform you the tests for consuming WS from 4GL (FWD) client were converted to ABLUnit - availabl... Marian Edu

08:15 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > I think I should implement it and wait for the review to discuss it further, as per usual.
>
... Galya B

08:14 AM Feature #6417: cleanup some known items in appserver support

> I think I should implement it and wait for the review to discuss it further, as per usual.
Does this really have... Greg Shah

07:45 AM Feature #6417: cleanup some known items in appserver support

Marian, thanks for the references.
I've read the Progress documentation, so my question was if we do Progress-like... Galya B

07:39 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Greg Shah wrote:
> > Aren't we simulating the nameserver lookup with our services configuration in... Marian Edu

06:58 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> If I understand correctly, we are just trying to bypass the nameserver nonsense and use the servi... Galya B

06:48 AM Feature #6417: cleanup some known items in appserver support

Constantin: Please provide some details about how this is supposed to work and why we have it.
Consider that appli... Greg Shah

06:29 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Aren't we simulating the nameserver lookup with our services configuration in the directory?
We ... Galya B

06:23 AM Feature #6417: cleanup some known items in appserver support

Aren't we simulating the nameserver lookup with our services configuration in the directory? Greg Shah

03:33 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Greg Shah wrote:
> > We have no need for the nameserver. We don't plan to implement a replacement... Galya B

01:58 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> We have no need for the nameserver. We don't plan to implement a replacement for it. Any functi... Galya B

06/24/2024

09:55 AM Feature #6417: cleanup some known items in appserver support

We have no need for the nameserver. We don't plan to implement a replacement for it. Any functionality choices shou... Greg Shah

09:44 AM Feature #6417: cleanup some known items in appserver support

What's different in FWD is that appserver connect works without nameserver and without @-DirectConnect@. In Progress ... Galya B

08:47 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Galya B wrote:
> > Constantin, I don't understand what is the function of the appserver config @... Galya B

08:43 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin, I don't understand what is the function of the appserver config @services@ in the conte... Greg Shah

08:40 AM Feature #6417: cleanup some known items in appserver support

> > Where to find the 'TCP/IP services file' in Progress, where the IP <-> service name is configured for appserver c... Greg Shah

06:21 AM Feature #6417: cleanup some known items in appserver support

Another question: How to configure a default appserver for Progress nameserver? There is no such config in the web ma... Galya B

05:49 AM Feature #6417: cleanup some known items in appserver support

Constantin, I don't understand what is the function of the appserver config @services@ in the context of the finding ... Galya B

05:28 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Where to find the 'TCP/IP services file' in Progress, where the IP <-> service name is configured f... Galya B

04:03 AM Feature #6417: cleanup some known items in appserver support

Where to find the 'TCP/IP services file' in Progress, where the IP <-> service name is configured for appserver connect? Galya B

02:03 AM Feature #6417 (WIP): cleanup some known items in appserver support

6417d was merged to trunk as rev. 15307 and archived. Galya B

01:55 AM Feature #6417 (Merge Pending): cleanup some known items in appserver support

Galya, please merge 6417d Constantin Asofiei

06/21/2024

02:30 PM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Dănuț Filimon wrote:
> Committed *8643a/rev.15307* which contains the 15272 and 15273 revisions from *8308e*. (see #... Constantin Asofiei

10:29 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Committed *8643a/rev.15307* which contains the 15272 and 15273 revisions from *8308e*. (see #8308-397) Dănuț Filimon

10:12 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Created *8643a*. Dănuț Filimon

02:28 PM Feature #4347: add runtime support for STOP-AFTER block option

Alexandru Lungu wrote:
> > ETF or some other appserver application testing to confirm that we haven't affected anyth... Constantin Asofiei

10:24 AM Feature #4347: add runtime support for STOP-AFTER block option

Smoke tests for a customer GUI application passed. Șerban Bursuc

10:13 AM Feature #4347: add runtime support for STOP-AFTER block option

Rebased 4347a to latest trunk. It is now at rev. 15315. Alexandru Lungu

09:59 AM Feature #4347: add runtime support for STOP-AFTER block option

I am rebasing this now. Alexandru Lungu

09:58 AM Feature #4347: add runtime support for STOP-AFTER block option

> ChUI regression testing. It uses virtual sessions and more than one FWD server which is definitely affected by thes... Alexandru Lungu

09:42 AM Feature #4347: add runtime support for STOP-AFTER block option

Additional testing:
* ChUI regression testing. It uses virtual sessions and more than one FWD server which is def... Greg Shah

09:08 AM Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15212. Eduard Soltan

09:02 AM Feature #4347 (Internal Test): add runtime support for STOP-AFTER block option

Eduard, please assess #4347-68 for 4347a.
This should be ready to be merged, right? Greg, other testing you sugges... Alexandru Lungu

08:56 AM Feature #4347: add runtime support for STOP-AFTER block option

I tested Ctrl-C tests, with 4347a changes. And haven't got any regressions.
Also tested customer scenario, and it ... Eduard Soltan

12:09 PM Feature #6417: cleanup some known items in appserver support

No, no, I'm reverting, sorry, this is safer. Reverted in r15312. Galya B

12:08 PM Feature #6417: cleanup some known items in appserver support

Or at least I need to add one @if (port == 0)@ before the filter. Galya B

12:04 PM Feature #6417: cleanup some known items in appserver support

I think we should revert the @serviceName@ check. Less errors thrown, better. I think it's not correct now. What if i... Galya B

12:02 PM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > So you can have both port and serviceName. More, serviceName for UR... Constantin Asofiei

11:59 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> So you can have both port and serviceName. More, serviceName for URL connections is con... Galya B

11:46 AM Feature #6417: cleanup some known items in appserver support

See r15311. I'm committing the test without the if, it works well now. Galya B

11:40 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> > @appsrv/test/connect_errors/service_name.p@ is successful. Is it not?
> It's a 'false... Galya B

11:38 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > > Constantin Asofiei wrote:
> > > > There is also an issue with @(s... Constantin Asofiei

11:37 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > There is also an issue with @(serviceName == null || ... Galya B

11:20 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Our @-S@ is both @serviceName@ and @port@. So the port can be declared @0@ in the connect string, w... Constantin Asofiei

10:56 AM Feature #6417: cleanup some known items in appserver support

Note #6417-283 edited. Galya B

10:54 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Galya, please add back the @if (port != 0)@ test - this is required ... Galya B

10:33 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, please add back the @if (port != 0)@ test - this is required for connection strin... Galya B

10:29 AM Feature #6417: cleanup some known items in appserver support

Galya, please add back the @if (port != 0)@ test - this is required for connection strings like @-AppService app_serv... Constantin Asofiei

10:01 AM Feature #6417: cleanup some known items in appserver support

Constantin: Please review. Greg Shah

09:32 AM Feature #6417: cleanup some known items in appserver support

The fix for #7143-1017 is on 6417d. Galya B

08:56 AM Feature #6417: cleanup some known items in appserver support

This is a list of all testcases/appsrv/test procedures. Before they were converting / compiling fine, now not.
Galya B

05:36 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> There is also an issue with @(serviceName == null || data.services.contains(serviceName)... Galya B

05:29 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, please let me know when 6417d is available.
6417d is created from trunk r15306 a... Galya B

04:00 AM Feature #6417: cleanup some known items in appserver support

This is the async test:
* @appsrv/test/test_raise_quit2.p@... Constantin Asofiei

06/20/2024

05:19 PM Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15211
It looks good.
Minor issue: please remove the @import com.goldenco... Greg Shah

03:22 PM Feature #4347: add runtime support for STOP-AFTER block option

Eduard reported in today's meeting that he was working to get Ctrl+C testing running. Greg, FYI, there is a 4347a/152... Eric Faulhaber

10:17 AM Feature #6417: cleanup some known items in appserver support

Branch 6417c was merged to trunk rev 15305 and archived.
Constantin Asofiei

10:11 AM Feature #6417: cleanup some known items in appserver support

There is also an issue with the socket connection and 'nohostverify' - I've found when trying to run some reports in ... Constantin Asofiei

08:59 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> * the test does not match the comment, I assume it was meant to be 'not equal':
> [...]... Galya B

08:56 AM Feature #6417: cleanup some known items in appserver support

Go ahead and merge 6417c. Greg Shah

08:54 AM Feature #6417: cleanup some known items in appserver support

I've checked @test_raise_stop.p@, @test_raise_quit.p@, @test_return_value.p@ and these work with 6417c and a change i... Constantin Asofiei

08:41 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > 'Time' doesn't close old tasks by itself. My assessment is that this functionality should not b... Galya B

08:40 AM Feature #6417: cleanup some known items in appserver support

> 'Time' doesn't close old tasks by itself. My assessment is that this functionality should not be reverted.
That... Greg Shah

08:38 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > > No one is saying everything is your fault. And who really cares about blame when we simply n... Galya B

08:36 AM Feature #6417: cleanup some known items in appserver support

> > No one is saying everything is your fault. And who really cares about blame when we simply need to help a custom... Greg Shah

08:33 AM Feature #6417: cleanup some known items in appserver support

Constantin found the issue early today. If he spoke with me, we might have had already found the proper solution. If ... Galya B

08:31 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> No one is saying everything is your fault. And who really cares about blame when we simply need ... Galya B

08:29 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> runtime issue in converison issue with @FileSystemOps.initFileInfo@ fixed in 15299
This is not i... Galya B

08:28 AM Feature #6417: cleanup some known items in appserver support

No one is saying everything is your fault. And who really cares about blame when we simply need to help a customer w... Greg Shah

08:27 AM Feature #6417: cleanup some known items in appserver support

# runtime issue in @FileSystemOps.initFileInfo@ fixed in 15299
# conversion issue in @control_flow.rules@ fixed in 1... Greg Shah

08:25 AM Feature #6417: cleanup some known items in appserver support

I wondered how I get so many black points in the register. Now I see. All issues in FWD are on my account. Galya B

08:22 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> This is the 3rd regression from 6417a and if the solution Constantin proposes is not obviously sa... Galya B

08:20 AM Feature #6417: cleanup some known items in appserver support

> > Are you saying it is better to back out 6417a completely?
> I'm obviously saying that a hotfix takes some time a... Greg Shah

08:20 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Across all of our customers, SOAP is much less used than appserver. For this customer, it is clo... Galya B

08:19 AM Feature #6417: cleanup some known items in appserver support

Across all of our customers, SOAP is much less used than appserver. For this customer, it is close to a production i... Greg Shah

08:17 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Are you saying it is better to back out 6417a completely?
I'm obviously saying that a hotfix tak... Galya B

08:15 AM Feature #6417: cleanup some known items in appserver support

I mean when SOAP wasn't working for days after java 17 related changes merge it wasn't urgent. Galya B

08:15 AM Feature #6417: cleanup some known items in appserver support

Are you saying it is better to back out 6417a completely? Greg Shah

08:15 AM Feature #6417: cleanup some known items in appserver support

I'm generally surprised by the urgency of an issue not on production. Even issues on production usually take a day or... Galya B

08:13 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Galya: Please split this discussion into 2 parts. The first, urgent part is to ensure that 6417c... Galya B

08:10 AM Feature #6417: cleanup some known items in appserver support

Also don't expect me to remember just like that what a change done months ago involves. That's what automation is about. Galya B

08:07 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> This regression is holding back a customer's testing. While it exists in trunk, they are blocked... Galya B

07:49 AM Feature #6417: cleanup some known items in appserver support

This regression is holding back a customer's testing. While it exists in trunk, they are blocked. It is urgent to g... Greg Shah

06:19 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin Asofiei wrote:
> > > Galya B wrote:
> > > > Can you exp... Galya B

06:17 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Galya B wrote:
> > > Can you explain why you back it out? What are ... Constantin Asofiei

06:10 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > Can you explain why you back it out? What are the steps for reproduc... Galya B

06:07 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Can you explain why you back it out? What are the steps for reproducing an issue?
The root cause i... Constantin Asofiei

05:40 AM Feature #6417: cleanup some known items in appserver support

Can you explain why you back it out? What are the steps for reproducing an issue? Galya B

05:39 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> 6417c rev 15304 backed out part of trunk rev 15287 in AppServerManager - the client need... Galya B

05:37 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> 6417c rev 15304 backed out part of trunk rev 15287 in AppServerManager - the client need... Galya B

05:34 AM Feature #6417: cleanup some known items in appserver support

Created task branch 6417c from trunk rev 15303.
6417c rev 15304 backed out part of trunk rev 15287 in AppServerMan... Constantin Asofiei

03:12 AM Feature #6417: cleanup some known items in appserver support

Also the revert in #6417-235 breaks a core functionality of SOAP, so we should address it somehow. Galya B

03:10 AM Feature #6417: cleanup some known items in appserver support

Constantin, give me more information on #7143-1012. Galya B

06/19/2024

12:56 PM Feature #4347: add runtime support for STOP-AFTER block option

After making these changes, please work with Tomasz to run all the CTRL-C tests using this branch. Greg Shah

12:55 PM Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15210
This is good. It is very close.
1. I'm worried about the use of @... Greg Shah

11:00 AM Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15210.
Changed implementation to insert Ctrl-C into TypeAhead queue.
Added as spec... Eduard Soltan

07:55 AM Feature #6417: cleanup some known items in appserver support

Just a quick note to let you know the tests for calling appsrv from 4GL client (RPC style) were converted to AblUnit ... Marian Edu

04:46 AM Feature #6417: cleanup some known items in appserver support

Created task branch 6417b from trunk rev 15298 to fix an existing bug exposed by the changes in 6417a.
The fix is ... Constantin Asofiei

06/18/2024

03:35 PM Feature #4347: add runtime support for STOP-AFTER block option

> > > Perhaps we need to down-call to cause this to occur. But I don't think it is as simple as making a downcall, s... Greg Shah

01:46 PM Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15209
1. The changes to rewrite the @Control@ synchronization are extensive... Greg Shah

01:29 PM Feature #4347: add runtime support for STOP-AFTER block option

> >I think we might have to insert @CTRL-C@ into the type ahead queue. Interestingly, that should even work when the... Greg Shah

11:01 AM Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15209.
I implemented a mechanism to interrupt a Conversation thread and synchronize the... Eduard Soltan

06:40 AM Feature #6417 (WIP): cleanup some known items in appserver support

Greg Shah

05:31 AM Feature #6417: cleanup some known items in appserver support

6417a was merged to trunk as rev. 15287 and archived.
Galya B

03:04 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > Let me know about 7994a and merge.
> Lets get 6417a to trunk first ... Galya B

03:01 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Let me know about 7994a and merge.
Lets get 6417a to trunk first and after that we'll check #7994 ... Constantin Asofiei

02:59 AM Feature #6417 (Merge Pending): cleanup some known items in appserver support

This can be merged after 8848a Constantin Asofiei

01:36 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> > Galya, this must be from the Jetty upgrade - we need a @baseRequest.setHandled(true);@ being call... Galya B

12:38 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Did 6417a pass its testing? If so, I'd like to get it merged.
It passed, but my concern is th... Galya B

06/17/2024

03:05 PM Feature #6417: cleanup some known items in appserver support

Did 6417a pass its testing? If so, I'd like to get it merged. Greg Shah

02:39 PM Feature #6417: cleanup some known items in appserver support

> Greg/Tomasz: is it worth it to integrate the #7994 work from 6667i into 6417a, so we can merge it to trunk?
Yes,... Greg Shah

02:30 PM Feature #6417: cleanup some known items in appserver support

Galya, this must be from the Jetty upgrade - we need a @baseRequest.setHandled(true);@ being called always in @SoapHa... Constantin Asofiei

03:29 AM Feature #6417: cleanup some known items in appserver support

There is something wrong with SOAP on +trunk+. Jetty returns 404, although the @SoapHandler@ handles the requests suc... Galya B

06/14/2024

10:25 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
>I think we might have to insert @CTRL-C@ into the type ahead queue. Interestingly, that should ev... Eduard Soltan

06/13/2024

07:42 AM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Imagine an situation.
> If I am in timer thread and control is on the client side, I send a ... Greg Shah

04:02 AM Feature #4347: add runtime support for STOP-AFTER block option

Imagine an situation.
If I am in timer thread and control is on the client side, I send a interrupt message to the c... Eduard Soltan

01:30 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > Since the tests are up to date, how do I solve #6417-149?
> This is... Galya B

06/12/2024

11:11 AM Feature #4347: add runtime support for STOP-AFTER block option

OK, go ahead with that idea. Greg Shah

04:51 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> Perhaps we need to down-call to cause this to occur. But I don't think it is as simple as making... Eduard Soltan

10:16 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Since the tests are up to date, how do I solve #6417-149?
This is tricky; on a first glance, decim... Constantin Asofiei

09:11 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, I don't think you need to setup OpenEdge to run the REST/SOAP tests.
>
> @webt... Galya B

03:11 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> Do you think that 40% is accurate for %Done?
We need to run the tests from xfer - we'll now more... Constantin Asofiei

02:45 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Constantin Asofiei wrote:
> * Once a structured exception is re-thrown, mark it as explicit, so it can be re-thrown ... Galya B

06/11/2024

05:44 PM Bug #8799 (Test): ON ERROR UNDO, THROW problems leading to infinite loops

Do you think that 40% is accurate for %Done? Greg Shah

05:37 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Branch 8799a was merged to trunk rev 15279 and archived. Constantin Asofiei

05:16 PM Bug #8799 (Merge Pending): ON ERROR UNDO, THROW problems leading to infinite loops

You can merge to trunk now. Greg Shah

04:59 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

8799a passed #7156 customer testing and other unit tests. Constantin Asofiei

09:19 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Code Review Task Branch 8799a Revision 15277
I'm good with the changes. Greg Shah

08:15 AM Bug #8799 (Internal Test): ON ERROR UNDO, THROW problems leading to infinite loops

Constantin Asofiei

04:12 PM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Greg Shah wrote:
> >7. Help me understand why the implementation of Control.setControl() is ... Greg Shah

07:27 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> 8. In @StopAfterTimer.addTimeOut()@, directly raising @NumberedException@ seems to be incorrect. ... Eduard Soltan

07:22 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
>7. Help me understand why the implementation of Control.setControl() is correct. In particular, do... Eduard Soltan

08:04 PM Feature #4347: add runtime support for STOP-AFTER block option

Code Review 4347a Revisions 15205 through 15208
1. The @BlockManager.LOG@ should not be initialized using @ErrorMa... Greg Shah

05:39 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Can you check r15302.
The changes look good. I was trying to get a standalone test with FWD clien... Constantin Asofiei

04:18 AM Feature #6417: cleanup some known items in appserver support

Can you check r15302. Galya B

04:09 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Also, the @server@ handle can also be assigned to @SESSION@ - in thi... Constantin Asofiei

04:00 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Also, the @server@ handle can also be assigned to @SESSION@ - in this case, @if (serverH... Galya B

03:18 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> by @throw on the Conversion thread@ you meant @throw on the Conversation thread@?
Yes. ... Galya B

02:41 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Client type is not done. It will have to be reviewed and tested further. It's way more complicated ... Constantin Asofiei

01:36 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Review for 6417a/15301 built on trunk rev 15276:
> * @src/com/goldencode/p2j/oo/lang/Oe... Galya B

06/10/2024

11:57 AM Feature #6417: cleanup some known items in appserver support

Review for 6417a/15301 built on trunk rev 15276:
* @src/com/goldencode/p2j/oo/lang/OeversionInfo.java@
** in the ja... Constantin Asofiei

07:45 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> The runtime needs to be regression tested with ChUI and other unit testing for customer ... Galya B

07:44 AM Feature #6417: cleanup some known items in appserver support

New r15301 of 6417a based on trunk r15276 ready for review. Galya B

07:29 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Other cases need to be fixed by calling a new server exported method, which I forgot and left in TO... Galya B

07:26 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> ** @recordOrThrowError@ can be called from FWD client, too - why @if (serverSide) { thro... Galya B

07:01 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> * @src/com/goldencode/p2j/util/SessionUtils.java@
> ** for @getClientType@, the value o... Galya B

06:46 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> It fixes a startup procedure being configured without startup params.
OK, just for clarification: ... Constantin Asofiei

06:43 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > The last example doesn't work. If you want me to revert the change, ... Galya B

06:40 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> The last example doesn't work. If you want me to revert the change, it will continue to fail agents... Constantin Asofiei

06:33 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> I'm talking about this code in @Agent.listen@:
> [...]
>
> This is executed when the... Galya B

06:28 AM Feature #6417: cleanup some known items in appserver support

I'm talking about this code in @Agent.listen@:... Constantin Asofiei

06:22 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> I don't understand - startup procedure defines an input parameter, always. FWD must pas... Galya B

06:16 AM Feature #6417: cleanup some known items in appserver support

I don't understand - startup procedure defines an input parameter, always. FWD must pass this argument, otherwise th... Constantin Asofiei

06:14 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> * @src/com/goldencode/p2j/util/Agent.java@
> ** Agent's startup-procedure signature alw... Galya B

05:19 AM Feature #6417: cleanup some known items in appserver support

Comment this line, at the time this was written I think there was a problem with the log:
> // generateRestTests(RES... Constantin Asofiei

02:51 AM Feature #6417: cleanup some known items in appserver support

@SoapUILog2Harness@ doesn't compile. Galya B

02:44 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, I don't think you need to setup OpenEdge to run the REST/SOAP tests.
>
> @webt... Galya B

02:37 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > I need confirmation if I got it right: I need to figure out by myself how to... Galya B

06/09/2024

10:46 AM Feature #6417: cleanup some known items in appserver support

Review for 6417a/15226 built on trunk rev 15202:
* branch needs rebase
* files with missing history entry:... Constantin Asofiei

02:39 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Created task branch 8799a from trunk rev 15266. Rev 15277 has:
* Once a structured exception is re-thrown, mark it ... Constantin Asofiei

06/07/2024

09:27 AM Feature #6417: cleanup some known items in appserver support

Galya, I don't think you need to setup OpenEdge to run the REST/SOAP tests.
@webtests_from_logs@ is meant to autom... Constantin Asofiei

09:19 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> I need confirmation if I got it right: I need to figure out by myself how to setup Progress classic... Marian Edu

08:46 AM Feature #6417: cleanup some known items in appserver support

I need confirmation if I got it right: I need to figure out by myself how to setup Progress classic appserver with RE... Galya B

08:21 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > The comment also says run all SoapUI tests. Am I supposed to set SOAP and REST api in Progress ... Galya B

08:14 AM Feature #6417: cleanup some known items in appserver support

> The comment also says run all SoapUI tests. Am I supposed to set SOAP and REST api in Progress corresponding to wha... Greg Shah

07:58 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Is this not what was documented in #6417-8 and following discussion?
The "documentation" is ex... Galya B

07:40 AM Feature #6417: cleanup some known items in appserver support

Is this not what was documented in #6417-8 and following discussion? Greg Shah

07:33 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Setup equivalent testing environments in both OE and FWD.
Hasn't this already been done / docume... Galya B

07:29 AM Feature #6417: cleanup some known items in appserver support

Can you start with this:
# Setup equivalent testing environments in both OE and FWD.
# Run the tests in both envi... Greg Shah

07:25 AM Feature #6417: cleanup some known items in appserver support

I can't proceed with fixing all tests or related issues in FWD appservers without clear documentation what has been d... Galya B

07:24 AM Feature #6417: cleanup some known items in appserver support

We should separate our artifacts from OE and FWD. Either by more specific name or by separate directories. Greg Shah

07:19 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > So @webtests_from_logs/results/20211112_201954_soap_classic/test_set... Galya B

07:17 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Galya, the @errorCode@ text from the @Error in SOAP parameter: error... Constantin Asofiei

06:27 AM Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, the @errorCode@ text from the @Error in SOAP parameter: errorCode@ message is the... Galya B

06:22 AM Feature #6417: cleanup some known items in appserver support

Galya, the @errorCode@ text from the @Error in SOAP parameter: errorCode@ message is the first argument from @new App... Constantin Asofiei

06:12 AM Feature #6417: cleanup some known items in appserver support

I'm puzzled by @webtests_from_logs/results/20211112_201954_soap_classic/test_set_2_exceptions/test_5_throw_error_1.ht... Galya B

08:01 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

In #8308, it was discovered that errors related to the database are handled differently when a CATCH block is present... Dănuț Filimon

06/05/2024

03:10 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

For this test:... Constantin Asofiei

09:09 AM Feature #6417: cleanup some known items in appserver support

Marian may just be referencing your comment from #6417-160 where you said "I'm not testing OE.". Greg Shah

08:51 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> I still don't understand how do you plan to fix those tests without testing against a real Progr... Galya B

08:48 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Marian: Can you please list them here so that Galya knows not to touch those without discussing... Marian Edu

08:45 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Marian, the work on the tests seems disjointed. I'm trying to help the team coordinate their versio... Marian Edu

08:42 AM Feature #6417: cleanup some known items in appserver support

> > Galya: The failures you mention in #6417-162 are from the harness, probably something written by Constantin. The... Greg Shah

08:14 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Galya: The failures you mention in #6417-162 are from the harness, probably something written by ... Galya B

08:06 AM Feature #6417: cleanup some known items in appserver support

Galya: The failures you mention in #6417-162 are from the harness, probably something written by Constantin. These w... Greg Shah

08:05 AM Feature #6417: cleanup some known items in appserver support

Marian, I believe acorn.ro is familiar not only with the @*.log@ files, but also with the SoapUI tests:... Galya B

07:57 AM Feature #6417: cleanup some known items in appserver support

Marian, let me help you understand what I'm working on here:
Greg Shah wrote:
> These are items that can be found... Galya B

07:53 AM Feature #6417: cleanup some known items in appserver support

Marian, the work on the tests seems disjointed. I'm trying to help the team coordinate their versions to achieve a st... Galya B

07:30 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Well said. The asserts in the SoapUI tests indeed match those from the Progress runs, i.e. are fa... Marian Edu

07:02 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ ... Galya B

06:44 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > Greg please let me know if we should move those to ABLUnit as well.
>
> Yes
>
> > Not sur... Marian Edu

06:42 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ are based on the OE res... Marian Edu

06:28 AM Feature #6417: cleanup some known items in appserver support

> Greg please let me know if we should move those to ABLUnit as well.
Yes
> Not sure if FWD supports this (RPC,... Greg Shah

06:26 AM Feature #6417: cleanup some known items in appserver support

> > > I find it very weird that so many tests were failing in OE, but not fixed,
> >
> > Please be more specific ... Greg Shah

05:57 AM Feature #6417: cleanup some known items in appserver support

The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ are based on the OE results in @testcases... Galya B

05:18 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> I'm not testing OE.
Maybe we've got confused by your previous statement then... "I find it very... Marian Edu

12:43 AM Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > I find it very weird that so many tests were failing in OE, but not fixed,
>
> Please be mo... Galya B

06/04/2024

04:54 PM Feature #6417: cleanup some known items in appserver support

> I find it very weird that so many tests were failing in OE, but not fixed,
Please be more specific about this. ... Greg Shah

09:39 AM Feature #4347: add runtime support for STOP-AFTER block option

We don't want a timer thread to exist if there is no @STOP-AFTER@ active. Greg Shah

08:51 AM Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15208. Eduard Soltan

08:14 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> * StopAfterTimer
> ** in the constructor, the @if (timer == null)@ is not needed - you ... Eduard Soltan

06/03/2024

08:12 AM Feature #6417: cleanup some known items in appserver support

I find it very weird that so many tests were failing in OE, but not fixed, instead directly ported to testcases and s... Galya B

03:13 AM Feature #4347: add runtime support for STOP-AFTER block option

Review for 4347a rev 15206:
* StandardServer
** only change is a 'bad import', revert this file to rev 15203.
* Bl... Constantin Asofiei

05/30/2024

08:46 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> Marian Edu wrote:
> > Some of them are just caused by the conversion when unknown (?) is passed... Greg Shah

08:45 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Artur: Please make all of these testcases work properly, including the conversion fixes. Constantin, Marian and I wi... Greg Shah

04:35 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> Some of them are just caused by the conversion when unknown (?) is passed directly as parameter ... Marian Edu

04:22 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> @undoReturnErrorTopLevel@ doesn't have an override using @ProError@.
This is for the @return ... Marian Edu

03:47 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> > I do not think we have tests for default error handling for all blocks but we can maybe add tho... Marian Edu

08:19 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> * I think if we need to have a way to disable @STOP-AFTER@, via a directory configuratio... Eduard Soltan

05/29/2024

02:18 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

> I do not think we have tests for default error handling for all blocks but we can maybe add those to somewhere if n... Greg Shah

04:16 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> Marian: Where are we with testcases for @ON ERROR UNDO, THROW@?
We have tests for error handling... Marian Edu

05/28/2024

02:15 PM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian: Where are we with testcases for @ON ERROR UNDO, THROW@?
Constantin: Do we have a standalone testcase to recr... Greg Shah