FWD » Core Development » Base Language

08/12/2024

03:36 PM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

I looked at @FastFindCache@ after the rebase/rework. The changes look ok to me. Is there a reason the same type of ca... Eric Faulhaber

01:51 PM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I'm trying to remember why I structured the @unknownModeResto... Constantin Asofiei

01:02 PM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Eric Faulhaber wrote:
> I'm trying to remember why I structured the @unknownModeRestore@ variable in @AbstractQuery.... Constantin Asofiei

10:31 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Code Review 9019a/15376-15386 (persistence-specific):
I'm trying to remember why I structured the @unknownModeRest... Eric Faulhaber

04:09 AM Bug #9032: Reduce the number of exceptions that are being thrown

I got blocked again as I am not able to reproduce the "null.*" import, the latest example I managed to create is:
<p... Dănuț Filimon

08/09/2024

11:44 AM Bug #9037 (Review): Two timers problem: only one fires

The 8393b rev. 15374 contains the change for #9037-7 and the fix for the #9037-12 issue. Please, review. Vladimir Tsichevski

10:16 AM Bug #9037: Two timers problem: only one fires

Vladimir Tsichevski wrote:
> I retested the issue once again: it appears sometimes still (but rarely), despite the p... Vladimir Tsichevski

08:47 AM Bug #9037 (WIP): Two timers problem: only one fires

I retested the issue once again: it appears sometimes still (but rarely), despite the problem with @ServerEvent@ init... Vladimir Tsichevski

10:25 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Code Review Task Branch 9019a Revisions 15376 through 15386
I'm good with the changes.
Eric: You need to review... Greg Shah

07:18 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

9019a has some other changes:
* rev 15386 - Inlined the SQLQuery logging, to avoid capturing lambdas.
* rev 15385 -... Constantin Asofiei

03:34 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

> Stefanel, unless you have more pending fixes, pleas consider 9019a frozen. My plan is to test this on my machine, ... Stefanel Pezamosca

03:29 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

9019a 15369 was rebased from trunk rev 15375 - new rev 15384.
Stefanel, unless you have more pending fixes, pleas ... Constantin Asofiei

03:27 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

I'm rebasing 9019a now. Constantin Asofiei

03:18 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Stefanel, is 9019a in a good place to review/cleanup/test? Constantin Asofiei

09:16 AM Bug #9032: Reduce the number of exceptions that are being thrown

Ovidiu Maxiniuc wrote:
> Dănuț Filimon wrote:
> > Ovidiu, do you have any small example that will reach @createImpo... Dănuț Filimon

07:44 AM Bug #9032: Reduce the number of exceptions that are being thrown

Committed *9032a/15369*. Removed usage of Arrays.stream(), incorporated the functionality in a separate method named ... Dănuț Filimon

06:48 AM Bug #9032: Reduce the number of exceptions that are being thrown

I've made a few adjustments to reduce the search for null parameter types. Instead of using @Arrays.stream(parTypes).... Dănuț Filimon

04:04 AM Bug #9032: Reduce the number of exceptions that are being thrown

Tested a customer scenario, 100 runs with and without 9032a and got the following results:
|_. Test |_.... Dănuț Filimon

02:08 AM Bug #9032: Reduce the number of exceptions that are being thrown

Ovidiu Maxiniuc wrote:
> Back to your idea: indeed, the errors are (if not, they probably should be) immutable objec... Dănuț Filimon

08/08/2024

03:24 PM Bug #9037: Two timers problem: only one fires

Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > Yes, that makes sense. Should we switch all of the current synch... Vladimir Tsichevski

02:25 PM Bug #9037: Two timers problem: only one fires

> Also, I think, the following code should by executed synchronized:
Agreed. Greg Shah

02:05 PM Bug #9037: Two timers problem: only one fires

Greg Shah wrote:
> Yes, that makes sense. Should we switch all of the current synchronization to that same lock obj... Vladimir Tsichevski

01:41 PM Bug #9037: Two timers problem: only one fires

Yes, that makes sense. Should we switch all of the current synchronization to that same lock object? Greg Shah

01:34 PM Bug #9037: Two timers problem: only one fires

Greg Shah wrote:
> Code Review Task Branch 8393b Revision 15373
>
> I don't think it is correct to synchronize on... Vladimir Tsichevski

01:14 PM Bug #9037: Two timers problem: only one fires

Code Review Task Branch 8393b Revision 15373
I don't think it is correct to synchronize on @dependencies@. That i... Greg Shah

09:13 AM Bug #9037 (Review): Two timers problem: only one fires

Branch 8393b rev. 15373 fixes this issue. Please, review. Vladimir Tsichevski

09:12 AM Bug #9037 (WIP): Two timers problem: only one fires

Vladimir Tsichevski

09:59 AM Bug #9032: Reduce the number of exceptions that are being thrown

Dănuț Filimon wrote:
> Ovidiu, do you have any small example that will reach @createImport()@? I've tried to create ... Ovidiu Maxiniuc

09:54 AM Bug #9032: Reduce the number of exceptions that are being thrown

Dănuț Filimon wrote:
> Something I thought of based on #9032-17, we can have a single ErrorConditionException instan... Ovidiu Maxiniuc

08:55 AM Bug #9032: Reduce the number of exceptions that are being thrown

Something I thought of based on #9032-17, we can have a single ErrorConditionException instance that can be thrown fo... Dănuț Filimon

03:41 AM Bug #9032: Reduce the number of exceptions that are being thrown

Ovidiu, do you have any small example that will reach @createImport()@? I've tried to create one similar to one of th... Dănuț Filimon

03:25 AM Bug #9032: Reduce the number of exceptions that are being thrown

Discussed during yesterday's meeting, relying on other exceptions to fill the callStack of the error for a LegacyErro... Dănuț Filimon

03:13 AM Bug #9032: Reduce the number of exceptions that are being thrown

I tested a customer scenario, 100 runs with 9032a/15268 and com.goldencode.p2j.util.DeferredLegacyErrorException does... Dănuț Filimon

02:47 AM Bug #9032: Reduce the number of exceptions that are being thrown

Committed *9032a/15268*.
* Reduce the number of DeferredLegacyErrorException by relying on a single instantiated obj... Dănuț Filimon

08/07/2024

04:10 PM Bug #9037: Two timers problem: only one fires

The problem is that the following code can be executed in *both* @PSTimer@ threads, so, the context for @ServerEvent.... Vladimir Tsichevski

03:43 PM Bug #9037: Two timers problem: only one fires

When two @PSTimer@ instances are defined to fire simultaneously, sometimes only one of them fires.
To reproduce ru... Vladimir Tsichevski

03:37 PM Bug #9037 (WIP): Two timers problem: only one fires

Vladimir Tsichevski

07:00 AM Bug #9032: Reduce the number of exceptions that are being thrown

Yes, we do this already. Any exception that doesn't need a stack trace is a candidate for this "trick". It saves a ... Greg Shah

05:47 AM Bug #9032: Reduce the number of exceptions that are being thrown

Greg Shah wrote:
> One idea: have a configurable option to throw a single pre-constructed instance (per context) of ... Dănuț Filimon

08/06/2024

10:06 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

I committed other changes to *9019a revision 15369*.
About the usage of the new JMX_DEBUG flag: I think checking i... Stefanel Pezamosca

09:43 AM Bug #9032: Reduce the number of exceptions that are being thrown

> Also, about the @ErrorConditionException@ and NO-ERROR mode: I don't think we can aggressively change this so that ... Greg Shah

08:54 AM Bug #9032: Reduce the number of exceptions that are being thrown

Constantin Asofiei wrote:
> @printfln@ will be in the FWD server's log, but the logging level is @FINE@, so unless y... Dănuț Filimon

08:46 AM Bug #9032: Reduce the number of exceptions that are being thrown

Dănuț Filimon wrote:
> Ovidiu Maxiniuc wrote:
> > However, inserting a @printfln("%s", copy.dumpTree(true))@ will r... Constantin Asofiei

08:45 AM Bug #9032: Reduce the number of exceptions that are being thrown

Ovidiu Maxiniuc wrote:
> However, inserting a @printfln("%s", copy.dumpTree(true))@ will reveal the node type/text a... Dănuț Filimon

08:44 AM Bug #9032: Reduce the number of exceptions that are being thrown

Also, about the @ErrorConditionException@ and NO-ERROR mode: I don't think we can aggressively change this so that th... Constantin Asofiei

08:43 AM Bug #9032: Reduce the number of exceptions that are being thrown

Dănuț Filimon wrote:
> The jroot JavaAst when calling createImport() is:
> [...]
I was not referring to the JAST, ... Ovidiu Maxiniuc

08:36 AM Bug #9032: Reduce the number of exceptions that are being thrown

If you add @-Drules.tracing=true@ at the FWD server, I think the runtime conversion will emit the @by-rule@ annotatio... Constantin Asofiei

08:22 AM Bug #9032: Reduce the number of exceptions that are being thrown

The jroot JavaAst when calling createImport() is:... Dănuț Filimon

08:05 AM Bug #9032: Reduce the number of exceptions that are being thrown

Dănuț Filimon wrote:
> [...] Not sure where this CE3124 comes from?
The TRPL code is assembled into Java code. This... Ovidiu Maxiniuc

07:34 AM Bug #9032: Reduce the number of exceptions that are being thrown

Dănuț Filimon wrote:
> The "null.*" comes from @rules/convert/buffer_definitions.rules line 703@.
This is the probl... Dănuț Filimon

07:29 AM Bug #9032: Reduce the number of exceptions that are being thrown

The "null.*" comes from @rules/convert/buffer_definitions.rules line 703@. Dănuț Filimon

07:13 AM Bug #9032: Reduce the number of exceptions that are being thrown

I've identified where the "null.*" is added, it comes from @CE3124@ (I remember seeing this type of class a lot), the... Dănuț Filimon

06:26 AM Bug #9032: Reduce the number of exceptions that are being thrown

Dănuț Filimon wrote:
> Ovidiu Maxiniuc wrote:
> You are right, the import path is actually @"null."@ and not @null@... Ovidiu Maxiniuc

02:51 AM Bug #9032: Reduce the number of exceptions that are being thrown

Ovidiu Maxiniuc wrote:
> Dănuț,
>
> I looked over your changes in r15367, Jast interpreter. I have a few questio... Dănuț Filimon

08/05/2024

01:36 PM Bug #9032: Reduce the number of exceptions that are being thrown

Dănuț,
I looked over your changes in r15367, Jast interpreter. I have a few questions here:
* in which cases @im... Ovidiu Maxiniuc

09:29 AM Bug #9032 (WIP): Reduce the number of exceptions that are being thrown

I've created *9032a* and committed revision *15367*, the changes include:
* Avoid looking up methods when the signat... Dănuț Filimon

09:05 AM Bug #9032: Reduce the number of exceptions that are being thrown

This is a separate issue created based on #7026-314.
From the same note:
4. Exceptions
|_. Class |_. Count |
|... Dănuț Filimon

08:27 AM Bug #9032 (WIP): Reduce the number of exceptions that are being thrown

Dănuț Filimon

10:22 AM Bug #9019 (Review): reduce the usage of capturing lambdas in FWD runtime

I committed my last changes to *9019a revision 15368*.
There were some changes before that were doing more bad tha... Stefanel Pezamosca

06:17 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Attached is the capturing lambda with 9019a/15367 and some changes I didn't yet commit. Constantin Asofiei

03:19 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

For now, just to be on the safe side I made a new Runnable field to store and use it in case all previous values are ... Stefanel Pezamosca

08/02/2024

05:25 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Can @setActiveBuffer@ ever be called while another call is active? I mean, currently we bracket this with @setActiveB... Constantin Asofiei

03:47 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

So, in @BaseRecord@ the only capturing lambda use I've seen is this one in @setActiveBuffer()@:... Stefanel Pezamosca

08/01/2024

10:08 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

I committed to branch 9019a: (15363..15366)
* Extracted processCommit and processRollback lambdas to processCommitIm... Stefanel Pezamosca

07/31/2024

10:34 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

> Will be true if we add @-Djmx.debug@ to JVM arguments.
> Or something similar.
Let's name it @-Dfwd_jmx_debug@ ... Greg Shah

10:33 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

I committed to branch 9019a revision 15362:
* I added the JMX_DEBUG flag in @FwdServerJMX.java@.
* Skipped the HYD... Stefanel Pezamosca

08:48 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

So, I can add something like:... Stefanel Pezamosca

08:26 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

I'm OK with that (for the debugging cases). The default should be no lambdas. Greg Shah

08:24 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg, adding a JVM-level argument to enable JMX lambdas may help (... Constantin Asofiei

08:23 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Constantin Asofiei wrote:
> Greg, adding a JVM-level argument to enable JMX lambdas may help (this would mean that d... Greg Shah

08:05 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Greg, adding a JVM-level argument to enable JMX lambdas may help (this would mean that depending on this flag we eith... Constantin Asofiei

07:38 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

No, that's still an instance created for the anon class. The point is to avoid instances being created (either via a... Constantin Asofiei

07:21 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Constantin, would this be considered as an improvement ? ... Stefanel Pezamosca

05:03 AM Bug #9019 (WIP): reduce the usage of capturing lambdas in FWD runtime

Sure, I will start working on this now. Stefanel Pezamosca

04:48 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime

Each capturing lambda in Java acts as a pseudo-anonymous class, and an instance of it is created on each call, to 'ca... Constantin Asofiei

04:36 AM Bug #9019 (Test): reduce the usage of capturing lambdas in FWD runtime

Constantin Asofiei

07/29/2024

02:44 AM Bug #9008: Trigger fired when iterating a Finalizable collection allows it to be modified

The main issue has been discussed in #8963-40 and #8963-44, the problem is as follows:
- When the Finalizables colle... Dănuț Filimon

02:30 AM Bug #9008 (New): Trigger fired when iterating a Finalizable collection allows it to be modified

Dănuț Filimon

07/25/2024

08:54 AM Bug #6570 (Closed): stale procedure leak when appservers are used

Greg Shah

06:39 AM Bug #6570 (Test): stale procedure leak when appservers are used

This was fixed in a recent memory leak fix done for a large customer. This is no longer a problem and can be closed. Alexandru Lungu

07/22/2024

09:26 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> * @oo/core/system/ArgumentError@
> ** why the static constructor is adding a @Argument ... Marian Edu

07/21/2024

06:09 PM Feature #6410: implement additional built-in OO classes/interfaces

Partial (see above) review of 6410b, r15339-15357:
* general issues:
** the H entries do not contain a new number... Ovidiu Maxiniuc

07/17/2024

08:41 AM Bug #8978: ErrorConditionException in not being propagated correctly

This ticket is derived from #8912-105. Artur Școlnic

08:40 AM Bug #8978: ErrorConditionException in not being propagated correctly

... Artur Școlnic

08:38 AM Bug #8978: ErrorConditionException in not being propagated correctly

myClass file... Artur Școlnic

08:35 AM Bug #8978 (Closed): ErrorConditionException in not being propagated correctly

Artur Școlnic

08:15 AM Feature #6410: implement additional built-in OO classes/interfaces

6410b rev 14873 built on trunk 14856 was rebased from trunk rev 15338 - new rev 15355.
rev 15356/15357 contains re... Constantin Asofiei