Project

General

Profile

Activity

From 11/28/2025 to 12/27/2025

12/25/2025

03:31 PM Bug #11080 (WIP): DATETIME / DATETIME-TZ Format (Time and Timezone Offset) Validation Issues
Vladimir Tsichevski
03:30 PM Bug #11080: DATETIME / DATETIME-TZ Format (Time and Timezone Offset) Validation Issues
h1. DATETIME / DATETIME-TZ Format Specification
This specification defines the valid format strings for @DATETIME@...
Vladimir Tsichevski
01:29 PM Bug #11080: DATETIME / DATETIME-TZ Format (Time and Timezone Offset) Validation Issues
When an invalid format is passed to @STRING(DATETIME, FORMAT)@, OE raises an error.
FWD does not consistently enfo...
Vladimir Tsichevski
12:36 PM Bug #11080 (WIP): DATETIME / DATETIME-TZ Format (Time and Timezone Offset) Validation Issues
Vladimir Tsichevski

12/24/2025

09:22 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR
Can the 8309a branch be merged into trunk?
The change is already over a year old. Merging it directly into the curre...
Vladimir Tsichevski

12/23/2025

08:05 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
Code Review Task Branch 6506b Revisions 16293 through 16295
Radu: Although Florin wrote the changes in the E4GL pr...
Greg Shah
06:49 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
Review of 6506b rev 16295:
* @name_map.xml@ and related code: I think we need to add a @fwdwebspeed/@ prefix for the...
Constantin Asofiei
06:15 AM Bug #10362 (WIP): FastFindCache.L2Key uses the buffer alias in the FQL
I don't think the approach will work - if I'm not mistaken, a DOT can be part of literals (like digits or strings).
...
Constantin Asofiei
06:13 AM Bug #11043: NPE in SAX-PARSE if the file does not exist
Ovidiu Maxiniuc wrote:
> Should I merge this into 9457c?
Is on my list, I'll do it. Thanks.
Constantin Asofiei
06:13 AM Bug #11043: NPE in SAX-PARSE if the file does not exist
Done. Committed revision 16329.
Should I merge this into 9457c?
Ovidiu Maxiniuc
03:41 AM Bug #11043 (Internal Test): NPE in SAX-PARSE if the file does not exist
Beside this @catch (UnsupportedOperationException | IOException e)@ which should have each type on its own line, the ... Constantin Asofiei

12/22/2025

03:50 PM Bug #11043 (Review): NPE in SAX-PARSE if the file does not exist
The absence of file, signalled by a legacy file not found error was ignored, causing the internal data of @SaxReaderI... Ovidiu Maxiniuc
03:47 PM Bug #11043 (WIP): NPE in SAX-PARSE if the file does not exist
Ovidiu Maxiniuc

12/19/2025

05:38 PM Bug #11048 (Internal Test): Temp-table wrong SERIALIZE-NAME when using same DMO
I think the r16323 is fine. To note that @getTable()@ will still return @dmoInfo.legacyTable@ in case of permanent ta... Ovidiu Maxiniuc
07:38 AM Bug #4734 (Closed): Invalid string to date conversion for non-"mm/dd/yyyy" format
Greg Shah
07:18 AM Bug #4734: Invalid string to date conversion for non-"mm/dd/yyyy" format
This issue no longer reproduces and should be closed (trunk rev. 16324). Vladimir Tsichevski

12/18/2025

02:42 AM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
Committed revision *16323* on task branch *11048a*:
- Fixed regression from 16322.
- @BUFFER-FIELD(INTEGER)@ should...
Teodor Gorghe

12/17/2025

04:56 PM Feature #6432: implement the WEB special stream
Greg Shah wrote:
> Please check if the @WEB@ stream can be opened in input mode, and whether it can have @paged@ or ...
Radu Apetrii
01:13 PM Bug #11042 (Internal Test): NativeInvoker may generate memptr with unknown size
Code Review Task Branch 11042a Revision 16324
No objections. The change seems right.
Greg Shah
08:23 AM Bug #11042 (Review): NativeInvoker may generate memptr with unknown size
I committed 11042a/rev. 16324.
* I forced the size of the memptr to be 4 or 8 to represent the pointer gathered th...
Alexandru Lungu
12:56 PM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
I will put this into the highest priority for tomorrow. Teodor Gorghe
11:46 AM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
Teodor,
I looked at the new branch and the code looks is OK to me. Please drop line 5110 since @dmoInfo@ local va...
Ovidiu Maxiniuc
10:52 AM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
The problem is that 4GL is case insensitive from the PoV of identifiers. Therefore @ttNAME@ and @ttName@ are identica... Ovidiu Maxiniuc
08:58 AM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
Please create more tests using an explicit @DEFINE BUFFER@ and see what happens.
I have a feeling we may need to c...
Constantin Asofiei
04:51 AM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
Thanks. The change makes sense then.
Please check also:
* @BufferImpl.getTable()@
* error messages in @BufferImp...
Constantin Asofiei
04:48 AM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
PTestDsTtlegacyName: Ttname_1_1.Buf ttname = TemporaryBuffer.define(Ttname_1_1.Buf.class, "ttname", "ttNAME", false, ... Teodor Gorghe
04:48 AM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
Please post how the TemporaryBuffer.define looks for the two tables. Constantin Asofiei
04:07 AM Bug #11048 (Review): Temp-table wrong SERIALIZE-NAME when using same DMO
Committed revision *16322* on task branch *11048a*:
- @SERIALIZE-NAME@ implementation should use the @_name()@ inste...
Teodor Gorghe
03:53 AM Bug #11048 (WIP): Temp-table wrong SERIALIZE-NAME when using same DMO
Created task branch *11048a*. Teodor Gorghe
03:45 AM Bug #11048: Temp-table wrong SERIALIZE-NAME when using same DMO
Suppose we have the following project, with 2 files, @pTestDsTTLegacyName.p@ and @pTestDsTTLegacyName2.p@:
* pTest...
Teodor Gorghe
03:34 AM Bug #11048 (Closed): Temp-table wrong SERIALIZE-NAME when using same DMO
Teodor Gorghe
07:41 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
Greg Shah wrote:
> Every time you rebase, please post in the task to let watchers know the status. The post should ...
Radu Apetrii
07:37 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
Every time you rebase, please post in the task to let watchers know the status. The post should be something like "R... Greg Shah
06:15 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
Greg, you should be looking at 6506b, not 'a'. Sorry it is not clear in this task. In #10109-314 the 'b' branch is me... Radu Apetrii
06:13 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
Are you holding off on rebase to wait for code review?
The Jetty 12 changes came in trunk 16293 and I'm especially...
Greg Shah

12/16/2025

01:43 PM Feature #6432: implement the WEB special stream
As seen in a customer project, using 6506a rev 15777, the following code fails to convert:... Greg Shah
01:27 PM Feature #6432: implement the WEB special stream
> Please check if the @WEB@ stream can be opened in input mode, and whether it can have @paged@ or @page-size@ set. ... Greg Shah
09:48 AM Bug #11043: NPE in SAX-PARSE if the file does not exist
This test fails with NPE if the file does not exist:... Constantin Asofiei
09:47 AM Bug #11043 (Closed): NPE in SAX-PARSE if the file does not exist
Constantin Asofiei
07:39 AM Bug #11042 (WIP): NativeInvoker may generate memptr with unknown size
This is a regression of #9448, where @BinaryData.getMethodSetup@ now returns false if the size is 0. This is incorrec... Alexandru Lungu
07:33 AM Bug #11042 (Test): NativeInvoker may generate memptr with unknown size
Alexandru Lungu
07:29 AM Bug #11038: Cannot find symbol when using two frames with the same name
Radu Apetrii wrote:
> So, in this case, do we just need to have some form of discrimination between frames with the ...
Greg Shah
07:18 AM Bug #11038: Cannot find symbol when using two frames with the same name
So, in this case, do we just need to have some form of discrimination between frames with the same name? Or at least ... Radu Apetrii
06:47 AM Bug #11038: Cannot find symbol when using two frames with the same name
I mis-read the code. Multiple @def frame@ instances do indeed create multiple frames, it is just that one of them is... Greg Shah
06:26 AM Bug #11038: Cannot find symbol when using two frames with the same name
Greg Shah wrote:
> > Notice how both frames have the same name
>
> This is not correct. The issue is that there ...
Radu Apetrii
06:14 AM Bug #11038: Cannot find symbol when using two frames with the same name
> Notice how both frames have the same name
This is not correct. The issue is that there should only be one frame...
Greg Shah
04:53 AM Bug #11038: Cannot find symbol when using two frames with the same name
I stumbled upon this when working with a customer application. Here's a testcase:... Radu Apetrii
04:33 AM Bug #11038 (New): Cannot find symbol when using two frames with the same name
Radu Apetrii
05:14 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden
Committed revision *16296* on task branch *10925a*:
- Use count iteration instead of iterator.
Teodor Gorghe
05:11 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden
Teodor, please use a counter loop instead of a for iterator loop - this avoids creating a new iterator instance. Constantin Asofiei
04:22 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden
Committed revision *16295* on task branch *10925a*:
- Fixed regression from last 2 revisions.
Teodor Gorghe

12/15/2025

02:59 PM Bug #7184 (Review): Incorrect conversion of concatenated string literals to a LONGCHAR
Branch 7184b (rev 16320) resolves the root cause of incorrect type promotion for concatenated string literals passed ... Vladimir Tsichevski
10:28 AM Bug #7184 (WIP): Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski
08:45 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden
Committed revision *16295* on task branch *10925a*:
- Added the correct fix for this issue: Keep returning the proxy.
Teodor Gorghe
08:37 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden
It fixes the non-deterministic behavior, but I think the fix isn't right. I will analyze it and come with a correct s... Teodor Gorghe
08:33 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden
Committed revision *16294* on task branch *10925a*:
- Fixed non-deterministic behavior when using temp-tables with t...
Teodor Gorghe

12/13/2025

01:45 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> BTW, the call with no concatenation
> [...]
>
> is converted as
>
> [...]
> ...
Vladimir Tsichevski
01:42 PM Bug #10973 (Review): REGRESSION: No string literal to LONGCHAR conversion for 4GL class method ca...
Vladimir Tsichevski
01:42 PM Bug #10973 (WIP): REGRESSION: No string literal to LONGCHAR conversion for 4GL class method call ...
Vladimir Tsichevski wrote:
> ...the @longchar@ constructor is applied two times to a string literal instead of one...
Vladimir Tsichevski

12/11/2025

05:11 AM Feature #3853: implement LOG-MANAGER runtime
Tomasz Domin wrote:
>
> I will push updated tests to @testcases@ project as soon as bzr update is done.
I've pu...
Tomasz Domin
04:26 AM Feature #3853: implement LOG-MANAGER runtime
Tomasz Domin wrote:
> I am almost done with fixing existing tests, just circling around some FWD-OE differences like...
Tomasz Domin

12/09/2025

01:26 PM Bug #10973: REGRESSION: No string literal to LONGCHAR conversion for 4GL class method call parame...
Vladimir Tsichevski wrote:
> This is a regression, this issue did not exist in trunk rev. 14527 when the task #7184 ...
Vladimir Tsichevski
03:02 AM Feature #9488 (Review): implement all built-in OO classes using the open source ADE code from 12.8.4
It's a bit lite, but I will put it into review, as me and Constantin talked via e-mail and I sent the files needed fo... Andrei Plugaru
07:03 PM Feature #10290 (Internal Test): Add support for character string literals options
Code Review Task Branch 10290b Revision 16305
No objections.
Greg Shah

12/08/2025

09:28 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant
Alexandru Lungu wrote:
> Artur, can you rerun the library_calls suite?
I recall having some issues running this s...
Artur Școlnic
06:37 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
Paul, I'm good with the changes. Constantin Asofiei
05:45 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
Committed rev. *16302* on branch *10935a* which contains the fix for the case described in the note above.
This c...
Paul Bodale
05:06 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
Committed rev. *16301* on branch *10935a* which fixes the process of copying table properties in case the filter is n... Paul Bodale

12/05/2025

08:29 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir Tsichevski wrote:
> That means there was a regression in trunk during the last 2 years, which is not caus...
Vladimir Tsichevski
08:16 AM Bug #10978: Conversion NPE when creating a temp-table with LIKE that uses a different primary index
I have tested with multiple cases with #10956 and this patch.
I have noticed that the change from #10247-141 are not...
Teodor Gorghe
05:52 AM Bug #10978: Conversion NPE when creating a temp-table with LIKE that uses a different primary index
Ok Teodor Gorghe
05:50 AM Bug #10978: Conversion NPE when creating a temp-table with LIKE that uses a different primary index
Teodor, please take a look. Constantin Asofiei
05:45 AM Bug #10978: Conversion NPE when creating a temp-table with LIKE that uses a different primary index
Test case:... Dănuț Filimon
05:43 AM Bug #10978 (Test): Conversion NPE when creating a temp-table with LIKE that uses a different prim...
Dănuț Filimon
07:22 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant
PS: I wonder if #10193 was actually negating the changes in #7254, so we are back with the problem from #7254. Alexandru Lungu
07:20 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant
Even if I fix this, I get another error. I think it hints that there is something broken in library_calls test-suite.... Alexandru Lungu
06:30 AM Bug #10004 (WIP): NativeInvoker fails if an argument is of type integerConstant
I tested the application that triggered #10004-1 and the error still occurs. I am looking at the latest trunk and the... Alexandru Lungu
06:02 AM Feature #10290 (Review): Add support for character string literals options
Committed rev. *16305* on branch *10290b* that fixes the case found in #10290-52. Paul Bodale
05:25 AM Feature #10290: Add support for character string literals options
The options are dropped because of the rules found in @constant_expressions.rules@
Those rules appear to be an op...
Paul Bodale
04:52 AM Feature #10290: Add support for character string literals options
Thanks for finding this out!
I am still investigating but I found that the problem comes from the fact that for th...
Paul Bodale
01:55 AM Feature #10290 (WIP): Add support for character string literals options
Paul, I think there is a little bit more work to do on this, because this testcase still fails:... Teodor Gorghe

12/04/2025

04:00 PM Bug #10973: REGRESSION: No string literal to LONGCHAR conversion for 4GL class method call parame...
This is a regression, this issue did not exist in trunk rev. 14527 when the task #7184 was worked on. Vladimir Tsichevski
03:56 PM Bug #10973: REGRESSION: No string literal to LONGCHAR conversion for 4GL class method call parame...
This issue affects the FWD conversion when passing a @CHARACTER@ literal as an argument to a class method expecting a... Vladimir Tsichevski
03:51 PM Bug #10973 (Review): REGRESSION: No string literal to LONGCHAR conversion for 4GL class method ca...
Vladimir Tsichevski
03:38 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
> BTW, the call with no concatenation
> ...
Vladimir Tsichevski
08:37 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
The revision of 7184a is too old (14527) to be rebased to the current trunk, will create 7184b to continue... Vladimir Tsichevski
04:48 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
Committed rev. *16299* on branch *10935a* which contains the solution described in #10935-10.
After committing thi...
Paul Bodale

12/03/2025

09:29 AM Feature #8138: ABLUnit configuration using environment variables
Rebased branch 8138b to trunk revision 16301. Please, review. Vladimir Tsichevski
09:22 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
I tested this on OE version 11.6 and 11.7. Paul Bodale
09:21 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
There is a problem. For the following test case:
A.cls...
Paul Bodale
02:44 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
I think we need to go the same way as variable references are resolved, via @tempIdx@:
* in SymbolResolver, add a ca...
Constantin Asofiei
02:28 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
Constantin Asofiei wrote:
> Paul, the direction is good, but the implementation needs to be rewritten to:
> * execu...
Paul Bodale
06:39 AM Bug #10961: Optimize StringBuilder usage in FWD
For long lived code, we could pre-allocate a large @StringBuffer@ instance and reuse it instead of a local instance, ... Greg Shah
06:33 AM Bug #10961: Optimize StringBuilder usage in FWD
@StringBuilder@ has a constructor which can specify the expected number of characters. It will pre-allocate the memor... Ovidiu Maxiniuc
05:21 AM Bug #10961: Optimize StringBuilder usage in FWD
The initial capacity of @StringBuilder@ is 16 characters.
When this capacity exceeds, the entire string content gets...
Teodor Gorghe
05:09 AM Bug #10961 (New): Optimize StringBuilder usage in FWD
Teodor Gorghe

12/02/2025

03:18 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
Vladimir, back to this code:
* please test direct function calls with both longchar and char parameters, with standa...
Constantin Asofiei
03:05 PM Feature #3853: implement LOG-MANAGER runtime
Vladimir Tsichevski wrote:
> > Vladimir, this was added during the initial FWD Assert implementation; what was the r...
Constantin Asofiei
03:02 PM Feature #3853: implement LOG-MANAGER runtime
> Vladimir, this was added during the initial FWD Assert implementation; what was the reason for it?
@com.goldencode...
Vladimir Tsichevski
12:20 PM Feature #3853: implement LOG-MANAGER runtime
Greg Shah wrote:
> > different class structure in OpenEdge.Core compared to FWD - In OE there is no OpenEdge.Core.Ab...
Constantin Asofiei
11:50 AM Feature #3853: implement LOG-MANAGER runtime
> There is a tests that checks all available Logging Entries - not sure if it makes sense as I guess reported values ... Greg Shah
02:54 PM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option
But, why not get the @NO-UNDO@ at the parse time and save it maybe as a special annotation, @like-no-undo@? Constantin Asofiei
02:54 PM Bug #10935 (WIP): Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table o...
Paul, the direction is good, but the implementation needs to be rewritten to:
* execute somewhere in schema phase (p...
Constantin Asofiei
03:36 AM Bug #10935 (Review): Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-tabl...
Created task branch *10935a* and committed rev. *16297* which introduces conversion changes to allow a temp-table def... Paul Bodale
01:56 PM Bug #7175 (Closed): substitute: incorrect handling of unknown longchar values
Greg Shah
01:37 PM Bug #7175 (Internal Test): substitute: incorrect handling of unknown longchar values
This issue does not exist anymore and should be closed. Vladimir Tsichevski
01:56 PM Bug #6993 (Closed): OO: incorrect field names in DataTypeEnum.java
Greg Shah
01:30 PM Bug #6993 (Internal Test): OO: incorrect field names in DataTypeEnum.java
This issue does not exist anymore: the example from #6993-10 compiles OK.
This issue can be closed.
Vladimir Tsichevski
11:36 AM Bug #9956 (Closed): Client crashes in DATE function
Hynek Cihlar
11:35 AM Bug #9956 (Internal Test): Client crashes in DATE function
Vladimir Tsichevski wrote:
> The same problem occurs is you use @SCREEN-VALUE@ attribute to set @FILL-IN@ value.
...
Vladimir Tsichevski

11/28/2025

04:06 PM Feature #3853: implement LOG-MANAGER runtime
I am almost done with fixing existing tests, just circling around some FWD-OE differences like:
* There is a tests...
Tomasz Domin
07:35 AM Bug #10597: [Regression] extent field in form fails conversion
Dănuț Filimon wrote:
> The patch is already in the trunk from the instance, I'll give it the benefit of the doubt an...
Stefanel Pezamosca
07:24 AM Bug #10597: [Regression] extent field in form fails conversion
Stefanel Pezamosca wrote:
> Dănuț Filimon wrote:
> > I ran a conversion with trunk/16293 for #10566 and the issue r...
Dănuț Filimon
07:17 AM Bug #10597: [Regression] extent field in form fails conversion
Dănuț Filimon wrote:
> I ran a conversion with trunk/16293 for #10566 and the issue remained. Stefanel, did you also...
Stefanel Pezamosca
06:48 AM Bug #10597: [Regression] extent field in form fails conversion
I ran a conversion with trunk/16293 for #10566 and the issue remained. Stefanel, did you also test the scenario using... Dănuț Filimon
 

Also available in: Atom