Activity
From 11/12/2012 to 12/11/2012
12/11/2012
- 04:44 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- I have attached SQL Functions I am going to test now. Sorry, there are no proper comments and formatting just because...
- 12:05 PM Feature #1910: add schema conversion support for sequences
- Ovidiu Maxiniuc wrote:
> The @_seqvals.d@ is indeed the default filename for exported sequence values. I documented ... - 11:29 AM Feature #1910: add schema conversion support for sequences
- Changes in today's update:
* @src@ directory structure fixed
* @dbimport@ replaced @seqimp@
* fixed indentation/al...
12/10/2012
- 02:34 PM Feature #1580: upgrade Hibernate to latest level
- About "Found two representations"-related issues:
1. In the first issue ("crossReferenceItem already exists with") p... - 02:19 PM Feature #1910: add schema conversion support for sequences
- After you finish with the code changes resulting from the above code reviews, please review all places in the P2J Con...
- 02:12 PM Feature #1910: add schema conversion support for sequences
- Code review 1210b:
* Nice work! I'm excited to give this a test run with a real database.
* Is _seqvals.d a hard... - 01:38 PM Feature #1910 (WIP): add schema conversion support for sequences
- 01:38 PM Feature #1910: add schema conversion support for sequences
- Code review 1210a:
Please note that the following files in your zip file:... - 11:11 AM Feature #1910 (Review): add schema conversion support for sequences
- Added sequence current value import
- 06:59 AM Feature #1910: add schema conversion support for sequences
- Moved the generation of sequence ddl from .schema to .p2o file.
- 11:37 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Vadim Nebogatov wrote:
> The arguments passed to SQLFunction are strings; we can parse them separately to Ast tree l...
12/08/2012
- 01:40 AM Feature #1580: upgrade Hibernate to latest level
- > Yes, this needs to be fixed, but I'm not sure what the issue is here. In build.xml, we copy the ehcache configurat...
12/07/2012
- 05:26 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- The arguments passed to SQLFunction are strings; we can parse them separately to Ast tree like method parse() does:
... - 12:50 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Vadim Nebogatov wrote:
> I tried to find out also how to simplify first approach for constant expressions and for no... - 02:48 PM Feature #1581: add conversion and runtime support for certain metadata constructs
- Discussed with Greg. Probably the best approach is to use an embedded H2 database to provide access to these metadat...
- 01:54 PM Feature #1583: add conversion and runtime support for the INSERT language statement
- Code looks good, but I should not have suggested that this go into post-parse fixups. This is too early, and it will...
- 01:01 PM Feature #1580: upgrade Hibernate to latest level
- Stanislav Lomany wrote:
> 6. "(net.sf.ehcache.config.ConfigurationFactory:WARNING) No configuration found. Configuri... - 12:29 AM Feature #1580: upgrade Hibernate to latest level
- I'm not so sure this behavior is about an unstable release. But I think you are right that the select statement is p...
12/06/2012
- 10:28 AM Feature #1910: add schema conversion support for sequences
- Please make this issue your highest priority (including the import of current sequence values). We need to deliver a ...
- 10:23 AM Feature #1910: add schema conversion support for sequences
- Taking into consideration that the rules are more or less the same, a couple of hours should be enough to move the so...
- 09:53 AM Feature #1910: add schema conversion support for sequences
- I'm sorry, but in my review of your initial updates, I didn't notice that you were generating the sequence DDL from t...
- 02:35 AM Feature #1910: add schema conversion support for sequences
- I observed yesterday that the converted data dictionary file .p2o does not contains any reference to the sequence. Th...
- 08:57 AM Feature #1580: upgrade Hibernate to latest level
- About "Found two representations". After I've inserted the following code right after deletion of the target item the...
- 02:09 AM Feature #1580: upgrade Hibernate to latest level
- > Good work on finding a reliable recreate. Please open a new bug issue in the database project for this error, but ...
12/05/2012
- 04:20 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- I also think it is hard to predict now how will SQLFunction approch affect caching and performance. I hope not very m...
- 02:39 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- As far as when to do it, I would say to do a quick and dirty test soon if possible. You want to know now if there is...
- 02:00 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- AFAIK, we have not done any work to determine the potential performance penalty.
We will have to look at some typi... - 01:28 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Eric: my questions were not related to the potential worry that you have about performance issues. I was fully aware...
- 02:15 PM Feature #1580: upgrade Hibernate to latest level
- Good work on finding a reliable recreate. Please open a new bug issue in the database project for this error, but do...
- 10:57 AM Feature #1580: upgrade Hibernate to latest level
- About...
- 11:51 AM Feature #1911: add runtime support for sequences
- I spoke with Greg about this and he suggested a much more efficient (and simpler) solution:
Add flags to the direc...
12/04/2012
- 06:05 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Investigation SQLFunctions processing in Hibernate&Antlr source code. SqlGenerator invokes SQLFunction.render() metho...
- 12:29 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Greg Shah wrote:
> Did I miss this?
Apparently, yes, you missed the post (# 49) where I voiced my concern about p... - 12:14 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Greg Shah wrote:
> I didn't realize that we already had eq and ne. When are they used? I previously thought that w... - 08:23 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Did I miss this? Is there a performance penalty to using the SQLFunction approach?
Also, what is the performance ... - 08:22 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- equals and not_equals seem fine to me.
I didn't realize that we already had eq and ne. When are they used? I pre... - 12:23 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Eric Faulhaber wrote:
> ...or even @eq@ and @neq@?
I just remembered @eq@ and @ne@ already are user defined funct... - 12:13 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- OK, it appears you have determined the SQLFunction approach is feasible. Let's go with it and see how it performs. ...
- 01:43 AM Feature #1911: add runtime support for sequences
- The implementation a service thread for handling sequence primitives (current/next/set) like this:
- the current val...
12/03/2012
- 04:54 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Concerning Example 3:
I tested with H2 database: for case f1=true, f2=true expression
(tt.f1 != true and tt.f2... - 01:23 PM Feature #1580: upgrade Hibernate to latest level
- OK, it sounds like caching the Hibernation Configuration objects by schema is no longer a safe thing to do with this ...
- 01:05 PM Feature #1580: upgrade Hibernate to latest level
- > What "type" resource was scoped to one SessionFactory that is now being scoped to another? In other words, what re...
- 12:06 PM Feature #1580: upgrade Hibernate to latest level
- Stanislav Lomany wrote:
> ... - 09:44 AM Feature #1580: upgrade Hibernate to latest level
- >The root cause might be because the ConnectionManager.local.cleanup is executed before the Persistence.Context.clean...
- 08:56 AM Feature #1580: upgrade Hibernate to latest level
- > 3. "error closing Hibernate session" is caused by fact that the session with a remote database is closed on applica...
- 05:57 AM Feature #1580: upgrade Hibernate to latest level
- Warning that appears when multiple servers are executed on the same machine:...
- 05:53 AM Feature #1580: upgrade Hibernate to latest level
- 1....
12/02/2012
- 06:21 AM Feature #1580: upgrade Hibernate to latest level
- The following issue:...
11/29/2012
- 04:24 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- SQLFunctionTemplate does not allow repeating parameters, but direct implementation of SQLFunction interface seems res...
- 04:20 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- SQLFunction approach (SQLFunctions are already in Hibernate v3.0.5).
I have added
registerFunction("p2j... - 05:35 AM Feature #1580: upgrade Hibernate to latest level
- > When those first warnings appear in the log, is it just the messages themselves, or is there any associated stack t...
- 10:30 PM Feature #1580: upgrade Hibernate to latest level
- When those first warnings appear in the log, is it just the messages themselves, or is there any associated stack tra...
- 11:25 PM Feature #1582: add conversion and runtime support for sequences
- Some additional code review comments for the 1123a drop:
* How is CustomSequence to be used? AFAIK, Progress sequ... - 10:40 PM Feature #1911: add runtime support for sequences
- If we need transaction processing separate from the current (application-defined) database transaction, it sounds lik...
11/28/2012
- 03:33 PM Feature #1580: upgrade Hibernate to latest level
- I looked at the original log carefully and now we have reproduction:
V-C-select RFQ-Enter (RFQ server should be runn... - 10:26 AM Feature #1580: upgrade Hibernate to latest level
- Stas, my conclusion about this being a threading issue was based on some cursory Internet research. Please dig into ...
- 06:09 AM Feature #1580: upgrade Hibernate to latest level
- Stanislav,
From the org.hibernate.Session javadoc (http://docs.jboss.org/hibernate/orm/4.1/javadocs/org/hibernate/Se... - 05:54 AM Feature #1580: upgrade Hibernate to latest level
- A session CAN be closed in another thread:...
- 11:06 AM Feature #1911: add runtime support for sequences
- An issue related to PSQL, but not only:
On a finite, non cycling sequences, calling @nextVal@ will return an error... - 04:18 AM Feature #1583 (Review): add conversion and runtime support for the INSERT language statement
- 04:18 AM Feature #1583 (WIP): add conversion and runtime support for the INSERT language statement
- 04:15 AM Feature #1583: add conversion and runtime support for the INSERT language statement
- I first tested if the sequence of CREATE/UPDATE has the same effect like @INSERT@. My fear was that if user skips the...
11/27/2012
- 06:32 PM Feature #1580: upgrade Hibernate to latest level
- Eric Faulhaber wrote:
> ... Although I haven't looked at the latest Hibernate source, I suspect Hibernate is using a... - 06:21 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Please explain your SQLFunction idea more fully. It is intriguing.
I think this is a relatively new feature in Hi... - 06:03 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- How to proceed with this task?..
- 04:57 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- One more option is providing a custom comparing functions (org.hibernate.dialect.function.SQLFunction) registered wit...
11/26/2012
- 06:22 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- I agreed absolutely. But it seems there is no choice if you want to fix this issue on the HQL level.
My draft idea ... - 12:05 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Vadim Nebogatov wrote:
> > I don't remember this being a supported operator in HQL.
> What operator did you mean? H... - 12:59 PM Feature #1666: add support for mixed-direction indexes
- I use PostgreSQL 9.1 (not the latest available version but what I have installed) to test this issue. Also I have a p...
- 12:26 PM Feature #1926: create an en_GB@p2j_basic locale definition
- Model this after locale/en_US@p2j_basic, customizing LC_CTYPE and LC_COLLATE sections. Use en_GB as a basis instead ...
- 12:22 PM Feature #1926 (Hold): create an en_GB@p2j_basic locale definition
11/25/2012
- 04:56 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Yes, you are correct, I did not notice that issue concerns NHibernate, but all others I wrote about Hibernate.
CA... - 02:04 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Vadim Nebogatov wrote:
> IS [NOT] DISTINCT FROM predicate is not supported with Hibernate and it seems they even do ... - 12:25 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- IS [NOT] DISTINCT FROM predicate is not supported with Hibernate and it seems they even do not plan to support it:
...
11/24/2012
- 05:00 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Vadim Nebogatov wrote:
> What about limitations for SQL statement length which some databases have? Resulting SQL st... - 03:30 PM Feature #1911 (WIP): add runtime support for sequences
- 03:25 PM Feature #1666: add support for mixed-direction indexes
- Highest priority sub-tasks of this issue should be:
# to fix the creation of indexes during the data import proces...
11/23/2012
- 06:01 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Yes, I understand this. Converted code will be not affected in this case, HQLAst and parameter list changes should be...
- 05:53 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- I'll let Eric comment on all the other good information and questions you have posed.
The only thing I want to mak... - 05:34 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- What about limitations for SQL statement length which some databases have? Resulting SQL statement could be very heavy.
- 05:15 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- I have found out that not only inequality should be replaced but equality also work incorrectly in some cases.
Very ... - 01:26 PM Feature #1582 (WIP): add conversion and runtime support for sequences
- I have reviewed the progress.g changes. They are fine. My only request is for you to please change the ending copyr...
- 12:04 PM Feature #1582: add conversion and runtime support for sequences
- My answers/comments to your questions:
* There is no separate ddl file generated for sequences. Only the xml that ge... - 01:03 AM Feature #1582: add conversion and runtime support for sequences
- I have done only a very high-level review of the update so far, and it looks like you've addressed all the necessary ...
- 08:32 AM Feature #1580: upgrade Hibernate to latest level
- I don't like putting a Hibernate-specific hack into our more generic implementation.
Let's back up a bit. In what...
11/22/2012
- 03:04 PM Feature #1580: upgrade Hibernate to latest level
- Eric, at 3 I'm not saying that is not feasible; as only Conversation threads can create hibernate Sessions, at a firs...
- 01:16 PM Feature #1580: upgrade Hibernate to latest level
- Regarding points 1 & 2 in the previous post: currently, there is no creation of Hibernate Session objects on anythin...
- 11:42 AM Feature #1580: upgrade Hibernate to latest level
- Thoughts about context cleanup:
# If the we decide to clean the Hibernate session on the Conversion thread, then we ... - 11:02 AM Feature #1580: upgrade Hibernate to latest level
- The Hibernate Session objects are created on the conversation thread (for that matter, all persistence runtime code o...
- 09:52 AM Feature #1580: upgrade Hibernate to latest level
- I don't think it is as simple as you suggest. By its nature, all contexts are accessed from multiple threads. At a ...
- 12:56 AM Feature #1580: upgrade Hibernate to latest level
- Regarding the error......
- 12:35 AM Feature #1580: upgrade Hibernate to latest level
- Eric Faulhaber wrote:
> How common was the
>
> [...]
>
> error in the regression server log? This looks a lot... - 12:28 AM Feature #1580: upgrade Hibernate to latest level
- How common was the...
- 11:01 AM Feature #1582: add conversion and runtime support for sequences
- Uploaded update patch that covers both conversion and runtime sub-tasks (1910 and 1911).
- 09:17 AM Feature #1583: add conversion and runtime support for the INSERT language statement
- Yes, I agree completely. So far we have almost never seen this statement used in practice. It is an interesting com...
- 12:17 AM Feature #1583: add conversion and runtime support for the INSERT language statement
- Greg,
There are only 4 uses of this statement across both projects (all in the server project), and they are all o... - 06:17 AM Feature #1911: add runtime support for sequences
- I discovered a way to access the current value in PostgreSQL without calling @CURRVAL@ which fails if it's called bef...
- 12:21 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Yes, I agree, let's put it in the HQLPreprocessor.
11/21/2012
- 12:58 PM Feature #1580: upgrade Hibernate to latest level
- Modification of LogicalUserType completely solves the problem (unless regression testing will show a surprise). Other...
- 12:11 PM Feature #1580: upgrade Hibernate to latest level
- Stanislav Lomany wrote:
> 4. Possible work around: use quotes for boolean literals: 'true' and 'false'
> 5. I don't... - 10:23 AM Feature #1580: upgrade Hibernate to latest level
- About boolean literals:
1. The bug/feature is related only to the fields of the P2J LogicalUserType (and any other c... - 09:48 AM Feature #1911: add runtime support for sequences
- Here are the result about MS SQL server. I used the free 2012 EXPRESS version with SP1, but I believe that there are ...
11/20/2012
- 11:20 AM Feature #1911: add runtime support for sequences
- 1. There is no problem for Progress/OE having a simple code like:...
- 10:53 AM Feature #1911: add runtime support for sequences
- Please also research sequences in MS SQL Server, which we have to support for this project.
- 10:38 AM Feature #1911: add runtime support for sequences
- Ovidiu Maxiniuc wrote:
> [...]
>
> *PostgreSQL*
> * offers full support for sequences (min and max values, varia... - 08:21 AM Feature #1911: add runtime support for sequences
- I have done some investigations and here is what I found out:
The Hibernate @Dialect@ base class defines the followi... - 07:52 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- This should not be exploded into the code. It should be hidden in the HQL preprocessor.
There is even a good reas...
11/19/2012
- 05:45 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- In common case 4GL inequality expression in WHERE clause
exp1!=exp2
should be replaced with
(exp1 is null and e... - 09:41 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Vadim Nebogatov wrote:
> Problem found. In common case is that not enough to change
>
> expr1 != expr2
>
> to
... - 05:39 PM Feature #1910: add schema conversion support for sequences
- So far the discussion has centered around the conversion of business logic references to sequences, but the highest p...
- 01:33 PM Feature #1910: add schema conversion support for sequences
- From progress.g:...
- 11:43 AM Feature #1910: add schema conversion support for sequences
- The key point here is that the assignment style statements should already be working without duplicating the assignme...
- 11:40 AM Feature #1910: add schema conversion support for sequences
- ...
- 10:54 AM Feature #1910: add schema conversion support for sequences
- I can now confirm that the statements also need "EQUALS! expr" at the end. Indeed, the syntax is stupid, but the antl...
- 10:53 AM Feature #1910: add schema conversion support for sequences
- What do you mean?
At this moment, the P2J work just fine, .p file is correctly converted.
Keeping @sequence_funcs@ ... - 10:14 AM Feature #1910: add schema conversion support for sequences
- OK, that explains things. When I added support for those, I had no way to test if the unquoted names could be used i...
- 10:02 AM Feature #1910: add schema conversion support for sequences
- As far as I can see, they are already there:...
- 09:54 AM Feature #1910: add schema conversion support for sequences
- We have not yet written the backing class for the 64-bit integer. It will be called int64 when it is written. But t...
- 09:48 AM Feature #1910: add schema conversion support for sequences
- The answer for 2nd question for now:
I am positive that DYNAMIC- forms require exactly 2 character parameters. This ... - 09:27 AM Feature #1910: add schema conversion support for sequences
- Questions:...
- 02:04 AM Feature #1910: add schema conversion support for sequences
- I created the new @com.goldencode.p2j.util.Sequence@ class with the appropriate methods declarations.
However, the P... - 09:38 AM Feature #1580: upgrade Hibernate to latest level
- Have you removed all the old versions of the Hibernate jar and its dependencies from the project and from the p2j.mf ...
- 05:09 AM Feature #1580: upgrade Hibernate to latest level
- I have some troubles with Hibernate. I have the small project to deal with different versions of Hibernate and while ...
11/18/2012
- 05:42 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- We can only use constructs that can be expressed in HQL and which are supported across all major databases (e.g., Ora...
11/17/2012
- 04:26 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Variant with changes in QUERY_SUBST is investigated. It is also possible solution but not very easy because QUERY_SU...
11/16/2012
- 05:40 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Problem found. In common case is that not enough to change
expr1 != expr2
to
expr1 is null and expr2 is not ... - 11:57 AM Feature #1910: add schema conversion support for sequences
- Please show the changes you have had to make. I am especially interested in the progress.g changes, but show everyth...
- 11:35 AM Feature #1910 (WIP): add schema conversion support for sequences
- 07:45 AM Feature #1580: upgrade Hibernate to latest level
- Stanislav Lomany wrote:
> Interesting thing about boolean literals issue is that it presents in the latest Hibernate... - 07:12 AM Feature #1580: upgrade Hibernate to latest level
- Boolean literals can be fixed by the following changes in org.hibernate.hql.internal.ast.tree.BooleanLiteralNode:
<p...
11/15/2012
- 06:04 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Based on idea above, new rule and function "replaceInequalityNode" are added. Function seems is not optimal, I think...
- 05:09 PM Feature #1580: upgrade Hibernate to latest level
- So, what are your thoughts about how we address these 3 errors?
Also, thoughts on the deprecated, positional param... - 03:10 PM Feature #1580: upgrade Hibernate to latest level
- Interesting thing about boolean literals issue is that it presents in the latest Hibernate release (at first I though...
- 07:09 AM Feature #1580: upgrade Hibernate to latest level
- As far as I've analyzed the regression testing log (it is 500M), there are three types of errors:
1. Boolean literal... - 09:50 AM Feature #1582: add conversion and runtime support for sequences
- Ovidiu Maxiniuc wrote:
> ... I believe P2J implementation will focus on OE10.x at the moment so the P2J implementati... - 07:53 AM Feature #1582: add conversion and runtime support for sequences
- Seems like the OpenEdge version installed on windev01 is only at version 10.2 and does not support the new extra para...
- 05:26 AM Feature #1582: add conversion and runtime support for sequences
- At first attempt to read about and prepare the dynamic forms testcases I could not find them in Progress Reference do...
11/13/2012
- 12:03 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- I put aside all above and started with a fresh new idea. Please correct me if I'm wrong.
P2J is informed about cha... - 11:40 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- This is an interesting idea, but it is pretty intrusive in the DMOs. Let's go with your first approach, limiting the...
- 10:11 AM Feature #1580: upgrade Hibernate to latest level
- It seems like using JPA-style positional parameters (?1, ?2, ?3, ...) would be much easier than changing conversion o...
- 08:37 AM Feature #1580: upgrade Hibernate to latest level
- Log file is full of this kind of warnings:...
11/12/2012
- 11:54 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- Indeed, the @snapshot@ seems to be used for a similar reason, but I see it's only used for undo-s, it only stores ses...
- 10:46 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- Please review the use of the @snapshot@ instance variable in @RecordBuffer@. Can this variable (i.e., when it is a d...
- 09:25 AM Feature #1911: add runtime support for sequences
- See parent issue for requirements.
Runtime implementations of the statement/functions should leverage dialect infr... - 09:21 AM Feature #1910 (New): add schema conversion support for sequences
- See parent issue for description of what must be converted.
The statements in the schema export (.df) file must be...
Also available in: Atom