Project

General

Profile

Activity

From 11/25/2012 to 12/24/2012

12/21/2012

12:54 PM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
I still need to review customer reports to determine actual scenarios, but please start with some basic use cases. Eric Faulhaber
12:35 PM Feature #1910: add schema conversion support for sequences
I have merged the 1214a update with my local changes and tested a real-world database import with sequences. I found... Eric Faulhaber
12:19 PM Feature #1663: test/debug case-sensitive field support
This task is about defining temporary and permanent database tables with a mix of case-sensitive and case-insensitive... Eric Faulhaber
09:40 AM Feature #1580: upgrade Hibernate to latest level
OK, let's try it. Can you think of an easy (generic) way to determine when an entity has a collection, or do you pro... Eric Faulhaber
04:41 AM Feature #1580: upgrade Hibernate to latest level
Eric, the snippet represents the process of deletion and the following rollback of an entity in P2J (during rollback ... Stanislav Lomany

12/20/2012

06:28 PM Feature #1910: add schema conversion support for sequences
Code review 1214a:
Is the version of SequenceManager.java in this update the correct one? It doesn't compile. Fi...
Eric Faulhaber
05:28 PM Feature #1580: upgrade Hibernate to latest level
PS: see the stacktrace in the #1566 bug. Constantin Asofiei
05:26 PM Feature #1580: upgrade Hibernate to latest level
Stas/Eric, just a thought: do you see the "Found two representations of same collection" issue any way related to the... Constantin Asofiei
05:07 PM Feature #1580: upgrade Hibernate to latest level
Sorry, I don't understand what your workaround example is trying to accomplish. What use case in P2J does this repre... Eric Faulhaber
06:23 AM Feature #1580: upgrade Hibernate to latest level
In order to reproduce the "Found two representations of same collection" issue the following Hibernate command sequen... Stanislav Lomany
08:45 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
The keyword is specified in the schema (.df file) as an option on a field:... Greg Shah

12/19/2012

05:59 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I read about this option, but I found no examples of it's using. Maybe it depends on 4GL version?
Syntax like
.....
Vadim Nebogatov
04:35 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Progress uses the keyword MANDATORY to denote a non-nullable field.
Thanks,
Eric
Vadim Nebogatov
04:34 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Reading and investigation of Progress 4GL documentation as regards not-nullable fields. I did not find any field opti... Vadim Nebogatov

12/18/2012

05:50 PM Feature #1926: create an en_GB@p2j_basic locale definition
Here is the information screen for the @<db_name>@ database on windev01 from the Data Administration --> Utilities --... Eric Faulhaber
12:47 PM Feature #1580: upgrade Hibernate to latest level
1. Found two representations of same collection -- a day, may be two to find the cause and make a solution
2. Sessio...
Stanislav Lomany
11:39 AM Feature #1580: upgrade Hibernate to latest level
Please summarize the current status of all known issues with this task and estimate (if you can) how much effort you ... Eric Faulhaber

12/17/2012

06:02 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Variant above does not require aliases mapping because argument type is calculated in HQLPreprocessor.
I made one m...
Vadim Nebogatov
08:23 AM Feature #1580: upgrade Hibernate to latest level
Testcase for the "Found two representations of same collection" issue:... Stanislav Lomany

12/15/2012

05:21 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Approach described above is implemented, it works and on testing now.
But I have found one more problem.
If where...
Vadim Nebogatov

12/14/2012

01:49 PM Feature #1580: upgrade Hibernate to latest level
> Did this behavior change from 3.0.5?
Yes, 3.0.5 just checks if there is the entity in the persistence context (reg...
Stanislav Lomany
01:13 PM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> The "crossReferenceItem already exists with" issue is about Session.contains function. In ...
Eric Faulhaber
06:42 AM Feature #1580: upgrade Hibernate to latest level
The "crossReferenceItem already exists with" issue is about Session.contains function. In Hibernate 4 it returns FALS... Stanislav Lomany
01:46 PM Feature #1911: add runtime support for sequences
Ovidiu Maxiniuc wrote:
> ...The fact is, this is the exact way PostgreSQL handles sequences and this should be a goo...
Eric Faulhaber
11:21 AM Feature #1911: add runtime support for sequences
I have discovered something at least interesting today. The Progress/4GL 9 and OpenEdge/ABL 11 Reference books, both ... Ovidiu Maxiniuc
12:15 PM Feature #1910: add schema conversion support for sequences
As I created a new test case file for sequences I discovered that the @Sequencemanager.setValue()@ set of overloaded ... Ovidiu Maxiniuc
07:25 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I understood the reason of problem with nested SQL Functions invocation (NPE on parsing SQL Function argument time): ... Vadim Nebogatov

12/13/2012

12:21 PM Feature #1926: create an en_GB@p2j_basic locale definition
I have done a first cut of this as described above, but I'm pretty sure it's not quite right yet.
I exported the c...
Eric Faulhaber

12/12/2012

05:11 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Some tests are attached and passed as expected.
Now I am working with tests containing nested sql functions - not a...
Vadim Nebogatov

12/11/2012

04:44 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I have attached SQL Functions I am going to test now. Sorry, there are no proper comments and formatting just because... Vadim Nebogatov
12:05 PM Feature #1910: add schema conversion support for sequences
Ovidiu Maxiniuc wrote:
> The @_seqvals.d@ is indeed the default filename for exported sequence values. I documented ...
Eric Faulhaber
11:29 AM Feature #1910: add schema conversion support for sequences
Changes in today's update:
* @src@ directory structure fixed
* @dbimport@ replaced @seqimp@
* fixed indentation/al...
Ovidiu Maxiniuc

12/10/2012

02:34 PM Feature #1580: upgrade Hibernate to latest level
About "Found two representations"-related issues:
1. In the first issue ("crossReferenceItem already exists with") p...
Stanislav Lomany
02:19 PM Feature #1910: add schema conversion support for sequences
After you finish with the code changes resulting from the above code reviews, please review all places in the P2J Con... Eric Faulhaber
02:12 PM Feature #1910: add schema conversion support for sequences
Code review 1210b:
* Nice work! I'm excited to give this a test run with a real database.
* Is _seqvals.d a hard...
Eric Faulhaber
01:38 PM Feature #1910 (WIP): add schema conversion support for sequences
Eric Faulhaber
01:38 PM Feature #1910: add schema conversion support for sequences
Code review 1210a:
Please note that the following files in your zip file:...
Eric Faulhaber
11:11 AM Feature #1910 (Review): add schema conversion support for sequences
Added sequence current value import Ovidiu Maxiniuc
06:59 AM Feature #1910: add schema conversion support for sequences
Moved the generation of sequence ddl from .schema to .p2o file. Ovidiu Maxiniuc
11:37 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Vadim Nebogatov wrote:
> The arguments passed to SQLFunction are strings; we can parse them separately to Ast tree l...
Eric Faulhaber

12/08/2012

01:40 AM Feature #1580: upgrade Hibernate to latest level
> Yes, this needs to be fixed, but I'm not sure what the issue is here. In build.xml, we copy the ehcache configurat... Stanislav Lomany

12/07/2012

05:26 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
The arguments passed to SQLFunction are strings; we can parse them separately to Ast tree like method parse() does:
...
Vadim Nebogatov
12:50 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Vadim Nebogatov wrote:
> I tried to find out also how to simplify first approach for constant expressions and for no...
Eric Faulhaber
02:48 PM Feature #1581: add conversion and runtime support for certain metadata constructs
Discussed with Greg. Probably the best approach is to use an embedded H2 database to provide access to these metadat... Eric Faulhaber
01:54 PM Feature #1583: add conversion and runtime support for the INSERT language statement
Code looks good, but I should not have suggested that this go into post-parse fixups. This is too early, and it will... Eric Faulhaber
01:01 PM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> 6. "(net.sf.ehcache.config.ConfigurationFactory:WARNING) No configuration found. Configuri...
Eric Faulhaber
12:29 AM Feature #1580: upgrade Hibernate to latest level
I'm not so sure this behavior is about an unstable release. But I think you are right that the select statement is p... Eric Faulhaber

12/06/2012

10:28 AM Feature #1910: add schema conversion support for sequences
Please make this issue your highest priority (including the import of current sequence values). We need to deliver a ... Eric Faulhaber
10:23 AM Feature #1910: add schema conversion support for sequences
Taking into consideration that the rules are more or less the same, a couple of hours should be enough to move the so... Ovidiu Maxiniuc
09:53 AM Feature #1910: add schema conversion support for sequences
I'm sorry, but in my review of your initial updates, I didn't notice that you were generating the sequence DDL from t... Eric Faulhaber
02:35 AM Feature #1910: add schema conversion support for sequences
I observed yesterday that the converted data dictionary file .p2o does not contains any reference to the sequence. Th... Ovidiu Maxiniuc
08:57 AM Feature #1580: upgrade Hibernate to latest level
About "Found two representations". After I've inserted the following code right after deletion of the target item the... Stanislav Lomany
02:09 AM Feature #1580: upgrade Hibernate to latest level
> Good work on finding a reliable recreate. Please open a new bug issue in the database project for this error, but ... Stanislav Lomany

12/05/2012

04:20 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I also think it is hard to predict now how will SQLFunction approch affect caching and performance. I hope not very m... Vadim Nebogatov
02:39 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
As far as when to do it, I would say to do a quick and dirty test soon if possible. You want to know now if there is... Greg Shah
02:00 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
AFAIK, we have not done any work to determine the potential performance penalty.
We will have to look at some typi...
Eric Faulhaber
01:28 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Eric: my questions were not related to the potential worry that you have about performance issues. I was fully aware... Greg Shah
02:15 PM Feature #1580: upgrade Hibernate to latest level
Good work on finding a reliable recreate. Please open a new bug issue in the database project for this error, but do... Eric Faulhaber
10:57 AM Feature #1580: upgrade Hibernate to latest level
About... Stanislav Lomany
11:51 AM Feature #1911: add runtime support for sequences
I spoke with Greg about this and he suggested a much more efficient (and simpler) solution:
Add flags to the direc...
Eric Faulhaber

12/04/2012

06:05 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Investigation SQLFunctions processing in Hibernate&Antlr source code. SqlGenerator invokes SQLFunction.render() metho... Vadim Nebogatov
12:29 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Greg Shah wrote:
> Did I miss this?
Apparently, yes, you missed the post (# 49) where I voiced my concern about p...
Eric Faulhaber
12:14 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Greg Shah wrote:
> I didn't realize that we already had eq and ne. When are they used? I previously thought that w...
Eric Faulhaber
08:23 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Did I miss this? Is there a performance penalty to using the SQLFunction approach?
Also, what is the performance ...
Greg Shah
08:22 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
equals and not_equals seem fine to me.
I didn't realize that we already had eq and ne. When are they used? I pre...
Greg Shah
12:23 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Eric Faulhaber wrote:
> ...or even @eq@ and @neq@?
I just remembered @eq@ and @ne@ already are user defined funct...
Eric Faulhaber
12:13 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
OK, it appears you have determined the SQLFunction approach is feasible. Let's go with it and see how it performs. ... Eric Faulhaber
01:43 AM Feature #1911: add runtime support for sequences
The implementation a service thread for handling sequence primitives (current/next/set) like this:
- the current val...
Ovidiu Maxiniuc

12/03/2012

04:54 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Concerning Example 3:
I tested with H2 database: for case f1=true, f2=true expression
(tt.f1 != true and tt.f2...
Vadim Nebogatov
01:23 PM Feature #1580: upgrade Hibernate to latest level
OK, it sounds like caching the Hibernation Configuration objects by schema is no longer a safe thing to do with this ... Eric Faulhaber
01:05 PM Feature #1580: upgrade Hibernate to latest level
> What "type" resource was scoped to one SessionFactory that is now being scoped to another? In other words, what re... Stanislav Lomany
12:06 PM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> ...
Eric Faulhaber
09:44 AM Feature #1580: upgrade Hibernate to latest level
>The root cause might be because the ConnectionManager.local.cleanup is executed before the Persistence.Context.clean... Stanislav Lomany
08:56 AM Feature #1580: upgrade Hibernate to latest level
> 3. "error closing Hibernate session" is caused by fact that the session with a remote database is closed on applica... Constantin Asofiei
05:57 AM Feature #1580: upgrade Hibernate to latest level
Warning that appears when multiple servers are executed on the same machine:... Stanislav Lomany
05:53 AM Feature #1580: upgrade Hibernate to latest level
1.... Stanislav Lomany

12/02/2012

06:21 AM Feature #1580: upgrade Hibernate to latest level
The following issue:... Stanislav Lomany

11/29/2012

04:24 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
SQLFunctionTemplate does not allow repeating parameters, but direct implementation of SQLFunction interface seems res... Vadim Nebogatov
04:20 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
SQLFunction approach (SQLFunctions are already in Hibernate v3.0.5).
I have added
registerFunction("p2j...
Vadim Nebogatov
05:35 AM Feature #1580: upgrade Hibernate to latest level
> When those first warnings appear in the log, is it just the messages themselves, or is there any associated stack t... Stanislav Lomany
10:30 PM Feature #1580: upgrade Hibernate to latest level
When those first warnings appear in the log, is it just the messages themselves, or is there any associated stack tra... Eric Faulhaber
11:25 PM Feature #1582: add conversion and runtime support for sequences
Some additional code review comments for the 1123a drop:
* How is CustomSequence to be used? AFAIK, Progress sequ...
Eric Faulhaber
10:40 PM Feature #1911: add runtime support for sequences
If we need transaction processing separate from the current (application-defined) database transaction, it sounds lik... Eric Faulhaber

11/28/2012

03:33 PM Feature #1580: upgrade Hibernate to latest level
I looked at the original log carefully and now we have reproduction:
V-C-select RFQ-Enter (RFQ server should be runn...
Stanislav Lomany
10:26 AM Feature #1580: upgrade Hibernate to latest level
Stas, my conclusion about this being a threading issue was based on some cursory Internet research. Please dig into ... Eric Faulhaber
06:09 AM Feature #1580: upgrade Hibernate to latest level
Stanislav,
From the org.hibernate.Session javadoc (http://docs.jboss.org/hibernate/orm/4.1/javadocs/org/hibernate/Se...
Constantin Asofiei
05:54 AM Feature #1580: upgrade Hibernate to latest level
A session CAN be closed in another thread:... Stanislav Lomany
11:06 AM Feature #1911: add runtime support for sequences
An issue related to PSQL, but not only:
On a finite, non cycling sequences, calling @nextVal@ will return an error...
Ovidiu Maxiniuc
04:18 AM Feature #1583 (Review): add conversion and runtime support for the INSERT language statement
Ovidiu Maxiniuc
04:18 AM Feature #1583 (WIP): add conversion and runtime support for the INSERT language statement
Ovidiu Maxiniuc
04:15 AM Feature #1583: add conversion and runtime support for the INSERT language statement
I first tested if the sequence of CREATE/UPDATE has the same effect like @INSERT@. My fear was that if user skips the... Ovidiu Maxiniuc

11/27/2012

06:32 PM Feature #1580: upgrade Hibernate to latest level
Eric Faulhaber wrote:
> ... Although I haven't looked at the latest Hibernate source, I suspect Hibernate is using a...
Eric Faulhaber
06:21 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Please explain your SQLFunction idea more fully. It is intriguing.
I think this is a relatively new feature in Hi...
Eric Faulhaber
06:03 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
How to proceed with this task?.. Vadim Nebogatov
04:57 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
One more option is providing a custom comparing functions (org.hibernate.dialect.function.SQLFunction) registered wit... Vadim Nebogatov

11/26/2012

06:22 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I agreed absolutely. But it seems there is no choice if you want to fix this issue on the HQL level.
My draft idea ...
Vadim Nebogatov
12:05 AM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Vadim Nebogatov wrote:
> > I don't remember this being a supported operator in HQL.
> What operator did you mean? H...
Eric Faulhaber
12:59 PM Feature #1666: add support for mixed-direction indexes
I use PostgreSQL 9.1 (not the latest available version but what I have installed) to test this issue. Also I have a p... Ovidiu Maxiniuc
12:26 PM Feature #1926: create an en_GB@p2j_basic locale definition
Model this after locale/en_US@p2j_basic, customizing LC_CTYPE and LC_COLLATE sections. Use en_GB as a basis instead ... Eric Faulhaber
12:22 PM Feature #1926 (Hold): create an en_GB@p2j_basic locale definition
Eric Faulhaber

11/25/2012

04:56 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Yes, you are correct, I did not notice that issue concerns NHibernate, but all others I wrote about Hibernate.
CA...
Vadim Nebogatov
02:04 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Vadim Nebogatov wrote:
> IS [NOT] DISTINCT FROM predicate is not supported with Hibernate and it seems they even do ...
Eric Faulhaber
12:25 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
IS [NOT] DISTINCT FROM predicate is not supported with Hibernate and it seems they even do not plan to support it:
...
Vadim Nebogatov
 

Also available in: Atom