Project

General

Profile

Activity

From 08/22/2013 to 09/20/2013

09/20/2013

07:59 PM Bug #2164: Server fails to start a Progress app when persistence disabled
The changes passed regression test, see shared\clients\timco\majic_test_results\10382_9c2ae9a_20130920_hc.zip.
Fixed...
Hynek Cihlar
04:04 PM Feature #2141: generate SQL Server schema
Another problem I have found out that for MS SQL Server both supportsIfExistsBeforeTableName() and supportsIfExistsAf... Vadim Nebogatov
03:57 PM Feature #2141: generate SQL Server schema
Yes, I also already understood that it does not depend on dialect. Vadim Nebogatov
03:54 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> 11. Table creation
>
> Maximum MS SQL Server NUMERIC column precision is 38.
The more y...
Eric Faulhaber
04:19 AM Feature #2141: generate SQL Server schema
I have added item 11 about table creation to note 11. Vadim Nebogatov
03:07 PM Feature #2137 (New): runtime support for FIELDS/EXCEPT record phrase options
This feature is an optimization, but is not necessary for the runtime to function properly. Moving target version acc... Eric Faulhaber
03:03 PM Feature #1580 (Closed): upgrade Hibernate to latest level
Eric Faulhaber
07:13 AM Feature #1580: upgrade Hibernate to latest level
I've uploaded original Hibernate sources to @shared/projects/p2j/hibernate/hibernate-4.1.8.Final-original.zip@ and th... Stanislav Lomany

09/19/2013

01:48 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> I altered the conversion so that the _user AST is copied from meta to each processed databa...
Eric Faulhaber
01:37 PM Feature #2116: add runtime support for _user metadata table
I altered the conversion so that the _user AST is copied from meta to each processed database if configured in p2j.cf... Ovidiu Maxiniuc
01:37 PM Feature #2175 (Closed): add support for -rereadnolock startup parameter
Eric Faulhaber
03:56 AM Feature #2175: add support for -rereadnolock startup parameter
The update "om_upd20130912e.zip":https://proj.goldencode.com/redmine/attachments/1285/om_upd20130912e.zip added in #1... Ovidiu Maxiniuc
01:36 PM Feature #1594 (Closed): add conversion and runtime support for CURRENT-CHANGED() built-in function
Eric Faulhaber
03:39 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
The update was committed to bzr as revision 10381 and distributed by email. Ovidiu Maxiniuc

09/18/2013

05:46 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> 10. getAlterComputedColumnString()
> ...
> MS SQL Server ALTER TABLE does not allow alter...
Eric Faulhaber
05:18 PM Feature #2141: generate SQL Server schema
Items 9, 10 about rtrim and getAlterComputedColumnString added to note 9. Vadim Nebogatov
01:40 PM Feature #2141: generate SQL Server schema
I have added item 8 about collation to note 9. Vadim Nebogatov
05:35 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> ...the @_User@ table has changed; the .d /.df pair I extracted today have a different numbe...
Eric Faulhaber
05:16 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> I also start adding import support for _User meta-table.
> I understand that this is a ta...
Eric Faulhaber
02:07 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> > * I am a bit confused by the use of the @Database@ class to hold the userid.
> Indeed, ...
Eric Faulhaber
12:52 PM Feature #2116: add runtime support for _user metadata table
I also start adding import support for _User meta-table.
I understand that this is a table like others from the dat...
Ovidiu Maxiniuc
12:35 PM Feature #2116: add runtime support for _user metadata table
> * I am a bit confused by the use of the @Database@ class to hold the userid.
Indeed, I was a little confused abou...
Ovidiu Maxiniuc

09/17/2013

04:11 PM Feature #2175 (WIP): add support for -rereadnolock startup parameter
Eric Faulhaber
04:09 PM Feature #2116: add runtime support for _user metadata table
Eliminating the Apache logging dependency:
1. Replace:...
Eric Faulhaber
04:08 PM Feature #2116: add runtime support for _user metadata table
Code review 20130917a:
I realize this is only an intermediate update, but I had a quick look to get an idea of you...
Eric Faulhaber
02:41 PM Feature #2116: add runtime support for _user metadata table
An intermediate version.
From my tests, @userid@ and @setuserid@ forms of the function without ldbname use indeed the...
Ovidiu Maxiniuc

09/16/2013

04:41 PM Feature #2141: generate SQL Server schema
Please bear in mind that the scope of this task is to generate a SQL Server schema, not to implement all functionalit... Eric Faulhaber
04:34 PM Feature #2141: generate SQL Server schema
Sorry, I missed this earlier. Yes, we need to support both (and only those) versions (2008 and 2012). We do not need ... Eric Faulhaber
04:28 PM Feature #2141: generate SQL Server schema
Eric, what do you think about my last question in note 9 ("Will we create separate P2JSQLServer2008Dialect and P2JSQL... Vadim Nebogatov
04:25 PM Feature #2141: generate SQL Server schema
MS SQL Server allows double quoted column names and I meant we need support this too... But it seems I understood now... Vadim Nebogatov
10:22 AM Feature #2141: generate SQL Server schema
I'm not sure what use case would make this necessary. We control the conversion of all names, and we don't allow doub... Eric Faulhaber
04:54 AM Feature #2141: generate SQL Server schema
I think all usages of dialect.getComputedColumnPrefix() should be corrected for the case when prefix could be meet in... Vadim Nebogatov
04:12 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> In P2J terms, we need to have an "default" database defined in the directory, that will be ...
Eric Faulhaber
03:53 PM Feature #2116: add runtime support for _user metadata table
If the @_user@ table of "default" database is populated (is not empty) and the -U -P command line parameters are not ... Ovidiu Maxiniuc
03:46 PM Feature #2116: add runtime support for _user metadata table
From my researches I found out some interesting things about @userid@ and @setuserid@ which are not very explicit in ... Ovidiu Maxiniuc
02:10 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
OK, thanks. Please commit and distribute the update. Eric Faulhaber
11:42 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
The @crtRecBuffCount == 1@ means that the respective record is referred by one buffer. In this case, there are two ca... Ovidiu Maxiniuc
11:49 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Code review 20130911b/20130912e:
Changes look good, but please help me understand why the refresh code in the 2 ma...
Eric Faulhaber

09/13/2013

04:26 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Yesterday my work was focused on fixing the queries for failing tests. Because of the large amounts of sql queries ne... Ovidiu Maxiniuc

09/12/2013

04:35 PM Feature #2141: generate SQL Server schema
I have added item 7 about sequences to note 9 and question. Vadim Nebogatov
03:22 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
The initial tests had some unimportant fails in CTRL+C and quite a lot of fails in the main part:
* 7 in gso_tests ...
Ovidiu Maxiniuc

09/11/2013

03:33 PM Feature #2141: generate SQL Server schema
*XXXXP2JDialect implementation (will be extended)*
1. extractColumnName(String expr) , needsComputedColumns() and i...
Vadim Nebogatov

09/09/2013

01:21 AM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> One more question concerning mapping varchar to TEXT in PostgreSQL.
Progress @character@ f...
Eric Faulhaber

09/07/2013

05:21 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> I have noticed in import_util.rules that PostgreSQL connection string is configured only fo...
Vadim Nebogatov
03:39 AM Feature #2141: generate SQL Server schema
One more question concerning mapping varchar to TEXT in PostgreSQL. Vadim Nebogatov

09/06/2013

04:46 PM Feature #2141: generate SQL Server schema
I have noticed in import_util.rules that PostgreSQL connection string is configured only for default port (5432). Is ... Vadim Nebogatov
12:23 PM Bug #2178: Asymmetric sequence behavior
Sequences in Progress are somewhat asymmetric relatively to their increment:
- An ascending sequence will allow any ...
Ovidiu Maxiniuc
12:02 PM Bug #2178 (New): Asymmetric sequence behavior
Ovidiu Maxiniuc

09/05/2013

05:14 PM Feature #2141: generate SQL Server schema
I have checked in SQL Server 2005 (I think the same for SQL Server 2008 and 2012): the following column names are cor... Vadim Nebogatov
09:28 AM Feature #2141: generate SQL Server schema
Your understanding is correct (assuming that prefix generates a legal name in SQL Server). Eric Faulhaber
03:15 AM Feature #2141: generate SQL Server schema
Could the same prefix @CC_PREFIX = "__"@ be used for any database supporting computed columns? As far as I understood... Vadim Nebogatov
02:32 PM Feature #2175: add support for -rereadnolock startup parameter
The runtime test failed.
Some CTRL+C test failed and 3 reports show results different than expected.
I started disc...
Ovidiu Maxiniuc
10:53 PM Feature #2116 (WIP): add runtime support for _user metadata table
See #2177, which describes some background research to be done in preparation for this task.
The P2J implementatio...
Eric Faulhaber

09/04/2013

10:53 AM Feature #2175: add support for -rereadnolock startup parameter
Update merged with latest bzr sources and changes from review. I already re-tested it with my sample tests.
I am run...
Ovidiu Maxiniuc
07:57 AM Bug #2176: exceptions to rereadnolock
This looks like an optimization of some kind that Progress uses to reduce accesses to db.
When the search for a re...
Ovidiu Maxiniuc
07:53 AM Bug #2176 (New): exceptions to rereadnolock
Ovidiu Maxiniuc
03:23 AM Bug #2164: Server fails to start a Progress app when persistence disabled
The code changes look good, though please remove the left margin space that was inserted on every line after the firs... Eric Faulhaber

09/03/2013

06:15 PM Bug #2164: Server fails to start a Progress app when persistence disabled
Also, the code changes don't include automated tests. Should tests be part of the solution for this particular issue? Hynek Cihlar
06:13 PM Bug #2164 (Review): Server fails to start a Progress app when persistence disabled
Please review the changes. The submitted files are based to bzr revision number 10379. Hynek Cihlar
05:27 PM Feature #2141 (WIP): generate SQL Server schema
This will require the addition of a @P2JSQLServerDialect@ which extends Hibernate's @SQLServer2008Dialect@. If I reca... Eric Faulhaber
05:06 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Update vmn_upd20130903a.zip committed to bzr revision 10379. Vadim Nebogatov
04:13 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Please don't commit MetaSchemaImpl and comment out its usage for now, adding a TODO to fix it later. Eric Faulhaber
04:11 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric, should I commit also MetaSchemaImpl?
Or simply comment current MetaSchemaImpl method call and write P2JIndex ...
Vadim Nebogatov
12:29 PM Feature #2126 (WIP): add support for table-level locking (share and exclusive) for runtime intern...
Eric Faulhaber
11:48 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Since my requested changes do not affect the code itself, no need for another round of testing. Assuming it still com... Eric Faulhaber
11:37 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
The changes look good. Please add a header entry to @LockManagerMultiplexer.java@. As @MetaSchemaImpl@ is a temporary... Eric Faulhaber
01:54 PM Feature #2175: add support for -rereadnolock startup parameter
<sigh> I can't make any sense of the "logic" that must be behind these results. Looks like a quirk/bug of their parse... Eric Faulhaber
01:20 PM Feature #2175: add support for -rereadnolock startup parameter
I found another issue. When the search for a record is done using the ROWID or RECID, the record is not re-fetched fr... Ovidiu Maxiniuc
12:13 PM Feature #2175: add support for -rereadnolock startup parameter
Eric Faulhaber wrote:
> @rereadNoLock()@ to @getRereadNoLock()@.
Sorry, for consistency, I guess that should be @is...
Eric Faulhaber
11:23 AM Feature #2175: add support for -rereadnolock startup parameter
One more thing: please use proper logging in your @RecordBuffer@ changes instead of @System.err.println@. Eric Faulhaber
11:06 AM Feature #2175: add support for -rereadnolock startup parameter
OK, thanks for the explanation. The implementation looks good to me, just minor change requests:
* For consistency o...
Eric Faulhaber
09:48 AM Feature #2175: add support for -rereadnolock startup parameter
From my researches on 4GL and docs, there is nothing to indicate that Progress looks into other user's buffers to see... Ovidiu Maxiniuc
01:42 AM Feature #2175: add support for -rereadnolock startup parameter
I haven't finished a detailed review yet, but I have a basic question on your approach: are you trying to determine ... Eric Faulhaber
12:30 PM Feature #2043 (WIP): add runtime support for some embedded SQL features
Eric Faulhaber
12:27 PM Feature #1668: add support for additional (non-dynamic) database attributes
Interesting temp-table result for DBNAME, too. Suggests that internally, Progress uses a distinct database for temp-t... Eric Faulhaber

09/02/2013

05:43 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Regressions (note 24-25) were executed for vmn_upd20130831a.zip. Vadim Nebogatov
05:41 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
I have uploaded update vmn_upd20130831a.zip replacing vmn_upd20130814a.zip with fixes according to note 23. Vadim Nebogatov
04:54 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Regression 20130902_061345, 3 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in actual at ...
Vadim Nebogatov
04:36 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
I have executed regression two times.
Regression 20130831_172455, 4 FAILED tests:
1. gso221_session1 FAILED f...
Vadim Nebogatov
05:31 PM Feature #1668: add support for additional (non-dynamic) database attributes
The following test case for note 124:... Vadim Nebogatov
05:15 PM Feature #1668: add support for additional (non-dynamic) database attributes
From docs: "For ... Buffer object handle, the ERROR attribute indicates whether an error occurred during a FILL or S... Vadim Nebogatov
11:37 AM Feature #2175: add support for -rereadnolock startup parameter
Update pack for review. This update is built over the om_upd20130829a.zip of #1594.
The implementation looks into @B...
Ovidiu Maxiniuc

08/30/2013

03:07 PM Feature #2175: add support for -rereadnolock startup parameter
My first instinct was to put this flag somewhere in the database branch which was a little cumbersome to extract. I f... Ovidiu Maxiniuc
12:35 PM Feature #2175: add support for -rereadnolock startup parameter
Ovidiu Maxiniuc wrote:
> This is a command-line parameter for the client, it's proper location is not the @directory...
Eric Faulhaber
11:57 AM Feature #2175: add support for -rereadnolock startup parameter
This is a command-line parameter for the client, it's proper location is not the @directory.xml@.
In 4GL I can have ...
Ovidiu Maxiniuc
02:22 PM Feature #2115: add runtime support for _file and _field metadata tables
I asked only to understand tables structures. Vadim Nebogatov
02:16 PM Feature #2115: add runtime support for _file and _field metadata tables
No reasons, I also think they could be hidden behind MetaSchema API. Vadim Nebogatov
02:11 PM Feature #2115: add runtime support for _file and _field metadata tables
Sorry I missed this earlier. Yes, these tables have a RECID field, generally of the form @{table_name}-recid@. But, I... Eric Faulhaber
01:57 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stanislav Lomany wrote:
> And what about index information - list of indexes with attributes: primary, word (if we n...
Eric Faulhaber
01:46 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
And what about index information - list of indexes with attributes: primary, word (if we need it), unique?
> We wi...
Stanislav Lomany
01:34 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
All of these will be available via the @MetaSchema@ API, though the actual metadata tables (e.g., _file, _field, etc.... Eric Faulhaber
01:26 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> These names will available via an API. The code will look something like this:
>
> MetaSchema meta = persistence...
Stanislav Lomany
11:58 AM Feature #1668: add support for additional (non-dynamic) database attributes
For all the buffer-related attributes in note 113, please determine with test cases that these all work the same way ... Eric Faulhaber
11:15 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Code review 20130814a:
I think the implementation of table locking in @InMemoryLockManager@ generally is OK, but s...
Eric Faulhaber

08/29/2013

05:59 PM Feature #1668: add support for additional (non-dynamic) database attributes
Update vmn_upd20130829a.zip/vmn_upd20130829b.zip is attached.
Test case corresponds to 4GL behavior for tablehand...
Vadim Nebogatov
02:37 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Update for review.
We need to update the current-changed each time @P2JQuery.current()@ is called. Other first/next/...
Ovidiu Maxiniuc
11:38 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
The @-rereadnolock@ is not activated and in 4GL this case is not taken into consideration.
In fact this is the sec...
Ovidiu Maxiniuc
10:04 AM Feature #2175: add support for -rereadnolock startup parameter
Testing environment. The article is not very explicit so I will explain the testcase.
Suppose we have a table @perso...
Ovidiu Maxiniuc

08/28/2013

03:46 PM Feature #2175: add support for -rereadnolock startup parameter
The current persistence implementation does not support the feature provided by the @-rereadnolock@ startup parameter... Eric Faulhaber
03:44 PM Feature #2175 (Closed): add support for -rereadnolock startup parameter
Eric Faulhaber
03:42 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
The @-rereadnolock@ parameter is indeed in use in the server project. We will need to support this as a configurable ... Eric Faulhaber
03:29 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Oops, I misread your test case. This is not a dirty share issue, as I was thinking. Session B actually commits its ch... Eric Faulhaber
03:01 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Just re-checked with @customer@ and @person@ tables.
There is definitely a bug, in P2J the A client displays the sa...
Ovidiu Maxiniuc
02:35 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
How does this test case behave in the 4GL?
The @customer@ table is a bit unusual in our @p2j_test@ database in tha...
Eric Faulhaber
02:19 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
I know.
The important issue is that if you have 2 clients on the same P2J server and
Client A:...
Ovidiu Maxiniuc
02:11 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Ovidiu Maxiniuc wrote:
> There is no second level cache in Hibernate. The @directory.xml@ explicitly say: @hibernate...
Eric Faulhaber
01:05 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
I am forced to do the implementation as you suggested.
I really do not understand why my session of hibernate cannot...
Ovidiu Maxiniuc

08/27/2013

06:51 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
I don't know if the caching behavior changed with the Hibernate upgrade. Regardless, I want to keep the calls to @Ses... Eric Faulhaber
03:01 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
You were right about the implementation. I changed a little, I'm doing the check for changed field in a bracket in @R... Ovidiu Maxiniuc

08/26/2013

03:54 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> Stas, could some conflict between ids happen with using shared buffers?
UniqueIdGenerator only hands out new ids...
Stanislav Lomany
02:33 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stas, could some conflict between ids happen with using shared buffers? Vadim Nebogatov
09:26 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Constantin, you can check com.goldencode.p2j.util.UniqueIdGenerator. Vadim, generator presumes that id's are unique a... Stanislav Lomany
08:57 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Vadim Nebogatov wrote:
> I understand for TEMP_TABLE, but why unique id for BUFFER is also ContextLocal?
I don't th...
Constantin Asofiei
05:32 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
I understand for TEMP_TABLE, but why unique id for BUFFER is also ContextLocal? Vadim Nebogatov

08/25/2013

10:36 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Hibernate sources update. Stanislav Lomany

08/23/2013

07:15 PM Feature #2080: add runtime support for database methods
I have attached preliminary update vmn_upd20130824a including BUFFER-FIELD and GET-BUFFER-HANDLE support and MetaSche... Vadim Nebogatov
05:49 PM Feature #2080: add runtime support for database methods
Support of methods added in issue #1947:
@BUFFER-FIELD (KW_BUF_FLD)@
Implemented with MetaShemaImpl (stub with...
Vadim Nebogatov
12:59 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update with new functionality for review. Stanislav Lomany

08/22/2013

04:10 PM Feature #2080: add runtime support for database methods
CompoundQuery.bufferHandle(int bufferSequenceNumber): could be based on recordBuffers() method returning iterator, bu... Vadim Nebogatov
03:22 PM Feature #1666: add support for mixed-direction indexes
I looked over the conversion test result and it has been generated as expected. Continuing with runtime-regression. Ovidiu Maxiniuc
12:50 PM Feature #1666: add support for mixed-direction indexes
I double checked the index and sort clause generations for both H2 and PSQL dialects.
I am putting now this update t...
Ovidiu Maxiniuc
01:48 AM Bug #2164: Server fails to start a Progress app when persistence disabled
Those examples I gave were theoretical cases which indeed may never happen. I'll put the check in the @BufferManager.... Hynek Cihlar
 

Also available in: Atom