FWD » Core Development » Database

11/28/2013

07:10 PM Feature #2116: add runtime support for _user metadata table

Code review 20131125d (database-related):
The database portions of this most recent drop look fine for check-in. T... Eric Faulhaber

11/27/2013

06:10 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Code review 20131126a:
* The new @legacy_primary_index_annotation@ in @java_templates.tpl@ is largely redundant with... Eric Faulhaber

03:53 PM Feature #2024: implement runtime support for database triggers

I think that parts of the @progress.g@ should be re-written to allow the correct syntax to be parsed. It here are the... Ovidiu Maxiniuc

03:21 PM Feature #2116: add runtime support for _user metadata table

I finally obtained a satisfiable result with the update for this issue.
The final run wasn't flawless, but I couldn'... Ovidiu Maxiniuc

11:26 AM Feature #2116 (Test): add runtime support for _user metadata table

Eric Faulhaber

09:27 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

So, when you use a dynamic table @tt@ (with fields @f-1@ and @f-2@) in a dynamic query, and in 4GL you have this pred... Constantin Asofiei

07:04 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

The problem: dynamic queries do not recognize fields of dynamic tables specified in 4GL where clause.
Cause:
1. Na... Stanislav Lomany

11/26/2013

03:36 PM Feature #1588: add conversion and runtime support for embedded SQL

Actually I tested deleteAll() with @DELETE FOR@ for permanent tables. Rest issue, – fix in P2JIndex.getOrderByClause... Vadim Nebogatov

03:35 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Update vmn_upd20131126a.zip is attached.
Fixed P2JIndex.getOrderByClause(), used dmoAlias instead of table name.
... Vadim Nebogatov

11/25/2013

02:01 PM Feature #1588: add conversion and runtime support for embedded SQL

Please use the new primary index annotation you have added for #2126 to ensure that the no-WHERE-clause variant of @d... Eric Faulhaber

01:53 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Update vmn_upd20131125a.zip is attached.
1) Using java annotations for retrieving primary index and deleteAll().
... Vadim Nebogatov

11/23/2013

12:18 AM Feature #2117: add runtime support for _lock metadata table

The attached update adds basic conversion and runtime metadata support for the _lock table. It has passed regression ... Eric Faulhaber

11/22/2013

03:08 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Vadim Nebogatov wrote:
> [...] But I agree that separate <extent-name> elements look better. Should I correct?
Yes... Eric Faulhaber

02:41 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Eric Faulhaber wrote:
> * Why did you choose a CSV format for the @<extent-names>@ hint element, instead of using se... Vadim Nebogatov

07:01 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Go ahead and commit and distribute the update, even though the above issues need to be addressed. It won't affect con... Eric Faulhaber

11/21/2013

06:24 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Second regresion 20131121_123331 executed with 6 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpecte... Vadim Nebogatov

05:59 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Code review 20131117*:
This is a good start, but it only handles the schema conversion, DMO creation, and ORM conf... Eric Faulhaber

11/20/2013

06:29 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Regresion 20131119_150620 executed with 3 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF i... Vadim Nebogatov

01:57 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

>Is there any significant technical debt you are adding by going with the simple map approach now, which will complic... Stanislav Lomany

01:32 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Do what you need to do to get this issue finished for M7 (so...simple map for now). Please open a separate issue for ... Eric Faulhaber

01:27 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Guys, in order to make Java compiler work for dynamic queries + dynamic tables, I've done the following:
1. @InMemor... Stanislav Lomany

11:04 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Constantin Asofiei wrote:
> More, I think for temp-tables the primary (and other info like this) is emitted to the @... Eric Faulhaber

10:50 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

I am OK with Constantin's approach, especially if we are going to get rid of the @@LegacyIndexes@ parent with Java 8. Eric Faulhaber

10:40 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Vadim Nebogatov wrote:
> ...in order to find primary index without search in array for example.
Yes, but you can al... Constantin Asofiei

10:35 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

...in order to find primary index without search in array for example. Vadim Nebogatov

10:33 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Actually I also started with adding boolean @primary@ to LegacyIndex, but noticed that Eric suggested to add index na... Vadim Nebogatov

10:23 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Vadim/Eric: The @LegacyIndexes@ annotation is used only because Java 7 does not allow multiple annotations with the s... Constantin Asofiei

10:11 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

I am trying to add optional annotation “primary” and generate DMO impl annotation like ... Vadim Nebogatov

11:03 AM Feature #2203: replace or minimize use of dmo_index.xml file

The @dmo_index.xml@ file (and @DMOIndex@ class) originally was established as a list of DMOs needed to bootstrap Hibe... Eric Faulhaber

10:55 AM Feature #2203 (New): replace or minimize use of dmo_index.xml file

Eric Faulhaber

11/19/2013

07:38 AM Feature #2116: add runtime support for _user metadata table

The @_User@ table should only be involved in conversion and at runtime if it was configured to be a metadata table in... Eric Faulhaber

07:26 AM Feature #2116: add runtime support for _user metadata table

I have the following issue:
I have the @meta_user@ table created in the @schema_table_<dbname>_<dialect>.sql@ and th... Ovidiu Maxiniuc

11/18/2013

01:20 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Doesn't include features from the todo list above. Stanislav Lomany

11/17/2013

06:08 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Updated files attached Vadim Nebogatov

11/15/2013

05:47 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Issue is found and fixed concerning wrong conversion of fields with no extent in case if hint is assigned for whole t... Vadim Nebogatov

01:17 PM Bug #2199: ambiguity warnings too aggressively disabled

I believe the following test-case is related:
This is a P4GL valid code (temp-table @book@ 'hides' the @book@ tabl... Ovidiu Maxiniuc

01:02 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

todo list for this task:
1. fix dynamic tables + dynamic queries (WIP)
2. fix scoping for dynamic buffers for stati... Stanislav Lomany

12:19 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

Note that we will not need the @primary@ annotation element for temp-tables (at least not for bulk delete purposes), ... Eric Faulhaber

12:16 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use

We have decided not to move forward with the @MetaSchema@ interface, and instead to use Java annotations in the DMO i... Eric Faulhaber

11/14/2013

04:07 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Issue with
<property column="hours9" name="hours3" type="p2j_integer"/>
is resolved. Vadim Nebogatov

10:20 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Attached
1) code update vmn_upd20131114a.zip merged with latest bzr revision 10411;
2) vmn_upd20131114b.zip con... Vadim Nebogatov

01:06 PM Feature #2120: add runtime support for dynamically prepared queries

Variation of the bug above. Testcase:... Stanislav Lomany

12:41 PM Feature #2120: add runtime support for dynamically prepared queries

Yet another minor bug. Testcase:... Stanislav Lomany

11/13/2013

01:30 PM Feature #2024: implement runtime support for database triggers

Wouldn't it be easier/cleaner to invoke the trigger manager from the record buffer proxy? It's already an architected... Eric Faulhaber

01:19 PM Feature #2024: implement runtime support for database triggers

Here is a 100 points question.
What's the best solution for notifying ASSIGN triggers ?
In P4GL, the ASSIGN trigg... Ovidiu Maxiniuc

11/12/2013

04:54 PM Feature #2116: add runtime support for _user metadata table

I saw that change, but it wasn't clear to me how this fixed the problem. I understand now: the problem was not that t... Eric Faulhaber

01:04 PM Feature #2116: add runtime support for _user metadata table

I already have talked to Contstantin and he helped me with this issue; the last update contains the fix for it. See t... Ovidiu Maxiniuc

12:58 PM Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> ...the big problem is registering dirty databases and doing the cleanup of @DatabaseManager... Eric Faulhaber

12:38 PM Feature #2116: add runtime support for _user metadata table

Sorry for the delay in review, lost track of this one. Please merge up to latest code level, make my minor changes be... Eric Faulhaber

02:02 PM Feature #2024: implement runtime support for database triggers

Today I had some questions about the WRITE trigger and its implementation so I had the following summarized mail disc... Ovidiu Maxiniuc

11/11/2013

06:04 PM Bug #1914: database conversion requires Internet connectivity

Actually, it is not even necessary to omit the PUBLIC ID. Only the code changes to use the entity resolver are needed. Eric Faulhaber

08:47 AM Bug #1914: database conversion requires Internet connectivity

I have a fix for this that does not require copying the DTD anywhere. The DTD already is in the Hibernate jar file, w... Eric Faulhaber

05:32 AM Bug #1914: database conversion requires Internet connectivity

Added the @hibernate-mapping-3.0.dtd@ file (in case hibernate.org site is inaccessible). Constantin Asofiei

04:51 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Yes, @initial@ subnode was missing, thanks. Vadim Nebogatov

02:54 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Look at the @.p2o@ file that is generated and compare the artificial property nodes you have created with your expans... Eric Faulhaber

01:42 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

I have created loop in p2o.xml in rule with the comment
<!-- map fields to properties -->
after rule with the ... Vadim Nebogatov

02:30 AM Feature #2120: add runtime support for dynamically prepared queries

I've found a minor bug: @get-next@ returns @yes@ even if there are no more results. Testcase:... Stanislav Lomany

11/10/2013

08:42 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> As the solution I will have to modify conversion for dynamic queries. Modifying AST after conversion or in some mid... Constantin Asofiei

11/09/2013

06:45 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

FYI, the original version of dynamic queries do not work with dynamic buffers because of the following: consider the ... Stanislav Lomany

05:43 AM Bug #1914: database conversion requires Internet connectivity

Today hibernate site has gone to maintenance, so I did like Constantin suggested. Luckily I found hibernate-mapping-3... Stanislav Lomany

11/08/2013

05:44 AM Bug #1914: database conversion requires Internet connectivity

The root cause is the same: the Hibernate's DTD is needed to parse the @.hbm.xml@ files, but is not reachable. An ini... Constantin Asofiei

05:24 AM Bug #1914: database conversion requires Internet connectivity

Unlike the previous MAJIC conversion error this one occurs at runtime at test server startup when it is offline. The ... Stanislav Lomany

11/07/2013

05:21 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Greg Shah wrote:
> I assume that we also would support a scenario where someone has set a hint to denormalize an ext... Eric Faulhaber

04:38 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Two thoughts:
> ...and in the event a hint specifies that the schedule table's daily-hours extent 5 field should b... Greg Shah

04:19 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

I think the common case we will encounter will be statically indexed references to extent fields, which we can resolv... Eric Faulhaber

02:15 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

I think that in any case we need some way to enumerate elementary properties specified in hint in runtime to provide ... Vadim Nebogatov

01:20 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Help me understand why we would need a custom Hibernate type for every extent field in an application. We already hav... Eric Faulhaber

08:55 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

This interface is already used in DatetimeTzUserType. Vadim Nebogatov

08:48 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

I think we should generate class implementing CompositeUserType for each such property both for incremented names and... Vadim Nebogatov

10:12 AM Feature #2024: implement runtime support for database triggers

Observations on schema triggers::
* checking the CRC box will force compile the trigger which mean the file must exi... Ovidiu Maxiniuc

08:59 AM Feature #2024: implement runtime support for database triggers

> Indeed, for each table in the schema administration of data dictionary there are two flags: one is the overridable ... Greg Shah

02:01 AM Feature #2024: implement runtime support for database triggers

>Where does the overridable flag come?
>
>If it comes from the schema, let's read that flag at conversion time and ... Ovidiu Maxiniuc

09:42 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav (from email):
> Heh, BUFFER:NAME is an attribute of a static or dynamic buffer. I don't mind to implement i... Constantin Asofiei

09:09 AM Feature #2141: generate SQL Server schema

The update looks good.
Eric: the other change is in the schema/import_util.rules file (the @sqlserver2008@ dialec... Constantin Asofiei

05:59 AM Feature #2141: generate SQL Server schema

I have attached corresponding update vmn_upd20131107a.zip with two changed files. Vadim Nebogatov

08:59 PM Feature #2141: generate SQL Server schema

No, the point of the previous entry was to indicate that @P2JH2Dialect.hasFullSequenceSupport@ should NOT be used to ... Eric Faulhaber

11/06/2013

04:42 PM Feature #2141: generate SQL Server schema

Is it ok if I change comment for P2JH2Dielect.hasFullSequenceSupport()... Vadim Nebogatov

04:12 PM Feature #2141: generate SQL Server schema

There is no plan currently to implement an @IdentityManager@ which does not rely on sequences. So far, SQL Server 200... Eric Faulhaber

03:29 PM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> Should I run regression one more time nevertheless?
No, is not needed.
> I checked DDL... Constantin Asofiei

12:39 PM Feature #2141: generate SQL Server schema

Constantin Asofiei wrote:
> I expect these to be false negatives, as there is nothing in MAJIC which uses legacy sequ... Vadim Nebogatov

11:16 AM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> Update vmn_upd20131104a.zip is attached containing P2JH2Dialect fix (method hasFullSequence... Constantin Asofiei

07:25 AM Feature #2141: generate SQL Server schema

Update vmn_upd20131104a.zip is attached containing P2JH2Dialect fix (method hasFullSequenceSupport() returns true).
... Vadim Nebogatov

02:16 PM Feature #2024: implement runtime support for database triggers

> the only issue here is that the trigger source file taken from P4GL do not contain the Overrideable attribute so t... Greg Shah

01:38 PM Feature #2024: implement runtime support for database triggers

> Consider that our current UI triggers work in this same way, and even have support for revert and so forth. Since t... Ovidiu Maxiniuc

10:01 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Vadim, what are you thinking in terms of how to deal with business logic that references former extent fields which h... Eric Faulhaber

08:09 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin,
> Can you post (at the task) the rules you've found relating to how scoping works for dynamic buffers
... Stanislav Lomany

11/05/2013

12:50 PM Feature #2024: implement runtime support for database triggers

> Because of these, I chosen to implement in TriggerManager a stack of 'Layers' that are automatically pushed/popped ... Greg Shah

12:15 PM Feature #2024: implement runtime support for database triggers

Here are a few things about triggers that are not implemented or need to be adjusted:
* there are two kinds of trigg... Ovidiu Maxiniuc

11/01/2013

06:03 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Parsing result is field in TableHints
... Vadim Nebogatov

10/31/2013

12:59 PM Bug #2199: ambiguity warnings too aggressively disabled

Because the ambiguity warning level is to low, P2J will force conversion of some pieces of code that that are not P4G... Ovidiu Maxiniuc

12:29 PM Bug #2199 (New): ambiguity warnings too aggressively disabled

Ovidiu Maxiniuc

12:25 PM Feature #2116: add runtime support for _user metadata table

This update is merged with latest sources from bzr (up to revision 10409) and also addresses the issue presented in n... Ovidiu Maxiniuc

05:49 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Issue status.
Found out and tested all places affecting custom extent conversion. Studied and tested hints generati... Vadim Nebogatov

05:03 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

I don't really like this, because a TEMP-TABLE resource in 4GL exists for both static and dynamic temp-tables. Althou... Constantin Asofiei

04:49 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin, as you have noticed, @TableMapper@ impelementation depends on @getUniqueId()@ and @getPersistentClass().g... Stanislav Lomany

02:45 AM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> OK, but tomorrow, please check in the version that already has passed regression testing bef... Constantin Asofiei

10/30/2013

01:52 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> I think we need a @QueryResource@ interface to be implemented only by the @QueryWrapper@... Eric Faulhaber

01:46 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> > Some other issues, all minor:
> I'll fix these tomorrow (as I need to double-check no... Eric Faulhaber

01:42 PM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> I'm wondering if it makes sense to refactor @P2JQuery@ and @AbstractQuery@, since so many of... Constantin Asofiei

01:37 PM Feature #2120: add runtime support for dynamically prepared queries

Greg Shah wrote:
> Anything else?
The issues Constantin described in notes 63 & 66 above.
With regard to the @Ab... Eric Faulhaber

01:31 PM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> ... due to the memory requirements of the pristineScope data in each SchemaDictionary insta... Constantin Asofiei

01:06 PM Feature #2120: add runtime support for dynamically prepared queries

Let's create new tasks for the open issues:
* Conversion artifacts moved into and read from the application jar.
... Greg Shah

12:50 PM Feature #2120: add runtime support for dynamically prepared queries

Code review 20131030a:
Wow, brilliant update! Looks really good, only one major concern: the approach of having a ... Eric Faulhaber

12:12 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> the following files and folders must exist in the server/ folder (i.e. current folder whe... Eric Faulhaber

11:22 AM Feature #2120: add runtime support for dynamically prepared queries

I missed something in the @QueryWrapper@ c'tor; I think this code:... Constantin Asofiei

09:52 AM Feature #2120 (Review): add runtime support for dynamically prepared queries

Attached 1030a.zip (replacement for 1029c.zip) and 1029a.zip have passed conversion and runtime testing. (1029c.zip h... Constantin Asofiei

12:26 PM Feature #2116: add runtime support for _user metadata table

I discovered that the buffer conflict was not correctly fixed. The name collision could occur also with buffers/table... Ovidiu Maxiniuc

10/29/2013

02:53 PM Feature #2116: add runtime support for _user metadata table

Eric,
I believe that we can live with a few hundreds KB of data permanently loaded for never or seldom databases ... Ovidiu Maxiniuc

10:35 AM Feature #2120: add runtime support for dynamically prepared queries

Code Review 1029a
This update is good to go. Nice!
Eric will handle the other update. Greg Shah

07:58 AM Feature #2120: add runtime support for dynamically prepared queries

1029a.zip is replacement for 1023d.zip (in-memory registry/storage plugin).
1029c.zip contains the changes for conve... Constantin Asofiei

03:31 AM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> I guess this makes sense on some level. For a dynamically created query, the handle(s) to it... Constantin Asofiei

03:22 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Eric Faulhaber wrote:
> Constantin, I didn't think of this earlier when we were discussing all the new annotations f... Constantin Asofiei