FWD » Core Development » Database

08/06/2014

09:08 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Code review 20140805a:
* As noted above, the @if@ condition at line 3662 should drop the BUFFER-COMPARE-specific p... Eric Faulhaber

08:29 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Yes, it looks like that length restriction is wrong; I'm not sur... Eric Faulhaber

08/05/2014

05:48 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

I have attached next update vmn_upd20140805a.zip tested with @#2353@ and @buffer-copy-pair-list.p@ from note 18. Both... Vadim Nebogatov

04:09 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

I just noticed that message ... Vadim Nebogatov

01:33 PM Feature #2359: automated maintenance of database support files

Current implementation of custom functions exposed in SQL queries uses some additional files that, even if they rarel... Ovidiu Maxiniuc

01:18 PM Feature #2359 (New): automated maintenance of database support files

Ovidiu Maxiniuc

01:14 PM Feature #2358: HQLPreprocessor and dialect specific functions

At this moment @HQLPreprocessor@ must preprocess the HQL code depending on the dialect.
The @rtrim@ function is rep... Ovidiu Maxiniuc

01:03 PM Feature #2358 (WIP): HQLPreprocessor and dialect specific functions

Ovidiu Maxiniuc

08/04/2014

07:11 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

[ECF: moved content of this note to #2353, note 13] Vadim Nebogatov

11:12 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Eric Faulhaber wrote:
> Yes, it looks like that length restriction is wrong; I'm not sure why I came up with that.
... Vadim Nebogatov

10:42 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Vadim Nebogatov wrote:
> Condition RecordBuffer, 3661
>
> ... Eric Faulhaber

10:58 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Code review 20140803a:
It seems this code will work, but I'm wondering about some choices:
* By adding @getSize@ ... Eric Faulhaber

08:55 AM Feature #2220: dynamic query methods which require implementation

While working on the LAST issue, I've looked into invalidation logic for adaptive queries. I think it's a bit doubtfu... Stanislav Lomany

08/03/2014

06:17 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Condition RecordBuffer, 3661... Vadim Nebogatov

07:27 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent

I have attached update vmn_upd20140803a.zip with fixes issues from Eric review and fix from Stas. Vadim Nebogatov

08/02/2014

10:05 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Eric Faulhaber wrote:
> I noticed you prepended @opType == OperationType.COPY &...@ to the @if@ condition at line 38... Vadim Nebogatov

09:24 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Code review 20140802a:
Please log a warning inside the catch block at line 3829, rather than eating the exception.... Eric Faulhaber

08:19 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Attached vmn_upd20140802a.zip with corrections according review (note 13) merged with latest bzr revision 10592. Vadim Nebogatov

08/01/2014

06:34 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Code review 20140801a:
* The use of @TempTableBuilder.getExtentSize@ at lines 3812 and 3814 does not look correct.... Eric Faulhaber

04:52 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

vmn_upd20140729a.zip merged with latest bzr revision 10591 to vmn_upd20140801a.zip. Vadim Nebogatov

04:51 PM Feature #2220: dynamic query methods which require implementation

OK, but that doesn't look like a flushing issue to me, so I guess we will stay out of each others' way on this one. Eric Faulhaber

04:44 PM Feature #2220: dynamic query methods which require implementation

This issue I have to fix. LAST just do not work for adaptive queries.... Stanislav Lomany

03:55 PM Feature #2220: dynamic query methods which require implementation

No problem about having this issue. I just need to consider it when making testcases. Stanislav Lomany

03:24 PM Feature #2220: dynamic query methods which require implementation

Stanislav Lomany wrote:
> BTW, P2J includes records in both PREV cases.
I am working on a flush/validate fix that I... Eric Faulhaber

03:19 PM Feature #2220: dynamic query methods which require implementation

You are right - it is about flushing.
>Are you saying they both include the 0 record or they both exclude it?
Inc... Stanislav Lomany

03:08 PM Feature #2220: dynamic query methods which require implementation

Stanislav Lomany wrote:
> There is no difference in testcases output if the queries are iterated in the forward dire... Eric Faulhaber

03:06 PM Feature #2220: dynamic query methods which require implementation

I think what's happening here is that nothing is releasing/flushing the newly created record from buffer @xtt@ before... Eric Faulhaber

02:51 PM Feature #2220: dynamic query methods which require implementation

Strange case. Testcase 1:... Stanislav Lomany

10:12 AM Feature #2220: dynamic query methods which require implementation

BTW, there is an issue with dynamic queries you probably aware of. Creation of a record using a backing buffer of a d... Stanislav Lomany

12:46 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

Code review 20140408a:
Changes look good. Unfortunately (my fault), the update is now way out of date with the lat... Eric Faulhaber

09:59 AM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

Eric Faulhaber wrote:
> Sorry I lost track of this. Does this update need separate review, or have these changes bee... Ovidiu Maxiniuc

09:53 AM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

Ovidiu Maxiniuc wrote:
> Reuploaded the update after merging with latest bzr revision (10506).
Sorry I lost track o... Eric Faulhaber

10:20 AM Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...

Eric Faulhaber wrote:
> What is the status of the issues described in and the update attached to note 4? This effort... Ovidiu Maxiniuc

09:50 AM Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...

What is the status of the issues described in and the update attached to note 4? This effort seems to have merged wit... Eric Faulhaber

07/31/2014

11:01 AM Feature #2207: Remaining issues for dynamic buffers and dynamic tables

Since none of these use cases are known to be in the current project, I am unassigning the milestone target. Eric Faulhaber

08:49 AM Feature #2220: dynamic query methods which require implementation

About caching. So far I can state that:
1. Adaptive scrolling queries have recid-based cache which is populated as w... Stanislav Lomany

08:15 AM Feature #2220: dynamic query methods which require implementation

Regarding the question if scrolling adaptive queries are modified with @DELETE-RESULT-LIST-ENTRY@ in the customer app... Stanislav Lomany

07/30/2014

05:34 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Attached @buffer-copy-dyn-static-tt-no-display.p@ with added new... Vadim Nebogatov

05:23 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Vadim Nebogatov wrote:
> NonUniqueObjectException in note 3 thrown in code RecordBuffer, 9922:
>
> [...]
>
> A... Eric Faulhaber

05:12 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Vadim Nebogatov wrote:
> Attached @buffer-copy-dyn-static-tt-no-display.p@ with added new @22-29@ tests.
Please c... Eric Faulhaber

03:23 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

NonUniqueObjectException in note 3 thrown in code RecordBuffer, 9922:... Vadim Nebogatov

11:57 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent

See #2353, note 1. Ovidiu Maxiniuc

10:46 AM Bug #2337 (Closed): trigger scanning defect

Eric Faulhaber

10:46 AM Bug #2344 (Closed): invalid scoping for dynamic buffers

Eric Faulhaber

10:04 AM Bug #2344 (Review): invalid scoping for dynamic buffers

Regression-tested. Committed to bzr rev 10586. Stanislav Lomany

07/29/2014

02:14 PM Bug #2347 (WIP): hql to SQL name mapping issue

The provided solution uses @HQLFunction@ annotation to make available at runtime the name of the function used in gen... Ovidiu Maxiniuc

12:47 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

I have attached update vmn_upd20140729a.zip fixing all these cases excepting one problem, it seems not directly relat... Vadim Nebogatov

07/28/2014

04:48 PM Bug #2350 (WIP): BUFFER-COPY errors related with copying fields with extent

Vadim Nebogatov

04:34 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent

Attached @buffer-copy-dyn-static-tt-no-display.p@ with added new @22-29@ tests.
h3. Progress results... Vadim Nebogatov

04:31 PM Bug #2350 (Closed): BUFFER-COPY errors related with copying fields with extent

Vadim Nebogatov

02:32 PM Bug #2347: hql to SQL name mapping issue

Consider the following Progress code sample:... Ovidiu Maxiniuc

01:49 PM Bug #2347 (Closed): hql to SQL name mapping issue

Ovidiu Maxiniuc

07/26/2014

02:52 PM Bug #2344: invalid scoping for dynamic buffers

Stanislav Lomany wrote:
> @4) Department CREATE@ output:
>
> [...]
You have to run "1) Department Type CREATE.... Eric Faulhaber

02:43 PM Bug #2344: invalid scoping for dynamic buffers

Code review 0725a:
Looks good. Please note that Vadim has a change to @RecordBuffer@ for #2331 (@vmn_upd20140723a.... Eric Faulhaber

07/25/2014

06:09 PM Bug #2344: invalid scoping for dynamic buffers

@4) Department CREATE@ output:... Stanislav Lomany

05:57 PM Bug #2344: invalid scoping for dynamic buffers

Yes. I ignored it:... Stanislav Lomany

05:53 PM Bug #2344: invalid scoping for dynamic buffers

Are you getting this after running @dbuf-scope1.p@?... Eric Faulhaber

05:52 PM Bug #2344: invalid scoping for dynamic buffers

Stanislav Lomany wrote:
> > Make sure the department_code_create API is not regressed
>
> Am I missing some files... Eric Faulhaber

05:49 PM Bug #2344: invalid scoping for dynamic buffers

> Make sure the department_code_create API is not regressed
Am I missing some files or do you mean 4) Department C... Stanislav Lomany

04:53 PM Bug #2344: invalid scoping for dynamic buffers

Good. Greg Shah

04:47 PM Bug #2344: invalid scoping for dynamic buffers

I use... Stanislav Lomany

04:27 PM Bug #2344: invalid scoping for dynamic buffers

Please check your testcases into testcases/uast/dynamic_buffer/. Greg Shah

04:26 PM Bug #2344: invalid scoping for dynamic buffers

> > Dynamic buffers for permanent tables should have global scope.
>
> Are you sure about this? How did you confir... Stanislav Lomany

04:25 PM Bug #2344: invalid scoping for dynamic buffers

Pending a reply to my last question...
Stanislav Lomany wrote:
> Fixes my testcases, #2329 and parameter_code_sea... Eric Faulhaber

04:06 PM Bug #2344: invalid scoping for dynamic buffers

Stanislav Lomany wrote:
> Dynamic buffers for permanent tables should have global scope.
Are you sure about this?... Eric Faulhaber

06:20 AM Bug #2344: invalid scoping for dynamic buffers

Fixes my testcases, #2329 and parameter_code_search (I guess #2331 is about that?). Note that I've altered ... Stanislav Lomany

11:17 AM Bug #2295: In Progress output parameters ignore decimal precision

I don't think anything more is needed right now. Eric will make the call on this soon. We will probably have to fix... Greg Shah

11:08 AM Bug #2295: In Progress output parameters ignore decimal precision

Hynek Cihlar wrote:
> If other storage systems are planned to be supported I think these should be tested as well. I ... Hynek Cihlar

08:14 AM Bug #2337: trigger scanning defect

After lots of failing tests I asked for Constantin's opinion and he confirmed that the update is safe for commit.
Lu... Ovidiu Maxiniuc

07/24/2014

08:23 AM Bug #2344: invalid scoping for dynamic buffers

... Stanislav Lomany

08:14 AM Bug #2344: invalid scoping for dynamic buffers

Dynamic buffers for permanent tables should have global scope.... Stanislav Lomany

07:45 AM Bug #2344 (Closed): invalid scoping for dynamic buffers

Stanislav Lomany

07/23/2014

08:57 AM Bug #2295: In Progress output parameters ignore decimal precision

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > * @display@ shows the decimal va... Hynek Cihlar

02:56 AM Bug #2295: In Progress output parameters ignore decimal precision

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> * @display@ shows the decimal value according to field's format d... Constantin Asofiei

07/22/2014

06:27 PM Bug #2295: In Progress output parameters ignore decimal precision

Constantin Asofiei wrote:
> Please try to find where the field's DECIMALS clause is forced: assign operator, buffer-... Hynek Cihlar

03:04 PM Bug #2295: In Progress output parameters ignore decimal precision

If other storage systems are planned to be supported I think these should be tested as well. I can imagine (and I act... Hynek Cihlar

07/21/2014

09:01 AM Bug #2295: In Progress output parameters ignore decimal precision

Hynek, please confirm that your test cases showing the unconstrained storage behavior work the same way on Progress 9... Eric Faulhaber

03:31 AM Bug #2295: In Progress output parameters ignore decimal precision

Hynek Cihlar wrote:
> What semantics @MAX-WIDTH@ holds anyway? I didn't find any useful documentation explaining the... Constantin Asofiei

07/20/2014

03:16 PM Bug #2295: In Progress output parameters ignore decimal precision

Constantin Asofiei wrote:
> OK, I think I understand what you mean now. What you need to test is this: change the ... Hynek Cihlar

08:02 AM Bug #2295: In Progress output parameters ignore decimal precision

Hynek Cihlar wrote:
> By @MAX-WIDTH@ did you mean the default number of decimal places, i.e. 10? The maximum number ... Constantin Asofiei

07/19/2014

07:49 PM Bug #2295: In Progress output parameters ignore decimal precision

Constantin Asofiei wrote:
> Please try to find where the field's DECIMALS clause is forced: assign operator, buffer-... Hynek Cihlar

05:03 AM Bug #2295: In Progress output parameters ignore decimal precision

Hynek Cihlar wrote:
> When the data is read into another buffer the buffer will still hold the unconstraint decimal ... Constantin Asofiei

07/18/2014

08:25 AM Bug #2295: In Progress output parameters ignore decimal precision

When the data is read into another buffer the buffer will still hold the unconstraint decimal value. I tried your sam... Hynek Cihlar

04:21 AM Bug #2295: In Progress output parameters ignore decimal precision

Hynek, please check the following too:
# what happens if the record (for which the field's decimals doesn't match th... Constantin Asofiei

07/17/2014

05:24 PM Bug #2295: In Progress output parameters ignore decimal precision

Greg Shah wrote:
> Please post the testcase(s) that you used to find this strange behavior. I'd like to see how appl... Hynek Cihlar

04:46 PM Bug #2295: In Progress output parameters ignore decimal precision

Please post the testcase(s) that you used to find this strange behavior. I'd like to see how applications might rely... Greg Shah

04:36 PM Bug #2295: In Progress output parameters ignore decimal precision

Constantin Asofiei wrote:
> Please double-check how this behaves with a physical table; use the p2j_test.df schema a... Hynek Cihlar

07/15/2014

02:24 PM Bug #2337: trigger scanning defect

There were no conversion differences (Except for the schema-triggers.xml file itself in src/aero/timco/majic/dmo).
T... Ovidiu Maxiniuc

10:32 PM Bug #2337: trigger scanning defect

Code review 0714a:
Looks good, please commit and distribute when this passes testing. Eric Faulhaber

07/14/2014

03:46 PM Bug #2337: trigger scanning defect

Attached the update that saves the @schema-trigger.xml@ to @src/{application path}/dmo@ directory to be further packa... Ovidiu Maxiniuc

02:16 PM Bug #2337: trigger scanning defect

Greg Shah wrote:
> ...we can always write a tool to generate the xml "cache" file from the annotations, such that it... Eric Faulhaber

10:56 AM Bug #2337: trigger scanning defect

In regard to the annotations vs xml file approach question, my preference is for the annotations approach. If the pe... Greg Shah

10:50 AM Bug #2337: trigger scanning defect

Code Review 0711a
I only reviewed the parser change. It looks good. Nice catch. Greg Shah

10:37 AM Bug #2337: trigger scanning defect

Greg: when Ovidiu posts the next update, would you please review the parser change? Eric Faulhaber

10:34 AM Bug #2337: trigger scanning defect

Let's keep all these alternatives in mind, but considering that it works well as is (I tested with the @schema-trigge... Eric Faulhaber

10:19 AM Bug #2337 (WIP): trigger scanning defect

I noticed that unintentionally I changed the status of this issue back to "Review". Reverted to WIP. Ovidiu Maxiniuc

07:15 AM Bug #2337 (Review): trigger scanning defect

I see tree solutions now, not sure which is the best:
1. the easiest would be to keep the current one, implemented i... Ovidiu Maxiniuc

03:22 PM Feature #2339: generate schema-triggers.xml from Java annotations at build time

Eric Faulhaber wrote:
> I understand @schema-triggers.xml@ is an artifact of conversion, and an intermediate form of... Ovidiu Maxiniuc

02:45 PM Feature #2339: generate schema-triggers.xml from Java annotations at build time

Eric Faulhaber wrote:
> ... and replacing the dots with slashes).
What I should have written was "... and replaci... Eric Faulhaber

02:42 PM Feature #2339: generate schema-triggers.xml from Java annotations at build time

Ovidiu Maxiniuc wrote:
> I was about to reply on 2337. I am not sure you understand the utility of @schema-triggers.... Eric Faulhaber

02:18 PM Feature #2339: generate schema-triggers.xml from Java annotations at build time

I was about to reply on 2337. I am not sure you understand the utility of @schema-triggers.xml@.
The xml file is c... Ovidiu Maxiniuc

02:10 PM Feature #2339: generate schema-triggers.xml from Java annotations at build time

See discussion in #2337, beginning at note 9, and particularly note 17.
The idea is to emit Java annotations relat... Eric Faulhaber

02:02 PM Feature #2339 (New): generate schema-triggers.xml from Java annotations at build time

Eric Faulhaber

07/13/2014

03:35 PM Bug #2295: In Progress output parameters ignore decimal precision

The case above from note 1 has been fixed by #2293. Hynek Cihlar

07/12/2014

06:27 PM Bug #2295 (WIP): In Progress output parameters ignore decimal precision

Hynek Cihlar

01:43 PM Bug #2337: trigger scanning defect

I converted the customer's server project. The @schema-triggers.xml@ file is left at the project root directory, but ... Eric Faulhaber

07/11/2014

03:35 PM Bug #2337 (WIP): trigger scanning defect

Code review 20140711a:
The only comment I have is about the change in approach when initializing the trigger manag... Eric Faulhaber

02:28 PM Bug #2337 (Review): trigger scanning defect

Uploaded fix for trigger issues:
- the @schema-trigger.xml@ improved in the second step
- @DatabaseTriggerManager@ ... Ovidiu Maxiniuc

11:32 AM Bug #2337: trigger scanning defect

Ah, OK. Sorry for the confusion I caused. Eric Faulhaber

11:30 AM Bug #2337: trigger scanning defect

I see, for the customer, @com/something/server/dmo@, it make more sense.
I was fooled by "directory's parent". I int... Ovidiu Maxiniuc

11:22 AM Bug #2337: trigger scanning defect

Ovidiu Maxiniuc wrote:
> I will add the rule for copying the file to @run/server@ and load it accordingly.
I foll... Eric Faulhaber

06:36 AM Bug #2337: trigger scanning defect

I found the cause why ASSIGNS are not converted correctly.
In the @progress.g@, in the @on_stmt@ function, the follo... Ovidiu Maxiniuc

05:00 AM Bug #2337: trigger scanning defect

Eric Faulhaber wrote:
> I would not add this to the root of the jar, if it is associated with a particular schema (@... Ovidiu Maxiniuc

07/10/2014

06:07 PM Bug #2337: trigger scanning defect

Ovidiu Maxiniuc wrote:
> Fixed the issue. It proved to be rather simple, just to add the class name (including packa... Eric Faulhaber

04:29 PM Bug #2337 (WIP): trigger scanning defect

Fixed the issue. It proved to be rather simple, just to add the class name (including package to current xml list of ... Ovidiu Maxiniuc

12:16 PM Bug #2337: trigger scanning defect

Because File.listFiles() does not work on jar locations, the initialization of the @DatabaseTriggerManager@ (gatherin... Ovidiu Maxiniuc

12:11 PM Bug #2337 (Closed): trigger scanning defect

Ovidiu Maxiniuc

07/09/2014

05:08 PM Bug #2336: TABLE-HANDLE FOR parameters for internal procedures

TABLE-HANDLE FOR parameters for internal procedures are not converted properly. @appserver-table-errors.p@ and @appse... Stanislav Lomany

05:04 PM Bug #2336 (New): TABLE-HANDLE FOR parameters for internal procedures

Stanislav Lomany