Project

General

Profile

Activity

From 08/01/2014 to 08/30/2014

08/31/2014

11:16 PM Support #2383: write an SQL script to verify all UDFs for built-in functions work once p2jpl.jar ...
The @p2jpl.jar@ contains a subset of the full P2J runtime classes. We recently found (in #2362) that one of the Progr... Eric Faulhaber
11:08 PM Support #2383 (New): write an SQL script to verify all UDFs for built-in functions work once p2jp...
Eric Faulhaber

08/29/2014

06:19 PM Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation
Some additional problems with @date@ type:
1) IllegalStateException at @DynamicTablesHelper:797@ (missed date and ...
Vadim Nebogatov

08/28/2014

05:44 PM Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation
Attached tests for different data types reproducing some errors.
@decimal, integer@
errors with different comb...
Vadim Nebogatov
12:14 PM Bug #2382 (New): Improve format string error handling in ADD-NEW-FIELD implementation
Vadim Nebogatov

08/21/2014

06:33 PM Feature #2220: dynamic query methods which require implementation
Rules from note 41 apply to multi-table queries as well. Stanislav Lomany

08/15/2014

04:03 PM Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
Test cases are checked in to testcases/uast/denormalization folder. Vadim Nebogatov
03:56 PM Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
Test @testcases/uast/denormalization/bulk3@:... Vadim Nebogatov
12:42 PM Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
Test @testcases/uast/denormalization/bulk2@:... Vadim Nebogatov
04:00 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Test cases are checked in to @testcases/uast/denormalization@ folder. Vadim Nebogatov

08/14/2014

05:03 PM Feature #2220: dynamic query methods which require implementation
>Please report the test cases you used to determine these rules and check them into the testcases project if you have... Stanislav Lomany
11:58 AM Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> I finally got caching rules for adaptive queries (single-table):
> # Cache is advanced in...
Eric Faulhaber
11:41 AM Feature #2220: dynamic query methods which require implementation
I finally got caching rules for adaptive queries (single-table):
# Cache is advanced in forward (if the first iterat...
Stanislav Lomany
04:26 PM Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
Thanks, Vadim. So, this tells us that we do not get a runtime error in Progress when invoking BUFFER-VALUE on an exte... Eric Faulhaber
04:02 PM Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
Test @testcases/uast/denormalization/bulk1@:... Vadim Nebogatov
12:28 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Ovidiu Maxiniuc wrote:
> The cause could be @(org.eclipse.jetty.util.component.AbstractLifeCycle:WARNING) FAILED Ser...
Eric Faulhaber
08:41 AM Bug #2222: WRITE event triggered too early
Code Review 0813a
I am fine with the changes.
Greg Shah

08/13/2014

05:52 PM Bug #2377 (New): default buffer can be incorrectly scoped to an internal procedure
Eric Faulhaber
05:47 PM Bug #2222: WRITE event triggered too early
The attached update fixes a defect which enabled write triggers to corrupt the @BlockManager@'s context-local state.
...
Eric Faulhaber
05:33 PM Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
There appears is a hole in our current implementation of custom, denormalized extent fields, in that we have eliminat... Eric Faulhaber
11:48 AM Feature #2376 (Test): retain bulk getter/setter methods for custom denormalized extent fields
Eric Faulhaber
04:35 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
The conversion test was successful, there are no changes in the ddl code, only the @.hbm.xml@ are affected: and extra... Ovidiu Maxiniuc

08/12/2014

04:01 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Code review 0811b:
> >
> > Looks good, but I have some questi...
Eric Faulhaber
03:03 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Eric Faulhaber wrote:
> Code review 0811b:
>
> Looks good, but I have some questions:
> * In the event there is ...
Ovidiu Maxiniuc
10:38 AM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Code review 0811b:
Looks good, but I have some questions:
* In the event there is no @sql-size@ hint (potentially...
Eric Faulhaber
10:40 AM Bug #2347: hql to SQL name mapping issue
Makes sense. So no need for a separate code review here. Once that update (0811a) is finished/tested, we can close ou... Eric Faulhaber
10:30 AM Bug #2347: hql to SQL name mapping issue
Yes, they are part of om_upd20140811a.zip (#2332).
It's hard for me to maintain them in separate updates, at some po...
Ovidiu Maxiniuc
10:22 AM Bug #2347: hql to SQL name mapping issue
Ovidiu, were the changes in this update rolled up into om_upd20140811a.zip (#2332)? Eric Faulhaber
08:44 AM Feature #2220: dynamic query methods which require implementation
Code review 0812a:
I think it looks OK, but this whole area of the code is tricky to assess with just a review. I'...
Eric Faulhaber
05:18 AM Feature #2220: dynamic query methods which require implementation
Fixes for testcases in notes 28 (not about flushing part, about PREV) and 34 (LAST issue). I didn't performed extensi... Stanislav Lomany

08/11/2014

05:12 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
I have finished merging the old update with bzr rev 10595. Please see the attached update.
My simple testcases were ...
Ovidiu Maxiniuc
09:03 AM Bug #2350 (Closed): BUFFER-COPY errors related with copying fields with extent
Eric Faulhaber
08:44 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
update [vmn_upd20140807a.zip] committed to bzr rev. 10595 and distributed. Vadim Nebogatov
07:45 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Please commit and distribute the 0807a update. Eric Faulhaber
05:30 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Regression completed: @tc_job_clock_002@ finally passed in 20140810_163259.
Vadim Nebogatov
02:09 AM Support #2371: trigger behavior
h1. Database Trigger Firing Rules
h2. General Sequence
Session triggers generally fire before schema triggers, EXCE...
Eric Faulhaber
12:28 AM Support #2371 (Closed): trigger behavior
Eric Faulhaber

08/10/2014

04:05 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Regression 20140810_120027: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat regression one ... Vadim Nebogatov

08/09/2014

06:42 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Regression 20140809_123827: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat regression one ... Vadim Nebogatov

08/08/2014

02:07 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Regression 20140808_092455: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat "main-regressio... Vadim Nebogatov

08/07/2014

06:15 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Regression 20140807_101619: failed tc_job_002, tc_job_clock_002, gso178_session1, gso178_session2, gso242_session1, g... Vadim Nebogatov

08/06/2014

06:05 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Corrected update vmn_upd20140807a.zip is attached. Tests still work properly, search API (#2353) also works.
Regres...
Vadim Nebogatov
03:41 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Code review 20140806b:
Line 2790 catches @ConditionException@ instead of @ErrorConditionException@, as I requested...
Eric Faulhaber
02:02 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Corrected update vmn_upd20140806b.zip is attached, test results for note 27 are like in Progress. Regression started. Vadim Nebogatov
10:13 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Code review 20140806a:
Please note the path of the source file in the zip archive is missing the leading @src/@ di...
Eric Faulhaber
10:07 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Your test results, where we are not returning a result for 2, 4, and 5 (while Progress returns false) tells me that w... Eric Faulhaber
09:09 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Please check attached @buffer-compare-pair-list.p@. Execution results:
h3. Progress...
Vadim Nebogatov
09:08 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Code review 20140805a:
* As noted above, the @if@ condition at line 3662 should drop the BUFFER-COMPARE-specific p...
Eric Faulhaber
08:29 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Yes, it looks like that length restriction is wrong; I'm not sur...
Eric Faulhaber
12:32 PM Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> Found this in AdaptiveQuery javadoc:
> [...]
Yes, I wrote that. All such cases are con...
Eric Faulhaber
12:07 PM Feature #2220: dynamic query methods which require implementation
Found this in AdaptiveQuery javadoc:... Stanislav Lomany

08/05/2014

05:48 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
I have attached next update vmn_upd20140805a.zip tested with @#2353@ and @buffer-copy-pair-list.p@ from note 18. Both... Vadim Nebogatov
04:09 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
I just noticed that message ... Vadim Nebogatov
01:33 PM Feature #2359: automated maintenance of database support files
Current implementation of custom functions exposed in SQL queries uses some additional files that, even if they rarel... Ovidiu Maxiniuc
01:18 PM Feature #2359 (New): automated maintenance of database support files
Ovidiu Maxiniuc
01:14 PM Feature #2358: HQLPreprocessor and dialect specific functions
At this moment @HQLPreprocessor@ must preprocess the HQL code depending on the dialect.
The @rtrim@ function is rep...
Ovidiu Maxiniuc
01:03 PM Feature #2358 (WIP): HQLPreprocessor and dialect specific functions
Ovidiu Maxiniuc

08/04/2014

07:11 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
[ECF: moved content of this note to #2353, note 13] Vadim Nebogatov
11:12 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Eric Faulhaber wrote:
> Yes, it looks like that length restriction is wrong; I'm not sure why I came up with that.
...
Vadim Nebogatov
10:42 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Vadim Nebogatov wrote:
> Condition RecordBuffer, 3661
>
> ...
Eric Faulhaber
10:58 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Code review 20140803a:
It seems this code will work, but I'm wondering about some choices:
* By adding @getSize@ ...
Eric Faulhaber
08:55 AM Feature #2220: dynamic query methods which require implementation
While working on the LAST issue, I've looked into invalidation logic for adaptive queries. I think it's a bit doubtfu... Stanislav Lomany

08/03/2014

06:17 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Condition RecordBuffer, 3661... Vadim Nebogatov
07:27 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
I have attached update vmn_upd20140803a.zip with fixes issues from Eric review and fix from Stas. Vadim Nebogatov

08/02/2014

10:05 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Eric Faulhaber wrote:
> I noticed you prepended @opType == OperationType.COPY &...@ to the @if@ condition at line 38...
Vadim Nebogatov
09:24 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Code review 20140802a:
Please log a warning inside the catch block at line 3829, rather than eating the exception....
Eric Faulhaber
08:19 AM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Attached vmn_upd20140802a.zip with corrections according review (note 13) merged with latest bzr revision 10592. Vadim Nebogatov

08/01/2014

06:34 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
Code review 20140801a:
* The use of @TempTableBuilder.getExtentSize@ at lines 3812 and 3814 does not look correct....
Eric Faulhaber
04:52 PM Bug #2350: BUFFER-COPY errors related with copying fields with extent
vmn_upd20140729a.zip merged with latest bzr revision 10591 to vmn_upd20140801a.zip. Vadim Nebogatov
04:51 PM Feature #2220: dynamic query methods which require implementation
OK, but that doesn't look like a flushing issue to me, so I guess we will stay out of each others' way on this one. Eric Faulhaber
04:44 PM Feature #2220: dynamic query methods which require implementation
This issue I have to fix. LAST just do not work for adaptive queries.... Stanislav Lomany
03:55 PM Feature #2220: dynamic query methods which require implementation
No problem about having this issue. I just need to consider it when making testcases. Stanislav Lomany
03:24 PM Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> BTW, P2J includes records in both PREV cases.
I am working on a flush/validate fix that I...
Eric Faulhaber
03:19 PM Feature #2220: dynamic query methods which require implementation
You are right - it is about flushing.
>Are you saying they both include the 0 record or they both exclude it?
Inc...
Stanislav Lomany
03:08 PM Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> There is no difference in testcases output if the queries are iterated in the forward dire...
Eric Faulhaber
03:06 PM Feature #2220: dynamic query methods which require implementation
I think what's happening here is that nothing is releasing/flushing the newly created record from buffer @xtt@ before... Eric Faulhaber
02:51 PM Feature #2220: dynamic query methods which require implementation
Strange case. Testcase 1:... Stanislav Lomany
10:12 AM Feature #2220: dynamic query methods which require implementation
BTW, there is an issue with dynamic queries you probably aware of. Creation of a record using a backing buffer of a d... Stanislav Lomany
12:46 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Code review 20140408a:
Changes look good. Unfortunately (my fault), the update is now way out of date with the lat...
Eric Faulhaber
09:59 AM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Eric Faulhaber wrote:
> Sorry I lost track of this. Does this update need separate review, or have these changes bee...
Ovidiu Maxiniuc
09:53 AM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Ovidiu Maxiniuc wrote:
> Reuploaded the update after merging with latest bzr revision (10506).
Sorry I lost track o...
Eric Faulhaber
10:20 AM Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...
Eric Faulhaber wrote:
> What is the status of the issues described in and the update attached to note 4? This effort...
Ovidiu Maxiniuc
09:50 AM Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...
What is the status of the issues described in and the update attached to note 4? This effort seems to have merged wit... Eric Faulhaber
 

Also available in: Atom