FWD » Core Development » Database

02/13/2015

02:32 PM Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods

Alternative working form for ... Ovidiu Maxiniuc

07:46 AM Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods

The set of get{First|Next|Last|Previous} methods should return:
* @?@ (unknown) if the query object handle is invali... Ovidiu Maxiniuc

07:38 AM Bug #2514 (Closed): incorrect return values for get{First|Next|Last|Previous} methods

Ovidiu Maxiniuc

02/11/2015

06:56 AM Bug #2488: replace runtime compilation of dynamic queries

The problem reported in note-62 is fixed by adding the @methods_attributes.rules@ to runtime conversion. With this oc... Ovidiu Maxiniuc

02/10/2015

02:41 PM Bug #2488: replace runtime compilation of dynamic queries

The attached update should handle the @WhereExpressions@.
There are a few other issues that must be solved first:
*... Ovidiu Maxiniuc

02:07 PM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> At a glance, yes, that looks wrong. Have you converted the static form of the same query? Thi... Ovidiu Maxiniuc

01:57 PM Bug #2488: replace runtime compilation of dynamic queries

At a glance, yes, that looks wrong. Have you converted the static form of the same query? This will tell you if the p... Eric Faulhaber

01:52 PM Bug #2488: replace runtime compilation of dynamic queries

Eric,
I almost finished implementing support for 'extending' and interpreting the client-side @WhereExpression@ but ... Ovidiu Maxiniuc

02/09/2015

02:16 PM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> If we cannot come up with a single test case which would result in client-side where clause ... Ovidiu Maxiniuc

01:25 PM Bug #2488: replace runtime compilation of dynamic queries

IIRC the point is that there can be multiple dynamic buffers with the same name in the same scope and some P2J struct... Stanislav Lomany

01:13 PM Bug #2488: replace runtime compilation of dynamic queries

Stanislav Lomany wrote:
> Eric, are you basically asking why suffixes are added to the names of dynamic buffers?
Ye... Eric Faulhaber

01:08 PM Bug #2488: replace runtime compilation of dynamic queries

Eric, are you basically asking why suffixes are added to the names of dynamic buffers? Stanislav Lomany

12:17 PM Bug #2488: replace runtime compilation of dynamic queries

Stanislav, I don't fully understand the following comment, from @DynamicQueryHelper@:763:... Eric Faulhaber

10:36 AM Bug #2488: replace runtime compilation of dynamic queries

If we cannot come up with a single test case which would result in client-side where clause processing (all so far se... Eric Faulhaber

09:24 AM Bug #2488: replace runtime compilation of dynamic queries

Regarding the user-defined functions. I was thinking too ahead. At this moment the @ProgressParser@ cannot handle UDF... Ovidiu Maxiniuc

08:25 AM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> The result of this evaluation would be fed into an adapter subclass of the @WhereExpression@... Ovidiu Maxiniuc

04:15 AM Bug #2488: replace runtime compilation of dynamic queries

Eric,
I tried such constructs on windev01.
*CAN-FIND*: P2J parses and successfully converts them in java code, ... Ovidiu Maxiniuc

02/07/2015

11:38 PM Bug #2488: replace runtime compilation of dynamic queries

Each OPEN QUERY in the following test case (@client-where-simple.p@) will force client-side where clause processing:
... Eric Faulhaber

07:03 PM Bug #2488: replace runtime compilation of dynamic queries

The regression test was successful. Please commit and distribute the update. Eric Faulhaber

02/06/2015

04:15 PM Bug #2488: replace runtime compilation of dynamic queries

The conversion test was successful. There are no differences in the generated code with the attached update. Ovidiu Maxiniuc

02:07 PM Bug #2488: replace runtime compilation of dynamic queries

> The best alternative is to use your solution from note 43 and rename the new method to @putAnnotationObject()@ so t... Eric Faulhaber

02:00 PM Bug #2488: replace runtime compilation of dynamic queries

Eric,
The last updates fail to convert the majic sources. The reason is the @putAnnotation()@ method. Although I use... Ovidiu Maxiniuc

12:38 PM Bug #2488: replace runtime compilation of dynamic queries

Thanks, Ovidiu. Please post your conversion results when that's done. I'll run my tests later today or overnight. Eric Faulhaber

07:31 AM Bug #2488: replace runtime compilation of dynamic queries

> * Why did you indent build.xml:265?
There were some TABs characters in that file that I replaced with plain spaces... Ovidiu Maxiniuc

11:03 PM Bug #2488: replace runtime compilation of dynamic queries

Code review 0205a:
* Please put back the indent at @DynamicQueryHelper@:101.
* I think the logging levels used in... Eric Faulhaber

02/05/2015

03:05 PM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> Before I write up the code review, I need a definitive answer on the client-side where claus... Ovidiu Maxiniuc

01:01 AM Bug #2488: replace runtime compilation of dynamic queries

Before I write up the code review, I need a definitive answer on the client-side where clause processing question in ... Eric Faulhaber

11:16 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Update that excludes temporary table fields from denormalization process. Committed to bzr revision 10743. Stanislav Lomany

01/29/2015

02:46 PM Bug #2488: replace runtime compilation of dynamic queries

This update fixes the copy/paste bug revealed by issues #2500 and #2501. Ovidiu Maxiniuc

01/28/2015

04:21 PM Bug #2488 (WIP): replace runtime compilation of dynamic queries

Added 'dumb' cache implementation and some additional fixes. Ovidiu Maxiniuc

01/26/2015

03:14 AM Bug #2488: replace runtime compilation of dynamic queries

Eric,
If you did not started the review, please find attached an update that adds the missing javadocs to @RuntimeJa... Ovidiu Maxiniuc

01/23/2015

09:29 AM Bug #2488: replace runtime compilation of dynamic queries

Greg, you are right.
We do parse the initial query using the @progress.g@ (@ProgressParser@ from the code in note ... Ovidiu Maxiniuc

08:58 AM Bug #2488: replace runtime compilation of dynamic queries

When I refer to the Progress AST, I mean the original AST that is first created for the provided expression in a @QUE... Greg Shah

08:55 AM Bug #2488: replace runtime compilation of dynamic queries

A few thoughts on the caching:
I agree with Greg that the Progress AST will be much more reliable. However, it is ... Eric Faulhaber

08:53 AM Bug #2488: replace runtime compilation of dynamic queries

Not sure I understand. Of course, the trees will be the except for the string value at some point. But later, during ... Ovidiu Maxiniuc

08:26 AM Bug #2488: replace runtime compilation of dynamic queries

> and realize that they are the same ?
Don't forget that in the Progress AST the tree structure is in fact:
* ... Greg Shah

05:01 AM Bug #2488: replace runtime compilation of dynamic queries

I analyzed the logs with the queries from #1868. Here are some results/thoughts:
* there are ~5500 @FIND FIRST@ of w... Ovidiu Maxiniuc

01/22/2015

04:56 PM Bug #2488: replace runtime compilation of dynamic queries

Uploaded update for review, together a file with my important testcases.
* I tried to detect as much as possible i... Ovidiu Maxiniuc

06:02 AM Bug #2488: replace runtime compilation of dynamic queries

After I got satisfactory results with simpler queries, I started to increase the complexity of the dynamic queries in... Ovidiu Maxiniuc

03:38 PM Bug #2496: Static conversion of legacy field names does not preserve original case

Legacy field names annotations for static conversion are now in low case. TableMapper seems works properly, also ther... Vadim Nebogatov

03:07 PM Bug #2496 (New): Static conversion of legacy field names does not preserve original case

Vadim Nebogatov

01/21/2015

10:28 AM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> Don't we convert these kinds of expressions into HQL today, using PL/Java UDFs to represent ... Ovidiu Maxiniuc

10:27 AM Bug #2488: replace runtime compilation of dynamic queries

Ovidiu Maxiniuc wrote:
> On the other hand, if we do to many semantic annotations, the tree will grow - and the mana... Eric Faulhaber

10:19 AM Bug #2488: replace runtime compilation of dynamic queries

Ovidiu Maxiniuc wrote:
> The static call is emitted, relying on java compiler to resolve the actual method to be inv... Eric Faulhaber

02:58 AM Bug #2488: replace runtime compilation of dynamic queries

This is true, we don't do the constant expression evaluation at this moment neither in static conversion but it would... Ovidiu Maxiniuc

01/20/2015

04:36 PM Bug #2488: replace runtime compilation of dynamic queries

Certainly static expressions will be more efficient to convert, execute, and store at conversion. I'm pretty sure we ... Eric Faulhaber

03:55 PM Bug #2488: replace runtime compilation of dynamic queries

> Don't abandon it just yet...it will not need to do as much as it does now, but this is a good candidate to morph in... Ovidiu Maxiniuc

08:08 PM Bug #2488: replace runtime compilation of dynamic queries

Ovidiu Maxiniuc wrote:
> Attached you can find a first version of 'runtime/interpret_find_query.xml'. It only handle... Eric Faulhaber

01/19/2015

02:36 PM Bug #2488: replace runtime compilation of dynamic queries

Attached you can find a first version of 'runtime/interpret_find_query.xml'. It only handles the simple @find-query@ ... Ovidiu Maxiniuc

08:07 PM Bug #2488: replace runtime compilation of dynamic queries

Ovidiu Maxiniuc wrote:
> If you have the chance to re-run it, please add the string @predicate@ before and, to simpl... Eric Faulhaber

01/17/2015

05:27 PM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote (from Constantin's email):
> The problem here is that at conversion-time the SchemaDictionary (... Eric Faulhaber

01/16/2015

05:46 PM Bug #2488: replace runtime compilation of dynamic queries

BTW, we have implemented a lot of constructor and method matching support already for TRPL itself. Perhaps we can lev... Eric Faulhaber

05:37 PM Bug #2488: replace runtime compilation of dynamic queries

I've taken a look at the code so far and it is a great start! Yes, I agree that the final tree is simpler to deal wit... Eric Faulhaber

03:55 PM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> Sure, I can do that, but are you certain you want to use the current, final version of the J... Ovidiu Maxiniuc

03:41 PM Bug #2488: replace runtime compilation of dynamic queries

Ovidiu Maxiniuc wrote:
> I did some researches on windev01. Progress is not very permissive. The static statements c... Eric Faulhaber

03:30 PM Bug #2488: replace runtime compilation of dynamic queries

Related to the @createAlias@ topic, here's an email exchange I had with Constantin recently:
> Eric,
>
> The prob... Eric Faulhaber

03:28 PM Bug #2488: replace runtime compilation of dynamic queries

> The text of the error message suggests you are passing the same parameter (@dictdb@) for both the @alias@ and @ldbN... Ovidiu Maxiniuc

02:38 PM Bug #2488: replace runtime compilation of dynamic queries

While I am excited that you've begun implementing a solution, I'm curious whether you've found the answers to the que... Eric Faulhaber

02:31 PM Bug #2488: replace runtime compilation of dynamic queries

Ovidiu Maxiniuc wrote:
> I started implementing a small 'interpreting' engine, targeting only the required node/item... Eric Faulhaber

02:25 PM Bug #2488: replace runtime compilation of dynamic queries

I started implementing a small 'interpreting' engine, targeting only the required node/items. In fact at this time, t... Ovidiu Maxiniuc