FWD » Core Development » Database

03/24/2015

07:24 PM Bug #2536: improve dynamic query parser error handling

Code review 0324b:
Looks fine. If you have tested successfully locally, please commit and distribute. There is no ... Eric Faulhaber

03:16 PM Bug #2536: improve dynamic query parser error handling

The attached update prepares the @ProgressParser@ to throw the exception when the syntax of the processed string is n... Ovidiu Maxiniuc

08:27 AM Bug #2536: improve dynamic query parser error handling

See @setConsumeError()@ and @reportError()@ in @progress.g@. Greg Shah

02:33 AM Bug #2536: improve dynamic query parser error handling

Currently, when the P2J Progress parser encounters unexpected tokens during runtime query conversion due to invalid i... Eric Faulhaber

02:26 AM Bug #2536 (New): improve dynamic query parser error handling

Eric Faulhaber

11:03 AM Bug #2488: replace runtime compilation of dynamic queries

Ovidiu Maxiniuc wrote:
> > What testing have you done with this update applied?
> See #2535, my note 10. There are ... Eric Faulhaber

10:44 AM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> Code review 0318a:
>
> Looks good, noticed one typo on line 1121: "...some king of expres... Ovidiu Maxiniuc

10:28 AM Bug #2488: replace runtime compilation of dynamic queries

Code review 0318a:
Looks good, noticed one typo on line 1121: "...some king of expression..."
What testing have... Eric Faulhaber

10:24 AM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> Code review 0306a:
>
> Looks good. I'll run tests with this update and let you know how i... Eric Faulhaber

10:21 AM Bug #2524 (Closed): missing support for NEXT-SIBLING attribute for buffer handles

Eric Faulhaber

08:54 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

The update passed the regression testing. It was merged with bzr repo' and then committed back as revision 10820. It ... Ovidiu Maxiniuc

03/22/2015

11:21 PM Bug #2535 (Closed): enhancing datatype conversion functions

Eric Faulhaber

03/18/2015

01:23 PM Bug #2488: replace runtime compilation of dynamic queries

The update adds @DateExpression@ and @IntegerExpression@ implementation. They might be needed in dynamic queries. Ovidiu Maxiniuc

09:57 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

The first run of testing returned success for ctr+c and a few issues for main.
I'm giving it a second chance: resta... Ovidiu Maxiniuc

06:03 AM Bug #2535: enhancing datatype conversion functions

Update committed to bzr as revno 10815 and distributed by mail. Ovidiu Maxiniuc

03/17/2015

02:27 PM Bug #2535: enhancing datatype conversion functions

Please commit and distribute the update. Eric Faulhaber

11:13 AM Bug #2535: enhancing datatype conversion functions

I guess after the second run, update passed the test. Ovidiu Maxiniuc

03/16/2015

02:48 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Constantin Asofiei wrote:
> Only issue I see is that you have this @System.out.println("\tInterlinking BUFFER " + pe... Ovidiu Maxiniuc

02:35 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Ovidiu Maxiniuc wrote:
> Constantin, please review the attached update.
Only issue I see is that you have this @S... Constantin Asofiei

11:12 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Constantin, please review the attached update. Ovidiu Maxiniuc

02:42 PM Bug #2535: enhancing datatype conversion functions

I guess the om_upd20150313b.zip update passed the regression testing. There were a few issues though:
* in CTRL+C th... Ovidiu Maxiniuc

03/13/2015

05:53 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Eric Faulhaber wrote:
> Code review 0313a:
>
> * The change to @RecordBuffer.getLDBName@ is OK to leave, but it w... Ovidiu Maxiniuc

04:46 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Code review 0313a:
* The change to @RecordBuffer.getLDBName@ is OK to leave, but it will necessitate runtime regre... Eric Faulhaber

04:23 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

The attached update is based on 10810 revision from bzr.
The @interlink@ method specialized in @BufferImpl@ will han... Ovidiu Maxiniuc

03:25 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Ovidiu, please merge the 0303c update up to the latest revision of P2J. Eric Faulhaber

05:48 PM Bug #2535: enhancing datatype conversion functions

Code review 0313b:
Just thought of one edge case which might be problematic: consider a WHERE clause with a singl... Eric Faulhaber

05:33 PM Bug #2535: enhancing datatype conversion functions

Logic that was incorrectly placed in @index_select.rules@ moved to @where_clause_prep.rules@. Ovidiu Maxiniuc

03:56 PM Bug #2535: enhancing datatype conversion functions

Code review 0311a:
> I am not sure I wrote the function call annotation in the right place (@index_selection.rules@) ... Eric Faulhaber

03/11/2015

02:56 PM Bug #2535: enhancing datatype conversion functions

With the attached update, queries like:... Ovidiu Maxiniuc

10:45 AM Bug #2535: enhancing datatype conversion functions

Yes, this is correct, the new constructors are not really needed.
I checked all datatypes classes and they all have... Ovidiu Maxiniuc

03/10/2015

03:28 PM Bug #2535: enhancing datatype conversion functions

Ovidiu Maxiniuc wrote:
> I guess we should keep the new constructor and replace the return line like:
> ... Eric Faulhaber

02:53 PM Bug #2535: enhancing datatype conversion functions

The generated @evaluate@ method for @WhereExpression@ @whereExpr0@ looks currently like this:... Ovidiu Maxiniuc

02:39 PM Bug #2535: enhancing datatype conversion functions

You are right: we don't want to mask this error always, because there may be times when it represents a legitimate er... Eric Faulhaber

01:35 PM Bug #2535: enhancing datatype conversion functions

Eric,
I have an issue regarding the implementation of these methods. At first I implemented as simple as this:
<... Ovidiu Maxiniuc

11:57 AM Bug #2535: enhancing datatype conversion functions

I just discovered that we don't cover all the conversions between datatypes. We need to implement additional construc... Ovidiu Maxiniuc

11:34 AM Bug #2535 (Closed): enhancing datatype conversion functions

Ovidiu Maxiniuc

03/06/2015

05:56 PM Bug #2488: replace runtime compilation of dynamic queries

Code review 0306a:
Looks good. I'll run tests with this update and let you know how it goes. Eric Faulhaber

01:31 PM Bug #2488: replace runtime compilation of dynamic queries

The strings literals are generated as ready-to-be-written to java source files and the escape sequences must be proce... Ovidiu Maxiniuc

03/04/2015

06:45 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, about HandleChain changes: the buffer-specific code ... Constantin Asofiei

05:43 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Constantin Asofiei wrote:
> Ovidiu, about HandleChain changes: the buffer-specific code I think should reside in ove... Ovidiu Maxiniuc

05:37 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Ovidiu, about HandleChain changes: the buffer-specific code I think should reside in overridden methods in the Buffer... Constantin Asofiei

05:17 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Eric Faulhaber wrote:
> Ovidiu: please rename the testcase to something more descriptive (you can keep "2524" as par... Ovidiu Maxiniuc

03/03/2015

05:28 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

One more thing: please make the @BufferImpl@ constructor you added @protected@ instead of @public@. As an implementat... Eric Faulhaber

03:29 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

Code review 0303c:
You added a call to @release()@ at @TemporaryBuffer@:3411, which seems unrelated to the remaini... Eric Faulhaber

12:26 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

The attached update fixes the management of dynamic buffer handles. Ovidiu Maxiniuc

11:55 AM Bug #2533 (WIP): management of dynamic buffer handles

Ovidiu Maxiniuc

02/27/2015

08:37 AM Bug #2526: Records preserving its position in the sorting index for adaptive query

As for initial analysis: currently we use record snapshots as the base to find the next record in the index using an ... Stanislav Lomany

08:28 AM Bug #2526: Records preserving its position in the sorting index for adaptive query

This problem was noticed in an editable browse which easily exposes this bug. Assigning a value to a field of the ind... Stanislav Lomany

08:17 AM Bug #2526 (New): Records preserving its position in the sorting index for adaptive query

Stanislav Lomany

02/26/2015

12:49 PM Bug #2488: replace runtime compilation of dynamic queries

I found a test case that fails to convert properly.... Ovidiu Maxiniuc

02/25/2015

03:53 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

The reference pdf states that the SESSION:FIRST-BUFFER is the head of the linked list of _"handles for the dynamic bu... Ovidiu Maxiniuc

02/24/2015

03:14 PM Bug #2524 (WIP): missing support for NEXT-SIBLING attribute for buffer handles

Ovidiu Maxiniuc

03:11 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles

I noticed the following message printed in the app-server 'client' log after each executed request.... Ovidiu Maxiniuc

02:44 PM Bug #2524 (Closed): missing support for NEXT-SIBLING attribute for buffer handles

Ovidiu Maxiniuc