FWD » Core Development » Database

05/20/2015

12:42 PM Bug #2536: improve dynamic query parser error handling

Code review 0519a:
I'm glad you made this change, I was going to ask for something like it. After you made the err... Eric Faulhaber

05/19/2015

03:37 AM Bug #2536: improve dynamic query parser error handling

I added a few changes to @DynamicQueryHelper@ that refine the messages printed in console. At this moment the log is ... Ovidiu Maxiniuc

05/18/2015

03:53 PM Bug #2536: improve dynamic query parser error handling

Is there anything left to do on this issue at this point, or can it be closed? Eric Faulhaber

03:51 PM Bug #2577: extent information in meta table

Ovidiu Maxiniuc wrote:
> I've just checked the @custom-extent@ support. As you thought, it doesn't work. The @messag... Eric Faulhaber

03:16 PM Bug #2577: extent information in meta table

Committed to bzr as revno 10865.
I've just checked the @custom-extent@ support. As you thought, it doesn't work. T... Ovidiu Maxiniuc

02:10 PM Bug #2577: extent information in meta table

Code review 0518b:
The fix looks fine. Please check it in as is, no regression testing needed (it is additive and ... Eric Faulhaber

12:54 PM Bug #2577: extent information in meta table

I discovered that the extent information is missing in the field meta table (it's always @0@). This causes some testc... Ovidiu Maxiniuc

12:38 PM Bug #2577 (Closed): extent information in meta table

Ovidiu Maxiniuc

05/12/2015

01:53 PM Bug #2488: replace runtime compilation of dynamic queries

Eric Faulhaber wrote:
> Code review 0512a:
>
> The change looks good. If it fixes your problem locally, please co... Ovidiu Maxiniuc

12:37 PM Bug #2488: replace runtime compilation of dynamic queries

Code review 0512a:
The change looks good. If it fixes your problem locally, please commit and distribute, since re... Eric Faulhaber

11:47 AM Bug #2488: replace runtime compilation of dynamic queries

The attached update allows variables to be declared and initialized in the dynamically constructed object. They were ... Ovidiu Maxiniuc

05/09/2015

12:53 PM Bug #2570 (Closed): buffers must be members of the class which defines their tightest scope

The attached fix resolves the original problem and the items in notes 6-8. It has passed regression testing and is co... Eric Faulhaber

05/07/2015

03:18 AM Bug #2570: buffers must be members of the class which defines their tightest scope

The third item in note 6 was actually a more serious latent bug than I thought. Buffer name conflict resolution was g... Eric Faulhaber

05/06/2015

01:25 PM Bug #2570: buffers must be members of the class which defines their tightest scope

> With my update, it doesn't compile.
Congrats! You made it more correct. :) Greg Shah

01:22 PM Bug #2570: buffers must be members of the class which defines their tightest scope

The types of failures I'm seeing:
* A buffer which previously was a top-level instance variable is referenced in a... Eric Faulhaber

12:31 PM Bug #2570: buffers must be members of the class which defines their tightest scope

Greg Shah wrote:
> Code Review ecf_upd20150506a.zip
>
> I don't see much in the way of problems. Where there man... Eric Faulhaber

10:04 AM Bug #2570: buffers must be members of the class which defines their tightest scope

Code Review ecf_upd20150506a.zip
I don't see much in the way of problems. Where there many changes to the MAJIC c... Greg Shah

03:58 AM Bug #2570: buffers must be members of the class which defines their tightest scope

I've decided to defer the name conflict improvements indefinitely, as it turns out there's a lot of potential breakag... Eric Faulhaber

05/05/2015

04:17 PM Bug #2570: buffers must be members of the class which defines their tightest scope

There were regressions with naming conflicts. Working on a fix. Eric Faulhaber

12:10 PM Bug #2570: buffers must be members of the class which defines their tightest scope

P2J incorrectly creates all record buffers as instance members of the top level class. Buffers scoped more tightly th... Eric Faulhaber

11:46 AM Bug #2570 (Closed): buffers must be members of the class which defines their tightest scope

Eric Faulhaber

05/02/2015

12:42 AM Bug #2568: Possibly wrong default column label value

P2J returns an empty string if a label or column label is not specified, so it is not clear how distinguish cases whe... Stanislav Lomany

12:36 AM Bug #2568 (New): Possibly wrong default column label value

Stanislav Lomany

04/30/2015

05:21 AM Bug #2562: record updated in a side buffer is not included in query result list

Testcase: ... Stanislav Lomany

05:19 AM Bug #2562 (New): record updated in a side buffer is not included in query result list

Stanislav Lomany

02:26 AM Bug #2561: invalid DEFAULT-BUFFER-HANDLE if a secondary buffer is initialized prior to default bu...

Testcase:... Stanislav Lomany

02:24 AM Bug #2561 (New): invalid DEFAULT-BUFFER-HANDLE if a secondary buffer is initialized prior to defa...

Stanislav Lomany

04/29/2015

11:50 PM Feature #2551 (Closed): replace runtime compilation of DMOs with ASM bytecode implementation

The attached update implements this feature. It passed regression testing and was committed to bzr rev. 10842.
Whe... Eric Faulhaber

04/25/2015

11:38 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

It is difficult to review the 0422a update, because it is built on top of the 0421a update. Since we know we're not k... Eric Faulhaber

04/22/2015

02:23 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

See #1868, note 51 for the primary key search test results with and without the 0421a update. There are 33 new failur... Eric Faulhaber

02:16 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

> Let's not take this on if we don't have to. If your form works and doesn't cause a significant performance penalty,... Ovidiu Maxiniuc

02:13 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

Ovidiu Maxiniuc wrote:
> As you can see there is a big failure to properly convert it. An educated guess is that we ... Eric Faulhaber

02:09 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

> Doesn't this simplify to the following?
> @(B != A) or (B is null != A is null)@
>
> Is that valid HQL/SQL? If ... Ovidiu Maxiniuc

01:45 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

Ovidiu Maxiniuc wrote:
> I am really sorry I broke your test results. My tests were quite focused on the task, I did... Eric Faulhaber

01:35 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

Ovidiu Maxiniuc wrote:
I haven't reviewed the update yet, but to respond to one of your items...
> The most com... Eric Faulhaber

01:23 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

> Yes, I tested this update with the passing and failing tests overnight and it went badly (did not finish, lots of t... Ovidiu Maxiniuc

01:14 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Code review 0421a:
> >
> > Looks good, please regression test... Eric Faulhaber

01:04 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

Eric Faulhaber wrote:
> Code review 0421a:
>
> Looks good, please regression test. It seems the change to the @Co... Ovidiu Maxiniuc

01:00 PM Bug #2552: bad hql caching prevents queries to position on the correct rows

Eric Faulhaber wrote:
> Agreed, we should try this. Hopefully, the @or@ in the where clause does not cause a perform... Ovidiu Maxiniuc

01:44 PM Bug #2554: Temp-tables with different labels / column labels are converted to the same TempRecord...

Conversion bug - two temp-tables with different labels / column labels are converted to the same @TempRecord@ class. ... Stanislav Lomany

01:41 PM Bug #2554 (New): Temp-tables with different labels / column labels are converted to the same Temp...

Stanislav Lomany