Activity
From 04/01/2019 to 04/30/2019
04/23/2019
- 01:17 PM Feature #3809: ProDataSet support
- 3809a was merged to trunk as r11304. Fresh new 3809c was created for following changes on this task.
- 11:47 AM Feature #3809: ProDataSet support
- Greg Shah wrote:
> To be safe, please put this back through conversion regression testing. If it passes for the ChU... - 09:53 AM Feature #3809: ProDataSet support
- Ovidiu Maxiniuc wrote:
> Eric, what do you say?
Yes, I like this better. - 09:40 AM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> Ovidiu, there is a regression in 3809a: you've added the @kw_cpy_ttbl@ to the top @load_... - 02:43 AM Feature #3809: ProDataSet support
- Ovidiu, there is a regression in 3809a: you've added the @kw_cpy_ttbl@ to the top @load_descriptors@ function, and th...
04/22/2019
- 07:56 AM Feature #3816: table and table handle parameter options
- Please document the specific questions we have that will require 4GL testcases. I don't know if we will be able to g...
- 07:51 AM Feature #3816: table and table handle parameter options
- 3809a contains some changes that implement dataset parameters. This will be merged to trunk shortly. As part of thi...
- 07:48 AM Feature #3815: more temp-table options
- > BEFORE-TABLE
Isn't this going to be handled as part of the work for #3809? - 02:46 AM Feature #3809: ProDataSet support
- Ovidiu, please rebase 3809a.
04/19/2019
- 04:55 PM Feature #3809: ProDataSet support
- Code Review Task Branch 3809a Revision 11316
I'm good with the changes. Constantin will include the @Preprocessor... - 04:44 PM Feature #3809: ProDataSet support
- The revision 11316 adds some new runtime support. It passed the DataSet Test Suite conversion test.
- 03:38 PM Feature #3809: ProDataSet support
- Greg Shah wrote:
> Code Review Task Branch 3809a Revision 11315
> 2. I think the gap marking needs to be updated wi... - 03:34 PM Feature #3809: ProDataSet support
- Greg Shah wrote:
> 1. Constantin: In regard to the @Preprocessor@ change:
>
> * Does this resolve #3846 (I assume... - 03:30 PM Feature #3809: ProDataSet support
- Code Review Task Branch 3809a Revision 11315
Generally, I'm good with this code. Some small items are below.
1... - 02:38 PM Feature #3809: ProDataSet support
- Thanks, Ovidiu - 3809a rev 11315 fixes my case for the OO method calls.
- 01:32 PM Feature #3809: ProDataSet support
- Sorry,
After my first reply I double checked the branch. I forgot to merge in the TRPL changes :(. Please update to... - 01:29 PM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> Ovidiu, I assume the conversion rules for dataset as function call argument are still WI... - 01:26 PM Feature #3809: ProDataSet support
- Ovidiu, I assume the conversion rules for dataset as function call argument are still WIP?
- 09:13 AM Feature #3809: ProDataSet support
- A bit later than expected I have the solution for @append@ and/or @by-reference@ datasets.
I tried to use the same c...
04/18/2019
- 05:19 PM Feature #3809: ProDataSet support
- Ovidiu: How long do you expect the parameter support changes to take? It may make sense to hold 3809a for those chan...
- 05:15 PM Feature #3809: ProDataSet support
- Greg Shah wrote:
> Constantin: Is it OK to deal with #3809-70 in another branch? Or will that cause us other issues... - 05:10 PM Feature #3809: ProDataSet support
- I'm inclined to get this merged to trunk.
Constantin: Is it OK to deal with #3809-70 in another branch? Or will t... - 02:56 PM Feature #3809: ProDataSet support
- Greg Shah wrote:
> Is there enough runtime change to make runtime regression testing useful?
I think not. I summary... - 02:36 PM Feature #3809: ProDataSet support
- Ovidiu, I need support for @dataset@ references passed to i.e. function calls (and from this I will adapt for OO meth...
- 02:30 PM Feature #3809: ProDataSet support
- Is there enough runtime change to make runtime regression testing useful?
- 01:44 PM Feature #3809: ProDataSet support
- The r11310 passed the conversion test on devsrv01, with no changes in generated code compared to latest trunk. I do n...
- 12:21 PM Feature #3809: ProDataSet support
- > And one more thing, I was not able to eliminate the ambiguity warning from progress grammar.
Resolved in revisio...
04/17/2019
- 03:04 PM Feature #3809: ProDataSet support
- Fixed hierarchy and some annotation. Added runtime support. refid: #3809
Committed revision 11311.
04/16/2019
- 01:00 PM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> 3809a 11308 contains some required legacy classes .
and another legacy class in 11309 (... - 12:44 PM Feature #3809: ProDataSet support
- 3809a 11308 contains some required legacy classes .
- 12:16 PM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> Something else - wasn't at some point the idea to avoid the generic get/set method name ... - 12:12 PM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > Constantin Asofiei wrote:
> > > I have some untracked chang... - 12:09 PM Feature #3809: ProDataSet support
- Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > I have some untracked changes, some related to dataset conve... - 12:07 PM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> I have some untracked changes, some related to dataset conversion, some to other, but sa... - 11:40 AM Feature #3809: ProDataSet support
- I have some untracked changes, some related to dataset conversion, some to other, but safe enough to commit here - pl...
- 10:59 AM Feature #3809: ProDataSet support
- Code Review Task Branch 3809b Revision 11327
It was easier to review the old branch than the new one since my last... - 07:19 AM Feature #3809: ProDataSet support
- Greg Shah wrote:
> Ovidiu: Do you think it is stable/safe enough to merge to trunk or does it need additional work?
... - 07:00 AM Feature #3809: ProDataSet support
- Ovidiu: Do you think it is stable/safe enough to merge to trunk or does it need additional work?
If this has no re... - 05:40 AM Feature #3809: ProDataSet support
- Branch 3750b was relased and merged into 3750a, then archived as 'dead'.
Branch 3750a was updated to r11304. DataSet...
04/15/2019
- 03:23 AM Feature #3809: ProDataSet support
- Ovidiu, once you have the dataset conversion/parsing changes in 3809a stable enough, I think we need to merge this to...
04/13/2019
- 06:11 PM Feature #3809: ProDataSet support
- Ovidiu, now that branch 3750b has been merged to trunk 11302, I have rebased branch 3809a (currently at revision 1130...
04/12/2019
- 06:15 PM Feature #1587: implement full support for word indexes
- It should be noted that error handling for the UDF version of CONTAINS support is not quite right. Any error in the s...
- 06:07 PM Feature #3809: ProDataSet support
- Greg Shah wrote:
> I'm not suggesting to use variable types. The idea is to use the @tempIdx@ value in @SymbolResol... - 01:29 PM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > > Also, do you have tests for shared datasets? I see no cha... - 01:25 PM Feature #3809: ProDataSet support
- Ovidiu, please add conversion and stub support for BUFFER:DATA-SOURCE attribute.
- 01:22 PM Feature #3809: ProDataSet support
- Ovidiu Maxiniuc wrote:
> > Also, do you have tests for shared datasets? I see no changes in SharedVariableManager r... - 01:20 PM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> Hmm... related to OO, we need tests at least for:
> * DATASET and DATASET-HANDLE as met... - 01:15 PM Feature #3809: ProDataSet support
- Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, do your testcases cover DATASET and DATASET-HANDLE a... - 01:03 PM Feature #3809: ProDataSet support
- Constantin Asofiei wrote:
> Ovidiu, do your testcases cover DATASET and DATASET-HANDLE as OO method arguments?
I ... - 12:59 PM Feature #3809: ProDataSet support
- Ovidiu, do your testcases cover DATASET and DATASET-HANDLE as OO method arguments?
- 12:31 PM Feature #3809: ProDataSet support
- I'm not suggesting to use variable types. The idea is to use the @tempIdx@ value in @SymbolResolver@ (see @addWrappe...
- 12:17 PM Feature #3809: ProDataSet support
- Greg Shah wrote:
> Code Review Task Branch 3809b Revision 11605
>
> 1. @annotations/datasets.rules@ implements li...
04/11/2019
- 03:00 PM Feature #3809: ProDataSet support
- > Is it OK to add move within RESERVED boundaries?
That is still for keywords. Instead, please put them inside th... - 02:34 PM Feature #3809: ProDataSet support
- Greg Shah wrote:
> Code Review Task Branch 3809b Revision 11605
Thank you for the review. It helps me fix some issu... - 11:26 AM Feature #3809: ProDataSet support
- Code Review Task Branch 3809b Revision 11605
1. @annotations/datasets.rules@ implements linking of dataset/datasou... - 10:31 AM Feature #3809: ProDataSet support
- Branch 3809b was updated. Current revision is (LE) 11605 . It contains fixes for regression introduces the last two d...
04/10/2019
- 02:43 AM Feature #3809: ProDataSet support
- Yes, there are two ambiguity issues.
I haven't added @options { generateAmbigWarnings = false; }@ to hide them yet...
04/09/2019
- 06:42 PM Feature #3809: ProDataSet support
- Ovidiu, antlr reports a lot of errors when I build 3809b/11596. Is that expected?
04/08/2019
- 06:12 PM Feature #4036: catch database UDF support up to current built-in function support level
- We have added support for many 4GL built-in functions over the past years. We need to review which of these can be us...
- 06:09 PM Feature #4036 (New): catch database UDF support up to current built-in function support level
- 05:27 PM Bug #4035: newly created record is not flushed at the right time
- The following test case illustrates the problem.
Constantin Asofiei wrote:
> Good news, I have a recreate; I thin... - 05:09 PM Bug #4035 (Closed): newly created record is not flushed at the right time
- 12:24 PM Feature #3809: ProDataSet support
- ...
- 11:41 AM Feature #3809: ProDataSet support
- Greg, yes, these makes sense, but I am trying to understand if a @dataset-handle@ parameter can receive a generic @ha...
- 11:33 AM Feature #3809: ProDataSet support
- Please see #3751-492 for some interesting details about @TABLE@ and @TABLE-HANDLE@ parameters for methods. It is my ...
- 11:04 AM Feature #3809: ProDataSet support
- Ovidiu Maxiniuc wrote:
> For the moment the @DATASET-HANDLE@ is not recognized as special data type. I am adding now... - 10:31 AM Feature #3809: ProDataSet support
- Consider the following ABL code:...
- 06:03 AM Feature #3809: ProDataSet support
- Ovidiu, please post a small snapshot of how DATASET and DATASET-HANDLE parameters will convert.
Also, I assume tha...
04/05/2019
- 04:26 PM Feature #3809: ProDataSet support
- Revision 11591.
Two important changes in converted code:
* the static definition of @DataSet@ was using buffer f... - 01:37 PM Feature #3809: ProDataSet support
- Revision 11587.
All provided files in Test Suite converted and compiled successfully. I updated the project and wi... - 11:16 PM Feature #3809: ProDataSet support
- Eric Faulhaber wrote:
> Please consider the recent refactoring I did with BUFFER-COPY and BUFFER-COMPARE.
BTW, I'...
04/04/2019
- 05:02 PM Feature #3809: ProDataSet support
- [Originally sent via email, but I wanted to document here...]:
Please consider the recent refactoring I did with B... - 04:59 PM Feature #3809: ProDataSet support
- Revision 11584.
Added missing method declarations. Added attributes and methods from existing interfaces. Fixed so...
04/03/2019
- 03:44 PM Feature #3809: ProDataSet support
- Revision 11583.
The project converts and generated sources compiles without errors.
I am going tomorrow to check ... - 12:21 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- Constantin Asofiei wrote:
> The table should have more than one record :-)
Yes, it should be a "real" table with ... - 10:05 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- My suggestion was to test without the runtime change. Just write the conditional around the @FIND@ in the converted ...
- 09:42 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- We are talking about an WHERE clause which is known that can always match on an unique record. If the lambda express...
- 09:20 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- Constantin Asofiei wrote:
> > How do we determine this efficiently? Within the current session is not too bad, but a... - 09:09 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- Constantin Asofiei wrote:
> No, the lock doesn't matter.
My point is that holding a lock on the record is the only ... - 08:52 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- Regarding Greg's #4033-2 - the idea here is to omit the conversion changes now, and just test a runtime change (which...
- 08:50 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- Eric Faulhaber wrote:
> Is the assumption that the current session holds a lock on the record between FIND [ FIRST ]... - 08:47 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- Eric Faulhaber wrote:
> > * The current record in the buffer meets the unique criteria.
> How do we determine this ... - 08:23 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- Is the assumption that the current session holds a lock on the record between FIND [ FIRST ] calls?
If NO-LOCK, wo... - 08:18 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- This is an interesting idea, but the details of the execution present some questions.
Greg Shah wrote:
> * The cu... - 08:06 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- The table should have more than one record :-)
- 07:17 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- One idea to test this:
1. Write a 4GL testcases that does 10000 of the same @FIND@ in a loop using a unique index ... - 07:08 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
- In discussions with a customer, it was noted that in the 4GL a @FIND@ (or @FIND FIRST@ etc) is very fast when the sam...
- 06:49 AM Feature #4033 (WIP): avoid query for FIND unique when the current record in the buffer would matc...
04/02/2019
- 03:16 PM Feature #3809: ProDataSet support
- Revision 11577.
Added missing parent-id-relation option and resolved conflicts with other variables.
Compiling th... - 10:52 PM Feature #4030: improve CompoundQuery optimizer
- Some time ago, I implemented a runtime optimizer for @CompoundQuery@, which would analyze the components of the compo...
- 10:36 PM Feature #4030 (New): improve CompoundQuery optimizer
04/01/2019
- 06:40 PM Feature #4024: PostgreSQL shared memory JDBC driver
- This concept is a more outside-the-box corollary to the idea behind #4012. In a system where lots of round trips to t...
- 06:22 PM Feature #4024 (New): PostgreSQL shared memory JDBC driver
- 06:20 PM Feature #4023: PostgreSQL query planning optimization
- To date, we have not made a concentrated effort to tune PostgreSQL's query planner for FWD's use, beyond some basics:...
- 06:12 PM Feature #4023 (New): PostgreSQL query planning optimization
- 06:10 PM Feature #4022: upgrade to a newer PostgreSQL release
- At the time of this writing, the most recent production PostgreSQL release is 11.2. We are currently working primaril...
- 05:48 PM Feature #4022 (WIP): upgrade to a newer PostgreSQL release
- 03:37 PM Feature #4021: better use of session-related resources such as PreparedStatements and caches
- At the moment, this task is somewhat speculative, in that I'm not sure how well we are amortizing the cost of setting...
- 03:22 PM Feature #4021 (New): better use of session-related resources such as PreparedStatements and caches
- 03:19 PM Feature #4020: reduce work Hibernate does flushing session
- Each time Hibernate does something that relies on the state of the database to be consistent with changes in the stat...
- 02:46 PM Feature #4020 (Rejected): reduce work Hibernate does flushing session
- 02:51 PM Feature #3809: ProDataSet support
- Committed r11576 of branch 3809b.
At this moment all the sources provided convert. However, the code is not 100% c... - 11:35 AM Feature #4019: rework dirty database implementation to use persistent database
- This task is meant to address two issues with the current dirty database implementation:
* it is limited, in that ... - 11:06 AM Feature #4019 (New): rework dirty database implementation to use persistent database
- 11:02 AM Feature #4018: possibly move temp-table support into persistent database
- We already do a form of optimization for @CompoundQuery@, where we attempt to determine whether a multi-table query w...
- 10:55 AM Feature #4018: possibly move temp-table support into persistent database
- In the early days of FWD, temp-table support was implemented in the persistent database (e.g., PostgreSQL). To avoid ...
- 10:25 AM Feature #4018 (New): possibly move temp-table support into persistent database
Also available in: Atom