Project

General

Profile

Activity

From 04/06/2019 to 05/05/2019

05/02/2019

10:24 AM Feature #3809: ProDataSet support
Ovidiu, @dataset-handle@ parameters need to convert as @DatasetParameter@ (same as @table-handle@ does). Currently t... Constantin Asofiei

05/01/2019

04:58 PM Feature #3761 (Closed): add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause inter...
As of trunk revision 11302, this functionality is complete. Greg Shah
02:14 PM Support #4063: linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation
After speaking with Eric, some thoughts:
* The current approach is handled exclusively at runtime.
* The more adv...
Greg Shah
02:04 PM Support #4063: linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation
From Eric:
> Yes. This has been implemented since 2006 as @AdaptiveFind@.
>
> It doesn't detect that it is in ...
Greg Shah
02:02 PM Support #4063: linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation
From Constantin:
> An idea here is to add an UUID at conversion time, to a FIND. This way the runtime can uniquely...
Greg Shah
02:01 PM Support #4063: linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation
Can @FIND FIRST@ and @FIND NEXT@ with same buffer and same @WHERE@ be matched together into a set oriented approach? ... Greg Shah
02:00 PM Support #4063 (New): linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation
Greg Shah
01:58 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
I think that in addition to @FIND unique@, there are other cases (@FIND FIRST/LAST@) where we can track enough state ... Greg Shah
01:17 PM Support #4060: investigate converting extent fields to array columns
Note that this task is created in the context of investigating changes that may improve performance, but I don't know... Eric Faulhaber
01:08 PM Support #4060: investigate converting extent fields to array columns
We have found on occasion that our default approach of normalizing extent fields of like extent into a secondary tabl... Eric Faulhaber
01:01 PM Support #4060 (WIP): investigate converting extent fields to array columns
Eric Faulhaber
01:00 PM Support #4058: consider denormalizing tables as the default approach
I don't really want to make denormalization the default, as this can result in a huge number of columns in a table, h... Eric Faulhaber
10:49 AM Support #4058: consider denormalizing tables as the default approach
We know that denormalizing for all tables is not always a performance improvement, so there may need to be a better a... Greg Shah
10:48 AM Support #4058 (New): consider denormalizing tables as the default approach
Greg Shah
10:46 AM Bug #4057: h2 performance degradation
From Eric:
> I'd rather not. 197 has a lot of fixes for regressions in the last few point releases before it.
>
...
Greg Shah
10:46 AM Bug #4057: h2 performance degradation
As an interim measure, can we go back to 1.4.196 (and add our customizations)? Greg Shah
10:45 AM Bug #4057: h2 performance degradation
More from the mailing list:
-------- Forwarded Message --------
Subject: [h2] Re: Recent drops in performance
D...
Greg Shah
10:44 AM Bug #4057: h2 performance degradation
From Eric:
> We're on (a customized) 1.4.197 (not depicted, but probably somewhere between cyan and red).
Greg Shah
10:43 AM Bug #4057: h2 performance degradation
From the H2 mailing list:
-------- Forwarded Message --------
Subject: [h2] Re: Recent drops in performance
Dat...
Greg Shah
10:42 AM Bug #4057 (New): h2 performance degradation
Greg Shah
02:21 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
In order to improve the performance of the persistence layer of FWD, we first need to measure the time spent at sever... Eric Faulhaber
02:11 AM Feature #4056 (WIP): instrument FWD and supporting libraries to measure database performance
Eric Faulhaber
02:03 AM Feature #4055: optimize temp-table output parameter copying
This idea warrants further investigation. Eric Faulhaber
02:02 AM Feature #4055: optimize temp-table output parameter copying
Eric wrote:
---
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > We could get past the first issue with ...
Eric Faulhaber
02:01 AM Feature #4055: optimize temp-table output parameter copying
Constantin wrote:
---
Eric Faulhaber wrote:
> We could get past the first issue with some clever insert statem...
Eric Faulhaber
02:01 AM Feature #4055: optimize temp-table output parameter copying
Eric wrote:
---
Constantin Asofiei wrote:
> Eric, did you notice the time spent during temp-table output param...
Eric Faulhaber
02:00 AM Feature #4055: optimize temp-table output parameter copying
Constantin wrote:
---
Eric, did you notice the time spent during temp-table output parameter copying, during pr...
Eric Faulhaber
01:59 AM Feature #4055: optimize temp-table output parameter copying
The following discussion between Constantin and myself is copied from another task... Eric Faulhaber
01:58 AM Feature #4055 (WIP): optimize temp-table output parameter copying
Eric Faulhaber
01:32 AM Feature #4054: only track specific tables in dirty database
The idea is to improve performance of the persistence layer by only tracking certain tables within the dirty database... Eric Faulhaber
01:28 AM Feature #4054 (New): only track specific tables in dirty database
Eric Faulhaber

04/23/2019

01:17 PM Feature #3809: ProDataSet support
3809a was merged to trunk as r11304. Fresh new 3809c was created for following changes on this task. Ovidiu Maxiniuc
11:47 AM Feature #3809: ProDataSet support
Greg Shah wrote:
> To be safe, please put this back through conversion regression testing. If it passes for the ChU...
Ovidiu Maxiniuc
09:53 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Eric, what do you say?
Yes, I like this better.
Eric Faulhaber
09:40 AM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, there is a regression in 3809a: you've added the @kw_cpy_ttbl@ to the top @load_...
Ovidiu Maxiniuc
02:43 AM Feature #3809: ProDataSet support
Ovidiu, there is a regression in 3809a: you've added the @kw_cpy_ttbl@ to the top @load_descriptors@ function, and th... Constantin Asofiei

04/22/2019

07:56 AM Feature #3816: table and table handle parameter options
Please document the specific questions we have that will require 4GL testcases. I don't know if we will be able to g... Greg Shah
07:51 AM Feature #3816: table and table handle parameter options
3809a contains some changes that implement dataset parameters. This will be merged to trunk shortly. As part of thi... Greg Shah
07:48 AM Feature #3815: more temp-table options
> BEFORE-TABLE
Isn't this going to be handled as part of the work for #3809?
Greg Shah
02:46 AM Feature #3809: ProDataSet support
Ovidiu, please rebase 3809a. Constantin Asofiei

04/19/2019

04:55 PM Feature #3809: ProDataSet support
Code Review Task Branch 3809a Revision 11316
I'm good with the changes. Constantin will include the @Preprocessor...
Greg Shah
04:44 PM Feature #3809: ProDataSet support
The revision 11316 adds some new runtime support. It passed the DataSet Test Suite conversion test. Ovidiu Maxiniuc
03:38 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> Code Review Task Branch 3809a Revision 11315
> 2. I think the gap marking needs to be updated wi...
Ovidiu Maxiniuc
03:34 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> 1. Constantin: In regard to the @Preprocessor@ change:
>
> * Does this resolve #3846 (I assume...
Constantin Asofiei
03:30 PM Feature #3809: ProDataSet support
Code Review Task Branch 3809a Revision 11315
Generally, I'm good with this code. Some small items are below.
1...
Greg Shah
02:38 PM Feature #3809: ProDataSet support
Thanks, Ovidiu - 3809a rev 11315 fixes my case for the OO method calls. Constantin Asofiei
01:32 PM Feature #3809: ProDataSet support
Sorry,
After my first reply I double checked the branch. I forgot to merge in the TRPL changes :(. Please update to...
Ovidiu Maxiniuc
01:29 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, I assume the conversion rules for dataset as function call argument are still WI...
Ovidiu Maxiniuc
01:26 PM Feature #3809: ProDataSet support
Ovidiu, I assume the conversion rules for dataset as function call argument are still WIP? Constantin Asofiei
09:13 AM Feature #3809: ProDataSet support
A bit later than expected I have the solution for @append@ and/or @by-reference@ datasets.
I tried to use the same c...
Ovidiu Maxiniuc

04/18/2019

05:19 PM Feature #3809: ProDataSet support
Ovidiu: How long do you expect the parameter support changes to take? It may make sense to hold 3809a for those chan... Greg Shah
05:15 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> Constantin: Is it OK to deal with #3809-70 in another branch? Or will that cause us other issues...
Constantin Asofiei
05:10 PM Feature #3809: ProDataSet support
I'm inclined to get this merged to trunk.
Constantin: Is it OK to deal with #3809-70 in another branch? Or will t...
Greg Shah
02:56 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> Is there enough runtime change to make runtime regression testing useful?
I think not. I summary...
Ovidiu Maxiniuc
02:36 PM Feature #3809: ProDataSet support
Ovidiu, I need support for @dataset@ references passed to i.e. function calls (and from this I will adapt for OO meth... Constantin Asofiei
02:30 PM Feature #3809: ProDataSet support
Is there enough runtime change to make runtime regression testing useful? Greg Shah
01:44 PM Feature #3809: ProDataSet support
The r11310 passed the conversion test on devsrv01, with no changes in generated code compared to latest trunk. I do n... Ovidiu Maxiniuc
12:21 PM Feature #3809: ProDataSet support
> And one more thing, I was not able to eliminate the ambiguity warning from progress grammar.
Resolved in revisio...
Greg Shah

04/17/2019

03:04 PM Feature #3809: ProDataSet support
Fixed hierarchy and some annotation. Added runtime support. refid: #3809
Committed revision 11311.
Ovidiu Maxiniuc

04/16/2019

01:00 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> 3809a 11308 contains some required legacy classes .
and another legacy class in 11309 (...
Constantin Asofiei
12:44 PM Feature #3809: ProDataSet support
3809a 11308 contains some required legacy classes . Constantin Asofiei
12:16 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Something else - wasn't at some point the idea to avoid the generic get/set method name ...
Ovidiu Maxiniuc
12:12 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > Constantin Asofiei wrote:
> > > I have some untracked chang...
Constantin Asofiei
12:09 PM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > I have some untracked changes, some related to dataset conve...
Constantin Asofiei
12:07 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> I have some untracked changes, some related to dataset conversion, some to other, but sa...
Ovidiu Maxiniuc
11:40 AM Feature #3809: ProDataSet support
I have some untracked changes, some related to dataset conversion, some to other, but safe enough to commit here - pl... Constantin Asofiei
10:59 AM Feature #3809: ProDataSet support
Code Review Task Branch 3809b Revision 11327
It was easier to review the old branch than the new one since my last...
Greg Shah
07:19 AM Feature #3809: ProDataSet support
Greg Shah wrote:
> Ovidiu: Do you think it is stable/safe enough to merge to trunk or does it need additional work?
...
Ovidiu Maxiniuc
07:00 AM Feature #3809: ProDataSet support
Ovidiu: Do you think it is stable/safe enough to merge to trunk or does it need additional work?
If this has no re...
Greg Shah
05:40 AM Feature #3809: ProDataSet support
Branch 3750b was relased and merged into 3750a, then archived as 'dead'.
Branch 3750a was updated to r11304. DataSet...
Ovidiu Maxiniuc

04/15/2019

03:23 AM Feature #3809: ProDataSet support
Ovidiu, once you have the dataset conversion/parsing changes in 3809a stable enough, I think we need to merge this to... Constantin Asofiei

04/13/2019

06:11 PM Feature #3809: ProDataSet support
Ovidiu, now that branch 3750b has been merged to trunk 11302, I have rebased branch 3809a (currently at revision 1130... Eric Faulhaber

04/12/2019

06:15 PM Feature #1587: implement full support for word indexes
It should be noted that error handling for the UDF version of CONTAINS support is not quite right. Any error in the s... Eric Faulhaber
06:07 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> I'm not suggesting to use variable types. The idea is to use the @tempIdx@ value in @SymbolResol...
Ovidiu Maxiniuc
01:29 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > > Also, do you have tests for shared datasets? I see no cha...
Ovidiu Maxiniuc
01:25 PM Feature #3809: ProDataSet support
Ovidiu, please add conversion and stub support for BUFFER:DATA-SOURCE attribute. Constantin Asofiei
01:22 PM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> > Also, do you have tests for shared datasets? I see no changes in SharedVariableManager r...
Constantin Asofiei
01:20 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Hmm... related to OO, we need tests at least for:
> * DATASET and DATASET-HANDLE as met...
Ovidiu Maxiniuc
01:15 PM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, do your testcases cover DATASET and DATASET-HANDLE a...
Constantin Asofiei
01:03 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, do your testcases cover DATASET and DATASET-HANDLE as OO method arguments?
I ...
Ovidiu Maxiniuc
12:59 PM Feature #3809: ProDataSet support
Ovidiu, do your testcases cover DATASET and DATASET-HANDLE as OO method arguments? Constantin Asofiei
12:31 PM Feature #3809: ProDataSet support
I'm not suggesting to use variable types. The idea is to use the @tempIdx@ value in @SymbolResolver@ (see @addWrappe... Greg Shah
12:17 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> Code Review Task Branch 3809b Revision 11605
>
> 1. @annotations/datasets.rules@ implements li...
Ovidiu Maxiniuc

04/11/2019

03:00 PM Feature #3809: ProDataSet support
> Is it OK to add move within RESERVED boundaries?
That is still for keywords. Instead, please put them inside th...
Greg Shah
02:34 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> Code Review Task Branch 3809b Revision 11605
Thank you for the review. It helps me fix some issu...
Ovidiu Maxiniuc
11:26 AM Feature #3809: ProDataSet support
Code Review Task Branch 3809b Revision 11605
1. @annotations/datasets.rules@ implements linking of dataset/datasou...
Greg Shah
10:31 AM Feature #3809: ProDataSet support
Branch 3809b was updated. Current revision is (LE) 11605 . It contains fixes for regression introduces the last two d... Ovidiu Maxiniuc

04/10/2019

02:43 AM Feature #3809: ProDataSet support
Yes, there are two ambiguity issues.
I haven't added @options { generateAmbigWarnings = false; }@ to hide them yet...
Ovidiu Maxiniuc

04/09/2019

06:42 PM Feature #3809: ProDataSet support
Ovidiu, antlr reports a lot of errors when I build 3809b/11596. Is that expected? Eric Faulhaber

04/08/2019

06:12 PM Feature #4036: catch database UDF support up to current built-in function support level
We have added support for many 4GL built-in functions over the past years. We need to review which of these can be us... Eric Faulhaber
06:09 PM Feature #4036 (New): catch database UDF support up to current built-in function support level
Eric Faulhaber
05:27 PM Bug #4035: newly created record is not flushed at the right time
The following test case illustrates the problem.
Constantin Asofiei wrote:
> Good news, I have a recreate; I thin...
Eric Faulhaber
05:09 PM Bug #4035 (Closed): newly created record is not flushed at the right time
Eric Faulhaber
12:24 PM Feature #3809: ProDataSet support
... Ovidiu Maxiniuc
11:41 AM Feature #3809: ProDataSet support
Greg, yes, these makes sense, but I am trying to understand if a @dataset-handle@ parameter can receive a generic @ha... Constantin Asofiei
11:33 AM Feature #3809: ProDataSet support
Please see #3751-492 for some interesting details about @TABLE@ and @TABLE-HANDLE@ parameters for methods. It is my ... Greg Shah
11:04 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> For the moment the @DATASET-HANDLE@ is not recognized as special data type. I am adding now...
Constantin Asofiei
10:31 AM Feature #3809: ProDataSet support
Consider the following ABL code:... Ovidiu Maxiniuc
06:03 AM Feature #3809: ProDataSet support
Ovidiu, please post a small snapshot of how DATASET and DATASET-HANDLE parameters will convert.
Also, I assume tha...
Constantin Asofiei
 

Also available in: Atom