Project

General

Profile

Activity

From 05/30/2019 to 06/28/2019

06/28/2019

07:12 PM Feature #3809: ProDataSet support
The branch 3809c was rebased to latest trunk and updated to r11358 (includes XMLSCHEMA serialization for DATASETs). Ovidiu Maxiniuc
06:18 PM Feature #3816: table and table handle parameter options
> Most of the code in @testcases/uast/oo/@ converts OK (not all, but most). Please post your sample here for review.
...
Stanislav Lomany
08:34 PM Feature #3815: more temp-table options
> Stanislav, what information do you need from the NEW SHARED TEMP-TABLE definition which is not in the SHARED TEMP-T... Stanislav Lomany

06/27/2019

06:19 PM Feature #3809: ProDataSet support
The branch 3809c was updated to r11355 (XML serialization for DATASETs). Note that it is not yet rebased to latest tr... Ovidiu Maxiniuc
09:24 AM Feature #3809: ProDataSet support
I have dumped the schema for some TEMP-TABLE and the list of fields looks like this:... Ovidiu Maxiniuc
08:50 PM Feature #3815: more temp-table options
I'll attach some testcases here. Note that at this point they do not work "out of the box" because of #3815-41. You h... Stanislav Lomany
08:40 PM Feature #3815: more temp-table options
3815a has been merged into the trunk as bzr revision 11320.
Stanislav Lomany

06/26/2019

07:26 PM Feature #3815: more temp-table options
Rebased task branch 3815a from P2J trunk revision 11319. Stanislav Lomany
05:36 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> > I can live with the @Text.assign(clob)@ issue temporarily if the runtime conversion chan...
Eric Faulhaber
05:19 PM Feature #3815: more temp-table options
> I can live with the @Text.assign(clob)@ issue temporarily if the runtime conversion changes you have in mind are ti... Stanislav Lomany
05:10 PM Feature #3815: more temp-table options
Stanislav, what information do you need from the NEW SHARED TEMP-TABLE definition which is not in the SHARED TEMP-TAB... Eric Faulhaber
11:41 AM Feature #3815: more temp-table options
The NEW (SHARED) TEMP-TABLES are tracked by @SharedVariableManager@. See @addTempTable()@ and @lookupTempTable()@ met... Ovidiu Maxiniuc
10:12 AM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> I need help with an idea for the fix. @getStaticTempTableDepth(String name)@ searches for ...
Eric Faulhaber
10:00 AM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> > I'm not crazy about the addition of @Text.assign(clob)@, since this is an ancestor class...
Eric Faulhaber
04:09 AM Feature #3815: more temp-table options
> @TempTableBuilder@: what is special about @ParmType.CLOB@ that we use @toLowerCase@ on this type and not on any of ... Stanislav Lomany

06/25/2019

04:17 PM Feature #3815: more temp-table options
I need help with an idea for the fix. @getStaticTempTableDepth(String name)@ searches for the table using @(table-nam... Stanislav Lomany
03:42 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> I found an issue: @add-fields-from@ and @add-like-field@ cannot find the source LIKE table...
Eric Faulhaber
03:40 PM Feature #3815: more temp-table options
I found an issue: @add-fields-from@ and @add-like-field@ cannot find the source LIKE table if it is a shared table. T... Stanislav Lomany

06/24/2019

06:13 AM Feature #3815: more temp-table options
> I'm not crazy about the addition of @Text.assign(clob)@, since this is an ancestor class that is now aware of its d... Stanislav Lomany
05:56 AM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Ovidiu, is 3809c in a state that is read for code review?
I added some unfinished code at t...
Ovidiu Maxiniuc
12:46 AM Feature #3809: ProDataSet support
Ovidiu, is 3809c in a state that is read for code review?
I'm sorry I do not have an idea for your previous post ATM.
Eric Faulhaber

06/23/2019

04:56 PM Feature #3816: table and table handle parameter options
Most of the code in @testcases/uast/oo/@ converts OK (not all, but most). Please post your sample here for review. Greg Shah

06/21/2019

03:58 PM Feature #3816: table and table handle parameter options
Adding skeleton helped to pass the errors above. However I cannot convert a file referencing a class. I suppose it ma... Stanislav Lomany

06/20/2019

05:09 PM Feature #3816: table and table handle parameter options
> Do we support 4GL classes (.cls)?
Yes, most use cases are already supported. See #3751.
You probably need to ...
Greg Shah
04:07 PM Feature #3816: table and table handle parameter options
Do we support 4GL classes (@.cls@)?... Stanislav Lomany
03:58 PM Feature #3815: more temp-table options
Code Review Task Branch 3815a Revision 11327
The @src/com/goldencode/p2j/uast/*@ changes are fine. I didn't look ...
Greg Shah
02:52 PM Feature #3815: more temp-table options
Code review 3815a/11327:
Nice update. A few things to consider...
Not your issue, but rather the correction of ...
Eric Faulhaber
09:43 AM Feature #3809: ProDataSet support
I have the following issue while working on save/merging changes back to DATA-SOURCE: how to identify the records/row... Ovidiu Maxiniuc

06/18/2019

03:59 PM Feature #3816 (WIP): table and table handle parameter options
I have a couple of questions about testcases:
# Is there a runner file for this set of testcases? I couldn't find on...
Stanislav Lomany

06/17/2019

04:44 AM Feature #3815: more temp-table options
> Please review 3815a rev 11327.
FYI it passed regression testing.
Stanislav Lomany

06/15/2019

11:16 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
It told me that the @com.sun.proxy.*@ join point weaves were @... advised by around advice from 'com.goldencode.p2j.a... Eric Faulhaber
09:34 PM Feature #3815: more temp-table options
Please review 3815a rev 11327. Stanislav Lomany

06/14/2019

04:20 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
Eric Faulhaber wrote:
> Hynek, AspectJ is executing a join point for methods outside the scope I am trying to define...
Hynek Cihlar
03:58 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
Hynek, AspectJ is executing a join point for methods outside the scope I am trying to define. For instance, this dyna... Eric Faulhaber
03:03 PM Feature #3815: more temp-table options
Rebased task branch 3815a from P2J trunk revision 11317. Stanislav Lomany
02:40 PM Feature #3815: more temp-table options
> How extensive are the changes?
60 core lines of separate rules.
> Are they likely to be expanded later?
I...
Stanislav Lomany
01:48 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> I put some code page conversion rules into @annotations/sorting.rules@, but because it's n...
Eric Faulhaber
01:40 PM Feature #3815: more temp-table options
I put some code page conversion rules into @annotations/sorting.rules@, but because it's not sorting-related rules, s... Stanislav Lomany
09:16 AM Feature #3815: more temp-table options
Create a task that describes the quirk, make Eric and myself watchers and make it related to this task. Greg Shah
08:41 AM Feature #3815: more temp-table options
FYI, I'm not going to implement #3815-47 quirk because it requires to create hierarchy tracking mechanism for an unre... Stanislav Lomany
08:32 AM Feature #3815: more temp-table options
> > I've found that the CODEPAGE can be inherited from another permanent or temp-table through either table- or field... Stanislav Lomany

06/13/2019

06:08 PM Feature #3815: more temp-table options
The @init@ block can be found using the @controlid@ annotation in the inner block node.
See @save_control_point_...
Greg Shah
04:57 PM Feature #3815: more temp-table options
Guys, can you give me an advice how to emit something at @Init@ section of the external procedure or in the main bloc... Stanislav Lomany
09:21 AM Bug #3960: localedef problems in Ubuntu 18.04
I've committed this change in branch 4069a as revision 11320. Greg Shah

06/12/2019

04:03 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> [...]
> Although this is for parameter passing in methods, I suspect it also is the same behavio...
Ovidiu Maxiniuc
03:42 PM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> I wonder if our interceptor within @ChangeBroker@ is preventing Hibernate from realizing tha...
Ovidiu Maxiniuc
11:05 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > What do you mean here by "not updated in database"? The records ...
Eric Faulhaber
10:49 AM Feature #3809: ProDataSet support
> I quote: the number of columns, data types, and so on. What does "and so on" mean? The name maybe? Well, not.
Pl...
Greg Shah
10:11 AM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> What do you mean here by "not updated in database"? The records still exist after we attempt...
Ovidiu Maxiniuc
10:00 AM Feature #3809: ProDataSet support
I've leant something about the TEMP-TABLE that is not documented. At least for GET-CHANGES, the source and destinatio... Ovidiu Maxiniuc
09:48 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Everything works fine, except one thing: in rare cases (only on DELETE operations, see @Tem...
Eric Faulhaber
08:38 AM Feature #3809: ProDataSet support
I have the following issue.
In a previous commit to 3809c I enriched the DMO with two new fields: @_rowState@ and @_...
Ovidiu Maxiniuc
03:35 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
I've added all the suggested features except the @Totals@ row (will add in a separate pass). I've rebased 4056a to tr... Eric Faulhaber
12:16 PM Feature #3815: more temp-table options
Agreed. Unless there is a technical advantage to using a @Resolvable@ (e.g., re-usability), we generally prefer to us... Eric Faulhaber
12:15 PM Feature #3815: more temp-table options
Use a lambda. This is easily done. See @convert/expressions.rules@ and the usage of @tw.graft("lambda_expr", copy, ... Greg Shah
12:09 PM Feature #3815: more temp-table options
Looks like the code page expression should be resolvable/lambda. Yes, it is evaluated once, but it can depend on the ... Stanislav Lomany

06/11/2019

01:47 PM Feature #3815: more temp-table options
An interesting observation. Consider we declared a shared temp-table:... Stanislav Lomany
05:03 AM Feature #3815: more temp-table options
> Which one are you suggesting? I did not design these classes, nor @TableMapper@, but it seems we split legacy infor... Stanislav Lomany
01:42 PM Bug #3960: localedef problems in Ubuntu 18.04
Greg Shah wrote:
> > Can someone that is running on Ubuntu 16.04 test this new locale definition on the old localede...
Eric Faulhaber
11:55 AM Bug #3960: localedef problems in Ubuntu 18.04
> Can someone that is running on Ubuntu 16.04 test this new locale definition on the old localedef?
Did this work?
Greg Shah
11:49 AM Bug #3960: localedef problems in Ubuntu 18.04
Greg Shah wrote:
> Can someone that is running on Ubuntu 16.04 test this new locale definition on the old localedef?...
Eric Faulhaber

06/10/2019

05:34 PM Feature #3815: more temp-table options
>> Code page is set in the separate function TemporaryBuffer.setCodePage(buffer, fieldName, codepage). The question i... Greg Shah
05:26 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> Guys, I want to know your opinion on how to better implement code page inheritance. We hav...
Eric Faulhaber
09:12 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
This looks very useful. Some suggested improvements for the output:
* Instead of @Agg Time@ use @Agg Time (nanose...
Greg Shah
02:12 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Attached is some Hotel GUI sample trace output showing aggregate times (nanosec) and invocation counts by top-level t... Eric Faulhaber

06/09/2019

02:43 PM Feature #3815: more temp-table options
Guys, I want to know your opinion on how to better implement code page inheritance. We have the following things to c... Stanislav Lomany

06/06/2019

07:21 PM Feature #3815: more temp-table options
> I've found that the CODEPAGE can be inherited from another permanent or temp-table through either table- or field-l... Stanislav Lomany
11:36 AM Feature #3815: more temp-table options
Side note: when a @longchar@/@clob@ value is assigned to a @clob@ field, it is implicitly converted into the codepage... Stanislav Lomany
06:15 AM Feature #3814: more schema metadata
Thank you very much, Ovidiu! Igor Skornyakov
06:04 AM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Which FWD classes are working with metadata? I've never worked with this and need some star...
Ovidiu Maxiniuc

06/05/2019

04:04 PM Bug #3651: regression in server startup when _connect metadata is active and a database is loaded...
This is 100% complete, right? Greg Shah
03:29 PM Feature #3814: more schema metadata
Which FWD classes are working with metadata? I've never worked with this and need some starting point.
Thank you.
Igor Skornyakov
03:12 PM Feature #3814 (WIP): more schema metadata
Greg Shah

06/04/2019

07:59 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > @WRITE-JSON(...,JsonObject|JsonArray)@ is needed at least fo...
Constantin Asofiei
07:51 AM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> @WRITE-JSON(...,JsonObject|JsonArray)@ is needed at least for buffer.
Is this urgent?
...
Ovidiu Maxiniuc
04:07 AM Feature #3809: ProDataSet support
@WRITE-JSON(...,JsonObject|JsonArray)@ is needed at least for buffer. Constantin Asofiei

06/03/2019

01:51 AM Bug #4071: FWD server stops allowing new web client logins after abend
Eric Faulhaber wrote:
> 4045a/11327 has an attempted workaround for this issue, but I'm not satisfied that it is a g...
Constantin Asofiei
12:49 AM Bug #4071: FWD server stops allowing new web client logins after abend
4045a/11327 has an attempted workaround for this issue, but I'm not satisfied that it is a good solution. In @Persist... Eric Faulhaber

06/02/2019

01:38 PM Bug #4071: FWD server stops allowing new web client logins after abend
Constantin Asofiei wrote:
>Eric, lets 'switch' the question a little; why are we not already rolling back the tx i...
Eric Faulhaber
01:17 PM Bug #4071: FWD server stops allowing new web client logins after abend
Greg Shah wrote:
> Another question: do we ever need to run session cleanup on the Reader or Writer threads? If it ...
Eric Faulhaber

05/31/2019

04:36 PM Feature #3816: table and table handle parameter options
See "Testcases":/projects/p2j/wiki/Writing_4GL_Testcases#Testcase-Project to access the 4GL code. Greg Shah
08:58 AM Feature #3809: ProDataSet support
This was caused because in Progress parser, @resolveLvalueCoreType@ _variables by the same name as a field, will hide... Ovidiu Maxiniuc
07:07 AM Bug #4071: FWD server stops allowing new web client logins after abend
Another question: do we ever need to run session cleanup on the Reader or Writer threads? If it always runs on the C... Greg Shah
01:32 AM Bug #4071: FWD server stops allowing new web client logins after abend
Eric, lets 'switch' the question a little; why are we not already rolling back the tx in case of an abend, on the Con... Constantin Asofiei

05/30/2019

07:26 PM Feature #3809: ProDataSet support
Ovidiu, the testcase is like this:... Constantin Asofiei
04:36 PM Feature #3809: ProDataSet support
There is a case where in a @define dataset@ there is a line like @data-relation rxx for t1, t2 relation-fields (f1,f1... Constantin Asofiei
04:08 PM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, are you planning on implementing this method: @buffer-handle:SYNCHRONIZE().@? L...
Ovidiu Maxiniuc
04:06 PM Feature #3809: ProDataSet support
Ovidiu, are you planning on implementing this method: @buffer-handle:SYNCHRONIZE().@? Looks like there is an implici... Constantin Asofiei
06:52 PM Feature #3815: more temp-table options
Created task branch 3815a from P2J trunk revision 11311. Stanislav Lomany
 

Also available in: Atom