Project

General

Profile

Activity

From 06/08/2019 to 07/07/2019

07/07/2019

06:13 PM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Hynek Cihlar wrote:
> > Ovidiu, I have some code changes to @JsonExport@ I'd like to merge...
Hynek Cihlar
04:44 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
Task branch 4056a has been rebased to trunk rev 11322. Eric Faulhaber

07/05/2019

05:37 PM Feature #3809: ProDataSet support
I updated the branch to r11365. Note that the temporary DMO will change a bit. (JSON not affected) Ovidiu Maxiniuc
09:08 AM Feature #3809: ProDataSet support
Hynek Cihlar wrote:
> Ovidiu, I have some code changes to @JsonExport@ I'd like to merge with your changes and deliv...
Ovidiu Maxiniuc
05:05 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Hynek Cihlar wrote:
> > Ovidiu please check in the class @ThrowingConsumer@. Do you have o...
Hynek Cihlar
05:04 AM Feature #3809: ProDataSet support
Ovidiu, I have some code changes to @JsonExport@ I'd like to merge with your changes and deliver to the branch. If yo... Hynek Cihlar

07/04/2019

01:33 PM Feature #3809: ProDataSet support
Btw, I would like to merge JSON & XML export classes to use a single output code because both these classes write the... Ovidiu Maxiniuc
01:27 PM Feature #3809: ProDataSet support
Hynek Cihlar wrote:
> Ovidiu please check in the class @ThrowingConsumer@. Do you have other upcoming changes for @J...
Ovidiu Maxiniuc
12:29 PM Feature #3809: ProDataSet support
Ovidiu please check in the class @ThrowingConsumer@. Do you have other upcoming changes for @JsonExport@? Hynek Cihlar
10:39 AM Support #3871: determine how to change codepages/locales during import
In this task we are understanding and resolving issues related to reading a database dump (@.d@ files) which has data... Greg Shah
04:15 AM Support #3871: determine how to change codepages/locales during import
Greg, what exactly do you need us to do on this one?
Albeit related the code page character encoding and the colla...
Marian Edu

07/03/2019

04:14 PM Feature #4128: defer transaction start until the time when real edits begin
It is my understanding that starting in OpenEdge 11.x, the default behavior is to defer transaction start until the t... Greg Shah
04:13 PM Feature #4128 (New): defer transaction start until the time when real edits begin
Greg Shah
02:27 PM Feature #3815: more temp-table options
> Place it in 3855b.
Committed rev 11329.
Stanislav Lomany
08:27 AM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> Where I can put the fix?
Place it in 3855b.
Constantin Asofiei

07/02/2019

04:46 PM Feature #3816: table and table handle parameter options
> One thing that you MUST do is to include the @oo/Printme.cls@ in the conversion list. I suspect that is your issue... Stanislav Lomany
04:44 PM Feature #3815: more temp-table options
> For now, I would just drop any code related to a temp-table definition in an interface
I couldn't do it at this ...
Stanislav Lomany

07/01/2019

02:59 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> Do you, guys, know, if a code page of a temp-table field defined in an interface have an a...
Constantin Asofiei
02:58 PM Feature #3815: more temp-table options
Do you, guys, know, if a code page of a temp-table field defined in an interface have an actual effect? Temp-table de... Stanislav Lomany
11:43 AM Feature #3815: more temp-table options
From Constantin: conversion fails because of a TEMP-TABLE with a COLUMN-CODEPAGE field defined in an interface.
<p...
Stanislav Lomany
10:42 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Apparently the revision 11359 added some changes, but the @JsonBackend@ file is missing. Hy...
Ovidiu Maxiniuc
06:43 AM Feature #3809: ProDataSet support
Apparently the revision 11359 added some changes, but the @JsonBackend@ file is missing. Hynek, please add it.
LE: T...
Ovidiu Maxiniuc
06:34 AM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> For JSON serialization, I need the legacy table and field names - but these are lowercas...
Ovidiu Maxiniuc
06:27 AM Feature #3809: ProDataSet support
Hynek Cihlar wrote:
> 3809c build fails with:
>
> [...]
You are correct. On Friday I commit my changes then I ...
Ovidiu Maxiniuc

06/30/2019

05:09 PM Feature #3809: ProDataSet support
3809c build fails with:... Hynek Cihlar
05:07 PM Feature #3809: ProDataSet support
For JSON serialization, I need the legacy table and field names - but these are lowercased in FWD, I can't find a way... Constantin Asofiei

06/29/2019

01:33 AM Feature #3816: table and table handle parameter options
Please post both the test driver and the @Printme.cls@ or commit them to @testcases/uast/@.
One thing that you MUS...
Greg Shah

06/28/2019

07:12 PM Feature #3809: ProDataSet support
The branch 3809c was rebased to latest trunk and updated to r11358 (includes XMLSCHEMA serialization for DATASETs). Ovidiu Maxiniuc
06:18 PM Feature #3816: table and table handle parameter options
> Most of the code in @testcases/uast/oo/@ converts OK (not all, but most). Please post your sample here for review.
...
Stanislav Lomany
08:34 PM Feature #3815: more temp-table options
> Stanislav, what information do you need from the NEW SHARED TEMP-TABLE definition which is not in the SHARED TEMP-T... Stanislav Lomany

06/27/2019

06:19 PM Feature #3809: ProDataSet support
The branch 3809c was updated to r11355 (XML serialization for DATASETs). Note that it is not yet rebased to latest tr... Ovidiu Maxiniuc
09:24 AM Feature #3809: ProDataSet support
I have dumped the schema for some TEMP-TABLE and the list of fields looks like this:... Ovidiu Maxiniuc
08:50 PM Feature #3815: more temp-table options
I'll attach some testcases here. Note that at this point they do not work "out of the box" because of #3815-41. You h... Stanislav Lomany
08:40 PM Feature #3815: more temp-table options
3815a has been merged into the trunk as bzr revision 11320.
Stanislav Lomany

06/26/2019

07:26 PM Feature #3815: more temp-table options
Rebased task branch 3815a from P2J trunk revision 11319. Stanislav Lomany
05:36 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> > I can live with the @Text.assign(clob)@ issue temporarily if the runtime conversion chan...
Eric Faulhaber
05:19 PM Feature #3815: more temp-table options
> I can live with the @Text.assign(clob)@ issue temporarily if the runtime conversion changes you have in mind are ti... Stanislav Lomany
05:10 PM Feature #3815: more temp-table options
Stanislav, what information do you need from the NEW SHARED TEMP-TABLE definition which is not in the SHARED TEMP-TAB... Eric Faulhaber
11:41 AM Feature #3815: more temp-table options
The NEW (SHARED) TEMP-TABLES are tracked by @SharedVariableManager@. See @addTempTable()@ and @lookupTempTable()@ met... Ovidiu Maxiniuc
10:12 AM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> I need help with an idea for the fix. @getStaticTempTableDepth(String name)@ searches for ...
Eric Faulhaber
10:00 AM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> > I'm not crazy about the addition of @Text.assign(clob)@, since this is an ancestor class...
Eric Faulhaber
04:09 AM Feature #3815: more temp-table options
> @TempTableBuilder@: what is special about @ParmType.CLOB@ that we use @toLowerCase@ on this type and not on any of ... Stanislav Lomany

06/25/2019

04:17 PM Feature #3815: more temp-table options
I need help with an idea for the fix. @getStaticTempTableDepth(String name)@ searches for the table using @(table-nam... Stanislav Lomany
03:42 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> I found an issue: @add-fields-from@ and @add-like-field@ cannot find the source LIKE table...
Eric Faulhaber
03:40 PM Feature #3815: more temp-table options
I found an issue: @add-fields-from@ and @add-like-field@ cannot find the source LIKE table if it is a shared table. T... Stanislav Lomany

06/24/2019

06:13 AM Feature #3815: more temp-table options
> I'm not crazy about the addition of @Text.assign(clob)@, since this is an ancestor class that is now aware of its d... Stanislav Lomany
05:56 AM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Ovidiu, is 3809c in a state that is read for code review?
I added some unfinished code at t...
Ovidiu Maxiniuc
12:46 AM Feature #3809: ProDataSet support
Ovidiu, is 3809c in a state that is read for code review?
I'm sorry I do not have an idea for your previous post ATM.
Eric Faulhaber

06/23/2019

04:56 PM Feature #3816: table and table handle parameter options
Most of the code in @testcases/uast/oo/@ converts OK (not all, but most). Please post your sample here for review. Greg Shah

06/21/2019

03:58 PM Feature #3816: table and table handle parameter options
Adding skeleton helped to pass the errors above. However I cannot convert a file referencing a class. I suppose it ma... Stanislav Lomany

06/20/2019

05:09 PM Feature #3816: table and table handle parameter options
> Do we support 4GL classes (.cls)?
Yes, most use cases are already supported. See #3751.
You probably need to ...
Greg Shah
04:07 PM Feature #3816: table and table handle parameter options
Do we support 4GL classes (@.cls@)?... Stanislav Lomany
03:58 PM Feature #3815: more temp-table options
Code Review Task Branch 3815a Revision 11327
The @src/com/goldencode/p2j/uast/*@ changes are fine. I didn't look ...
Greg Shah
02:52 PM Feature #3815: more temp-table options
Code review 3815a/11327:
Nice update. A few things to consider...
Not your issue, but rather the correction of ...
Eric Faulhaber
09:43 AM Feature #3809: ProDataSet support
I have the following issue while working on save/merging changes back to DATA-SOURCE: how to identify the records/row... Ovidiu Maxiniuc

06/18/2019

03:59 PM Feature #3816 (WIP): table and table handle parameter options
I have a couple of questions about testcases:
# Is there a runner file for this set of testcases? I couldn't find on...
Stanislav Lomany

06/17/2019

04:44 AM Feature #3815: more temp-table options
> Please review 3815a rev 11327.
FYI it passed regression testing.
Stanislav Lomany

06/15/2019

11:16 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
It told me that the @com.sun.proxy.*@ join point weaves were @... advised by around advice from 'com.goldencode.p2j.a... Eric Faulhaber
09:34 PM Feature #3815: more temp-table options
Please review 3815a rev 11327. Stanislav Lomany

06/14/2019

04:20 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
Eric Faulhaber wrote:
> Hynek, AspectJ is executing a join point for methods outside the scope I am trying to define...
Hynek Cihlar
03:58 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
Hynek, AspectJ is executing a join point for methods outside the scope I am trying to define. For instance, this dyna... Eric Faulhaber
03:03 PM Feature #3815: more temp-table options
Rebased task branch 3815a from P2J trunk revision 11317. Stanislav Lomany
02:40 PM Feature #3815: more temp-table options
> How extensive are the changes?
60 core lines of separate rules.
> Are they likely to be expanded later?
I...
Stanislav Lomany
01:48 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> I put some code page conversion rules into @annotations/sorting.rules@, but because it's n...
Eric Faulhaber
01:40 PM Feature #3815: more temp-table options
I put some code page conversion rules into @annotations/sorting.rules@, but because it's not sorting-related rules, s... Stanislav Lomany
09:16 AM Feature #3815: more temp-table options
Create a task that describes the quirk, make Eric and myself watchers and make it related to this task. Greg Shah
08:41 AM Feature #3815: more temp-table options
FYI, I'm not going to implement #3815-47 quirk because it requires to create hierarchy tracking mechanism for an unre... Stanislav Lomany
08:32 AM Feature #3815: more temp-table options
> > I've found that the CODEPAGE can be inherited from another permanent or temp-table through either table- or field... Stanislav Lomany

06/13/2019

06:08 PM Feature #3815: more temp-table options
The @init@ block can be found using the @controlid@ annotation in the inner block node.
See @save_control_point_...
Greg Shah
04:57 PM Feature #3815: more temp-table options
Guys, can you give me an advice how to emit something at @Init@ section of the external procedure or in the main bloc... Stanislav Lomany
09:21 AM Bug #3960: localedef problems in Ubuntu 18.04
I've committed this change in branch 4069a as revision 11320. Greg Shah

06/12/2019

04:03 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> [...]
> Although this is for parameter passing in methods, I suspect it also is the same behavio...
Ovidiu Maxiniuc
03:42 PM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> I wonder if our interceptor within @ChangeBroker@ is preventing Hibernate from realizing tha...
Ovidiu Maxiniuc
11:05 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > What do you mean here by "not updated in database"? The records ...
Eric Faulhaber
10:49 AM Feature #3809: ProDataSet support
> I quote: the number of columns, data types, and so on. What does "and so on" mean? The name maybe? Well, not.
Pl...
Greg Shah
10:11 AM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> What do you mean here by "not updated in database"? The records still exist after we attempt...
Ovidiu Maxiniuc
10:00 AM Feature #3809: ProDataSet support
I've leant something about the TEMP-TABLE that is not documented. At least for GET-CHANGES, the source and destinatio... Ovidiu Maxiniuc
09:48 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Everything works fine, except one thing: in rare cases (only on DELETE operations, see @Tem...
Eric Faulhaber
08:38 AM Feature #3809: ProDataSet support
I have the following issue.
In a previous commit to 3809c I enriched the DMO with two new fields: @_rowState@ and @_...
Ovidiu Maxiniuc
03:35 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
I've added all the suggested features except the @Totals@ row (will add in a separate pass). I've rebased 4056a to tr... Eric Faulhaber
12:16 PM Feature #3815: more temp-table options
Agreed. Unless there is a technical advantage to using a @Resolvable@ (e.g., re-usability), we generally prefer to us... Eric Faulhaber
12:15 PM Feature #3815: more temp-table options
Use a lambda. This is easily done. See @convert/expressions.rules@ and the usage of @tw.graft("lambda_expr", copy, ... Greg Shah
12:09 PM Feature #3815: more temp-table options
Looks like the code page expression should be resolvable/lambda. Yes, it is evaluated once, but it can depend on the ... Stanislav Lomany

06/11/2019

01:47 PM Feature #3815: more temp-table options
An interesting observation. Consider we declared a shared temp-table:... Stanislav Lomany
05:03 AM Feature #3815: more temp-table options
> Which one are you suggesting? I did not design these classes, nor @TableMapper@, but it seems we split legacy infor... Stanislav Lomany
01:42 PM Bug #3960: localedef problems in Ubuntu 18.04
Greg Shah wrote:
> > Can someone that is running on Ubuntu 16.04 test this new locale definition on the old localede...
Eric Faulhaber
11:55 AM Bug #3960: localedef problems in Ubuntu 18.04
> Can someone that is running on Ubuntu 16.04 test this new locale definition on the old localedef?
Did this work?
Greg Shah
11:49 AM Bug #3960: localedef problems in Ubuntu 18.04
Greg Shah wrote:
> Can someone that is running on Ubuntu 16.04 test this new locale definition on the old localedef?...
Eric Faulhaber

06/10/2019

05:34 PM Feature #3815: more temp-table options
>> Code page is set in the separate function TemporaryBuffer.setCodePage(buffer, fieldName, codepage). The question i... Greg Shah
05:26 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> Guys, I want to know your opinion on how to better implement code page inheritance. We hav...
Eric Faulhaber
09:12 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
This looks very useful. Some suggested improvements for the output:
* Instead of @Agg Time@ use @Agg Time (nanose...
Greg Shah
02:12 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Attached is some Hotel GUI sample trace output showing aggregate times (nanosec) and invocation counts by top-level t... Eric Faulhaber

06/09/2019

02:43 PM Feature #3815: more temp-table options
Guys, I want to know your opinion on how to better implement code page inheritance. We have the following things to c... Stanislav Lomany
 

Also available in: Atom