Project

General

Profile

Activity

From 06/21/2019 to 07/20/2019

07/20/2019

08:44 AM Feature #3809: ProDataSet support
After fixing #3860-63, to allow runtime-specification of default databases per a project, I get a validation exceptio... Constantin Asofiei
08:38 PM Feature #3809: ProDataSet support
I've placed some notes to #3816-34, #3816-35, #3816-36, as that task handles @BY-REFERENCE@ (only for tables). But t... Constantin Asofiei
08:44 AM Feature #3816: table and table handle parameter options
Constantin Asofiei wrote:
> To continue with previous notes, as it may be related to @TABLE-HANDLE@, too: I think a ...
Constantin Asofiei
05:57 AM Feature #3816: table and table handle parameter options
To continue with previous notes, as it may be related to @TABLE-HANDLE@, too: I think a @DELETE@ for a @DATASET-HANDL... Constantin Asofiei
08:36 PM Feature #3816: table and table handle parameter options
The static dataset delete was just a minor issue. Even if I'm assuming that INPUT-OUTPUT behaves the same as BY-REFE... Constantin Asofiei

07/19/2019

07:56 PM Feature #3816: table and table handle parameter options
Looks like this states that the 'delete will not happen if the DATASET is not owned by the procedure attempting the d... Constantin Asofiei
07:20 PM Feature #3816: table and table handle parameter options
I found in a project code like this:... Constantin Asofiei
01:13 PM Feature #3816: table and table handle parameter options
Stanislav Lomany wrote:
> Guys, I'm interested, how technically we can pass a table parameter by reference? In this ...
Eric Faulhaber
08:55 PM Feature #3816: table and table handle parameter options
Guys, I'm interested, how technically we can pass a table parameter by reference? In this case 4GL passes the default... Stanislav Lomany
05:58 PM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, as we discussed, I need NEXT-ROWID, BATCH-SIZE and R...
Ovidiu Maxiniuc
02:46 PM Feature #3809: ProDataSet support
The other part which I need is dynamic construction of a DATA-SET from a DataSetContainer received from a remote side... Constantin Asofiei
09:53 AM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, as we discussed, I need NEXT-ROWID, BATCH-SIZE and RESTART-ROWID to work.
I s...
Ovidiu Maxiniuc
09:05 AM Feature #3809: ProDataSet support
Ovidiu, as we discussed, I need NEXT-ROWID, BATCH-SIZE and RESTART-ROWID to work. Constantin Asofiei

07/17/2019

08:24 PM Feature #3816: table and table handle parameter options
> Temp-tables declared as REFERENCE-ONLY are initialized in FWD as usual buffers (i.e. StaticTempTable is created and... Greg Shah

07/16/2019

05:28 PM Feature #3816: table and table handle parameter options
Some thoughts about BIND:
# Temp-tables declared as @REFERENCE-ONLY@ are initialized in FWD as usual buffers (i.e. @...
Stanislav Lomany
10:00 PM Feature #4011: database/persistence layer performance improvements
Running the instrumentation added in trunk rev 11323 (#4056) has indicated that common persistence scenarios spend a ... Eric Faulhaber
09:59 PM Feature #4016: replace portions of Hibernate which are non-performant
Based on further analysis, including using the persistence instrumentation (#4056), we have decided to remove as much... Eric Faulhaber

07/15/2019

04:13 PM Bug #4035 (Closed): newly created record is not flushed at the right time
4035a/11327 passed main regression testing and ETF. I rebased to trunk rev 11325, merged to trunk, and committed as t... Eric Faulhaber
11:00 PM Bug #4035: newly created record is not flushed at the right time
To summarize the idea:
* Any FOR BLOCK or FOR LOOP causes a special aggressive flushing mode to occur when all the...
Greg Shah
10:44 PM Bug #4035: newly created record is not flushed at the right time
Code Review Task Branch 4035a Revision 11327
I'm OK with the changes. I think they accurately implement the behav...
Greg Shah
10:11 PM Bug #4035: newly created record is not flushed at the right time
Greg, aggressive buffer flush mode support was added in 4035a/11327. It fixes the @buf1.p@/@buf2.p@ test case and fix... Eric Faulhaber
10:22 AM Feature #3816: table and table handle parameter options
After I've rebased to the latest trunk, the errors of the following type occur:... Stanislav Lomany

07/14/2019

07:44 PM Feature #3809: ProDataSet support
Ovidiu, please look at 4124a rev 11336 - it fixes the DatasetContainer so that it works with appserver calls. Constantin Asofiei
04:19 AM Feature #3816: table and table handle parameter options
Rebased task branch 3816a from P2J trunk revision 11325. Stanislav Lomany

07/13/2019

06:27 AM Feature #3809: ProDataSet support
4124a rev 11333 fixes a naming issue with DATASET or TABLE parameters, when the source is in a super-class: for DATAS... Constantin Asofiei

07/12/2019

04:42 PM Feature #3809: ProDataSet support
3809d was merged to 4124a rev 11329 and dead-archived. Constantin Asofiei
02:42 PM Feature #3809: ProDataSet support
Branch 3809c passed MAJIC testing and was merged to trunk rev 11325, and archived. It contains changes:
* OM: many ...
Constantin Asofiei
02:21 PM Feature #3809: ProDataSet support
Please merge 3809c to trunk. Greg Shah
02:02 PM Feature #3809: ProDataSet support
Runtime testing (main part) passed with 3809c rev 11382. Constantin Asofiei
02:24 AM Feature #4056: instrument FWD and supporting libraries to measure database performance
Branch 4056a was merged to trunk revision 11323. It passed ChUI conversion and runtime regression testing (the latter... Eric Faulhaber

07/11/2019

03:53 PM Bug #4035: newly created record is not flushed at the right time
Eric Faulhaber wrote:
> Yes, it works if ALL indexed fields are updated after the second create book.
Even if you e...
Constantin Asofiei
03:45 PM Bug #4035: newly created record is not flushed at the right time
Yes, it works if ALL indexed fields are updated after the second @create book@.
However, I'm not sure that forcing...
Eric Faulhaber
03:20 PM Bug #4035: newly created record is not flushed at the right time
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, some thoughts: for indexed fields, maybe we should assu...
Constantin Asofiei
03:17 PM Bug #4035: newly created record is not flushed at the right time
Constantin Asofiei wrote:
> Eric, some thoughts: for indexed fields, maybe we should assume that when a (sub)tx bloc...
Eric Faulhaber
03:10 PM Bug #4035: newly created record is not flushed at the right time
Eric, some thoughts: for indexed fields, maybe we should assume that when a (sub)tx block iterates, its indexed field... Constantin Asofiei
03:05 PM Bug #4035: newly created record is not flushed at the right time
Greg Shah wrote:
> Are the buffer scopes the same as the converted code? Based on what you told me previously, the ...
Eric Faulhaber
02:56 PM Bug #4035: newly created record is not flushed at the right time
Are the buffer scopes the same as the converted code? Based on what you told me previously, the transaction scoping ... Greg Shah
02:53 PM Bug #4035: newly created record is not flushed at the right time
Here are the compile listings for the test cases above (note: I have renamed them to @flush-buf1.p@ and @flush-buf2.p... Eric Faulhaber
02:51 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> > The problem is time and the fact that the mapping are to PPTT constants, which started to be ve...
Ovidiu Maxiniuc
02:44 PM Feature #3809: ProDataSet support
If the branch passes ChUI regression testing, I am good with it being merged to trunk. Eric Faulhaber
02:26 PM Feature #3809: ProDataSet support
> The problem is time and the fact that the mapping are to PPTT constants, which started to be very cryptic. I will p... Greg Shah
02:19 PM Feature #3809: ProDataSet support
Greg Shah wrote:
> Code Review Task Branch 3809c Revisions 11325 through 11380
> I only reviewed the changes in @ut...
Ovidiu Maxiniuc
01:57 PM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Code review task branch 3809c, rev 11326-11375 (part 4):
> @RecordBuffer@:
>
> * Please ...
Ovidiu Maxiniuc
01:57 PM Feature #3809: ProDataSet support
Code Review Task Branch 3809c Revisions 11325 through 11380
I only reviewed the changes in @util/@ and @uast/@. I...
Greg Shah
01:10 PM Feature #3809: ProDataSet support
Ovidiu, FYI, I have committed in rev 11380 some very minor format and typo cleanups that I made inline during my code... Eric Faulhaber
10:39 AM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Code review task branch 3809c, rev 11326-11375 (part 3):
>
> @CallbackData@: Should @geTa...
Ovidiu Maxiniuc
01:25 AM Feature #3809: ProDataSet support
Performance/Resource Concerns:
As noted earlier, these are things that stood out to me, but I obviously haven't do...
Eric Faulhaber
01:15 AM Feature #3809: ProDataSet support
Code review task branch 3809c, rev 11326-11375 (part 4):
@RecordBuffer@:
* Please use proper logging instead of...
Eric Faulhaber
12:07 AM Feature #3809: ProDataSet support
Code review task branch 3809c, rev 11326-11375 (part 3):
@CallbackData@: Should @geTarget@ be @getTarget@? It is c...
Eric Faulhaber
01:59 PM Feature #3816: table and table handle parameter options
FYI, branch 3809c has significant changes/improvements to table parameter processing (and dataset parameter processin... Greg Shah
10:47 AM Feature #3816: table and table handle parameter options
The priority should be on the implementation of conversion and runtime support for the core features listed in #3816-... Greg Shah
09:45 AM Feature #3816: table and table handle parameter options
Created task branch 3816a from P2J trunk revision 11324. Stanislav Lomany
09:11 AM Feature #3816: table and table handle parameter options
Okay, I fixed NPE and now I can get meaningful results for the testcases. It is about a hundred of testcases. I didn'... Stanislav Lomany

07/10/2019

04:25 PM Feature #3816: table and table handle parameter options
Good, thank you! @convert/buffer_definitions.rules@ has this variable... Stanislav Lomany
04:13 PM Feature #3816: table and table handle parameter options
One has it and the other does not. I've attached my output (I changed the @.p@ names but the code is the same). Greg Shah
03:47 PM Feature #3816: table and table handle parameter options
Yes, convert both attached files in a single run and check if @TemporaryBuffer.createDynamicTable@ presents in both c... Stanislav Lomany
03:45 PM Feature #3816: table and table handle parameter options
Do you have a standalone testcase I can use? Greg Shah
03:37 PM Feature #3816: table and table handle parameter options
Could someone please confirm the issue from the previous note? That it's not an issue with my RAM. Stanislav Lomany
09:47 AM Feature #3816: table and table handle parameter options
Consider we have two procedures:... Stanislav Lomany
09:31 PM Feature #3816: table and table handle parameter options
There is a procedure @dataset/help/get_tt_num_rows.p@ which is used by pretty much all testcases (which now they are ... Stanislav Lomany
03:28 PM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> @AbstractTempTable@: Why do we override/implement the @readXml@ methods in this abstract cla...
Ovidiu Maxiniuc
02:37 PM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> * Is it necessary for @buffer()@ to be @public@? I went through great pains to keep it @prot...
Hynek Cihlar
02:09 PM Feature #3809: ProDataSet support
Code review task branch 3809c, rev 11326-11375 (part 2 - I am not done with the runtime review yet, but I wanted to g... Eric Faulhaber
10:26 AM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > Constantin, could you review Hynek's changes?
> I'm OK with...
Hynek Cihlar
09:00 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Constantin, could you review Hynek's changes?
I'm OK with the OO changes.
Hynek, btw, I...
Constantin Asofiei
07:42 AM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Code review task branch 3809c, rev 11326-11375 (part 1):
>
> Ovidiu, this is quite an imp...
Ovidiu Maxiniuc
12:20 AM Feature #3809: ProDataSet support
Code review task branch 3809c, rev 11326-11375 (part 1):
Ovidiu, this is quite an impressive update! I am still re...
Eric Faulhaber

07/09/2019

07:23 AM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, please work with high priority on DATASET support for appserver - follow how @Ta...
Ovidiu Maxiniuc
07:22 AM Feature #3809: ProDataSet support
Ovidiu, please work with high priority on DATASET support for appserver - follow how @TableResultSet@ and @TableWrapp... Constantin Asofiei
04:25 AM Feature #3809: ProDataSet support
I've started the rebase process to latest trunk. Thanks for notifying me. I was about to overwrite your revision. Ovidiu Maxiniuc
04:23 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> BTW: Hynek, please review your changes in r11370. I encountered several conflicts with @Jso...
Hynek Cihlar

07/08/2019

04:32 PM Feature #3809: ProDataSet support
Task branch 3809c was updated with ORIGIN-ROWID & DATA-SOURCE-ROWID implementations. Latest revision is: 11371. Ovidiu Maxiniuc
10:45 AM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> Ovidiu, can 3809c be tested and merged to trunk in the near future? I need both Hynek's...
Ovidiu Maxiniuc
07:47 AM Feature #3809: ProDataSet support
Ovidiu, can 3809c be tested and merged to trunk in the near future? I need both Hynek's JSON changes and dataset run... Constantin Asofiei
06:13 AM Feature #3809: ProDataSet support
The trunk revision number has increased by 2. I am starting the rebase op now. Ovidiu Maxiniuc

07/07/2019

06:13 PM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Hynek Cihlar wrote:
> > Ovidiu, I have some code changes to @JsonExport@ I'd like to merge...
Hynek Cihlar
04:44 PM Feature #4056: instrument FWD and supporting libraries to measure database performance
Task branch 4056a has been rebased to trunk rev 11322. Eric Faulhaber

07/05/2019

05:37 PM Feature #3809: ProDataSet support
I updated the branch to r11365. Note that the temporary DMO will change a bit. (JSON not affected) Ovidiu Maxiniuc
09:08 AM Feature #3809: ProDataSet support
Hynek Cihlar wrote:
> Ovidiu, I have some code changes to @JsonExport@ I'd like to merge with your changes and deliv...
Ovidiu Maxiniuc
05:05 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Hynek Cihlar wrote:
> > Ovidiu please check in the class @ThrowingConsumer@. Do you have o...
Hynek Cihlar
05:04 AM Feature #3809: ProDataSet support
Ovidiu, I have some code changes to @JsonExport@ I'd like to merge with your changes and deliver to the branch. If yo... Hynek Cihlar

07/04/2019

01:33 PM Feature #3809: ProDataSet support
Btw, I would like to merge JSON & XML export classes to use a single output code because both these classes write the... Ovidiu Maxiniuc
01:27 PM Feature #3809: ProDataSet support
Hynek Cihlar wrote:
> Ovidiu please check in the class @ThrowingConsumer@. Do you have other upcoming changes for @J...
Ovidiu Maxiniuc
12:29 PM Feature #3809: ProDataSet support
Ovidiu please check in the class @ThrowingConsumer@. Do you have other upcoming changes for @JsonExport@? Hynek Cihlar
10:39 AM Support #3871: determine how to change codepages/locales during import
In this task we are understanding and resolving issues related to reading a database dump (@.d@ files) which has data... Greg Shah
04:15 AM Support #3871: determine how to change codepages/locales during import
Greg, what exactly do you need us to do on this one?
Albeit related the code page character encoding and the colla...
Marian Edu

07/03/2019

04:14 PM Feature #4128: defer transaction start until the time when real edits begin
It is my understanding that starting in OpenEdge 11.x, the default behavior is to defer transaction start until the t... Greg Shah
04:13 PM Feature #4128 (New): defer transaction start until the time when real edits begin
Greg Shah
02:27 PM Feature #3815: more temp-table options
> Place it in 3855b.
Committed rev 11329.
Stanislav Lomany
08:27 AM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> Where I can put the fix?
Place it in 3855b.
Constantin Asofiei

07/02/2019

04:46 PM Feature #3816: table and table handle parameter options
> One thing that you MUST do is to include the @oo/Printme.cls@ in the conversion list. I suspect that is your issue... Stanislav Lomany
04:44 PM Feature #3815: more temp-table options
> For now, I would just drop any code related to a temp-table definition in an interface
I couldn't do it at this ...
Stanislav Lomany

07/01/2019

02:59 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> Do you, guys, know, if a code page of a temp-table field defined in an interface have an a...
Constantin Asofiei
02:58 PM Feature #3815: more temp-table options
Do you, guys, know, if a code page of a temp-table field defined in an interface have an actual effect? Temp-table de... Stanislav Lomany
11:43 AM Feature #3815: more temp-table options
From Constantin: conversion fails because of a TEMP-TABLE with a COLUMN-CODEPAGE field defined in an interface.
<p...
Stanislav Lomany
10:42 AM Feature #3809: ProDataSet support
Ovidiu Maxiniuc wrote:
> Apparently the revision 11359 added some changes, but the @JsonBackend@ file is missing. Hy...
Ovidiu Maxiniuc
06:43 AM Feature #3809: ProDataSet support
Apparently the revision 11359 added some changes, but the @JsonBackend@ file is missing. Hynek, please add it.
LE: T...
Ovidiu Maxiniuc
06:34 AM Feature #3809: ProDataSet support
Constantin Asofiei wrote:
> For JSON serialization, I need the legacy table and field names - but these are lowercas...
Ovidiu Maxiniuc
06:27 AM Feature #3809: ProDataSet support
Hynek Cihlar wrote:
> 3809c build fails with:
>
> [...]
You are correct. On Friday I commit my changes then I ...
Ovidiu Maxiniuc

06/30/2019

05:09 PM Feature #3809: ProDataSet support
3809c build fails with:... Hynek Cihlar
05:07 PM Feature #3809: ProDataSet support
For JSON serialization, I need the legacy table and field names - but these are lowercased in FWD, I can't find a way... Constantin Asofiei

06/29/2019

01:33 AM Feature #3816: table and table handle parameter options
Please post both the test driver and the @Printme.cls@ or commit them to @testcases/uast/@.
One thing that you MUS...
Greg Shah

06/28/2019

07:12 PM Feature #3809: ProDataSet support
The branch 3809c was rebased to latest trunk and updated to r11358 (includes XMLSCHEMA serialization for DATASETs). Ovidiu Maxiniuc
06:18 PM Feature #3816: table and table handle parameter options
> Most of the code in @testcases/uast/oo/@ converts OK (not all, but most). Please post your sample here for review.
...
Stanislav Lomany
08:34 PM Feature #3815: more temp-table options
> Stanislav, what information do you need from the NEW SHARED TEMP-TABLE definition which is not in the SHARED TEMP-T... Stanislav Lomany

06/27/2019

06:19 PM Feature #3809: ProDataSet support
The branch 3809c was updated to r11355 (XML serialization for DATASETs). Note that it is not yet rebased to latest tr... Ovidiu Maxiniuc
09:24 AM Feature #3809: ProDataSet support
I have dumped the schema for some TEMP-TABLE and the list of fields looks like this:... Ovidiu Maxiniuc
08:50 PM Feature #3815: more temp-table options
I'll attach some testcases here. Note that at this point they do not work "out of the box" because of #3815-41. You h... Stanislav Lomany
08:40 PM Feature #3815: more temp-table options
3815a has been merged into the trunk as bzr revision 11320.
Stanislav Lomany

06/26/2019

07:26 PM Feature #3815: more temp-table options
Rebased task branch 3815a from P2J trunk revision 11319. Stanislav Lomany
05:36 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> > I can live with the @Text.assign(clob)@ issue temporarily if the runtime conversion chan...
Eric Faulhaber
05:19 PM Feature #3815: more temp-table options
> I can live with the @Text.assign(clob)@ issue temporarily if the runtime conversion changes you have in mind are ti... Stanislav Lomany
05:10 PM Feature #3815: more temp-table options
Stanislav, what information do you need from the NEW SHARED TEMP-TABLE definition which is not in the SHARED TEMP-TAB... Eric Faulhaber
11:41 AM Feature #3815: more temp-table options
The NEW (SHARED) TEMP-TABLES are tracked by @SharedVariableManager@. See @addTempTable()@ and @lookupTempTable()@ met... Ovidiu Maxiniuc
10:12 AM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> I need help with an idea for the fix. @getStaticTempTableDepth(String name)@ searches for ...
Eric Faulhaber
10:00 AM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> > I'm not crazy about the addition of @Text.assign(clob)@, since this is an ancestor class...
Eric Faulhaber
04:09 AM Feature #3815: more temp-table options
> @TempTableBuilder@: what is special about @ParmType.CLOB@ that we use @toLowerCase@ on this type and not on any of ... Stanislav Lomany

06/25/2019

04:17 PM Feature #3815: more temp-table options
I need help with an idea for the fix. @getStaticTempTableDepth(String name)@ searches for the table using @(table-nam... Stanislav Lomany
03:42 PM Feature #3815: more temp-table options
Stanislav Lomany wrote:
> I found an issue: @add-fields-from@ and @add-like-field@ cannot find the source LIKE table...
Eric Faulhaber
03:40 PM Feature #3815: more temp-table options
I found an issue: @add-fields-from@ and @add-like-field@ cannot find the source LIKE table if it is a shared table. T... Stanislav Lomany

06/24/2019

06:13 AM Feature #3815: more temp-table options
> I'm not crazy about the addition of @Text.assign(clob)@, since this is an ancestor class that is now aware of its d... Stanislav Lomany
05:56 AM Feature #3809: ProDataSet support
Eric Faulhaber wrote:
> Ovidiu, is 3809c in a state that is read for code review?
I added some unfinished code at t...
Ovidiu Maxiniuc
12:46 AM Feature #3809: ProDataSet support
Ovidiu, is 3809c in a state that is read for code review?
I'm sorry I do not have an idea for your previous post ATM.
Eric Faulhaber

06/23/2019

04:56 PM Feature #3816: table and table handle parameter options
Most of the code in @testcases/uast/oo/@ converts OK (not all, but most). Please post your sample here for review. Greg Shah

06/21/2019

03:58 PM Feature #3816: table and table handle parameter options
Adding skeleton helped to pass the errors above. However I cannot convert a file referencing a class. I suppose it ma... Stanislav Lomany
 

Also available in: Atom