FWD » Core Development » Database

01/31/2020

05:45 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Eric, I understand that the "altered" bits allow to update only some of fields of a record.... Eric Faulhaber

04:44 PM Feature #4011: database/persistence layer performance improvements

Eric, I understand that the "altered" bits allow to update only some of fields of a record. The idea is good but I ha... Ovidiu Maxiniuc

03:34 PM Feature #4011: database/persistence layer performance improvements

Separate idea, Ovidiu, for the caching of converted FQL statements...
A lot of 4GL code I've seen has a pattern li... Eric Faulhaber

03:22 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Well, wait a minute. The savepoint is tightly bracketed to just that validating update, so I... Ovidiu Maxiniuc

03:15 PM Feature #4011: database/persistence layer performance improvements

I think we're ok on both the explicit RELEASE statement validate/flush as well as the implicit validate/flush when a ... Eric Faulhaber

03:12 PM Feature #4011: database/persistence layer performance improvements

Well, wait a minute. The savepoint is tightly bracketed to just that validating update, so I suppose I could just rol... Eric Faulhaber

02:44 PM Feature #4011: database/persistence layer performance improvements

Perhaps in the @VALIDATE@ case we can have a routine that implements the multiple queries approach. It is not optima... Greg Shah

02:30 PM Feature #4011: database/persistence layer performance improvements

I was thinking of @RELEASE@, too. However, the release will automatically issue a FLUSH routine, indirectly validatin... Ovidiu Maxiniuc

02:30 PM Feature #4011: database/persistence layer performance improvements

Constantin Asofiei wrote:
> Eric, does the above include what VALIDATE does in 4GL?
That's a good point. No, I wa... Eric Faulhaber

02:29 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Yes, I totally agree with the change of the way records are handled on rollback events. And... Eric Faulhaber

02:25 PM Feature #4011: database/persistence layer performance improvements

Eric, does the above include what VALIDATE does in 4GL? Constantin Asofiei

02:14 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I have been reworking the DMO validation processing to take advantage of the fact that we have removed hibern... Eric Faulhaber

11:45 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> Constantin: Are you planning to use an H2 database for storing project state?
Yes Constantin Asofiei

11:45 AM Bug #3471: incremental conversion is regressed

Constantin: Are you planning to use an H2 database for storing project state? Greg Shah

09:31 AM Bug #4450: implement shared query and shared browse

Marian: Open questions which I'm hoping you can answer (see #4450-36):
* Is there any way to use a shared browse i... Greg Shah

01/27/2020

05:15 PM Feature #3813: misc DB features part deux

Eric Faulhaber wrote:
> For implementation of the @DBPARAM@ builtin function, correct. For those options which we in... Igor Skornyakov

05:09 PM Feature #3813: misc DB features part deux

For implementation of the @DBPARAM@ builtin function, correct. For those options which we intend to add support, the ... Eric Faulhaber

04:09 PM Feature #3813: misc DB features part deux

Eric Faulhaber wrote:
> The original, ordered list approach was based on a very limited set of connection options, w... Igor Skornyakov

03:52 PM Feature #3813: misc DB features part deux

The original, ordered list approach was based on a very limited set of connection options, which were basically the m... Eric Faulhaber

03:47 PM Feature #3813: misc DB features part deux

Eric Faulhaber wrote:
> Hm, you're correct, that conversion looks completely wrong. I think the conversion may have ... Igor Skornyakov

03:34 PM Feature #3813: misc DB features part deux

Hm, you're correct, that conversion looks completely wrong. I think the conversion may have been broken along the way... Eric Faulhaber

02:40 PM Feature #3813: misc DB features part deux

The conversion of the @CONNECT@ statement looks a little bit strange.
For example. The statement ... Igor Skornyakov

11:38 AM Bug #3471: incremental conversion is regressed

I believe the original issue of the task is gone now as recently Adrian replaced the @schema-triggers@ two-stage trig... Ovidiu Maxiniuc

11:26 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> The first phase is part of the 4-6 weeks?
Yes.
> The second phase is the extra 3-4 days?
Yes,... Constantin Asofiei

11:13 AM Bug #3471: incremental conversion is regressed

>>> I plan to rely on an explicit list of files to 'incrementally convert'.
>>
>> We would build this list automati... Greg Shah

10:29 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> > automatic incremental conversion
>
> By this do you mean item 3 in #3471-7/?
Yes.
> > I pl... Constantin Asofiei

09:49 AM Bug #3471: incremental conversion is regressed

> automatic incremental conversion
By this do you mean item 3 in #3471-7/?
> I plan to rely on an explicit list... Greg Shah

09:32 AM Bug #3471: incremental conversion is regressed

I think it will take ~4-6 weeks to complete and stabilize. I've been working on identifying and analyzing the parts ... Constantin Asofiei

01/24/2020

05:53 PM Feature #3815 (Closed): more temp-table options

Greg Shah

02:04 PM Feature #3815: more temp-table options

Task #4520 was created for the inheritance from permanent to temp tables issue. This task can be closed. Stanislav Lomany

02:01 PM Bug #4520: Implement proper codepage inheritance from permanent to temp tables

A code page can be set for a clob field of a permanent table. E.g.... Stanislav Lomany

01:41 PM Bug #4520 (New): Implement proper codepage inheritance from permanent to temp tables

Stanislav Lomany

11:55 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> Igor Skornyakov wrote:
> Did the original pf file you tested have parameters that are not relate... Igor Skornyakov

11:34 AM Feature #3813: misc DB features part deux

Igor Skornyakov wrote:
> All connection parameters from #3813-11 are accepted in the @CONNECT@ statement and are sho... Greg Shah

11:10 AM Feature #3813: misc DB features part deux

All connection parameters from #3813-11 are accepted in the @CONNECT@ statement and are shown by @DBPARAM@ in this case. Igor Skornyakov

08:22 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> One thing that was not clear from #3813-11: which of these items can be specified in the @CONNECT... Igor Skornyakov

08:17 AM Feature #3813: misc DB features part deux

>> I understand that I should add support for the remaining options in the CONNECT statement by just storing values a... Greg Shah

03:31 AM Feature #3813: misc DB features part deux

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > Can anybody help me to figure which of the database connection p... Igor Skornyakov

09:24 AM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...

Greg Shah wrote:
> Constantin: Did I write up the part about the UAST testcases correctly?
Yes.
> All: What is th... Constantin Asofiei

08:11 AM Feature #4175 (WIP): add support for -1 (single user) option for CONNECT statement

Greg Shah

01/23/2020

06:15 PM Feature #3813: misc DB features part deux

Igor Skornyakov wrote:
> Can anybody help me to figure which of the database connection parameters described in the ... Eric Faulhaber

05:14 PM Feature #3813: misc DB features part deux

Can anybody help me to figure which of the database connection parameters described in the previous note have direct ... Igor Skornyakov

05:02 PM Feature #3813: misc DB features part deux

Here is a (hopefully) complete list of database connection parameters shown by @DBPARAM@ function.
|_.Parameter|_.De... Igor Skornyakov

04:02 PM Feature #4011: database/persistence layer performance improvements

Yes, I totally agree with the change of the way records are handled on rollback events. And I firmly believe that, ev... Ovidiu Maxiniuc

02:07 PM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...

The buffer alias changes shouldn't affect any of the above. They are strictly regarding "proxying" any buffer paramet... Adrian Lungu

12:22 PM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...

Constantin: Did I write up the part about the UAST testcases correctly?
Adrian: Does your buffer alias work have a... Greg Shah

12:21 PM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...

The initial work was done as part of #3816. All of those changes are in trunk. As of trunk 11340, this is the statu... Greg Shah

11:59 AM Feature #4516 (New): testing and completion of runtime compatibility for table/table-handle/datas...

Greg Shah

12:28 PM Feature #3815: more temp-table options

>> Also I left a comment in the code which says that it's not clear if a temp-table inherits code page from a permane... Greg Shah

12:23 PM Feature #3816 (Closed): table and table handle parameter options

The final work will be done in #4516. Greg Shah

01/22/2020

05:49 PM Feature #3809 (Closed): ProDataSet support

Greg Shah

05:49 PM Feature #3809: ProDataSet support

All remaining work (of which I'm aware) related to ProDataSets is documented in these tasks:
* #4514 run ProDataSe... Greg Shah

05:42 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...

As part of the work to add ProDataSet support in #3809, a test suite was written to explore the behavior of the PDS f... Greg Shah

05:40 PM Feature #4514 (WIP): run ProDataSet test suite in FWD and resolve any issues such that it works t...

Greg Shah

02:01 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I want to run my ideas for planned changes to the undo architecture by you and get your input...
To the gr... Eric Faulhaber

07:32 AM Feature #4011: database/persistence layer performance improvements

> We might be able to create some custom bulk/mass get/set methods to call from these methods that might be more effi... Greg Shah

01:21 AM Feature #4011: database/persistence layer performance improvements

I'm not sure why you get the @VerifyError@.
I haven't considered the most efficient ways these methods might be wr... Eric Faulhaber

01/21/2020

04:01 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Yes, please go ahead and make the necessary changes to @DmoClass@ to add the missing signatu... Ovidiu Maxiniuc

03:33 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> > For example, I have a @.pf@ file with multiple parameters, but only two of them are included in... Igor Skornyakov

03:17 PM Feature #3813: misc DB features part deux

> For example, I have a @.pf@ file with multiple parameters, but only two of them are included in the @DBPARAM@ resul... Greg Shah

12:17 PM Feature #3813: misc DB features part deux

The following statement from the Progress documentation regarding @DBPARAM@ functions (see https://docs.progress.com/... Igor Skornyakov

09:06 AM Feature #2156: datetime-tz and hibernate

3809e was merged to trunk as revision 11340. Greg Shah

01/20/2020

07:02 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> @isTracked@ actually removes a record's key. That doesn't seem right. Maybe I'm not understa... Ovidiu Maxiniuc

06:17 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, please hold off making changes to @UniqueTracker@ related to the above post. I have begun refactoring the dir... Eric Faulhaber

04:15 AM Feature #3809: ProDataSet support

3809e passed ChUI and GUI regression tests. It was merged to trunk as revision 11340 and archived. Hynek Cihlar

01/17/2020

05:42 PM Feature #4011: database/persistence layer performance improvements

Another feature we need is an atomic, context-safe, check and update feature to update an index with a new record if ... Eric Faulhaber

04:41 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, thanks for the @UniqueTracker@ implementation. I am working to integrate this code now, but I have some quest... Eric Faulhaber

01/16/2020

06:15 PM Feature #4011: database/persistence layer performance improvements

Speaking of dynamic temp-tables, one of us is going to need to address the changes to the DMO interface design. Right... Eric Faulhaber

06:15 PM Feature #4011: database/persistence layer performance improvements

In email, Ovidiu Maxiniuc wrote:
> Have you had the time to add the support for extent properties? I am a bit bloc... Eric Faulhaber

07:36 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > ... The code is documented that _it is OK to do this with cached... Ovidiu Maxiniuc

01/15/2020

05:41 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> The nice part is that if this works correctly (apparently it did until now) it will also co... Eric Faulhaber

05:35 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> One more thing: I see the cache is context-local. Wouldn't it cover all connections if we m... Eric Faulhaber

05:21 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> ... The code is documented that _it is OK to do this with cached queries, because each use ... Eric Faulhaber

04:42 PM Feature #4011: database/persistence layer performance improvements

Eric,
after fixing some issues that surfaced while working with repetitive queries and client (re-)connections, my e... Ovidiu Maxiniuc

01/14/2020

04:32 PM Bug #4492: database trigger defined with abbreviation should create a new buffer

I agree, let's pause work on this. Greg Shah

04:24 PM Bug #4492: database trigger defined with abbreviation should create a new buffer

The root of the problem is clearly at a lower level than anticipated. After some code analysis, the parser is the one... Adrian Lungu

01/13/2020

01:32 PM Bug #4492: database trigger defined with abbreviation should create a new buffer

Finally, I've got to the responsible area in the conversion. Mainly it looks like a new @BUFFER-SCORE@ Progress Ast s... Adrian Lungu

05:55 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Greg Shah wrote:
> Didn't you previously find that some abbreviations were treated as the same buffer as @dummy@ but... Adrian Lungu

08:58 AM Feature #3813: misc DB features part deux

4335a Greg Shah

08:52 AM Feature #3813: misc DB features part deux

Which branch should I use for this task?
Thank you. Igor Skornyakov

08:21 AM Feature #3813 (WIP): misc DB features part deux

From Eric:
> Pending Ovidiu's review, I believe the rest of #3813-2 is now pretty accurate, though I don't know ho... Greg Shah

04:40 AM Feature #4011: database/persistence layer performance improvements

After addressing the items in #4011-61 through #4011-65, please consider and propose a design for a caching/optimizat... Eric Faulhaber

04:29 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, currently, we determine which implementation of @DirtyShareContext@ we use for a particular buffer by the typ... Eric Faulhaber

01/12/2020

10:13 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Didn't you previously find that some abbreviations were treated as the same buffer as @dummy@ but @dum@ was somehow s... Greg Shah

01/11/2020

09:56 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Issue #4492-1 is implying multiple changes regarding conversion:
# If the buffer used has the same name as the sch... Adrian Lungu

01/10/2020

10:46 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Issue #4492-5 fixed. @RecordBuffer.create()@ should have called the trigger before updating the @dirtyContext@, other... Adrian Lungu

08:52 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

There seems to be a sub-issue in #4492-1. The @find last@ statement will find the newly created record. In 4GL, an er... Adrian Lungu

09:22 AM Feature #4011: database/persistence layer performance improvements

The trick is to write the @hashCode@ and @equals@ methods generically, to operate only on those properties that are c... Eric Faulhaber

09:15 AM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> For the moment, I have one question, from 1st phrase, related to the key for the hash map/s... Eric Faulhaber

09:07 AM Feature #4011: database/persistence layer performance improvements

For the moment, I have one question, from 1st phrase, related to the key for the hash map/set: wouldn't it be a bit o... Ovidiu Maxiniuc

08:21 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, please implement a feature which uses @BitSet@ and @HashSet@ (or @HashMap@) to implement a tracker for record... Eric Faulhaber

01/09/2020

12:04 PM Bug #4492 (WIP): database trigger defined with abbreviation should create a new buffer

Adrian Lungu

01/08/2020

04:22 PM Feature #4011: database/persistence layer performance improvements

Tasks from note 59 are implemented and were pushed to branch 4011 as r11370. Ovidiu Maxiniuc

03:37 PM Bug #4450: implement shared query and shared browse

Roger Borrello wrote:
> These testcases are broken:
>
> ./uast/browse/shared_query_browse_frame.p
> ./uast/brows... Roger Borrello

02:08 PM Bug #4450: implement shared query and shared browse

These testcases are broken:
./uast/browse/shared_query_browse_frame.p
./uast/browse/shared_query_browse_frame-run... Roger Borrello

05:13 AM Bug #4450: implement shared query and shared browse

> The 4GL probably provides the ability to use a shared browse in more than one non-shared frame.
As far as I test... Stanislav Lomany

01/07/2020

06:57 PM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> 4450a was merged into 4207a as rev 11371.
I updated my 4207a to that rev, and customer ... Roger Borrello

06:05 PM Bug #4450: implement shared query and shared browse

4450a was merged into 4207a as rev 11371. Stanislav Lomany

09:34 AM Bug #4450: implement shared query and shared browse

Greg Shah wrote:
> Code Review Task Branch 4450a Revision 11342
>
> I'm good with the changes. Please merge them... Roger Borrello

09:27 AM Bug #4450: implement shared query and shared browse

Code Review Task Branch 4450a Revision 11342
I'm good with the changes. Please merge them into 4207a and then dea... Greg Shah

09:20 AM Bug #4450 (WIP): implement shared query and shared browse

Iterator issue and javadocs are fixed in 4450a rev 11342. (please note that I'll be unavailable for the next couple o... Stanislav Lomany

08:11 AM Bug #4450: implement shared query and shared browse

Please check in your changes and I will review. I'd like to have them merged into 4207a ASAP, if there is no issue.
... Greg Shah

08:02 AM Bug #4450: implement shared query and shared browse

Heh, I forgot to define a local iterator and and the one from the outer cycle was used.
The files in the customer's ... Stanislav Lomany

06:10 AM Bug #4450: implement shared query and shared browse

> 1. Why aren't shared browse instances registered with/imported from the SVM?
Browse widget is a part of a frame,... Stanislav Lomany

01/06/2020

05:54 PM Feature #4011: database/persistence layer performance improvements

Please go ahead and implement the conversion changes for the DMO interface simplification (i.e., moving the bulk meth... Eric Faulhaber

03:20 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> It seems we could rationalize the DMO interface and implementation class hierarchy a bit. Cu... Ovidiu Maxiniuc

02:09 PM Feature #4011: database/persistence layer performance improvements

Another issue I want to discuss for when I get back to the bulk getters and setter for extent fields in @DmoClass@...... Eric Faulhaber

01:49 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> The usage of @BitSet@ should be blazing fast.
I think it should be much better, though n... Eric Faulhaber

07:29 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Ovidiu, welcome back! I am reworking the @RecordBuffer$Handler@ inner class pretty drastical... Ovidiu Maxiniuc

01:21 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, welcome back! I am reworking the @RecordBuffer$Handler@ inner class pretty drastically, pushing much of the p... Eric Faulhaber

11:18 AM Bug #4450: implement shared query and shared browse

Code Review Task Branch 4450a Revision 11341
1. Why aren't shared browse instances registered with/imported from t... Greg Shah

09:19 AM Bug #4450: implement shared query and shared browse

Roger Borrello wrote:
> Stanislav Lomany wrote:
> > 4450a rev 11341 fixes the testcase, not sure about the customer... Roger Borrello

09:13 AM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> 4450a rev 11341 fixes the testcase, not sure about the customer's app. Please review.
I... Roger Borrello

06:25 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

A database trigger defined in the following manner behaves differently on FWD:... Adrian Lungu

06:17 AM Bug #4492 (WIP): database trigger defined with abbreviation should create a new buffer

Adrian Lungu

01/04/2020

03:35 PM Bug #4450: implement shared query and shared browse

4450a rev 11341 fixes the testcase, not sure about the customer's app. Please review. Stanislav Lomany