FWD » Core Development » Database

03/06/2020

05:03 AM Feature #4011: database/persistence layer performance improvements

There is this constant:... Ovidiu Maxiniuc

03/05/2020

03:18 PM Feature #4011: database/persistence layer performance improvements

We have had customer requests to rename the @id@ field/column, which is a commonly used field name in applications. C... Eric Faulhaber

03/03/2020

02:42 PM Bug #4426: Cannot find parent when processing REPEAT PRESELECT

Task branch 4207a was merged to trunk as revision 11344. However, this task was worked around in customer code, and h... Roger Borrello

01:04 PM Bug #4450: implement shared query and shared browse

Branch 4207a was merged to trunk as revision 11344. Greg Shah

01:02 PM Bug #4450 (Closed): implement shared query and shared browse

Greg Shah

10:44 AM Bug #4564: unqualified field references can get the wrong buffer name if a FORM or DEF FRAME is p...

This has nothing to do with the FIND. The issue is in the assignment.... Greg Shah

10:16 AM Bug #4564: unqualified field references can get the wrong buffer name if a FORM or DEF FRAME is p...

h2. Description
Extra scoping causes issues with wrong buffer being used for unqualified field names. Same results... Roger Borrello

10:08 AM Bug #4564 (New): unqualified field references can get the wrong buffer name if a FORM or DEF FRAM...

Roger Borrello

03/02/2020

03:52 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> UNDO update.
> The old implementation was using commits and rollbacks a bit aggressive, al... Eric Faulhaber

03:17 PM Feature #4011: database/persistence layer performance improvements

UNDO update.
The old implementation was using commits and rollbacks a bit aggressive, altogether with creation of ne... Ovidiu Maxiniuc

02:15 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> So, are you saying you also would expect @HQLPreprocessor@ to still handle the null paramete... Ovidiu Maxiniuc

02/28/2020

05:38 PM Feature #4011: database/persistence layer performance improvements

So, are you saying you also would expect @HQLPreprocessor@ to still handle the null parameters before getting into th... Eric Faulhaber

04:49 PM Feature #4011: database/persistence layer performance improvements

Eric, please grab the 11396 revision. In my hurry I did not fully test the do and I made it worse. Ovidiu Maxiniuc

02:37 PM Feature #4011: database/persistence layer performance improvements

Thanks. See @raq_nulls_sort.p@ in testcases. Eric Faulhaber

02:32 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> I haven't debugged too deeply yet... shouldn't @HQLPreprocessor@ have taken care of those @n... Ovidiu Maxiniuc

02:04 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I have this stack trace:... Eric Faulhaber

02/26/2020

10:21 AM Bug #4450: implement shared query and shared browse

> Can you do regression testing?
Sure.
Stanislav Lomany

09:43 AM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> > Would you like me to handle the change to @screen_buffer.rules@,
>
> That seems a sa... Roger Borrello

09:34 AM Bug #4450: implement shared query and shared browse

> Would you like me to handle the change to @screen_buffer.rules@,
That seems a safer option to me.
Stanislav Lomany

09:32 AM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> > This change in @screen_buffer.rules@ was making sure the @frame-id@ and the other widget... Roger Borrello

08:42 AM Bug #4450: implement shared query and shared browse

> This change in @screen_buffer.rules@ was making sure the @frame-id@ and the other widget annotations are placed in ... Stanislav Lomany

02/25/2020

04:51 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > So, I started a new manager class that should drive the undo dat... Ovidiu Maxiniuc

02:29 AM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Notes/status on UNDO part (related to notes 118/119):
>
> It is a bit difficult for me t... Eric Faulhaber

02/24/2020

05:33 PM Feature #4011: database/persistence layer performance improvements

Notes/status on UNDO part (related to notes 118/119):
It is a bit difficult for me to "dry" discuss. My experience... Ovidiu Maxiniuc

04:00 PM Feature #3813: misc DB features part deux

I see two things regarding @RAW-TRANSFER@ to be done
* Rework @BUFFER@ <-> @RAW@ (de)serialization which is binary c... Igor Skornyakov

03:55 PM Feature #3813: misc DB features part deux

Added correct error messages and fixed incompatibilities of the @RAW-TRANSFER@ support for use cases I could imagine.... Igor Skornyakov

02:06 PM Bug #4450: implement shared query and shared browse

> Is that the same as the issue converting @./uast/browse/browse-at_base_field@?
Yes, my main goal is to fix this ... Stanislav Lomany

07:28 AM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> 4207a rev 11402 has the shared browse issues fixed: conversion regression testing passes. ... Roger Borrello

01:51 AM Bug #4450: implement shared query and shared browse

4207a rev 11402 has the shared browse issues fixed: conversion regression testing passes. BTW runtume regression test... Stanislav Lomany

02/22/2020

06:03 AM Feature #3813: misc DB features part deux

The reason for the quirk described in #3813-74 is following:
The 4GL expression @LENGTH(hFieldHandle:BUFFER-VALUE())... Igor Skornyakov

02/21/2020

01:22 PM Feature #3813: misc DB features part deux

Fixed the issue described in #3813-72. The problem with @LENGTH(raw)@ is also resolved as it was a result of the fact... Igor Skornyakov

08:44 AM Feature #3813: misc DB features part deux

Also, the new interface must be added to @HandleCommon@. Greg Shah

08:39 AM Feature #3813: misc DB features part deux

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I've added support for the @BUFFER-FIELD:AVAILABLE@ attribute w... Igor Skornyakov

08:30 AM Feature #3813: misc DB features part deux

Igor Skornyakov wrote:
> I've added support for the @BUFFER-FIELD:AVAILABLE@ attribute which is sufficient for @BUFF... Ovidiu Maxiniuc

07:19 AM Feature #3813: misc DB features part deux

I've noticed a strange effect.
Let @hFieldHandle@ is a handle for the @RAW@ field of a @TEMP-TABLE@. After @RAW-TRAN... Igor Skornyakov

05:18 AM Feature #3813: misc DB features part deux

I've added support for the @BUFFER-FIELD:AVAILABLE@ attribute which is sufficient for @BUFFER:RAW-TRANSER@ runtime su... Igor Skornyakov

04:14 AM Feature #3813: misc DB features part deux

FWD behavior of the @BUFFER-FIELD:BUFFER-VALUE()@ in the situation when there is no data record is not the same as in... Igor Skornyakov

02/20/2020

03:17 PM Feature #3813: misc DB features part deux

@BUFFER-FIELD:AVAILABLE@ attribute is not supported in FWD (raises @** AVAILABLE is not a queryable attribute for BUF... Igor Skornyakov

08:51 AM Feature #3813: misc DB features part deux

> TODO comment in the BufferImpl.rawCopyTo(raw r) method states that FWD is not binary compatible with 4GL on this. M... Greg Shah

06:04 AM Feature #3813: misc DB features part deux

I've found a number of incompatibilities in the behavior of the @RAW-TRANSFER@ statement and @BUFFER:RAW-TRANSFER@ me... Igor Skornyakov

02:00 AM Feature #4011: database/persistence layer performance improvements

I've committed rev 11394, which fixes a few more issues with the validation/flushing. I managed to run an early/rough... Eric Faulhaber

02/19/2020

06:26 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> *** once we've determined it is not a fatal database error and is in fact a unique constrain... Eric Faulhaber

04:19 PM Feature #4011: database/persistence layer performance improvements

Eric,
It seems that you have the cache disabled (Session.get(Session.java:255))? I disable it, too, and I was able t... Ovidiu Maxiniuc

03:16 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I just committed rev 11392 with some fixes.
Please review my change to @FqlToSqlConverted@ for correctness... Eric Faulhaber

02:27 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Ovidiu, is @Validation.checkMaxIndex@ fully implemented? Can I mark this item as complete?
... Ovidiu Maxiniuc

02:19 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, is @Validation.checkMaxIndex@ fully implemented? Can I mark this item as complete? Eric Faulhaber

06:02 AM Feature #4011: database/persistence layer performance improvements

I committed rev 11391, which has changes related to DMO validation and flushing, especially w.r.t. unique constraint ... Eric Faulhaber

01:34 PM Bug #4450: implement shared query and shared browse

I looked and the testcase using the debug version of @frame_scoping.rules@ shows the override frame on line 24 of the... Roger Borrello

12:53 PM Bug #4450: implement shared query and shared browse

> Can you take a look?
Sure, but after I fix all of the @<chui_app>@ regressions caused by shared browse changes.... Stanislav Lomany

11:54 AM Bug #4450: implement shared query and shared browse

Stanislav, saw your *4207a-rev 11398*, and thank your for that update! Are you able to help find the cause of the mis... Roger Borrello

11:37 AM Support #4550: eliminate the need to place the p2jspi.jar in the JVM extension directory

In Java 8 it is supposed to be possible to load service providers from the application classpath. See "ServiceLoader... Greg Shah

11:30 AM Support #4550 (Closed): eliminate the need to place the p2jspi.jar in the JVM extension directory

Greg Shah

02/18/2020

03:02 PM Feature #3813: misc DB features part deux

> Review for 4335a revisions 11416, 11419, and 11421.
>
> In @ConnectionManager.java@:
> * javadocs: I think some... Igor Skornyakov

02:07 PM Feature #3813: misc DB features part deux

Review for 4335a revisions 11416, 11419, and 11421.
In @ConnectionManager.java@:
* javadocs: I think some methods... Ovidiu Maxiniuc

02:53 PM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> > If my changes are causing issues, please describe them, and I will help out.
>
> I wa... Roger Borrello

02:48 PM Bug #4450: implement shared query and shared browse

If you attempt to build @./uast/sharedframes/shared_frame_at_label.p@ (below) and @./uast/sharedframes/shared_frame_a... Roger Borrello

02:25 PM Bug #4450: implement shared query and shared browse

> If my changes are causing issues, please describe them, and I will help out.
I was referencing the @browse-at_ba... Stanislav Lomany

12:30 PM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> Roger, I'm working on the regression caused by the shared browse changes. Regarding the at... Roger Borrello

11:49 AM Bug #4450: implement shared query and shared browse

Roger, I'm working on the regression caused by the shared browse changes. Regarding the at-field changes, I probably ... Stanislav Lomany

11:35 AM Bug #4450: implement shared query and shared browse

Stanislav, do you have anything blocking you on getting 4207a into trunk? Please let us know what the status is. Thanks! Roger Borrello

03:01 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> FYI (especially Constantin and Greg): the implementation of lightweight unique constraint tr... Constantin Asofiei

10:05 PM Feature #4011: database/persistence layer performance improvements

FYI (especially Constantin and Greg): the implementation of lightweight unique constraint tracking across uncommitted... Eric Faulhaber

09:54 PM Feature #4011: database/persistence layer performance improvements

Another aspect of the NO-UNDO support is that we will have to handle REDO of creates and deletes which are rolled bac... Eric Faulhaber

02/17/2020

06:05 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> As seen from a distance, a new class that should handle the savepoints should implement the... Eric Faulhaber

02:07 PM Feature #4011: database/persistence layer performance improvements

As seen from a distance, a new class that should handle the savepoints should implement the @Committable@ interface, ... Ovidiu Maxiniuc

03:37 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> I don't think those testcases were used in FWD. We used them to explore @RAW-TRANSFER@ in the 4G... Igor Skornyakov

03:32 PM Feature #3813: misc DB features part deux

I don't think those testcases were used in FWD. We used them to explore @RAW-TRANSFER@ in the 4GL.
For the purpos... Greg Shah

03:27 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> No, we don't have any support for the @CRC-VALUE@ attribute.
I see. Thank you. Igor Skornyakov

03:25 PM Feature #3813: misc DB features part deux

No, we don't have any support for the @CRC-VALUE@ attribute. Greg Shah

03:19 PM Feature #3813: misc DB features part deux

The conversion of the @uast/raw_transfer/raw_transfer_basic_multi_column_mixed_data_type_encoding.p@ fails/... Igor Skornyakov

02/14/2020

08:20 AM Feature #3813: misc DB features part deux

Additional tests of the @CONNECT@ @-pf@ option support passed. A minor typo was fixed.
4335a revision 11421 is ready... Igor Skornyakov

04:57 AM Feature #4011: database/persistence layer performance improvements

I committed intermediate changes for unique constraint validation in r11389, but it is not yet working properly. The ... Eric Faulhaber

04:57 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Adrian Lungu wrote:
> Issue #4492-5 fixed. @RecordBuffer.create()@ should have called the trigger before updating th... Adrian Lungu

02/13/2020

04:12 PM Feature #3813: misc DB features part deux

Added configuration file (@-pf@ option of the @CONNECT@ statement).
Committed to 4335a revision 11419.
Please not... Igor Skornyakov

10:04 AM Feature #3813: misc DB features part deux

Yes, failing on recursion is a good idea. Hangs don't have to be duplicated. Greg Shah

10:03 AM Feature #3813: misc DB features part deux

4GL allows @-pf@ option in the .pf file. However, this may result in the application hang due to infinite recursion.... Igor Skornyakov

03:23 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> [OM] replace current UNDO architecture with savepoint-based, just-in-time DMO refresh impl... Eric Faulhaber

03:19 PM Feature #4011: database/persistence layer performance improvements

Just a note on what I'm up to, since I realize I've become a bit quiet again. I've been reworking @UniqueTracker@ as ... Eric Faulhaber

02/12/2020

10:23 AM Feature #3813: misc DB features part deux

Finished rework of @CONNECT@/@DBPARAM@.
Committed to 4335a revision 11416.
Working on the parameter file support ... Igor Skornyakov

02/11/2020

03:50 PM Bug #4537: CONNECT statement parameters parsing quirks

4GL uses some weird logic when parsing @CONNECT@ statement arguments which I cannot understand.
For example, if one ... Igor Skornyakov

03:46 PM Bug #4537 (New): CONNECT statement parameters parsing quirks

Igor Skornyakov

01:36 PM Feature #3813: misc DB features part deux

> Is it OK if FWD will complain about a complete key, e.g.
Yes, for *now* it is OK. Please create a new task for ... Greg Shah

12:21 PM Feature #3813: misc DB features part deux

4GL uses some weird logic when parsing @CONNECT@ statement arguments which I cannot understand.
For example, if one ... Igor Skornyakov

11:03 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> Ignoring the quirks in #4535 (which will be deferred), what is the effort to resolve these other ... Igor Skornyakov

10:31 AM Feature #3813: misc DB features part deux

Ignoring the quirks in #4535 (which will be deferred), what is the effort to resolve these other issues (from #3813-51)? Greg Shah

07:25 AM Feature #3813: misc DB features part deux

Some important notes:
# The @CONNECT@ statement can create more than one connection. This is mentioned in the Progre... Igor Skornyakov

08:35 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> * I am testing/debugging @UniqueTracker@ and I will have some changes. Do you have any pendi... Ovidiu Maxiniuc

05:47 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, a few questions...
* I am testing/debugging @UniqueTracker@ and I will have some changes. Do you have any ... Eric Faulhaber

06:17 AM Bug #4535: CONNECT statement with VALUE expression quirks

The @VALUE@ usage in the @CONNECT@ statement looks really tricky. For example... Igor Skornyakov

06:13 AM Bug #4535 (New): CONNECT statement with VALUE expression quirks

Igor Skornyakov

02/10/2020

05:55 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> #3813 does need to handle the case where there are more than 1 option inside a single @VALUE()@ e... Igor Skornyakov

05:51 PM Feature #3813: misc DB features part deux

#3813 does need to handle the case where there are more than 1 option inside a single @VALUE()@ expression. That is ... Greg Shah

05:44 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> For now, I don't know of a case where customer code uses this approach. Please create a new task... Igor Skornyakov

05:36 PM Feature #3813: misc DB features part deux

For now, I don't know of a case where customer code uses this approach. Please create a new task (under the Database... Greg Shah

05:31 PM Feature #3813: misc DB features part deux

Constantin Asofiei wrote:
> Does @CONNECT E:\testcases\uast\security\fwd1.db -P secret -P secret -U fwdb@domain -... Igor Skornyakov

05:22 PM Feature #3813: misc DB features part deux

Does @CONNECT E:\testcases\uast\security\fwd1.db -P secret -P secret -U fwdb@domain -bibufs 13 -1 -ld fwd1.@ work ... Constantin Asofiei

05:21 PM Feature #3813: misc DB features part deux

The @VALUE@ usage in the @CONNECT@ statement looks really tricky. For example... Igor Skornyakov

02:10 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> Is this the 4GL or FWD?
It is 4GL. The current implementation of FWD doesn't support any of th... Igor Skornyakov

02:08 PM Feature #3813: misc DB features part deux

Is this the 4GL or FWD? Greg Shah

01:21 PM Feature #3813: misc DB features part deux

Using @VALUE()@ in the @CONNECT@ statement looks a little tricky. Consider the following code:... Igor Skornyakov

11:35 AM Feature #3813: misc DB features part deux

I agree that we need to improve our documentation to explain this. For now, I think you can ignore it. Greg Shah

11:10 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> In your case, were you explicitly setting @unix-escapes@ to @true@ even though @opsys@ was set to... Igor Skornyakov

10:55 AM Feature #3813: misc DB features part deux

> This means that even if the incorrect value of the "unix-escapes" was specified before "opsys" (as in my case) it w... Greg Shah

03:58 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> 4. Removing reflection dependencies (getter/setter methods) from @PropertyMeta@ if possible.... Ovidiu Maxiniuc

03:49 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I've made some initial assignments in #4011-105. Please look at those items which I've marked with your initi... Eric Faulhaber

02:12 PM Feature #4011: database/persistence layer performance improvements

Regarding the @BDTType@ and the @TypeManager@.
The problem is that, I wrote @TypeManager@ to provide @ParameterSette... Ovidiu Maxiniuc

11:28 AM Feature #4011: database/persistence layer performance improvements

Eric,
I committed my latest changes as revision 11385. The caching of UPDATES is included, along with fixes for BDTT... Ovidiu Maxiniuc

04:51 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, please see #4011-105 and note that I have assigned the "refactor and finish @BDTType@ implementations" item t... Eric Faulhaber

04:08 AM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote (in email):
> working on update optimization based on "changed" bitsets as keys. It proves t... Eric Faulhaber

11:34 AM Bug #3471: incremental conversion is regressed

> Not sure how to handle the files which are deleted (or removed from the conversion).
If the 4GL source files are... Greg Shah

11:05 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> > add all files without an @.ast@
>
> Yes, this makes sense. I presume that this really means... Constantin Asofiei

10:59 AM Bug #3471: incremental conversion is regressed

> add all files without an @.ast@
Yes, this makes sense. I presume that this really means "add all files (that wo... Greg Shah

02/09/2020

02:50 PM Bug #3471: incremental conversion is regressed

Greg, about identifying the 'modified files' from a full conversion project. What I'm thinking is to:
* add all fil... Constantin Asofiei