Project

General

Profile

Activity

From 04/01/2020 to 04/30/2020

04/30/2020

06:56 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> For persistent procedures, a buffer will live as long as that program lives.
Hm, ri...
Eric Faulhaber
06:24 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Specifically, I provisionally have decided on the approach where we tie the database session...
Constantin Asofiei
05:55 PM Feature #4011: database/persistence layer performance improvements
Constantin, I need some guidance on my previous entry.
Specifically, I provisionally have decided on the approach ...
Eric Faulhaber
03:50 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> If @Persistence.closeSession(false)@ is called only from @Persistence$Context.cleanup()@. T...
Eric Faulhaber
10:08 AM Feature #4011: database/persistence layer performance improvements
I agree that refactoring and using modules are both very good things. And we are definitely wanting to do some of th... Greg Shah
09:34 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> When we upgrade to Java9 we could make use of the new modules and compile them independentl...
Igor Skornyakov
09:24 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> In #4155 we are working to eliminate use of the @.df@. And converting as part of the build proce...
Ovidiu Maxiniuc
09:10 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> In #4155 we are working to eliminate use of the @.df@. And converting as part of the build proce...
Igor Skornyakov
08:58 AM Feature #4011: database/persistence layer performance improvements
In #4155 we are working to eliminate use of the @.df@. And converting as part of the build process leads to a bootst... Greg Shah
08:50 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > taking in consideration that we do not have the class at the moment FWD is compiled
>
> In m...
Ovidiu Maxiniuc
08:44 AM Feature #4011: database/persistence layer performance improvements
> taking in consideration that we do not have the class at the moment FWD is compiled
In my opinion, it makes no s...
Greg Shah

04/29/2020

05:29 PM Feature #4011: database/persistence layer performance improvements
Last night I committed r11422.
This revision re-enables @LockTableUpdater@, @ConnectTableUpdater@ and @TransactionT...
Ovidiu Maxiniuc
04:09 PM Feature #4011: database/persistence layer performance improvements
If @Persistence.closeSession(false)@ is called only from @Persistence$Context.cleanup()@. This is the end of session,... Ovidiu Maxiniuc
02:33 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Just committed r11421.
> There are two changes:
> # in @Persistence.closeSession(boolean)...
Eric Faulhaber
06:32 AM Feature #4011: database/persistence layer performance improvements
For now, don't change what the queries fetch. If a query fetches all columns, leave it that way, but ensure the prima... Eric Faulhaber
08:47 PM Feature #4011: database/persistence layer performance improvements
I observed the following usecase:
* some records are created fresh in a loop and get saved. They are successfully in...
Ovidiu Maxiniuc

04/28/2020

04:20 PM Feature #4011: database/persistence layer performance improvements
Just committed r11421.
There are two changes:
# in @Persistence.closeSession(boolean)@, the @closeSessionImpl(error...
Ovidiu Maxiniuc
01:36 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Briefly speaking, the problem is caused because the static temp-tables are 'permanent', a...
Eric Faulhaber
11:50 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> One more issue to fix is that it seems we are not properly dropping indexes on temporary tab...
Ovidiu Maxiniuc
08:18 AM Feature #4011: database/persistence layer performance improvements
> At each nested block within that application transaction, the SavepointManager sets a database savepoint. If that b... Greg Shah
05:51 AM Feature #4011: database/persistence layer performance improvements
One more issue to fix is that it seems we are not properly dropping indexes on temporary tables upon exiting Hotel GU... Eric Faulhaber
05:32 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> For undoable DMOs marked stale, the next access forces a re-read of that DMO's data from t...
Eric Faulhaber
05:25 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I think there is an issue with the nesting transactions. [...]
I debugged through this...
Eric Faulhaber
04:20 AM Feature #4011: database/persistence layer performance improvements
Thanks for clarifications, I will use these information (from both your last posts) to continue investigations on the... Ovidiu Maxiniuc
03:37 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > I don't intentionally create nested transactions, in fact, the @...
Eric Faulhaber
03:09 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Can you please share the reasoning behind your change?
> The ...
Eric Faulhaber
09:10 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I don't intentionally create nested transactions, in fact, the @inTx@ flag in @Session@ is i...
Ovidiu Maxiniuc
09:03 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Can you please share the reasoning behind your change?
The usecase is when same dmo is load...
Ovidiu Maxiniuc
08:50 PM Feature #4011: database/persistence layer performance improvements
Ovidiu, the change in 11418 to @Session.save@ seems dangerous to me. The reason for the check to test whether another... Eric Faulhaber
12:16 PM Feature #4397: add database attrs, methods and options
Greg Shah wrote:
> The runtime would be up to Eric/Ovidiu. After #4011, they have plenty of control all the way dow...
Ovidiu Maxiniuc
10:08 AM Feature #4397: add database attrs, methods and options
4231b rev 11493 :
* added BUFFER:LAST-BUFFER and QUERY's callback API support
* fixed EXCEPT/FIELDS option with a r...
Constantin Asofiei
09:43 AM Feature #4397: add database attrs, methods and options
Looks like FIELDS and EXCEPT are already supported for this case:... Constantin Asofiei
09:41 AM Feature #4397: add database attrs, methods and options
The runtime would be up to Eric/Ovidiu. After #4011, they have plenty of control all the way down to the JDBC driver. Greg Shah
09:24 AM Feature #4397: add database attrs, methods and options
I understand the reasoning behind it, to limit the amount of data retrieved by a query; but, my point is that to make... Constantin Asofiei
09:15 AM Feature #4397: add database attrs, methods and options
Constantin Asofiei wrote:
> I recall way back that we had a talk about FIELDS/EXCEPT with a record phrase, and with ...
Greg Shah
08:16 AM Feature #4397: add database attrs, methods and options
Yes, it exists:... Constantin Asofiei
08:12 AM Feature #4397: add database attrs, methods and options
Constantin Asofiei wrote:
> > Where did you find from of the existence of the attribute for dataset objects? Custome...
Ovidiu Maxiniuc
07:32 AM Feature #4397: add database attrs, methods and options
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Just a note, there is a @DATASET:FILL-MODE@ attribute which ...
Constantin Asofiei
07:01 AM Feature #4397: add database attrs, methods and options
Constantin Asofiei wrote:
> Just a note, there is a @DATASET:FILL-MODE@ attribute which I stubbed in 4231b. FWD now...
Ovidiu Maxiniuc
10:16 AM Feature #3814: more schema metadata
Greg Shah wrote:
> > Why not keep the metadata in the database as 4GL does?
>
> Just because the 4GL represents t...
Igor Skornyakov
10:08 AM Feature #3814: more schema metadata
> Why not keep the metadata in the database as 4GL does?
Just because the 4GL represents these as tables, doesn't ...
Greg Shah
09:49 AM Feature #3814: more schema metadata
Greg Shah wrote:
> When you add a column or an index post-conversion, it must be represented in the metadata. Relyi...
Igor Skornyakov
08:00 AM Feature #3814: more schema metadata
When you add a column or an index post-conversion, it must be represented in the metadata. Relying upon static defin... Greg Shah

04/27/2020

07:20 PM Feature #3814: more schema metadata
Greg Shah wrote:
> At least for tables such as @file_@ or @field_@, these must always represent the latest structu...
Eric Faulhaber
06:47 PM Feature #3814: more schema metadata
Greg Shah wrote:
> > I can easily imagine the situation when we'll be able to provide compatibility with 4GL for the...
Igor Skornyakov
06:35 PM Feature #3814: more schema metadata
> I can easily imagine the situation when we'll be able to provide compatibility with 4GL for the application if we w... Greg Shah
06:00 PM Feature #3814: more schema metadata
Greg Shah wrote:
> > I've not realized this. In any case, the content of the non-VST system tables should be really ...
Igor Skornyakov
05:45 PM Feature #3814: more schema metadata
> I've not realized this. In any case, the content of the non-VST system tables should be really persistent and survi... Greg Shah
05:25 PM Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Igor, AFAIK the meta database in FWD is a separate H2 in-memory database, for each physi...
Igor Skornyakov
05:20 PM Feature #3814: more schema metadata
Igor, AFAIK the meta database in FWD is a separate H2 in-memory database, for each physical database. So even if the... Constantin Asofiei
04:31 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > Well, it seems that we need some changes in the conversion proce...
Igor Skornyakov
04:20 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Well, it seems that we need some changes in the conversion process. The SCHEMA meta tables ...
Eric Faulhaber
06:44 PM Feature #4397: add database attrs, methods and options
I recall way back that we had a talk about FIELDS/EXCEPT with a record phrase, and with our current FWD, it doesn't m... Constantin Asofiei
06:39 PM Feature #4397: add database attrs, methods and options
Just a note, there is a @DATASET:FILL-MODE@ attribute which I stubbed in 4231b. FWD now has runtime only for @BUFFER... Constantin Asofiei
05:37 PM Feature #4011: database/persistence layer performance improvements
I don't intentionally create nested transactions, in fact, the @inTx@ flag in @Session@ is intended specifically to a... Eric Faulhaber
05:24 PM Feature #4011: database/persistence layer performance improvements
Eric,
I committed a small update that will make the embedded client work. See r11418.
But I have the following is...
Ovidiu Maxiniuc
03:45 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> [...]
> This was making sense when we let Hibernate do the flush as late as possible, bu...
Eric Faulhaber
08:47 AM Feature #4011: database/persistence layer performance improvements
Eric,
We need to discuss the ...
Ovidiu Maxiniuc
06:05 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> This is fixed in rev 11417.
Super!
> Ovidiu, after the issues in #4011-241, could you al...
Ovidiu Maxiniuc
06:00 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, after the issues in #4011-241, could you also please take a look at what is going wrong with embedded mode Ho... Eric Faulhaber
05:48 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > What is the recreate for this? I can have a look.
> Available R...
Eric Faulhaber
02:15 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, thanks for the fixes in rev 11416. Please look at these next, which occur when you try to manipulate the tree... Eric Faulhaber

04/25/2020

02:48 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I've now come across a dynamic database problem in Hotel GUI (virtual desktop). On the "Room...
Ovidiu Maxiniuc
02:37 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> What is the recreate for this? I can have a look.
Available Rooms > Check-In > (select a gu...
Ovidiu Maxiniuc
02:34 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The issue I was after yesterday changes a bit. [...]
What is the recreate for this? I ...
Eric Faulhaber
11:28 AM Feature #4011: database/persistence layer performance improvements
Eric,
The issue I was after yesterday changes a bit. Now I am getting the following NPE when a record is deleted:
<...
Ovidiu Maxiniuc
09:01 AM Feature #4011: database/persistence layer performance improvements
> The problem with my last revision is that I was assuming Finalizable entry and finished calls were always paired, w... Greg Shah
04:19 AM Feature #4011: database/persistence layer performance improvements
I've committed rev 11415, which I believe fixes the @UniqueTracker@ scope imbalance problem. I think the logic is sou... Eric Faulhaber

04/24/2020

04:11 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> the first part, @on commit drop@ means to drop the table on transaction commit. Now, I do...
Eric Faulhaber
10:07 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Why do we create temp tables with the postfix @on commit drop transactional@? What does this...
Ovidiu Maxiniuc
04:23 AM Feature #4011: database/persistence layer performance improvements
Update on the unbalanced scopes in @UniqueTracker@...
I've reworked the scope mechanism in @UniqueTracker@ to rely...
Eric Faulhaber
02:19 PM Feature #4375: add support for -pf <profile_filename> option for CONNECT statement
Greg Shah wrote:
> It looks like rev 11369 of 4231b.
>
> As you develop changes for a task, please keep the @% Do...
Igor Skornyakov
01:29 PM Feature #4375 (Test): add support for -pf <profile_filename> option for CONNECT statement
It looks like rev 11369 of 4231b.
As you develop changes for a task, please keep the @% Done@ and @Status@ updated...
Greg Shah
01:13 PM Feature #4375: add support for -pf <profile_filename> option for CONNECT statement
Greg Shah wrote:
> Are the changes in 4231b?
I do not remember. I think that they are in the trunk already.
Igor Skornyakov
01:12 PM Feature #4375: add support for -pf <profile_filename> option for CONNECT statement
Are the changes in 4231b? Greg Shah
01:11 PM Feature #4375: add support for -pf <profile_filename> option for CONNECT statement
This was done in the scope of #3813. Igor Skornyakov
11:46 AM Feature #4375: add support for -pf <profile_filename> option for CONNECT statement
I think I mistakenly assigned you #4392 previously, but meant for you to work this one. Greg Shah
01:06 PM Feature #4175: add support for -1 (single user) option for CONNECT statement
I was not working in this task/ As far as I remember, I was reassigned to another one. Igor Skornyakov
11:44 AM Feature #4175: add support for -1 (single user) option for CONNECT statement
What is the status of this task? Greg Shah

04/23/2020

04:58 PM Feature #4011: database/persistence layer performance improvements
Why do we create temp tables with the postfix @on commit drop transactional@? What does this do? Eric Faulhaber
03:49 PM Feature #4011: database/persistence layer performance improvements
I just committed r11414. Here are the changes:
* changed the initialization of @_metadata@ of @DmoClass@ generated c...
Ovidiu Maxiniuc
02:33 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Do we need to be so eager to close the session in the attempt to salvage the normal execu...
Eric Faulhaber
10:44 AM Feature #4011: database/persistence layer performance improvements
I used r11413 and the hotel_gui has @deploy.all@-ed smoothly. I found some new hardcoded @id@ which were replaced wit... Ovidiu Maxiniuc
08:15 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I was not thinking of database import when I put @PRIMARY_KEY_NAME@ into @DatabaseManager@. ...
Ovidiu Maxiniuc
06:10 AM Feature #4011: database/persistence layer performance improvements
The attached changes to @directory.xml@ are needed to adjust for the removal of Hibernate. Note that these are just t... Eric Faulhaber
06:02 AM Feature #4011: database/persistence layer performance improvements
I checked in rev 11413, which fixes a few bugs (hard-coded references to @id@ as primary key) and makes @Session.PK@ ... Eric Faulhaber
04:44 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> * the @DatabaseManager.PRIMARY_KEY@ is used when initializing the @DmoMeta@ for each DMO ...
Eric Faulhaber
09:33 AM Bug #3471: incremental conversion is regressed
4231b rev -11481- 11482 contains more performance fixes (again, related to the @tmpTabNodes@ and @AstKey@):
* collec...
Constantin Asofiei

04/22/2020

03:31 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Is @MultiClassLoader@ really needed for the import, or just @AsmClassLoader@?
Good point....
Ovidiu Maxiniuc
03:24 PM Feature #4011: database/persistence layer performance improvements
Is @MultiClassLoader@ really needed for the import, or just @AsmClassLoader@? Eric Faulhaber
03:21 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> BTW, for import and server to start the
> @-Djava.system.class.loader=com.goldencode.p2...
Eric Faulhaber
03:20 PM Feature #4011: database/persistence layer performance improvements
BTW, for import and server to start the
@-Djava.system.class.loader=com.goldencode.p2j.classloader.MultiClassLoad...
Ovidiu Maxiniuc
03:06 PM Feature #4011: database/persistence layer performance improvements
Eric,
I committed r11412. The changes include:
* I fixed the reported issue. It was caused by the @key@ being dif...
Ovidiu Maxiniuc
05:20 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, when I try to log into Hotel GUI embedded mode (or run any test case) with rev 14111, I get this:... Eric Faulhaber
08:18 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
>> I noticed your TODO in DatabaseManager. I am going to address is immediately as this is use...
Ovidiu Maxiniuc

04/21/2020

08:07 AM Feature #3814: more schema metadata
At this moment I'm using the current approach based on @metadata@ in @p2j.cfg.xml@. I believe that it will be easy to... Igor Skornyakov
08:02 AM Feature #3814: more schema metadata
We can leave behind a conversion artifact for this, since the dynamic queries are only processed at runtime this shou... Greg Shah
03:47 AM Feature #3814: more schema metadata
Greg/Igor: a VST can be used from dynamic queries, too. And this will leave nothing for us to determine via the stan... Constantin Asofiei
06:08 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I merged in my changes related to import and a few other fixes. Latest revision of 4011a is...
Eric Faulhaber
10:01 PM Feature #4011: database/persistence layer performance improvements
I merged in my changes related to import and a few other fixes. Latest revision of 4011a is 11411. Notes:
* the prop...
Ovidiu Maxiniuc

04/20/2020

08:42 AM Feature #3814: more schema metadata
Greg Shah wrote:
> > I do not understand what the "conversion support" (#3814-7) means as it seems that it is suffic...
Igor Skornyakov
08:29 AM Feature #3814: more schema metadata
> I do not understand what the "conversion support" (#3814-7) means as it seems that it is sufficient just to add the... Greg Shah
07:52 AM Feature #3814: more schema metadata
Looking at the content of the @_Database-Feature@ VST from the sample customer environment I do not think that it can... Igor Skornyakov
05:17 AM Feature #4011: database/persistence layer performance improvements
I committed rev 11409. With this drop, I can log into virtual desktop Hotel GUI. I can navigate the tabs, though the ... Eric Faulhaber
03:34 AM Feature #4011: database/persistence layer performance improvements
I've checked in revisions 11407 and 11408, which replace the UNDO architecture and the transaction management.
Ple...
Eric Faulhaber

04/19/2020

02:39 PM Feature #3814: more schema metadata
Well, it seems that we need some changes in the conversion process. The SCHEMA meta tables should be included in the ... Igor Skornyakov
12:48 PM Feature #3814: more schema metadata
In this note, I summarise my current understanding of the scope of this task and things which are not clear for me.
...
Igor Skornyakov

04/18/2020

08:58 AM Feature #3814: more schema metadata
Greg Shah wrote:
> You've been analyzing this for a few days. Please provide more details so we can discuss.
Gre...
Igor Skornyakov
07:06 AM Feature #3814: more schema metadata
> I understand that most of the data mentioned in this task are related to data security.
I don't think so. The @...
Greg Shah

04/17/2020

02:28 PM Feature #3814: more schema metadata
I understand that most of the data mentioned in this task are related to data security. I'm not sure that most of the... Igor Skornyakov

04/16/2020

04:21 PM Bug #3471: incremental conversion is regressed
4231b rev 11462 contains some performance fixes related to the memory usage.
The idea here was:
* 'unpin' the AST...
Constantin Asofiei
04:03 PM Bug #3471: incremental conversion is regressed
Additional notes which may be useful:
The core idea is that the FWD ConversionDriver has an incremental conversion...
Greg Shah
12:05 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Igor: Can you please commit your import fixes so that the build is working again? I need to push...
Igor Skornyakov
11:24 AM Feature #3813: misc DB features part deux
Igor: Can you please commit your import fixes so that the build is working again? I need to push this to our customers. Greg Shah

04/15/2020

07:15 PM Feature #3813: misc DB features part deux
Constantin Asofiei wrote:
> Igor, there is an issue in @BufferFieldImpl@ - this import "import org.aspectj.org.eclip...
Igor Skornyakov
06:29 PM Feature #3813: misc DB features part deux
Igor, there is an issue in @BufferFieldImpl@ - this import "import org.aspectj.org.eclipse.jdt.core.dom.*;" is not OK... Constantin Asofiei
07:11 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> However, I have another question on this topic: aren't the values in each row of the @.d@ fi...
Ovidiu Maxiniuc
07:05 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> [...] I think we can either:
> * drop the method, I think the association property-index c...
Eric Faulhaber
06:52 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> The other issue is that I had removed the deprecated @BaseRecord.indexOf@ method in my worki...
Ovidiu Maxiniuc
06:01 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I found out that @PropertyMapper@ tries to delegate the setting of a field if @delegate@ ...
Eric Faulhaber
05:12 PM Feature #4011: database/persistence layer performance improvements
Eric,
I started rewriting some parts of the @import.xml@, @ImportWorker@ and related classes to take advantage of th...
Ovidiu Maxiniuc
09:46 AM Bug #3471 (Closed): incremental conversion is regressed
Greg Shah
09:15 PM Feature #4613: add missing support for database user defined functions (UDF) if they are supporte...
FWD supports many built-in functions for use in WHERE clauses, such that they are executed at the database server usi... Eric Faulhaber

04/14/2020

07:03 PM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Igor, I will open a new task for this. We will need to put together a process for identifyin...
Igor Skornyakov
06:54 PM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> The only remaining thing in this task is @Built-In Function Usage in WHERE Clauses@.
> Whe...
Eric Faulhaber
03:33 PM Feature #3813: misc DB features part deux
The only remaining thing in this task is @Built-In Function Usage in WHERE Clauses@.
Where can I take a look at the ...
Igor Skornyakov
03:30 PM Feature #3813: misc DB features part deux
Implemented runtime support for the @BUFFER:BUFFER-VALIDATE@.
4231b revision 11447.
Igor Skornyakov
06:58 PM Feature #4613 (New): add missing support for database user defined functions (UDF) if they are su...
Eric Faulhaber
06:06 PM Bug #3471: incremental conversion is regressed
Branch 3471a was merged to trunk rev 11346 and archived. This adds support for incremental conversion. Not mandator... Constantin Asofiei
05:43 PM Bug #3471: incremental conversion is regressed
Phase 2 planning:
* move the h2-related code as a service in goldencode.ast
* tmpTabNodes usage - find a better way...
Constantin Asofiei
11:58 AM Bug #3471: incremental conversion is regressed
Code Review Task Branch 3471a Revision 11376
I'm fine with the changes. You can merge to trunk when your testing ...
Greg Shah
11:27 AM Bug #3471: incremental conversion is regressed
The lambda issues were addressed in 3471a 11375.
I think this can be merged to trunk, after I finish another conve...
Constantin Asofiei
11:15 AM Bug #3471: incremental conversion is regressed
3471a rev 11376 contains a fix for #4384-187 issue related to converting references for builtin classes with no FWD i... Constantin Asofiei
04:57 PM Feature #3814: more schema metadata
Ovidiu Maxiniuc wrote:
> Igor, you can query the meta tables from a 4GL environment as a standard stable. For exampl...
Igor Skornyakov
04:35 PM Feature #3814: more schema metadata
Igor, you can query the meta tables from a 4GL environment as a standard stable. For example:... Ovidiu Maxiniuc
04:13 PM Feature #3814: more schema metadata
Where can I find the description of the schema metadata? So far I've found only this article: https://knowledgebase.p... Igor Skornyakov

04/13/2020

07:02 PM Bug #3471: incremental conversion is regressed
Greg Shah wrote:
> 5. The design is quite elegant. The fact that the maps and sets in conversion have been replaced...
Constantin Asofiei
06:54 PM Bug #3471: incremental conversion is regressed
Code Review Task Branch 3471a Revision 11373
+Part 2+
5. The design is quite elegant. The fact that the maps a...
Greg Shah
06:33 PM Bug #3471: incremental conversion is regressed
Greg Shah wrote:
> 1. In the calling locations of @helper.persistCollection()@ it would be better if the types of t...
Constantin Asofiei
04:34 PM Bug #3471: incremental conversion is regressed
Code Review Task Branch 3471a Revision 11373
So far, I've very impressed.
+Part 1+
I'm posting the review in...
Greg Shah
07:27 AM Bug #3471: incremental conversion is regressed
Greg, 3471a rev 11373 is ready for review Constantin Asofiei
09:11 AM Feature #3813: misc DB features part deux
Implemented changes suggested by Eric (see #3813-157) and fixed dependency of the DMO instantiation on @SESSION:DATE... Igor Skornyakov
05:26 AM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> No, please don't work on the conversion part. The @LegacyField@ annotation is precisely the ...
Igor Skornyakov
05:05 AM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Igor: Can you implement the parts of the support except for the looku...
Eric Faulhaber
05:03 AM Feature #3813: misc DB features part deux
Igor, for @LegacyField@ look in @dmo_common.rules@, around line 1780, for code like this:... Constantin Asofiei
03:24 AM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Igor: Can you implement the parts of the support except for the lookup of the value? Then it can...
Igor Skornyakov
09:20 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Eric: I assume you mean that just the backing value is there in the DMO in 4011a. The rest of th...
Eric Faulhaber

04/12/2020

07:40 PM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I'm supposed to work at least on @DECIMALS@ support right no...
Greg Shah
05:05 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> The other issue is that I had removed the deprecated @BaseRecord.indexOf@ method in my worki...
Eric Faulhaber
05:03 PM Feature #4011: database/persistence layer performance improvements
Thanks for fixing up the import.
I had two errors compiling with rev 11406. One was due to a change I have made in...
Eric Faulhaber

04/11/2020

04:12 PM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Sorry, Igor, would not have been giving you implementation advice had I realized Ovidiu alre...
Igor Skornyakov
04:08 PM Feature #3813: misc DB features part deux
Sorry, Igor, would not have been giving you implementation advice had I realized Ovidiu already implemented this feat... Eric Faulhaber
04:01 PM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> I'm supposed to work at least on @DECIMALS@ support right now.
If there is not a criti...
Eric Faulhaber
03:58 PM Feature #3813: misc DB features part deux
Ovidiu Maxiniuc wrote:
> [...]
> Both attributes and can be directly accessed via the new @DmoMetadataManager@ / @D...
Eric Faulhaber
03:03 PM Feature #3813: misc DB features part deux
Ovidiu Maxiniuc wrote:
> Igor, I believe both of the above attributes are members fields in the new @Property@ DMO a...
Igor Skornyakov
02:50 PM Feature #3813: misc DB features part deux
Igor, I believe both of the above attributes are members fields in the new @Property@ DMO annotation of the new persi... Ovidiu Maxiniuc
08:08 AM Feature #3813: misc DB features part deux
Can anybody help me to understand how the @LegacyField@ annotations are generated? We need at least two fixes for thi... Igor Skornyakov

04/10/2020

06:06 PM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I need the get the @DECIMALS@ value from the @BufferFieldImp...
Igor Skornyakov
06:00 PM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> I need the get the @DECIMALS@ value from the @BufferFieldImpl@ method I do not see how ge...
Eric Faulhaber
04:38 PM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> The DMO field will always return a BDT value, never @null@, even if it is unknown value. The...
Igor Skornyakov
03:58 PM Feature #3813: misc DB features part deux
Fixed the issue with @INITIAL@ value parsing for date fields.
Committed with @SessionExport@ support to 4231b revis...
Igor Skornyakov
03:06 PM Feature #3813: misc DB features part deux
I've removed my changes regarding @LogicalTerminal@. Apart from extracting @SessionExports@ operations to a separate ... Igor Skornyakov
01:57 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> > I understand that EnvironmentDaemon is not a suitable pattern for the situation with SESSION:DA...
Igor Skornyakov
01:46 PM Feature #3813: misc DB features part deux
> I understand that EnvironmentDaemon is not a suitable pattern for the situation with SESSION:DATE-FORMAT and the ot... Greg Shah
01:11 PM Feature #3813: misc DB features part deux
I understand that @EnvironmentDaemon@ is not a suitable pattern for the situation with @SESSION:DATE-FORMAT@ and the ... Igor Skornyakov
04:26 PM Feature #4011: database/persistence layer performance improvements
The first revision of import process was committed to 4011a. I have successfully imported the hotel_gui database in b... Ovidiu Maxiniuc

04/09/2020

03:32 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Yes, it will certinly make it better, even if it is not the full solution.
>
> You can patte...
Igor Skornyakov
03:30 PM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> BTW: maybe the problem is not with the @SessionUtils@ _per se_, but in the way @SessionExpo...
Greg Shah
03:29 PM Feature #3813: misc DB features part deux
Yes, it will certinly make it better, even if it is not the full solution.
You can pattern it using the @Environ...
Greg Shah
03:29 PM Feature #3813: misc DB features part deux
BTW: maybe the problem is not with the @SessionUtils@ _per se_, but in the way @SessionExports@ is instantiated in th... Igor Skornyakov
02:55 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Yes. This is what I meant by my comment:
>
> > I don't know why we are using SessionUtils on ...
Igor Skornyakov
02:47 PM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> A @SESSION:TIMEZONE = 3.@ (@SessionUtils.setTimezone@) causes the same exception as in #381...
Greg Shah
02:45 PM Feature #3813: misc DB features part deux
A @SESSION:TIMEZONE = 3.@ (@SessionUtils.setTimezone@) causes the same exception as in #3813-123 (@No export or no ac... Igor Skornyakov

04/07/2020

05:19 PM Feature #4011: database/persistence layer performance improvements
While working with the @hotel_gui@ and in particular with embedded client I feel that FWD is non-deterministically un... Ovidiu Maxiniuc
04:46 PM Feature #3813: misc DB features part deux
The runtime support for the @DEFAULT-STRING@ (modulo the issue with EXTENT fields (see #3813-99) is finished.
Commit...
Igor Skornyakov
04:27 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Most likely, the initial value for these problem cases should be the unknown value. Please check...
Igor Skornyakov
04:24 PM Feature #3813: misc DB features part deux
> I've implemented preventive pre-check in the getDefaultString and do not try to vet the values for the problematic ... Greg Shah
04:01 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> > Formally this issue is not related to #3813 and does not prevent tesing.
>
> We still should...
Igor Skornyakov
03:59 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> > I've found that current INITIAL attribute support generates exceptions for other data types (su...
Igor Skornyakov
03:48 PM Feature #3813: misc DB features part deux
> Formally this issue is not related to #3813 and does not prevent tesing.
We still should probably fix this now. ...
Greg Shah
03:37 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Igor Skornyakov wrote:
> > On the conversion of the field definition
> > [...]
> > the time pa...
Igor Skornyakov
03:31 PM Feature #3813: misc DB features part deux
Another issue:
The converted statement @SessionUtils.setDateFormat(new character("ydm"))@ causes runtime exception:
...
Igor Skornyakov
03:30 PM Feature #3813: misc DB features part deux
> I've found that current INITIAL attribute support generates exceptions for other data types (such as raw or even ch... Greg Shah
03:27 PM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> On the conversion of the field definition
> [...]
> the time part is lost.
Please show...
Greg Shah
03:23 PM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> I don't think that was intentional. Please add it if you need it. My advice about @getPrecis...
Igor Skornyakov
03:21 PM Feature #3813: misc DB features part deux
In addition to the #3813-95, I've found that current @INITIAL@ attribute support generates exceptions for other data ... Igor Skornyakov
03:09 PM Feature #3813: misc DB features part deux
On the conversion of the field definition... Igor Skornyakov
02:56 PM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Where @foo@ represents a DMO and @bar@ is a @decimal@ property, ...
Eric Faulhaber
01:33 PM Feature #3813: misc DB features part deux
@DEFAULT-STRING@ uses only decimal separator when rendering @DECIMAL@ values. The value of the group separator is not... Igor Skornyakov
11:04 AM Feature #3813: misc DB features part deux
Greg Shah wrote:
> No. A format string is not the same thing as the @DATE-FORMAT@. A format string for @date@ migh...
Igor Skornyakov
10:45 AM Feature #3813: misc DB features part deux
> DEFAULT-STRING renders its dates and numeric values in LOCAL format, subject to the DATE-FORMAT and NUMERIC-FORMAT ... Greg Shah
08:23 AM Feature #3813: misc DB features part deux
Greg Shah wrote:
> The @date@, @datetime@, @datetime-tz@, @integer@, @int64@ and @decimal@ classes all are designed ...
Igor Skornyakov
08:14 AM Feature #3813: misc DB features part deux
The @date@, @datetime@, @datetime-tz@, @integer@, @int64@ and @decimal@ classes all are designed to format their stat... Greg Shah
07:51 AM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Igor Skornyakov wrote:
> > Do we have methods for rendering date/numeric data using @SESSION:DAT...
Igor Skornyakov
07:46 AM Feature #3813: misc DB features part deux
Greg Shah wrote:
> > We need to correctly distinguish between datetime literal and valid expression as NOW. The firs...
Igor Skornyakov
07:39 AM Feature #3813: misc DB features part deux
> We need to correctly distinguish between datetime literal and valid expression as NOW. The first question is what c... Greg Shah
07:36 AM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> Do we have methods for rendering date/numeric data using @SESSION:DATE-FORMAT@ and @SESSION...
Greg Shah
05:45 AM Feature #3813: misc DB features part deux
Do we have methods for rendering date/numeric data using @SESSION:DATE-FORMAT@ and @SESSION:NUMERIC-FORMAT@ attribute... Igor Skornyakov
05:39 AM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return th...
Igor Skornyakov
04:40 AM Feature #3813: misc DB features part deux
The issue described in the #3813-97 was a result of the following. I've compiled two tests. The TEMP-TABLE @source-da... Igor Skornyakov
03:35 AM Feature #3813: misc DB features part deux
Eric Faulhaber wrote:
> Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return th...
Igor Skornyakov

04/06/2020

07:29 PM Feature #3813: misc DB features part deux
Where @foo@ represents a DMO and @bar@ is a @decimal@ property, the following will return the value of DECIMAL from t... Eric Faulhaber
05:43 PM Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> I cannot find where the value of the DECIMAL option of the field definition is located in t...
Igor Skornyakov
05:38 PM Feature #3813: misc DB features part deux
I cannot find where the value of the DECIMAL option of the field definition is located in the conversion artifacts.
...
Igor Skornyakov
01:35 PM Feature #3813: misc DB features part deux
Ovidiu Maxiniuc wrote:
> I will schedule working on this issue. 4011a is not yet stable enough, but we'll see whethe...
Igor Skornyakov
01:29 PM Feature #3813: misc DB features part deux
> BTW: do I understand correctly that more complicated expressions cannot be used in the @INITIAL@ clause?
TBH, befo...
Ovidiu Maxiniuc
12:40 PM Feature #3813: misc DB features part deux
Ovidiu Maxiniuc wrote:
> I am working on 4011a branch, where the field's attributes (including the default value) ar...
Igor Skornyakov
12:29 PM Feature #3813: misc DB features part deux
The following field definition... Igor Skornyakov
12:26 PM Feature #3813: misc DB features part deux
I am working on 4011a branch, where the field's attributes (including the default value) are defined as DMO interface... Ovidiu Maxiniuc
11:40 AM Feature #3813: misc DB features part deux
At the moment FWD runtime support if the INITIAL attribute for fields like @FIELD s-datetime AS DATETIME INITIAL NOW@... Igor Skornyakov
09:57 AM Feature #3813: misc DB features part deux
Greg Shah wrote:
> Doesn't the @DEFAULT-VALUE@ of the DMO map more closely to @BUFFER-FIELD:DEFAULT-VALUE@ instead o...
Igor Skornyakov
09:50 AM Feature #3813: misc DB features part deux
Doesn't the @DEFAULT-VALUE@ of the DMO map more closely to @BUFFER-FIELD:DEFAULT-VALUE@ instead of using the @DEFAULT... Greg Shah
09:42 AM Feature #3813: misc DB features part deux
We have no support for the BUFFER-FIELD:DEFAULT-VALUE (even conversion is not supported). This can be a little bit tr... Igor Skornyakov
07:34 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Which revision of hotel_gui are you using with 4011a/11404?
I found r202 of hotel_gui is wh...
Ovidiu Maxiniuc

04/05/2020

06:08 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I have committed my latest changes to 4011a as r11404.
> The standalone hotel_gui is start...
Eric Faulhaber
07:52 AM Feature #4011: database/persistence layer performance improvements
I have committed my latest changes to 4011a as r11404.
The standalone hotel_gui is starting up and tabs can be navig...
Ovidiu Maxiniuc
07:37 AM Feature #4011: database/persistence layer performance improvements
> This is a non-orthodox workaround.
You're being kind. Let us call it what it is: an ugly solution. Unfortunate...
Greg Shah

04/04/2020

06:24 PM Feature #4011: database/persistence layer performance improvements
Greg, thanks for suggestion. This is a non-orthodox workaround. Here is what I've done.
I altered @NUM_LITERAL@ in l...
Ovidiu Maxiniuc

04/03/2020

06:33 PM Feature #3813: misc DB features part deux
By the end of the weekend, please report the list of open items remaining in this task. We can push the #3813-81 it... Greg Shah
06:31 PM Feature #4011: database/persistence layer performance improvements
Is the column name version of @order@ always "qualified" (e.g. @tt1.order@)? If so, then you can easily differentiat... Greg Shah
05:29 PM Feature #4011: database/persistence layer performance improvements
In fact, @by@ does not suffer from this inconvenient as it is already a Progress reserved keyword and cannot be the n... Ovidiu Maxiniuc
04:59 PM Feature #4011: database/persistence layer performance improvements
I encountered the following issue and I see no easy trick to work around. It is a antlr issue I think. Suppose we hav... Ovidiu Maxiniuc

04/02/2020

08:22 AM Feature #3813: misc DB features part deux
Contrary to what is said in the Progress documentation the @DEFAULT-STRING@ attribute is read-only. This is logical a... Igor Skornyakov

04/01/2020

11:47 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > There is another issue which I have in mind: when creating a savepoint, shouldn't we also sav...
Eric Faulhaber
11:36 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> What happens if in the meantime between the roll-forward and the original execution of a statem...
Eric Faulhaber
07:39 AM Feature #4011: database/persistence layer performance improvements
> maybe, instead of trying to track NO-UNDO DMOs as POJOs, I need to track the SQL statements that were rolled back a... Greg Shah
07:21 AM Feature #4011: database/persistence layer performance improvements
Eric, this FFD replay is the same though I had in mind. I don't think we can keep the database in good condition and ... Ovidiu Maxiniuc
 

Also available in: Atom