Project

General

Profile

Activity

From 05/07/2020 to 06/05/2020

06/05/2020

07:12 PM Feature #4011: database/persistence layer performance improvements
Unfortunately, I don't have the dirty share fully done yet.
To let my brain cool down I returned and fixed the uniqu...
Ovidiu Maxiniuc
05:57 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Virtual desktop and embedded mode get through this flow fine,...
Eric Faulhaber
05:42 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > The only issue I'm aware in Hotel GUI is the NPE related to C...
Constantin Asofiei
05:41 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Virtual desktop and embedded mode get through this flow fine, so it may be a client problem ...
Constantin Asofiei
05:36 PM Feature #4011: database/persistence layer performance improvements
Another issue I hit was in Swing only:
* log in
* from "Available Rooms", click "Check-In..."
* delete guest
* ...
Eric Faulhaber
05:32 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, afte...
Eric Faulhaber
05:15 PM Feature #4011: database/persistence layer performance improvements
The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, after deleting the guest. Constantin Asofiei
05:13 PM Feature #4011: database/persistence layer performance improvements
This code in @RecordBuffer.delete@ doesn't set the @token@:... Constantin Asofiei
04:56 PM Feature #4011: database/persistence layer performance improvements
The deadlock described in #4011-385 can be duplicated like this in 11452:
* delete a room
* close and start another...
Constantin Asofiei
02:56 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> My changes to fix the #4011-385, the @deleteAll@ problem because there was no notificati...
Constantin Asofiei
05:35 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion...
Constantin Asofiei
05:17 AM Feature #4011: database/persistence layer performance improvements
Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion from scratch and try it ... Eric Faulhaber
05:07 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, the issue in #4011-412 is not solved by your changes.
...
Constantin Asofiei
04:57 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is not solved by your changes.
Constantin, I don't get a...
Eric Faulhaber
04:38 PM Feature #3814: more schema metadata
# restored @_database-feature@ support previously implemented by Ovidiu
# added the following @_file@ fields:...
Igor Skornyakov

06/04/2020

05:20 PM Feature #3814: more schema metadata
Added conversion support for the @_Field.CAN-*@ fields and population of @CAN_*@ and @*-SA@ fields for @_File@/@_Fiel... Igor Skornyakov
04:08 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> In case of abends, I think FWD should release all locks, right?
Yes, it should. The...
Eric Faulhaber
01:03 PM Feature #4011: database/persistence layer performance improvements
My changes to fix the #4011-385, the @deleteAll@ problem because there was no notification of a newly created record ... Constantin Asofiei
12:39 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> If you know of any other issues in Hotel GUI which you suspect are related to this root caus...
Constantin Asofiei
08:30 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is no solved by your changes.
OK, thanks for testing. Th...
Eric Faulhaber
08:22 AM Feature #4011: database/persistence layer performance improvements
Eric, the issue in #4011-412 is not solved by your changes. Constantin Asofiei
07:21 AM Feature #4011: database/persistence layer performance improvements
I've committed rev 11450, which reworks the UNDO of DMOs to be primarily in memory on the FWD server, with less relia... Eric Faulhaber

06/03/2020

06:35 PM Feature #4011: database/persistence layer performance improvements
More details:
At this moment the unique-indexes are validated on SQL-tier, the result in case of failure being a dia...
Ovidiu Maxiniuc
05:26 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Please disable the new query-based validation check for now, but then get back to integratin...
Ovidiu Maxiniuc
09:31 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> unique index validation: primarily a no 1 implementation (see entry 127), but also slight...
Eric Faulhaber

06/02/2020

05:34 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Even if this particular issue is related to a regression in batch assign mode, I think the o...
Constantin Asofiei
05:34 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Eric Faulhaber wrote:
> >
> > > We probably need to centra...
Eric Faulhaber
04:36 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > We probably need to centralize the validation/flushing/notifi...
Constantin Asofiei
04:24 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> We probably need to centralize the validation/flushing/notification into one method to mak...
Eric Faulhaber

06/01/2020

03:09 PM Feature #3814: more schema metadata
Added conversion support for the tables/fields string attributes (@*-SA@ properties)
Committed to 4231b rev. 11577.
Igor Skornyakov
12:14 PM Feature #3814: more schema metadata
Debugging the conversion I've realized that I have to add support for the new table/field properties to the @p2o.xml@... Igor Skornyakov
10:04 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Put debug @printf@ statements in the @dmo_common.rules@ section for @graft "column-label-sa" anno...
Igor Skornyakov
09:55 AM Feature #3814: more schema metadata
Put debug @printf@ statements in the @dmo_common.rules@ section for @graft "column-label-sa" annotation@. Either you... Greg Shah
09:38 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Yes.
Well, as you can see the new properties were not added.
Igor Skornyakov
09:02 AM Feature #3814: more schema metadata
Yes. Greg Shah
08:45 AM Feature #3814: more schema metadata
Greg Shah wrote:
> I think you have shown the 4GL AST. The code calling @declareProperty@ is building a Java AST. ...
Igor Skornyakov
08:16 AM Feature #3814: more schema metadata
I think you have shown the 4GL AST. The code calling @declareProperty@ is building a Java AST. Please show that Jav... Greg Shah
07:53 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Please show the output jast for the example field....
Igor Skornyakov
07:48 AM Feature #3814: more schema metadata
Please show the output jast for the example field. Greg Shah
07:32 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Post your @dmo_common.rules@.
>
> Are the annotations correct (as you would expect) in the AST...
Igor Skornyakov
07:25 AM Feature #3814: more schema metadata
Post your @dmo_common.rules@.
Are the annotations correct (as you would expect) in the AST?
Greg Shah
07:16 AM Feature #3814: more schema metadata
I see some strange situation:
There are two similar annotations for the field AST in the @.schema@ file:...
Igor Skornyakov
06:23 AM Feature #3814: more schema metadata
Greg Shah wrote:
> > Please note, that the TYPE for the LABEL property is KW_LABEL, but is VALEXP for VALEXP (not KW...
Igor Skornyakov
06:21 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Feedback:
>
> 1. The artificial token definitions for @KW_COL_LAB@, @KW_HELP@ and @KW_LABEL@ s...
Igor Skornyakov
02:07 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Indeed, the full scan will be required for both of @count(__)@ versions. However, the @limi...
Eric Faulhaber
02:02 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> About the #4011-385 - the issue is that the @ttRoomTypeAgg.deleteAll()@ is seeing the ta...
Eric Faulhaber
12:42 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Some thoughts: that article uses a pseudo randomized unindexed data set. They need the coun...
Constantin Asofiei
12:41 PM Feature #4011: database/persistence layer performance improvements
Some thoughts: that article uses a pseudo randomized unindexed data set. They need the count so the scan is mandatory... Ovidiu Maxiniuc
12:31 PM Feature #4011: database/persistence layer performance improvements
Indeed, the full scan will be required for both of @count(__)@ versions. However, the @limit 1@ will not help. The re... Ovidiu Maxiniuc
12:30 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Anyway, looking at some benchmark articles, like https://www.citusdata.com/blog/2016/1...
Eric Faulhaber
11:50 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I suppose you are talking about the unique index validation. These are queries using standa...
Constantin Asofiei
11:42 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A note: we shouldn't use @select count(*)@ - this should be replaced by something like @...
Ovidiu Maxiniuc
08:12 AM Feature #4011: database/persistence layer performance improvements
About the #4011-385 - the issue is that the @ttRoomTypeAgg.deleteAll()@ is seeing the table as 'empty' (the @isTableD... Constantin Asofiei
07:41 AM Feature #4011: database/persistence layer performance improvements
A note: we shouldn't use @select count(*)@ - this should be replaced by something like @select count(recid)@ or whate... Constantin Asofiei
07:37 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Please continue to test Hotel GUI and work on fixes for any apparent regressions which do no...
Constantin Asofiei
05:08 AM Feature #4011: database/persistence layer performance improvements
Constantin, I am working on a solution, but it may take another day or so. The good news is that I think you may have... Eric Faulhaber

05/31/2020

06:20 PM Feature #3814: more schema metadata
> Please note, that the TYPE for the LABEL property is KW_LABEL, but is VALEXP for VALEXP (not KW_VALEXP)
Yes, tha...
Greg Shah
06:13 PM Feature #3814: more schema metadata
Feedback:
1. The artificial token definitions for @KW_COL_LAB@, @KW_HELP@ and @KW_LABEL@ should not be moved into ...
Greg Shah
09:12 AM Feature #4011: database/persistence layer performance improvements
Eric, is not just about inserts. See this test:... Constantin Asofiei
06:35 AM Feature #4011: database/persistence layer performance improvements
The key is to maintain enough information to differentiate between a savepoint rollback which legitimately undoes a c... Eric Faulhaber
06:16 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, please see this test:
> [...]
>
> The flush is executed at the @find first@ st...
Eric Faulhaber
05:19 AM Feature #4011: database/persistence layer performance improvements
Eric, please see this test:... Constantin Asofiei
08:42 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the main issue with the savepoints, the FWD (sub)-tx and the FWD flush is this: in...
Eric Faulhaber

05/30/2020

05:10 PM Feature #4011: database/persistence layer performance improvements
Eric, the main issue with the savepoints, the FWD (sub)-tx and the FWD flush is this: in H2, a flush will associate t... Constantin Asofiei
04:27 PM Feature #4011: database/persistence layer performance improvements
Constantin, we made a significant functional change in 4011a in terms of the timing of flushes to the database.
As...
Eric Faulhaber
03:59 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> For some reason, FWD does the rollback for the savepoint which has the @guest.create()...
Eric Faulhaber
03:49 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, I have the H2 fixes for CREATE/DROP INDEX, DROP TABLE, ALTER TABLE ADD CONSTRAINT ...
Constantin Asofiei
03:17 PM Feature #4011: database/persistence layer performance improvements
Attached is the changed H2 jar and the patch. Constantin Asofiei
03:05 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Do you have the 197 version of this patch? I can't apply it to ver 197.
Hm, I have...
Eric Faulhaber
02:55 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> For some reason, FWD does the rollback for the savepoint which has the @guest.create()@,...
Constantin Asofiei
02:14 PM Feature #4011: database/persistence layer performance improvements
Eric, I have the H2 fixes for CREATE/DROP INDEX, DROP TABLE, ALTER TABLE ADD CONSTRAINT FOREIGN cases. I'll upload t... Constantin Asofiei
12:46 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, we still require the synchronization patch we have for ...
Constantin Asofiei
10:16 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, we still require the synchronization patch we have for ver 192 (from here: https:/...
Eric Faulhaber
10:04 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Also, the current version is 1.4.200 - should we build the changes on top of that? And a...
Ovidiu Maxiniuc
09:25 AM Feature #4011: database/persistence layer performance improvements
Also, the current version is 1.4.200 - should we build the changes on top of that? And also switch FWD to 1.4.200? Constantin Asofiei
09:22 AM Feature #4011: database/persistence layer performance improvements
Eric, we still require the synchronization patch we have for ver 192 (from here: https://proj.goldencode.com/download... Constantin Asofiei
06:11 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I can see how we could defer the drops until a safe time, aft...
Eric Faulhaber
03:38 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I can see how we could defer the drops until a safe time, after a transaction. The creates a...
Constantin Asofiei
09:59 PM Feature #4011: database/persistence layer performance improvements
I committed r11447. Changes include:
* unique index validation: primarily a no 1 implementation (see entry 127), but...
Ovidiu Maxiniuc
03:27 PM Feature #3814: more schema metadata
I've implemented the changes from #3814-79. However, the desired annotation arguments are still not emitted. I've als... Igor Skornyakov
08:16 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Some feedback:
>
> 1. Keyword token lengths are limited to KW_ + 8 characters. @KW_VALMSG_SA@...
Igor Skornyakov
08:08 AM Feature #3814: more schema metadata
Some feedback:
1. Keyword token lengths are limited to KW_ + 8 characters. @KW_VALMSG_SA@ would be too long. Thi...
Greg Shah
06:52 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Please post your changed versions of both @schema.g@ and @progress.g@.
Please find them attach...
Igor Skornyakov
06:49 AM Feature #3814: more schema metadata
Please post your changed versions of both @schema.g@ and @progress.g@. Greg Shah
06:46 AM Feature #3814: more schema metadata
I'm trying to add conversion support for string attributes for tables and fields (@*-SA@ properties).
I've added th...
Igor Skornyakov

05/29/2020

05:28 PM Feature #4011: database/persistence layer performance improvements
Nice find. I wonder why we weren't hitting this before. I was not doing anything special to do the temp-table DDL out... Eric Faulhaber
04:21 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> * @transactional@ - the H2 manual says that the @CREATE TABLE@ _command commits an open tra...
Constantin Asofiei
03:58 PM Feature #4011: database/persistence layer performance improvements
The root cause for the @Reservations/Check-in/Delete guest/Cancel reservation@ abend related to invalid savepoint is ... Constantin Asofiei
01:22 PM Feature #4011: database/persistence layer performance improvements
OK, so it probably is an issue with the timing of the record flush. Eric Faulhaber
01:16 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > OK, I'll switch to the savepoint problem when using the 'good...
Constantin Asofiei
01:03 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> OK, I'll switch to the savepoint problem when using the 'good data'.
Since you have t...
Eric Faulhaber
01:00 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin,
> I am working on getting these messages parsed and the proper 4GL error issue...
Constantin Asofiei
12:58 PM Feature #4011: database/persistence layer performance improvements
This is one of the open items. See #4011-127. Eric Faulhaber
12:58 PM Feature #4011: database/persistence layer performance improvements
Constantin,
I am working on getting these messages parsed and the proper 4GL error issued. I estimate they will be c...
Ovidiu Maxiniuc
12:55 PM Feature #4011: database/persistence layer performance improvements
OK, that makes sense. My problem is this: in the @validateUniqueCommitted@, we don't know which unique index failed v... Constantin Asofiei
12:53 PM Feature #4011: database/persistence layer performance improvements
This is interesting:... Eric Faulhaber
12:48 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Why is @records@ empty? Shouldn't this be loaded with all the unique records from the ...
Eric Faulhaber
12:37 PM Feature #4011: database/persistence layer performance improvements
Eric/Ovidiu, about the 'bad data' case; there is this class @orm.UniqueTracker@:... Constantin Asofiei
12:26 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > There is another issue, and please let me know if either of ...
Constantin Asofiei
12:08 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There is another issue, and please let me know if either of you tracks it. If you go to...
Ovidiu Maxiniuc
12:04 PM Feature #4011: database/persistence layer performance improvements
There is another issue, and please let me know if either of you tracks it. If you go to @Reservations@, and click @C... Constantin Asofiei
11:54 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, I can't duplicate this anymore - yesterday I saw this issue, but it seems to be fixed in 4011a r11446. Constantin Asofiei
11:51 AM Feature #4011: database/persistence layer performance improvements
From Ovidiu:
> I understand that you managed to get the hotel GUI application up and running (including the database...
Constantin Asofiei
08:30 AM Feature #4011: database/persistence layer performance improvements
Committed rev 11446, which fixes a flushing issue found in testing, adds stricter caching logic to the ORM session to... Eric Faulhaber

05/28/2020

07:36 PM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> The leaking of these malformed records seems less likely to be useful than the one ChUI applicati...
Eric Faulhaber
05:37 PM Feature #4011: database/persistence layer performance improvements
The leaking of these malformed records seems less likely to be useful than the one ChUI application case where the co... Greg Shah
04:50 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> > Constantin Asofiei wrote:
> > > Do you have any unofficial/uncom...
Constantin Asofiei
04:43 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Note regarding the check for null mandatory fields (@checkNotNull@/@failNotNull@) already c...
Eric Faulhaber
04:33 PM Feature #4011: database/persistence layer performance improvements
Constantin,
I think the @AsmClassLoader@ is missing from the command line (see the @-Djava.system.class.loader@).
L...
Ovidiu Maxiniuc
04:31 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Do you have any unofficial/uncommitted updates to Hotel GUI, ...
Eric Faulhaber
04:28 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Do you have any unofficial/uncommitted updates to Hotel GUI, in respect to #4011? I can...
Eric Faulhaber
04:21 PM Feature #4011: database/persistence layer performance improvements
Do you have any unofficial/uncommitted updates to Hotel GUI, in respect to #4011? I can't import the data in H2, I g... Constantin Asofiei
03:58 PM Feature #4011: database/persistence layer performance improvements
Note regarding the check for null mandatory fields (@checkNotNull@/@failNotNull@) already committed in 4011.
Ther...
Ovidiu Maxiniuc

05/27/2020

03:52 PM Feature #4011: database/persistence layer performance improvements
The revision 11445 contains the fix for conversion of FQL statements when denormalized extent fields are present. Ovidiu Maxiniuc
10:55 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I've committed rev 11443.
> Ovidiu, please review, as these are largely in areas of the cod...
Ovidiu Maxiniuc
04:29 AM Feature #4011: database/persistence layer performance improvements
Something in r11440 caused the following regression in Hotel GUI (virtual desktop). Recreate is to check in a guest f... Eric Faulhaber

05/26/2020

08:12 AM Feature #4011: database/persistence layer performance improvements
I've committed rev 11443.
* temp-table copying fixes;
* @ScrollableResults@ fix to not skip first record;
* @SQL...
Eric Faulhaber
08:04 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu, please revert the changes in rev 11441 and commit a new revision to bring the branch...
Ovidiu Maxiniuc
08:03 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > the pdf is generated but my pdf application is not fast enough to display it. The file is delet...
Ovidiu Maxiniuc
07:39 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, please revert the changes in rev 11441 and commit a new revision to bring the branch back to where it was. Do... Eric Faulhaber
06:06 AM Feature #4011: database/persistence layer performance improvements
> the pdf is generated but my pdf application is not fast enough to display it. The file is deleted too fast so a mis... Greg Shah
04:25 AM Feature #4011: database/persistence layer performance improvements
Thanks, but this breaks things the same way as I described. Here's an example stack trace. There are many like this, ... Eric Faulhaber
10:20 PM Feature #4011: database/persistence layer performance improvements
Eric,
I just committed r11441 with some adjustments in @Sql/Query.uniqueResult()@ implementation. I do not know th...
Ovidiu Maxiniuc
09:00 PM Feature #4011: database/persistence layer performance improvements
Ovidiu, can you help me understand the idea behind the @Query.uniqueResult@ implementation? The object ignores @rowSt... Eric Faulhaber
08:39 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> it seems to me that the @PropertyMeta@ and @Property@ like the @DmoMeta@ and @RecordMeta@...
Eric Faulhaber

05/25/2020

06:19 PM Feature #4011: database/persistence layer performance improvements
Eric,
please find r11440 of 4011. Some additional notes:
* the broken SELECT from note 258 was easy to fix, there ...
Ovidiu Maxiniuc
04:51 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin or Greg: is that invalid handle error in #4011-358 something to be concerned with...
Constantin Asofiei
04:42 PM Feature #4011: database/persistence layer performance improvements
Constantin or Greg: is that invalid handle error in #4011-358 something to be concerned with? I want to avoid chasing... Eric Faulhaber
07:58 AM Feature #4011: database/persistence layer performance improvements
Eric,
I finished reviewing your latest changes. They are sound. I added the constant and replaced the related empt...
Ovidiu Maxiniuc
06:41 AM Feature #4011: database/persistence layer performance improvements
I just realized I forgot to add a @NO_ALIAS@ constant to the FQL converter instead of using the empty string literal ... Eric Faulhaber
06:03 AM Feature #4011: database/persistence layer performance improvements
I've committed rev. 11439, which fixes several issues:
* the previously reported @ClassCastException@, which was c...
Eric Faulhaber
05:00 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Consider the @_lock@ table as an example. With the current implementation, the @meta_lock@ t...
Igor Skornyakov
04:54 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Regarding enabling all metadata in all applications, I have no p...
Eric Faulhaber
04:46 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Regarding enabling all metadata in all applications, I have no problem doing this eventually...
Igor Skornyakov
04:32 PM Feature #3814: more schema metadata
Regarding enabling all metadata in all applications, I have no problem doing this eventually, but we do not yet have ... Eric Faulhaber

05/24/2020

04:32 PM Feature #3814: more schema metadata
Greg Shah wrote:
> Please post the detailed status of this task. I would like to know:
>
> * In regard to the li...
Igor Skornyakov

05/23/2020

07:51 AM Feature #4011: database/persistence layer performance improvements
In #4011-355, your references to @no-undo@ are probably meant to be @no-error@?
> This is not the problem to solve...
Greg Shah
07:35 AM Feature #3814: more schema metadata
Please post the detailed status of this task. I would like to know:
* In regard to the list of work in #3814-1 an...
Greg Shah

05/22/2020

06:29 PM Feature #4011: database/persistence layer performance improvements
I've committed rev. 11438, which fixes both the @UniqueTracker@ empty scopes issue and the missing extent field metho... Eric Faulhaber
06:22 PM Feature #4011: database/persistence layer performance improvements
There are a couple of days since I have started thinking of the following issue related to validation.
As I inform...
Ovidiu Maxiniuc
05:33 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Do you have enough information in DMO annotations to generate them?
Yes, but I've had to...
Eric Faulhaber
10:04 AM Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > This can be done of course if you believe that it makes sens...
Igor Skornyakov
09:57 AM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> This can be done of course if you believe that it makes sense to complicate the conversion/...
Constantin Asofiei
09:55 AM Feature #3814: more schema metadata
Constantin Asofiei wrote:
> What about the @_lock@ meta-table? Currently FWD enables this only if @_lock@ is explici...
Igor Skornyakov
09:32 AM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I totally agree with the idea to convert all system tables. After all, in 4GL they exist in...
Constantin Asofiei
09:22 AM Feature #3814: more schema metadata
Greg Shah wrote:
> At this point I see no reason to continue with the configuration at all. Why are we not just con...
Igor Skornyakov
09:07 AM Feature #3814: more schema metadata
> My idea was for the conversion rules to do some sanity checks: if you specified one or more table which is part of ... Greg Shah
09:05 AM Feature #3814: more schema metadata
We really only have one project where we made the effort to eliminate all metadata usage. That may not ever happen a... Greg Shah
09:03 AM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> The overhead with the creation/population of the "minimal" set of meta-tables is negligible...
Constantin Asofiei
08:58 AM Feature #3814: more schema metadata
Constantin Asofiei wrote:
> I'm not OK with this. Meta-tables should be optional. It adds overhead to other projec...
Igor Skornyakov
08:28 AM Feature #3814: more schema metadata
From an email discussion:
Constantin:
> BTW, leaving an empty metadata in p2j.cfg.xml works in FWD, so the meta t...
Constantin Asofiei

05/21/2020

06:02 PM Feature #4011: database/persistence layer performance improvements
My recent changes only involved the conversion. I do not have changes related to @DmoClass@. You can safely work in t... Ovidiu Maxiniuc
02:57 PM Feature #4011: database/persistence layer performance improvements
We are not generating implementations for some methods declared in DMO interfaces, such as indexed getters and setter... Eric Faulhaber

05/20/2020

07:00 AM Feature #3814: more schema metadata
Greg Shah wrote:
> I think 4231b is fine.
Committed to 4231b revision 11549. ...
Igor Skornyakov
06:35 AM Feature #3814: more schema metadata
I think 4231b is fine. Greg Shah

05/19/2020

04:19 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I've finished the population of the @_File@, @_Field@, @_Index@, and @_Index-Field@ system ...
Igor Skornyakov
02:58 PM Feature #4011: database/persistence layer performance improvements
I've just committed my latest changes to 4011 as r11437.
The most important thing here is the fix for the endless qu...
Ovidiu Maxiniuc
10:00 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > but in 4011 this is automatically done by DmoMetadataManager. The 4011 uses the new syntax supp...
Ovidiu Maxiniuc

05/18/2020

06:53 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> OTOH, the @ProgressiveResults@ have @sessionClosing()@ method which will duplicate the un...
Eric Faulhaber
06:27 PM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > but in 4011 this is automatically done by DmoMetadataManager. The 4011 uses the new syntax supp...
Eric Faulhaber
06:04 PM Feature #4011: database/persistence layer performance improvements
> but in 4011 this is automatically done by DmoMetadataManager. The 4011 uses the new syntax supported by H2 (and PSQ... Greg Shah
05:49 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> [..] when a query is associated with a browse, apparently we need some special treatment, be...
Ovidiu Maxiniuc
04:00 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Separately, I committed rev 11436, which completes the fix to the server startup performance...
Ovidiu Maxiniuc
05:02 AM Feature #4011: database/persistence layer performance improvements
The @UniqueTracker@ empty scopes issue seems to be caused by the fact that we aren't registering the tracker for @Fin... Eric Faulhaber
05:44 PM Feature #3814: more schema metadata
I've finished the population of the @_File@, @_Field@, @_Index@, and @_Index-Field@ system tables base on DMO reflect... Igor Skornyakov

05/16/2020

01:53 AM Feature #4011: database/persistence layer performance improvements
Running a single ETF test results in some errors...... Eric Faulhaber

05/15/2020

07:12 PM Feature #4011: database/persistence layer performance improvements
The long delay during ETF server startup while processing index metadata appears to be due to the fact that we swappe... Eric Faulhaber
06:57 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > * Using the mouse wheel to scroll down in the "Available Rooms" ...
Eric Faulhaber
06:32 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> * Using the mouse wheel to scroll down in the "Available Rooms" tab browse results in an end...
Ovidiu Maxiniuc
05:07 PM Feature #3814: more schema metadata
The @_File@ table population for a large customer application (both system and user tables) takes ~100 ms in my envir... Igor Skornyakov
12:55 PM Feature #3814: more schema metadata
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I'm a little bit confused with the discussion in #3145. At the ...
Igor Skornyakov
12:07 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I'm a little bit confused with the discussion in #3145. At the bottom line - is it OK to se...
Ovidiu Maxiniuc
06:18 AM Feature #3814: more schema metadata
I'm a little bit confused with the discussion in #3145. At the bottom line - is it OK to set the value of the @_Templ... Igor Skornyakov
02:55 AM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > [...]
> > I've noticed that the current data for the @_User...
Igor Skornyakov
10:04 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> [...]
> I've noticed that the current data for the @_User@ table in the @xxx.meta.xml@ f...
Eric Faulhaber

05/14/2020

05:45 PM Feature #3814: more schema metadata
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > [...] and @_Template@ is always zero (not a negative number).
...
Igor Skornyakov
05:15 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> [...] and @_Template@ is always zero (not a negative number).
I do not remember exactly, b...
Ovidiu Maxiniuc
05:04 PM Feature #3814: more schema metadata
Populating @_File@ system table based *only* on database metadata (provided by @Connection.getMetaData()@) looks to b... Igor Skornyakov
03:55 PM Feature #4011: database/persistence layer performance improvements
Hotel GUI r220 issues with 4011a:
* Adding a guest to the "Check-In" dialog replaces the existing guest instead of...
Eric Faulhaber
03:26 PM Feature #4011: database/persistence layer performance improvements
I noticed something else related to assigns, which will probably not be handled in this task: the way the ASSIGN trig... Ovidiu Maxiniuc
03:12 PM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> We've never seen this behavior before. I think it can only be seen in a @NO-ERROR@ case because ...
Ovidiu Maxiniuc
07:24 AM Feature #4011: database/persistence layer performance improvements
> Next, if we enable the two commented lines the program will print 0 ? because the values of k and f11 will be rolle... Greg Shah
09:44 PM Feature #4011: database/persistence layer performance improvements
Indeed, to observe the null-mandatory-nonValidated field case the field initial value must be declared @?@, like:
<p...
Ovidiu Maxiniuc

05/13/2020

07:08 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Related to not-null/mandatory validation. There are some issues with current implementation...
Eric Faulhaber
04:28 PM Feature #4011: database/persistence layer performance improvements
Related to not-null/mandatory validation. There are some issues with current implementation.
* 1st: there is a two...
Ovidiu Maxiniuc
03:12 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I will do a test on my HDD to give as a base for comparing future work. How many threads ...
Eric Faulhaber
06:19 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Revision 11434 implements bulk insert (i.e., broader SQL batching) and a few other optimizat...
Ovidiu Maxiniuc
04:05 AM Feature #4011: database/persistence layer performance improvements
Revision 11434 implements bulk insert (i.e., broader SQL batching) and a few other optimizations for the database imp... Eric Faulhaber
09:33 AM Bug #3471: incremental conversion is regressed
Some other parts which are required for incremental conversion:
* the @.wsdl@ generation for exported SOAP services...
Constantin Asofiei

05/12/2020

08:07 AM Feature #3814: more schema metadata
Greg Shah wrote:
> > This can result in a performance drag on the system, in that the maintenance of the state of th...
Igor Skornyakov
08:03 AM Feature #3814: more schema metadata
> do we already have an issue for this?
Not that I recall.
> I do not want to include all system tables support...
Greg Shah

05/11/2020

07:28 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I do not see any potential conflicts between what I see in 4011a and my changes in 4231b. S...
Eric Faulhaber
06:37 PM Feature #3814: more schema metadata
I've made @MetadataManager.initialize()@ implementation as close to one in 4011a as possible. Both implementations a... Igor Skornyakov
06:52 AM Feature #3814: more schema metadata
I do not see any potential conflicts between what I see in 4011a and my changes in 4231b. Some changes will be requir... Igor Skornyakov
02:01 PM Feature #4011: database/persistence layer performance improvements
Thanks for the batch size fix, I hadn't noticed that. Yes, the import organizes the records into batches, but we don'... Eric Faulhaber
12:13 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I've been running database import and I noticed something surprising in the import worker co...
Ovidiu Maxiniuc
05:42 AM Feature #4011: database/persistence layer performance improvements
I'm trying to run my standalone test with H2 database. It runs fine with 4231b, but with 4011a the server fails at st... Igor Skornyakov
04:32 AM Feature #4011: database/persistence layer performance improvements
I've been running database import and I noticed something surprising in the import worker code:... Eric Faulhaber

05/10/2020

03:31 AM Feature #4011: database/persistence layer performance improvements
To clarify, that last line refers to deleting DMOs one at a time using @Persistence.delete@, as is done in the persis... Eric Faulhaber
03:27 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Ovidiu Maxiniuc wrote:
> > > [...]
> > > I think this region o...
Eric Faulhaber

05/09/2020

09:41 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > [...]
> > I think this region of the persistence was not altere...
Ovidiu Maxiniuc
06:38 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> [...]
> I think this region of the persistence was not altered. I wonder how this was work...
Eric Faulhaber

05/08/2020

07:55 PM Feature #4011: database/persistence layer performance improvements
Please find the TempTable DataSource management patch as r11432. I tested the web client and multiple clients connect... Ovidiu Maxiniuc
07:09 PM Feature #4011: database/persistence layer performance improvements
I was testing the new datasource/connection when I encounter the following issue: once a dynamic table (probably not ... Ovidiu Maxiniuc
06:08 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu, w.r.t. the ETF import taking almost 17 hours, is that normal for that machine? It se...
Eric Faulhaber
05:59 PM Feature #4011: database/persistence layer performance improvements
Agreed. That's what I was trying to suggest, but you summarized it better.
Also, looking back at how it ended up, ...
Eric Faulhaber
05:54 PM Feature #4011: database/persistence layer performance improvements
I think the framework might work with this idea: we just move the context from the @TempTableDataSourceProvider@, to ... Ovidiu Maxiniuc
05:46 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The problem is in @JdbcDataSource@. For temp-tables, it is built from the @DataSourceImpl@ ...
Eric Faulhaber
05:04 PM Feature #4011: database/persistence layer performance improvements
The problem is in @JdbcDataSource@. For temp-tables, it is built from the @DataSourceImpl@ returned by the @TempTable... Ovidiu Maxiniuc
04:25 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
>
> > I investigated the connections and they seem to share the sa...
Eric Faulhaber
12:37 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I investigated the connections and they seem to share the same connection. I will investi...
Eric Faulhaber
06:18 AM Feature #4011: database/persistence layer performance improvements
I tried connecting with two clients at once: the Swing client first (only connect, no other clicks) and then the embe... Ovidiu Maxiniuc
04:32 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, w.r.t. the ETF import taking almost 17 hours, is that normal for that machine? It seems really long to me. Wi... Eric Faulhaber
04:08 AM Feature #4011: database/persistence layer performance improvements
Thanks for the fixes.
I rebuilt and converted Hotel GUI from scratch. The import worked, but unfortunately, I stil...
Eric Faulhaber
09:59 PM Feature #4011: database/persistence layer performance improvements
New update, r11431.
There was an issue with _temp records fetched by loader. The hydration wasn't setting up the @_m...
Ovidiu Maxiniuc
03:20 AM Feature #3757: add metadata support
Ovidiu Maxiniuc wrote:
> Igor,
> I do not remember exactly why the @ _database-feature@ was removed. It seems to me...
Igor Skornyakov

05/07/2020

07:24 PM Feature #4011: database/persistence layer performance improvements
Eric,
Please grab -r11429- LE:r11430. I have a separate directory for commits and I forgot to compare and merge in t...
Ovidiu Maxiniuc
06:38 PM Feature #4011: database/persistence layer performance improvements
Ovidiu, I'm getting this during the import step:... Eric Faulhaber
04:40 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The standalone clients now can sequentially connect to server and the table/index cleanup...
Eric Faulhaber
04:15 PM Feature #4011: database/persistence layer performance improvements
I have just committed r11429. Changes include:
* moved DDL generation from @DmoMetadataManager@ to @TempTableHelper@...
Ovidiu Maxiniuc
04:27 AM Feature #4011: database/persistence layer performance improvements
I committed rev 11427, which adds the placeholder suffix at the end of temp-table index names. Note that this short t... Eric Faulhaber
04:19 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> This must be done as some things changed: @id@/@recid@ as PK, @identifier@/@id@, datetime...
Eric Faulhaber
07:17 PM Feature #3757: add metadata support
Igor,
I do not remember exactly why the @ _database-feature@ was removed. It seems to me that, since work on @_ActLo...
Ovidiu Maxiniuc
06:24 PM Feature #3757: add metadata support
Greg Shah wrote:
> I had not planned for you to make everything "live" yet. For this current task, it is OK to exte...
Igor Skornyakov
06:16 PM Feature #3757: add metadata support
I had not planned for you to make everything "live" yet. For this current task, it is OK to extend the current stati... Greg Shah
04:59 PM Feature #3757: add metadata support
Ovidiu Maxiniuc wrote:
> The @_database-feature@ has the runtime support in @MetadataManager.populateDatabaseFeature...
Igor Skornyakov
 

Also available in: Atom