Project

General

Profile

Activity

From 05/17/2020 to 06/15/2020

06/16/2020

11:11 PM Feature #4011: database/persistence layer performance improvements
> issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to check if I'm missing ... Greg Shah
09:42 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. ...
Eric Faulhaber

06/15/2020

07:23 PM Feature #4011: database/persistence layer performance improvements
4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. FQL2SQL will take care of cr... Constantin Asofiei
07:11 PM Feature #4011: database/persistence layer performance improvements
4011a rev 11479 adds the @AnnotatedAst.iterator()@ fix (#4011-574) and refactors rowStructure to allow for self-join. Constantin Asofiei
09:49 AM Feature #4011: database/persistence layer performance improvements
A variation of #4011-549 with the validation:... Constantin Asofiei
05:51 AM Feature #4011: database/persistence layer performance improvements
4011a rev 11475 fixes ChangeSet.ensureCapacity. Constantin Asofiei

06/14/2020

10:25 AM Feature #4011: database/persistence layer performance improvements
> BTW, in FWD (both 4011 and trunk) only the RAQ will consult the dirty database for possible leaking record. The 4GL... Greg Shah

06/13/2020

05:53 PM Feature #4011: database/persistence layer performance improvements
> There's nowhere to descend, nor another sibling. When iter.hasNext() is called after the BOOL_TRUE was processed, i... Greg Shah

06/12/2020

07:03 PM Feature #4011: database/persistence layer performance improvements
Yes, if we can evaluate static sub-expressions during conversion, we roll them up to their result and replace the sub... Eric Faulhaber
07:00 PM Feature #4011: database/persistence layer performance improvements
Is it possible that the WHERE node was dropped in this case? Ovidiu Maxiniuc
06:57 PM Feature #4011: database/persistence layer performance improvements
AFAIK, we didn't change this in 4011a. I wonder why we are hitting this now. Eric Faulhaber
06:42 PM Feature #4011: database/persistence layer performance improvements
There's a bug in @AnnotatedAst.iterator@ when trying to iterate starting from the @BOOL_TRUE@ child (of the @WHERE@ c... Constantin Asofiei
06:20 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The not closed objects are most likely the reason for the me...
Constantin Asofiei
05:37 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready.
See...
Constantin Asofiei
05:25 PM Feature #4011: database/persistence layer performance improvements
Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready. Eric Faulhaber
05:17 PM Feature #4011: database/persistence layer performance improvements
This was inspired by what I saw Hibernate was generating. The most signifiant 32 bit came naturally and will match th... Ovidiu Maxiniuc
05:02 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Or better yet, why use a hashcode for the FK? Just as a convention? This name needs to...
Eric Faulhaber
05:01 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There's something wrong in TempTableHelper when the constraint name is computed:
> [......
Constantin Asofiei
04:45 PM Feature #4011: database/persistence layer performance improvements
There's something wrong in TempTableHelper when the constraint name is computed:... Constantin Asofiei
03:57 PM Feature #4011: database/persistence layer performance improvements
OK, I think this is what Hibernate did as well. We may come back to @PreparedStatement@ caching as a potential optimi... Eric Faulhaber
03:49 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS...
Ovidiu Maxiniuc
03:47 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS...
Constantin Asofiei
03:43 PM Feature #4011: database/persistence layer performance improvements
I think we know when we are done with the statement in all cases, but do we cache @PreparedStatement@ instances to pr... Eric Faulhaber
03:42 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The not closed objects are most likely the reason for the memory issues. I tried to close s...
Constantin Asofiei
03:20 PM Feature #4011: database/persistence layer performance improvements
The not closed objects are most likely the reason for the memory issues. I tried to close some of them but it was rea... Ovidiu Maxiniuc
03:18 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> How were we handling cleanup of the Hibernate query resources?
I think Hibernate was taking...
Constantin Asofiei
03:09 PM Feature #4011: database/persistence layer performance improvements
@AbstractQuery@ has a @cleanup@ method, however, the use of @SQLQuery@ and even @Query@ is somewhat internal/hidden w... Eric Faulhaber
03:04 PM Feature #4011: database/persistence layer performance improvements
Another issue which I don't understand: the @SQLQuery@'s JDBC statement and ResultSet is never closed. Why? Who shou... Constantin Asofiei
03:02 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've moved to another test as the current one is blocked ...
Constantin Asofiei
09:05 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I've moved to another test as the current one is blocked with the flush/mandatory issue....
Constantin Asofiei
08:25 AM Feature #4011: database/persistence layer performance improvements
I've moved to another test as the current one is blocked with the flush/mandatory issue. Now I've reached an extent ... Constantin Asofiei
08:13 PM Feature #4011: database/persistence layer performance improvements
Not exactly. I will add it, thanks. Eric Faulhaber

06/11/2020

07:57 PM Feature #4011: database/persistence layer performance improvements
Eric, do you have this case in your current flush/validation work?... Constantin Asofiei
06:37 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you e...
Eric Faulhaber
06:06 PM Feature #4011: database/persistence layer performance improvements
Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you end up with two records like ... Constantin Asofiei
04:56 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE ...
Constantin Asofiei
03:39 PM Feature #4011: database/persistence layer performance improvements
A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE and there is the same behavio... Constantin Asofiei
03:22 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu, what's the difference between @FqlType.DECIMAL@ and @FqlType.DOUBLE@? How are th...
Ovidiu Maxiniuc
03:07 PM Feature #4011: database/persistence layer performance improvements
11467 contains the ScrollingResults fix, rollback of SqlQuery RSMD usage and another fix in FqlType. Constantin Asofiei
03:06 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Should I call @Persistence$Context.useSession@ for @Scrol...
Eric Faulhaber
02:58 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Should I call @Persistence$Context.useSession@ for @ScrollingResults@, too? I see that w...
Constantin Asofiei
02:48 PM Feature #4011: database/persistence layer performance improvements
I've got an infinite loop because this code:... Constantin Asofiei
12:28 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > That code already has a call for RSMD, @int columnCount =...
Constantin Asofiei
12:26 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> That code already has a call for RSMD, @int columnCount = resultSet.getMetaData().getC...
Eric Faulhaber
12:14 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The foreign table is mapped by @MetaFile.class@ and by defau...
Constantin Asofiei
12:03 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, we have biased as much as we can in this implementation toward speed, so we are ...
Constantin Asofiei
11:45 AM Feature #4011: database/persistence layer performance improvements
Constantin, we have biased as much as we can in this implementation toward speed, so we are avoiding things like @Res... Eric Faulhaber
10:33 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The problem is the previous code assumed the SELECT was always retrieving full records. ...
Ovidiu Maxiniuc
10:24 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > 4011a rev 11465 contains my FQL fixes plus misc. Please rev...
Constantin Asofiei
09:38 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 4011a rev 11465 contains my FQL fixes plus misc. Please review.
I have only a questi...
Ovidiu Maxiniuc

06/10/2020

06:23 PM Feature #4011: database/persistence layer performance improvements
4011a rev 11465 contains my FQL fixes plus misc. Please review. Constantin Asofiei
06:17 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The foreign table is mapped by @MetaFile.class@ and by default the 'foreign' field is also ...
Constantin Asofiei
01:53 PM Feature #4011: database/persistence layer performance improvements
Lots of regression after changing it... so no good. Constantin Asofiei
01:49 PM Feature #4011: database/persistence layer performance improvements
There is a problem at the fql.g parser:... Constantin Asofiei
01:43 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Found a broken feature I forgot about in 4011: sequences, see #3814-109.
> We need to add ...
Ovidiu Maxiniuc
12:05 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Replacing Record with Persistable fixes the above.
> I am n...
Constantin Asofiei
11:59 AM Feature #4011: database/persistence layer performance improvements
Constantin,
After running conversion with a newer metadata definition I have this:...
Ovidiu Maxiniuc
11:16 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu, I have a problem with the relation generated between the Field and File meta tab...
Ovidiu Maxiniuc
10:48 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Replacing Record with Persistable fixes the above.
I am not sure is not correct. Which ...
Ovidiu Maxiniuc
09:17 AM Feature #4011: database/persistence layer performance improvements
Replacing Record with Persistable fixes the above. Constantin Asofiei
09:02 AM Feature #4011: database/persistence layer performance improvements
I've fixed that manually (BTW, @name="id"@ should be @name="recid"@, depending on what you configured as the PK in p2... Constantin Asofiei
08:51 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, I have a problem with the relation generated between the Field and File meta tables. In DMO index, I have th... Constantin Asofiei
08:37 AM Feature #4011: database/persistence layer performance improvements
11463 fixes the FqlType issue in #4011-517. But I think we need complete support for FqlType enum. Constantin Asofiei
07:53 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, I need a mapping between FQLType enum values and java.sql.Types. Can you provide a complete list? Constantin Asofiei
06:05 AM Feature #4011: database/persistence layer performance improvements
Rev 11462 fixes @TB.readAllRows@. It also has some validation, flush, rollback fixes that are work in process. They d... Eric Faulhaber
05:33 PM Feature #4155 (WIP): remove conversion dependency on metadata .df file
Our ultimate objective with schema metadata is to eliminate the conversion of these DMOs and instead rely upon metada... Greg Shah
10:21 AM Feature #3814: more schema metadata
Greg Shah wrote:
> As you check in updates for this task, the @rules/gaps/database.rules@ (@addMetaschema@ section) ...
Igor Skornyakov
10:19 AM Feature #3814: more schema metadata
As you check in updates for this task, the @rules/gaps/database.rules@ (@addMetaschema@ section) needs to be updated ... Greg Shah

06/09/2020

07:13 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There is this code in @TemporaryBuffer.readAllRows@:
> [...]
>
> I would expect @res...
Constantin Asofiei
07:01 PM Feature #4011: database/persistence layer performance improvements
There is this code in @TemporaryBuffer.readAllRows@:... Constantin Asofiei
03:32 PM Feature #4011: database/persistence layer performance improvements
Actually, the code above will not work for PostgreSQL as the @getComputedColumnFormula@ will return @null@. It looks ... Ovidiu Maxiniuc
03:19 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > That is interesting. It looks like I added a regression when...
Ovidiu Maxiniuc
03:14 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> That is interesting. It looks like I added a regression when constructing validation messag...
Constantin Asofiei
03:12 PM Feature #4011: database/persistence layer performance improvements
That is interesting. It looks like I added a regression when constructing validation message in my recent commit. Ple... Ovidiu Maxiniuc
02:59 PM Feature #4011: database/persistence layer performance improvements
Ovidiu, one more - I don't understand where the "__i?" is coming from.... Constantin Asofiei
02:44 PM Feature #4011: database/persistence layer performance improvements
If the query already has fetched the full records, we already would have used the session cache to gain this optimiza... Eric Faulhaber
02:37 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin,
> I think the change you refer to was mine. The idea was to fetch the exact am...
Constantin Asofiei
02:36 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> This part in @metaschema.xml@ is wrong:
> [...]
> We need to use the primary key as s...
Ovidiu Maxiniuc
02:30 PM Feature #4011: database/persistence layer performance improvements
Constantin,
I think the change you refer to in #4011-504 was mine. The idea was to fetch the exact amount of informa...
Ovidiu Maxiniuc
02:21 PM Feature #4011: database/persistence layer performance improvements
This part in @metaschema.xml@ is wrong:... Constantin Asofiei
01:31 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, what part is wrong here? The @Presorter$SortedResults@ which expects full records,...
Constantin Asofiei
01:12 PM Feature #4011: database/persistence layer performance improvements
Found a broken feature I forgot about in 4011: sequences, see #3814-109.
We need to add back initialization support ...
Ovidiu Maxiniuc
10:02 AM Feature #4011: database/persistence layer performance improvements
If you enable enhanced browse, and click the 'checkin' column in the Guests grid, you get a @ClassCastException@:
<p...
Constantin Asofiei
09:46 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Attached are my changes in process for the rollback fix. It is not working yet, but I am pos...
Constantin Asofiei
08:22 AM Feature #4011: database/persistence layer performance improvements
Attached are my changes in process for the rollback fix. It is not working yet, but I am posting because I need to ta... Eric Faulhaber
07:06 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > The reason I ask is that I noticed in the debugger that the...
Eric Faulhaber
07:01 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I guess all the changes for @LazyUndoable@ are just an optimization, but the core idea is st...
Constantin Asofiei
06:55 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Now my problem is that @LightweightUndoable@ is nothing like I remember it. I guess all th...
Eric Faulhaber
06:46 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> OK, so the record doesn't need to remain in the database, as the flush is rolledback, ...
Eric Faulhaber
06:38 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I don't understand this patch. I mean, I get the logic, but it doesn't look right to me conc...
Constantin Asofiei
06:32 AM Feature #4011: database/persistence layer performance improvements
I don't understand this patch. I mean, I get the logic, but it doesn't look right to me conceptually. The point of ma... Eric Faulhaber
06:14 AM Feature #4011: database/persistence layer performance improvements
Eric, attached patch fixes this testcases:... Constantin Asofiei
05:47 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Going back to this: I've tried saving the record in the database, in @ChangeSet.rollba...
Eric Faulhaber
02:33 PM Feature #3814: more schema metadata
Greg Shah wrote:
> My worry here is that you are creating new things that will be hard to merge with 4011a. We plan...
Igor Skornyakov
02:16 PM Feature #3814: more schema metadata
My worry here is that you are creating new things that will be hard to merge with 4011a. We plan to do that merge ve... Greg Shah
01:29 PM Feature #3814: more schema metadata
Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
> Yes, the @DMOIndex@ c...
Igor Skornyakov
01:07 PM Feature #3814: more schema metadata
Greg Shah wrote:
> Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
Yes, the @DMOIndex@ class is already gone in 4011a....
Ovidiu Maxiniuc
12:24 PM Feature #3814: more schema metadata
Greg Shah wrote:
> Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
I already use @DMOIndex@ in the @MetadataManager@...
Igor Skornyakov
12:12 PM Feature #3814: more schema metadata
Ovidiu: Doesn't @DMOIndex@ go away in 4011a? Greg Shah
12:04 PM Feature #3814: more schema metadata
Ovidiu Maxiniuc wrote:
> Of course, please see the last lines in @ddl/schema_table_<db-name>_<sql-dialect>.sql@. Aft...
Igor Skornyakov
11:23 AM Feature #3814: more schema metadata
Of course, please see the last lines in @ddl/schema_table_<db-name>_<sql-dialect>.sql@. After a successuful conversio... Ovidiu Maxiniuc
04:27 AM Feature #3814: more schema metadata
Do we generate any artifacts for @SEQUENCE@? I cannot find any. The corresponding AST exists. Please advise.
Thank you.
Igor Skornyakov

06/08/2020

02:12 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Eric Faulhaber wrote:
> > > Constantin, at this level in...
Constantin Asofiei
02:00 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I didn't think so. We should be fetching it from the database...
Constantin Asofiei
01:54 PM Feature #4011: database/persistence layer performance improvements
Constantin,
in FWD runtime the primary key name is read from @persistence/primary-key-name@ and stored globally in @...
Ovidiu Maxiniuc
01:36 PM Feature #4011: database/persistence layer performance improvements
Eric, in #4011-303, you note that in @p2j.cfg.xml@ you used this:... Constantin Asofiei
11:13 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin, at this level in the code, we are not dealing wit...
Constantin Asofiei
11:04 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, at this level in the code, we are not dealing with BDT instances.
You are corr...
Constantin Asofiei
11:00 AM Feature #4011: database/persistence layer performance improvements
Constantin, at this level in the code, we are not dealing with BDT instances. These are the lower level Java types wh... Eric Faulhaber
10:51 AM Feature #4011: database/persistence layer performance improvements
This fix solves all deadlocks related to locking (even those which exist in trunk), in @BaseRecord.setDatum@:... Constantin Asofiei
10:17 AM Feature #4011: database/persistence layer performance improvements
There is a deadlock when updating a Rate or a Guest by multiple clients, but this is an application logic problem.
...
Constantin Asofiei
08:57 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I didn't think so. We should be fetching it from the database on next access.
The problem ...
Constantin Asofiei
08:46 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The abend in Reservations/Check-in/Delete Guest/Cancel Check-in is related to this test:...
Eric Faulhaber
08:41 AM Feature #4011: database/persistence layer performance improvements
The abend in Reservations/Check-in/Delete Guest/Cancel Check-in is related to this test:... Constantin Asofiei
07:52 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, please commit your change to always use @NopDirtyShareContext@, with a TODO to r...
Constantin Asofiei
07:04 AM Feature #4011: database/persistence layer performance improvements
Rev 11455 fixes an NPE and some validation logic. Eric Faulhaber
06:56 AM Feature #4011: database/persistence layer performance improvements
Constantin, please commit your change to always use @NopDirtyShareContext@, with a TODO to re-enable it when the re-i... Eric Faulhaber
06:48 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> So, the dirty share database should be used only for explicitly-configured tables/data...
Eric Faulhaber
06:04 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> After another full @ant deploy.all@, this time with the data from Hotel GUI rev 212, I now g...
Constantin Asofiei
05:57 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> And another issue with the dirty database - previously there were @Reversible@ instances...
Constantin Asofiei
05:51 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Please coordinate with Ovidiu on this; he is actively making changes in this area. The dirty...
Constantin Asofiei
05:46 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > BTW, also found these in the server log from the same work fl...
Eric Faulhaber
05:20 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> BTW, also found these in the server log from the same work flow:
>
> [...]
The root caus...
Constantin Asofiei
05:04 AM Feature #4011: database/persistence layer performance improvements
OK, I'll check with H2, too.
BTW, I still see the NPE for the 'delete guest' and 'Cancel', in the Reservations, C...
Constantin Asofiei
05:00 AM Feature #4011: database/persistence layer performance improvements
BTW, also found these in the server log from the same work flow:... Eric Faulhaber
04:59 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I am using the default H2 database in my testing. I'll try with PostgreSQL.
Indeed, the...
Eric Faulhaber
04:42 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 11454 does not compile for me:
> [...]
>
> I've bypassed this and I don't get your e...
Eric Faulhaber
04:35 AM Feature #4011: database/persistence layer performance improvements
11454 does not compile for me:... Constantin Asofiei
04:24 AM Feature #4011: database/persistence layer performance improvements
After another full @ant deploy.all@, this time with the data from Hotel GUI rev 212, I now get the following error wi... Eric Faulhaber
04:00 AM Feature #4011: database/persistence layer performance improvements
On a completely fresh run of Hotel GUI, first thing after running @ant deploy.all@ and server startup, I get some err... Eric Faulhaber
08:50 AM Feature #3814: more schema metadata
> Regarding the undocumented fields of the _Field table, I think that it can be sufficient to set them to a "typical"... Greg Shah
08:30 AM Feature #3814: more schema metadata
Greg Shah wrote:
> > This means that the _File._ianum is almost useless and has not any meaningful counterpart in FW...
Igor Skornyakov
08:01 AM Feature #3814: more schema metadata
> This means that the _File._ianum is almost useless and has not any meaningful counterpart in FWD. I understand the ... Greg Shah
07:38 AM Feature #3813: misc DB features part deux
Considering that the WHERE clause work has been moved to #4613, is there any reason to keep this task open? Greg Shah

06/05/2020

07:12 PM Feature #4011: database/persistence layer performance improvements
Unfortunately, I don't have the dirty share fully done yet.
To let my brain cool down I returned and fixed the uniqu...
Ovidiu Maxiniuc
05:57 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Virtual desktop and embedded mode get through this flow fine,...
Eric Faulhaber
05:42 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > The only issue I'm aware in Hotel GUI is the NPE related to C...
Constantin Asofiei
05:41 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Virtual desktop and embedded mode get through this flow fine, so it may be a client problem ...
Constantin Asofiei
05:36 PM Feature #4011: database/persistence layer performance improvements
Another issue I hit was in Swing only:
* log in
* from "Available Rooms", click "Check-In..."
* delete guest
* ...
Eric Faulhaber
05:32 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, afte...
Eric Faulhaber
05:15 PM Feature #4011: database/persistence layer performance improvements
The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, after deleting the guest. Constantin Asofiei
05:13 PM Feature #4011: database/persistence layer performance improvements
This code in @RecordBuffer.delete@ doesn't set the @token@:... Constantin Asofiei
04:56 PM Feature #4011: database/persistence layer performance improvements
The deadlock described in #4011-385 can be duplicated like this in 11452:
* delete a room
* close and start another...
Constantin Asofiei
02:56 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> My changes to fix the #4011-385, the @deleteAll@ problem because there was no notificati...
Constantin Asofiei
05:35 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion...
Constantin Asofiei
05:17 AM Feature #4011: database/persistence layer performance improvements
Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion from scratch and try it ... Eric Faulhaber
05:07 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, the issue in #4011-412 is not solved by your changes.
...
Constantin Asofiei
04:57 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is not solved by your changes.
Constantin, I don't get a...
Eric Faulhaber
04:38 PM Feature #3814: more schema metadata
# restored @_database-feature@ support previously implemented by Ovidiu
# added the following @_file@ fields:...
Igor Skornyakov

06/04/2020

05:20 PM Feature #3814: more schema metadata
Added conversion support for the @_Field.CAN-*@ fields and population of @CAN_*@ and @*-SA@ fields for @_File@/@_Fiel... Igor Skornyakov
04:08 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> In case of abends, I think FWD should release all locks, right?
Yes, it should. The...
Eric Faulhaber
01:03 PM Feature #4011: database/persistence layer performance improvements
My changes to fix the #4011-385, the @deleteAll@ problem because there was no notification of a newly created record ... Constantin Asofiei
12:39 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> If you know of any other issues in Hotel GUI which you suspect are related to this root caus...
Constantin Asofiei
08:30 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is no solved by your changes.
OK, thanks for testing. Th...
Eric Faulhaber
08:22 AM Feature #4011: database/persistence layer performance improvements
Eric, the issue in #4011-412 is not solved by your changes. Constantin Asofiei
07:21 AM Feature #4011: database/persistence layer performance improvements
I've committed rev 11450, which reworks the UNDO of DMOs to be primarily in memory on the FWD server, with less relia... Eric Faulhaber

06/03/2020

06:35 PM Feature #4011: database/persistence layer performance improvements
More details:
At this moment the unique-indexes are validated on SQL-tier, the result in case of failure being a dia...
Ovidiu Maxiniuc
05:26 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Please disable the new query-based validation check for now, but then get back to integratin...
Ovidiu Maxiniuc
09:31 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> unique index validation: primarily a no 1 implementation (see entry 127), but also slight...
Eric Faulhaber

06/02/2020

05:34 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Even if this particular issue is related to a regression in batch assign mode, I think the o...
Constantin Asofiei
05:34 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Eric Faulhaber wrote:
> >
> > > We probably need to centra...
Eric Faulhaber
04:36 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > We probably need to centralize the validation/flushing/notifi...
Constantin Asofiei
04:24 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> We probably need to centralize the validation/flushing/notification into one method to mak...
Eric Faulhaber

06/01/2020

03:09 PM Feature #3814: more schema metadata
Added conversion support for the tables/fields string attributes (@*-SA@ properties)
Committed to 4231b rev. 11577.
Igor Skornyakov
12:14 PM Feature #3814: more schema metadata
Debugging the conversion I've realized that I have to add support for the new table/field properties to the @p2o.xml@... Igor Skornyakov
10:04 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Put debug @printf@ statements in the @dmo_common.rules@ section for @graft "column-label-sa" anno...
Igor Skornyakov
09:55 AM Feature #3814: more schema metadata
Put debug @printf@ statements in the @dmo_common.rules@ section for @graft "column-label-sa" annotation@. Either you... Greg Shah
09:38 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Yes.
Well, as you can see the new properties were not added.
Igor Skornyakov
09:02 AM Feature #3814: more schema metadata
Yes. Greg Shah
08:45 AM Feature #3814: more schema metadata
Greg Shah wrote:
> I think you have shown the 4GL AST. The code calling @declareProperty@ is building a Java AST. ...
Igor Skornyakov
08:16 AM Feature #3814: more schema metadata
I think you have shown the 4GL AST. The code calling @declareProperty@ is building a Java AST. Please show that Jav... Greg Shah
07:53 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Please show the output jast for the example field....
Igor Skornyakov
07:48 AM Feature #3814: more schema metadata
Please show the output jast for the example field. Greg Shah
07:32 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Post your @dmo_common.rules@.
>
> Are the annotations correct (as you would expect) in the AST...
Igor Skornyakov
07:25 AM Feature #3814: more schema metadata
Post your @dmo_common.rules@.
Are the annotations correct (as you would expect) in the AST?
Greg Shah
07:16 AM Feature #3814: more schema metadata
I see some strange situation:
There are two similar annotations for the field AST in the @.schema@ file:...
Igor Skornyakov
06:23 AM Feature #3814: more schema metadata
Greg Shah wrote:
> > Please note, that the TYPE for the LABEL property is KW_LABEL, but is VALEXP for VALEXP (not KW...
Igor Skornyakov
06:21 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Feedback:
>
> 1. The artificial token definitions for @KW_COL_LAB@, @KW_HELP@ and @KW_LABEL@ s...
Igor Skornyakov
02:07 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Indeed, the full scan will be required for both of @count(__)@ versions. However, the @limi...
Eric Faulhaber
02:02 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> About the #4011-385 - the issue is that the @ttRoomTypeAgg.deleteAll()@ is seeing the ta...
Eric Faulhaber
12:42 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Some thoughts: that article uses a pseudo randomized unindexed data set. They need the coun...
Constantin Asofiei
12:41 PM Feature #4011: database/persistence layer performance improvements
Some thoughts: that article uses a pseudo randomized unindexed data set. They need the count so the scan is mandatory... Ovidiu Maxiniuc
12:31 PM Feature #4011: database/persistence layer performance improvements
Indeed, the full scan will be required for both of @count(__)@ versions. However, the @limit 1@ will not help. The re... Ovidiu Maxiniuc
12:30 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Anyway, looking at some benchmark articles, like https://www.citusdata.com/blog/2016/1...
Eric Faulhaber
11:50 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I suppose you are talking about the unique index validation. These are queries using standa...
Constantin Asofiei
11:42 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A note: we shouldn't use @select count(*)@ - this should be replaced by something like @...
Ovidiu Maxiniuc
08:12 AM Feature #4011: database/persistence layer performance improvements
About the #4011-385 - the issue is that the @ttRoomTypeAgg.deleteAll()@ is seeing the table as 'empty' (the @isTableD... Constantin Asofiei
07:41 AM Feature #4011: database/persistence layer performance improvements
A note: we shouldn't use @select count(*)@ - this should be replaced by something like @select count(recid)@ or whate... Constantin Asofiei
07:37 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Please continue to test Hotel GUI and work on fixes for any apparent regressions which do no...
Constantin Asofiei
05:08 AM Feature #4011: database/persistence layer performance improvements
Constantin, I am working on a solution, but it may take another day or so. The good news is that I think you may have... Eric Faulhaber

05/31/2020

06:20 PM Feature #3814: more schema metadata
> Please note, that the TYPE for the LABEL property is KW_LABEL, but is VALEXP for VALEXP (not KW_VALEXP)
Yes, tha...
Greg Shah
06:13 PM Feature #3814: more schema metadata
Feedback:
1. The artificial token definitions for @KW_COL_LAB@, @KW_HELP@ and @KW_LABEL@ should not be moved into ...
Greg Shah
09:12 AM Feature #4011: database/persistence layer performance improvements
Eric, is not just about inserts. See this test:... Constantin Asofiei
06:35 AM Feature #4011: database/persistence layer performance improvements
The key is to maintain enough information to differentiate between a savepoint rollback which legitimately undoes a c... Eric Faulhaber
06:16 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, please see this test:
> [...]
>
> The flush is executed at the @find first@ st...
Eric Faulhaber
05:19 AM Feature #4011: database/persistence layer performance improvements
Eric, please see this test:... Constantin Asofiei
08:42 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the main issue with the savepoints, the FWD (sub)-tx and the FWD flush is this: in...
Eric Faulhaber

05/30/2020

05:10 PM Feature #4011: database/persistence layer performance improvements
Eric, the main issue with the savepoints, the FWD (sub)-tx and the FWD flush is this: in H2, a flush will associate t... Constantin Asofiei
04:27 PM Feature #4011: database/persistence layer performance improvements
Constantin, we made a significant functional change in 4011a in terms of the timing of flushes to the database.
As...
Eric Faulhaber
03:59 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> For some reason, FWD does the rollback for the savepoint which has the @guest.create()...
Eric Faulhaber
03:49 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, I have the H2 fixes for CREATE/DROP INDEX, DROP TABLE, ALTER TABLE ADD CONSTRAINT ...
Constantin Asofiei
03:17 PM Feature #4011: database/persistence layer performance improvements
Attached is the changed H2 jar and the patch. Constantin Asofiei
03:05 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Do you have the 197 version of this patch? I can't apply it to ver 197.
Hm, I have...
Eric Faulhaber
02:55 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> For some reason, FWD does the rollback for the savepoint which has the @guest.create()@,...
Constantin Asofiei
02:14 PM Feature #4011: database/persistence layer performance improvements
Eric, I have the H2 fixes for CREATE/DROP INDEX, DROP TABLE, ALTER TABLE ADD CONSTRAINT FOREIGN cases. I'll upload t... Constantin Asofiei
12:46 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, we still require the synchronization patch we have for ...
Constantin Asofiei
10:16 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, we still require the synchronization patch we have for ver 192 (from here: https:/...
Eric Faulhaber
10:04 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Also, the current version is 1.4.200 - should we build the changes on top of that? And a...
Ovidiu Maxiniuc
09:25 AM Feature #4011: database/persistence layer performance improvements
Also, the current version is 1.4.200 - should we build the changes on top of that? And also switch FWD to 1.4.200? Constantin Asofiei
09:22 AM Feature #4011: database/persistence layer performance improvements
Eric, we still require the synchronization patch we have for ver 192 (from here: https://proj.goldencode.com/download... Constantin Asofiei
06:11 AM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I can see how we could defer the drops until a safe time, aft...
Eric Faulhaber
03:38 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I can see how we could defer the drops until a safe time, after a transaction. The creates a...
Constantin Asofiei
09:59 PM Feature #4011: database/persistence layer performance improvements
I committed r11447. Changes include:
* unique index validation: primarily a no 1 implementation (see entry 127), but...
Ovidiu Maxiniuc
03:27 PM Feature #3814: more schema metadata
I've implemented the changes from #3814-79. However, the desired annotation arguments are still not emitted. I've als... Igor Skornyakov
08:16 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Some feedback:
>
> 1. Keyword token lengths are limited to KW_ + 8 characters. @KW_VALMSG_SA@...
Igor Skornyakov
08:08 AM Feature #3814: more schema metadata
Some feedback:
1. Keyword token lengths are limited to KW_ + 8 characters. @KW_VALMSG_SA@ would be too long. Thi...
Greg Shah
06:52 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Please post your changed versions of both @schema.g@ and @progress.g@.
Please find them attach...
Igor Skornyakov
06:49 AM Feature #3814: more schema metadata
Please post your changed versions of both @schema.g@ and @progress.g@. Greg Shah
06:46 AM Feature #3814: more schema metadata
I'm trying to add conversion support for string attributes for tables and fields (@*-SA@ properties).
I've added th...
Igor Skornyakov

05/29/2020

05:28 PM Feature #4011: database/persistence layer performance improvements
Nice find. I wonder why we weren't hitting this before. I was not doing anything special to do the temp-table DDL out... Eric Faulhaber
04:21 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> * @transactional@ - the H2 manual says that the @CREATE TABLE@ _command commits an open tra...
Constantin Asofiei
03:58 PM Feature #4011: database/persistence layer performance improvements
The root cause for the @Reservations/Check-in/Delete guest/Cancel reservation@ abend related to invalid savepoint is ... Constantin Asofiei
01:22 PM Feature #4011: database/persistence layer performance improvements
OK, so it probably is an issue with the timing of the record flush. Eric Faulhaber
01:16 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > OK, I'll switch to the savepoint problem when using the 'good...
Constantin Asofiei
01:03 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> OK, I'll switch to the savepoint problem when using the 'good data'.
Since you have t...
Eric Faulhaber
01:00 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin,
> I am working on getting these messages parsed and the proper 4GL error issue...
Constantin Asofiei
12:58 PM Feature #4011: database/persistence layer performance improvements
This is one of the open items. See #4011-127. Eric Faulhaber
12:58 PM Feature #4011: database/persistence layer performance improvements
Constantin,
I am working on getting these messages parsed and the proper 4GL error issued. I estimate they will be c...
Ovidiu Maxiniuc
12:55 PM Feature #4011: database/persistence layer performance improvements
OK, that makes sense. My problem is this: in the @validateUniqueCommitted@, we don't know which unique index failed v... Constantin Asofiei
12:53 PM Feature #4011: database/persistence layer performance improvements
This is interesting:... Eric Faulhaber
12:48 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Why is @records@ empty? Shouldn't this be loaded with all the unique records from the ...
Eric Faulhaber
12:37 PM Feature #4011: database/persistence layer performance improvements
Eric/Ovidiu, about the 'bad data' case; there is this class @orm.UniqueTracker@:... Constantin Asofiei
12:26 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > There is another issue, and please let me know if either of ...
Constantin Asofiei
12:08 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There is another issue, and please let me know if either of you tracks it. If you go to...
Ovidiu Maxiniuc
12:04 PM Feature #4011: database/persistence layer performance improvements
There is another issue, and please let me know if either of you tracks it. If you go to @Reservations@, and click @C... Constantin Asofiei
11:54 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, I can't duplicate this anymore - yesterday I saw this issue, but it seems to be fixed in 4011a r11446. Constantin Asofiei
11:51 AM Feature #4011: database/persistence layer performance improvements
From Ovidiu:
> I understand that you managed to get the hotel GUI application up and running (including the database...
Constantin Asofiei
08:30 AM Feature #4011: database/persistence layer performance improvements
Committed rev 11446, which fixes a flushing issue found in testing, adds stricter caching logic to the ORM session to... Eric Faulhaber

05/28/2020

07:36 PM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> The leaking of these malformed records seems less likely to be useful than the one ChUI applicati...
Eric Faulhaber
05:37 PM Feature #4011: database/persistence layer performance improvements
The leaking of these malformed records seems less likely to be useful than the one ChUI application case where the co... Greg Shah
04:50 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> > Constantin Asofiei wrote:
> > > Do you have any unofficial/uncom...
Constantin Asofiei
04:43 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Note regarding the check for null mandatory fields (@checkNotNull@/@failNotNull@) already c...
Eric Faulhaber
04:33 PM Feature #4011: database/persistence layer performance improvements
Constantin,
I think the @AsmClassLoader@ is missing from the command line (see the @-Djava.system.class.loader@).
L...
Ovidiu Maxiniuc
04:31 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Do you have any unofficial/uncommitted updates to Hotel GUI, ...
Eric Faulhaber
04:28 PM Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Do you have any unofficial/uncommitted updates to Hotel GUI, in respect to #4011? I can...
Eric Faulhaber
04:21 PM Feature #4011: database/persistence layer performance improvements
Do you have any unofficial/uncommitted updates to Hotel GUI, in respect to #4011? I can't import the data in H2, I g... Constantin Asofiei
03:58 PM Feature #4011: database/persistence layer performance improvements
Note regarding the check for null mandatory fields (@checkNotNull@/@failNotNull@) already committed in 4011.
Ther...
Ovidiu Maxiniuc

05/27/2020

03:52 PM Feature #4011: database/persistence layer performance improvements
The revision 11445 contains the fix for conversion of FQL statements when denormalized extent fields are present. Ovidiu Maxiniuc
10:55 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I've committed rev 11443.
> Ovidiu, please review, as these are largely in areas of the cod...
Ovidiu Maxiniuc
04:29 AM Feature #4011: database/persistence layer performance improvements
Something in r11440 caused the following regression in Hotel GUI (virtual desktop). Recreate is to check in a guest f... Eric Faulhaber

05/26/2020

08:12 AM Feature #4011: database/persistence layer performance improvements
I've committed rev 11443.
* temp-table copying fixes;
* @ScrollableResults@ fix to not skip first record;
* @SQL...
Eric Faulhaber
08:04 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu, please revert the changes in rev 11441 and commit a new revision to bring the branch...
Ovidiu Maxiniuc
08:03 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > the pdf is generated but my pdf application is not fast enough to display it. The file is delet...
Ovidiu Maxiniuc
07:39 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, please revert the changes in rev 11441 and commit a new revision to bring the branch back to where it was. Do... Eric Faulhaber
06:06 AM Feature #4011: database/persistence layer performance improvements
> the pdf is generated but my pdf application is not fast enough to display it. The file is deleted too fast so a mis... Greg Shah
04:25 AM Feature #4011: database/persistence layer performance improvements
Thanks, but this breaks things the same way as I described. Here's an example stack trace. There are many like this, ... Eric Faulhaber
10:20 PM Feature #4011: database/persistence layer performance improvements
Eric,
I just committed r11441 with some adjustments in @Sql/Query.uniqueResult()@ implementation. I do not know th...
Ovidiu Maxiniuc
09:00 PM Feature #4011: database/persistence layer performance improvements
Ovidiu, can you help me understand the idea behind the @Query.uniqueResult@ implementation? The object ignores @rowSt... Eric Faulhaber
08:39 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> it seems to me that the @PropertyMeta@ and @Property@ like the @DmoMeta@ and @RecordMeta@...
Eric Faulhaber

05/25/2020

06:19 PM Feature #4011: database/persistence layer performance improvements
Eric,
please find r11440 of 4011. Some additional notes:
* the broken SELECT from note 258 was easy to fix, there ...
Ovidiu Maxiniuc
04:51 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin or Greg: is that invalid handle error in #4011-358 something to be concerned with...
Constantin Asofiei
04:42 PM Feature #4011: database/persistence layer performance improvements
Constantin or Greg: is that invalid handle error in #4011-358 something to be concerned with? I want to avoid chasing... Eric Faulhaber
07:58 AM Feature #4011: database/persistence layer performance improvements
Eric,
I finished reviewing your latest changes. They are sound. I added the constant and replaced the related empt...
Ovidiu Maxiniuc
06:41 AM Feature #4011: database/persistence layer performance improvements
I just realized I forgot to add a @NO_ALIAS@ constant to the FQL converter instead of using the empty string literal ... Eric Faulhaber
06:03 AM Feature #4011: database/persistence layer performance improvements
I've committed rev. 11439, which fixes several issues:
* the previously reported @ClassCastException@, which was c...
Eric Faulhaber
05:00 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Consider the @_lock@ table as an example. With the current implementation, the @meta_lock@ t...
Igor Skornyakov
04:54 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Regarding enabling all metadata in all applications, I have no p...
Eric Faulhaber
04:46 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Regarding enabling all metadata in all applications, I have no problem doing this eventually...
Igor Skornyakov
04:32 PM Feature #3814: more schema metadata
Regarding enabling all metadata in all applications, I have no problem doing this eventually, but we do not yet have ... Eric Faulhaber

05/24/2020

04:32 PM Feature #3814: more schema metadata
Greg Shah wrote:
> Please post the detailed status of this task. I would like to know:
>
> * In regard to the li...
Igor Skornyakov

05/23/2020

07:51 AM Feature #4011: database/persistence layer performance improvements
In #4011-355, your references to @no-undo@ are probably meant to be @no-error@?
> This is not the problem to solve...
Greg Shah
07:35 AM Feature #3814: more schema metadata
Please post the detailed status of this task. I would like to know:
* In regard to the list of work in #3814-1 an...
Greg Shah

05/22/2020

06:29 PM Feature #4011: database/persistence layer performance improvements
I've committed rev. 11438, which fixes both the @UniqueTracker@ empty scopes issue and the missing extent field metho... Eric Faulhaber
06:22 PM Feature #4011: database/persistence layer performance improvements
There are a couple of days since I have started thinking of the following issue related to validation.
As I inform...
Ovidiu Maxiniuc
05:33 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Do you have enough information in DMO annotations to generate them?
Yes, but I've had to...
Eric Faulhaber
10:04 AM Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > This can be done of course if you believe that it makes sens...
Igor Skornyakov
09:57 AM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> This can be done of course if you believe that it makes sense to complicate the conversion/...
Constantin Asofiei
09:55 AM Feature #3814: more schema metadata
Constantin Asofiei wrote:
> What about the @_lock@ meta-table? Currently FWD enables this only if @_lock@ is explici...
Igor Skornyakov
09:32 AM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I totally agree with the idea to convert all system tables. After all, in 4GL they exist in...
Constantin Asofiei
09:22 AM Feature #3814: more schema metadata
Greg Shah wrote:
> At this point I see no reason to continue with the configuration at all. Why are we not just con...
Igor Skornyakov
09:07 AM Feature #3814: more schema metadata
> My idea was for the conversion rules to do some sanity checks: if you specified one or more table which is part of ... Greg Shah
09:05 AM Feature #3814: more schema metadata
We really only have one project where we made the effort to eliminate all metadata usage. That may not ever happen a... Greg Shah
09:03 AM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> The overhead with the creation/population of the "minimal" set of meta-tables is negligible...
Constantin Asofiei
08:58 AM Feature #3814: more schema metadata
Constantin Asofiei wrote:
> I'm not OK with this. Meta-tables should be optional. It adds overhead to other projec...
Igor Skornyakov
08:28 AM Feature #3814: more schema metadata
From an email discussion:
Constantin:
> BTW, leaving an empty metadata in p2j.cfg.xml works in FWD, so the meta t...
Constantin Asofiei

05/21/2020

06:02 PM Feature #4011: database/persistence layer performance improvements
My recent changes only involved the conversion. I do not have changes related to @DmoClass@. You can safely work in t... Ovidiu Maxiniuc
02:57 PM Feature #4011: database/persistence layer performance improvements
We are not generating implementations for some methods declared in DMO interfaces, such as indexed getters and setter... Eric Faulhaber

05/20/2020

07:00 AM Feature #3814: more schema metadata
Greg Shah wrote:
> I think 4231b is fine.
Committed to 4231b revision 11549. ...
Igor Skornyakov
06:35 AM Feature #3814: more schema metadata
I think 4231b is fine. Greg Shah

05/19/2020

04:19 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I've finished the population of the @_File@, @_Field@, @_Index@, and @_Index-Field@ system ...
Igor Skornyakov
02:58 PM Feature #4011: database/persistence layer performance improvements
I've just committed my latest changes to 4011 as r11437.
The most important thing here is the fix for the endless qu...
Ovidiu Maxiniuc
10:00 AM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > but in 4011 this is automatically done by DmoMetadataManager. The 4011 uses the new syntax supp...
Ovidiu Maxiniuc

05/18/2020

06:53 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> OTOH, the @ProgressiveResults@ have @sessionClosing()@ method which will duplicate the un...
Eric Faulhaber
06:27 PM Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > but in 4011 this is automatically done by DmoMetadataManager. The 4011 uses the new syntax supp...
Eric Faulhaber
06:04 PM Feature #4011: database/persistence layer performance improvements
> but in 4011 this is automatically done by DmoMetadataManager. The 4011 uses the new syntax supported by H2 (and PSQ... Greg Shah
05:49 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> [..] when a query is associated with a browse, apparently we need some special treatment, be...
Ovidiu Maxiniuc
04:00 PM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Separately, I committed rev 11436, which completes the fix to the server startup performance...
Ovidiu Maxiniuc
05:02 AM Feature #4011: database/persistence layer performance improvements
The @UniqueTracker@ empty scopes issue seems to be caused by the fact that we aren't registering the tracker for @Fin... Eric Faulhaber
05:44 PM Feature #3814: more schema metadata
I've finished the population of the @_File@, @_Field@, @_Index@, and @_Index-Field@ system tables base on DMO reflect... Igor Skornyakov
 

Also available in: Atom