Activity

From 05/29/2020 to 06/27/2020

06/27/2020

04:13 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Is index size a problem for temp-tables? I thought that was a SQLSer... Eric Faulhaber

06/26/2020

07:33 PM Feature #4011: database/persistence layer performance improvements: Greg Shah wrote:
> Is index size a problem for temp-tables? I thought that was a SQLServer thing.
4GL has its own ... Ovidiu Maxiniuc
07:27 PM Feature #4011: database/persistence layer performance improvements: Is index size a problem for temp-tables? I thought that was a SQLServer thing. Greg Shah
06:55 PM Feature #4011: database/persistence layer performance improvements: Note that in the cases where the DMO implementation classes are different, it is not just unique constraints that are... Eric Faulhaber
06:36 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > In @TemporaryBuffer.copyAllRows@, we can skip record validati... Constantin Asofiei
06:13 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> In @TemporaryBuffer.copyAllRows@, we can skip record validation if:
> [...]
>
> This... Eric Faulhaber

06/25/2020

04:10 PM Feature #3814: more schema metadata: Added _File-Trig and _Field-Trig population
Committing to 3821c revision 11366. ... Igor Skornyakov
12:51 PM Feature #4011: database/persistence layer performance improvements: Regarding the test at #4011-633 - I've created a physical database with the same table structure and indexes, and OE ... Constantin Asofiei
12:49 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I'm not sure what you are asking. Across different DMO implementation classes, two unique in... Constantin Asofiei
12:44 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> But, does anyone know if we have a way to check if the unique indexes in two DMO impl ma... Eric Faulhaber
09:55 AM Feature #4011: database/persistence layer performance improvements: For temp-tables, FWD has problems with this test:... Constantin Asofiei
09:10 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, an idea about the temp-table flushing. We currently save on every touched field. ... Constantin Asofiei
09:00 AM Feature #4011: database/persistence layer performance improvements: Eric, an idea about the temp-table flushing. We currently save on every touched field. But I think we can defer thi... Constantin Asofiei
06:36 AM Feature #4011: database/persistence layer performance improvements: In @TemporaryBuffer.copyAllRows@, we can skip record validation if:... Constantin Asofiei

06/24/2020

06:49 PM Feature #4011: database/persistence layer performance improvements: The NULLS LAST/FIRST fix is in 4011a rev 11499. Constantin Asofiei
05:50 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> I don't understand what is happening. The same SQL in the standalone H2 server knows to... Constantin Asofiei
03:29 PM Feature #4011: database/persistence layer performance improvements: I don't understand what is happening. The same SQL in the standalone H2 server knows to move the nulls to last posit... Constantin Asofiei
02:35 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Also, H2 is wrong with or without a DESC index for F2 - the NULL must be first.
To be m... Constantin Asofiei
02:33 PM Feature #4011: database/persistence layer performance improvements: Ovidiu, add an ASC index for F1 and you will see that H2 is wrong - it will place the NULL first.
Also, H2 is wron... Constantin Asofiei
02:32 PM Feature #4011: database/persistence layer performance improvements: ... Ovidiu Maxiniuc
02:28 PM Feature #4011: database/persistence layer performance improvements: What's the result for @select * from t1 order by f1 desc;@? Constantin Asofiei
02:27 PM Feature #4011: database/persistence layer performance improvements: I did a quick test with H2:... Ovidiu Maxiniuc
02:24 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> I have some tests, and OE sorts the nulls always last, regardless of direction.
Sorry, ... Constantin Asofiei
02:01 PM Feature #4011: database/persistence layer performance improvements: I have some tests, and OE sorts the nulls always last, regardless of direction.
H2 has a bug in that it doesn't co... Constantin Asofiei
01:16 PM Feature #4011: database/persistence layer performance improvements: Postgresql states that:
> By default, null values sort as if larger than any non-null value; that is, NULLS FIRST is... Constantin Asofiei
11:48 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Another issue is that the SUBSELECT doesn't have the @NULLS LAST@. At least we should b... Constantin Asofiei
11:42 AM Feature #4011: database/persistence layer performance improvements: There is a problem in 4011a, where we emit @NULLS LAST@ in the @ORDER BY@ clause. This causes a performance regressi... Constantin Asofiei
03:20 PM Feature #3814: more schema metadata: Finished with VIEW-AS field property conversion and population of the @_Field._View-As@.
Tested with a standalone te... Igor Skornyakov
08:55 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, the fix is in 3821c rev 11363.
> >
> > Please test ... Roger Borrello
08:40 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Constantin Asofiei wrote:
> Roger, the fix is in 3821c rev 11363.
>
> Please test with the customer scenario.
... Roger Borrello
07:10 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Roger, the fix is in 3821c rev 11363.
Please test with the customer scenario. Constantin Asofiei
05:58 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Eric Faulhaber wrote:
> I am attaching a patch because I didn't have a branch to which to commit. The attached patch... Constantin Asofiei
05:28 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Eric Faulhaber wrote:
> Constantin, please take it from here.
OK, I'm working on it.
Constantin Asofiei
01:33 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Roger Borrello wrote:
> That patch alleviated the NPE, and we now result in:
> * "Unable to PREPARE TEMP-TABLE bu... Eric Faulhaber
07:05 AM Support #3871: determine how to change codepages/locales during import: This task is not about the runtime environment. This is only about database import.
What matters is that we must ... Greg Shah
12:02 AM Support #3871: determine how to change codepages/locales during import: Analyzing the task history. The @FWD@ functionality from my understanding is to have tow separate parts, runtime envi... Eugenie Lyzenko

06/23/2020

07:54 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Eric Faulhaber wrote:
> Yes and no :-)
>
> I am attaching a patch because I didn't have a branch to which to comm... Roger Borrello
06:09 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Yes and no :-)
I am attaching a patch because I didn't have a branch to which to commit. The attached patch fixes ... Eric Faulhaber
06:04 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Eric Faulhaber wrote:
> Nevermind, got it.
Are you looking at this? Did you see the notes in #4208-736 ? Roger Borrello
04:55 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Nevermind, got it.... Eric Faulhaber
04:49 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Stack trace? Eric Faulhaber
04:01 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): Will there be different code-paths for a temp-table versus a standard table? I am walking through the testcase, tryin... Roger Borrello
01:17 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed): This code generates a @NPE@ on @trunk-11347@:... Roger Borrello
07:17 PM Feature #4011: database/persistence layer performance improvements: I committed revision 11496 to 4011a. It is mainly a FLQ support update:
* added support for DMOs in FROM clause of S... Ovidiu Maxiniuc
10:35 AM Feature #4011: database/persistence layer performance improvements: It is not clear to me why we match @PROPERTY@ in the lexer (as @DOT SYMBOL@). Since there are many possible qualifie... Greg Shah
10:22 AM Feature #4011: database/persistence layer performance improvements: Related to parsing of FQL: at this moment FQL2SQL is unable to parse queries like:
@from com.goldencode.appname.dmo.... Ovidiu Maxiniuc
06:06 AM Feature #4011: database/persistence layer performance improvements: I've committed revisions 11494 and 11495. 11494 is Ovidiu's import fix. 11495 partially fixes the test case in #4011-... Eric Faulhaber
05:38 PM Feature #3814: more schema metadata: After adding checks for @null@ to the @SymbolResolver@ I do not see warning anymore and there is a @KW_VIEW_AS@ note... Igor Skornyakov
05:12 PM Feature #3814: more schema metadata: > I do not see KW_VIEW_AS node in the .schema or .dict files. Maybe this is a result of NPE.
Yes, possibly so. Greg Shah
05:04 PM Feature #3814: more schema metadata: Greg Shah wrote:
> > however, there is no KW_VIEW_AS node in the AST at all
>
> The @replaceAst()@ rewrites that ... Igor Skornyakov
04:46 PM Feature #3814: more schema metadata: > however, there is no KW_VIEW_AS node in the AST at all
The @replaceAst()@ rewrites that @KW_VIEW_AS@ subtree, th... Greg Shah
04:42 PM Feature #3814: more schema metadata: Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg, do you think is safe to set @dict=true@ at the @SymbolResolv... Igor Skornyakov
04:37 PM Feature #3814: more schema metadata: Constantin Asofiei wrote:
> Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created b... Greg Shah
04:10 PM Feature #3814: more schema metadata: Constantin Asofiei wrote:
> Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created b... Igor Skornyakov
03:39 PM Feature #3814: more schema metadata: Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created by @SchemaLoader.postProcessIm... Constantin Asofiei
03:36 PM Feature #3814: more schema metadata: Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > This is exactly what I did. It seems that not callers are re... Igor Skornyakov
03:24 PM Feature #3814: more schema metadata: Igor Skornyakov wrote:
> This is exactly what I did. It seems that not callers are ready for @null@. But I will try ... Constantin Asofiei
03:19 PM Feature #3814: more schema metadata: Constantin Asofiei wrote:
> > I've tried this. It doesn't help, NPE happens in @SymbolResolver.addWrappedWorker@
> ... Igor Skornyakov
03:15 PM Feature #3814: more schema metadata: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > I think is enough to add a NPE check there for @currentCls@.... Constantin Asofiei
03:13 PM Feature #3814: more schema metadata: Constantin Asofiei wrote:
> I think is enough to add a NPE check there for @currentCls@. During schema parser, ther... Igor Skornyakov
03:08 PM Feature #3814: more schema metadata: Igor Skornyakov wrote:
> The conversion of the .df files produces a number of warnings like this:
> [...]
> This h... Constantin Asofiei
02:59 PM Feature #3814: more schema metadata: The conversion of the .df files produces a number of warnings like this:... Igor Skornyakov
08:01 AM Support #3871 (WIP): determine how to change codepages/locales during import: Sergey Ivanovskiy wrote:
> I used the similar diff to the following one in order to setup the UTF-8 database with IN... Greg Shah

06/22/2020

06:12 PM Feature #4011: database/persistence layer performance improvements: Some notes about @fql.g@ from my quick review:
* The overall structure looks ... familiar. :) This is not a compl... Greg Shah
02:28 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> There are issues in 4011a with the batch deletes:
> * the composite tables need to be d... Constantin Asofiei
10:00 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> A variation of #4011-549 with the validation:
> [...]
>
> The @CAN-FIND@ sees this r... Eric Faulhaber
01:42 PM Feature #4692: add sanity check at server startup to compare DMO indices with database indices: Good point. We should add a comparison of legacy "mandatory" fields with database columns marked "not null" as part o... Eric Faulhaber
12:48 PM Feature #4692: add sanity check at server startup to compare DMO indices with database indices: Additional indices are OK as they could improve performance (if we spot some series of queries that frequently use a ... Ovidiu Maxiniuc
12:38 PM Feature #4692: add sanity check at server startup to compare DMO indices with database indices: Branch 4011a eliminates the collection of index metadata from the database at startup to populate @IndexHelper@ data ... Eric Faulhaber
12:27 PM Feature #4692 (New): add sanity check at server startup to compare DMO indices with database indices: Eric Faulhaber
01:37 PM Support #4693: check whether our index consolidation adversely affects flushing behavior: During schema conversion, we do some consolidation of the original 4GL indices to eliminate redundant indices. I am w... Eric Faulhaber
01:28 PM Support #4693 (New): check whether our index consolidation adversely affects flushing behavior: Eric Faulhaber
11:24 AM Feature #3814: more schema metadata: Finished re-working metadata configuration in p2j.cfg.xml.
Now, if there is no <metadata> section on the @p2j.cfg.xm... Igor Skornyakov

06/21/2020

06:51 PM Feature #3814: more schema metadata: Yes, I think that is fine. Greg Shah
10:54 AM Feature #3814: more schema metadata: Do we really need to support @p2j.cf.xml@ w/o a <metadata> section? It requires a lot of changes as in many places it... Igor Skornyakov
05:09 AM Feature #3814: more schema metadata: Backport of the @SEQUENCE@ support from 4011a and population of the @_Sequence@ table committed to 3821c rev. 11351. Igor Skornyakov

06/20/2020

01:34 PM Feature #3814: more schema metadata: Greg Shah wrote:
> 3821c not b
OK, thank you. Igor Skornyakov
01:33 PM Feature #3814: more schema metadata: 3821c not b Greg Shah
01:32 PM Feature #3814: more schema metadata: Greg Shah wrote:
> Hynek will open 3821b shortly.
Got it. Thanks! Igor Skornyakov
01:23 PM Feature #3814: more schema metadata: Hynek will open 3821b shortly. Greg Shah
12:45 PM Feature #3814: more schema metadata: Greg, which branch should I use for #3814 now?
Thank you. Igor Skornyakov
12:00 PM Feature #3814: more schema metadata: Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:10 PM Bug #4492: database trigger defined with abbreviation should create a new buffer: Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:01 PM Bug #3471: incremental conversion is regressed: Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:57 AM Feature #4397: add database attrs, methods and options: Task branch 4231b has been merged to trunk as revision 11347.
Is there anything left to do in this task? Greg Shah
11:57 AM Feature #3813: misc DB features part deux: Task branch 4231b has been merged to trunk as revision 11347.
> Considering that the WHERE clause work has been mo... Greg Shah
11:56 AM Feature #4375 (Closed): add support for -pf <profile_filename> option for CONNECT statement: Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

06/19/2020

05:13 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> The old @cumulativeDirtyProps@ was stored in @ValidationHelper@ and contained the entire se... Eric Faulhaber
04:49 PM Feature #4011: database/persistence layer performance improvements: The old @cumulativeDirtyProps@ was stored in @ValidationHelper@ and contained the entire set of changes at the last (... Ovidiu Maxiniuc
04:37 PM Feature #4011: database/persistence layer performance improvements: Ovidiu, regarding 4011a/11486: @RecordBuffer.cumulativeDirtyProps@ is never modified, only instantiated and used as a... Eric Faulhaber
04:09 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > the composite tables need to be deleted manually (or is t... Ovidiu Maxiniuc
04:05 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> the composite tables need to be deleted manually (or is the foreign key 'on cascade de... Eric Faulhaber
03:18 PM Feature #4011: database/persistence layer performance improvements: There are issues in 4011a with the batch deletes:
* the composite tables need to be deleted manually (or is the fore... Constantin Asofiei
02:17 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> The only issue I have is that @boolean doFlush = !rollback || hasUniqueConstraint;@ wi... Eric Faulhaber
02:01 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin, would you please carefully review the change? It did go through some regression ... Constantin Asofiei
01:40 PM Feature #4011: database/persistence layer performance improvements: Committed rev 11487, which:
* bypasses database-level unique constraint validation when the backing table has no u... Eric Faulhaber
07:52 AM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> some indexes keep their @unique@ attribute. I remember that we were intentionally doing s... Eric Faulhaber
08:05 PM Feature #4011: database/persistence layer performance improvements: Eric,
As I informed by email, I noticed some differences in the generated indexes for our test framework. There are ... Ovidiu Maxiniuc
06:08 AM Feature #3814: more schema metadata: Status summary update (see #3814-100)
# Added @_Sequence@ table population based on the new @SEQUENCE@ support (back... Igor Skornyakov

06/18/2020

07:34 PM Feature #4011: database/persistence layer performance improvements: As part of cleaning up the branch, we should get rid of these ANTLR warnings:... Eric Faulhaber
01:30 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> This is a different issue than that which is addressed by the use of the @ParameterIndices@ ... Constantin Asofiei
01:04 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > For a WHERE clause which has subscripted fields like @tt1... Eric Faulhaber
09:25 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> For a WHERE clause which has subscripted fields like @tt1.f1[?]@, I need to inject the @... Constantin Asofiei
08:34 AM Feature #4011: database/persistence layer performance improvements: For a WHERE clause which has subscripted fields like @tt1.f1[?]@, I need to inject the @tt1__10.list__index = ?@ at t... Constantin Asofiei
04:52 PM Feature #4690: re-integrate dirty share logic into new persistence implementation: Ovidiu Maxiniuc wrote:
> The choice to use a @null@ context is due the performance. This might not be the most ele... Eric Faulhaber
03:55 PM Feature #4690: re-integrate dirty share logic into new persistence implementation: Eric Faulhaber wrote:
> I'm reading through the changes, and this is not a full review yet, but I have some general ... Ovidiu Maxiniuc
02:28 PM Feature #4690: re-integrate dirty share logic into new persistence implementation: I'm reading through the changes, and this is not a full review yet, but I have some general questions about the 4011a... Eric Faulhaber
02:20 PM Feature #4690: re-integrate dirty share logic into new persistence implementation: Some new requirements have arisen for the dirty share feature set. Although we would like to eliminate this feature a... Eric Faulhaber
01:54 PM Feature #4690: re-integrate dirty share logic into new persistence implementation: Opening a separate issue for this, as it is a substantial topic on its own...
4011a_dirty is the branch in use for... Eric Faulhaber
01:53 PM Feature #4690 (WIP): re-integrate dirty share logic into new persistence implementation: Eric Faulhaber

06/17/2020

02:12 PM Feature #3814: more schema metadata: Greg Shah wrote:
> OK, please commit the change to 4231b.
Committed revision 11609. Igor Skornyakov
02:05 PM Feature #3814: more schema metadata: OK, please commit the change to 4231b. Greg Shah
01:58 PM Feature #3814: more schema metadata: Some additional fixes were made to run hotel apps w/o @p2j.cf.xml@. See attachment. Igor Skornyakov
12:33 PM Feature #3814: more schema metadata: Igor Skornyakov wrote:
> Greg Shah wrote:
> > The change looks good. Please test it with Hotel GUI and Hotel ChUI.... Greg Shah
12:32 PM Feature #3814: more schema metadata: Greg Shah wrote:
> The change looks good. Please test it with Hotel GUI and Hotel ChUI.
Both apps started OK. Pl... Igor Skornyakov
12:11 PM Feature #3814: more schema metadata: The change looks good. Please test it with Hotel GUI and Hotel ChUI. Greg Shah
12:04 PM Feature #3814: more schema metadata: Greg Shah wrote:
> Why did you remove the @throw@ in the @catch()@ block of @Configuration.createConfiguration()@? ... Igor Skornyakov
11:55 AM Feature #3814: more schema metadata: Why did you remove the @throw@ in the @catch()@ block of @Configuration.createConfiguration()@? This means that the ... Greg Shah
11:48 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Code Review cfg.diff
>
> Please remove the new imports in @Configuration@ and also remove the ... Igor Skornyakov
11:41 AM Feature #3814: more schema metadata: Code Review cfg.diff
Please remove the new imports in @Configuration@ and also remove the change for the @catch()@... Greg Shah
11:11 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Code Review cfg.diff
>
> 1. At this time, it is intentional that we do not use logging in @Con... Igor Skornyakov
10:17 AM Feature #3814: more schema metadata: Code Review cfg.diff
1. At this time, it is intentional that we do not use logging in @Configuration@. It is used... Greg Shah
09:02 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Please post the change here in patch format so I can review it. If OK, you will check it in to 4... Igor Skornyakov
08:06 AM Feature #3814: more schema metadata: Please post the change here in patch format so I can review it. If OK, you will check it in to 4231b since this is m... Greg Shah
07:54 AM Feature #3814: more schema metadata: Greg Shah wrote:
> A safe default configuration (which has nothing enabled) should be present if the file is not ava... Igor Skornyakov
07:02 AM Feature #3814: more schema metadata: A safe default configuration (which has nothing enabled) should be present if the file is not available. No abends. Greg Shah
06:57 AM Feature #3814: more schema metadata: I've fixed the situation when there is no <metadata> section on the @p2j.cfg.xml@. However it seems that the applicat... Igor Skornyakov
05:55 AM Feature #3814: more schema metadata: Please make both cases safe. Greg Shah
02:55 AM Feature #3814: more schema metadata: Greg Shah wrote:
> I'm using the ChUI regression test suite. I found that with 4231b, it is now required to have a ... Igor Skornyakov

06/16/2020

07:00 PM Feature #3814: more schema metadata: I'm using the ChUI regression test suite. I found that with 4231b, it is now required to have a @cfg/p2j.cfg.xml@ bu... Greg Shah
04:58 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > A variation of #4011-549 with the validation:
> > [...]
> >... Constantin Asofiei
04:42 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> A variation of #4011-549 with the validation:
> [...]
>
> The @CAN-FIND@ sees this r... Eric Faulhaber
11:11 AM Feature #4011: database/persistence layer performance improvements: Greg Shah wrote:
> > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to c... Constantin Asofiei
10:52 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I've been considering divorcing the cache from the session object to get more advantage from... Constantin Asofiei
08:05 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've seen cases where we have a select like @select tt1.*... Eric Faulhaber
06:54 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> I've seen cases where we have a select like @select tt1.*, tt2.recid@ where @tt2@ is a s... Constantin Asofiei
06:28 AM Feature #4011: database/persistence layer performance improvements: I've seen cases where we have a select like @select tt1.*, tt2.recid@ where @tt2@ is a standalone table or a composit... Constantin Asofiei
06:07 AM Feature #4011: database/persistence layer performance improvements: I've committed revision 11481, which minimizes the number of database savepoints being set for application sub-transa... Eric Faulhaber
12:43 AM Feature #4011: database/persistence layer performance improvements: Greg Shah wrote:
> > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to c... Eric Faulhaber
11:11 PM Feature #4011: database/persistence layer performance improvements: > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to check if I'm missing ... Greg Shah
09:42 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> 4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. ... Eric Faulhaber
04:36 PM Feature #4681: prepared statement caching/pooling: I think we can simplify this idea a bit. I don't see the value in making a static cache. A @PreparedStatement@ instan... Eric Faulhaber
01:39 PM Feature #4681: prepared statement caching/pooling: My concern is related to multiple session close (they have a short life), which will invalidate the cached statements... Ovidiu Maxiniuc
12:58 PM Feature #4681: prepared statement caching/pooling: This issue is to discuss the implementation of @PreparedStatement@ caching/pooling as a potential performance optimiz... Eric Faulhaber
12:56 PM Feature #4681 (WIP): prepared statement caching/pooling: Eric Faulhaber

06/15/2020

07:23 PM Feature #4011: database/persistence layer performance improvements: 4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. FQL2SQL will take care of cr... Constantin Asofiei
07:11 PM Feature #4011: database/persistence layer performance improvements: 4011a rev 11479 adds the @AnnotatedAst.iterator()@ fix (#4011-574) and refactors rowStructure to allow for self-join. Constantin Asofiei
09:49 AM Feature #4011: database/persistence layer performance improvements: A variation of #4011-549 with the validation:... Constantin Asofiei
05:51 AM Feature #4011: database/persistence layer performance improvements: 4011a rev 11475 fixes ChangeSet.ensureCapacity. Constantin Asofiei

06/14/2020

10:25 AM Feature #4011: database/persistence layer performance improvements: > BTW, in FWD (both 4011 and trunk) only the RAQ will consult the dirty database for possible leaking record. The 4GL... Greg Shah

06/13/2020

05:53 PM Feature #4011: database/persistence layer performance improvements: > There's nowhere to descend, nor another sibling. When iter.hasNext() is called after the BOOL_TRUE was processed, i... Greg Shah

06/12/2020

07:03 PM Feature #4011: database/persistence layer performance improvements: Yes, if we can evaluate static sub-expressions during conversion, we roll them up to their result and replace the sub... Eric Faulhaber
07:00 PM Feature #4011: database/persistence layer performance improvements: Is it possible that the WHERE node was dropped in this case? Ovidiu Maxiniuc
06:57 PM Feature #4011: database/persistence layer performance improvements: AFAIK, we didn't change this in 4011a. I wonder why we are hitting this now. Eric Faulhaber
06:42 PM Feature #4011: database/persistence layer performance improvements: There's a bug in @AnnotatedAst.iterator@ when trying to iterate starting from the @BOOL_TRUE@ child (of the @WHERE@ c... Constantin Asofiei
06:20 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The not closed objects are most likely the reason for the me... Constantin Asofiei
05:37 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready.
See... Constantin Asofiei
05:25 PM Feature #4011: database/persistence layer performance improvements: Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready. Eric Faulhaber
05:17 PM Feature #4011: database/persistence layer performance improvements: This was inspired by what I saw Hibernate was generating. The most signifiant 32 bit came naturally and will match th... Ovidiu Maxiniuc
05:02 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Or better yet, why use a hashcode for the FK? Just as a convention? This name needs to... Eric Faulhaber
05:01 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> There's something wrong in TempTableHelper when the constraint name is computed:
> [...... Constantin Asofiei
04:45 PM Feature #4011: database/persistence layer performance improvements: There's something wrong in TempTableHelper when the constraint name is computed:... Constantin Asofiei
03:57 PM Feature #4011: database/persistence layer performance improvements: OK, I think this is what Hibernate did as well. We may come back to @PreparedStatement@ caching as a potential optimi... Eric Faulhaber
03:49 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS... Ovidiu Maxiniuc
03:47 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS... Constantin Asofiei
03:43 PM Feature #4011: database/persistence layer performance improvements: I think we know when we are done with the statement in all cases, but do we cache @PreparedStatement@ instances to pr... Eric Faulhaber
03:42 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> The not closed objects are most likely the reason for the memory issues. I tried to close s... Constantin Asofiei
03:20 PM Feature #4011: database/persistence layer performance improvements: The not closed objects are most likely the reason for the memory issues. I tried to close some of them but it was rea... Ovidiu Maxiniuc
03:18 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> How were we handling cleanup of the Hibernate query resources?
I think Hibernate was taking... Constantin Asofiei
03:09 PM Feature #4011: database/persistence layer performance improvements: @AbstractQuery@ has a @cleanup@ method, however, the use of @SQLQuery@ and even @Query@ is somewhat internal/hidden w... Eric Faulhaber
03:04 PM Feature #4011: database/persistence layer performance improvements: Another issue which I don't understand: the @SQLQuery@'s JDBC statement and ResultSet is never closed. Why? Who shou... Constantin Asofiei
03:02 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've moved to another test as the current one is blocked ... Constantin Asofiei
09:05 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> I've moved to another test as the current one is blocked with the flush/mandatory issue.... Constantin Asofiei
08:25 AM Feature #4011: database/persistence layer performance improvements: I've moved to another test as the current one is blocked with the flush/mandatory issue. Now I've reached an extent ... Constantin Asofiei
08:13 PM Feature #4011: database/persistence layer performance improvements: Not exactly. I will add it, thanks. Eric Faulhaber

06/11/2020

07:57 PM Feature #4011: database/persistence layer performance improvements: Eric, do you have this case in your current flush/validation work?... Constantin Asofiei
06:37 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you e... Eric Faulhaber
06:06 PM Feature #4011: database/persistence layer performance improvements: Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you end up with two records like ... Constantin Asofiei
04:56 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE ... Constantin Asofiei
03:39 PM Feature #4011: database/persistence layer performance improvements: A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE and there is the same behavio... Constantin Asofiei
03:22 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Ovidiu, what's the difference between @FqlType.DECIMAL@ and @FqlType.DOUBLE@? How are th... Ovidiu Maxiniuc
03:07 PM Feature #4011: database/persistence layer performance improvements: 11467 contains the ScrollingResults fix, rollback of SqlQuery RSMD usage and another fix in FqlType. Constantin Asofiei
03:06 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Should I call @Persistence$Context.useSession@ for @Scrol... Eric Faulhaber
02:58 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Should I call @Persistence$Context.useSession@ for @ScrollingResults@, too? I see that w... Constantin Asofiei
02:48 PM Feature #4011: database/persistence layer performance improvements: I've got an infinite loop because this code:... Constantin Asofiei
12:28 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > That code already has a call for RSMD, @int columnCount =... Constantin Asofiei
12:26 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> That code already has a call for RSMD, @int columnCount = resultSet.getMetaData().getC... Eric Faulhaber
12:14 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The foreign table is mapped by @MetaFile.class@ and by defau... Constantin Asofiei
12:03 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin, we have biased as much as we can in this implementation toward speed, so we are ... Constantin Asofiei
11:45 AM Feature #4011: database/persistence layer performance improvements: Constantin, we have biased as much as we can in this implementation toward speed, so we are avoiding things like @Res... Eric Faulhaber
10:33 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> The problem is the previous code assumed the SELECT was always retrieving full records. ... Ovidiu Maxiniuc
10:24 AM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > 4011a rev 11465 contains my FQL fixes plus misc. Please rev... Constantin Asofiei
09:38 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> 4011a rev 11465 contains my FQL fixes plus misc. Please review.
I have only a questi... Ovidiu Maxiniuc

06/10/2020

06:23 PM Feature #4011: database/persistence layer performance improvements: 4011a rev 11465 contains my FQL fixes plus misc. Please review. Constantin Asofiei
06:17 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> The foreign table is mapped by @MetaFile.class@ and by default the 'foreign' field is also ... Constantin Asofiei
01:53 PM Feature #4011: database/persistence layer performance improvements: Lots of regression after changing it... so no good. Constantin Asofiei
01:49 PM Feature #4011: database/persistence layer performance improvements: There is a problem at the fql.g parser:... Constantin Asofiei
01:43 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Found a broken feature I forgot about in 4011: sequences, see #3814-109.
> We need to add ... Ovidiu Maxiniuc
12:05 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Replacing Record with Persistable fixes the above.
> I am n... Constantin Asofiei
11:59 AM Feature #4011: database/persistence layer performance improvements: Constantin,
After running conversion with a newer metadata definition I have this:... Ovidiu Maxiniuc
11:16 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Ovidiu, I have a problem with the relation generated between the Field and File meta tab... Ovidiu Maxiniuc
10:48 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Replacing Record with Persistable fixes the above.
I am not sure is not correct. Which ... Ovidiu Maxiniuc
09:17 AM Feature #4011: database/persistence layer performance improvements: Replacing Record with Persistable fixes the above. Constantin Asofiei
09:02 AM Feature #4011: database/persistence layer performance improvements: I've fixed that manually (BTW, @name="id"@ should be @name="recid"@, depending on what you configured as the PK in p2... Constantin Asofiei
08:51 AM Feature #4011: database/persistence layer performance improvements: Ovidiu, I have a problem with the relation generated between the Field and File meta tables. In DMO index, I have th... Constantin Asofiei
08:37 AM Feature #4011: database/persistence layer performance improvements: 11463 fixes the FqlType issue in #4011-517. But I think we need complete support for FqlType enum. Constantin Asofiei
07:53 AM Feature #4011: database/persistence layer performance improvements: Ovidiu, I need a mapping between FQLType enum values and java.sql.Types. Can you provide a complete list? Constantin Asofiei
06:05 AM Feature #4011: database/persistence layer performance improvements: Rev 11462 fixes @TB.readAllRows@. It also has some validation, flush, rollback fixes that are work in process. They d... Eric Faulhaber
05:33 PM Feature #4155 (WIP): remove conversion dependency on metadata .df file: Our ultimate objective with schema metadata is to eliminate the conversion of these DMOs and instead rely upon metada... Greg Shah
10:21 AM Feature #3814: more schema metadata: Greg Shah wrote:
> As you check in updates for this task, the @rules/gaps/database.rules@ (@addMetaschema@ section) ... Igor Skornyakov
10:19 AM Feature #3814: more schema metadata: As you check in updates for this task, the @rules/gaps/database.rules@ (@addMetaschema@ section) needs to be updated ... Greg Shah

06/09/2020

07:13 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> There is this code in @TemporaryBuffer.readAllRows@:
> [...]
>
> I would expect @res... Constantin Asofiei
07:01 PM Feature #4011: database/persistence layer performance improvements: There is this code in @TemporaryBuffer.readAllRows@:... Constantin Asofiei
03:32 PM Feature #4011: database/persistence layer performance improvements: Actually, the code above will not work for PostgreSQL as the @getComputedColumnFormula@ will return @null@. It looks ... Ovidiu Maxiniuc
03:19 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > That is interesting. It looks like I added a regression when... Ovidiu Maxiniuc
03:14 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> That is interesting. It looks like I added a regression when constructing validation messag... Constantin Asofiei
03:12 PM Feature #4011: database/persistence layer performance improvements: That is interesting. It looks like I added a regression when constructing validation message in my recent commit. Ple... Ovidiu Maxiniuc
02:59 PM Feature #4011: database/persistence layer performance improvements: Ovidiu, one more - I don't understand where the "__i?" is coming from.... Constantin Asofiei
02:44 PM Feature #4011: database/persistence layer performance improvements: If the query already has fetched the full records, we already would have used the session cache to gain this optimiza... Eric Faulhaber
02:37 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Constantin,
> I think the change you refer to was mine. The idea was to fetch the exact am... Constantin Asofiei
02:36 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> This part in @metaschema.xml@ is wrong:
> [...]
> We need to use the primary key as s... Ovidiu Maxiniuc
02:30 PM Feature #4011: database/persistence layer performance improvements: Constantin,
I think the change you refer to in #4011-504 was mine. The idea was to fetch the exact amount of informa... Ovidiu Maxiniuc
02:21 PM Feature #4011: database/persistence layer performance improvements: This part in @metaschema.xml@ is wrong:... Constantin Asofiei
01:31 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, what part is wrong here? The @Presorter$SortedResults@ which expects full records,... Constantin Asofiei
01:12 PM Feature #4011: database/persistence layer performance improvements: Found a broken feature I forgot about in 4011: sequences, see #3814-109.
We need to add back initialization support ... Ovidiu Maxiniuc
10:02 AM Feature #4011: database/persistence layer performance improvements: If you enable enhanced browse, and click the 'checkin' column in the Guests grid, you get a @ClassCastException@:
<p... Constantin Asofiei
09:46 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Attached are my changes in process for the rollback fix. It is not working yet, but I am pos... Constantin Asofiei
08:22 AM Feature #4011: database/persistence layer performance improvements: Attached are my changes in process for the rollback fix. It is not working yet, but I am posting because I need to ta... Eric Faulhaber
07:06 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > The reason I ask is that I noticed in the debugger that the... Eric Faulhaber
07:01 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I guess all the changes for @LazyUndoable@ are just an optimization, but the core idea is st... Constantin Asofiei
06:55 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Now my problem is that @LightweightUndoable@ is nothing like I remember it. I guess all th... Eric Faulhaber
06:46 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> OK, so the record doesn't need to remain in the database, as the flush is rolledback, ... Eric Faulhaber
06:38 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I don't understand this patch. I mean, I get the logic, but it doesn't look right to me conc... Constantin Asofiei
06:32 AM Feature #4011: database/persistence layer performance improvements: I don't understand this patch. I mean, I get the logic, but it doesn't look right to me conceptually. The point of ma... Eric Faulhaber
06:14 AM Feature #4011: database/persistence layer performance improvements: Eric, attached patch fixes this testcases:... Constantin Asofiei
05:47 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Going back to this: I've tried saving the record in the database, in @ChangeSet.rollba... Eric Faulhaber
02:33 PM Feature #3814: more schema metadata: Greg Shah wrote:
> My worry here is that you are creating new things that will be hard to merge with 4011a. We plan... Igor Skornyakov
02:16 PM Feature #3814: more schema metadata: My worry here is that you are creating new things that will be hard to merge with 4011a. We plan to do that merge ve... Greg Shah
01:29 PM Feature #3814: more schema metadata: Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
> Yes, the @DMOIndex@ c... Igor Skornyakov
01:07 PM Feature #3814: more schema metadata: Greg Shah wrote:
> Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
Yes, the @DMOIndex@ class is already gone in 4011a.... Ovidiu Maxiniuc
12:24 PM Feature #3814: more schema metadata: Greg Shah wrote:
> Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
I already use @DMOIndex@ in the @MetadataManager@... Igor Skornyakov
12:12 PM Feature #3814: more schema metadata: Ovidiu: Doesn't @DMOIndex@ go away in 4011a? Greg Shah
12:04 PM Feature #3814: more schema metadata: Ovidiu Maxiniuc wrote:
> Of course, please see the last lines in @ddl/schema_table_<db-name>_<sql-dialect>.sql@. Aft... Igor Skornyakov
11:23 AM Feature #3814: more schema metadata: Of course, please see the last lines in @ddl/schema_table_<db-name>_<sql-dialect>.sql@. After a successuful conversio... Ovidiu Maxiniuc
04:27 AM Feature #3814: more schema metadata: Do we generate any artifacts for @SEQUENCE@? I cannot find any. The corresponding AST exists. Please advise.
Thank you. Igor Skornyakov

06/08/2020

02:12 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Eric Faulhaber wrote:
> > > Constantin, at this level in... Constantin Asofiei
02:00 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I didn't think so. We should be fetching it from the database... Constantin Asofiei
01:54 PM Feature #4011: database/persistence layer performance improvements: Constantin,
in FWD runtime the primary key name is read from @persistence/primary-key-name@ and stored globally in @... Ovidiu Maxiniuc
01:36 PM Feature #4011: database/persistence layer performance improvements: Eric, in #4011-303, you note that in @p2j.cfg.xml@ you used this:... Constantin Asofiei
11:13 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin, at this level in the code, we are not dealing wit... Constantin Asofiei
11:04 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin, at this level in the code, we are not dealing with BDT instances.
You are corr... Constantin Asofiei
11:00 AM Feature #4011: database/persistence layer performance improvements: Constantin, at this level in the code, we are not dealing with BDT instances. These are the lower level Java types wh... Eric Faulhaber
10:51 AM Feature #4011: database/persistence layer performance improvements: This fix solves all deadlocks related to locking (even those which exist in trunk), in @BaseRecord.setDatum@:... Constantin Asofiei
10:17 AM Feature #4011: database/persistence layer performance improvements: There is a deadlock when updating a Rate or a Guest by multiple clients, but this is an application logic problem.
... Constantin Asofiei
08:57 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I didn't think so. We should be fetching it from the database on next access.
The problem ... Constantin Asofiei
08:46 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> The abend in Reservations/Check-in/Delete Guest/Cancel Check-in is related to this test:... Eric Faulhaber
08:41 AM Feature #4011: database/persistence layer performance improvements: The abend in Reservations/Check-in/Delete Guest/Cancel Check-in is related to this test:... Constantin Asofiei
07:52 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin, please commit your change to always use @NopDirtyShareContext@, with a TODO to r... Constantin Asofiei
07:04 AM Feature #4011: database/persistence layer performance improvements: Rev 11455 fixes an NPE and some validation logic. Eric Faulhaber
06:56 AM Feature #4011: database/persistence layer performance improvements: Constantin, please commit your change to always use @NopDirtyShareContext@, with a TODO to re-enable it when the re-i... Eric Faulhaber
06:48 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> So, the dirty share database should be used only for explicitly-configured tables/data... Eric Faulhaber
06:04 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> After another full @ant deploy.all@, this time with the data from Hotel GUI rev 212, I now g... Constantin Asofiei
05:57 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> And another issue with the dirty database - previously there were @Reversible@ instances... Constantin Asofiei
05:51 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Please coordinate with Ovidiu on this; he is actively making changes in this area. The dirty... Constantin Asofiei
05:46 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > BTW, also found these in the server log from the same work fl... Eric Faulhaber
05:20 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> BTW, also found these in the server log from the same work flow:
>
> [...]
The root caus... Constantin Asofiei
05:04 AM Feature #4011: database/persistence layer performance improvements: OK, I'll check with H2, too.
BTW, I still see the NPE for the 'delete guest' and 'Cancel', in the Reservations, C... Constantin Asofiei
05:00 AM Feature #4011: database/persistence layer performance improvements: BTW, also found these in the server log from the same work flow:... Eric Faulhaber
04:59 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I am using the default H2 database in my testing. I'll try with PostgreSQL.
Indeed, the... Eric Faulhaber
04:42 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> 11454 does not compile for me:
> [...]
>
> I've bypassed this and I don't get your e... Eric Faulhaber
04:35 AM Feature #4011: database/persistence layer performance improvements: 11454 does not compile for me:... Constantin Asofiei
04:24 AM Feature #4011: database/persistence layer performance improvements: After another full @ant deploy.all@, this time with the data from Hotel GUI rev 212, I now get the following error wi... Eric Faulhaber
04:00 AM Feature #4011: database/persistence layer performance improvements: On a completely fresh run of Hotel GUI, first thing after running @ant deploy.all@ and server startup, I get some err... Eric Faulhaber
08:50 AM Feature #3814: more schema metadata: > Regarding the undocumented fields of the _Field table, I think that it can be sufficient to set them to a "typical"... Greg Shah
08:30 AM Feature #3814: more schema metadata: Greg Shah wrote:
> > This means that the _File._ianum is almost useless and has not any meaningful counterpart in FW... Igor Skornyakov
08:01 AM Feature #3814: more schema metadata: > This means that the _File._ianum is almost useless and has not any meaningful counterpart in FWD. I understand the ... Greg Shah
07:38 AM Feature #3813: misc DB features part deux: Considering that the WHERE clause work has been moved to #4613, is there any reason to keep this task open? Greg Shah

06/05/2020

07:12 PM Feature #4011: database/persistence layer performance improvements: Unfortunately, I don't have the dirty share fully done yet.
To let my brain cool down I returned and fixed the uniqu... Ovidiu Maxiniuc
05:57 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Virtual desktop and embedded mode get through this flow fine,... Eric Faulhaber
05:42 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > The only issue I'm aware in Hotel GUI is the NPE related to C... Constantin Asofiei
05:41 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Virtual desktop and embedded mode get through this flow fine, so it may be a client problem ... Constantin Asofiei
05:36 PM Feature #4011: database/persistence layer performance improvements: Another issue I hit was in Swing only:
* log in
* from "Available Rooms", click "Check-In..."
* delete guest
* ... Eric Faulhaber
05:32 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, afte... Eric Faulhaber
05:15 PM Feature #4011: database/persistence layer performance improvements: The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, after deleting the guest. Constantin Asofiei
05:13 PM Feature #4011: database/persistence layer performance improvements: This code in @RecordBuffer.delete@ doesn't set the @token@:... Constantin Asofiei
04:56 PM Feature #4011: database/persistence layer performance improvements: The deadlock described in #4011-385 can be duplicated like this in 11452:
* delete a room
* close and start another... Constantin Asofiei
02:56 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> My changes to fix the #4011-385, the @deleteAll@ problem because there was no notificati... Constantin Asofiei
05:35 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion... Constantin Asofiei
05:17 AM Feature #4011: database/persistence layer performance improvements: Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion from scratch and try it ... Eric Faulhaber
05:07 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, the issue in #4011-412 is not solved by your changes.
... Constantin Asofiei
04:57 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is not solved by your changes.
Constantin, I don't get a... Eric Faulhaber
04:38 PM Feature #3814: more schema metadata: # restored @_database-feature@ support previously implemented by Ovidiu
# added the following @_file@ fields:... Igor Skornyakov

06/04/2020

05:20 PM Feature #3814: more schema metadata: Added conversion support for the @_Field.CAN-*@ fields and population of @CAN_*@ and @*-SA@ fields for @_File@/@_Fiel... Igor Skornyakov
04:08 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> In case of abends, I think FWD should release all locks, right?
Yes, it should. The... Eric Faulhaber
01:03 PM Feature #4011: database/persistence layer performance improvements: My changes to fix the #4011-385, the @deleteAll@ problem because there was no notification of a newly created record ... Constantin Asofiei
12:39 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> If you know of any other issues in Hotel GUI which you suspect are related to this root caus... Constantin Asofiei
08:30 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is no solved by your changes.
OK, thanks for testing. Th... Eric Faulhaber
08:22 AM Feature #4011: database/persistence layer performance improvements: Eric, the issue in #4011-412 is not solved by your changes. Constantin Asofiei
07:21 AM Feature #4011: database/persistence layer performance improvements: I've committed rev 11450, which reworks the UNDO of DMOs to be primarily in memory on the FWD server, with less relia... Eric Faulhaber

06/03/2020

06:35 PM Feature #4011: database/persistence layer performance improvements: More details:
At this moment the unique-indexes are validated on SQL-tier, the result in case of failure being a dia... Ovidiu Maxiniuc
05:26 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Please disable the new query-based validation check for now, but then get back to integratin... Ovidiu Maxiniuc
09:31 AM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> unique index validation: primarily a no 1 implementation (see entry 127), but also slight... Eric Faulhaber

06/02/2020

05:34 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Even if this particular issue is related to a regression in batch assign mode, I think the o... Constantin Asofiei
05:34 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Eric Faulhaber wrote:
> >
> > > We probably need to centra... Eric Faulhaber
04:36 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > We probably need to centralize the validation/flushing/notifi... Constantin Asofiei
04:24 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> We probably need to centralize the validation/flushing/notification into one method to mak... Eric Faulhaber

06/01/2020

03:09 PM Feature #3814: more schema metadata: Added conversion support for the tables/fields string attributes (@*-SA@ properties)
Committed to 4231b rev. 11577. Igor Skornyakov
12:14 PM Feature #3814: more schema metadata: Debugging the conversion I've realized that I have to add support for the new table/field properties to the @p2o.xml@... Igor Skornyakov
10:04 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Put debug @printf@ statements in the @dmo_common.rules@ section for @graft "column-label-sa" anno... Igor Skornyakov
09:55 AM Feature #3814: more schema metadata: Put debug @printf@ statements in the @dmo_common.rules@ section for @graft "column-label-sa" annotation@. Either you... Greg Shah
09:38 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Yes.
Well, as you can see the new properties were not added. Igor Skornyakov
09:02 AM Feature #3814: more schema metadata: Yes. Greg Shah
08:45 AM Feature #3814: more schema metadata: Greg Shah wrote:
> I think you have shown the 4GL AST. The code calling @declareProperty@ is building a Java AST. ... Igor Skornyakov
08:16 AM Feature #3814: more schema metadata: I think you have shown the 4GL AST. The code calling @declareProperty@ is building a Java AST. Please show that Jav... Greg Shah
07:53 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Please show the output jast for the example field.... Igor Skornyakov
07:48 AM Feature #3814: more schema metadata: Please show the output jast for the example field. Greg Shah
07:32 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Post your @dmo_common.rules@.
>
> Are the annotations correct (as you would expect) in the AST... Igor Skornyakov
07:25 AM Feature #3814: more schema metadata: Post your @dmo_common.rules@.
Are the annotations correct (as you would expect) in the AST? Greg Shah
07:16 AM Feature #3814: more schema metadata: I see some strange situation:
There are two similar annotations for the field AST in the @.schema@ file:... Igor Skornyakov
06:23 AM Feature #3814: more schema metadata: Greg Shah wrote:
> > Please note, that the TYPE for the LABEL property is KW_LABEL, but is VALEXP for VALEXP (not KW... Igor Skornyakov
06:21 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Feedback:
>
> 1. The artificial token definitions for @KW_COL_LAB@, @KW_HELP@ and @KW_LABEL@ s... Igor Skornyakov
02:07 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Indeed, the full scan will be required for both of @count(__)@ versions. However, the @limi... Eric Faulhaber
02:02 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> About the #4011-385 - the issue is that the @ttRoomTypeAgg.deleteAll()@ is seeing the ta... Eric Faulhaber
12:42 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Some thoughts: that article uses a pseudo randomized unindexed data set. They need the coun... Constantin Asofiei
12:41 PM Feature #4011: database/persistence layer performance improvements: Some thoughts: that article uses a pseudo randomized unindexed data set. They need the count so the scan is mandatory... Ovidiu Maxiniuc
12:31 PM Feature #4011: database/persistence layer performance improvements: Indeed, the full scan will be required for both of @count(__)@ versions. However, the @limit 1@ will not help. The re... Ovidiu Maxiniuc
12:30 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Anyway, looking at some benchmark articles, like https://www.citusdata.com/blog/2016/1... Eric Faulhaber
11:50 AM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> I suppose you are talking about the unique index validation. These are queries using standa... Constantin Asofiei
11:42 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> A note: we shouldn't use @select count(*)@ - this should be replaced by something like @... Ovidiu Maxiniuc
08:12 AM Feature #4011: database/persistence layer performance improvements: About the #4011-385 - the issue is that the @ttRoomTypeAgg.deleteAll()@ is seeing the table as 'empty' (the @isTableD... Constantin Asofiei
07:41 AM Feature #4011: database/persistence layer performance improvements: A note: we shouldn't use @select count(*)@ - this should be replaced by something like @select count(recid)@ or whate... Constantin Asofiei
07:37 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Please continue to test Hotel GUI and work on fixes for any apparent regressions which do no... Constantin Asofiei
05:08 AM Feature #4011: database/persistence layer performance improvements: Constantin, I am working on a solution, but it may take another day or so. The good news is that I think you may have... Eric Faulhaber

05/31/2020

06:20 PM Feature #3814: more schema metadata: > Please note, that the TYPE for the LABEL property is KW_LABEL, but is VALEXP for VALEXP (not KW_VALEXP)
Yes, tha... Greg Shah
06:13 PM Feature #3814: more schema metadata: Feedback:
1. The artificial token definitions for @KW_COL_LAB@, @KW_HELP@ and @KW_LABEL@ should not be moved into ... Greg Shah
09:12 AM Feature #4011: database/persistence layer performance improvements: Eric, is not just about inserts. See this test:... Constantin Asofiei
06:35 AM Feature #4011: database/persistence layer performance improvements: The key is to maintain enough information to differentiate between a savepoint rollback which legitimately undoes a c... Eric Faulhaber
06:16 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, please see this test:
> [...]
>
> The flush is executed at the @find first@ st... Eric Faulhaber
05:19 AM Feature #4011: database/persistence layer performance improvements: Eric, please see this test:... Constantin Asofiei
08:42 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, the main issue with the savepoints, the FWD (sub)-tx and the FWD flush is this: in... Eric Faulhaber

05/30/2020

05:10 PM Feature #4011: database/persistence layer performance improvements: Eric, the main issue with the savepoints, the FWD (sub)-tx and the FWD flush is this: in H2, a flush will associate t... Constantin Asofiei
04:27 PM Feature #4011: database/persistence layer performance improvements: Constantin, we made a significant functional change in 4011a in terms of the timing of flushes to the database.
As... Eric Faulhaber
03:59 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> For some reason, FWD does the rollback for the savepoint which has the @guest.create()... Eric Faulhaber
03:49 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, I have the H2 fixes for CREATE/DROP INDEX, DROP TABLE, ALTER TABLE ADD CONSTRAINT ... Constantin Asofiei
03:17 PM Feature #4011: database/persistence layer performance improvements: Attached is the changed H2 jar and the patch. Constantin Asofiei
03:05 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Do you have the 197 version of this patch? I can't apply it to ver 197.
Hm, I have... Eric Faulhaber
02:55 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> For some reason, FWD does the rollback for the savepoint which has the @guest.create()@,... Constantin Asofiei
02:14 PM Feature #4011: database/persistence layer performance improvements: Eric, I have the H2 fixes for CREATE/DROP INDEX, DROP TABLE, ALTER TABLE ADD CONSTRAINT FOREIGN cases. I'll upload t... Constantin Asofiei
12:46 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, we still require the synchronization patch we have for ... Constantin Asofiei
10:16 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric, we still require the synchronization patch we have for ver 192 (from here: https:/... Eric Faulhaber
10:04 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Also, the current version is 1.4.200 - should we build the changes on top of that? And a... Ovidiu Maxiniuc
09:25 AM Feature #4011: database/persistence layer performance improvements: Also, the current version is 1.4.200 - should we build the changes on top of that? And also switch FWD to 1.4.200? Constantin Asofiei
09:22 AM Feature #4011: database/persistence layer performance improvements: Eric, we still require the synchronization patch we have for ver 192 (from here: https://proj.goldencode.com/download... Constantin Asofiei
06:11 AM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I can see how we could defer the drops until a safe time, aft... Eric Faulhaber
03:38 AM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> I can see how we could defer the drops until a safe time, after a transaction. The creates a... Constantin Asofiei
09:59 PM Feature #4011: database/persistence layer performance improvements: I committed r11447. Changes include:
* unique index validation: primarily a no 1 implementation (see entry 127), but... Ovidiu Maxiniuc
03:27 PM Feature #3814: more schema metadata: I've implemented the changes from #3814-79. However, the desired annotation arguments are still not emitted. I've als... Igor Skornyakov
08:16 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Some feedback:
>
> 1. Keyword token lengths are limited to KW_ + 8 characters. @KW_VALMSG_SA@... Igor Skornyakov
08:08 AM Feature #3814: more schema metadata: Some feedback:
1. Keyword token lengths are limited to KW_ + 8 characters. @KW_VALMSG_SA@ would be too long. Thi... Greg Shah
06:52 AM Feature #3814: more schema metadata: Greg Shah wrote:
> Please post your changed versions of both @schema.g@ and @progress.g@.
Please find them attach... Igor Skornyakov
06:49 AM Feature #3814: more schema metadata: Please post your changed versions of both @schema.g@ and @progress.g@. Greg Shah
06:46 AM Feature #3814: more schema metadata: I'm trying to add conversion support for string attributes for tables and fields (@*-SA@ properties).
I've added th... Igor Skornyakov

05/29/2020

05:28 PM Feature #4011: database/persistence layer performance improvements: Nice find. I wonder why we weren't hitting this before. I was not doing anything special to do the temp-table DDL out... Eric Faulhaber
04:21 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> * @transactional@ - the H2 manual says that the @CREATE TABLE@ _command commits an open tra... Constantin Asofiei
03:58 PM Feature #4011: database/persistence layer performance improvements: The root cause for the @Reservations/Check-in/Delete guest/Cancel reservation@ abend related to invalid savepoint is ... Constantin Asofiei
01:22 PM Feature #4011: database/persistence layer performance improvements: OK, so it probably is an issue with the timing of the record flush. Eric Faulhaber
01:16 PM Feature #4011: database/persistence layer performance improvements: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > OK, I'll switch to the savepoint problem when using the 'good... Constantin Asofiei
01:03 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> OK, I'll switch to the savepoint problem when using the 'good data'.
Since you have t... Eric Faulhaber
01:00 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Constantin,
> I am working on getting these messages parsed and the proper 4GL error issue... Constantin Asofiei
12:58 PM Feature #4011: database/persistence layer performance improvements: This is one of the open items. See #4011-127. Eric Faulhaber
12:58 PM Feature #4011: database/persistence layer performance improvements: Constantin,
I am working on getting these messages parsed and the proper 4GL error issued. I estimate they will be c... Ovidiu Maxiniuc
12:55 PM Feature #4011: database/persistence layer performance improvements: OK, that makes sense. My problem is this: in the @validateUniqueCommitted@, we don't know which unique index failed v... Constantin Asofiei
12:53 PM Feature #4011: database/persistence layer performance improvements: This is interesting:... Eric Faulhaber
12:48 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> Why is @records@ empty? Shouldn't this be loaded with all the unique records from the ... Eric Faulhaber
12:37 PM Feature #4011: database/persistence layer performance improvements: Eric/Ovidiu, about the 'bad data' case; there is this class @orm.UniqueTracker@:... Constantin Asofiei
12:26 PM Feature #4011: database/persistence layer performance improvements: Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > There is another issue, and please let me know if either of ... Constantin Asofiei
12:08 PM Feature #4011: database/persistence layer performance improvements: Constantin Asofiei wrote:
> There is another issue, and please let me know if either of you tracks it. If you go to... Ovidiu Maxiniuc
12:04 PM Feature #4011: database/persistence layer performance improvements: There is another issue, and please let me know if either of you tracks it. If you go to @Reservations@, and click @C... Constantin Asofiei
11:54 AM Feature #4011: database/persistence layer performance improvements: Ovidiu, I can't duplicate this anymore - yesterday I saw this issue, but it seems to be fixed in 4011a r11446. Constantin Asofiei
11:51 AM Feature #4011: database/persistence layer performance improvements: From Ovidiu:
> I understand that you managed to get the hotel GUI application up and running (including the database... Constantin Asofiei
08:30 AM Feature #4011: database/persistence layer performance improvements: Committed rev 11446, which fixes a flushing issue found in testing, adds stricter caching logic to the ORM session to... Eric Faulhaber

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Database

Activity

Activity

06/27/2020

06/26/2020

06/25/2020

06/24/2020

06/23/2020

06/22/2020

06/21/2020

06/20/2020

06/19/2020

06/18/2020

06/17/2020

06/16/2020

06/15/2020

06/14/2020

06/13/2020

06/12/2020

06/11/2020

06/10/2020

06/09/2020

06/08/2020

06/05/2020

06/04/2020

06/03/2020

06/02/2020

06/01/2020

05/31/2020

05/30/2020

05/29/2020