Activity
From 06/05/2020 to 07/04/2020
07/04/2020
- 06:58 PM Bug #4742: heap usage increase on server startup
- Constantin Asofiei wrote:
> So this allows multiple records for the same file (and if my interpretation of the code ... - 06:28 PM Bug #4742: heap usage increase on server startup
- In a large customer application, it was noticed a heap usage increase on a freshly started FWD server. The assumptio...
- 06:07 PM Bug #4742 (New): heap usage increase on server startup
- 05:59 PM Support #4702: write temp-table performance test cases
- There is an issue running the update tests with 4011b/11544. Looks like we are getting into an infinite loop based on...
07/03/2020
- 06:36 PM Feature #4011: database/persistence layer performance improvements
- I don't understand how @Loader.readExtentData@ worked before. Shouldn't it increase the @i@ var by the @seriesSize@...
- 02:49 PM Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> Is the primary problem this loop in @beginTx()@ and similar in @endTx()@:
Exactly. The global sc... - 02:47 PM Feature #4011: database/persistence layer performance improvements
- Is the primary problem this loop in @beginTx()@ and similar in @endTx()@:...
- 01:26 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> In email, Constantin wrote:
>
> > @BufferManager.beginTx@ and @endTx@ both stand out in t... - 01:05 PM Feature #4011: database/persistence layer performance improvements
- In email, Constantin wrote:
> @BufferManager.beginTx@ and @endTx@ both stand out in the visualvm sampler. This is... - 04:34 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> I see, then we have a problem. The same API is used for INSERT/UPDATE statements. When a DT... - 04:34 PM Support #4701: try to improve H2 transaction commit performance
- I attached the patch based on @h2_synchronization_transactional_fix_20200703a.patch@, but compatible with the 1.4.200...
- 02:56 PM Support #4701: try to improve H2 transaction commit performance
- Adrian, please post the clean patches for the 1.4.200 source code base. Unless Stanislav's findings are vastly differ...
- 02:44 PM Support #4701: try to improve H2 transaction commit performance
- Stanislav,
I attached the h2 versions I used in testing. I can't attach the already built ones as they are too bi... - 09:34 AM Support #4701: try to improve H2 transaction commit performance
- Adrian, could you share 197 patched and 200 patched?
- 07:33 AM Support #4701 (WIP): try to improve H2 transaction commit performance
- 07:33 AM Support #4701: try to improve H2 transaction commit performance
- I have computed the testing results for 1.4.200 and 1.4.200 patched. The spreadsheet is attached and a representative...
- 04:16 PM Support #4702: write temp-table performance test cases
- FYI, I added some missing EOL markers to @perf-run-all-silent.p@ and committed the fix.
- 02:00 PM Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
- I've tested calling one of Stanislav's tests (with minor changes to suppress output) as an external program in loop:
...
07/02/2020
- 07:36 PM Support #4702 (Review): write temp-table performance test cases
- I've committed all of the tests, including FOR EACH, FIND and BUFFER-COPY tests.
- 05:59 PM Support #4702: write temp-table performance test cases
- Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > I would like at least one test which "thrashes" JDBC connecti... - 06:28 AM Support #4702: write temp-table performance test cases
- Eric Faulhaber wrote:
> I would like at least one test which "thrashes" JDBC connections. That is, the test should... - 06:12 AM Support #4702: write temp-table performance test cases
- Stanislav Lomany wrote:
> Igor, I'm not managing connection. I suppose that is a part of your task.
> BTW, I just c... - 05:53 AM Support #4702: write temp-table performance test cases
- > Which of your tests is supposed to open/close multiple JDBC Connections?
Igor, I'm not managing connection. I su... - 04:21 AM Support #4702: write temp-table performance test cases
- Stanislav.
Which of your tests is supposed to open/close multiple JDBC Connections?
Thank you. - 04:58 PM Support #4701: try to improve H2 transaction commit performance
- Just found this in the H2 v1.4.200 change log, as something that was fixed:
* Issue # 1820: Performance problem on... - 04:05 PM Support #4701: try to improve H2 transaction commit performance
- I shared the findings in #4057. I will go ahead with testing the 1.4.200 version. Need just some syntax changes to th...
- 03:29 PM Support #4701: try to improve H2 transaction commit performance
- Adrian, this performance data presents an interesting counterpoint to the information posted previously to #4057. Ple...
- 11:26 AM Support #4701: try to improve H2 transaction commit performance
- I have done some testing using the Apache JMeter in order to see some differences between H2 versions: 1.4.196, 1.4.1...
- 04:14 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > * @TypeManager.setFwdDatetimetzParameter()@ you decided not ... - 04:05 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Review for 4011b rev 11537:
> * in which cases in @FqlToSqlConverter.getSqlColumnAlias@, t... - 04:00 PM Feature #4011: database/persistence layer performance improvements
- Review for 4011b rev 11537:
* in which cases in @FqlToSqlConverter.getSqlColumnAlias@, the @sqlName@ is null col "co... - 03:36 PM Feature #4011: database/persistence layer performance improvements
- More blob, clob and datetimetz fixes are in 4011b rev 11537.
- 03:34 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> They have an id reserved in @ReservedProperty@, indeed.
In the DMO interface, the annotat... - 03:33 PM Feature #4011: database/persistence layer performance improvements
- They have an id reserved in @ReservedProperty@, indeed.
However, if I remember correctly, they are true fields in d... - 03:17 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu, is it normal for a before-table to explicitly generate the @_error-flag@, @_row-state@ and other related prop...
- 02:49 PM Feature #4011: database/persistence layer performance improvements
- I'm getting an NPE when checking in a guest in Hotel GUI:...
- 01:40 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> 4011b rev 11535 seems fine to me. It's really strange that PSQL dialect has so specials nee... - 01:23 PM Feature #4011: database/persistence layer performance improvements
- 4011b rev 11535 seems fine to me. It's really strange that PSQL dialect has so specials needs.
4011b rev 11536: one ... - 01:04 PM Feature #4011: database/persistence layer performance improvements
- 4011 rev 11536 has these:
* Ignore DMO properties like _error-flag, _row-state, etc, where only table-defined legacy... - 12:47 PM Feature #4011: database/persistence layer performance improvements
- 4011b rev 11535 completed implementation for blob, clob, comhandle, handle, object and raw field types. Please review.
- 12:47 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> This code in @TemporaryBuffer$Context.nextPrimaryKey@:
> [...]
OK, yes, I see now.... - 12:27 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> So, instead of @lte@, we should emit @tt1.f1 < ?@, and use @PreparedStatement.setTimesta... - 12:23 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> All our supported dialects have a field type which includes the time zone. However, they de... - 12:17 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > Ovidiu/Eric: when does a del... - 12:07 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Ovidiu/Eric: when does a deleted record get evicted from ... - 11:57 AM Feature #4011: database/persistence layer performance improvements
- Committed @DirtyShareSupport@ class missing from last commit, as 4011b rev 11534.
- 11:35 AM Feature #4011: database/persistence layer performance improvements
- All our supported dialects have a field type which includes the time zone. However, they decided to support them diff...
- 10:47 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu, in SQL, do we still need the '_offset' column when comparing a datetime-tz field with another (string represe...
- 09:02 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Ovidiu/Eric: when does a deleted record get evicted from the @orm.Session.cache@? I can'... - 08:42 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu/Eric: when does a deleted record get evicted from the @orm.Session.cache@? I can't find any place for this... ...
- 06:36 AM Feature #4011: database/persistence layer performance improvements
- I have committed 4011a_rebase rev 11533, which fixes the CAN-FIND in the test case from #4011-577 and enables dirty s...
- 04:01 PM Bug #4057: h2 performance degradation
- I've done a testing effort in comparing 1.4.196, 1.4.197, 1.4.197 patched, 1.4.198 and 1.4.199. I shared the results ...
- 01:39 PM Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
- FYI, 4011b is the branch for this work. 4011a and 4011a_rebase are now frozen.
07/01/2020
- 07:26 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Is it safe to change @getLegacyField2Name()@, to omit these properties?
I do not know e... - 07:24 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Is it safe to change @getLegacyField2Name()@, to omit these properties?
It seems that o... - 07:18 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Thanks, that solved this. And following is @TableMapper.leg... - 07:13 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Thanks, that solved this. And following is @TableMapper.legacyGettersByProperty@ - this... - 07:07 PM Feature #4011: database/persistence layer performance improvements
- Thanks, that solved this. And following is @TableMapper.legacyGettersByProperty@ - this doesn't include the @TempTab...
- 06:59 PM Feature #4011: database/persistence layer performance improvements
- The dataset-related fields are added to @DmoMeta@ only if the table has before/after tables declared (see @src/com/go...
- 06:40 PM Feature #4011: database/persistence layer performance improvements
- Thanks, that solve this one. Now moving to more @TempTableRecord@ properties. The failure is this:...
- 06:35 PM Feature #4011: database/persistence layer performance improvements
- Use this in @DmoMetadataManager@:375 (method @getExistingFields()@):...
- 06:24 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> In my opinion, we should set in @TempTableBuilder@:686:
> [...]
> and get rid of @columnT... - 06:20 PM Feature #4011: database/persistence layer performance improvements
- I am all for getting rid of multi-layer mappings; they slow things down and complicate code maintenance. But there ar...
- 06:18 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> What seems to me is that the @P2JIndexCompoent@ can be used with FQL and SQL style index... - 06:15 PM Feature #4011: database/persistence layer performance improvements
- I think the problem is the ambiguity of @P2JIndex@. It is a descriptor of an index, which may be either a Progress in...
- 06:10 PM Feature #4011: database/persistence layer performance improvements
- In 4011a_rebase the index component is built from the DMO interface:...
- 06:07 PM Feature #4011: database/persistence layer performance improvements
- That suggests to me that the @column@ attribute of the @@Property@ annotation on the DMO interface is wrong, and shou...
- 05:59 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Either, the column name key (i.e., the post-SQL-keyname-conflict-resolution version with the... - 05:49 PM Feature #4011: database/persistence layer performance improvements
- Either, the column name key (i.e., the post-SQL-keyname-conflict-resolution version with the trailing underscore) is ...
- 04:57 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I have a new case of name mismatch in @TempTableBuilder.getExistingIndexes@.
>
> The ... - 04:45 PM Feature #4011: database/persistence layer performance improvements
- The recreate is this:...
- 04:16 PM Feature #4011: database/persistence layer performance improvements
- I have a new case of name mismatch in @TempTableBuilder.getExistingIndexes@.
The field name is @order@, @P2JIndexC... - 02:04 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I need to find another way of creating the @PgBlob@ instance...
In the end, PostgreSQL ... - 11:56 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Ovidiu, please check Hotel GUI for any other issues with 4011a_rebase.
OK, I will focus... - 11:48 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Unless there is something more important I can help with. Please let me know.
Ovidiu, plea... - 10:33 AM Feature #4011: database/persistence layer performance improvements
- I found a possible issue in @DmoMetadataManager@, when tables from different databases have the same name.
I am not ... - 09:29 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> And now I'm stuck because we are using c3p0 (which has @com.mchange.v2.c3p0.impl.NewProx... - 09:18 AM Feature #4011: database/persistence layer performance improvements
- And now I'm stuck because we are using c3p0 (which has @com.mchange.v2.c3p0.impl.NewProxyConnection@ instances for @j...
- 08:46 AM Feature #4011: database/persistence layer performance improvements
- @BlobType.readProperty@ is like this:...
- 07:52 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Ovidiu, we are still converting LOBs for DMOs (interfaces and im... - 07:27 AM Feature #4011: database/persistence layer performance improvements
- First time I'm trying to fire up the FWD server with 4011_rebase (rev 11531), in order to run a test case. I get this...
- 02:47 AM Feature #4011: database/persistence layer performance improvements
- 4011a_rebase r11531 has modified build.gradle to use the fwd-h2 patched in this task, as ver 1.4.197-20200530.
- 08:12 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Ovidiu, we are still converting LOBs for DMOs (interfaces and implementation classes), it se... - 08:10 PM Feature #4011: database/persistence layer performance improvements
- About the 'reWriteBatchedInserts=true' optimization for data import. I think this is just reporting '0' after the in...
- 08:00 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu, we are still converting LOBs for DMOs (interfaces and implementation classes), it seems, same as before. What...
- 01:47 PM Support #4702: write temp-table performance test cases
- Looks good so far.
In addition to the OPEN QUERY use you have in the read tests, please add some stressful use of ... - 08:22 AM Support #4702: write temp-table performance test cases
- I've committed read and update testcases to @testcases/uast/h2_performance@. The remaining testcases will follow.
- 01:31 PM Feature #4723: make it significantly easier to run database import
- The database import should be very simple to run, but today it has some "sharp edges" which tend to trip people up. ...
- 01:21 PM Feature #4723 (New): make it significantly easier to run database import
- 01:18 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
- The current approach has a fragile design which requires that we have a conversion project (or at least parts of it s...
- 01:15 PM Feature #4722 (Test): data import should be able to run with only the converted application jar f...
06/30/2020
- 07:58 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Some details about postgresql are here: https://jdbc.postgre... - 07:50 PM Feature #4011: database/persistence layer performance improvements
- There's a change in 4011a_rebase which breaks @RecordBuffer.initialize@. This was previously done when @getDMOImplem...
- 07:38 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Some details about postgresql are here: https://jdbc.postgresql.org/documentation/80/bin... - 07:29 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> blob and clob import is broken now. I'm working on fixing @PropertyMapper@.
The same p... - 07:09 PM Feature #4011: database/persistence layer performance improvements
- blob and clob import is broken now. I'm working on fixing @PropertyMapper@.
- 05:05 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> There are some issues in @IndexHelper.getPrimaryIndex@:
> * it was using @dmoClass@ ins... - 04:48 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > * @TemporaryBuffer@
> > ** @makeMutable@ - yes, we need ... - 08:35 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> * @TemporaryBuffer@
> ** @makeMutable@ - yes, we need an interface there, otherwise the... - 05:43 AM Feature #4011: database/persistence layer performance improvements
- The patch looks ok to me.
- 08:04 PM Feature #4011: database/persistence layer performance improvements
- There are some issues in @IndexHelper.getPrimaryIndex@:
* it was using @dmoClass@ instead of @dmoIface@ to get the a... - 04:39 PM Feature #3814: more schema metadata
- Found a minor issue with @_Field-Trig@ population.
Committing to 3821c revision 11381. ... - 03:57 PM Feature #3814: more schema metadata
- Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Very strange. Can you please send me your project? I will take a... - 03:24 AM Feature #3814: more schema metadata
- Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Very strange. Can you please send me your project? I will take a... - 10:34 PM Feature #3814: more schema metadata
- Igor Skornyakov wrote:
> Very strange. Can you please send me your project? I will take a look tomorrow.
> Thank yo... - 02:14 PM Support #4702: write temp-table performance test cases
- It is a common case in which a lot of time is likely to be spent in real applications. Any server-side stuff is goin...
- 01:09 PM Support #4702: write temp-table performance test cases
- Greg Shah wrote:
> Perhaps it makes sense to have a test that has some temp-tables with large numbers of columns and... - 01:06 PM Support #4702: write temp-table performance test cases
- Stanislav Lomany wrote:
> [...]
> Is that good for a start?
Yes. - 08:58 AM Support #4702: write temp-table performance test cases
- I'm think there will be tables which will have the same set of fields:
# integer
# char
# double
# date
# logica... - 08:17 AM Support #4702: write temp-table performance test cases
- Perhaps it makes sense to have a test that has some temp-tables with large numbers of columns and uses buffer-copy to...
- 01:14 PM Feature #4055: optimize temp-table output parameter copying
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > * Pre-validation of each record is necessary. If we leave it ... - 06:00 AM Feature #4055: optimize temp-table output parameter copying
- Eric Faulhaber wrote:
> * Pre-validation of each record is necessary. If we leave it to the database to reject uniqu... - 06:02 AM Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
- Igor Skornyakov wrote:
> Is it a top-priority task?
It is next highest priority behind any work needed to complet... - 06:00 AM Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
- @TempTableDataSourceProvider@ was introduced in branch 4011a to provide database connections to the in-memory H2 data...
- 05:53 AM Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
- Is it a top-priority task?
Thank you. - 05:50 AM Bug #4703 (Hold): investigate whether performance of TempTableDataSourceProvider can be improved
- 08:24 PM Support #4701: try to improve H2 transaction commit performance
- Eric Faulhaber wrote:
> Start with version 1.4.197 and apply our existing patches before you build. Constantin has a... - 08:22 PM Bug #4057: h2 performance degradation
- Eric Faulhaber wrote:
> Constantin has a recent patch which is not integrated into the FWD distribution yet; you wil...
06/29/2020
- 07:43 PM Support #4702: write temp-table performance test cases
- We need a set of temp-table related test cases in support of issues #4057 and #4071. The tests need to stress H2 as t...
- 05:11 PM Support #4702 (Closed): write temp-table performance test cases
- 07:16 PM Bug #4057: h2 performance degradation
- Please get the source for the latest version of H2 (1.4.200 at the time of this writing) and port our existing patche...
- 07:07 PM Support #4701: try to improve H2 transaction commit performance
- H2's transaction commit code repeatedly shows up as a performance bottleneck when profiling FWD application code. We ...
- 05:10 PM Support #4701 (Closed): try to improve H2 transaction commit performance
- 06:02 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu, there is a TODO in @TableMapper@:...
- 02:57 PM Feature #4011: database/persistence layer performance improvements
- @DmoMetadataManager.getBasePackage@
LE: Sorry, it's actually @DmoMetadataManager.getDmoBasePackage@, and it will i... - 02:52 PM Feature #4011: database/persistence layer performance improvements
- What is the counterpart of the @DMOIndex.getBasePackage()@ in 4011a?
Thank you. - 12:52 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > Greg Shah wrote:
> > > Is index size a problem for temp-tables?... - 08:54 AM Feature #4011: database/persistence layer performance improvements
- * @SortCriterion@
** @WHERE_WITH_NULLS@ I think can be removed. I'll need to double-check the customer project, but... - 08:30 AM Feature #4011: database/persistence layer performance improvements
- @FWDDataObject@ - this class is used outside of the FWD context, by customer code via @LegacyJavaAppserver@. I'm wor...
- 07:52 AM Feature #4011: database/persistence layer performance improvements
- Regarding the rebase TODO in @DatabaseManager.getDatabaseDMOs@...
The javadoc for @DatabaseManager.getDatabaseDMOs... - 05:20 PM Feature #3814: more schema metadata
- Constantin Asofiei wrote:
> Roger, what version of 3821c do you have? Note that trunk had a metadata generation issu... - 05:17 PM Feature #3814: more schema metadata
- Roger, what version of 3821c do you have? Note that trunk had a metadata generation issue which was solved in a 3821...
- 05:08 PM Feature #3814: more schema metadata
- Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Roger,
> > I'm busy now with some urgent assignment. Was the @m... - 05:03 PM Feature #3814: more schema metadata
- Igor Skornyakov wrote:
> Roger,
> I'm busy now with some urgent assignment. Was the @meta_table_ddl.sql@ file gener... - 04:48 PM Feature #3814: more schema metadata
- Roger Borrello wrote:
> I started receiving this during runtime of my testcase:
> [...]
>
> I made a few updates... - 04:38 PM Feature #3814: more schema metadata
- I started receiving this during runtime of my testcase:...
- 02:30 PM Feature #3814: more schema metadata
- 3821c revision 11377 fixes a regression DMO generation. The VIEW-AS text can have embedded quotes and escape sequenc...
- 11:40 PM Feature #3813: misc DB features part deux
- Branch 3821c revision 11374 has the implementation of @BUFFER-FIELD:DEFAULT-VALUE@ as well as the fixes to @date@/@da...
06/27/2020
- 04:13 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Is index size a problem for temp-tables? I thought that was a SQLSer...
06/26/2020
- 07:33 PM Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> Is index size a problem for temp-tables? I thought that was a SQLServer thing.
4GL has its own ... - 07:27 PM Feature #4011: database/persistence layer performance improvements
- Is index size a problem for temp-tables? I thought that was a SQLServer thing.
- 06:55 PM Feature #4011: database/persistence layer performance improvements
- Note that in the cases where the DMO implementation classes are different, it is not just unique constraints that are...
- 06:36 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > In @TemporaryBuffer.copyAllRows@, we can skip record validati... - 06:13 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> In @TemporaryBuffer.copyAllRows@, we can skip record validation if:
> [...]
>
> This...
06/25/2020
- 04:10 PM Feature #3814: more schema metadata
- Added _File-Trig and _Field-Trig population
Committing to 3821c revision 11366. ... - 12:51 PM Feature #4011: database/persistence layer performance improvements
- Regarding the test at #4011-633 - I've created a physical database with the same table structure and indexes, and OE ...
- 12:49 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> I'm not sure what you are asking. Across different DMO implementation classes, two unique in... - 12:44 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> But, does anyone know if we have a way to check if the unique indexes in two DMO impl ma... - 09:55 AM Feature #4011: database/persistence layer performance improvements
- For temp-tables, FWD has problems with this test:...
- 09:10 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric, an idea about the temp-table flushing. We currently save on every touched field. ... - 09:00 AM Feature #4011: database/persistence layer performance improvements
- Eric, an idea about the temp-table flushing. We currently save on every touched field. But I think we can defer thi...
- 06:36 AM Feature #4011: database/persistence layer performance improvements
- In @TemporaryBuffer.copyAllRows@, we can skip record validation if:...
06/24/2020
- 06:49 PM Feature #4011: database/persistence layer performance improvements
- The NULLS LAST/FIRST fix is in 4011a rev 11499.
- 05:50 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I don't understand what is happening. The same SQL in the standalone H2 server knows to... - 03:29 PM Feature #4011: database/persistence layer performance improvements
- I don't understand what is happening. The same SQL in the standalone H2 server knows to move the nulls to last posit...
- 02:35 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Also, H2 is wrong with or without a DESC index for F2 - the NULL must be first.
To be m... - 02:33 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu, add an ASC index for F1 and you will see that H2 is wrong - it will place the NULL first.
Also, H2 is wron... - 02:32 PM Feature #4011: database/persistence layer performance improvements
- ...
- 02:28 PM Feature #4011: database/persistence layer performance improvements
- What's the result for @select * from t1 order by f1 desc;@?
- 02:27 PM Feature #4011: database/persistence layer performance improvements
- I did a quick test with H2:...
- 02:24 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I have some tests, and OE sorts the nulls always last, regardless of direction.
Sorry, ... - 02:01 PM Feature #4011: database/persistence layer performance improvements
- I have some tests, and OE sorts the nulls always last, regardless of direction.
H2 has a bug in that it doesn't co... - 01:16 PM Feature #4011: database/persistence layer performance improvements
- Postgresql states that:
> By default, null values sort as if larger than any non-null value; that is, NULLS FIRST is... - 11:48 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Another issue is that the SUBSELECT doesn't have the @NULLS LAST@. At least we should b... - 11:42 AM Feature #4011: database/persistence layer performance improvements
- There is a problem in 4011a, where we emit @NULLS LAST@ in the @ORDER BY@ clause. This causes a performance regressi...
- 03:20 PM Feature #3814: more schema metadata
- Finished with VIEW-AS field property conversion and population of the @_Field._View-As@.
Tested with a standalone te... - 08:55 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, the fix is in 3821c rev 11363.
> >
> > Please test ... - 08:40 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Constantin Asofiei wrote:
> Roger, the fix is in 3821c rev 11363.
>
> Please test with the customer scenario.
... - 07:10 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Roger, the fix is in 3821c rev 11363.
Please test with the customer scenario. - 05:58 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Eric Faulhaber wrote:
> I am attaching a patch because I didn't have a branch to which to commit. The attached patch... - 05:28 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Eric Faulhaber wrote:
> Constantin, please take it from here.
OK, I'm working on it.
- 01:33 AM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Roger Borrello wrote:
> That patch alleviated the NPE, and we now result in:
> * "Unable to PREPARE TEMP-TABLE bu... - 07:05 AM Support #3871: determine how to change codepages/locales during import
- This task is not about the runtime environment. This is only about database import.
What matters is that we must ... - 12:02 AM Support #3871: determine how to change codepages/locales during import
- Analyzing the task history. The @FWD@ functionality from my understanding is to have tow separate parts, runtime envi...
06/23/2020
- 07:54 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Eric Faulhaber wrote:
> Yes and no :-)
>
> I am attaching a patch because I didn't have a branch to which to comm... - 06:09 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Yes and no :-)
I am attaching a patch because I didn't have a branch to which to commit. The attached patch fixes ... - 06:04 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Eric Faulhaber wrote:
> Nevermind, got it.
Are you looking at this? Did you see the notes in #4208-736 ? - 04:55 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Nevermind, got it....
- 04:49 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Stack trace?
- 04:01 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- Will there be different code-paths for a temp-table versus a standard table? I am walking through the testcase, tryin...
- 01:17 PM Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
- This code generates a @NPE@ on @trunk-11347@:...
- 07:17 PM Feature #4011: database/persistence layer performance improvements
- I committed revision 11496 to 4011a. It is mainly a FLQ support update:
* added support for DMOs in FROM clause of S... - 10:35 AM Feature #4011: database/persistence layer performance improvements
- It is not clear to me why we match @PROPERTY@ in the lexer (as @DOT SYMBOL@). Since there are many possible qualifie...
- 10:22 AM Feature #4011: database/persistence layer performance improvements
- Related to parsing of FQL: at this moment FQL2SQL is unable to parse queries like:
@from com.goldencode.appname.dmo.... - 06:06 AM Feature #4011: database/persistence layer performance improvements
- I've committed revisions 11494 and 11495. 11494 is Ovidiu's import fix. 11495 partially fixes the test case in #4011-...
- 05:38 PM Feature #3814: more schema metadata
- After adding checks for @null@ to the @SymbolResolver@ I do not see warning anymore and there is a @KW_VIEW_AS@ note...
- 05:12 PM Feature #3814: more schema metadata
- > I do not see KW_VIEW_AS node in the .schema or .dict files. Maybe this is a result of NPE.
Yes, possibly so. - 05:04 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> > however, there is no KW_VIEW_AS node in the AST at all
>
> The @replaceAst()@ rewrites that ... - 04:46 PM Feature #3814: more schema metadata
- > however, there is no KW_VIEW_AS node in the AST at all
The @replaceAst()@ rewrites that @KW_VIEW_AS@ subtree, th... - 04:42 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg, do you think is safe to set @dict=true@ at the @SymbolResolv... - 04:37 PM Feature #3814: more schema metadata
- Constantin Asofiei wrote:
> Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created b... - 04:10 PM Feature #3814: more schema metadata
- Constantin Asofiei wrote:
> Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created b... - 03:39 PM Feature #3814: more schema metadata
- Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created by @SchemaLoader.postProcessIm...
- 03:36 PM Feature #3814: more schema metadata
- Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > This is exactly what I did. It seems that not callers are re... - 03:24 PM Feature #3814: more schema metadata
- Igor Skornyakov wrote:
> This is exactly what I did. It seems that not callers are ready for @null@. But I will try ... - 03:19 PM Feature #3814: more schema metadata
- Constantin Asofiei wrote:
> > I've tried this. It doesn't help, NPE happens in @SymbolResolver.addWrappedWorker@
> ... - 03:15 PM Feature #3814: more schema metadata
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > I think is enough to add a NPE check there for @currentCls@.... - 03:13 PM Feature #3814: more schema metadata
- Constantin Asofiei wrote:
> I think is enough to add a NPE check there for @currentCls@. During schema parser, ther... - 03:08 PM Feature #3814: more schema metadata
- Igor Skornyakov wrote:
> The conversion of the .df files produces a number of warnings like this:
> [...]
> This h... - 02:59 PM Feature #3814: more schema metadata
- The conversion of the .df files produces a number of warnings like this:...
- 08:01 AM Support #3871 (WIP): determine how to change codepages/locales during import
- Sergey Ivanovskiy wrote:
> I used the similar diff to the following one in order to setup the UTF-8 database with IN...
06/22/2020
- 06:12 PM Feature #4011: database/persistence layer performance improvements
- Some notes about @fql.g@ from my quick review:
* The overall structure looks ... familiar. :) This is not a compl... - 02:28 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> There are issues in 4011a with the batch deletes:
> * the composite tables need to be d... - 10:00 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> A variation of #4011-549 with the validation:
> [...]
>
> The @CAN-FIND@ sees this r... - 01:42 PM Feature #4692: add sanity check at server startup to compare DMO indices with database indices
- Good point. We should add a comparison of legacy "mandatory" fields with database columns marked "not null" as part o...
- 12:48 PM Feature #4692: add sanity check at server startup to compare DMO indices with database indices
- Additional indices are OK as they could improve performance (if we spot some series of queries that frequently use a ...
- 12:38 PM Feature #4692: add sanity check at server startup to compare DMO indices with database indices
- Branch 4011a eliminates the collection of index metadata from the database at startup to populate @IndexHelper@ data ...
- 12:27 PM Feature #4692 (New): add sanity check at server startup to compare DMO indices with database indices
- 01:37 PM Support #4693: check whether our index consolidation adversely affects flushing behavior
- During schema conversion, we do some consolidation of the original 4GL indices to eliminate redundant indices. I am w...
- 01:28 PM Support #4693 (New): check whether our index consolidation adversely affects flushing behavior
- 11:24 AM Feature #3814: more schema metadata
- Finished re-working metadata configuration in p2j.cfg.xml.
Now, if there is no <metadata> section on the @p2j.cfg.xm...
06/21/2020
- 06:51 PM Feature #3814: more schema metadata
- Yes, I think that is fine.
- 10:54 AM Feature #3814: more schema metadata
- Do we really need to support @p2j.cf.xml@ w/o a <metadata> section? It requires a lot of changes as in many places it...
- 05:09 AM Feature #3814: more schema metadata
- Backport of the @SEQUENCE@ support from 4011a and population of the @_Sequence@ table committed to 3821c rev. 11351.
06/20/2020
- 01:34 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> 3821c not b
OK, thank you. - 01:33 PM Feature #3814: more schema metadata
- 3821c not b
- 01:32 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> Hynek will open 3821b shortly.
Got it. Thanks! - 01:23 PM Feature #3814: more schema metadata
- Hynek will open 3821b shortly.
- 12:45 PM Feature #3814: more schema metadata
- Greg, which branch should I use for #3814 now?
Thank you. - 12:00 PM Feature #3814: more schema metadata
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:10 PM Bug #4492: database trigger defined with abbreviation should create a new buffer
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:01 PM Bug #3471: incremental conversion is regressed
- Task branch 4231b has been merged to trunk as revision 11347.
- 11:57 AM Feature #4397: add database attrs, methods and options
- Task branch 4231b has been merged to trunk as revision 11347.
Is there anything left to do in this task? - 11:57 AM Feature #3813: misc DB features part deux
- Task branch 4231b has been merged to trunk as revision 11347.
> Considering that the WHERE clause work has been mo... - 11:56 AM Feature #4375 (Closed): add support for -pf <profile_filename> option for CONNECT statement
- Task branch 4231b has been merged to trunk as revision 11347.
06/19/2020
- 05:13 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> The old @cumulativeDirtyProps@ was stored in @ValidationHelper@ and contained the entire se... - 04:49 PM Feature #4011: database/persistence layer performance improvements
- The old @cumulativeDirtyProps@ was stored in @ValidationHelper@ and contained the entire set of changes at the last (...
- 04:37 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu, regarding 4011a/11486: @RecordBuffer.cumulativeDirtyProps@ is never modified, only instantiated and used as a...
- 04:09 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > the composite tables need to be deleted manually (or is t... - 04:05 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> the composite tables need to be deleted manually (or is the foreign key 'on cascade de... - 03:18 PM Feature #4011: database/persistence layer performance improvements
- There are issues in 4011a with the batch deletes:
* the composite tables need to be deleted manually (or is the fore... - 02:17 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> The only issue I have is that @boolean doFlush = !rollback || hasUniqueConstraint;@ wi... - 02:01 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin, would you please carefully review the change? It did go through some regression ... - 01:40 PM Feature #4011: database/persistence layer performance improvements
- Committed rev 11487, which:
* bypasses database-level unique constraint validation when the backing table has no u... - 07:52 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> some indexes keep their @unique@ attribute. I remember that we were intentionally doing s... - 08:05 PM Feature #4011: database/persistence layer performance improvements
- Eric,
As I informed by email, I noticed some differences in the generated indexes for our test framework. There are ... - 06:08 AM Feature #3814: more schema metadata
- Status summary update (see #3814-100)
# Added @_Sequence@ table population based on the new @SEQUENCE@ support (back...
06/18/2020
- 07:34 PM Feature #4011: database/persistence layer performance improvements
- As part of cleaning up the branch, we should get rid of these ANTLR warnings:...
- 01:30 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> This is a different issue than that which is addressed by the use of the @ParameterIndices@ ... - 01:04 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > For a WHERE clause which has subscripted fields like @tt1... - 09:25 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> For a WHERE clause which has subscripted fields like @tt1.f1[?]@, I need to inject the @... - 08:34 AM Feature #4011: database/persistence layer performance improvements
- For a WHERE clause which has subscripted fields like @tt1.f1[?]@, I need to inject the @tt1__10.list__index = ?@ at t...
- 04:52 PM Feature #4690: re-integrate dirty share logic into new persistence implementation
- Ovidiu Maxiniuc wrote:
> The choice to use a @null@ context is due the performance. This might not be the most ele... - 03:55 PM Feature #4690: re-integrate dirty share logic into new persistence implementation
- Eric Faulhaber wrote:
> I'm reading through the changes, and this is not a full review yet, but I have some general ... - 02:28 PM Feature #4690: re-integrate dirty share logic into new persistence implementation
- I'm reading through the changes, and this is not a full review yet, but I have some general questions about the 4011a...
- 02:20 PM Feature #4690: re-integrate dirty share logic into new persistence implementation
- Some new requirements have arisen for the dirty share feature set. Although we would like to eliminate this feature a...
- 01:54 PM Feature #4690: re-integrate dirty share logic into new persistence implementation
- Opening a separate issue for this, as it is a substantial topic on its own...
4011a_dirty is the branch in use for... - 01:53 PM Feature #4690 (WIP): re-integrate dirty share logic into new persistence implementation
06/17/2020
- 02:12 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> OK, please commit the change to 4231b.
Committed revision 11609. - 02:05 PM Feature #3814: more schema metadata
- OK, please commit the change to 4231b.
- 01:58 PM Feature #3814: more schema metadata
- Some additional fixes were made to run hotel apps w/o @p2j.cf.xml@. See attachment.
- 12:33 PM Feature #3814: more schema metadata
- Igor Skornyakov wrote:
> Greg Shah wrote:
> > The change looks good. Please test it with Hotel GUI and Hotel ChUI.... - 12:32 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> The change looks good. Please test it with Hotel GUI and Hotel ChUI.
Both apps started OK. Pl... - 12:11 PM Feature #3814: more schema metadata
- The change looks good. Please test it with Hotel GUI and Hotel ChUI.
- 12:04 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> Why did you remove the @throw@ in the @catch()@ block of @Configuration.createConfiguration()@? ... - 11:55 AM Feature #3814: more schema metadata
- Why did you remove the @throw@ in the @catch()@ block of @Configuration.createConfiguration()@? This means that the ...
- 11:48 AM Feature #3814: more schema metadata
- Greg Shah wrote:
> Code Review cfg.diff
>
> Please remove the new imports in @Configuration@ and also remove the ... - 11:41 AM Feature #3814: more schema metadata
- Code Review cfg.diff
Please remove the new imports in @Configuration@ and also remove the change for the @catch()@... - 11:11 AM Feature #3814: more schema metadata
- Greg Shah wrote:
> Code Review cfg.diff
>
> 1. At this time, it is intentional that we do not use logging in @Con... - 10:17 AM Feature #3814: more schema metadata
- Code Review cfg.diff
1. At this time, it is intentional that we do not use logging in @Configuration@. It is used... - 09:02 AM Feature #3814: more schema metadata
- Greg Shah wrote:
> Please post the change here in patch format so I can review it. If OK, you will check it in to 4... - 08:06 AM Feature #3814: more schema metadata
- Please post the change here in patch format so I can review it. If OK, you will check it in to 4231b since this is m...
- 07:54 AM Feature #3814: more schema metadata
- Greg Shah wrote:
> A safe default configuration (which has nothing enabled) should be present if the file is not ava... - 07:02 AM Feature #3814: more schema metadata
- A safe default configuration (which has nothing enabled) should be present if the file is not available. No abends.
- 06:57 AM Feature #3814: more schema metadata
- I've fixed the situation when there is no <metadata> section on the @p2j.cfg.xml@. However it seems that the applicat...
- 05:55 AM Feature #3814: more schema metadata
- Please make both cases safe.
- 02:55 AM Feature #3814: more schema metadata
- Greg Shah wrote:
> I'm using the ChUI regression test suite. I found that with 4231b, it is now required to have a ...
06/16/2020
- 07:00 PM Feature #3814: more schema metadata
- I'm using the ChUI regression test suite. I found that with 4231b, it is now required to have a @cfg/p2j.cfg.xml@ bu...
- 04:58 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > A variation of #4011-549 with the validation:
> > [...]
> >... - 04:42 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> A variation of #4011-549 with the validation:
> [...]
>
> The @CAN-FIND@ sees this r... - 11:11 AM Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to c... - 10:52 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> I've been considering divorcing the cache from the session object to get more advantage from... - 08:05 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've seen cases where we have a select like @select tt1.*... - 06:54 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I've seen cases where we have a select like @select tt1.*, tt2.recid@ where @tt2@ is a s... - 06:28 AM Feature #4011: database/persistence layer performance improvements
- I've seen cases where we have a select like @select tt1.*, tt2.recid@ where @tt2@ is a standalone table or a composit...
- 06:07 AM Feature #4011: database/persistence layer performance improvements
- I've committed revision 11481, which minimizes the number of database savepoints being set for application sub-transa...
- 12:43 AM Feature #4011: database/persistence layer performance improvements
- Greg Shah wrote:
> > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to c... - 11:11 PM Feature #4011: database/persistence layer performance improvements
- > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to check if I'm missing ...
- 09:42 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> 4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. ... - 04:36 PM Feature #4681: prepared statement caching/pooling
- I think we can simplify this idea a bit. I don't see the value in making a static cache. A @PreparedStatement@ instan...
- 01:39 PM Feature #4681: prepared statement caching/pooling
- My concern is related to multiple session close (they have a short life), which will invalidate the cached statements...
- 12:58 PM Feature #4681: prepared statement caching/pooling
- This issue is to discuss the implementation of @PreparedStatement@ caching/pooling as a potential performance optimiz...
- 12:56 PM Feature #4681 (WIP): prepared statement caching/pooling
06/15/2020
- 07:23 PM Feature #4011: database/persistence layer performance improvements
- 4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. FQL2SQL will take care of cr...
- 07:11 PM Feature #4011: database/persistence layer performance improvements
- 4011a rev 11479 adds the @AnnotatedAst.iterator()@ fix (#4011-574) and refactors rowStructure to allow for self-join.
- 09:49 AM Feature #4011: database/persistence layer performance improvements
- A variation of #4011-549 with the validation:...
- 05:51 AM Feature #4011: database/persistence layer performance improvements
- 4011a rev 11475 fixes ChangeSet.ensureCapacity.
06/14/2020
- 10:25 AM Feature #4011: database/persistence layer performance improvements
- > BTW, in FWD (both 4011 and trunk) only the RAQ will consult the dirty database for possible leaking record. The 4GL...
06/13/2020
- 05:53 PM Feature #4011: database/persistence layer performance improvements
- > There's nowhere to descend, nor another sibling. When iter.hasNext() is called after the BOOL_TRUE was processed, i...
06/12/2020
- 07:03 PM Feature #4011: database/persistence layer performance improvements
- Yes, if we can evaluate static sub-expressions during conversion, we roll them up to their result and replace the sub...
- 07:00 PM Feature #4011: database/persistence layer performance improvements
- Is it possible that the WHERE node was dropped in this case?
- 06:57 PM Feature #4011: database/persistence layer performance improvements
- AFAIK, we didn't change this in 4011a. I wonder why we are hitting this now.
- 06:42 PM Feature #4011: database/persistence layer performance improvements
- There's a bug in @AnnotatedAst.iterator@ when trying to iterate starting from the @BOOL_TRUE@ child (of the @WHERE@ c...
- 06:20 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The not closed objects are most likely the reason for the me... - 05:37 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready.
See... - 05:25 PM Feature #4011: database/persistence layer performance improvements
- Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready.
- 05:17 PM Feature #4011: database/persistence layer performance improvements
- This was inspired by what I saw Hibernate was generating. The most signifiant 32 bit came naturally and will match th...
- 05:02 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Or better yet, why use a hashcode for the FK? Just as a convention? This name needs to... - 05:01 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> There's something wrong in TempTableHelper when the constraint name is computed:
> [...... - 04:45 PM Feature #4011: database/persistence layer performance improvements
- There's something wrong in TempTableHelper when the constraint name is computed:...
- 03:57 PM Feature #4011: database/persistence layer performance improvements
- OK, I think this is what Hibernate did as well. We may come back to @PreparedStatement@ caching as a potential optimi...
- 03:49 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS... - 03:47 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS... - 03:43 PM Feature #4011: database/persistence layer performance improvements
- I think we know when we are done with the statement in all cases, but do we cache @PreparedStatement@ instances to pr...
- 03:42 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> The not closed objects are most likely the reason for the memory issues. I tried to close s... - 03:20 PM Feature #4011: database/persistence layer performance improvements
- The not closed objects are most likely the reason for the memory issues. I tried to close some of them but it was rea...
- 03:18 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> How were we handling cleanup of the Hibernate query resources?
I think Hibernate was taking... - 03:09 PM Feature #4011: database/persistence layer performance improvements
- @AbstractQuery@ has a @cleanup@ method, however, the use of @SQLQuery@ and even @Query@ is somewhat internal/hidden w...
- 03:04 PM Feature #4011: database/persistence layer performance improvements
- Another issue which I don't understand: the @SQLQuery@'s JDBC statement and ResultSet is never closed. Why? Who shou...
- 03:02 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've moved to another test as the current one is blocked ... - 09:05 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> I've moved to another test as the current one is blocked with the flush/mandatory issue.... - 08:25 AM Feature #4011: database/persistence layer performance improvements
- I've moved to another test as the current one is blocked with the flush/mandatory issue. Now I've reached an extent ...
- 08:13 PM Feature #4011: database/persistence layer performance improvements
- Not exactly. I will add it, thanks.
06/11/2020
- 07:57 PM Feature #4011: database/persistence layer performance improvements
- Eric, do you have this case in your current flush/validation work?...
- 06:37 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you e... - 06:06 PM Feature #4011: database/persistence layer performance improvements
- Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you end up with two records like ...
- 04:56 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE ... - 03:39 PM Feature #4011: database/persistence layer performance improvements
- A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE and there is the same behavio...
- 03:22 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Ovidiu, what's the difference between @FqlType.DECIMAL@ and @FqlType.DOUBLE@? How are th... - 03:07 PM Feature #4011: database/persistence layer performance improvements
- 11467 contains the ScrollingResults fix, rollback of SqlQuery RSMD usage and another fix in FqlType.
- 03:06 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Should I call @Persistence$Context.useSession@ for @Scrol... - 02:58 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Should I call @Persistence$Context.useSession@ for @ScrollingResults@, too? I see that w... - 02:48 PM Feature #4011: database/persistence layer performance improvements
- I've got an infinite loop because this code:...
- 12:28 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > That code already has a call for RSMD, @int columnCount =... - 12:26 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> That code already has a call for RSMD, @int columnCount = resultSet.getMetaData().getC... - 12:14 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The foreign table is mapped by @MetaFile.class@ and by defau... - 12:03 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin, we have biased as much as we can in this implementation toward speed, so we are ... - 11:45 AM Feature #4011: database/persistence layer performance improvements
- Constantin, we have biased as much as we can in this implementation toward speed, so we are avoiding things like @Res...
- 10:33 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> The problem is the previous code assumed the SELECT was always retrieving full records. ... - 10:24 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > 4011a rev 11465 contains my FQL fixes plus misc. Please rev... - 09:38 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> 4011a rev 11465 contains my FQL fixes plus misc. Please review.
I have only a questi...
06/10/2020
- 06:23 PM Feature #4011: database/persistence layer performance improvements
- 4011a rev 11465 contains my FQL fixes plus misc. Please review.
- 06:17 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> The foreign table is mapped by @MetaFile.class@ and by default the 'foreign' field is also ... - 01:53 PM Feature #4011: database/persistence layer performance improvements
- Lots of regression after changing it... so no good.
- 01:49 PM Feature #4011: database/persistence layer performance improvements
- There is a problem at the fql.g parser:...
- 01:43 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Found a broken feature I forgot about in 4011: sequences, see #3814-109.
> We need to add ... - 12:05 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Replacing Record with Persistable fixes the above.
> I am n... - 11:59 AM Feature #4011: database/persistence layer performance improvements
- Constantin,
After running conversion with a newer metadata definition I have this:... - 11:16 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Ovidiu, I have a problem with the relation generated between the Field and File meta tab... - 10:48 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Replacing Record with Persistable fixes the above.
I am not sure is not correct. Which ... - 09:17 AM Feature #4011: database/persistence layer performance improvements
- Replacing Record with Persistable fixes the above.
- 09:02 AM Feature #4011: database/persistence layer performance improvements
- I've fixed that manually (BTW, @name="id"@ should be @name="recid"@, depending on what you configured as the PK in p2...
- 08:51 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu, I have a problem with the relation generated between the Field and File meta tables. In DMO index, I have th...
- 08:37 AM Feature #4011: database/persistence layer performance improvements
- 11463 fixes the FqlType issue in #4011-517. But I think we need complete support for FqlType enum.
- 07:53 AM Feature #4011: database/persistence layer performance improvements
- Ovidiu, I need a mapping between FQLType enum values and java.sql.Types. Can you provide a complete list?
- 06:05 AM Feature #4011: database/persistence layer performance improvements
- Rev 11462 fixes @TB.readAllRows@. It also has some validation, flush, rollback fixes that are work in process. They d...
- 05:33 PM Feature #4155 (WIP): remove conversion dependency on metadata .df file
- Our ultimate objective with schema metadata is to eliminate the conversion of these DMOs and instead rely upon metada...
- 10:21 AM Feature #3814: more schema metadata
- Greg Shah wrote:
> As you check in updates for this task, the @rules/gaps/database.rules@ (@addMetaschema@ section) ... - 10:19 AM Feature #3814: more schema metadata
- As you check in updates for this task, the @rules/gaps/database.rules@ (@addMetaschema@ section) needs to be updated ...
06/09/2020
- 07:13 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> There is this code in @TemporaryBuffer.readAllRows@:
> [...]
>
> I would expect @res... - 07:01 PM Feature #4011: database/persistence layer performance improvements
- There is this code in @TemporaryBuffer.readAllRows@:...
- 03:32 PM Feature #4011: database/persistence layer performance improvements
- Actually, the code above will not work for PostgreSQL as the @getComputedColumnFormula@ will return @null@. It looks ...
- 03:19 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > That is interesting. It looks like I added a regression when... - 03:14 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> That is interesting. It looks like I added a regression when constructing validation messag... - 03:12 PM Feature #4011: database/persistence layer performance improvements
- That is interesting. It looks like I added a regression when constructing validation message in my recent commit. Ple...
- 02:59 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu, one more - I don't understand where the "__i?" is coming from....
- 02:44 PM Feature #4011: database/persistence layer performance improvements
- If the query already has fetched the full records, we already would have used the session cache to gain this optimiza...
- 02:37 PM Feature #4011: database/persistence layer performance improvements
- Ovidiu Maxiniuc wrote:
> Constantin,
> I think the change you refer to was mine. The idea was to fetch the exact am... - 02:36 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> This part in @metaschema.xml@ is wrong:
> [...]
> We need to use the primary key as s... - 02:30 PM Feature #4011: database/persistence layer performance improvements
- Constantin,
I think the change you refer to in #4011-504 was mine. The idea was to fetch the exact amount of informa... - 02:21 PM Feature #4011: database/persistence layer performance improvements
- This part in @metaschema.xml@ is wrong:...
- 01:31 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric, what part is wrong here? The @Presorter$SortedResults@ which expects full records,... - 01:12 PM Feature #4011: database/persistence layer performance improvements
- Found a broken feature I forgot about in 4011: sequences, see #3814-109.
We need to add back initialization support ... - 10:02 AM Feature #4011: database/persistence layer performance improvements
- If you enable enhanced browse, and click the 'checkin' column in the Guests grid, you get a @ClassCastException@:
<p... - 09:46 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Attached are my changes in process for the rollback fix. It is not working yet, but I am pos... - 08:22 AM Feature #4011: database/persistence layer performance improvements
- Attached are my changes in process for the rollback fix. It is not working yet, but I am posting because I need to ta...
- 07:06 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > The reason I ask is that I noticed in the debugger that the... - 07:01 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> I guess all the changes for @LazyUndoable@ are just an optimization, but the core idea is st... - 06:55 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Now my problem is that @LightweightUndoable@ is nothing like I remember it. I guess all th... - 06:46 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> OK, so the record doesn't need to remain in the database, as the flush is rolledback, ... - 06:38 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> I don't understand this patch. I mean, I get the logic, but it doesn't look right to me conc... - 06:32 AM Feature #4011: database/persistence layer performance improvements
- I don't understand this patch. I mean, I get the logic, but it doesn't look right to me conceptually. The point of ma...
- 06:14 AM Feature #4011: database/persistence layer performance improvements
- Eric, attached patch fixes this testcases:...
- 05:47 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Going back to this: I've tried saving the record in the database, in @ChangeSet.rollba... - 02:33 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> My worry here is that you are creating new things that will be hard to merge with 4011a. We plan... - 02:16 PM Feature #3814: more schema metadata
- My worry here is that you are creating new things that will be hard to merge with 4011a. We plan to do that merge ve...
- 01:29 PM Feature #3814: more schema metadata
- Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
> Yes, the @DMOIndex@ c... - 01:07 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
Yes, the @DMOIndex@ class is already gone in 4011a.... - 12:24 PM Feature #3814: more schema metadata
- Greg Shah wrote:
> Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
I already use @DMOIndex@ in the @MetadataManager@... - 12:12 PM Feature #3814: more schema metadata
- Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
- 12:04 PM Feature #3814: more schema metadata
- Ovidiu Maxiniuc wrote:
> Of course, please see the last lines in @ddl/schema_table_<db-name>_<sql-dialect>.sql@. Aft... - 11:23 AM Feature #3814: more schema metadata
- Of course, please see the last lines in @ddl/schema_table_<db-name>_<sql-dialect>.sql@. After a successuful conversio...
- 04:27 AM Feature #3814: more schema metadata
- Do we generate any artifacts for @SEQUENCE@? I cannot find any. The corresponding AST exists. Please advise.
Thank you.
06/08/2020
- 02:12 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Eric Faulhaber wrote:
> > > Constantin, at this level in... - 02:00 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I didn't think so. We should be fetching it from the database... - 01:54 PM Feature #4011: database/persistence layer performance improvements
- Constantin,
in FWD runtime the primary key name is read from @persistence/primary-key-name@ and stored globally in @... - 01:36 PM Feature #4011: database/persistence layer performance improvements
- Eric, in #4011-303, you note that in @p2j.cfg.xml@ you used this:...
- 11:13 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin, at this level in the code, we are not dealing wit... - 11:04 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin, at this level in the code, we are not dealing with BDT instances.
You are corr... - 11:00 AM Feature #4011: database/persistence layer performance improvements
- Constantin, at this level in the code, we are not dealing with BDT instances. These are the lower level Java types wh...
- 10:51 AM Feature #4011: database/persistence layer performance improvements
- This fix solves all deadlocks related to locking (even those which exist in trunk), in @BaseRecord.setDatum@:...
- 10:17 AM Feature #4011: database/persistence layer performance improvements
- There is a deadlock when updating a Rate or a Guest by multiple clients, but this is an application logic problem.
... - 08:57 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> I didn't think so. We should be fetching it from the database on next access.
The problem ... - 08:46 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> The abend in Reservations/Check-in/Delete Guest/Cancel Check-in is related to this test:... - 08:41 AM Feature #4011: database/persistence layer performance improvements
- The abend in Reservations/Check-in/Delete Guest/Cancel Check-in is related to this test:...
- 07:52 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin, please commit your change to always use @NopDirtyShareContext@, with a TODO to r... - 07:04 AM Feature #4011: database/persistence layer performance improvements
- Rev 11455 fixes an NPE and some validation logic.
- 06:56 AM Feature #4011: database/persistence layer performance improvements
- Constantin, please commit your change to always use @NopDirtyShareContext@, with a TODO to re-enable it when the re-i...
- 06:48 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> So, the dirty share database should be used only for explicitly-configured tables/data... - 06:04 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> After another full @ant deploy.all@, this time with the data from Hotel GUI rev 212, I now g... - 05:57 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> And another issue with the dirty database - previously there were @Reversible@ instances... - 05:51 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Please coordinate with Ovidiu on this; he is actively making changes in this area. The dirty... - 05:46 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > BTW, also found these in the server log from the same work fl... - 05:20 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> BTW, also found these in the server log from the same work flow:
>
> [...]
The root caus... - 05:04 AM Feature #4011: database/persistence layer performance improvements
- OK, I'll check with H2, too.
BTW, I still see the NPE for the 'delete guest' and 'Cancel', in the Reservations, C... - 05:00 AM Feature #4011: database/persistence layer performance improvements
- BTW, also found these in the server log from the same work flow:...
- 04:59 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> I am using the default H2 database in my testing. I'll try with PostgreSQL.
Indeed, the... - 04:42 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> 11454 does not compile for me:
> [...]
>
> I've bypassed this and I don't get your e... - 04:35 AM Feature #4011: database/persistence layer performance improvements
- 11454 does not compile for me:...
- 04:24 AM Feature #4011: database/persistence layer performance improvements
- After another full @ant deploy.all@, this time with the data from Hotel GUI rev 212, I now get the following error wi...
- 04:00 AM Feature #4011: database/persistence layer performance improvements
- On a completely fresh run of Hotel GUI, first thing after running @ant deploy.all@ and server startup, I get some err...
- 08:50 AM Feature #3814: more schema metadata
- > Regarding the undocumented fields of the _Field table, I think that it can be sufficient to set them to a "typical"...
- 08:30 AM Feature #3814: more schema metadata
- Greg Shah wrote:
> > This means that the _File._ianum is almost useless and has not any meaningful counterpart in FW... - 08:01 AM Feature #3814: more schema metadata
- > This means that the _File._ianum is almost useless and has not any meaningful counterpart in FWD. I understand the ...
- 07:38 AM Feature #3813: misc DB features part deux
- Considering that the WHERE clause work has been moved to #4613, is there any reason to keep this task open?
06/05/2020
- 07:12 PM Feature #4011: database/persistence layer performance improvements
- Unfortunately, I don't have the dirty share fully done yet.
To let my brain cool down I returned and fixed the uniqu... - 05:57 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Virtual desktop and embedded mode get through this flow fine,... - 05:42 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > The only issue I'm aware in Hotel GUI is the NPE related to C... - 05:41 PM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Virtual desktop and embedded mode get through this flow fine, so it may be a client problem ... - 05:36 PM Feature #4011: database/persistence layer performance improvements
- Another issue I hit was in Swing only:
* log in
* from "Available Rooms", click "Check-In..."
* delete guest
* ... - 05:32 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, afte... - 05:15 PM Feature #4011: database/persistence layer performance improvements
- The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, after deleting the guest.
- 05:13 PM Feature #4011: database/persistence layer performance improvements
- This code in @RecordBuffer.delete@ doesn't set the @token@:...
- 04:56 PM Feature #4011: database/persistence layer performance improvements
- The deadlock described in #4011-385 can be duplicated like this in 11452:
* delete a room
* close and start another... - 02:56 PM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> My changes to fix the #4011-385, the @deleteAll@ problem because there was no notificati... - 05:35 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion... - 05:17 AM Feature #4011: database/persistence layer performance improvements
- Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion from scratch and try it ...
- 05:07 AM Feature #4011: database/persistence layer performance improvements
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, the issue in #4011-412 is not solved by your changes.
... - 04:57 AM Feature #4011: database/persistence layer performance improvements
- Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is not solved by your changes.
Constantin, I don't get a... - 04:38 PM Feature #3814: more schema metadata
- # restored @_database-feature@ support previously implemented by Ovidiu
# added the following @_file@ fields:...
Also available in: Atom