Project

General

Profile

Activity

From 07/15/2020 to 08/13/2020

08/13/2020

07:28 PM Feature #3814: more schema metadata
> My understanding is that VSTs are created at the connect to the database and are not cleared until the connection i... Greg Shah
06:45 PM Feature #3814: more schema metadata
My understanding is that VSTs are created at the connect to the database and are not cleared until the connection is ... Igor Skornyakov
06:41 PM Feature #3814: more schema metadata
> The data from the contexts that are closed before the start of the aggregation will be lost.
I would have though...
Greg Shah
06:39 PM Feature #3814: more schema metadata
> Note that simple long types will do. There is no need to use AtomicLong, since these variables are counting operati... Greg Shah
06:27 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I'm not talking about database query. Me suggestion is have ...
Igor Skornyakov
06:12 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I'm not talking about database query. Me suggestion is have the map as a field in the @Da...
Eric Faulhaber
05:28 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > And keeping this map in the @Database@ instance will greatly sim...
Igor Skornyakov
05:15 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> And keeping this map in the @Database@ instance will greatly simplify the aggregation.
P...
Eric Faulhaber
04:51 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
.> Yes, a map lookup at @RecordBuffer@ creation (or initialization) seems an acceptable level ...
Igor Skornyakov
04:44 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> To ensure that the @TableStats@ should be one per table I think that it is better to hold t...
Eric Faulhaber
04:36 PM Feature #3814: more schema metadata
BTW: I do not think that the overhead will be substantially increased if the map will be not context-local but a fiel... Igor Skornyakov
04:31 PM Feature #3814: more schema metadata
Greg Shah wrote:
> [...]
>
> There would be one of these for each table ever accessed. At the first time a table...
Igor Skornyakov
04:19 PM Feature #3814: more schema metadata
... Greg Shah
04:12 PM Feature #3814: more schema metadata
Greg Shah wrote:
> This still seems expensive. We don't want to take a map lookup hit in order to increment a count...
Igor Skornyakov
04:06 PM Feature #3814: more schema metadata
> I understand that it should be a map of arrays of counters. If it will be ConcurrentMap with Atomic values no addit... Greg Shah
03:17 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> I assume the entries for a particular session should be removed when that session ends. Othe...
Igor Skornyakov
03:12 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I understand that it should be a map of arrays of counters. If it will be @ConcurrentMap@...
Eric Faulhaber
02:59 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Greg Shah wrote:
> > That doc page suggests @_usertablestat-num@ is the table number. Perh...
Igor Skornyakov
02:52 PM Feature #3814: more schema metadata
Greg Shah wrote:
> That doc page suggests @_usertablestat-num@ is the table number. Perhaps this is some kind of un...
Eric Faulhaber
02:43 PM Feature #3814: more schema metadata
Greg Shah wrote:
> That doc page suggests @_usertablestat-num@ is the table number. Perhaps this is some kind of un...
Igor Skornyakov
02:33 PM Feature #3814: more schema metadata
That doc page suggests @_usertablestat-num@ is the table number. Perhaps this is some kind of unique number associat... Greg Shah
02:32 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> > What is the @_usertablestat-num@ field about?
>
> Is this a "...
Igor Skornyakov
02:31 PM Feature #3814: more schema metadata
Eric,
Yes, the table effectively holds counters, 4 for 4 different CRUD operations per user/table combination. At le...
Igor Skornyakov
02:27 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> What is the @_usertablestat-num@ field about?
Is this a "foreign key" of sorts to the @_...
Eric Faulhaber
02:21 PM Feature #3814: more schema metadata
Igor, to best answer you, please help me understand the purpose of these fields:... Eric Faulhaber
01:50 PM Feature #3814: more schema metadata
It is also possible to have the updater, but it will not try to persist statistics constantly but keep it in the in-m... Igor Skornyakov
01:34 PM Feature #3814: more schema metadata
Greg Shah wrote:
> Even if the overhead is minimized, the current approach wastes CPU cycles for a feature that is a...
Igor Skornyakov
01:16 PM Feature #3814: more schema metadata
Even if the overhead is minimized, the current approach wastes CPU cycles for a feature that is almost never used.
...
Greg Shah
12:07 PM Feature #3814: more schema metadata
Eric Faulhaber wrote:
> I don't know enough about the information you need to collect to answer this. This method ge...
Igor Skornyakov
11:48 AM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> I'm working now on the @_usertablestat@ VST support. This VST holds information about the C...
Eric Faulhaber
06:44 AM Feature #3814: more schema metadata
Greg Shah wrote:
> Is the @_usertablestat@ contents specific to the current user's session? If so, then it is impor...
Igor Skornyakov
06:29 AM Feature #3814: more schema metadata
Is the @_usertablestat@ contents specific to the current user's session? If so, then it is important to capture and ... Greg Shah
03:19 PM Bug #4071: FWD server stops allowing new web client logins after abend
Greg Shah wrote:
> > for interactive sessions, it should interrupt and wait for the Conversation thread to finish an...
Constantin Asofiei
08:07 AM Bug #4071: FWD server stops allowing new web client logins after abend
> for interactive sessions, it should interrupt and wait for the Conversation thread to finish and cleanup the contex... Greg Shah
05:05 AM Bug #4071: FWD server stops allowing new web client logins after abend
And there's one more case to consider for the 'unplanned' socket termination, for virtual sessions: if there is an ac... Constantin Asofiei
01:05 PM Feature #3813: misc DB features part deux
OK, then lets wait until 4011b is in trunk (and 3821c rebased) before we finish this last item. Greg Shah
01:01 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> So there are no pending properties changes in 3821c?
It looks like that. Please note that it w...
Igor Skornyakov
12:55 PM Feature #3813: misc DB features part deux
So there are no pending properties changes in 3821c? Greg Shah
12:09 PM Feature #3813: misc DB features part deux
Greg Shah wrote:
> I understand there will be some edits. Am I correct in my understanding that there are already o...
Igor Skornyakov
12:04 PM Feature #3813: misc DB features part deux
I understand there will be some edits. Am I correct in my understanding that there are already other such edits that... Greg Shah
11:56 AM Feature #3813: misc DB features part deux
Greg Shah wrote:
> We have other such property changes in 3821c, right? If you finish @BUFFER-FIELD:DECIMALS@ in 38...
Igor Skornyakov
10:59 AM Feature #3813: misc DB features part deux
> According to #3813-162, #3813-163, the only remaining issue is Built-In Function Usage in WHERE Clauses but there i... Greg Shah
08:34 AM Feature #3813: misc DB features part deux
Greg Shah wrote:
> What is left open in this task?
According to #3813-(162,163), the only remaining issue is @Bui...
Igor Skornyakov
08:12 AM Feature #3813: misc DB features part deux
What is left open in this task? Greg Shah
10:52 AM Feature #4613: add missing support for database user defined functions (UDF) if they are supporte...
Some items mentioned in #3813 should be handled as part of this task:
> +Built-In Function Usage in WHERE Clauses+...
Greg Shah
07:59 AM Support #4701: try to improve H2 transaction commit performance
Committed 4701a rev.11625 - added switch between shared and private temporary database. Adrian Lungu

08/12/2020

05:59 PM Bug #4071: FWD server stops allowing new web client logins after abend
I agree that all context cleanup for interactive sessions must be on the main Conversation thread.
For the virtual...
Constantin Asofiei
09:06 AM Bug #4071: FWD server stops allowing new web client logins after abend
I think we also need to exclude context-cleanup from happening on @RelatedThread@ instances. Such threads share the ... Greg Shah
09:01 AM Bug #4071: FWD server stops allowing new web client logins after abend
I think we need to consider if there is ever a scenario in which context cleanup is needed for reader/writer threads.... Greg Shah
03:27 PM Feature #3814: more schema metadata
I'm working now on the @_usertablestat@ VST support. This VST holds information about the CRUD operations. The corres... Igor Skornyakov
06:58 AM Feature #3814: more schema metadata
Greg Shah wrote:
> When will you get to a good stopping point?
Most likely today. Tomorrow at the latest.
Igor Skornyakov
06:35 AM Feature #3814: more schema metadata
> Maybe it makes send to do it only for the new ORM.
Yes, probably so. Get it to the point where everything is re...
Greg Shah
06:23 AM Feature #3814: more schema metadata
Greg Shah wrote:
> How quickly do you estimate that can you complete this work?
I plan to finish with the updater...
Igor Skornyakov
06:01 AM Feature #3814: more schema metadata
How quickly do you estimate that can you complete this work? Greg Shah
08:46 AM Support #4701: try to improve H2 transaction commit performance
Created branch 4701a and committed the changes regarding per-user temporary databases rev. 11624. Please review.
...
Adrian Lungu

08/11/2020

05:01 PM Feature #3814: more schema metadata
Yes, if that is how it works in the 4GL for a non-multi-tenant case. Greg Shah
04:47 PM Feature #3814: more schema metadata
Greg Shah wrote:
> > I do not know if we already have any support for the notion of tenant.
>
> No, we do not. W...
Igor Skornyakov
04:39 PM Feature #3814: more schema metadata
> I do not know if we already have any support for the notion of tenant.
No, we do not. We are not currently plan...
Greg Shah
02:30 PM Feature #3814: more schema metadata
As I can see the following fields are already supported, at least the "Minimal*" interfaces in the @ConnectTableUpdat... Igor Skornyakov

08/10/2020

05:11 PM Feature #3814: more schema metadata
Igor Skornyakov wrote:
> 3821c rev. 11449 does not compile
> [...]
Fixed in rev 11450.
Igor Skornyakov
05:06 PM Feature #3814: more schema metadata
Yes Greg Shah
03:28 PM Feature #3814: more schema metadata
3821c rev. 11449 does not compile... Igor Skornyakov
11:33 AM Support #4701: try to improve H2 transaction commit performance
This approach makes me a bit nervous.
Note that the @Database@ object is used as a key in a number of maps across ...
Eric Faulhaber
11:11 AM Support #4701: try to improve H2 transaction commit performance
@SecurityManager.getInstance().getSessionId()@ is what I needed.
Eric Faulhaber wrote:
> Can you help me underst...
Adrian Lungu
10:48 AM Support #4701: try to improve H2 transaction commit performance
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > You could use @SecurityManager.getInstance().getUserId()@ to ...
Eric Faulhaber
10:00 AM Support #4701: try to improve H2 transaction commit performance
Eric Faulhaber wrote:
> You could use @SecurityManager.getInstance().getUserId()@ to get a unique ID per user sessio...
Constantin Asofiei
09:56 AM Support #4701: try to improve H2 transaction commit performance
Can you help me understand the proposed "high" and "low" level implementations?
I guess we are really differentiat...
Eric Faulhaber
09:30 AM Support #4701: try to improve H2 transaction commit performance
By now, I delayed the initialization of the @_temp@ database. Until now, FWD was initializing the @_temp@ table at se... Adrian Lungu

08/09/2020

01:49 PM Feature #3814: more schema metadata
Added population of the @_Field@ table fields, described in #3814-188.
Committed to 3821c revision 11447.
Igor Skornyakov
09:22 AM Support #4701: try to improve H2 transaction commit performance
Recently I have finished building new FWD testcases based on #4701-42 (extracting SQL batches from @h2_performance@ t... Adrian Lungu

08/08/2020

06:59 AM Feature #3814: more schema metadata
It is interesting that for some system tables the @_Field@ table contains records for fields which are not shown in t... Igor Skornyakov

08/07/2020

05:52 PM Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Igor, please see the @TYPE_@ constants in @LegacyJavaAppserverApi@ - I think @_dtype@ is...
Igor Skornyakov
05:20 PM Feature #3814: more schema metadata
Igor, please see the @TYPE_@ constants in @LegacyJavaAppserverApi@ - I think @_dtype@ is the same. You can confirm t... Constantin Asofiei
05:10 PM Feature #3814: more schema metadata
Greg Shah wrote:
> Is @_field._dtype@ the same as the data-type list I've described in #3549-3 and #3549-4?
Greg,...
Igor Skornyakov
04:30 PM Feature #3814: more schema metadata
Is @_field._dtype@ the same as the data-type list I've described in #3549-3 and #3549-4? Greg Shah
04:22 PM Feature #3814: more schema metadata
Based on the analisys of the content of the @_Field@ table in the large customer database (12000+ records in this tab... Igor Skornyakov
09:49 AM Support #4701: try to improve H2 transaction commit performance
Please build the necessary changes. It would be best to implement this such that we can set a flag and choose "per-u... Greg Shah

08/06/2020

11:46 AM Support #4701: try to improve H2 transaction commit performance
Greg Shah wrote:
> What is the development effort needed to make this work? Is the meta database a problem?
At t...
Adrian Lungu
10:45 AM Support #4701: try to improve H2 transaction commit performance
Your results in #4843 (per-user "private" @_temp@ H2 instances vs the current "global" instance approach) are very en... Greg Shah

08/05/2020

12:50 PM Feature #3814: more schema metadata
Greg Shah wrote:
> Can you finish #3814-185 items 1-3 by Friday?
Yes, I think that it possible. If not, I will fini...
Igor Skornyakov
12:47 PM Feature #3814: more schema metadata
Can you finish #3814-185 items 1-3 by Friday?
> It is difficult to estimate the time which is required for impleme...
Greg Shah
12:42 PM Feature #3814: more schema metadata
Status summary update (see #3814-135)
# Adding of the mandatory meta-tables is enforced. Working now on handling som...
Igor Skornyakov
10:02 AM Support #4701: try to improve H2 transaction commit performance
The preliminary results reported by Apache JMeter are not very promising. However, note that the used tests are pure ... Adrian Lungu

08/03/2020

08:00 AM Support #4701: try to improve H2 transaction commit performance
Eric Faulhaber wrote:
> Adrian, as I understand it, your JMeter test environment can simulate heavy multi-user use, ...
Adrian Lungu

08/01/2020

05:54 PM Support #4701: try to improve H2 transaction commit performance
Adrian, as I understand it, your JMeter test environment can simulate heavy multi-user use, correct?
I would like ...
Eric Faulhaber

07/31/2020

11:31 AM Feature #4011: database/persistence layer performance improvements
Ovidiu, OK, I see that these are emitted at the @Table@ annotation for the DMO interface. Before that , we had code ... Constantin Asofiei
11:08 AM Feature #4011: database/persistence layer performance improvements
I tried to keep as much compatibility as I was aware when I added the new annotations and even added new attributes. ... Ovidiu Maxiniuc
10:52 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Have you encountered this necessity in customer code?
Yes. The previous support needs to ...
Constantin Asofiei
10:30 AM Feature #4011: database/persistence layer performance improvements
Constantin,
Have you encountered this necessity in customer code?
The problem might be more complicated than ad...
Ovidiu Maxiniuc
06:21 AM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> We are talking about two different types of 'attributes' of the temp-tables:
> * structur...
Constantin Asofiei

07/30/2020

03:50 PM Feature #4011: database/persistence layer performance improvements
Constantin,
I replaced the last conditional from the code you posted in note-791 with...
Ovidiu Maxiniuc
01:32 PM Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The problem with @BufferImpl.fill@ is not only in the code from 791 but in previous lines, ...
Eric Faulhaber
10:20 AM Feature #4011: database/persistence layer performance improvements
The problem with @BufferImpl.fill@ is not only in the code from 791 but in prevous lines, too.
# use of @dereference...
Ovidiu Maxiniuc

07/29/2020

05:19 PM Bug #4825: OutputTableHandleCopier dynamically defines destination temp-table
Constantin Asofiei wrote:
> Something else we could do is to force the DMO interface to be the one from the source t...
Eric Faulhaber
04:19 PM Bug #4825: OutputTableHandleCopier dynamically defines destination temp-table
Something else we could do is to force the DMO interface to be the one from the source temp-table (to avoid building ... Constantin Asofiei
02:36 PM Bug #4825: OutputTableHandleCopier dynamically defines destination temp-table
Eric, I understand your POV, but at the caller's side we have a @handle@ parameter, right? In this case, we need to c... Constantin Asofiei
02:24 PM Bug #4825: OutputTableHandleCopier dynamically defines destination temp-table
As I was debugging an API-based regression test, I noticed we end up quite often in this code in @OutputTableHandleCo... Eric Faulhaber
01:55 PM Bug #4825 (New): OutputTableHandleCopier dynamically defines destination temp-table
Eric Faulhaber
01:25 PM Feature #4011: database/persistence layer performance improvements
Ovidiu, see this test:... Constantin Asofiei
01:14 PM Feature #4011: database/persistence layer performance improvements
The validation has changed a bit. I need more input on this. What exactly is wrong with MERGE and REPLACE fill modes? Ovidiu Maxiniuc
01:08 PM Feature #4011: database/persistence layer performance improvements
This code in @BufferImpl.fill@:... Constantin Asofiei

07/28/2020

01:05 PM Feature #4055: optimize temp-table output parameter copying
@loose-copy-mode@ sounds like a case 4 in which the index mapping for the source/target pair is not calculated by fie... Greg Shah
12:58 PM Feature #4055: optimize temp-table output parameter copying
Greg Shah wrote:
> > There are the DATASET-related cases, for FILL and such - I haven't looked at how these can be i...
Constantin Asofiei
12:42 PM Feature #4055: optimize temp-table output parameter copying
> There are the DATASET-related cases, for FILL and such - I haven't looked at how these can be improved.
Do the D...
Greg Shah
11:52 AM Feature #4055: optimize temp-table output parameter copying
Greg Shah wrote:
> In regard to case 3, I know it is not possible with table parameters of methods, so I wonder if i...
Constantin Asofiei

07/27/2020

05:54 PM Feature #4055: optimize temp-table output parameter copying
Some thoughts about table copying. I know of at least 3 different copy scenarios:
# source and target tables are ...
Greg Shah
09:21 AM Support #4701: try to improve H2 transaction commit performance
I uploaded @fwd-h2-1.4.200-20200727.jar@ to @devsrv01:/tmp/@, which includes the patch mentioned in #4701-38. Adrian Lungu
09:14 AM Support #4701: try to improve H2 transaction commit performance
I found out that the transactional keyword was exploiting a vulnerability of constraints inside create table statemen... Adrian Lungu

07/25/2020

07:44 AM Support #4701: try to improve H2 transaction commit performance
Moved the @Timeout trying to lock table "SYS"@ topic from #4753 here.
# The exception can appear with different st...
Adrian Lungu

07/24/2020

01:50 PM Feature #4022: upgrade to a newer PostgreSQL release
Also, please update the FWD docs to make it more clear where we might put it by default. Greg Shah
01:22 PM Feature #4022: upgrade to a newer PostgreSQL release
Stanislav Lomany wrote:
> "Installation of PL/Java Base Support" documentation states that this file should be put _...
Constantin Asofiei
01:19 PM Feature #4022: upgrade to a newer PostgreSQL release
"Installation of PL/Java Base Support" documentation states that this file should be put _somewhere_ in a directory r... Stanislav Lomany
01:07 PM Feature #4022: upgrade to a newer PostgreSQL release
Stanislav Lomany wrote:
> The only question I have regarding installation is about this code from the customer's @bu...
Constantin Asofiei
01:06 PM Feature #4022: upgrade to a newer PostgreSQL release
The only question I have regarding installation is about this code from the customer's @build_db.xml@:... Stanislav Lomany
08:29 PM Feature #4022: upgrade to a newer PostgreSQL release
I've compared times for postgres 12.3 vs 9.5 and they're absolutely the same (in average). I've tested times for:
# ...
Stanislav Lomany

07/23/2020

01:52 PM Bug #4760 (Closed): new keywords added in H2 1.4.200
Eric Faulhaber
01:51 PM Bug #4760: new keywords added in H2 1.4.200
Eric Faulhaber wrote:
> Just looked over the changes and they seem fine. Is @_rowid_@ really a reserved keyword for ...
Constantin Asofiei
01:49 PM Bug #4760: new keywords added in H2 1.4.200
Just looked over the changes and they seem fine. Is @_rowid_@ really a reserved keyword for H2? Seems an odd one.
...
Eric Faulhaber
08:12 PM Feature #4022: upgrade to a newer PostgreSQL release
> Which version of PostgreSQL are you using?
12.3
> Were you able to leverage the pre-built PL/Java binaries?
I ...
Stanislav Lomany

07/22/2020

05:20 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Eric Faulhaber wrote:
> As I think about the addition of the multiplex ID to the L1 key, it occurs to me that we h...
Eric Faulhaber
05:19 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
As I think about the addition of the multiplex ID to the L1 key, it occurs to me that we have a potential memory leak... Eric Faulhaber
04:35 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Code review 4011b/11588:
Looks good. The @buffer.isTemporary()@ check can be eliminated in the @FFC.Key@ c'tor, si...
Eric Faulhaber
04:22 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
The new L1 key implemented in r11588. Please update. Ovidiu Maxiniuc
03:09 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
I think it makes sense to encapsulate the several behaviors of the FFC that are required to be different between temp... Eric Faulhaber
02:55 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Code review 4011b/11586:
Please see #4796-8, specifically the points about @updateLock@ and about leaking locks. T...
Eric Faulhaber
02:20 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Sorry, you are right. I will prepare a patch for this.
Ovidiu Maxiniuc
02:16 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Ovidiu Maxiniuc wrote:
> Actually no.
> The temp cache for tables-tables are context local. See @FastFindCache.getI...
Constantin Asofiei
02:14 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Actually no.
The cache objects for tables-tables are context local. See @FastFindCache.getInstance(boolean)@. Only t...
Ovidiu Maxiniuc
02:03 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Ovidiu, the fact that you use a @dmoUid@ is not OK for temp-tables. You need to include the multiplex, too.
A @de...
Constantin Asofiei
03:55 PM Feature #4022: upgrade to a newer PostgreSQL release
Which version of PostgreSQL are you using?
Were you able to leverage the pre-built PL/Java binaries?
Any issues...
Eric Faulhaber
03:40 PM Feature #4022: upgrade to a newer PostgreSQL release
Import of the customer's data is running. Stanislav Lomany
12:48 PM Feature #4022: upgrade to a newer PostgreSQL release
What is the status with v12.x? Eric Faulhaber
03:19 AM Feature #4011: database/persistence layer performance improvements
Rev 11584 resolves all but the 2f and 3f parts of the test case in #4011-633. Eric Faulhaber

07/21/2020

06:46 PM Feature #4022: upgrade to a newer PostgreSQL release
If 13 is beta, don't use it. Use the latest stable released build. Greg Shah
06:24 PM Feature #4022: upgrade to a newer PostgreSQL release
I'm not able to build the latest pljava 1.5.5 with postgresql 13 beta 2. There're compilation errors caused by incomp... Stanislav Lomany
05:55 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
My first instinct was to pull the argument resolution forward from @executeImpl@ to @execute@, but that is a lot of r... Eric Faulhaber
03:14 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
I found a new issue with FFC.
When we add a new result for the cache, use use the substitution array as part of th...
Ovidiu Maxiniuc
02:37 AM Bug #4796: locking regression in RAQ introduced with the FFC
Eric Faulhaber wrote:
> I had to make one change ...
This was committed as rev 11580.
Eric Faulhaber
02:13 AM Bug #4796: locking regression in RAQ introduced with the FFC
Code review 4011b/11579:
I had to make one change to get the @RecordLockContext@ directly from @RecordBuffer@, rat...
Eric Faulhaber

07/20/2020

05:15 PM Bug #4796: locking regression in RAQ introduced with the FFC
I committed revision 11579. I am unable to test at this moment with customer application. Ovidiu Maxiniuc
03:13 PM Bug #4796: locking regression in RAQ introduced with the FFC
It is unfortunate that the @RecordIdentifier@ used in the FF cache and session cache is not the same as can be used f... Eric Faulhaber
03:02 PM Bug #4796: locking regression in RAQ introduced with the FFC
Eric Faulhaber wrote:
> Do you see any holes in this approach?
No. In fact this is even simpler and straightforwa...
Ovidiu Maxiniuc
02:50 PM Bug #4796 (WIP): locking regression in RAQ introduced with the FFC
Eric Faulhaber
02:50 PM Bug #4796: locking regression in RAQ introduced with the FFC
Eric Faulhaber wrote:
> As I think more about this, we may need to use the cache result only for NO-LOCK requests,...
Eric Faulhaber
02:26 PM Bug #4796: locking regression in RAQ introduced with the FFC
Ovidiu Maxiniuc wrote:
> I copied the area which handles the locking, but I am trying to avoid code duplication u...
Eric Faulhaber
01:34 PM Bug #4796: locking regression in RAQ introduced with the FFC
h3. Initial issue:
When we have a FF cache hit, we do not honor the record lock request of the @FIND@. So, a requ...
Ovidiu Maxiniuc
01:28 PM Bug #4796 (WIP): locking regression in RAQ introduced with the FFC
Ovidiu Maxiniuc
03:00 PM Bug #4797: review Persistence.load, as called by RAQ.executeImpl
I think this method is not quite right in 4011b. It will load the record requested and get the lock type, but the @fo... Eric Faulhaber
02:57 PM Bug #4797 (New): review Persistence.load, as called by RAQ.executeImpl
Eric Faulhaber

07/19/2020

07:05 AM Feature #4011: database/persistence layer performance improvements
I committed rev 11575, which defers storing buffers whose scopes are opened in the @BufferManager.openBuffers@ list, ... Eric Faulhaber

07/17/2020

06:37 PM Support #4702: write temp-table performance test cases
I've added section how to run performance testcases from the new testcases project: https://proj.goldencode.com/proje... Stanislav Lomany
10:28 AM Support #4702: write temp-table performance test cases
The H2 performance testcases have been committed into the new testcases project as rev 668. They have been removed fr... Stanislav Lomany
04:42 PM Feature #4022: upgrade to a newer PostgreSQL release
At this point there is now a PostgreSQL 13.0. I don't think we should waste time on the intermediate versions. Greg Shah
04:22 PM Feature #4022: upgrade to a newer PostgreSQL release
Just a note that the last VM I created used PL/java 1.5.5 and PostgreSQL 10. Roger Borrello
04:16 PM Feature #4022 (WIP): upgrade to a newer PostgreSQL release
Eric Faulhaber

07/16/2020

04:23 PM Feature #4011: database/persistence layer performance improvements
I have committed 4011b/11564, which skips the index lookup in @RAQ.initialize@ if the table being queried has no lega... Eric Faulhaber
04:08 PM Feature #4011: database/persistence layer performance improvements
It seems to be that the message is misleading. If the record fails a unique index validation, that line is in fact un... Ovidiu Maxiniuc
03:49 PM Feature #4011: database/persistence layer performance improvements
Ovidiu, based on this comment in @Persister.update@:... Eric Faulhaber

07/15/2020

07:49 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Done. Committed as revision 4011b / 11561. Ovidiu Maxiniuc
07:43 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Looks good. Please merge if you're still there :-) Eric Faulhaber
07:30 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Eric Faulhaber wrote:
> I'm concerned synchronizing on the cache instance might be too coarse for an active system, ...
Ovidiu Maxiniuc
06:32 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Ovidiu Maxiniuc wrote:
> Eric,
> I committed r11563. It contains the last two issues: 3-level cache and synchroniza...
Eric Faulhaber
05:26 PM Feature #4033 (WIP): avoid query for FIND unique when the current record in the buffer would matc...
Eric,
I committed r11563. It contains the last two issues: 3-level cache and synchronization. I must admit I did not...
Ovidiu Maxiniuc
04:04 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
It is a bug in @SavepointManager.registerBlockHooks@. We should be differentiating between full and sub-transaction, ... Eric Faulhaber
03:55 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Eric Faulhaber wrote:
> I think if you already have the cache invalidation logic in @SavepointManager@, we should be...
Ovidiu Maxiniuc
03:34 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
@SavepointManager@ registers for the same master transaction rollback hook that is leading to this call, so it should... Eric Faulhaber
03:21 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Eric Faulhaber wrote:
> From where is @Session.rollback@ called in this case?...
Ovidiu Maxiniuc
03:17 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
From where is @Session.rollback@ called in this case? Eric Faulhaber
03:10 PM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Eric Faulhaber wrote:
> For the invalidation on UNDO, please see @SavepointManager$Block.rollback(Session)@.
In t...
Ovidiu Maxiniuc
10:51 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Greg Shah wrote:
> Now is the time to get this right. The 4GL deals with things at an index level and we should str...
Ovidiu Maxiniuc
10:31 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
Eric Faulhaber wrote:
> > * I had a thought or two on dirty database and whether those operation. As long as it do n...
Ovidiu Maxiniuc
06:23 AM Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...
> I think what we need to do is, just before the loop which rolls back the elements of the @changed@ set, collect the... Greg Shah
07:03 PM Feature #3814: more schema metadata
Greg Shah wrote:
> If it is just for analysis for this task, it is fine. I just want to be clear that we should not...
Igor Skornyakov
06:58 PM Feature #3814: more schema metadata
If it is just for analysis for this task, it is fine. I just want to be clear that we should not expect to do an imp... Greg Shah
06:09 PM Feature #3814: more schema metadata
Greg,
DMO annotations keeps the properties which are defined in the @.df@ file. They all are already added to the DM...
Igor Skornyakov
05:51 PM Feature #3814: more schema metadata
We don't want to import this data. Why spend time on this when we want the DMO annotations to hold everything needed... Greg Shah
05:32 PM Feature #3814: more schema metadata
The problems has multiple reasons.
1. The table dump from the Data Administrator skips some fields for the reason I ...
Igor Skornyakov
01:14 PM Feature #4055 (WIP): optimize temp-table output parameter copying
The changes are in 4011b rev 11559 Please review. Constantin Asofiei
06:05 AM Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric Faulhaber wrote:
> > > Why not create an array which ma...
Constantin Asofiei
 

Also available in: Atom