FWD » Core Development » Database

10/09/2020

05:20 PM Bug #4945: Optimize indexes for H2 dialect

Eric Faulhaber wrote:
> OK, as soon as you are comfortable with your FWD-only changes, please commit them.
Done, se... Ovidiu Maxiniuc

04:40 PM Bug #4945: Optimize indexes for H2 dialect

OK, as soon as you are comfortable with your FWD-only changes, please commit them.
As to the H2 changes, please DO... Eric Faulhaber

04:27 PM Bug #4945: Optimize indexes for H2 dialect

I will answer in reverse order.
> Is the first item in #4945-15 something that stands on its own?
Yes, I adjusted... Ovidiu Maxiniuc

03:53 PM Bug #4945: Optimize indexes for H2 dialect

Ovidiu, do you expect to have any update today? Is the first item in #4945-15 something that stands on its own? Eric Faulhaber

10/08/2020

06:36 PM Bug #4945: Optimize indexes for H2 dialect

Constantin Asofiei wrote:
> Without the @_multiplex@ first at the ORDER BY, the WHERE will choose a different index;... Ovidiu Maxiniuc

10/07/2020

01:43 AM Bug #4945: Optimize indexes for H2 dialect

Eric Faulhaber wrote:
> Constantin, do you remember why we moved @_multiplex@ to the front of index definitions and ... Constantin Asofiei

01:40 AM Bug #4945: Optimize indexes for H2 dialect

From my debugging of the AdaptiveQuery, in H2 the LIMIT is applied at the fetch, and not after re-sort, if the fetch ... Constantin Asofiei

10/06/2020

05:40 PM Bug #4945: Optimize indexes for H2 dialect

Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Are you talking about H2 changes here, or just FWD changes?
> T... Eric Faulhaber

05:27 PM Bug #4945: Optimize indexes for H2 dialect

When H2 selects the index @Select.getSortIndex()@ it looks for the first N components of the index to be a perfect ma... Ovidiu Maxiniuc

05:03 PM Bug #4945: Optimize indexes for H2 dialect

Constantin, do you remember why we moved @_multiplex@ to the front of index definitions and ORDER BY clauses? I origi... Eric Faulhaber

05:00 PM Bug #4945: Optimize indexes for H2 dialect

Eric Faulhaber wrote:
> Are you talking about H2 changes here, or just FWD changes?
There are two set of changes:
... Ovidiu Maxiniuc

04:17 PM Bug #4945: Optimize indexes for H2 dialect

Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > But will this mean H2 will select the index AND not re-sort afte... Eric Faulhaber

03:36 PM Bug #4945: Optimize indexes for H2 dialect

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > What happens if the index in 4GL is originally as @index ix1... Eric Faulhaber

01:20 PM Bug #4945: Optimize indexes for H2 dialect

Another issue I noticed while debugging: there was an extra index, having the @recid@ as unique component. It was mar... Ovidiu Maxiniuc

01:11 PM Bug #4945: Optimize indexes for H2 dialect

Eric Faulhaber wrote:
> But will this mean H2 will select the index AND not re-sort after the results are fetched? O... Ovidiu Maxiniuc

01:07 PM Bug #4945: Optimize indexes for H2 dialect

Constantin Asofiei wrote:
> What happens if the index in 4GL is originally as @index ix1 f1 desc@?
Evidently, the... Ovidiu Maxiniuc

12:27 PM Bug #4945: Optimize indexes for H2 dialect

Ovidiu Maxiniuc wrote:
> Right. I am adding now the @DESC@ direction to @_multiplex@ when FWD detects a reversed i... Eric Faulhaber

12:25 PM Bug #4945: Optimize indexes for H2 dialect

What happens if the index in 4GL is originally as @index ix1 f1 desc@? Constantin Asofiei

12:24 PM Bug #4945: Optimize indexes for H2 dialect

Constantin Asofiei wrote:
> I don't understand - what's the exact @ORDER BY@ clause? Do you mean there is an @ORDER... Ovidiu Maxiniuc

12:13 PM Bug #4945: Optimize indexes for H2 dialect

Ovidiu Maxiniuc wrote:
> * I discovered a bug in FWD related to sorting temp-tables queries. When a reversed order i... Constantin Asofiei

11:18 AM Bug #4945: Optimize indexes for H2 dialect

I took a look over H2 code that handles selection of the index (@Select.prepare()@)to be used for a query and the pos... Ovidiu Maxiniuc

10:54 AM Bug #4945: Optimize indexes for H2 dialect

We notice that sometimes the temp-table queries are slow because the matching reversed index is not selected by the q... Ovidiu Maxiniuc

10:48 AM Bug #4945 (Feedback): Optimize indexes for H2 dialect

Ovidiu Maxiniuc

10/05/2020

12:33 PM Feature #3814: more schema metadata

Greg Shah wrote:
> Igor: Are @_area@, @_filelist@ and @_tenant@ all "complete" (stubbed out with a basic functional ... Igor Skornyakov

12:01 PM Feature #3814: more schema metadata

Igor: Are @_area@, @_filelist@ and @_tenant@ all "complete" (stubbed out with a basic functional set of constant data... Greg Shah

10/02/2020

09:22 AM Bug #4940: Refactor the overlapping DmoMeta, RecordMeta, and PropertyMeta classes into a more rat...

The @DmoMeta@, @RecordMeta@, and @PropertyMeta@ do overlap in some measure. They need to be refactored / simplified. ... Ovidiu Maxiniuc

09:10 AM Bug #4940 (New): Refactor the overlapping DmoMeta, RecordMeta, and PropertyMeta classes into a mo...

Ovidiu Maxiniuc

07:22 AM Bug #4926 (Closed): "guest already exists with ? ?. (132)" error in Hotel GUI

Greg Shah

10/01/2020

01:16 PM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

I did not observe any regressions while testing hotel_gui and customer application so I decided to commit the update.... Ovidiu Maxiniuc

12:10 PM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

I do not see any issues with customer code.
The query that was exceeding 150ms is no more present in my statistics b... Ovidiu Maxiniuc

11:54 AM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

Ovidiu Maxiniuc wrote:
> I did not log any of this activity. I am thinking of doing it.
If you mean permanent log... Eric Faulhaber

11:45 AM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

I did not log any of this activity. I am thinking of doing it. Ovidiu Maxiniuc

11:44 AM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

I did not make any test regarding this, but it should work.
If we have @A.a1 = B.b1@ as join relation, the logic tha... Ovidiu Maxiniuc

11:33 AM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

Ovidiu Maxiniuc wrote:
> I attached the patch, if you have time, please review. If everything is fine, I will push... Eric Faulhaber

10:38 AM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

Eric,
I have an implementation which is quite stable for my test-case. I am putting it to the test against hotel_gui... Ovidiu Maxiniuc

12:52 PM Bug #4926: "guest already exists with ? ?. (132)" error in Hotel GUI

The issue is fixed in 3821c/r11641. Ovidiu Maxiniuc

09/29/2020

12:51 PM Bug #4931: possible ProgressiveResults performance improvement

@AdaptiveQuery@ uses @ProgressiveResults@ internally to fetch a progressively larger set of query results. The origin... Eric Faulhaber

12:30 PM Bug #4931 (New): possible ProgressiveResults performance improvement

Eric Faulhaber

10:57 AM Support #4928: rewrite FieldReference to use lambdas instead of reflection

At runtime we generate implementation classes to back the DMO interfaces. All of these classes have existing methods... Greg Shah

09:49 AM Support #4928 (New): rewrite FieldReference to use lambdas instead of reflection

Greg Shah

12:43 AM Bug #4926: "guest already exists with ? ?. (132)" error in Hotel GUI

Conversation via email:
---
>> Ovidiu Maxiniuc wrote:
>>>
>>> I am investigating the ** guest already exists ... Eric Faulhaber

11:57 PM Bug #4926 (Closed): "guest already exists with ? ?. (132)" error in Hotel GUI

Eric Faulhaber

09/27/2020

04:09 PM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

This fix is intended only for the case where we have sort clauses for more than one table concatenated together, and ... Eric Faulhaber

03:52 PM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

Something to share about my investigations with H2 - if the chosen index didn't match the ORDER BY clause, then H2 wi... Constantin Asofiei

03:15 PM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

I initially thought there would be an @AbstractJoin@ object in the second query component we could use to analyze the... Eric Faulhaber

03:08 PM Bug #4917: eliminate redundant ORDER BY elements in multi-table queries

We have found that in certain cases (e.g., optimized @CompoundQuery@), multi-table queries are generated with ORDER B... Eric Faulhaber

02:55 PM Bug #4917 (New): eliminate redundant ORDER BY elements in multi-table queries

Eric Faulhaber

09/25/2020

07:09 AM Feature #4055: optimize temp-table output parameter copying

Adrian Lungu wrote:
> Unfortunately, almost every member of @RecordBuffer@ should be retrieved through getters in or... Constantin Asofiei

06:38 AM Feature #4055: optimize temp-table output parameter copying

Constantin, the testcases work now. Unfortunately, almost every member of @RecordBuffer@ should be retrieved through ... Adrian Lungu

09/24/2020

01:59 PM Feature #4055: optimize temp-table output parameter copying

Adrian, I've backed out my ArgumentBuffer change in 3821c rev 11577 - the solution was to use getters for RecordBuffe... Constantin Asofiei

08:24 AM Feature #4055: optimize temp-table output parameter copying

Ovidiu Maxiniuc wrote:
> Review of 3821c rev 11565.
>
> The code looks good to me. I cannot say I fully get all o... Constantin Asofiei

09/23/2020

07:48 PM Feature #4055: optimize temp-table output parameter copying

Review of 3821c rev 11565.
The code looks good to me. I cannot say I fully get all of it but I did a double pass o... Ovidiu Maxiniuc

06:36 AM Feature #4055: optimize temp-table output parameter copying

Adrian, thanks for the explanation. We can't make the @buffer()@ and @definition()@ methods non-final, as this will ... Constantin Asofiei

05:01 AM Feature #4055: optimize temp-table output parameter copying

Constantin, the @RecordBuffer$ArgumentBuffer@ seems to be broken - the use of parameter buffers in queries was result... Adrian Lungu

09/22/2020

06:33 PM Feature #4055: optimize temp-table output parameter copying

3821c rev 11565 contains another pass at improving the 'field-by-field' copy. @RecordBuffer$DatumAccess@ was enhance... Constantin Asofiei

09/21/2020

03:43 PM Feature #4055: optimize temp-table output parameter copying

There is a bug in dataset-handle parameter copy, when there is a before-table, too - the before-table DMO iface (back... Constantin Asofiei

01:51 PM Feature #4055: optimize temp-table output parameter copying

I have some changes which enhance @RecordBuffer$DatumAccess@ to provide more data (like the PropertyMeta, Method inst... Constantin Asofiei

09:36 AM Support #4701: try to improve H2 transaction commit performance

In @directory.xml@, the following empty container node should be added (usually right before the database specific co... Adrian Lungu

09/20/2020

03:51 PM Support #4701: try to improve H2 transaction commit performance

Adrian: Please document the configuration changes to enable the separate database mode. Greg Shah

09/19/2020

07:16 AM Support #4701: try to improve H2 transaction commit performance

Probably the branch was not bound. I did the commit now as revision 11553.
Adrian Lungu

09/18/2020

02:33 PM Support #4701: try to improve H2 transaction commit performance

Adrian Lungu wrote:
> Done. Committed in 3821c as revision 11549.
Adrian, I don't see your commit in 3821c. 11549... Eric Faulhaber

07:14 AM Support #4701: try to improve H2 transaction commit performance

Done. Committed in 3821c as revision 11549. Adrian Lungu

09/17/2020

04:52 PM Feature #4011: database/persistence layer performance improvements

Roger Borrello wrote:
> Is this a safe setting to add into existing projects? In other words, is there a downside ... Eric Faulhaber

04:38 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> It is *disabled* by default (meaning normal 4GL behavior: temp-tables are undoable unless de... Roger Borrello

03:58 PM Feature #4011: database/persistence layer performance improvements

The performance enhancement to force NO-UNDO mode for all temp-tables (regardless of how they were defined) is implem... Eric Faulhaber

02:50 PM Support #4701: try to improve H2 transaction commit performance

Adrian: Go ahead and merge into 3821c. If there are any special requirements for rebuilding/deployment, please notif... Greg Shah

01:36 PM Support #4701: try to improve H2 transaction commit performance

Adrian, thanks for the explanations. Greg, I am good with the update going into 3821c. Eric Faulhaber

09/16/2020

05:16 AM Support #4701: try to improve H2 transaction commit performance

Just rebased 4701a using 3821c. Adrian Lungu

03:36 AM Support #4701: try to improve H2 transaction commit performance

Eric Faulhaber wrote:
> Code review 4701a, rev 11624-11627:
>
> This review is for the private vs. shared temp-ta... Adrian Lungu

09/15/2020

07:24 PM Support #4701: try to improve H2 transaction commit performance

Code review 4701a, rev 11624-11627:
This review is for the private vs. shared temp-table database implementation. ... Eric Faulhaber

09/14/2020

05:53 AM Support #4701: try to improve H2 transaction commit performance

4701a is independent upon the H2 version. Adrian Lungu

05:51 AM Support #4701: try to improve H2 transaction commit performance

Does this depend upon a new version of H2? Greg Shah

05:07 AM Support #4701: try to improve H2 transaction commit performance

I find 4701a safe enough. The major change is the new private vs shared temporary database. Using a shared temporary ... Adrian Lungu

09/13/2020

11:13 AM Support #4701: try to improve H2 transaction commit performance

How risky is 4701a? Greg Shah

09/10/2020

05:58 AM Feature #3574: finish implementation of temp-table XML support

Conversion and runtime stubs for @SERIALIZE-ROW()@ method are in 3821c rev 11512 Constantin Asofiei