Project

General

Profile

Activity

From 12/06/2020 to 01/04/2021

01/04/2021

08:32 AM Feature #1587: implement full support for word indexes
In addition to #1587-190.
After enabling debug mode I in the trace file that @H2@ inserts and removes the same recor...
Igor Skornyakov
07:20 AM Feature #1587: implement full support for word indexes
I've encountered the following problem with @H2@ trigger when I try to insert multiple rows to the word table:
* If ...
Igor Skornyakov
08:06 AM Feature #3958: BUFFER-COPY optimization
I noticed something off in the current @BaseRecord.setAllDatum()@ implementation. This is used, according to #3958-7,... Adrian Lungu

12/30/2020

02:58 PM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> FWD H2 databases are created with the "p2jspi.jar":/projects/p2j/wiki/Application_Server_Installa...
Igor Skornyakov
01:53 PM Feature #1587: implement full support for word indexes
FWD H2 databases are created with the "p2jspi.jar":/projects/p2j/wiki/Application_Server_Installation#Text-Collator p... Greg Shah
12:47 PM Feature #1587: implement full support for word indexes
I've encountered a strange error trying to connect to FWD H2 database with my favorite database client @dbeaver@. I'v... Igor Skornyakov

12/29/2020

05:00 PM Bug #5056 (WIP): Temp-tables and unique indexes
I continued with investigation of the issue. The @validateMaybeFlush()@ uses @BaseRecord.getUnvalidatedIndices(int)@ ... Ovidiu Maxiniuc
03:36 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > On the other side, I understand that we use a customized ver...
Igor Skornyakov
03:21 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> On the other side, I understand that we use a customized version of H2. Maybe it is the r...
Eric Faulhaber
03:13 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> I believe FWD will compile without the H2 jar (though I have not tried recently). So, I do n...
Igor Skornyakov
03:08 PM Feature #1587: implement full support for word indexes
I believe FWD will compile without the H2 jar (though I have not tried recently). So, I do not think we already have ... Eric Faulhaber
08:20 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> We already have hard coded dependencies on H2. I will let Eric evaluate if the new dependencies ...
Igor Skornyakov
08:14 AM Feature #1587: implement full support for word indexes
> I understand that to implement triggers for H2 one has to implement Java classes that depend on H2 API.
> What is ...
Greg Shah
06:47 AM Feature #1587: implement full support for word indexes
I understand that to implement triggers for H2 one has to implement Java classes that depend on H2 API.
What is the ...
Igor Skornyakov

12/25/2020

07:52 AM Feature #1587: implement full support for word indexes
Fixed issues mentioned in the code review (#1587-160) except the message about word indexes support.
Committed to 15...
Igor Skornyakov
04:29 AM Feature #1587: implement full support for word indexes
Branch 1587b was rebased to 3821c revision 11888. Pushed up to revision 11904. Igor Skornyakov

12/24/2020

04:34 PM Feature #1587: implement full support for word indexes
Finished word tables' population on import for PostgreSQL.
Committed to 1587b revision 11900.
All objects related t...
Igor Skornyakov
03:34 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> If, at the time the @p2o.xml@ ruleset runs, you have the name calculated and stored in a var...
Igor Skornyakov

12/23/2020

06:13 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Need to add "wordtablename" annotation to the word index AST in the .p2o file on conversion...
Eric Faulhaber
05:22 PM Feature #1587: implement full support for word indexes
Need to add "wordtablename" annotation to the word index AST in the .p2o file on conversion.
Will highly appreciate ...
Igor Skornyakov
04:49 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> @BaseRecord.getData(PropertyMapper)@ returns the entire data array for the record, not for a...
Igor Skornyakov
04:43 PM Feature #1587: implement full support for word indexes
@BaseRecord.getData(PropertyMapper)@ returns the entire data array for the record, not for any particular field. See ... Eric Faulhaber
03:56 PM Feature #1587: implement full support for word indexes
I've noticed that @dmo.getData(PropertyMapper)@ returns an array of length 2 for the field with word index where the ... Igor Skornyakov
03:18 PM Feature #1587: implement full support for word indexes
I think that it is sufficient to add a lookup of @PropertyMapper@ by property name to the @RecordLoader@. This will b... Igor Skornyakov
03:08 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMa...
Eric Faulhaber
02:09 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMapper)@. You probably will ne...
Igor Skornyakov
02:02 PM Feature #1587: implement full support for word indexes
See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMapper)@. You probably will need to do some refactoring... Eric Faulhaber
01:27 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > What is the best way to retrieve a field value by the field name...
Igor Skornyakov
01:22 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> What is the best way to retrieve a field value by the field name from the @BaseRecord@ inst...
Eric Faulhaber
01:08 PM Feature #1587: implement full support for word indexes
What is the best way to retrieve a field value by the field name from the @BaseRecord@ instance?
Thank you.
Igor Skornyakov
12:56 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > Across all changed files, please remove the revision numbers ...
Igor Skornyakov
12:55 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Currently, the H2 dialect specifies that the CONTAINS UDF should be used, and has a "TODO im...
Igor Skornyakov
12:12 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Across all changed files, please remove the revision numbers from the file header entries....
Eric Faulhaber
12:01 PM Feature #1587: implement full support for word indexes
Code review 1587b/11898:
Nice work, overall. Some questions/comments...
Currently, the H2 dialect specifies tha...
Eric Faulhaber
09:29 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> Does the server startup still report @(com.goldencode.p2j.persist.orm.RecordMeta:WARNING) Word in...
Igor Skornyakov
08:49 AM Feature #1587: implement full support for word indexes
Does the server startup still report @(com.goldencode.p2j.persist.orm.RecordMeta:WARNING) Word indices are not suppor... Greg Shah
07:02 PM Bug #5056: Temp-tables and unique indexes
Ovidiu Maxiniuc wrote:
> My problem is that a temp-table keeps accumulating newly-created 'validated' records whic...
Eric Faulhaber

12/22/2020

01:26 PM Bug #5056: Temp-tables and unique indexes
This is a discussion started by email.
On 12/21/20 6:50 PM, Ovidiu Maxiniuc wrote:
> Eric,
>
> Do you recall w...
Ovidiu Maxiniuc
01:19 PM Bug #5056 (Closed): Temp-tables and unique indexes
Ovidiu Maxiniuc

12/21/2020

02:30 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor, is there a way I can test this new word index implementation, without having to re-con...
Igor Skornyakov
02:14 PM Feature #1587: implement full support for word indexes
Igor, is there a way I can test this new word index implementation, without having to re-convert a large application?... Eric Faulhaber
08:13 AM Feature #1587: implement full support for word indexes
Branch 1587b was rebased to 3831c revision 11884. Pushed up to revision 11898. Igor Skornyakov
11:43 AM Support #3871: determine how to change codepages/locales during import
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin, do you remember what was going wrong with this se...
Igor Skornyakov
11:37 AM Support #3871: determine how to change codepages/locales during import
Eric Faulhaber wrote:
> Constantin, do you remember what was going wrong with this setting? I recall that you report...
Constantin Asofiei
11:31 AM Support #3871: determine how to change codepages/locales during import
Igor Skornyakov wrote:
> BTW: I think we can speed up the import if we will use @PreparedStatement.addBatch@ and @...
Eric Faulhaber
07:59 AM Support #3871: determine how to change codepages/locales during import
Greg Shah wrote:
> OK, I understand. We need Eric to complete the code review of #1587 first.
Got it, thank you.
Igor Skornyakov
07:57 AM Support #3871: determine how to change codepages/locales during import
OK, I understand. We need Eric to complete the code review of #1587 first. Greg Shah
07:44 AM Support #3871: determine how to change codepages/locales during import
Greg Shah wrote:
> I prefer for these changes to go into 3821c directly. Is there a reason they need to be build on...
Igor Skornyakov
07:22 AM Support #3871: determine how to change codepages/locales during import
I prefer for these changes to go into 3821c directly. Is there a reason they need to be build on top of 1587b? Greg Shah

12/20/2020

12:14 PM Support #3871: determine how to change codepages/locales during import
Implemented @CPSTREAM@ support on import.
Committed to 1587b rev 11873.
Re-working of the word tables' import is st...
Igor Skornyakov

12/18/2020

01:14 PM Support #3871: determine how to change codepages/locales during import
Yes, go ahead. Greg Shah
10:59 AM Support #3871: determine how to change codepages/locales during import
Since I have to get familiar with import, maybe be I will add the population of the word tables with postponed creati... Igor Skornyakov

12/17/2020

04:07 PM Support #3871: determine how to change codepages/locales during import
> I think I've seen that for some .d files the import reports that the footer was not found. In this case we can eith... Greg Shah
03:57 PM Support #3871: determine how to change codepages/locales during import
Greg Shah wrote:
> I think that honoring that value is the easist way to implement my approach. We have to have tha...
Igor Skornyakov
03:47 PM Support #3871: determine how to change codepages/locales during import
I think that honoring that value is the easist way to implement my approach. We have to have that value as input. W... Greg Shah
03:38 PM Support #3871: determine how to change codepages/locales during import
Greg Shah wrote:
> > However, at this moment I do not see how the CPSTRIM value is used in the ImportWorker. It is u...
Igor Skornyakov
03:31 PM Support #3871: determine how to change codepages/locales during import
> However, at this moment I do not see how the CPSTRIM value is used in the ImportWorker. It is used in the creation ... Greg Shah
02:38 PM Support #3871: determine how to change codepages/locales during import
Greg Shah wrote:
> * We use our 4GL compatible stream processing to read the encoded @.d@ files during import. Thes...
Igor Skornyakov
02:10 PM Support #3871: determine how to change codepages/locales during import
* We use our 4GL compatible stream processing to read the encoded @.d@ files during import. These are the @com.golde... Greg Shah
01:20 PM Support #3871: determine how to change codepages/locales during import
Sorry, I'm confused. In my understanding, all we need is to use @CODEPAGE-CONVERT@ with @UTF-8@ as the target codepag... Igor Skornyakov

12/16/2020

02:37 PM Feature #4055: optimize temp-table output parameter copying
Committed in 3821c/rev. 11881 support for fast loose-copy. Done some testing and it seems that loose-copy-mode now se... Adrian Lungu

12/15/2020

01:57 PM Feature #4055: optimize temp-table output parameter copying
Ovidiu Maxiniuc wrote:
> Yes, this is exactly the scenario where I encountered the issue. However, I am not familiar...
Adrian Lungu
12:24 PM Feature #4055: optimize temp-table output parameter copying
Please note: currently, the work of record initialization to default values is done in @BaseRecord.initialize@, which... Eric Faulhaber
09:54 AM Feature #4055: optimize temp-table output parameter copying
Adrian Lungu wrote:
> Ovidiu, I see the problem. This can be appear only when @loose-copy-mode@ is on (so we have a ...
Ovidiu Maxiniuc
05:58 AM Feature #4055: optimize temp-table output parameter copying
Ovidiu, I see the problem. This can be appear only when @loose-copy-mode@ is on (so we have a possible restricted fie... Adrian Lungu
08:54 PM Feature #4055: optimize temp-table output parameter copying
There is a flaw in @FastCopyHelper.java@: when a copy operation is executed using a restricted field mapping, the unm... Ovidiu Maxiniuc

12/10/2020

01:37 PM Feature #1587: implement full support for word indexes
I've finally decided to augment @MetadataManager@ with word tables support. So the implementation for PostgreSQL is e... Igor Skornyakov
05:53 AM Feature #1587: implement full support for word indexes
Branch 1587b was rebased to 3821c revision 11860.
Pushed up to revision 11870.
Igor Skornyakov
05:47 AM Feature #1587: implement full support for word indexes
Short names' generation committed to 1587b revision 11849.
Working on using generated names in @FqlToSqlConverter@
Igor Skornyakov
12:57 PM Bug #5030: xfer dataset test issues
Ovidiu Maxiniuc wrote:
> > [[https://documentation.progress.com/output/ua/OpenEdge_latest]]
> Yes, that's it. I t...
Marian Edu
12:16 PM Bug #5030: xfer dataset test issues
Marian Edu wrote:
> > BTW, is there a public documentation on OE 12.X? I could not find it, I am always redirected t...
Ovidiu Maxiniuc
08:53 AM Bug #5030: xfer dataset test issues
> I am a pit puzzled now. What is our OE version target to match? Will we support multiple versions? I know there was... Greg Shah
02:46 AM Bug #5030: xfer dataset test issues
Ovidiu Maxiniuc wrote:
> Marian Edu wrote:
> > Well, nothing is perfect... in practice no one it doing that though ...
Marian Edu
11:13 AM Feature #3958: BUFFER-COPY optimization
I committed 3821c/rev. 11862 changes to @DMOSignatureHelper@ which can now compute explicit signatures. The modificat... Adrian Lungu

12/09/2020

06:39 PM Bug #5030 (WIP): xfer dataset test issues
I have another issue. In @dataset/dynamic/methods/copy_dataset.p@ we have:... Ovidiu Maxiniuc
06:09 PM Bug #5030: xfer dataset test issues
Marian Edu wrote:
> Well, nothing is perfect... in practice no one it doing that though so I wouldn't make it such a...
Ovidiu Maxiniuc
03:48 AM Bug #5030: xfer dataset test issues
Ovidiu Maxiniuc wrote:
> Here is one example I used for observing the @REPOSITION@ attribute:
> [...]
>
> This w...
Marian Edu
07:40 PM Bug #5030: xfer dataset test issues
Marian Edu wrote:
> The @AUTO-DELETE@ attribute only has a role when a dynamic dataset is deleted, nothing to do wit...
Ovidiu Maxiniuc
07:37 PM Bug #5030: xfer dataset test issues
Here is one example I used for observing the @REPOSITION@ attribute:... Ovidiu Maxiniuc
03:24 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> What about the Java annotation in the DMO interface? My point is, I just want one name store...
Igor Skornyakov
03:21 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Please do make the change. Even if we don't simplify the logic m...
Eric Faulhaber
03:05 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Please do make the change. Even if we don't simplify the logic much, we want to keep the con...
Igor Skornyakov
03:01 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> If I understand correctly, you need to map the DMOs (@DmoMeta@ most likely) using SQL names...
Igor Skornyakov
02:59 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> At this moment I do not use the _least-common-denominator approach for the names_, but it c...
Eric Faulhaber
02:56 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> I thought we use the _least-common-denominator approach for the names_ (see Eric's entry #1...
Igor Skornyakov
02:41 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Well, I think I've found a 'right' place to add information about word table names (there c...
Ovidiu Maxiniuc
02:32 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I see the following problem with this approach. I understand that @NameConverterWorker@ is ...
Ovidiu Maxiniuc
02:20 PM Feature #1587: implement full support for word indexes
Well, I think I've found a 'right' place to add information about word table names (there can be different names for ... Igor Skornyakov
05:29 AM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Yes, the information is mainly correct. I would look back one step, looking for the @name.c...
Igor Skornyakov
04:15 AM Feature #3958: BUFFER-COPY optimization
Added a new signature for each @DmoMeta@ - see #4055-80, #4055-81. The first one I will refer to as "quick signature"... Adrian Lungu

12/08/2020

05:10 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Yes, the information is mainly correct. I would look back one step, looking for the @name.c...
Igor Skornyakov
05:01 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Ovidiu: please reality check my statements and file references above, in case my recollectio...
Ovidiu Maxiniuc
04:58 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> OK, I think this is the place the Java annotations are actually written into the Java AST wh...
Igor Skornyakov
02:44 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > See the @createCompileUnit@ TRPL function in @rules/schema/dmo_c...
Eric Faulhaber
02:35 AM Bug #5030: xfer dataset test issues
Ovidiu Maxiniuc wrote:
> A second issue is related to recently added @AUTO-DELETE@ attribute. I am see why is an aut...
Marian Edu
02:17 AM Bug #5030: xfer dataset test issues
Ovidiu Maxiniuc wrote:
> A first question is about the dataset relations. Normally, there can be at most @n - 1@ ins...
Marian Edu
07:42 PM Feature #4397: add database attrs, methods and options
I encountered two more issues which were probably added with 4011 and slipped unnoticed until now.
* the first is ...
Ovidiu Maxiniuc

12/07/2020

05:21 PM Bug #5030: xfer dataset test issues
A second issue is related to recently added @AUTO-DELETE@ attribute. I am see why is an auto-delete dynamic buffer no... Ovidiu Maxiniuc
04:40 PM Bug #5030: xfer dataset test issues
A first question is about the dataset relations. Normally, there can be at most @n - 1@ instances of them, but if som... Ovidiu Maxiniuc
04:23 PM Bug #5030: xfer dataset test issues
I have started recently to run the testsets stored on xref repository in order to fine-tune the dataset-related attri... Ovidiu Maxiniuc
04:00 PM Bug #5030 (WIP): xfer dataset test issues
Ovidiu Maxiniuc
04:58 PM Bug #5013 (Test): Collision of java names with SQL keywords
Greg Shah
03:35 PM Bug #5013: Collision of java names with SQL keywords
This issue should be fixed in r11866/4397a (11/26/20). Ovidiu Maxiniuc
02:35 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> See the @createCompileUnit@ TRPL function in @rules/schema/dmo_common.rules@ for examples of...
Igor Skornyakov
02:33 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> The problem is that at this moment I do not understand how to add annotation from the @DDLG...
Eric Faulhaber
01:49 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Ovidiu, please look at @dmo_common.rules@. Based on Igor's change, it looks like we were omi...
Ovidiu Maxiniuc
02:42 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> For things like this, we usually compute the value at schema conversion time and write it as...
Igor Skornyakov
11:36 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I've re-worked the code to address Eric's comments (#1587-128).
> There is a problem with ...
Eric Faulhaber

12/06/2020

03:38 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I've re-worked the code to address Eric's comments (#1587-128).
Committed to 1587b revisio...
Igor Skornyakov
03:37 PM Feature #1587: implement full support for word indexes
I've re-worked the code to address Eric's comments (#1587-128).
There is a problem with renaming word tables - we n...
Igor Skornyakov
02:58 AM Feature #1587: implement full support for word indexes
Sorry, I forgot to add. At this moment for the dialects other than PostgreSQL the @CONTIANS@ UDF will be still used. Igor Skornyakov
02:51 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> * I am a bit confused by the @words@ UDF. It is added as a PL/Java function in @Functions@ a...
Igor Skornyakov
 

Also available in: Atom