Activity
From 12/13/2020 to 01/11/2021
01/12/2021
- 07:37 PM Feature #4397: add database attrs, methods and options
- Eric Faulhaber wrote:
> I'm reviewing 4397a/11924. Since it's so big, I'm not going to present a single review of al...
01/11/2021
- 06:51 PM Feature #1587: implement full support for word indexes
- There are some very similar messages posted in #3871.
However, "this article":https://knowledgebase.progress.com/a... - 02:54 PM Feature #1587: implement full support for word indexes
- In the import of a large customer database I've got 4 errors for a single table on populating the related word table:...
- 07:34 AM Feature #1587: implement full support for word indexes
- Yes. In fact I think it must be fixed at runtime because otherwise we would not generate a warning at the same place...
- 06:36 AM Feature #1587: implement full support for word indexes
- Is it OK if the discrepancy described in #1587-226 regarding subscript on array field in CONTAINS phrase will be fixe...
- 06:27 AM Feature #1587: implement full support for word indexes
- > I mean @extent_field_name CONTAINS something@. I understand that (@extent_field_name[index_expr] CONTAINS something...
- 07:31 AM Feature #4397: add database attrs, methods and options
- > If you want we can write some more tests to see how the dataset behaves when this odd situation occurs but imho thi...
- 04:10 AM Feature #4397: add database attrs, methods and options
- I'm reviewing 4397a/11924. Since it's so big, I'm not going to present a single review of all the changes, but rather...
- 02:11 AM Feature #4397: add database attrs, methods and options
- Greg Shah wrote:
> Marian: What is your opinion of this bug?
That is definitively an undiscovered bug, no one pro... - 02:27 AM Bug #5030: xfer dataset test issues
- Ovidiu Maxiniuc wrote:
> According to my old and new ABL reference manual and OpenEdge "online documentation":https:...
01/10/2021
- 10:12 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> Igor Skornyakov wrote:
> > It seems that in 4GL the value of the @CONTAINS@ operator for the ext... - 09:54 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> It seems that in 4GL the value of the @CONTAINS@ operator for the extent field is an OR of ... - 05:32 AM Feature #1587: implement full support for word indexes
- It seems that in 4GL the value of the @CONTAINS@ operator for the extent field is an OR of @CONTAINS@ value for all i...
- 05:24 AM Feature #1587: implement full support for word indexes
- BTW: the @CONTAINS@ operator support based on UDF is also incorrect. The generated SQL statement still contains (for ...
- 03:55 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > The import of the large customer database finished OK. However,...
01/09/2021
- 05:49 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> The import of the large customer database finished OK. However, I see in the log multiple s... - 04:24 AM Feature #1587: implement full support for word indexes
- The import of the large customer database finished OK. However, I see in the log multiple strange errors related to t...
01/08/2021
- 03:54 PM Support #3871: determine how to change codepages/locales during import
- Eric Faulhaber wrote:
> Are the code page changes in any way dependent upon the other changes unique to branch 1587b... - 03:33 PM Support #3871: determine how to change codepages/locales during import
- Are the code page changes in any way dependent upon the other changes unique to branch 1587b? If not, I would suggest...
- 01:16 PM Support #3871: determine how to change codepages/locales during import
- My changes for the codepage support on the database import seem to be not 100% correct - they prevent the normal impo...
- 11:12 AM Support #3871: determine how to change codepages/locales during import
- My changes seem to cause error on import the customer database:...
- 11:27 AM Feature #1587: implement full support for word indexes
- The branch 1587b was rebased to 3821c revision 11901.
Pushed up to revision 11920. - 10:30 AM Bug #5072: exception loading _user meta table
- There is this exception in FWD when trying to load the @_user@ meta table:...
- 10:27 AM Bug #5072 (New): exception loading _user meta table
01/07/2021
- 05:41 PM Bug #5030: xfer dataset test issues
- Marian,
I was re-running the test-sets again when I encountered the following issue: the same method responds in app... - 03:34 PM Feature #4397: add database attrs, methods and options
- Actually, never mind. I'll just do a fresh checkout.
- 03:33 PM Feature #4397: add database attrs, methods and options
- Ovidiu, I've updated then reverted (to adjust for an apparent rebase since my last update) my older checkout of 4397a...
- 03:03 PM Feature #4397: add database attrs, methods and options
- Greg Shah wrote:
> My initial reaction is that we probably should fix this. Can we potentially use a @Set@ to detec... - 02:00 PM Feature #4397: add database attrs, methods and options
- > At this moment all of the functionality specified in the first notes of this task is present in branch 4397a (lates...
- 11:46 AM Feature #4397: add database attrs, methods and options
- Greg Shah wrote:
> Is it correct that all of the functionality needed for this task is complete in 4397a?
>
> Whe... - 11:06 AM Feature #4397: add database attrs, methods and options
- Is it correct that all of the functionality needed for this task is complete in 4397a?
When do you estimate comple... - 03:20 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> Where is your @testcases@ bound to?... - 03:15 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> This is really strange:
> [...]
Where is your @testcases@ bound to?
> I see. Thank you... - 03:01 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > Sorry, I meant @build_db.xml@
> Nope. @find /opt/testcases/ -i... - 02:45 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Sorry, I meant @build_db.xml@
Nope. @find /opt/testcases/ -iname build_db.xml@ still canno... - 02:36 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Actually, there is no need for a full reconversion. Only the database support is required (... - 02:27 PM Feature #1587: implement full support for word indexes
- Actually, there is no need for a full reconversion. Only the database support is required (ddls and p2o), so running ...
- 02:25 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> > I'm not sure this exists. Ovidiu?
> I cannot find any @import_db.xml@ in @xfer@ project.... - 02:19 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> I think that the conversion and import will take quite some time, right? These are just long run... - 02:04 PM Feature #1587: implement full support for word indexes
- > > OK, please go ahead with such a test. If the results are good, then the changes can be merged back into 3821c.
... - 02:00 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/... - 01:58 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> OK, please go ahead with such a test. If the results are good, then the changes can be merged ba... - 01:31 PM Feature #1587: implement full support for word indexes
- OK, please go ahead with such a test. If the results are good, then the changes can be merged back into 3821c.
- 01:20 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> Has this been tested with any of the large customer applications which we are working on right no... - 01:11 PM Feature #1587: implement full support for word indexes
- Has this been tested with any of the large customer applications which we are working on right now?
- 12:49 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> I would like you to please integrate the @words.p@ test case into the test cases project mor... - 12:41 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/testcases/@ contains tasks ... - 12:40 PM Feature #1587: implement full support for word indexes
- Code review 1587b/11907:
The latest code changes look fine to me.
I would like you to please integrate the @wor... - 07:25 AM Feature #1587: implement full support for word indexes
- The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/testcases/@ contains tasks for @h2@ and @postresql@ d...
- 02:01 PM Feature #3574: finish implementation of temp-table XML support
- From #4397-27:
> so I would say they should be handled as part of #3574. However, the separation line is rather th...
01/06/2021
- 07:29 PM Bug #5030: xfer dataset test issues
- According to my old and new ABL reference manual and OpenEdge "online documentation":https://documentation.progress.c...
01/05/2021
- 01:38 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> I think we need to add support in this case, too. The previous implementation of @contains@... - 01:20 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Please note that for the temp tables the @CONTAINS@ UDF is used at this moment.
> Do we re... - 12:48 PM Feature #1587: implement full support for word indexes
- Fixed @CONTAINS@ support for the temporary tables.
Committed to 1587b revision 11907.
Please note that for the te... - 11:18 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> The previous implementation used the @contains()@ methods from @pl/Functions.java@ in order... - 10:49 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> I've noticed that for @H2@ the name of the @CONTAINS@ UDF in the AST processed by @FqlToSql... - 08:58 AM Feature #1587: implement full support for word indexes
- Eric: Please review and confirm if 1587b can be merged into 3821c.
- 08:30 AM Feature #1587: implement full support for word indexes
- Finished word tables' support for H2.
Committed to 1587b revision 11906.
See the required changes to the import of ... - 04:54 AM Feature #1587: implement full support for word indexes
- I've noticed that for @H2@ the name of the @CONTAINS@ UDF in the AST processed by @FqlToSqlConverter@ is "contains_1"...
- 12:33 PM Bug #5030: xfer dataset test issues
- I have identified a OE bug that bothers me for some time. The @copy-temp-table@'s 2 parameter (@replace-mode@) is lea...
01/04/2021
- 08:32 AM Feature #1587: implement full support for word indexes
- In addition to #1587-190.
After enabling debug mode I in the trace file that @H2@ inserts and removes the same recor... - 07:20 AM Feature #1587: implement full support for word indexes
- I've encountered the following problem with @H2@ trigger when I try to insert multiple rows to the word table:
* If ... - 08:06 AM Feature #3958: BUFFER-COPY optimization
- I noticed something off in the current @BaseRecord.setAllDatum()@ implementation. This is used, according to #3958-7,...
12/30/2020
- 02:58 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> FWD H2 databases are created with the "p2jspi.jar":/projects/p2j/wiki/Application_Server_Installa... - 01:53 PM Feature #1587: implement full support for word indexes
- FWD H2 databases are created with the "p2jspi.jar":/projects/p2j/wiki/Application_Server_Installation#Text-Collator p...
- 12:47 PM Feature #1587: implement full support for word indexes
- I've encountered a strange error trying to connect to FWD H2 database with my favorite database client @dbeaver@. I'v...
12/29/2020
- 05:00 PM Bug #5056 (WIP): Temp-tables and unique indexes
- I continued with investigation of the issue. The @validateMaybeFlush()@ uses @BaseRecord.getUnvalidatedIndices(int)@ ...
- 03:36 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > On the other side, I understand that we use a customized ver... - 03:21 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> On the other side, I understand that we use a customized version of H2. Maybe it is the r... - 03:13 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> I believe FWD will compile without the H2 jar (though I have not tried recently). So, I do n... - 03:08 PM Feature #1587: implement full support for word indexes
- I believe FWD will compile without the H2 jar (though I have not tried recently). So, I do not think we already have ...
- 08:20 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> We already have hard coded dependencies on H2. I will let Eric evaluate if the new dependencies ... - 08:14 AM Feature #1587: implement full support for word indexes
- > I understand that to implement triggers for H2 one has to implement Java classes that depend on H2 API.
> What is ... - 06:47 AM Feature #1587: implement full support for word indexes
- I understand that to implement triggers for H2 one has to implement Java classes that depend on H2 API.
What is the ...
12/25/2020
- 07:52 AM Feature #1587: implement full support for word indexes
- Fixed issues mentioned in the code review (#1587-160) except the message about word indexes support.
Committed to 15... - 04:29 AM Feature #1587: implement full support for word indexes
- Branch 1587b was rebased to 3821c revision 11888. Pushed up to revision 11904.
12/24/2020
- 04:34 PM Feature #1587: implement full support for word indexes
- Finished word tables' population on import for PostgreSQL.
Committed to 1587b revision 11900.
All objects related t... - 03:34 AM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> If, at the time the @p2o.xml@ ruleset runs, you have the name calculated and stored in a var...
12/23/2020
- 06:13 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Need to add "wordtablename" annotation to the word index AST in the .p2o file on conversion... - 05:22 PM Feature #1587: implement full support for word indexes
- Need to add "wordtablename" annotation to the word index AST in the .p2o file on conversion.
Will highly appreciate ... - 04:49 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> @BaseRecord.getData(PropertyMapper)@ returns the entire data array for the record, not for a... - 04:43 PM Feature #1587: implement full support for word indexes
- @BaseRecord.getData(PropertyMapper)@ returns the entire data array for the record, not for any particular field. See ...
- 03:56 PM Feature #1587: implement full support for word indexes
- I've noticed that @dmo.getData(PropertyMapper)@ returns an array of length 2 for the field with word index where the ...
- 03:18 PM Feature #1587: implement full support for word indexes
- I think that it is sufficient to add a lookup of @PropertyMapper@ by property name to the @RecordLoader@. This will b...
- 03:08 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMa... - 02:09 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMapper)@. You probably will ne... - 02:02 PM Feature #1587: implement full support for word indexes
- See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMapper)@. You probably will need to do some refactoring...
- 01:27 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > What is the best way to retrieve a field value by the field name... - 01:22 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> What is the best way to retrieve a field value by the field name from the @BaseRecord@ inst... - 01:08 PM Feature #1587: implement full support for word indexes
- What is the best way to retrieve a field value by the field name from the @BaseRecord@ instance?
Thank you. - 12:56 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > Across all changed files, please remove the revision numbers ... - 12:55 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Currently, the H2 dialect specifies that the CONTAINS UDF should be used, and has a "TODO im... - 12:12 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Across all changed files, please remove the revision numbers from the file header entries.... - 12:01 PM Feature #1587: implement full support for word indexes
- Code review 1587b/11898:
Nice work, overall. Some questions/comments...
Currently, the H2 dialect specifies tha... - 09:29 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> Does the server startup still report @(com.goldencode.p2j.persist.orm.RecordMeta:WARNING) Word in... - 08:49 AM Feature #1587: implement full support for word indexes
- Does the server startup still report @(com.goldencode.p2j.persist.orm.RecordMeta:WARNING) Word indices are not suppor...
- 07:02 PM Bug #5056: Temp-tables and unique indexes
- Ovidiu Maxiniuc wrote:
> My problem is that a temp-table keeps accumulating newly-created 'validated' records whic...
12/22/2020
- 01:26 PM Bug #5056: Temp-tables and unique indexes
- This is a discussion started by email.
On 12/21/20 6:50 PM, Ovidiu Maxiniuc wrote:
> Eric,
>
> Do you recall w... - 01:19 PM Bug #5056 (Closed): Temp-tables and unique indexes
12/21/2020
- 02:30 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor, is there a way I can test this new word index implementation, without having to re-con... - 02:14 PM Feature #1587: implement full support for word indexes
- Igor, is there a way I can test this new word index implementation, without having to re-convert a large application?...
- 08:13 AM Feature #1587: implement full support for word indexes
- Branch 1587b was rebased to 3831c revision 11884. Pushed up to revision 11898.
- 11:43 AM Support #3871: determine how to change codepages/locales during import
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin, do you remember what was going wrong with this se... - 11:37 AM Support #3871: determine how to change codepages/locales during import
- Eric Faulhaber wrote:
> Constantin, do you remember what was going wrong with this setting? I recall that you report... - 11:31 AM Support #3871: determine how to change codepages/locales during import
- Igor Skornyakov wrote:
> BTW: I think we can speed up the import if we will use @PreparedStatement.addBatch@ and @... - 07:59 AM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> OK, I understand. We need Eric to complete the code review of #1587 first.
Got it, thank you. - 07:57 AM Support #3871: determine how to change codepages/locales during import
- OK, I understand. We need Eric to complete the code review of #1587 first.
- 07:44 AM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> I prefer for these changes to go into 3821c directly. Is there a reason they need to be build on... - 07:22 AM Support #3871: determine how to change codepages/locales during import
- I prefer for these changes to go into 3821c directly. Is there a reason they need to be build on top of 1587b?
12/20/2020
- 12:14 PM Support #3871: determine how to change codepages/locales during import
- Implemented @CPSTREAM@ support on import.
Committed to 1587b rev 11873.
Re-working of the word tables' import is st...
12/18/2020
- 01:14 PM Support #3871: determine how to change codepages/locales during import
- Yes, go ahead.
- 10:59 AM Support #3871: determine how to change codepages/locales during import
- Since I have to get familiar with import, maybe be I will add the population of the word tables with postponed creati...
12/17/2020
- 04:07 PM Support #3871: determine how to change codepages/locales during import
- > I think I've seen that for some .d files the import reports that the footer was not found. In this case we can eith...
- 03:57 PM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> I think that honoring that value is the easist way to implement my approach. We have to have tha... - 03:47 PM Support #3871: determine how to change codepages/locales during import
- I think that honoring that value is the easist way to implement my approach. We have to have that value as input. W...
- 03:38 PM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> > However, at this moment I do not see how the CPSTRIM value is used in the ImportWorker. It is u... - 03:31 PM Support #3871: determine how to change codepages/locales during import
- > However, at this moment I do not see how the CPSTRIM value is used in the ImportWorker. It is used in the creation ...
- 02:38 PM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> * We use our 4GL compatible stream processing to read the encoded @.d@ files during import. Thes... - 02:10 PM Support #3871: determine how to change codepages/locales during import
- * We use our 4GL compatible stream processing to read the encoded @.d@ files during import. These are the @com.golde...
- 01:20 PM Support #3871: determine how to change codepages/locales during import
- Sorry, I'm confused. In my understanding, all we need is to use @CODEPAGE-CONVERT@ with @UTF-8@ as the target codepag...
12/16/2020
- 02:37 PM Feature #4055: optimize temp-table output parameter copying
- Committed in 3821c/rev. 11881 support for fast loose-copy. Done some testing and it seems that loose-copy-mode now se...
12/15/2020
- 01:57 PM Feature #4055: optimize temp-table output parameter copying
- Ovidiu Maxiniuc wrote:
> Yes, this is exactly the scenario where I encountered the issue. However, I am not familiar... - 12:24 PM Feature #4055: optimize temp-table output parameter copying
- Please note: currently, the work of record initialization to default values is done in @BaseRecord.initialize@, which...
- 09:54 AM Feature #4055: optimize temp-table output parameter copying
- Adrian Lungu wrote:
> Ovidiu, I see the problem. This can be appear only when @loose-copy-mode@ is on (so we have a ... - 05:58 AM Feature #4055: optimize temp-table output parameter copying
- Ovidiu, I see the problem. This can be appear only when @loose-copy-mode@ is on (so we have a possible restricted fie...
- 08:54 PM Feature #4055: optimize temp-table output parameter copying
- There is a flaw in @FastCopyHelper.java@: when a copy operation is executed using a restricted field mapping, the unm...
Also available in: Atom