Activity
From 12/23/2020 to 01/21/2021
01/21/2021
- 05:16 PM Feature #4397: add database attrs, methods and options
- I tried to configure the buffer name initialization in @P2OLookup.addJavaName()@ but there is a problem. The @javaNam...
- 12:50 PM Feature #4397: add database attrs, methods and options
- Ovidiu Maxiniuc wrote:
> But, OTOH, the @P2OAccessWorker.javaBufferName()@ is not returning a stored value from a ... - 04:05 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> I just reread the notes for this where you mention the 1688 error is a compile time error in... - 03:45 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > I've found a clean solution for the @extent_field_name[index_ex... - 02:05 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> I've found a clean solution for the @extent_field_name[index_expr] CONTAINS something@ (see... - 02:00 PM Feature #1587: implement full support for word indexes
- Finished runtime word tables' support for extent fields (H2 and PostgreSQL).
Committed to 1587b revision 11924. ...
01/20/2021
- 02:31 PM Feature #5095: complete the shift from field names to bitsets
- #4011 implemented some of this work, but left some unfinished. See #5062-6 to #5062-8 for more details. This is a p...
- 02:30 PM Feature #5095 (New): complete the shift from field names to bitsets
01/19/2021
- 04:27 PM Feature #1587: implement full support for word indexes
- I've found a clean solution for the @extent_field_name[index_expr] CONTAINS something@ (see #1587-226). However, I ha...
01/18/2021
- 03:54 PM Feature #1587: implement full support for word indexes
- Implementation of the 4GL behavior for @extent_field_name[index_expr] CONTAINS something@ (see #1587-226) appears to ...
- 03:14 PM Feature #4397: add database attrs, methods and options
- Ovidiu Maxiniuc wrote:
> > @P2OAccessWorker@: the addition of @NameConverter.resolvePossibleKeywordConflict@ calls i...
01/17/2021
- 10:57 AM Feature #1587: implement full support for word indexes
- Added runtime support for the word indices on extent fields.
Committed to 1587b revision 11923.
Please note that at...
01/16/2021
- 06:21 AM Feature #1587: implement full support for word indexes
- Added word indices support for extent fields (conversion and import) for PostgreSQL and H2 dialects.
Committed to 15...
01/15/2021
- 11:59 AM Bug #5030: xfer dataset test issues
- Marian Edu wrote:
> Ovidiu, this is probably because of the `message xxx no-error.` statement that you use there whi... - 02:57 AM Bug #5030: xfer dataset test issues
- Ovidiu Maxiniuc wrote:
> Each time I get the following *compiler messages*:
Ovidiu, this is probably because of t... - 11:48 AM Bug #5085: uppercasing and string comparisons are incorrect for some character sets
- As noted in #1587-235, lowercasing has issues too:
> One thing here which is inconsistent in the 4GL is about usin... - 11:34 AM Bug #5085: uppercasing and string comparisons are incorrect for some character sets
- If we talk about comparing insensitive character data, there is a dirty workaround. I noticed that @toLowerCase()@ in...
- 10:34 AM Bug #5085: uppercasing and string comparisons are incorrect for some character sets
- It clearly is something that needs to be fixed in some way.
Looking at our implementation, it is more than just th... - 10:23 AM Bug #5085: uppercasing and string comparisons are incorrect for some character sets
- During the work on the @CONTAINS@ operator (starting at #1587-229), Igor encountered a problem in data import:
> I... - 10:13 AM Bug #5085 (New): uppercasing and string comparisons are incorrect for some character sets
- 10:34 AM Feature #1587: implement full support for word indexes
- > Should we re-work FWD toUpperCase() functions implementation to match 4GL behavior?
I've answered this in #5085.
01/14/2021
- 04:50 PM Bug #5030: xfer dataset test issues
- Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> Ovidiu, you're right on this one. The parameter is there alright, it d... - 12:54 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Now that is funny.
> I peeked at @java.lang.CharacterDataLatin1@, method @int toUpperCase(... - 12:46 PM Feature #1587: implement full support for word indexes
- Now that is funny.
I peeked at @java.lang.CharacterDataLatin1@, method @int toUpperCase(int)@ which is called from @... - 11:28 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Not the codepage is the problem. It seems to me like a flaw in Java's uppercase implementat... - 11:17 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> PostgreSQL @UPPER@ function for the @LATIN1@ database converts µ to µ (doesn't change it). ... - 11:05 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> The problem is that we convert to uppercase using Java toUpperCase() method which works wit... - 10:50 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> This is an interesting observation. The latin micro (@µ@) is @U00B5@. The Greek letters @μ@...
01/13/2021
- 05:39 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> BTW: in LATIN1 µ is called not "Greek mu", but "micro", I think this is the reason why ther... - 09:56 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> > It seems that the problem is that µ (Greek 'mu' in lowercase) does exist in LATIN1 character se... - 09:42 AM Feature #1587: implement full support for word indexes
- > It seems that the problem is that µ (Greek 'mu' in lowercase) does exist in LATIN1 character set, while Μ (Greek 'm...
- 09:57 AM Support #3871: determine how to change codepages/locales during import
- Greg Shah wrote:
> Please see #1587-229 and following notes for related discussions about code page failures during ... - 09:43 AM Support #3871: determine how to change codepages/locales during import
- Please see #1587-229 and following notes for related discussions about code page failures during import.
- 07:14 PM Feature #4397: add database attrs, methods and options
- Eric Faulhaber wrote:
> 4397a/11924 code review (cont)...
> @DmoMeta.getPrimaryIndex@: in implicit primary index ca...
01/12/2021
- 06:56 PM Feature #4397: add database attrs, methods and options
- Adrian Lungu wrote:
> Eric, the changes on @TemporaryBuffer@ are OK in regard with the temp-table copy. I saw that n... - 06:49 PM Feature #4397: add database attrs, methods and options
- Eric Faulhaber wrote:
> @SSL.java@:328 contains the following comment: [...] Was this resolved, or an issue opened ... - 05:58 PM Feature #4397: add database attrs, methods and options
- 4397a/11924 code review (cont)...
@DmoMeta.getPrimaryIndex@: in implicit primary index case, what constitutes the ... - 02:10 PM Feature #4397: add database attrs, methods and options
- Eric, the changes on @TemporaryBuffer@ are OK in regard with the temp-table copy. I saw that now there is support for...
- 03:07 AM Feature #4397: add database attrs, methods and options
- 4397a/11924 code review (cont):
@SSL.java@:328 contains the following comment:... - 07:37 PM Feature #4397: add database attrs, methods and options
- Eric Faulhaber wrote:
> I'm reviewing 4397a/11924. Since it's so big, I'm not going to present a single review of al... - 07:25 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> It seems that the problem is that µ (Greek 'mu' in lowercase) does exist in @LATIN1@ char... - 07:10 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Indeed, a closer look reveals that in all these records the field contains greek "mu" (lowe... - 05:03 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> @0xce 0x9c@ looks like Greek uppercase M (https://vazor.com/unicode/c039C.html) u. The prob... - 04:23 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> There are some very similar messages posted in #3871.
This was a result of my changes. I'v...
01/11/2021
- 06:51 PM Feature #1587: implement full support for word indexes
- There are some very similar messages posted in #3871.
However, "this article":https://knowledgebase.progress.com/a... - 02:54 PM Feature #1587: implement full support for word indexes
- In the import of a large customer database I've got 4 errors for a single table on populating the related word table:...
- 07:34 AM Feature #1587: implement full support for word indexes
- Yes. In fact I think it must be fixed at runtime because otherwise we would not generate a warning at the same place...
- 06:36 AM Feature #1587: implement full support for word indexes
- Is it OK if the discrepancy described in #1587-226 regarding subscript on array field in CONTAINS phrase will be fixe...
- 06:27 AM Feature #1587: implement full support for word indexes
- > I mean @extent_field_name CONTAINS something@. I understand that (@extent_field_name[index_expr] CONTAINS something...
- 07:31 AM Feature #4397: add database attrs, methods and options
- > If you want we can write some more tests to see how the dataset behaves when this odd situation occurs but imho thi...
- 04:10 AM Feature #4397: add database attrs, methods and options
- I'm reviewing 4397a/11924. Since it's so big, I'm not going to present a single review of all the changes, but rather...
- 02:11 AM Feature #4397: add database attrs, methods and options
- Greg Shah wrote:
> Marian: What is your opinion of this bug?
That is definitively an undiscovered bug, no one pro... - 02:27 AM Bug #5030: xfer dataset test issues
- Ovidiu Maxiniuc wrote:
> According to my old and new ABL reference manual and OpenEdge "online documentation":https:...
01/10/2021
- 10:12 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> Igor Skornyakov wrote:
> > It seems that in 4GL the value of the @CONTAINS@ operator for the ext... - 09:54 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> It seems that in 4GL the value of the @CONTAINS@ operator for the extent field is an OR of ... - 05:32 AM Feature #1587: implement full support for word indexes
- It seems that in 4GL the value of the @CONTAINS@ operator for the extent field is an OR of @CONTAINS@ value for all i...
- 05:24 AM Feature #1587: implement full support for word indexes
- BTW: the @CONTAINS@ operator support based on UDF is also incorrect. The generated SQL statement still contains (for ...
- 03:55 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > The import of the large customer database finished OK. However,...
01/09/2021
- 05:49 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> The import of the large customer database finished OK. However, I see in the log multiple s... - 04:24 AM Feature #1587: implement full support for word indexes
- The import of the large customer database finished OK. However, I see in the log multiple strange errors related to t...
01/08/2021
- 03:54 PM Support #3871: determine how to change codepages/locales during import
- Eric Faulhaber wrote:
> Are the code page changes in any way dependent upon the other changes unique to branch 1587b... - 03:33 PM Support #3871: determine how to change codepages/locales during import
- Are the code page changes in any way dependent upon the other changes unique to branch 1587b? If not, I would suggest...
- 01:16 PM Support #3871: determine how to change codepages/locales during import
- My changes for the codepage support on the database import seem to be not 100% correct - they prevent the normal impo...
- 11:12 AM Support #3871: determine how to change codepages/locales during import
- My changes seem to cause error on import the customer database:...
- 11:27 AM Feature #1587: implement full support for word indexes
- The branch 1587b was rebased to 3821c revision 11901.
Pushed up to revision 11920. - 10:30 AM Bug #5072: exception loading _user meta table
- There is this exception in FWD when trying to load the @_user@ meta table:...
- 10:27 AM Bug #5072 (New): exception loading _user meta table
01/07/2021
- 05:41 PM Bug #5030: xfer dataset test issues
- Marian,
I was re-running the test-sets again when I encountered the following issue: the same method responds in app... - 03:34 PM Feature #4397: add database attrs, methods and options
- Actually, never mind. I'll just do a fresh checkout.
- 03:33 PM Feature #4397: add database attrs, methods and options
- Ovidiu, I've updated then reverted (to adjust for an apparent rebase since my last update) my older checkout of 4397a...
- 03:03 PM Feature #4397: add database attrs, methods and options
- Greg Shah wrote:
> My initial reaction is that we probably should fix this. Can we potentially use a @Set@ to detec... - 02:00 PM Feature #4397: add database attrs, methods and options
- > At this moment all of the functionality specified in the first notes of this task is present in branch 4397a (lates...
- 11:46 AM Feature #4397: add database attrs, methods and options
- Greg Shah wrote:
> Is it correct that all of the functionality needed for this task is complete in 4397a?
>
> Whe... - 11:06 AM Feature #4397: add database attrs, methods and options
- Is it correct that all of the functionality needed for this task is complete in 4397a?
When do you estimate comple... - 03:20 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> Where is your @testcases@ bound to?... - 03:15 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> This is really strange:
> [...]
Where is your @testcases@ bound to?
> I see. Thank you... - 03:01 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > Sorry, I meant @build_db.xml@
> Nope. @find /opt/testcases/ -i... - 02:45 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Sorry, I meant @build_db.xml@
Nope. @find /opt/testcases/ -iname build_db.xml@ still canno... - 02:36 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> Actually, there is no need for a full reconversion. Only the database support is required (... - 02:27 PM Feature #1587: implement full support for word indexes
- Actually, there is no need for a full reconversion. Only the database support is required (ddls and p2o), so running ...
- 02:25 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> > I'm not sure this exists. Ovidiu?
> I cannot find any @import_db.xml@ in @xfer@ project.... - 02:19 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> I think that the conversion and import will take quite some time, right? These are just long run... - 02:04 PM Feature #1587: implement full support for word indexes
- > > OK, please go ahead with such a test. If the results are good, then the changes can be merged back into 3821c.
... - 02:00 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/... - 01:58 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> OK, please go ahead with such a test. If the results are good, then the changes can be merged ba... - 01:31 PM Feature #1587: implement full support for word indexes
- OK, please go ahead with such a test. If the results are good, then the changes can be merged back into 3821c.
- 01:20 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> Has this been tested with any of the large customer applications which we are working on right no... - 01:11 PM Feature #1587: implement full support for word indexes
- Has this been tested with any of the large customer applications which we are working on right now?
- 12:49 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> I would like you to please integrate the @words.p@ test case into the test cases project mor... - 12:41 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/testcases/@ contains tasks ... - 12:40 PM Feature #1587: implement full support for word indexes
- Code review 1587b/11907:
The latest code changes look fine to me.
I would like you to please integrate the @wor... - 07:25 AM Feature #1587: implement full support for word indexes
- The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/testcases/@ contains tasks for @h2@ and @postresql@ d...
- 02:01 PM Feature #3574: finish implementation of temp-table XML support
- From #4397-27:
> so I would say they should be handled as part of #3574. However, the separation line is rather th...
01/06/2021
- 07:29 PM Bug #5030: xfer dataset test issues
- According to my old and new ABL reference manual and OpenEdge "online documentation":https://documentation.progress.c...
01/05/2021
- 01:38 PM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> I think we need to add support in this case, too. The previous implementation of @contains@... - 01:20 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Please note that for the temp tables the @CONTAINS@ UDF is used at this moment.
> Do we re... - 12:48 PM Feature #1587: implement full support for word indexes
- Fixed @CONTAINS@ support for the temporary tables.
Committed to 1587b revision 11907.
Please note that for the te... - 11:18 AM Feature #1587: implement full support for word indexes
- Ovidiu Maxiniuc wrote:
> The previous implementation used the @contains()@ methods from @pl/Functions.java@ in order... - 10:49 AM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> I've noticed that for @H2@ the name of the @CONTAINS@ UDF in the AST processed by @FqlToSql... - 08:58 AM Feature #1587: implement full support for word indexes
- Eric: Please review and confirm if 1587b can be merged into 3821c.
- 08:30 AM Feature #1587: implement full support for word indexes
- Finished word tables' support for H2.
Committed to 1587b revision 11906.
See the required changes to the import of ... - 04:54 AM Feature #1587: implement full support for word indexes
- I've noticed that for @H2@ the name of the @CONTAINS@ UDF in the AST processed by @FqlToSqlConverter@ is "contains_1"...
- 12:33 PM Bug #5030: xfer dataset test issues
- I have identified a OE bug that bothers me for some time. The @copy-temp-table@'s 2 parameter (@replace-mode@) is lea...
01/04/2021
- 08:32 AM Feature #1587: implement full support for word indexes
- In addition to #1587-190.
After enabling debug mode I in the trace file that @H2@ inserts and removes the same recor... - 07:20 AM Feature #1587: implement full support for word indexes
- I've encountered the following problem with @H2@ trigger when I try to insert multiple rows to the word table:
* If ... - 08:06 AM Feature #3958: BUFFER-COPY optimization
- I noticed something off in the current @BaseRecord.setAllDatum()@ implementation. This is used, according to #3958-7,...
12/30/2020
- 02:58 PM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> FWD H2 databases are created with the "p2jspi.jar":/projects/p2j/wiki/Application_Server_Installa... - 01:53 PM Feature #1587: implement full support for word indexes
- FWD H2 databases are created with the "p2jspi.jar":/projects/p2j/wiki/Application_Server_Installation#Text-Collator p...
- 12:47 PM Feature #1587: implement full support for word indexes
- I've encountered a strange error trying to connect to FWD H2 database with my favorite database client @dbeaver@. I'v...
12/29/2020
- 05:00 PM Bug #5056 (WIP): Temp-tables and unique indexes
- I continued with investigation of the issue. The @validateMaybeFlush()@ uses @BaseRecord.getUnvalidatedIndices(int)@ ...
- 03:36 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > On the other side, I understand that we use a customized ver... - 03:21 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> On the other side, I understand that we use a customized version of H2. Maybe it is the r... - 03:13 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> I believe FWD will compile without the H2 jar (though I have not tried recently). So, I do n... - 03:08 PM Feature #1587: implement full support for word indexes
- I believe FWD will compile without the H2 jar (though I have not tried recently). So, I do not think we already have ...
- 08:20 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> We already have hard coded dependencies on H2. I will let Eric evaluate if the new dependencies ... - 08:14 AM Feature #1587: implement full support for word indexes
- > I understand that to implement triggers for H2 one has to implement Java classes that depend on H2 API.
> What is ... - 06:47 AM Feature #1587: implement full support for word indexes
- I understand that to implement triggers for H2 one has to implement Java classes that depend on H2 API.
What is the ...
12/25/2020
- 07:52 AM Feature #1587: implement full support for word indexes
- Fixed issues mentioned in the code review (#1587-160) except the message about word indexes support.
Committed to 15... - 04:29 AM Feature #1587: implement full support for word indexes
- Branch 1587b was rebased to 3821c revision 11888. Pushed up to revision 11904.
12/24/2020
- 04:34 PM Feature #1587: implement full support for word indexes
- Finished word tables' population on import for PostgreSQL.
Committed to 1587b revision 11900.
All objects related t... - 03:34 AM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> If, at the time the @p2o.xml@ ruleset runs, you have the name calculated and stored in a var...
12/23/2020
- 06:13 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Need to add "wordtablename" annotation to the word index AST in the .p2o file on conversion... - 05:22 PM Feature #1587: implement full support for word indexes
- Need to add "wordtablename" annotation to the word index AST in the .p2o file on conversion.
Will highly appreciate ... - 04:49 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> @BaseRecord.getData(PropertyMapper)@ returns the entire data array for the record, not for a... - 04:43 PM Feature #1587: implement full support for word indexes
- @BaseRecord.getData(PropertyMapper)@ returns the entire data array for the record, not for any particular field. See ...
- 03:56 PM Feature #1587: implement full support for word indexes
- I've noticed that @dmo.getData(PropertyMapper)@ returns an array of length 2 for the field with word index where the ...
- 03:18 PM Feature #1587: implement full support for word indexes
- I think that it is sufficient to add a lookup of @PropertyMapper@ by property name to the @RecordLoader@. This will b...
- 03:08 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMa... - 02:09 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMapper)@. You probably will ne... - 02:02 PM Feature #1587: implement full support for word indexes
- See @PropertyMapper.getIndex@ and @BaseRecord.getData(PropertyMapper)@. You probably will need to do some refactoring...
- 01:27 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > What is the best way to retrieve a field value by the field name... - 01:22 PM Feature #1587: implement full support for word indexes
- Igor Skornyakov wrote:
> What is the best way to retrieve a field value by the field name from the @BaseRecord@ inst... - 01:08 PM Feature #1587: implement full support for word indexes
- What is the best way to retrieve a field value by the field name from the @BaseRecord@ instance?
Thank you. - 12:56 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > Across all changed files, please remove the revision numbers ... - 12:55 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Currently, the H2 dialect specifies that the CONTAINS UDF should be used, and has a "TODO im... - 12:12 PM Feature #1587: implement full support for word indexes
- Eric Faulhaber wrote:
> Across all changed files, please remove the revision numbers from the file header entries.... - 12:01 PM Feature #1587: implement full support for word indexes
- Code review 1587b/11898:
Nice work, overall. Some questions/comments...
Currently, the H2 dialect specifies tha... - 09:29 AM Feature #1587: implement full support for word indexes
- Greg Shah wrote:
> Does the server startup still report @(com.goldencode.p2j.persist.orm.RecordMeta:WARNING) Word in... - 08:49 AM Feature #1587: implement full support for word indexes
- Does the server startup still report @(com.goldencode.p2j.persist.orm.RecordMeta:WARNING) Word indices are not suppor...
Also available in: Atom