Project

General

Profile

Activity

From 12/30/2020 to 01/28/2021

01/29/2021

07:41 PM Feature #4397: add database attrs, methods and options
Eric Faulhaber wrote:
> Code review 4397a/11958:
> @RecordBuffer.setCurrentRecord@ being non-private is still a pro...
Ovidiu Maxiniuc
07:11 PM Feature #4397: add database attrs, methods and options
Code review 4397a/11991:
Continuing the discussion from #5056-14, I'm still convinced the @BufferImpl.validate()@ ...
Eric Faulhaber
07:12 PM Feature #3574: finish implementation of temp-table XML support
Ovidiu Maxiniuc wrote:
> I re-did the rebase and re-commit earlier so you might want to review these changes too).
...
Eric Faulhaber

01/28/2021

05:11 PM Feature #3574: finish implementation of temp-table XML support
That is exactly what I feel in regard to @TableMapper@, too. It only have the advantage of being decoupled, but acces... Ovidiu Maxiniuc
04:34 PM Feature #3574: finish implementation of temp-table XML support
I really don't like the @TableMapper@ construct at all. I tried to rationalize its internals at one point long ago, w... Eric Faulhaber
08:31 PM Feature #3574: finish implementation of temp-table XML support
I started implementing a solution for the issue in note-11. As noted there, the problem in the fact that @TableMapper... Ovidiu Maxiniuc
04:24 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Is the import change (to uppercase in the database) safe across all dialects we currently su...
Igor Skornyakov
04:18 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> This will require a simple change in the import. But, to make the word table work correct...
Eric Faulhaber
04:11 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > Well, if changes in the conversion are allowed I can impleme...
Igor Skornyakov
04:03 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Well, if changes in the conversion are allowed I can implement a workaround for import by...
Eric Faulhaber
03:56 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I understand your point. However, the initial idea was not t...
Igor Skornyakov
03:34 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I understand your point. However, the initial idea was not to change the conversion at al...
Eric Faulhaber
02:03 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> We should not be adjusting for conversion errors at runtime. If something is incorrectly add...
Igor Skornyakov
01:57 PM Feature #1587: implement full support for word indexes
We should not be adjusting for conversion errors at runtime. If something is incorrectly added by conversion, we shou... Eric Faulhaber
01:25 PM Feature #1587: implement full support for word indexes
I understand that the incorrect @ORDER BY@ component is added at the @PreselectQuery.assembleHQL()@ method. The @Sort... Igor Skornyakov
10:00 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> There are two things that can cause a problem:
> # temp-tables with word index for an exte...
Igor Skornyakov
09:35 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> > uppercasing with LATIN1 database (#5082). This is a real problem with at least one large custom...
Igor Skornyakov
09:24 AM Feature #1587: implement full support for word indexes
> uppercasing with LATIN1 database (#5082). This is a real problem with at least one large customer app.
Does 1587...
Greg Shah
09:10 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> Is 1587b safe for merge into 3821c? Does it work properly for the large customer application whi...
Igor Skornyakov
09:01 AM Feature #1587: implement full support for word indexes
Is 1587b safe for merge into 3821c? Does it work properly for the large customer application which you tested? We a... Greg Shah
01:39 PM Feature #4397: add database attrs, methods and options
Code review 4397a/11958:
@RecordBuffer.setCurrentRecord@ being non-private is still a problem. See comments in #43...
Eric Faulhaber

01/27/2021

05:04 PM Bug #5056: Temp-tables and unique indexes
Actually my first idea for @validate()@ was as simple as:... Ovidiu Maxiniuc
04:42 PM Bug #5056: Temp-tables and unique indexes
Ovidiu Maxiniuc wrote:
> Yes, the method implementation does not make sense. The caller will get nothing in return. ...
Eric Faulhaber
04:16 PM Bug #5056: Temp-tables and unique indexes
Yes, the method implementation does not make sense. The caller will get nothing in return. Nice catch! I think it sho... Ovidiu Maxiniuc
04:15 PM Bug #5056: Temp-tables and unique indexes
BTW, with my local changes, when I change the call from @BufferImpl.validate@ to pass @true@ to @RB.validate(boolean)... Eric Faulhaber
03:50 PM Bug #5056: Temp-tables and unique indexes
Ovidiu Maxiniuc wrote:
> Does it make sense to check whether the buffer is @Temporary@ ? Because the permanent table...
Eric Faulhaber
03:37 PM Bug #5056: Temp-tables and unique indexes
Does it make sense to check whether the buffer is @Temporary@ ? Because the permanent tables have all indexes in plac... Ovidiu Maxiniuc
03:15 PM Bug #5056: Temp-tables and unique indexes
Ovidiu Maxiniuc wrote:
> Yes, please add the change to 3821c. I inspected the code (the four places where @validateM...
Eric Faulhaber
02:48 PM Bug #5056: Temp-tables and unique indexes
Yes, please add the change to 3821c. I inspected the code (the four places where @validateMaybeFlush()@ is called) an... Ovidiu Maxiniuc
02:29 PM Bug #5056: Temp-tables and unique indexes
The patch was based on knowing that the @Validation@ instance was invoked for the purpose of flushing, but your point... Eric Faulhaber
01:53 PM Bug #5056: Temp-tables and unique indexes
Just inspecting the code it looked fine. I rebased and run the testcases to be sure. I got different behaviour, but n... Ovidiu Maxiniuc
11:30 AM Feature #3958: BUFFER-COPY optimization
Adrian Lungu wrote:
> I noticed something off in the current @BaseRecord.setAllDatum()@ implementation. This is used...
Eric Faulhaber

01/26/2021

04:40 PM Bug #5056 (Review): Temp-tables and unique indexes
I have committed to 3821c/11953 a fix for the failing test case in #5056-3. Please review. I put it in 3821c because ... Eric Faulhaber
01:31 PM Feature #1587: implement full support for word indexes
There is some strange thing I've noticed regarding the generated @sort@ parameter of the @AdaptiveQuery.initialize()@... Igor Skornyakov
11:54 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Please see if you can come up with any test case which breaks this rule or which further ref...
Igor Skornyakov
11:38 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Greg Shah wrote:
> > I guess the leftmost contains word match is the most significant orde...
Eric Faulhaber
10:32 AM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> [...]? I.e., do the other words in the field matter?
As far as I can see, it doesn't matte...
Igor Skornyakov
10:27 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> I guess the leftmost contains word match is the most significant ordering constraint. Then the n...
Ovidiu Maxiniuc
10:21 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> I guess the leftmost contains word match is the most significant ordering constraint. Then the n...
Igor Skornyakov
10:13 AM Feature #1587: implement full support for word indexes
I guess the leftmost contains word match is the most significant ordering constraint. Then the next word match and s... Greg Shah
10:00 AM Feature #1587: implement full support for word indexes
The order of the records in case of more complicated queries (see #1587-291) is less obvious. Consider the following ... Igor Skornyakov
09:22 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> As well known, SQL standard explicitly says that in the absence of the @ORDER BY@ clause th...
Igor Skornyakov
10:20 AM Feature #3574: finish implementation of temp-table XML support
> shouldn't error flag be cleared at the start of the next NO-ERROR?
No. Although we initially thought this was t...
Greg Shah
09:45 AM Feature #3574: finish implementation of temp-table XML support
Greg Shah wrote:
> 1. A @NO-ERROR@ statement has its errors collected into the @ErrorManager.WorkArea.pendingErrorSt...
Ovidiu Maxiniuc
08:25 AM Feature #3574: finish implementation of temp-table XML support
> My question is: where/when should the error flag be reset?
1. A @NO-ERROR@ statement has its errors collected in...
Greg Shah

01/25/2021

05:53 PM Feature #3574: finish implementation of temp-table XML support
While thinking of the above issue I encountered the next one. Consider the 4GL code (ignore missing declarations):
<...
Ovidiu Maxiniuc
04:29 PM Feature #3574: finish implementation of temp-table XML support
I have encountered the following issue: the @serialize-hidden@ attribute steals the value from another temp-table fie... Ovidiu Maxiniuc
05:23 PM Feature #1587: implement full support for word indexes
As well known, SQL standard explicitly says that in the absence of the @ORDER BY@ clause the order of the @SELECT@ re... Igor Skornyakov
04:49 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > Should I use @__iifext@ in the @ORDER BY@ clause? Does it make...
Igor Skornyakov
04:45 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Hm, I did not look carefully enough at the DDL. The presence of the @tt1__5@ table means tha...
Igor Skornyakov
04:42 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Should I use @__iifext@ in the @ORDER BY@ clause? Does it make sense?
Did you add @ifext@...
Ovidiu Maxiniuc
04:33 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> It seems this is a problem with index selection. See https://proj.goldencode.com/artifacts/j...
Igor Skornyakov
04:31 PM Feature #1587: implement full support for word indexes
To be more explicit regarding the test case requirement, please add a primary index to your test case temp-table, whi... Eric Faulhaber
04:28 PM Feature #1587: implement full support for word indexes
Hm, I did not look carefully enough at the DDL. The presence of the @tt1__5@ table means that temp-tables are not den... Eric Faulhaber
04:26 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> @ifext@ was added to @order by@ clause because @wiext@ index was selected to 'drive' the qu...
Igor Skornyakov
04:22 PM Feature #1587: implement full support for word indexes
It seems this is a problem with index selection. See https://proj.goldencode.com/artifacts/javadoc/latest/api/com/gol... Eric Faulhaber
04:05 PM Feature #1587: implement full support for word indexes
@ifext@ was added to @order by@ clause because @wiext@ index was selected to 'drive' the query. Normally this should ... Ovidiu Maxiniuc
03:34 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > Looking how to fix the @ORDER BY@ clause. In fact, I do not com...
Igor Skornyakov
03:22 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Looking how to fix the @ORDER BY@ clause. In fact, I do not completely understand why @uppe...
Ovidiu Maxiniuc
02:49 PM Feature #1587: implement full support for word indexes
I've re-worked the SQL generations for @CONTAINS@ for temporary tables with an extent field (see #1587-271). However,... Igor Skornyakov
02:05 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I'm changing the code at this moment and cannot provide the exact error but it was about ...
Eric Faulhaber
01:44 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> What does the converted code look like for this test case?...
Igor Skornyakov
01:38 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > I was hoping to keep @FqlToSqlConverter@ clean w.r.t. denormaliz...
Eric Faulhaber
01:32 PM Feature #1587: implement full support for word indexes
Igor, sorry, I missed your intermediate post. Digesting it now... Eric Faulhaber
01:30 PM Feature #1587: implement full support for word indexes
Although this is excellent information to document, I do want to reiterate that I want to avoid putting denormalizati... Eric Faulhaber
01:27 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> > From Igor:
> > I need this in the @FqlToSqlConverter.toSQL()@. There is no information a...
Igor Skornyakov
01:26 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> I was hoping to keep @FqlToSqlConverter@ clean w.r.t. denormalization knowledge, and to avoi...
Igor Skornyakov
01:25 PM Feature #1587: implement full support for word indexes
> From Igor:
> I need this in the @FqlToSqlConverter.toSQL()@. There is no information about DMOs at this point (at ...
Ovidiu Maxiniuc
01:10 PM Feature #1587: implement full support for word indexes
I was hoping to keep @FqlToSqlConverter@ clean w.r.t. denormalization knowledge, and to avoid additional lookups at t... Eric Faulhaber
01:07 PM Feature #1587: implement full support for word indexes
From email...
---
>> From Igor:
>>
>> Do we have any repository for the temporary tables' DMOs like @Metadat...
Eric Faulhaber
06:36 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> > It was my suggestion to deal with warning 1688 at runtime and Grep agreed with this (see #1587-...
Igor Skornyakov
06:25 AM Feature #1587: implement full support for word indexes
> It was my suggestion to deal with warning 1688 at runtime and Grep agreed with this (see #1587-227, #1587-228).
...
Greg Shah
03:40 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > How can I run the conversion to use denormalized extent fields?
...
Igor Skornyakov
03:38 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> How can I run the conversion to use denormalized extent fields?
> Thank you.
I just rem...
Eric Faulhaber
03:27 AM Feature #1587: implement full support for word indexes
How can I run the conversion to use denormalized extent fields?
Thank you.
Igor Skornyakov
03:19 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I'm working now on the extent fields in the @_temp@ database...
Igor Skornyakov
03:16 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Regarding the SQL rewriting, are you sure the FQL code coming from the @HQLPreprocessor@ (we...
Igor Skornyakov
03:14 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I'm working now on the extent fields in the @_temp@ database support. Without this, the c...
Eric Faulhaber
03:11 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> There are three places affected by the word tables' support
> # DDL generation
> # Dat...
Eric Faulhaber
03:09 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Code review 1587b/11924:
>
> I've made various, minor formatting and javadoc fixes and co...
Igor Skornyakov
03:02 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Thanks for the details.
> >
> > Is the case of the @f_ext@ fi...
Igor Skornyakov
02:58 AM Feature #1587: implement full support for word indexes
Code review 1587b/11924:
I've made various, minor formatting and javadoc fixes and committed these as rev 11925. O...
Eric Faulhaber
02:45 AM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Thanks for the details.
>
> Is the case of the @f_ext@ field being denormalized handled? ...
Igor Skornyakov
01:53 AM Feature #1587: implement full support for word indexes
Thanks for the details.
Is the case of the @f_ext@ field being denormalized handled? If so, is it handled above th...
Eric Faulhaber

01/21/2021

05:16 PM Feature #4397: add database attrs, methods and options
I tried to configure the buffer name initialization in @P2OLookup.addJavaName()@ but there is a problem. The @javaNam... Ovidiu Maxiniuc
12:50 PM Feature #4397: add database attrs, methods and options
Ovidiu Maxiniuc wrote:
> But, OTOH, the @P2OAccessWorker.javaBufferName()@ is not returning a stored value from a ...
Eric Faulhaber
04:05 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> I just reread the notes for this where you mention the 1688 error is a compile time error in...
Igor Skornyakov
03:45 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > I've found a clean solution for the @extent_field_name[index_ex...
Eric Faulhaber
02:05 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I've found a clean solution for the @extent_field_name[index_expr] CONTAINS something@ (see...
Igor Skornyakov
02:00 PM Feature #1587: implement full support for word indexes
Finished runtime word tables' support for extent fields (H2 and PostgreSQL).
Committed to 1587b revision 11924. ...
Igor Skornyakov

01/20/2021

02:31 PM Feature #5095: complete the shift from field names to bitsets
#4011 implemented some of this work, but left some unfinished. See #5062-6 to #5062-8 for more details. This is a p... Greg Shah
02:30 PM Feature #5095 (New): complete the shift from field names to bitsets
Greg Shah

01/19/2021

04:27 PM Feature #1587: implement full support for word indexes
I've found a clean solution for the @extent_field_name[index_expr] CONTAINS something@ (see #1587-226). However, I ha... Igor Skornyakov

01/18/2021

03:54 PM Feature #1587: implement full support for word indexes
Implementation of the 4GL behavior for @extent_field_name[index_expr] CONTAINS something@ (see #1587-226) appears to ... Igor Skornyakov
03:14 PM Feature #4397: add database attrs, methods and options
Ovidiu Maxiniuc wrote:
> > @P2OAccessWorker@: the addition of @NameConverter.resolvePossibleKeywordConflict@ calls i...
Ovidiu Maxiniuc

01/17/2021

10:57 AM Feature #1587: implement full support for word indexes
Added runtime support for the word indices on extent fields.
Committed to 1587b revision 11923.
Please note that at...
Igor Skornyakov

01/16/2021

06:21 AM Feature #1587: implement full support for word indexes
Added word indices support for extent fields (conversion and import) for PostgreSQL and H2 dialects.
Committed to 15...
Igor Skornyakov

01/15/2021

11:59 AM Bug #5030: xfer dataset test issues
Marian Edu wrote:
> Ovidiu, this is probably because of the `message xxx no-error.` statement that you use there whi...
Ovidiu Maxiniuc
02:57 AM Bug #5030: xfer dataset test issues
Ovidiu Maxiniuc wrote:
> Each time I get the following *compiler messages*:
Ovidiu, this is probably because of t...
Marian Edu
11:48 AM Bug #5085: uppercasing and string comparisons are incorrect for some character sets
As noted in #1587-235, lowercasing has issues too:
> One thing here which is inconsistent in the 4GL is about usin...
Greg Shah
11:34 AM Bug #5085: uppercasing and string comparisons are incorrect for some character sets
If we talk about comparing insensitive character data, there is a dirty workaround. I noticed that @toLowerCase()@ in... Ovidiu Maxiniuc
10:34 AM Bug #5085: uppercasing and string comparisons are incorrect for some character sets
It clearly is something that needs to be fixed in some way.
Looking at our implementation, it is more than just th...
Greg Shah
10:23 AM Bug #5085: uppercasing and string comparisons are incorrect for some character sets
During the work on the @CONTAINS@ operator (starting at #1587-229), Igor encountered a problem in data import:
> I...
Greg Shah
10:13 AM Bug #5085 (New): uppercasing and string comparisons are incorrect for some character sets
Greg Shah
10:34 AM Feature #1587: implement full support for word indexes
> Should we re-work FWD toUpperCase() functions implementation to match 4GL behavior?
I've answered this in #5085.
Greg Shah

01/14/2021

04:50 PM Bug #5030: xfer dataset test issues
Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> Ovidiu, you're right on this one. The parameter is there alright, it d...
Ovidiu Maxiniuc
12:54 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Now that is funny.
> I peeked at @java.lang.CharacterDataLatin1@, method @int toUpperCase(...
Igor Skornyakov
12:46 PM Feature #1587: implement full support for word indexes
Now that is funny.
I peeked at @java.lang.CharacterDataLatin1@, method @int toUpperCase(int)@ which is called from @...
Ovidiu Maxiniuc
11:28 AM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Not the codepage is the problem. It seems to me like a flaw in Java's uppercase implementat...
Igor Skornyakov
11:17 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> PostgreSQL @UPPER@ function for the @LATIN1@ database converts µ to µ (doesn't change it). ...
Igor Skornyakov
11:05 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> The problem is that we convert to uppercase using Java toUpperCase() method which works wit...
Ovidiu Maxiniuc
10:50 AM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> This is an interesting observation. The latin micro (@µ@) is @U00B5@. The Greek letters @μ@...
Igor Skornyakov

01/13/2021

05:39 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> BTW: in LATIN1 µ is called not "Greek mu", but "micro", I think this is the reason why ther...
Ovidiu Maxiniuc
09:56 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> > It seems that the problem is that µ (Greek 'mu' in lowercase) does exist in LATIN1 character se...
Igor Skornyakov
09:42 AM Feature #1587: implement full support for word indexes
> It seems that the problem is that µ (Greek 'mu' in lowercase) does exist in LATIN1 character set, while Μ (Greek 'm... Greg Shah
09:57 AM Support #3871: determine how to change codepages/locales during import
Greg Shah wrote:
> Please see #1587-229 and following notes for related discussions about code page failures during ...
Igor Skornyakov
09:43 AM Support #3871: determine how to change codepages/locales during import
Please see #1587-229 and following notes for related discussions about code page failures during import. Greg Shah
07:14 PM Feature #4397: add database attrs, methods and options
Eric Faulhaber wrote:
> 4397a/11924 code review (cont)...
> @DmoMeta.getPrimaryIndex@: in implicit primary index ca...
Ovidiu Maxiniuc

01/12/2021

06:56 PM Feature #4397: add database attrs, methods and options
Adrian Lungu wrote:
> Eric, the changes on @TemporaryBuffer@ are OK in regard with the temp-table copy. I saw that n...
Ovidiu Maxiniuc
06:49 PM Feature #4397: add database attrs, methods and options
Eric Faulhaber wrote:
> @SSL.java@:328 contains the following comment: [...] Was this resolved, or an issue opened ...
Ovidiu Maxiniuc
05:58 PM Feature #4397: add database attrs, methods and options
4397a/11924 code review (cont)...
@DmoMeta.getPrimaryIndex@: in implicit primary index case, what constitutes the ...
Eric Faulhaber
02:10 PM Feature #4397: add database attrs, methods and options
Eric, the changes on @TemporaryBuffer@ are OK in regard with the temp-table copy. I saw that now there is support for... Adrian Lungu
03:07 AM Feature #4397: add database attrs, methods and options
4397a/11924 code review (cont):
@SSL.java@:328 contains the following comment:...
Eric Faulhaber
07:37 PM Feature #4397: add database attrs, methods and options
Eric Faulhaber wrote:
> I'm reviewing 4397a/11924. Since it's so big, I'm not going to present a single review of al...
Ovidiu Maxiniuc
07:25 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> It seems that the problem is that µ (Greek 'mu' in lowercase) does exist in @LATIN1@ char...
Igor Skornyakov
07:10 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Indeed, a closer look reveals that in all these records the field contains greek "mu" (lowe...
Igor Skornyakov
05:03 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> @0xce 0x9c@ looks like Greek uppercase M (https://vazor.com/unicode/c039C.html) u. The prob...
Igor Skornyakov
04:23 AM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> There are some very similar messages posted in #3871.
This was a result of my changes. I'v...
Igor Skornyakov

01/11/2021

06:51 PM Feature #1587: implement full support for word indexes
There are some very similar messages posted in #3871.
However, "this article":https://knowledgebase.progress.com/a...
Ovidiu Maxiniuc
02:54 PM Feature #1587: implement full support for word indexes
In the import of a large customer database I've got 4 errors for a single table on populating the related word table:... Igor Skornyakov
07:34 AM Feature #1587: implement full support for word indexes
Yes. In fact I think it must be fixed at runtime because otherwise we would not generate a warning at the same place... Greg Shah
06:36 AM Feature #1587: implement full support for word indexes
Is it OK if the discrepancy described in #1587-226 regarding subscript on array field in CONTAINS phrase will be fixe... Igor Skornyakov
06:27 AM Feature #1587: implement full support for word indexes
> I mean @extent_field_name CONTAINS something@. I understand that (@extent_field_name[index_expr] CONTAINS something... Igor Skornyakov
07:31 AM Feature #4397: add database attrs, methods and options
> If you want we can write some more tests to see how the dataset behaves when this odd situation occurs but imho thi... Greg Shah
04:10 AM Feature #4397: add database attrs, methods and options
I'm reviewing 4397a/11924. Since it's so big, I'm not going to present a single review of all the changes, but rather... Eric Faulhaber
02:11 AM Feature #4397: add database attrs, methods and options
Greg Shah wrote:
> Marian: What is your opinion of this bug?
That is definitively an undiscovered bug, no one pro...
Marian Edu
02:27 AM Bug #5030: xfer dataset test issues
Ovidiu Maxiniuc wrote:
> According to my old and new ABL reference manual and OpenEdge "online documentation":https:...
Marian Edu

01/10/2021

10:12 AM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> Igor Skornyakov wrote:
> > It seems that in 4GL the value of the @CONTAINS@ operator for the ext...
Igor Skornyakov
09:54 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> It seems that in 4GL the value of the @CONTAINS@ operator for the extent field is an OR of ...
Greg Shah
05:32 AM Feature #1587: implement full support for word indexes
It seems that in 4GL the value of the @CONTAINS@ operator for the extent field is an OR of @CONTAINS@ value for all i... Igor Skornyakov
05:24 AM Feature #1587: implement full support for word indexes
BTW: the @CONTAINS@ operator support based on UDF is also incorrect. The generated SQL statement still contains (for ... Igor Skornyakov
03:55 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > The import of the large customer database finished OK. However,...
Igor Skornyakov

01/09/2021

05:49 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> The import of the large customer database finished OK. However, I see in the log multiple s...
Igor Skornyakov
04:24 AM Feature #1587: implement full support for word indexes
The import of the large customer database finished OK. However, I see in the log multiple strange errors related to t... Igor Skornyakov

01/08/2021

03:54 PM Support #3871: determine how to change codepages/locales during import
Eric Faulhaber wrote:
> Are the code page changes in any way dependent upon the other changes unique to branch 1587b...
Igor Skornyakov
03:33 PM Support #3871: determine how to change codepages/locales during import
Are the code page changes in any way dependent upon the other changes unique to branch 1587b? If not, I would suggest... Eric Faulhaber
01:16 PM Support #3871: determine how to change codepages/locales during import
My changes for the codepage support on the database import seem to be not 100% correct - they prevent the normal impo... Igor Skornyakov
11:12 AM Support #3871: determine how to change codepages/locales during import
My changes seem to cause error on import the customer database:... Igor Skornyakov
11:27 AM Feature #1587: implement full support for word indexes
The branch 1587b was rebased to 3821c revision 11901.
Pushed up to revision 11920.
Igor Skornyakov
10:30 AM Bug #5072: exception loading _user meta table
There is this exception in FWD when trying to load the @_user@ meta table:... Constantin Asofiei
10:27 AM Bug #5072 (New): exception loading _user meta table
Constantin Asofiei

01/07/2021

05:41 PM Bug #5030: xfer dataset test issues
Marian,
I was re-running the test-sets again when I encountered the following issue: the same method responds in app...
Ovidiu Maxiniuc
03:34 PM Feature #4397: add database attrs, methods and options
Actually, never mind. I'll just do a fresh checkout. Eric Faulhaber
03:33 PM Feature #4397: add database attrs, methods and options
Ovidiu, I've updated then reverted (to adjust for an apparent rebase since my last update) my older checkout of 4397a... Eric Faulhaber
03:03 PM Feature #4397: add database attrs, methods and options
Greg Shah wrote:
> My initial reaction is that we probably should fix this. Can we potentially use a @Set@ to detec...
Ovidiu Maxiniuc
02:00 PM Feature #4397: add database attrs, methods and options
> At this moment all of the functionality specified in the first notes of this task is present in branch 4397a (lates... Greg Shah
11:46 AM Feature #4397: add database attrs, methods and options
Greg Shah wrote:
> Is it correct that all of the functionality needed for this task is complete in 4397a?
>
> Whe...
Ovidiu Maxiniuc
11:06 AM Feature #4397: add database attrs, methods and options
Is it correct that all of the functionality needed for this task is complete in 4397a?
When do you estimate comple...
Greg Shah
03:20 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> Where is your @testcases@ bound to?...
Igor Skornyakov
03:15 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> This is really strange:
> [...]
Where is your @testcases@ bound to?
> I see. Thank you...
Ovidiu Maxiniuc
03:01 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > Sorry, I meant @build_db.xml@
> Nope. @find /opt/testcases/ -i...
Igor Skornyakov
02:45 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Sorry, I meant @build_db.xml@
Nope. @find /opt/testcases/ -iname build_db.xml@ still canno...
Ovidiu Maxiniuc
02:36 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> Actually, there is no need for a full reconversion. Only the database support is required (...
Igor Skornyakov
02:27 PM Feature #1587: implement full support for word indexes
Actually, there is no need for a full reconversion. Only the database support is required (ddls and p2o), so running ... Ovidiu Maxiniuc
02:25 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> > I'm not sure this exists. Ovidiu?
> I cannot find any @import_db.xml@ in @xfer@ project....
Igor Skornyakov
02:19 PM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> I think that the conversion and import will take quite some time, right? These are just long run...
Igor Skornyakov
02:04 PM Feature #1587: implement full support for word indexes
> > OK, please go ahead with such a test. If the results are good, then the changes can be merged back into 3821c.
...
Greg Shah
02:00 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/...
Ovidiu Maxiniuc
01:58 PM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> OK, please go ahead with such a test. If the results are good, then the changes can be merged ba...
Igor Skornyakov
01:31 PM Feature #1587: implement full support for word indexes
OK, please go ahead with such a test. If the results are good, then the changes can be merged back into 3821c. Greg Shah
01:20 PM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> Has this been tested with any of the large customer applications which we are working on right no...
Igor Skornyakov
01:11 PM Feature #1587: implement full support for word indexes
Has this been tested with any of the large customer applications which we are working on right now? Greg Shah
12:49 PM Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> I would like you to please integrate the @words.p@ test case into the test cases project mor...
Igor Skornyakov
12:41 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/testcases/@ contains tasks ...
Eric Faulhaber
12:40 PM Feature #1587: implement full support for word indexes
Code review 1587b/11907:
The latest code changes look fine to me.
I would like you to please integrate the @wor...
Eric Faulhaber
07:25 AM Feature #1587: implement full support for word indexes
The @import_db.xml@ file at @sftp://ias@xfer.goldencode.com/opt/testcases/@ contains tasks for @h2@ and @postresql@ d... Igor Skornyakov
02:01 PM Feature #3574: finish implementation of temp-table XML support
From #4397-27:
> so I would say they should be handled as part of #3574. However, the separation line is rather th...
Greg Shah

01/06/2021

07:29 PM Bug #5030: xfer dataset test issues
According to my old and new ABL reference manual and OpenEdge "online documentation":https://documentation.progress.c... Ovidiu Maxiniuc

01/05/2021

01:38 PM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> I think we need to add support in this case, too. The previous implementation of @contains@...
Igor Skornyakov
01:20 PM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Please note that for the temp tables the @CONTAINS@ UDF is used at this moment.
> Do we re...
Ovidiu Maxiniuc
12:48 PM Feature #1587: implement full support for word indexes
Fixed @CONTAINS@ support for the temporary tables.
Committed to 1587b revision 11907.
Please note that for the te...
Igor Skornyakov
11:18 AM Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> The previous implementation used the @contains()@ methods from @pl/Functions.java@ in order...
Igor Skornyakov
10:49 AM Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I've noticed that for @H2@ the name of the @CONTAINS@ UDF in the AST processed by @FqlToSql...
Ovidiu Maxiniuc
08:58 AM Feature #1587: implement full support for word indexes
Eric: Please review and confirm if 1587b can be merged into 3821c. Greg Shah
08:30 AM Feature #1587: implement full support for word indexes
Finished word tables' support for H2.
Committed to 1587b revision 11906.
See the required changes to the import of ...
Igor Skornyakov
04:54 AM Feature #1587: implement full support for word indexes
I've noticed that for @H2@ the name of the @CONTAINS@ UDF in the AST processed by @FqlToSqlConverter@ is "contains_1"... Igor Skornyakov
12:33 PM Bug #5030: xfer dataset test issues
I have identified a OE bug that bothers me for some time. The @copy-temp-table@'s 2 parameter (@replace-mode@) is lea... Ovidiu Maxiniuc

01/04/2021

08:32 AM Feature #1587: implement full support for word indexes
In addition to #1587-190.
After enabling debug mode I in the trace file that @H2@ inserts and removes the same recor...
Igor Skornyakov
07:20 AM Feature #1587: implement full support for word indexes
I've encountered the following problem with @H2@ trigger when I try to insert multiple rows to the word table:
* If ...
Igor Skornyakov
08:06 AM Feature #3958: BUFFER-COPY optimization
I noticed something off in the current @BaseRecord.setAllDatum()@ implementation. This is used, according to #3958-7,... Adrian Lungu

12/30/2020

02:58 PM Feature #1587: implement full support for word indexes
Greg Shah wrote:
> FWD H2 databases are created with the "p2jspi.jar":/projects/p2j/wiki/Application_Server_Installa...
Igor Skornyakov
01:53 PM Feature #1587: implement full support for word indexes
FWD H2 databases are created with the "p2jspi.jar":/projects/p2j/wiki/Application_Server_Installation#Text-Collator p... Greg Shah
12:47 PM Feature #1587: implement full support for word indexes
I've encountered a strange error trying to connect to FWD H2 database with my favorite database client @dbeaver@. I'v... Igor Skornyakov
 

Also available in: Atom