FWD » Core Development » Database

06/18/2021

03:12 PM Bug #5476: Bug in Java UDF addinterval(date, ...)

The statement @select public.addinterval(date '1999-01-08', 1, 'months')@ works fine, while @select public.addinterva... Igor Skornyakov

03:11 PM Bug #5476 (New): Bug in Java UDF addinterval(date, ...)

Igor Skornyakov

06/15/2021

07:12 PM Feature #5453: optimize FindQuery hasOne and hasAny implementations

Alternatively, we can keep the record in session cache, hoping a future query will have the result already fetched. U... Ovidiu Maxiniuc

12:15 PM Feature #5453: optimize FindQuery hasOne and hasAny implementations

We currently convert standalone CAN-FIND calls to use @FindQuery.hasAny@ or @FindQuery.hasOne@. These methods will fe... Eric Faulhaber

12:09 PM Feature #5453 (New): optimize FindQuery hasOne and hasAny implementations

Eric Faulhaber

07:05 PM Bug #5452: eliminate use of ResultSet.CONCUR_UPDATABLE?

You are right. Since we always fetch the data from the @ResultSet@ s and use it to hydrate our own @Record@ s there i... Ovidiu Maxiniuc

12:07 PM Bug #5452: eliminate use of ResultSet.CONCUR_UPDATABLE?

Ovidiu, while debugging a few days ago, I came across this in @SQLQuery.scroll(Session, int, boolean, List<RowStructu... Eric Faulhaber

12:00 PM Bug #5452 (Closed): eliminate use of ResultSet.CONCUR_UPDATABLE?

Eric Faulhaber

06/14/2021

06:15 PM Bug #5289: Misc. problems with triggers

Eric Faulhaber wrote:
> Is bullet point 3 (NPE in @PreselectQuery@ for FIND trigger) in #5289-1 the only thing left ... Ovidiu Maxiniuc

02:55 PM Bug #5289: Misc. problems with triggers

Is bullet point 3 (NPE in @PreselectQuery@ for FIND trigger) in #5289-1 the only thing left in this task?
Were you... Eric Faulhaber

02:57 PM Support #3871 (Closed): determine how to change codepages/locales during import

Greg Shah

08:07 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> Please do not re-use branches once they have been merged. Please extract your changes and ei... Igor Skornyakov

09:12 PM Feature #3930 (Closed): allow session level control over the database(s) which are auto-connected

Eric Faulhaber

06/13/2021

07:56 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> Get rid of the notion of the permanent connection.
>
> Committed to 3930a revision 12499... Eric Faulhaber

04:29 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Get rid of the notion of the permanent connection.
Committed to 3930a revision 12499.
The notion of the transient... Igor Skornyakov

07:42 PM Bug #5440: finish DatabaseManager refactoring for implicit/explicit connections

Issue #3930 added session level control over database connections (in the 4GL sense, not the JDBC sense). These conne... Eric Faulhaber

07:11 PM Bug #5440 (New): finish DatabaseManager refactoring for implicit/explicit connections

Eric Faulhaber

06/11/2021

05:06 PM Bug #5289: Misc. problems with triggers

Yes, attempt to improve generics was rolled back in r12522. It was reported by other colleagues which compiled newly ... Ovidiu Maxiniuc

03:46 AM Bug #5289: Misc. problems with triggers

Is the generics regression in @DatabaseTriggerManager@ which was causing converted code to not compile fixed in 3821c... Eric Faulhaber

10:59 PM Bug #5289: Misc. problems with triggers

I committed the fix for REPLICATION and improved management of table triggers (including veto support) in r12468 and ... Ovidiu Maxiniuc

04:54 PM Support #3871: determine how to change codepages/locales during import

Indeed, the usage of static configuration on client side (added in r12499) was incorrect so was reverted in 12502.
I... Ovidiu Maxiniuc

07:10 AM Support #3871: determine how to change codepages/locales during import

Code Review Task Branch 3821c Revision 12502
The changes are good.
Isn't there still an issue with calling @Con... Greg Shah

10:45 PM Support #3871: determine how to change codepages/locales during import

The revision 12502 of 3821c handles the issues and suggestions from the ode review:
* the @CharsetConverter@ which w... Ovidiu Maxiniuc

03:41 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> For the remaining cleanup, please note that the explicit connections really shouldn't be tre... Igor Skornyakov

03:33 PM Feature #3930: allow session level control over the database(s) which are auto-connected

For the remaining cleanup, please note that the explicit connections really shouldn't be treated much differently tha... Eric Faulhaber

06/02/2021

05:13 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Merged to 3821c/12490. Igor Skornyakov

12:34 AM Feature #3930: allow session level control over the database(s) which are auto-connected

The changes in 3930a revs 12482-3 look good. Please add the more detailed javadoc and clean up the code to coding sta... Eric Faulhaber

06/01/2021

05:14 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> Please move the @autoConnect@ method to @DatabaseManager@ (#3930-118) and remove the first l... Igor Skornyakov

05/31/2021

06:59 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> We have covered a lot of ground...could you please review and report what is left to do befo... Igor Skornyakov

06:48 AM Feature #3930: allow session level control over the database(s) which are auto-connected

We have covered a lot of ground...could you please review and report what is left to do before we can consider this t... Eric Faulhaber

06:34 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> Code review 3930a/12481:
> Please move the @autoConnect@ method to @DatabaseManager@ (#3930... Igor Skornyakov

06:29 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Code review 3930a/12481:
Thanks for making these changes.
Please move the @autoConnect@ method to @DatabaseMana... Eric Faulhaber

05:59 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > Do you mean that I should make this more explicit by using @Cont... Igor Skornyakov

05/30/2021

05:20 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > Do you mean that I should make this more explicit by using @Cont... Igor Skornyakov

05:16 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> Do you mean that I should make this more explicit by using @ContextLocal@? This will of cou... Eric Faulhaber

05:10 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> Your understanding about deactivation is correct, but I don't agree with the conclusion you'... Igor Skornyakov

04:50 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > I am not suggesting reference counters and I don't see how using... Eric Faulhaber

03:28 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> I am not suggesting reference counters and I don't see how using @ContextLocal@ prevents pro... Igor Skornyakov

03:14 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > * The implementation uses @SessionListener@ for cleanup purposes... Eric Faulhaber

05/28/2021

03:17 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> * The concept of "permanent" and "transient" databases, and the use of the @load_at_startup@... Igor Skornyakov

05/27/2021

04:19 PM Feature #2617 (Closed): implement RCODE-INFORMATION attributes

Greg Shah

03:18 PM Feature #2617: implement RCODE-INFORMATION attributes

Greg Shah wrote:
> Please update the gap marking.
Done in 3821c rev 12464. Constantin Asofiei

02:50 PM Feature #2617: implement RCODE-INFORMATION attributes

Code Review Task Branch 3821c Revision 12462
The changes are good.
Please update the gap marking. Greg Shah

08:06 AM Feature #2617 (WIP): implement RCODE-INFORMATION attributes

FILENAME, DB-REFERENCES and IS-CLASS were added to 3821c rev 12462 Constantin Asofiei

01:09 PM Support #3871: determine how to change codepages/locales during import

Than you for the quick code review.
I will remove the @CharsetConverter@ accessors. It is a clever way to handle c... Ovidiu Maxiniuc

11:53 AM Support #3871: determine how to change codepages/locales during import

Code Review Task Branch 3821c Revision 12459
The changes are a nice improvement.
1. @FileStream.getCc()@ and @F... Greg Shah

10:21 PM Support #3871: determine how to change codepages/locales during import

Now the requested text decoder is used when processing dump files.
At the same time, I fixed support for processing ... Ovidiu Maxiniuc

11:14 AM Bug #5289 (WIP): Misc. problems with triggers

No, not yet.
I am waiting to finish the ASSIGN triggers work, too, and commit all in a single unified commit. I esti... Ovidiu Maxiniuc

07:59 AM Bug #5289: Misc. problems with triggers

Are those change in 3821c? Greg Shah

10:28 PM Bug #5289: Misc. problems with triggers

Yes, the REPLICATION triggers work correctly now (pending commit).
I also added/fixed vetoing support for some trigg... Ovidiu Maxiniuc

03:41 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> I think there was a miscommunication or misunderstanding with #3930-11. I was trying to conv... Igor Skornyakov

03:33 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Constantin Asofiei wrote:
> The token support is already in FWD, and the directory utility APIs already have this (a... Igor Skornyakov

09:35 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > * The concept of "permanent" and "transient" databases, and the ... Eric Faulhaber

05/26/2021

04:27 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> * The concept of "permanent" and "transient" databases, and the use of the @load_at_startup@... Igor Skornyakov

03:42 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I prefer to avoid reference counters as it is a fragile tech... Igor Skornyakov

03:34 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> I prefer to avoid reference counters as it is a fragile technique. With @ContextLocal@ I... Eric Faulhaber

03:27 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> * The implementation uses @SessionListener@ for cleanup purposes and adds references to netw... Igor Skornyakov

03:16 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> I am starting my code review. I will have more detailed feedback later, but on a quick first... Igor Skornyakov

03:12 PM Feature #3930: allow session level control over the database(s) which are auto-connected

I am starting my code review. I will have more detailed feedback later, but on a quick first pass, I noticed a few pr... Eric Faulhaber

02:50 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Constantin Asofiei wrote:
> Sorry, I didn't notice that. Use @database-connections.prj@.
I see, Thank you. At thi... Igor Skornyakov

02:47 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Sorry, I didn't notice that. Use @database-connections.prj@. Constantin Asofiei

02:44 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Constantin. Where exactly I should add this node?
> As a si... Igor Skornyakov

02:40 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> Constantin. Where exactly I should add this node?
As a sibling of the @auto-connect@ node. Constantin Asofiei

02:38 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Constantin Asofiei wrote:
> The token support is already in FWD, and the directory utility APIs already have this (a... Igor Skornyakov

02:30 PM Feature #3930: allow session level control over the database(s) which are auto-connected

> I had not considered this feature. Constantin, the implementation so far only reads from the directory. What needs ... Greg Shah

02:28 PM Feature #3930: allow session level control over the database(s) which are auto-connected

The token support is already in FWD, and the directory utility APIs already have this (at least the @Utils.getDirecto... Constantin Asofiei

02:25 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, does the @auto-connect@ directory configuration suppor... Eric Faulhaber

02:15 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Constantin Asofiei wrote:
> Igor, does the @auto-connect@ directory configuration support the 'project token' approa... Igor Skornyakov

01:52 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor, does the @auto-connect@ directory configuration support the 'project token' approach? Here I mean that the cli... Constantin Asofiei

07:23 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> There is a regression caused by my changes in a large customer application. Analyzing.
T... Igor Skornyakov

04:59 AM Feature #3930: allow session level control over the database(s) which are auto-connected

There is a regression caused by my changes in a large customer application. Analyzing. Igor Skornyakov

07:38 AM Bug #5289: Misc. problems with triggers

Ovidiu: From emails, I know you have some of these issues resolved. Please document the status here.
If we can ge... Greg Shah

08:23 PM Support #5183: database collation

I've reviewed the output of the @cp_coll.p@ program from several environments:
* en_US / 8859-1
** Linux
** Wind... Eric Faulhaber

05/25/2021

03:53 PM Feature #3930: allow session level control over the database(s) which are auto-connected

The functionality is implemented and tested with the test app. Will test with the real customer app.
Committed to ... Igor Skornyakov

05/21/2021

01:39 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> That being said, I'm not sure that code looks right now...what if we had two @database@ keys... Igor Skornyakov

01:33 PM Feature #3930: allow session level control over the database(s) which are auto-connected

That being said, I'm not sure that code looks right now...what if we had two @database@ keys mapped to the same @Sess... Eric Faulhaber

01:13 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> The current @deregisterDatabase@ code is just about cleaning up local data structures when a... Igor Skornyakov

01:12 PM Feature #3930: allow session level control over the database(s) which are auto-connected

The current @deregisterDatabase@ code is just about cleaning up local data structures when a database connection ends... Eric Faulhaber

01:05 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > As far as I understand the same logic is used for local data... Igor Skornyakov

01:02 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor Skornyakov wrote:
> As far as I understand the same logic is used for local databases as well. Should I fix i... Eric Faulhaber

12:56 PM Feature #3930: allow session level control over the database(s) which are auto-connected

Eric Faulhaber wrote:
> IIRC, for remote connections, we create one virtual session between server A and server B, r... Igor Skornyakov

12:40 PM Feature #3930: allow session level control over the database(s) which are auto-connected

IIRC, for remote connections, we create one virtual session between server A and server B, regardless of how many use... Eric Faulhaber

06:51 AM Feature #3930: allow session level control over the database(s) which are auto-connected

I'm confused with the following code in the @ConnectionManager.disconnectImmediately()@:... Igor Skornyakov

03:04 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Constantin Asofiei wrote:
> Igor, as I mentioned - Agents can reset their context (for State-reset mode) - in this c... Igor Skornyakov

02:01 AM Feature #3930: allow session level control over the database(s) which are auto-connected

Igor, as I mentioned - Agents can reset their context (for State-reset mode) - in this case, I think these databases ... Constantin Asofiei

12:46 PM Support #5183 (WIP): database collation

Eric Faulhaber