Project

General

Profile

Activity

From 07/15/2022 to 08/13/2022

08/13/2022

09:31 PM Feature #6348: implement support for MariaDB
The revision 14156 brings several improvements for the dialect:
* I noticed they released a new GA JDBC driver (3.0.... Ovidiu Maxiniuc

08/12/2022

04:22 PM Feature #6450: buffer/buffer-field features
I did not work with 6129a lately so I had to update the branch and review those changes. Constantin did the rebase ag... Ovidiu Maxiniuc
10:47 AM Feature #6450: buffer/buffer-field features
Ovidiu, I see there was a review cycle in #6502 and a commit of your changes to 6129a. Given that, is there anything ... Eric Faulhaber
03:19 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
In 3821c/14153. *157* of *219* UDFs are ported from PostrgreSQL to MariaDB.
So, all 'simple' UDFs have been ported... Igor Skornyakov
01:49 PM Feature #6348: implement support for MariaDB
How to configure your test project to work with @MariaDb@:
* update your @cfg/p2j.cfg.xml@ to add generation of DDL ... Ovidiu Maxiniuc
01:33 PM Feature #6348: implement support for MariaDB
I did a basic write/read from database test. It seems to be working, but I did not use any fancy queries.
I used t... Ovidiu Maxiniuc

08/11/2022

02:32 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > Exactly. Any objections?
>
> No, seems like a good approa... Igor Skornyakov
02:27 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> Exactly. Any objections?
No, seems like a good approach.
I would like to get the in... Eric Faulhaber
02:19 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> If I understand your process correctly, it looks like you are doing an automated port of the... Igor Skornyakov
02:17 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
If I understand your process correctly, it looks like you are doing an automated port of the "scaffolding" from the P... Eric Faulhaber
02:13 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > It appears that we should use @DECIMAL(65, 38)@ instead of @NUME... Igor Skornyakov
02:05 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> It appears that we should use @DECIMAL(65, 38)@ instead of @NUMERIC@ in UDFs.
Shouldn't ... Eric Faulhaber
01:59 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
In 3821c/14150. *55* of *219* UDFs are ported from PostrgreSQL to MariaDB.
Please do not be too optimistic. The po... Igor Skornyakov
12:45 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
It appears that we should use @DECIMAL(65, 38)@ instead of @NUMERIC@ in UDFs. Igor Skornyakov
03:13 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> I just looked at this again and noticed that some of the mappings ... Igor Skornyakov
01:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> [...]
> In fact the MariaDB data types a not very different from PostgreSQL ones. See the ... Eric Faulhaber

08/10/2022

05:24 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> > I'm ok with your naming convention, though where the mapped data types differ in name for... Ovidiu Maxiniuc
03:12 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Created MariaDB UDFs templates.
Committed to 3821c/14145. Igor Skornyakov
02:39 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> We had a similar issue with H2 and we resolved it by prepending an underscore followed by a ... Igor Skornyakov
02:06 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
We had a similar issue with H2 and we resolved it by prepending an underscore followed by a unique integer (for that ... Eric Faulhaber
01:38 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> I've realized that in MariaDB we cannot have two UDFs with the same name but different sign... Igor Skornyakov
01:24 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
I've realized that in MariaDB we cannot have two UDFs with the same name but different signatures.
This requires cha... Igor Skornyakov
08:01 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
At this moment I see the following plan
# Create an @AWK@ script for automatic conversion of the udfs.sql script for... Igor Skornyakov
05:10 PM Feature #6371: implement SAVE CACHE statement
Pushed revision 6371a/14096 with JavaDoc and indexes. Boris Schegolev
01:14 PM Feature #6371: implement SAVE CACHE statement
If the cost is not high, making an implicit @SAVE CACHE@ call at server startup will make the system more resilient/s... Greg Shah
01:11 PM Feature #6371: implement SAVE CACHE statement
The persistence of the DMOs is a good point. We would want these to load like any other DMOs, if no schema changes ha... Eric Faulhaber
12:49 PM Feature #6371: implement SAVE CACHE statement
Also, I wonder if we should even do this persisting for generated DMOs for dynamic temp-tables (at least if they are ... Greg Shah
12:47 PM Feature #6371: implement SAVE CACHE statement
Another difference from dynamic temp-tables: the generated DMOs must survive server restarts (or must be recreated on... Greg Shah
12:35 PM Feature #6371: implement SAVE CACHE statement
After detecting schema differences, we need to inspect/apply/walk these to generate the correct DMO interfaces. DMO i... Eric Faulhaber
11:19 AM Feature #6371: implement SAVE CACHE statement
Let's go with XML for persisting each "snapshot" state, which will be used for later comparisons. TBD: do we need to ... Eric Faulhaber

08/09/2022

05:45 PM Feature #6371: implement SAVE CACHE statement
XML is more consistent with the rest of the configuration in FWD. Greg Shah
04:59 PM Feature #6371: implement SAVE CACHE statement
I pushed revision 6371a/14095 with code to support comparison for tables and columns. Also, extended the javadoc on t... Boris Schegolev
11:20 AM Feature #6371: implement SAVE CACHE statement
Eric Faulhaber wrote:
> Boris Schegolev wrote:
> > Saved state will consist of tables, columns and index lists. Thi... Tijs Wickardt
11:02 AM Feature #6371: implement SAVE CACHE statement
Eric Faulhaber wrote:
> Boris, please commit all your updates to 6371a. You are the only one changing this branch, s... Eric Faulhaber
10:56 AM Feature #6371: implement SAVE CACHE statement
Boris Schegolev wrote:
> Saved state will consist of tables, columns and index lists. This object can be serialized ... Eric Faulhaber
10:47 AM Feature #6371: implement SAVE CACHE statement
Boris, please commit all your updates to 6371a. You are the only one changing this branch, so it is safe. This will m... Eric Faulhaber
11:55 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
If the JSON array approach seems to be the only viable option, I think we have to use it for now. Another alternative... Eric Faulhaber

08/05/2022

02:35 PM Feature #6371: implement SAVE CACHE statement
Implemented @DatabaseState@ object, @Difference@ object and loading / comparison for tables. Please, review. Boris Schegolev
12:04 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
There is a about a couple of dozens of PostgreSQL native UDFs (~10%) that heavily use arrays and/or user-defined data... Igor Skornyakov

08/04/2022

06:18 AM Feature #6348: implement support for MariaDB
Greg Shah wrote:
> > However supporing word indexes for non-normalized extent fields can be not strightforward.
>
... Igor Skornyakov
05:50 AM Feature #6348: implement support for MariaDB
> However supporing word indexes for non-normalized extent fields can be not strightforward.
Is it possible to use... Greg Shah
12:38 AM Feature #6348: implement support for MariaDB
Eric Faulhaber wrote:
> Agreed, we should not have logic that begins @if (dialect instanceof *Dialect) ...@.
>
I'... Igor Skornyakov
10:59 PM Feature #6348: implement support for MariaDB
Ovidiu Maxiniuc wrote:
> Yes, I noticed that @WordTable@ class and some methods of @DDLGeneratorWorker@ are not full... Eric Faulhaber

08/03/2022

04:39 PM Feature #6371: implement SAVE CACHE statement
Saved state will consist of tables, columns and index lists. This object can be serialized using common methods (YAML... Boris Schegolev
12:41 AM Feature #6371: implement SAVE CACHE statement
Boris Schegolev wrote:
> I am attaching a proposal for Schema Comparator service. It would be invoked like:
>
> [... Eric Faulhaber
03:52 PM Feature #6348: implement support for MariaDB
Yes, I noticed that @WordTable@ class and some methods of @DDLGeneratorWorker@ are not fully dialect independent. The... Ovidiu Maxiniuc
02:56 PM Feature #6348: implement support for MariaDB
Please note that @CONTAINS@ (word tables') support for MariaDB will also need some some efforts (we need MariaDB-spec... Igor Skornyakov
01:10 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Please see #6348-7. In fact, it would be good to review that whole task.
Thank you, revie... Igor Skornyakov
12:52 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Please see #6348-7. In fact, it would be good to review that whole task. Eric Faulhaber
12:11 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Have we already made a decision about datatypes' mapping for MariaDB?
At this moment the most important for me are s... Igor Skornyakov

08/01/2022

03:42 PM Feature #6371: implement SAVE CACHE statement
I am attaching a proposal for Schema Comparator service. It would be invoked like:... Boris Schegolev
02:32 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Ovidiu Maxiniuc wrote:
> I used the following command:
> [...]
>
> That installed for me:
> [...]
>
> I do n... Igor Skornyakov
02:22 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
I used the following command:... Ovidiu Maxiniuc
01:27 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Working with version 10.8.3 Igor Skornyakov
12:45 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> Which version of MariaDB should I work with?
The most recent production build (10.8, AFA... Eric Faulhaber
04:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Which version of MariaDB should I work with?
Thank you. Igor Skornyakov

07/31/2022

03:41 PM Feature #6628 (WIP): port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov

07/29/2022

01:25 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> I understand that MariaDB does not have arrays
Not as a first class data type, no, but p... Eric Faulhaber

07/27/2022

04:02 PM Bug #6599: minimal mode conversion problem with DMO name collision
Eric, minimal mode conversion was added after I my @NameConverter.java@ change - and conversion was fine, until the r... Constantin Asofiei
03:43 PM Bug #6599: minimal mode conversion problem with DMO name collision
Constantin, it looks like you made this change very early in 6129a (rev 13815), apparently to address cases of confli... Eric Faulhaber
06:15 AM Bug #6599: minimal mode conversion problem with DMO name collision
Eric, can this be fixed? Although is not a problem when running the converted code, this is a problem when executing... Constantin Asofiei
03:33 AM Support #4701: try to improve H2 transaction commit performance
I just noticed that H2 is moving kinda fast with no more than 5 releases in the last couple of months. I can't tell i... Alexandru Lungu

07/25/2022

03:56 AM Feature #6582: implement multi-table AdaptiveQuery
Alexandru Lungu wrote:
> I've done a bit of query exploring. I converted the following example:
>
> [...]
>
> ... Igor Skornyakov
03:38 AM Feature #6582: implement multi-table AdaptiveQuery
I've done a bit of query exploring. I converted the following example:... Alexandru Lungu

07/24/2022

01:28 PM Feature #6582: implement multi-table AdaptiveQuery
Alexandru Lungu wrote:
> I was rather thinking if there are implications of @FIRST/LAST@ and @OUTER-JOIN@ when doing... Igor Skornyakov
06:06 AM Feature #6582: implement multi-table AdaptiveQuery
Eric Faulhaber wrote:
> The ideal scenario is that we start in preselect (fast) mode and we only ever transition to ... Alexandru Lungu
05:08 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
It looks that in migration of the PostgreSQL native UDFs to MariaDB the most efforts will require those UDFs that use... Igor Skornyakov

07/23/2022

01:50 PM Feature #6582: implement multi-table AdaptiveQuery
As far as I understand the approach described in #6582-9 works with MariaDB 10.2+ as well. Igor Skornyakov
07:44 AM Feature #6582: implement multi-table AdaptiveQuery
Alexandru Lungu wrote:
>Also, I didn't consider yet other aspects as: FIRST/LAST or OUTER-JOIN.
I can suggest the f... Igor Skornyakov
04:28 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Igor, can you think of a way to generate a list of the PostgreSQL built-in functions (includ... Igor Skornyakov

07/22/2022

06:07 PM Feature #6630: optimize return of table parameter
While working on a related issue I noticed the following stack trace:... Ovidiu Maxiniuc
05:55 PM Feature #6630 (Closed): optimize return of table parameter
Ovidiu Maxiniuc
02:25 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> So far, so good...
>
> [...]
Please note the PostreSQL UDF raise both @ERROR@ and @NOT... Igor Skornyakov
02:20 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
So far, so good...... Eric Faulhaber
01:06 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Igor, can you think of a way to generate a list of the PostgreSQL built-in functions (includ... Igor Skornyakov
01:05 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> Greg Shah wrote:
>
> > I suspect that error handling will be a problem.
>
> I guess yo... Eric Faulhaber
01:01 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber wrote:
> What are the technical prerequisites a database implementation must have for word index su... Igor Skornyakov
01:01 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Greg Shah wrote:
> I suspect that error handling will be a problem.
I guess you're right, based on the answers ... Eric Faulhaber
12:55 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor, can you think of a way to generate a list of the PostgreSQL built-in functions (including signatures) upon whic... Eric Faulhaber
12:42 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Igor Skornyakov wrote:
> Please note also that it is makes sense to check how the words tables' support can be porte... Eric Faulhaber
12:40 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Looping in SQL can be simulated using "Common Table Expressions":https://en.wikipedia.org/wiki/Hierarchical_and_recur... Greg Shah
12:24 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Please note also that it is makes sense to check how the words tables' support can be ported to MariaDB. Igor Skornyakov
12:11 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
We need a robust library of UDFs for MariaDB to represent 4GL built-in functions used in WHERE clauses, which referen... Eric Faulhaber
11:50 AM Feature #6628 (WIP): port PostgreSQL native user defined functions to MariaDB
Eric Faulhaber
12:07 PM Feature #6348: implement support for MariaDB
Greg Shah wrote:
> > Greg: I know Roger was keeping the documentation/license project up-to-date, but is there a wik... Ovidiu Maxiniuc
07:50 AM Feature #6348: implement support for MariaDB
> Greg: I know Roger was keeping the documentation/license project up-to-date, but is there a wiki with the steps nee... Greg Shah
04:00 AM Feature #6348: implement support for MariaDB
With 3821c/14095 change of build.gradle, this was added:... Constantin Asofiei
11:46 AM Feature #6582: implement multi-table AdaptiveQuery
Alexandru Lungu wrote:
> I got the time to familiarize myself with @AdaptiveQuery@. I understood the motivation for ... Eric Faulhaber
10:41 AM Feature #6582: implement multi-table AdaptiveQuery
I got the time to familiarize myself with @AdaptiveQuery@. I understood the motivation for the "adaptive" part, but n... Alexandru Lungu
10:07 AM Feature #6582: implement multi-table AdaptiveQuery
Alexandru Lungu wrote:
> Eric Faulhaber wrote:
> > Alexandru, please review the existing @AdaptiveQuery@ implementa... Eric Faulhaber

07/20/2022

07:53 PM Feature #6348: implement support for MariaDB
A first revision of FWD with partial support for MariaDb dialect was committed in 14095:
* the build script will fet... Ovidiu Maxiniuc
08:20 PM Feature #6348: implement support for MariaDB
Some observations on data types resulted from the attempt to create a (partial) database from generated DDL for Maria... Ovidiu Maxiniuc
04:51 AM Bug #6577 (Review): move RecordBuffer.ooFields at the DMO meta
3821c/14090 - RecordBuffer instance fields can not be accessed directly from static methods - their getter must be us... Constantin Asofiei

07/19/2022

03:20 PM Feature #6418: represent extent fields as arrays
Downsides of the JSON approach:
* The syntax is pretty messy since you have to use functions to access/set element... Greg Shah
01:57 PM Feature #6418: represent extent fields as arrays
Eric Faulhaber wrote:
> AFAICT, MariaDB offers no native array data type which can be assigned to a column. The re... Eric Faulhaber
12:55 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface
Greg Shah wrote:
> This is a reasonable restriction. Let's just make sure the limitation is clearly documented.
I a... Ovidiu Maxiniuc
11:53 AM Feature #6584 (Review): implement schema hint which generates a POJO in addition to a DMO interface
Greg Shah wrote:
> I made some minor edits to the doc. Please review.
Thank you for your contribution. I moved t... Ovidiu Maxiniuc
08:41 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface
I made some minor edits to the doc. Please review. Greg Shah
08:36 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface
I took a quick look at the docs. It looks good. Please move it to here:
"Using POJOs for Database Entities":/pro... Greg Shah
09:14 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface
The documentation can be found at:
https://proj.goldencode.com/projects/timco/wiki/POJOs_-_Tutorial#section-8
I c... Ovidiu Maxiniuc

07/18/2022

02:30 PM Feature #6371: implement SAVE CACHE statement
Constantin Asofiei wrote:
> There is a compile error in 3821c/14083:
> [...]
>
> Boris: when committing somethin... Boris Schegolev
09:50 AM Feature #6371: implement SAVE CACHE statement
There is a compile error in 3821c/14083:... Constantin Asofiei
12:28 PM Bug #5673: Additional support for INDEXED REPOSITION open query attribute
The issue which required support for @INDEXED-REPOSITION@ was using a @REPOSITION-TO-ROWID@. I can't recall if this w... Alexandru Lungu
04:59 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface
In 3821c/14082 I've added support for Java enums and, if there is no FWD serializer registered for the given type, de... Constantin Asofiei

07/16/2022

05:49 PM Feature #6348 (WIP): implement support for MariaDB
Started adding support for the new database by implementation of the @MariaDbDialect.java@. On Monday I will continue... Ovidiu Maxiniuc

07/15/2022

03:35 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface
Constantin,
I know you worked with JSON probably more than any of us. Do you have an API which serialize a POJOs an... Ovidiu Maxiniuc
01:38 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface
I committed the (final ?) version of the POJO/DMO marshalling solution. Revision is 14075.
To summarize:
* the PO... Ovidiu Maxiniuc
09:13 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface
Constantin Asofiei wrote:
> I don't think is OK to be using the SQL types:
> * date/datetime/datetime-tz should all... Ovidiu Maxiniuc
12:14 AM Feature #6574 (Closed): auto-detect native UDFs at server startup and install them if missing
The changes in 3821c/14066 look good.
Note: to ensure missing native UDFs are installed, entries for @admin_userna... Eric Faulhaber
 

Also available in: Atom