Activity

From 03/26/2023 to 04/24/2023

04/24/2023

05:30 PM Feature #6371: implement SAVE CACHE statement: Code review 6371d/14544:
One *very minor* change: please fix the open curly brace at @SchemaComparator.java@:149 t... Eric Faulhaber
06:50 AM Feature #6371: implement SAVE CACHE statement: I was asked to test this statement. I will not be able to have a look at this soon, probably not even before summer v... Jurjen Dijkstra
01:42 PM Bug #7258 (Test): Optimize INDEX-INFORMATION with closed dynamic queries: @7258a.patch@ looks fine. The code in @DynamicQueryHelper@ looks much cleaner now. Good job! Ovidiu Maxiniuc
04:25 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: Ovidiu, I am planning to merge 7258a today. Move this to Test after you check #7158-7: these are the same changes as ... Alexandru Lungu
09:00 AM Bug #7035: Extract query parameters from statically converted FQL: I created the temporary *JMX* and added counters for meta, temp, dirty and persistent database hits/misses. The count... Dănuț Filimon
06:46 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Review to 7138a_h2/rev.17* : I am OK with the changes.
Danut, please re-test 7138a_h2 (own test-cases, large cust... Alexandru Lungu
05:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the ... Greg Shah
05:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Radu, let the intended changes for #7194 reside in 7026c. I am thinking of merging 7026c independently from 7066a, as... Alexandru Lungu
05:30 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select: *Review of #7235 patch in #7235-3.*
* When you append the NUM_LITERAL, you also append SELECT (which is OK). You u... Alexandru Lungu

04/22/2023

02:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the br... Maciej Zieniuk

04/21/2023

04:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
> That seems reasonabl... Ovidiu Maxiniuc
08:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
>
> That seems reaso... Marian Edu
07:55 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: > I am thinking about making a change to the FWD code, to something like:
That seems reasonable if the @unableToAs... Greg Shah
07:23 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I've pushed a bunch of changes in @testcases@, we took out @tests@, @support@ from @PROPATH@ and added missing 'stand... Marian Edu
06:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: The @TestNamespaceUri.cls@ method @TestSetInvalid@ is outdated and needs to be corrected.
Below procedure result i... Maciej Zieniuk
10:23 AM Bug #7185: H2 in-memory lazy hydration: Rebased 7185a_h2 to trunk rev. 15. Not it is at rev. 20.
Committed 7185a_h2/rev. 21 including some extra optimizatio... Alexandru Lungu

04/20/2023

07:42 AM Bug #7258 (Review): Optimize INDEX-INFORMATION with closed dynamic queries: Committed fix to 7258a/rev. 14544. It is ready to merge.
I've run some regression tests and everything looks right.
... Alexandru Lungu
07:35 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: Radu, can you please make a statistic in a dummy Java project for:
* 10,000 JDBC statements doing @select tt.* from ... Alexandru Lungu
07:14 AM Bug #7174 (Test): Resolve simple CAN-FIND statements faster: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
07:13 AM Bug #7165: Close multiplex scope using prepared statement: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
07:13 AM Bug #5306 (Test): AdaptiveQuery sets a found record into the buffer twice in dynamic mode: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
07:12 AM Feature #7060 (Test): Consider using wildcard selection to reduce SQL size: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
07:12 AM Feature #7062 (Test): Direct access to H2 internals to solve basic queries: This was merged in trunk as rev. 14523 and can be closed. Alexandru Lungu
04:56 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Constantin Asofiei wrote:
> ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar
Good.
Greg, Eric:... Alexandru Lungu
04:35 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> The @tests/dataset/TestXmlNodeType.cls@ have a line during the setup, which runs some other ... Marian Edu

04/19/2023

04:00 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database: Code review 6812a/14487:
Sorry for the delay in reviewing. A lot of changes have gone in to trunk in the meantime;... Eric Faulhaber
03:27 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Thanks Marian.
But I think i am doing something wrong.
The @tests/dataset/TestXmlNodeType.cls@ have a line during... Maciej Zieniuk
06:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Marian Edu wrote:
> That one was moved in a different location under support folder only forgot to push the changes ... Marian Edu
05:12 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: Maciej Zieniuk wrote:
> I have few tests passing, but there are few which will definitively not run.
> As an exampl... Marian Edu
12:49 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar Constantin Asofiei
09:43 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Alexandru Lungu wrote:
> Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial f... Dănuț Filimon
07:09 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial for the performance tests t... Alexandru Lungu
06:41 AM Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses: Alexandru Lungu
06:34 AM Feature #7066: Implement multi-table indexed query in H2: I've committed to 7066a. rev. 14528 the following things:
* @use_index@ is now used only in multi-table scenarios an... Radu Apetrii
05:22 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select: I've attached a patch for the current issue.
When using the function *exists* and the first child is of type @SUBSEL... Dănuț Filimon

04/18/2023

04:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: I have few tests passing, but there are few which will definitively not run.
As an example, the @tests/dataset/TestA... Maciej Zieniuk
10:06 AM Bug #7185: H2 in-memory lazy hydration: Committed 7185a_h2/rev. 19.
It includes optimization for @FWDDirectAccess.retrieveResponse@:
* If no record is ... Alexandru Lungu
08:29 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Constantin, can you run the ETF tests with 7108a?
> OK, I'... Alexandru Lungu
07:20 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Alexandru Lungu wrote:
> Constantin, can you run the ETF tests with 7108a?
OK, I'll do this. Is this for performa... Constantin Asofiei
06:51 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Constantin, can you run the ETF tests with 7108a?
I rebased 7108a with trunk rev. 14537.
I rebased 7108a_h2 with F... Alexandru Lungu
04:51 AM Bug #7035 (WIP): Extract query parameters from statically converted FQL: Eric Faulhaber wrote:
> Are we testing/profiling these changes only with H2, or with other database dialects as well... Alexandru Lungu

04/17/2023

10:43 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: At this time we have a limitation in our conversion approach, such that we must list the entire referenced object gra... Greg Shah
10:31 AM Feature #4514 (WIP): run ProDataSet test suite in FWD and resolve any issues such that it works t...: I have issues with conversion on @tests/dataset/@ and @dataset/@ - latest trunk on testcases and p2j repos.
The @fil... Maciej Zieniuk

04/14/2023

07:24 AM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...: Marian: What work is needed to complete these tests? What is the status of the existing tests for table/table-handle... Greg Shah
07:21 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...: The tests are in [[p2j:Testcases]] under the @tests/dataset/@ directory (for the ones already migrated to ABLUnit) an... Greg Shah

04/13/2023

11:54 AM Bug #7035: Extract query parameters from statically converted FQL: Are we testing/profiling these changes only with H2, or with other database dialects as well? I am concerned that wha... Eric Faulhaber
05:06 AM Bug #7035: Extract query parameters from statically converted FQL: Alexandru Lungu wrote:
> Danut, please constrain the changes to target only a specific sub-set of query parameters f... Dănuț Filimon
08:00 AM Feature #7066: Implement multi-table indexed query in H2: Alexandru Lungu wrote:
> * In @Select.queryFlat@, I think it is best to rename @nonReversedOrder@ to @reversedOrder@... Radu Apetrii
06:49 AM Bug #7185: H2 in-memory lazy hydration: Committed 7185a/rev. 14533:
* Optimized @TempRecord.fallback@ usage. Redone the profile and got to +0.25% performa... Alexandru Lungu

04/12/2023

11:01 AM Bug #7185 (WIP): H2 in-memory lazy hydration: My profiling session shown a +0.7% performance decrease. This is bad.
* My first concern here is the @extractCurre... Alexandru Lungu
06:30 AM Bug #7185: H2 in-memory lazy hydration: Alexandru Lungu wrote:
> Danut please review. I will start the profiling session asap. I would like to know the perf... Dănuț Filimon
05:56 AM Bug #7185 (Review): H2 in-memory lazy hydration: *Fixed regressions in 7185a_h2/rev. 18 and 7185a/rev. 14532*
* In H2, the cursors were not properly initialized to... Alexandru Lungu
10:33 AM Bug #7035: Extract query parameters from statically converted FQL: I am OK with the fix. However, my last profile session shown a +0.2% performance decrease with 7035a. I don't think i... Alexandru Lungu
10:23 AM Feature #7066: Implement multi-table indexed query in H2: Radu, please make an update on #7066. AFAIK, you are planning to integrate the #7194 changes into 7066a and deliver b... Alexandru Lungu

04/11/2023

01:36 PM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: I have reviewed @fix_7258.patch@. I think it works exactly how was described in previous notes.
As an optimization... Ovidiu Maxiniuc
07:37 AM Bug #7258 (WIP): Optimize INDEX-INFORMATION with closed dynamic queries: Attached the fix. I used a flag to mark that the query was executed already. This flag is reset on query close. Pleas... Alexandru Lungu
10:13 AM Bug #7185: H2 in-memory lazy hydration: Alexandru Lungu wrote:
> Committed 7185a/rev. 14531: small fixes. Danut, please review.
> I am close to finding th... Dănuț Filimon
09:59 AM Bug #7185: H2 in-memory lazy hydration: Committed 7185a/rev. 14531: small fixes. Danut, please review.
I am close to finding the regression we are chasing f... Alexandru Lungu
09:55 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: I am OK with the current implementation. This should be tested and merged into trunk. Alexandru Lungu
08:10 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Alexandru Lungu wrote:
> In @FQLPreprocessor@, please keep the @simplifyCiProperties@ guard. Otherwise, we risk a fu... Dănuț Filimon
04:40 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: *Review to 7108a/rev.14528*
The changes are good. Last note to address before attempting to do a full test round a... Alexandru Lungu
07:56 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found: Constantin Asofiei wrote:
> Danut: the patch would be this, please test it, in CompoundQuery$Optimizer.isServerJoinP... Dănuț Filimon
07:43 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found: Danut: the patch would be this, please test it, in @CompoundQuery$Optimizer.isServerJoinPossible@ - the point is, a N... Constantin Asofiei
07:43 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found: Eric: this looks like the same #7229 problem. Constantin Asofiei
07:41 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found: There is a problem with CompoundQuery where using FOR FIRST, EACH will only return the first record available, ignori... Dănuț Filimon
07:30 AM Bug #7267 (Test): CompoundQuery FOR FIRST, EACH only retrieves the first record found: Dănuț Filimon
07:17 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: *Committed 7138a_h2/rev.16*. Made changes to should-circuit fake-updates. @TestCompatibility@ change is related to #7... Dănuț Filimon
07:17 AM Feature #6444: dataset improvements: Eric Faulhaber wrote:
> Code review 6444b/14528:
>
> Only the "old" @Persistence.scroll@ and @Persistence.list@ m... Igor Skornyakov
05:53 AM Feature #6444: dataset improvements: Code review 6444b/14528:
Only the "old" @Persistence.scroll@ and @Persistence.list@ methods with the @public@ acce... Eric Faulhaber

04/10/2023

08:31 AM Feature #6444 (Review): dataset improvements: Greg Shah wrote:
> The application Sergey is talking about has no datasets, no data relations. I would expect that ... Igor Skornyakov
07:09 AM Feature #6444: dataset improvements: Greg Shah wrote:
> The application Sergey is talking about has no datasets, no data relations. I would expect that ... Igor Skornyakov
07:05 AM Feature #6444: dataset improvements: The application Sergey is talking about has no datasets, no data relations. I would expect that usage of those APIs ... Greg Shah
07:03 AM Feature #6444: dataset improvements: From Igor:
> An additional DataRelation parameter is used only for the second pass of the FILL operation. In all o... Greg Shah
07:02 AM Feature #6444: dataset improvements: From Sergey, in regard to the merged changes from 6444a:
> It seems @<customer_application_with_hand_coded_persist... Greg Shah

04/07/2023

02:26 PM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: Well, the listener was added exactly for this reason, to invoke the @execute()@ method later, asynchronously from pre... Ovidiu Maxiniuc
04:12 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: Ovidiu Maxiniuc wrote:
> Rather it seems to me that the @getDelegate().notifyQueryOpenListeners(false);@ is not call... Alexandru Lungu
09:58 PM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: Alexandru Lungu wrote:
> Ovidiu, OFC, we can't mark the query as opened to avoid this. Can we at least short-circuit... Ovidiu Maxiniuc
08:39 AM Feature #7194 (WIP): Avoid generating an ORDER-BY clause if not required: Alexandru Lungu
02:10 AM Feature #6995 (Closed): possibly support NO-UNDO temporary tables directly in H2: Eric Faulhaber

04/06/2023

07:37 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: I've added in @PreselectQuery@ a function that checks if the query will retrieve a unique finding. If so, then no @OR... Radu Apetrii
07:34 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: *Committed 7108a/rev.14528*. Removed @isAutoRtrimAndCi@ and replaced it with @isAutoRtrim and isAutoCi@.
I think tha... Dănuț Filimon
03:23 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Ovidiu Maxiniuc wrote:
> Historically speaking (in P2J/FWD terms), the @rtrim@ and @upper@ were handled together bec... Alexandru Lungu
08:45 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Alexandru Lungu wrote:
> Ovidiu Maxiniuc wrote:
> > Dănuț Filimon wrote:
> > Note that, for the moment, only Maria... Ovidiu Maxiniuc
07:16 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries: I profiled the @INDEX-INFORMATION@ implementation in FWD on a POC that runs in ~10.000ms. ~10ms are spent inside @IND... Alexandru Lungu
07:00 AM Bug #7258 (Closed): Optimize INDEX-INFORMATION with closed dynamic queries: Alexandru Lungu
04:36 AM Bug #7185: H2 in-memory lazy hydration: Alexandru Lungu wrote:
> Radu, can you please check-out 7185a and test it against adaptive-scrolling/non-scrolling t... Radu Apetrii

04/05/2023

04:02 PM Feature #6444: dataset improvements: The changes in @expressions.rules@ do not affect the code generated by the conversion. Ovidiu Maxiniuc
04:00 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > Review of 6444a/14552.
> >
> > @expressions.rules@: please u... Eugenie Lyzenko
03:45 PM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> Review of 6444a/14552.
>
> @expressions.rules@: please update the gap status for @KW_SYN... Igor Skornyakov
03:29 PM Feature #6444: dataset improvements: Review of 6444a/14552.
@expressions.rules@: please update the gap status for @KW_SYNCHRON@ ("synchronize"), @KW_F_... Ovidiu Maxiniuc
02:11 PM Feature #6444: dataset improvements: Updated history entries.
Committed to 6444a/14552.
Changes to the @rules/gaps/expressions.rules@ are also committed. Igor Skornyakov
02:25 AM Feature #6444: dataset improvements: Branch 6444a was rebased to the trunk rev. 14525.
Pushed up to revision 14551.
Igor Skornyakov
03:46 PM Feature #6453: temp-table features: Merged to the trunk rev. 14526. Igor Skornyakov
01:41 PM Support #6455: XML feature(s) needing testing: Igor,
The revision 14552 is NOT visible in @devsrv01:/opt/secure/code/p2j_repo/p2j/active/6444a@.
Is it possible ... Ovidiu Maxiniuc
08:51 AM Support #6455: XML feature(s) needing testing: Eric Faulhaber wrote:
> As part of your final cleanup of #6444, please update the gap marking in @expressions.rules@... Igor Skornyakov
04:20 AM Support #6455 (Closed): XML feature(s) needing testing: As part of your final cleanup of #6444, please update the gap marking in @expressions.rules@ in branch 6444a to full ... Eric Faulhaber
04:13 AM Support #6455: XML feature(s) needing testing: Eric Faulhaber wrote:
> Thank you, Igor. It does appear that runtime support for READ-XMLSCHEMA was updated from par... Igor Skornyakov
04:08 AM Support #6455: XML feature(s) needing testing: Igor Skornyakov wrote:
> Eric,
> I believe that it was completely implemented in #6444. At least I've tested this f... Igor Skornyakov
04:07 AM Support #6455: XML feature(s) needing testing: Thank you, Igor. It does appear that runtime support for READ-XMLSCHEMA was updated from partial to basic in @rules/g... Eric Faulhaber
03:47 AM Support #6455: XML feature(s) needing testing: Eric Faulhaber wrote:
> Igor, is this issue already covered by the work you have done for #6444? If so, how complete... Igor Skornyakov
03:42 AM Support #6455: XML feature(s) needing testing: Igor, is this issue already covered by the work you have done for #6444? If so, how complete is the support now for t... Eric Faulhaber
11:11 AM Bug #7235 (WIP): Avoid selecting all fields for an CAN-FIND sub-select: Alexandru Lungu
10:45 AM Bug #7185: H2 in-memory lazy hydration: I have troubles testing 7185a. One customer application works flawlessly, while the other in hanging right at the sta... Alexandru Lungu
09:13 AM Bug #7185: H2 in-memory lazy hydration: Rebased 7185a with trunk (rev. 14525). 7185a is now at 14530. Alexandru Lungu
09:01 AM Feature #7066: Implement multi-table indexed query in H2: Tested 7066a against a customer application: most of the tests pass, but I have one that provides an unexpected outpu... Alexandru Lungu
06:27 AM Feature #7066: Implement multi-table indexed query in H2: Rebased 7066a with trunk rev. 14525. 7066a is now at rev. 14526.
Radu, please update 7066a and notify me if somethin... Alexandru Lungu
05:43 AM Feature #7066: Implement multi-table indexed query in H2: *Review for 7066a_h2/rev. 14*
Most of the changes for #7066 are conceptually inside H2. I see that there are a lot... Alexandru Lungu
07:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Note that the changes require reconversion of the application (or at least regeneration of DDL - convert.middle and j... Alexandru Lungu
05:00 AM Bug #7108 (Test): Simulate upper/rtrim directly in H2 using case specific columns: Alexandru Lungu wrote:
> Danut, please address this issue and I will move this to test.
Never mind. This is not c... Alexandru Lungu
04:17 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: I tested several applications:
* customer application POC - no regressions
* 2 customer application regression test... Alexandru Lungu
05:47 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: I think the issue is that we don't emit as lambda the OO expression. Take this test:... Constantin Asofiei
03:24 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...: Constantin, Greg informed me that you were concerned about certain OO expressions embedded in WHERE clauses not conve... Eric Faulhaber
01:35 AM Bug #6887: improve performance of dataset/table[-handle] parameters: We should profile and check how #6887-3 test behaves now with FWD first. Constantin Asofiei
12:06 AM Bug #6887: improve performance of dataset/table[-handle] parameters: Constantin Asofiei wrote:
> This is the entire JMX result for the large application:
> [...]
>
> The 3 cases fro... Eric Faulhaber

04/04/2023

10:11 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses: *4GL code:*... Alexandru Lungu
09:57 AM Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses: Alexandru Lungu
06:32 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Ovidiu Maxiniuc wrote:
> Dănuț Filimon wrote:
> Note that, for the moment, only MariaDb support this kind of charac... Alexandru Lungu
04:59 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Rebased 7108a with trunk (rev. 14523). 7108a is now at rev. 14527. Alexandru Lungu
06:06 AM Bug #7035 (Review): Extract query parameters from statically converted FQL: *Committed 7035a/rev.14526*. This is a fix for #7035-24.
I found a similar problem on a customer application after ... Dănuț Filimon
04:14 AM Bug #7035: Extract query parameters from statically converted FQL: Constantin Asofiei wrote:
> There is another peculiarity at least with PostgreSQL - @select '1' = 1;@ will show 'tru... Alexandru Lungu

04/03/2023

09:47 AM Bug #7035: Extract query parameters from statically converted FQL: The H2 supports implicit conversion of @1 = '1'@, @'true' = true@ and even @'1' = true@. MariaDb will also return ret... Ovidiu Maxiniuc
05:07 AM Bug #7035 (WIP): Extract query parameters from statically converted FQL: Constantin Asofiei wrote:
> There is another peculiarity at least with PostgreSQL - @select '1' = 1;@ will show 'tru... Alexandru Lungu
07:42 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Ovidiu Maxiniuc wrote:
> ... Indeed, both dialects (actually the character type on SQL side) handle both of these la... Dănuț Filimon

04/01/2023

08:28 AM Bug #7035: Extract query parameters from statically converted FQL: There is another peculiarity at least with PostgreSQL - @select '1' = 1;@ will show 'true'. The same for @select 'tr... Constantin Asofiei
04:57 AM Bug #7035: Extract query parameters from statically converted FQL: The root cause seems to be an FQL like @tt1.f1 <> 0@ where @f1@ is an integer field. In this case, @0@ is extracted ... Constantin Asofiei
08:58 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Dănuț Filimon wrote:
> Ovidiu, is there any case where a rtrim is used but should not be removed when using @MariaDb... Ovidiu Maxiniuc

03/31/2023

07:28 PM Bug #6767: Possible name clashes in DMO classes: Eric Faulhaber wrote:
> Vladimir Tsichevski wrote:
>
> > What am I expected to do to make this patch merged to th... Vladimir Tsichevski
03:06 PM Feature #6371: implement SAVE CACHE statement: Merged into trunk as revision 14524. Boris Schegolev
02:18 PM Feature #6371 (Review): implement SAVE CACHE statement: Code review 6371b/14529: the changes look good. Eric Faulhaber
01:53 PM Feature #6371: implement SAVE CACHE statement: I pushed cleanup and headers update for modified files as revision 14529. Also, normalized extent support is replaced... Boris Schegolev
12:08 PM Feature #6371: implement SAVE CACHE statement: I've looked at 6371b and the changes look safe, they are limited to SAVE CACHE package in FWD. Constantin Asofiei
11:25 AM Bug #7035: Extract query parameters from statically converted FQL: 7035a still fails, I think is related to some date literal. I need to find the actual FQL and SQL, will get back to ... Constantin Asofiei
07:13 AM Bug #7035: Extract query parameters from statically converted FQL: Committed it as 7035a/rev. 14525. I will also redo some of my regression tests for this. Alexandru Lungu
04:51 AM Bug #7035: Extract query parameters from statically converted FQL: Dănuț Filimon wrote:
> I attached a patch that should solve the issue. When handling strings in @FQLPreprocessor.cre... Constantin Asofiei
04:08 AM Bug #7035: Extract query parameters from statically converted FQL: I attached a patch that should solve the issue. When handling strings in @FQLPreprocessor.createParameterDiff@, they ... Dănuț Filimon
02:03 AM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> Yes, That is correct. The time-stamps remain, but they need to be grouped together at the e... Igor Skornyakov

03/30/2023

07:29 PM Feature #6444: dataset improvements: Yes, That is correct. The time-stamps remain, but they need to be grouped together at the end of history list, under ... Ovidiu Maxiniuc
04:32 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > Actually, not what I meant by updating the history entries.
> ... Igor Skornyakov
03:15 PM Feature #6444: dataset improvements: Constantin Asofiei wrote:
> The 'scale' computed in @int colDecs = Math.max(1, column.getDecimals());@ results in '0... Igor Skornyakov
03:04 PM Feature #6444: dataset improvements: The 'scale' computed in @int colDecs = Math.max(1, column.getDecimals());@ results in '0' so colDecs becomes 1, in Ov... Constantin Asofiei
02:28 PM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> Here is the isolated testcase:
> [...]
> And the results are as follows:
> |_. Reference... Igor Skornyakov
02:22 PM Feature #6444: dataset improvements: Constantin Asofiei wrote:
> We need Ovidiu's test first. Also, try the test in #6444-201 with and without DECIMAL... Igor Skornyakov
02:20 PM Feature #6444: dataset improvements: Here is the isolated testcase:... Ovidiu Maxiniuc
01:13 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > If DECIMALS is not specified, it defaults to 10 in OE. In F... Constantin Asofiei
01:12 PM Feature #6444: dataset improvements: Constantin Asofiei wrote:
> If DECIMALS is not specified, it defaults to 10 in OE. In FWD, there may be a problem a... Igor Skornyakov
01:08 PM Feature #6444: dataset improvements: If DECIMALS is not specified, it defaults to 10 in OE. In FWD, there may be a problem as we assume '0' in @persist.o... Constantin Asofiei
12:54 PM Feature #6444: dataset improvements: Well, in fact I've used the attached test for WRITE-JSON. Igor Skornyakov
12:40 PM Feature #6444: dataset improvements: For example, this test:... Constantin Asofiei
12:39 PM Feature #6444: dataset improvements: Constantin Asofiei wrote:
> Do you have a test which just uses @WRITE-XML@ for a temp-table with some records?
I me... Constantin Asofiei
12:39 PM Feature #6444: dataset improvements: This test uses appserver calls - the data may be affected by the transfer over the appserver. Do you have a test whi... Constantin Asofiei
12:27 PM Feature #6444: dataset improvements: Constantin Asofiei wrote:
> Igor, please specify a testcase I can use for the decimal serialization - where you saw ... Igor Skornyakov
12:23 PM Feature #6444: dataset improvements: Igor, please specify a testcase I can use for the decimal serialization - where you saw that the rounding is necessary. Constantin Asofiei
12:22 PM Feature #6444: dataset improvements: Branch 6444a was rebased to the trunk rev. 14523.
Pushed up to revision 14548. Igor Skornyakov
01:35 AM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> Actually, not what I meant by updating the history entries.
> Your entry must be the last ... Igor Skornyakov
12:15 AM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > Please update the H entries first. I will do some tests regardi... Ovidiu Maxiniuc
02:51 PM Feature #6371: implement SAVE CACHE statement: Boris Schegolev wrote:
> I rebased the branch (well, merged trunk into 6371b) without major issues.
>
> > As not... Eric Faulhaber
02:44 PM Feature #6371: implement SAVE CACHE statement: Awesome, I will apply headers update and continue cleanup and testing. Thank you! Boris Schegolev
02:42 PM Feature #6371: implement SAVE CACHE statement: Eric Faulhaber wrote:
> Boris Schegolev wrote:
> > I rebased the branch (well, merged trunk into 6371b) without maj... Eric Faulhaber
01:37 PM Feature #6371: implement SAVE CACHE statement: Boris Schegolev wrote:
> I rebased the branch (well, merged trunk into 6371b) without major issues.
This is not ... Eric Faulhaber
01:17 PM Feature #6371: implement SAVE CACHE statement: I rebased the branch (well, merged trunk into 6371b) without major issues.
> As noted in #6371-100, #6371-101, an... Boris Schegolev
11:23 AM Bug #7035: Extract query parameters from statically converted FQL: There are lots of these:... Constantin Asofiei
11:21 AM Bug #7035: Extract query parameters from statically converted FQL: Alexandru Lungu wrote:
> Rebased 7035a with latest trunk/rev. 14523.
ETF testing fails badly. Constantin Asofiei
09:53 AM Bug #7035: Extract query parameters from statically converted FQL: Rebased 7035a with latest trunk/rev. 14523. Alexandru Lungu
09:34 AM Bug #7035: Extract query parameters from statically converted FQL: Alexandru Lungu wrote:
> Tested it against two large customer applications. Also profiled against a customer POC. Th... Constantin Asofiei
06:37 AM Bug #7035: Extract query parameters from statically converted FQL: Tested it against two large customer applications. Also profiled against a customer POC. There were no regressions.
... Alexandru Lungu
06:31 AM Bug #7035: Extract query parameters from statically converted FQL: Alexandru, what's the state of testing for 7035a? Constantin Asofiei
10:08 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: *Committed 7108a_h2/rev.18*. Fix for cached @CompareMode@ where the same instance is used but a different one is requ... Dănuț Filimon
05:39 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: *Committed 7108a/rev.14519*. Skip adding upper and rtrim in the @SortCriterion.toString@ represensation when necessar... Dănuț Filimon
09:08 AM Feature #7066: Implement multi-table indexed query in H2: Alexandru Lungu wrote:
> * @s.setType(INDEX);@ means that you set the @index_name@ AST type to INDEX. This way, in a... Radu Apetrii
08:27 AM Feature #7066: Implement multi-table indexed query in H2: *Review for 7066a/rev. 14532*
The changes are reasonable considering the need of enforcing USE-INDEX in some scenari... Alexandru Lungu
06:26 AM Feature #7066: Implement multi-table indexed query in H2: I've committed to 7066a, rev. 14532 and 7066a_h2, rev. 14 some changes that target the use of @use index@.
As Alex p... Radu Apetrii
05:36 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Alexandru Lungu wrote:
> Eric Faulhaber wrote:
> > If you are intending to remove it at the FQL level, please note ... Radu Apetrii
03:05 AM Bug #6767: Possible name clashes in DMO classes: Vladimir Tsichevski wrote:
> What am I expected to do to make this patch merged to the trunk?
Create a task bra... Eric Faulhaber

03/29/2023

05:10 PM Bug #6767: Possible name clashes in DMO classes: Eric Faulhaber wrote:
> Code review 6767-full.diff:
>
> The changes look good.
>
> Just some minor issues with... Vladimir Tsichevski
12:58 PM Bug #6767: Possible name clashes in DMO classes: Code review 6767-full.diff:
The changes look good.
Just some minor issues with the file headers:
* The dates... Eric Faulhaber
04:09 PM Feature #6444: dataset improvements: Ovidiu, please post when you have some test results, so we can figure out where this falls in the merge order. Thanks. Eric Faulhaber
12:23 AM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> Please update the H entries first. I will do some tests regarding the synchronize, fill and... Igor Skornyakov
03:30 PM Feature #6371: implement SAVE CACHE statement: Code review 6371b/14485-14488:
Overall, it seems good functionally; nice work. I do have some considerations and c... Eric Faulhaber
11:40 AM Bug #7185: H2 in-memory lazy hydration: Committed 7185a/rev. 14532 and 7185a_h2/rev. 16: handle cases when result-set is composed out of multiple row structu... Alexandru Lungu
11:09 AM Bug #7185: H2 in-memory lazy hydration: *Done some tests with latest 7185a/rev. 14531 and latest 7185a_h2:*
* @FWDDirectAccess.retrieveResponse@ you creat... Alexandru Lungu
09:02 AM Bug #7185: H2 in-memory lazy hydration: Based on #7185-14 I committed *7185a/rev.14531*. I confirmed that @TempRecord.checkIncomplete@ is redundant and remov... Dănuț Filimon
07:15 AM Bug #7185: H2 in-memory lazy hydration: Eric Faulhaber wrote:
> The idea when I first implemented @BaseRecord@ was to make the @data@ array directly accessi... Alexandru Lungu
06:28 AM Bug #7185: H2 in-memory lazy hydration: Alexandru Lungu wrote:
> *Eric, Constantin, please advice*. If we attempt to implement lazy-hydration in any form ... Eric Faulhaber
06:03 AM Bug #7185: H2 in-memory lazy hydration: *Review for 7185a/rev. 14529 and 14530*
This is close to a conceptually correct solution. However, there are still... Alexandru Lungu
05:19 AM Bug #7185: H2 in-memory lazy hydration: *Committed 7185a/rev.14530*. Fixed a NPE in @TempRecord.getDatum()@ where fallback was assigned but readFields was null. Dănuț Filimon
10:16 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Danut, please mark #7108-31 as high priority for now. Alexandru Lungu
07:47 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select: 4GL code:... Alexandru Lungu
07:39 AM Bug #7235 (Closed): Avoid selecting all fields for an CAN-FIND sub-select: Alexandru Lungu
07:17 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Eric Faulhaber wrote:
> If you are intending to remove it at the FQL level, please note that we do a reverse lookup ... Alexandru Lungu
06:37 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Is the idea to just remove the ORDER BY at the SQL level (as opposed to the FQL level)?
If you are intending to re... Eric Faulhaber
05:25 AM Feature #7066: Implement multi-table indexed query in H2: Created 7066a from trunk rev. 14519 and rebased with 7026b changes. Also created 7066a_h2 from FWD-H2 trunk rev. 13. Alexandru Lungu

03/28/2023

07:37 PM Feature #6444: dataset improvements: Igor Skornyakov wrote:
> > *** according to https://docs.progress.com/bundle/openedge-prodatasets-117/page/Using-the... Ovidiu Maxiniuc
07:11 AM Feature #6444: dataset improvements: Ovidiu Maxiniuc wrote:
> Review of 6444a/14538:
> * @AbstractQuery.java@, @CompoundComponent.java@, Dialect.java, e... Igor Skornyakov
02:30 AM Feature #6444: dataset improvements: Branch 6444a was rebase to the trunk rev. 14518.
Pushed up to revision 14541. Igor Skornyakov
02:12 AM Feature #6444 (WIP): dataset improvements: Igor Skornyakov
11:34 PM Feature #6444: dataset improvements: Review of 6444a/14538:
* @AbstractQuery.java@, @CompoundComponent.java@, Dialect.java, etc: GCD coding standard: ple... Ovidiu Maxiniuc
07:05 PM Feature #6371: implement SAVE CACHE statement: I added support for comments / meta info for extent fields as revision 6371b/14488. Documentation is also updated - s... Boris Schegolev
10:58 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: h2. Reviews
*Review for 7108a*
* @SortCriterion@ instances are still generated with @upper@ and @rtrim@! Please c... Alexandru Lungu
08:25 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns: Rebased 7108a from trunk rev. 14515. 7108a is now at rev. 14518. Alexandru Lungu
09:50 AM Bug #7185: H2 in-memory lazy hydration: Based on #7185-10 I committed *7185a/rev.14529* and *7185a_h2/rev.15.*.
* Fixed @TempRecord@.
* Made @BaseRecord.ja... Dănuț Filimon
05:27 AM Bug #7185: H2 in-memory lazy hydration: *Review for 7185a/rev. 14528*
* In @TempRecord@:
** @readFields.set(i);@ is redundant as @readProperty@ already s... Alexandru Lungu
02:57 AM Bug #7185: H2 in-memory lazy hydration: *Committed 7185a_h2/rev.14* and *7185a/rev.14528* as part of the initial implementation for lazy hydration.
I've m... Dănuț Filimon
09:23 AM Feature #7194: Avoid generating an ORDER-BY clause if not required: Radu, please address #7194 once you get a stable solution for #7066. AFAIK, you already have some implementation rega... Alexandru Lungu
07:16 AM Feature #7060 (Review): Consider using wildcard selection to reduce SQL size: Alexandru Lungu
04:27 AM Bug #7138 (WIP): Short circuit fake-update (update with a new value eqaul to the old value) in H2: Alexandru Lungu

03/27/2023

10:29 AM Bug #7220: Record not created when property is set to empty string: I remember that Danut also tested the example with a temporary table. In that case, the record was found because @isA... Alexandru Lungu

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Database

Activity

Activity

04/24/2023

04/22/2023

04/21/2023

04/20/2023

04/19/2023

04/18/2023

04/17/2023

04/14/2023

04/13/2023

04/12/2023

04/11/2023

04/10/2023

04/07/2023

04/06/2023

04/05/2023

04/04/2023

04/03/2023

04/01/2023

03/31/2023

03/30/2023

03/29/2023

03/28/2023

03/27/2023