Activity
From 04/05/2023 to 05/04/2023
05/04/2023
- 06:11 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- We might as well fix it here, now.
It is weird syntax. Normally you would call @valid-handle(dsMasterDynamic)@ to... - 05:41 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> In my testcases branch i changed this code to assign the handle to some other handle, as it ... - 05:25 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- In my testcases branch i changed this code to assign the handle to some other handle, as it did not compile for me.
... - 05:16 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have an issue compiling the @TestHandle.cls@ test: statements like...
- 09:30 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate... - 03:53 PM Bug #6812 (WIP): fix FastFindCache to use a shared instance per persistent database
- 06:05 AM Bug #7319: Fix adaptive query test suite from testcases
- Alexandru Lungu wrote:
> Are these the issues for the persistent database?
Yes, I forgot to mention. These issues ... - 05:59 AM Bug #7319: Fix adaptive query test suite from testcases
- Are these the issues for the persistent database? Are they the same as for temporary database?
- 05:52 AM Bug #7319: Fix adaptive query test suite from testcases
- It is done. Inside @adaptive_scrolling/persistent-adaptive_tests@ there are 2 folders (one for no-scrolling tests and...
- 04:08 AM Bug #7319: Fix adaptive query test suite from testcases
- Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > AFAIK, Radu, you already have such work already done. Please commi... - 04:02 AM Bug #7319: Fix adaptive query test suite from testcases
- Alexandru Lungu wrote:
> AFAIK, Radu, you already have such work already done. Please commit to testcases the adapti... - 04:15 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- *Committed 7138a_h2/rev.21*. Fixed a concurrency problem. @inMemUpdate@ and @notInMemUpdate@ need to be set to *null*...
- 03:24 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- From the testing POV, we already covered several large applications for in-memory H2.
Danut:
* you can do a quick r...
05/03/2023
- 04:30 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate th... - 03:01 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I identified the issue, thhat the @run support/dataset/create/dsMaster.p@ does not propagate the assigned handle @o...
- 02:48 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- This test which had error propagation issues is working with the 3827b branch :)
I will rebase my changes on top o... - 11:44 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Vladimir has some error propagation changes in task branch 3827b. Can you try those to see if the issue is resolved?
- 02:33 PM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Dănuț Filimon wrote:
> Should I do similar tests for persistent tables?
As a lower priority, yes, just to make ... - 11:30 AM Feature #7323: Implement soft unique index in FWD-H2
- I've done some logging with FWD-H2 on a large customer application and identified the following for a POC run. Out of...
- 10:48 AM Feature #7323 (Closed): Implement soft unique index in FWD-H2
- 09:51 AM Feature #6630: optimize return of table parameter
- I recreated a similar scenario where @TemporaryBuffer.loopDelete@ is called using a class field that has a destructor...
05/02/2023
- 04:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I just pushed a potential fix to 4514a p2j branch, for the @tests.dataset.parameter.input.TestInputDynamicDsInDynamic...
- 03:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Attached @file-cvt-list.txt@
- 01:26 PM Bug #7113: Problem with nested CAN-FIND conversion
- > Sorry, but I do not understand. The conversion w/o my patch was incorrect and, AFAIR, you agreed with this. The fac...
- 10:03 AM Bug #7321 (WIP): Improve FWD-H2 wildcard projection
- 09:56 AM Bug #7321: Improve FWD-H2 wildcard projection
- Recently, queries over the temporary database use the wildcard syntax: @tt.*@ to select all the columns. If there are...
- 09:28 AM Bug #7321 (Closed): Improve FWD-H2 wildcard projection
- 09:27 AM Feature #7320: Extend H2 tester from Hotel GUI
- This task is related to the H2 tester from Hotel GUI, used to track performance of FWD-H2 in certain scenarios. We sh...
- 08:50 AM Feature #7320 (WIP): Extend H2 tester from Hotel GUI
- 07:35 AM Bug #7319: Fix adaptive query test suite from testcases
- The @testcases/adaptive-scrolling@ test-suite is a reference point for our implementation of @AdaptiveQuery@. It incl...
- 07:21 AM Bug #7319 (New): Fix adaptive query test suite from testcases
- 07:26 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I've tested fake-update performance for larger tables and extent fields, results of each test are measured in millise...
- 07:21 AM Bug #7267 (Test): CompoundQuery FOR FIRST, EACH only retrieves the first record found
- This can be closed/rejected.
- 07:20 AM Bug #7267 (Review): CompoundQuery FOR FIRST, EACH only retrieves the first record found
- 07:20 AM Bug #7267 (WIP): CompoundQuery FOR FIRST, EACH only retrieves the first record found
- 07:16 AM Bug #7235 (Test): Avoid selecting all fields for an CAN-FIND sub-select
- Merged 7026c to trunk as rev. 14553.
- 04:15 AM Feature #7066: Implement multi-table indexed query in H2
- While doing some work on #7252, I noticed that there might be some (other) stuff that is unnecessary computed when an...
- 04:02 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- After doing some testing, I managed to form the following table:
|_. Scenario |_. Normal statements |_. Direct-a...
05/01/2023
- 03:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej, can you provide me and other with the @file-cvt-list.txt@ you use to convert tests for this issue, please. Th...
04/29/2023
- 04:02 AM Bug #7113: Problem with nested CAN-FIND conversion
- Ovidiu Maxiniuc wrote:
> Igor,
> I have fixed the extra closing parenthesis as part of another task. Please do not... - 08:34 PM Bug #7113: Problem with nested CAN-FIND conversion
- Igor,
I have fixed the extra closing parenthesis as part of another task. Please do not put additional effort in th... - 03:38 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@... - 09:56 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The expectation is that the @for each ttOrderCustomer:@ will fail with @Progress.Lang.Error@...
04/28/2023
- 04:15 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I am not sure what to do with the @tests.dataset.parameter.input.TestDatasetBind@ class test @referenceOnlyNotValid@....
- 09:09 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Correct. ...
- 09:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > Aka, this doesn't convert because of the use of @no-error@:
>
> What is the error? Is it du... - 08:04 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > Aka, this doesn't convert because of the use of @no-error@:
What is the error? Is it during parsing or during l... - 04:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Pushed a few changes, the conversion issue with @create dataset/data-source@ was due to the fact that @no-error@ opti...
- 04:06 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> You are right. I initially though this is about @dsInit@ being unknown, not initialized, b... - 02:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > This sounds good to me, but then why the handle is invalid? I would check the converted code, from what we've seen ...
- 01:49 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> - @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@ method @passDatase... - 04:12 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- Alexandru Lungu wrote:
> ** What if the uniquely found record is changed? The query should invalidate (or not?) and ...
04/27/2023
- 09:30 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej: Please do fix all of these conversion issues. I don't want to leave behind any latent problems.
So we nee... - 09:19 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases... - 07:49 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Marian, i don't think the @support/test/HandleFactory.cls@ is converting in newest testcases revision, because of the...
- 05:32 AM Feature #7076: make CAN-FIND avoid hydration
- I've tested both temporary and persistent tables with CAN-FIND and nested CAN-FIND. CAN-FIND no longer hydrates with ...
- 03:50 AM Feature #6630: optimize return of table parameter
- Danut, I recall I changed the @AdaptiveQuery@ from @TemporaryBuffer.loopDelete@ into a @PreselectQuery@. Basically, t...
- 03:00 AM Bug #7235 (Review): Avoid selecting all fields for an CAN-FIND sub-select
- Added this patch to 7026c.
Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebas...
04/26/2023
- 05:04 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Thanks Marian, that helped.
Few findings:
- @tests.dataset.parameter.inout.TestInputOutputDynamicDsInDynamicProc@... - 02:09 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases r... - 10:21 AM Feature #7194 (WIP): Avoid generating an ORDER-BY clause if not required
- I will move this back to 50% to allow the handling of other ORDER BY clauses (from RandomAccessQuery especially).
- 10:18 AM Feature #7194 (Review): Avoid generating an ORDER-BY clause if not required
- Tested this. I got a -0.24% performance improvement with a 7026c profile run.
Just rebased 7026c with trunk.
Fu... - 10:06 AM Feature #7076 (WIP): make CAN-FIND avoid hydration
- Danut, please investigate this.
I am not sure if CAN-FIND still hydrates in the latest versions of FWD-H2 trunk (>1... - 09:16 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I've tested #6928-3 and also made my own set of performance tests (results are measured in milliseconds). The results...
- 05:57 AM Bug #7138 (Review): Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Fixed a regression in 7138a_h2 regarding updating indexed computed columns in inMemUpdate mode. If you have (f1, __if...
- 08:05 AM Bug #7185: H2 in-memory lazy hydration
- Merged 7185a_h2 into FWD-H2 trunk as rev. 17.
This doesn't require any FWD changes; it just optimizes the direct-ac... - 04:35 AM Bug #7185: H2 in-memory lazy hydration
- Review 7185a_h2. The changes are good to go, you can proceed with the merge.
04/25/2023
- 06:36 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Oh i almost forgot, i have this weird issue, that i cannot run @ant dist@ on the testcases repo, because it fails wit...
- 06:26 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I wanted to make sure that the dataset testcases actually works fine in 4GL ABLUnit.
With 4GL 11.6 version i was abl... - 12:34 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> > Running all tests in a suite seems to make some of those tests to fail even if ran individ... - 10:45 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > Running all tests in a suite seems to make some of those tests to fail even if ran individually they pass... curren...
- 07:41 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> Yes by "push" i meant bound branch to a remote repo with bzr commit.
> I will have to reba... - 02:51 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Yes by "push" i meant bound branch to a remote repo with bzr commit.
I will have to rebase too once in a while, to ... - 10:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- My initial thought when I created #7194 was to optimize UNIQUE FIND/CAN-FIND for persistent databases. For temp datab...
- 10:20 AM Bug #7185: H2 in-memory lazy hydration
- I updated #7185-30 with the times regarding the FWD changes (lazy hydration). While the FWD-H2 changes provides a con...
- 09:44 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I tested Hotel_GUI and found no problems, but I found a regression in a customer application which I didn't manage to...
- 05:51 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- Alexandru Lungu wrote:
> ... Please check that the SELECT keyword is placed correctly (as a left sibling of the num ... - 05:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Branch 7108a_h2 has been merged to FWD-H2 trunk at revision 16.
- 05:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Branch 7108a has been merged to trunk at revision 14550
- 05:11 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Branch 7258a has been merged to trunk at revision 14549.
04/24/2023
- 05:30 PM Feature #6371: implement SAVE CACHE statement
- Code review 6371d/14544:
One *very minor* change: please fix the open curly brace at @SchemaComparator.java@:149 t... - 06:50 AM Feature #6371: implement SAVE CACHE statement
- I was asked to test this statement. I will not be able to have a look at this soon, probably not even before summer v...
- 01:42 PM Bug #7258 (Test): Optimize INDEX-INFORMATION with closed dynamic queries
- @7258a.patch@ looks fine. The code in @DynamicQueryHelper@ looks much cleaner now. Good job!
- 04:25 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Ovidiu, I am planning to merge 7258a today. Move this to Test after you check #7158-7: these are the same changes as ...
- 09:00 AM Bug #7035: Extract query parameters from statically converted FQL
- I created the temporary *JMX* and added counters for meta, temp, dirty and persistent database hits/misses. The count...
- 06:46 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- *Review to 7138a_h2/rev.17* : I am OK with the changes.
Danut, please re-test 7138a_h2 (own test-cases, large cust... - 05:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the ...
- 05:34 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- Radu, let the intended changes for #7194 reside in 7026c. I am thinking of merging 7026c independently from 7066a, as...
- 05:30 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- *Review of #7235 patch in #7235-3.*
* When you append the NUM_LITERAL, you also append SELECT (which is OK). You u...
04/22/2023
- 02:18 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have pushed that change to @~/secure/code/p2j_repo/p2j/active/4514a@. If i find anything i will push more to the br...
04/21/2023
- 04:28 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
> That seems reasonabl... - 08:00 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> > I am thinking about making a change to the FWD code, to something like:
>
> That seems reaso... - 07:55 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I am thinking about making a change to the FWD code, to something like:
That seems reasonable if the @unableToAs... - 07:23 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I've pushed a bunch of changes in @testcases@, we took out @tests@, @support@ from @PROPATH@ and added missing 'stand...
- 06:47 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- The @TestNamespaceUri.cls@ method @TestSetInvalid@ is outdated and needs to be corrected.
Below procedure result i... - 10:23 AM Bug #7185: H2 in-memory lazy hydration
- Rebased 7185a_h2 to trunk rev. 15. Not it is at rev. 20.
Committed 7185a_h2/rev. 21 including some extra optimizatio...
04/20/2023
- 07:42 AM Bug #7258 (Review): Optimize INDEX-INFORMATION with closed dynamic queries
- Committed fix to 7258a/rev. 14544. It is ready to merge.
I've run some regression tests and everything looks right.
... - 07:35 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
- Radu, can you please make a statistic in a dummy Java project for:
* 10,000 JDBC statements doing @select tt.* from ... - 07:14 AM Bug #7174 (Test): Resolve simple CAN-FIND statements faster
- This was merged in trunk as rev. 14523 and can be closed.
- 07:13 AM Bug #7165: Close multiplex scope using prepared statement
- This was merged in trunk as rev. 14523 and can be closed.
- 07:13 AM Bug #5306 (Test): AdaptiveQuery sets a found record into the buffer twice in dynamic mode
- This was merged in trunk as rev. 14523 and can be closed.
- 07:12 AM Feature #7060 (Test): Consider using wildcard selection to reduce SQL size
- This was merged in trunk as rev. 14523 and can be closed.
- 07:12 AM Feature #7062 (Test): Direct access to H2 internals to solve basic queries
- This was merged in trunk as rev. 14523 and can be closed.
- 04:56 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin Asofiei wrote:
> ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar
Good.
Greg, Eric:... - 04:35 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> The @tests/dataset/TestXmlNodeType.cls@ have a line during the setup, which runs some other ...
04/19/2023
- 04:00 PM Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Code review 6812a/14487:
Sorry for the delay in reviewing. A lot of changes have gone in to trunk in the meantime;... - 03:27 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Thanks Marian.
But I think i am doing something wrong.
The @tests/dataset/TestXmlNodeType.cls@ have a line during... - 06:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Marian Edu wrote:
> That one was moved in a different location under support folder only forgot to push the changes ... - 05:12 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Maciej Zieniuk wrote:
> I have few tests passing, but there are few which will definitively not run.
> As an exampl... - 12:49 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- ETF testing is OK with 7108a rev 14543 and fwd-h2-1.20-7108a.jar
- 09:43 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Alexandru Lungu wrote:
> Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial f... - 07:09 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Please address this review on *7138a_h2/rev.16* asap. Some of the points here are crucial for the performance tests t...
- 06:41 AM Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses
- 06:34 AM Feature #7066: Implement multi-table indexed query in H2
- I've committed to 7066a. rev. 14528 the following things:
* @use_index@ is now used only in multi-table scenarios an... - 05:22 AM Bug #7235: Avoid selecting all fields for an CAN-FIND sub-select
- I've attached a patch for the current issue.
When using the function *exists* and the first child is of type @SUBSEL...
04/18/2023
- 04:43 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have few tests passing, but there are few which will definitively not run.
As an example, the @tests/dataset/TestA... - 10:06 AM Bug #7185: H2 in-memory lazy hydration
- Committed 7185a_h2/rev. 19.
It includes optimization for @FWDDirectAccess.retrieveResponse@:
* If no record is ... - 08:29 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Constantin, can you run the ETF tests with 7108a?
> OK, I'... - 07:20 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Constantin, can you run the ETF tests with 7108a?
OK, I'll do this. Is this for performa... - 06:51 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Constantin, can you run the ETF tests with 7108a?
I rebased 7108a with trunk rev. 14537.
I rebased 7108a_h2 with F... - 04:51 AM Bug #7035 (WIP): Extract query parameters from statically converted FQL
- Eric Faulhaber wrote:
> Are we testing/profiling these changes only with H2, or with other database dialects as well...
04/17/2023
- 10:43 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- At this time we have a limitation in our conversion approach, such that we must list the entire referenced object gra...
- 10:31 AM Feature #4514 (WIP): run ProDataSet test suite in FWD and resolve any issues such that it works t...
- I have issues with conversion on @tests/dataset/@ and @dataset/@ - latest trunk on testcases and p2j repos.
The @fil...
04/14/2023
- 07:24 AM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...
- Marian: What work is needed to complete these tests? What is the status of the existing tests for table/table-handle...
- 07:21 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- The tests are in [[p2j:Testcases]] under the @tests/dataset/@ directory (for the ones already migrated to ABLUnit) an...
04/13/2023
- 11:54 AM Bug #7035: Extract query parameters from statically converted FQL
- Are we testing/profiling these changes only with H2, or with other database dialects as well? I am concerned that wha...
- 05:06 AM Bug #7035: Extract query parameters from statically converted FQL
- Alexandru Lungu wrote:
> Danut, please constrain the changes to target only a specific sub-set of query parameters f... - 08:00 AM Feature #7066: Implement multi-table indexed query in H2
- Alexandru Lungu wrote:
> * In @Select.queryFlat@, I think it is best to rename @nonReversedOrder@ to @reversedOrder@... - 06:49 AM Bug #7185: H2 in-memory lazy hydration
- Committed 7185a/rev. 14533:
* Optimized @TempRecord.fallback@ usage. Redone the profile and got to +0.25% performa...
04/12/2023
- 11:01 AM Bug #7185 (WIP): H2 in-memory lazy hydration
- My profiling session shown a +0.7% performance decrease. This is bad.
* My first concern here is the @extractCurre... - 06:30 AM Bug #7185: H2 in-memory lazy hydration
- Alexandru Lungu wrote:
> Danut please review. I will start the profiling session asap. I would like to know the perf... - 05:56 AM Bug #7185 (Review): H2 in-memory lazy hydration
- *Fixed regressions in 7185a_h2/rev. 18 and 7185a/rev. 14532*
* In H2, the cursors were not properly initialized to... - 10:33 AM Bug #7035: Extract query parameters from statically converted FQL
- I am OK with the fix. However, my last profile session shown a +0.2% performance decrease with 7035a. I don't think i...
- 10:23 AM Feature #7066: Implement multi-table indexed query in H2
- Radu, please make an update on #7066. AFAIK, you are planning to integrate the #7194 changes into 7066a and deliver b...
04/11/2023
- 01:36 PM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- I have reviewed @fix_7258.patch@. I think it works exactly how was described in previous notes.
As an optimization... - 07:37 AM Bug #7258 (WIP): Optimize INDEX-INFORMATION with closed dynamic queries
- Attached the fix. I used a flag to mark that the query was executed already. This flag is reset on query close. Pleas...
- 10:13 AM Bug #7185: H2 in-memory lazy hydration
- Alexandru Lungu wrote:
> Committed 7185a/rev. 14531: small fixes. Danut, please review.
> I am close to finding th... - 09:59 AM Bug #7185: H2 in-memory lazy hydration
- Committed 7185a/rev. 14531: small fixes. Danut, please review.
I am close to finding the regression we are chasing f... - 09:55 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- I am OK with the current implementation. This should be tested and merged into trunk.
- 08:10 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> In @FQLPreprocessor@, please keep the @simplifyCiProperties@ guard. Otherwise, we risk a fu... - 04:40 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- *Review to 7108a/rev.14528*
The changes are good. Last note to address before attempting to do a full test round a... - 07:56 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found
- Constantin Asofiei wrote:
> Danut: the patch would be this, please test it, in CompoundQuery$Optimizer.isServerJoinP... - 07:43 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found
- Danut: the patch would be this, please test it, in @CompoundQuery$Optimizer.isServerJoinPossible@ - the point is, a N...
- 07:43 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found
- Eric: this looks like the same #7229 problem.
- 07:41 AM Bug #7267: CompoundQuery FOR FIRST, EACH only retrieves the first record found
- There is a problem with CompoundQuery where using FOR FIRST, EACH will only return the first record available, ignori...
- 07:30 AM Bug #7267 (Test): CompoundQuery FOR FIRST, EACH only retrieves the first record found
- 07:17 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- *Committed 7138a_h2/rev.16*. Made changes to should-circuit fake-updates. @TestCompatibility@ change is related to #7...
- 07:17 AM Feature #6444: dataset improvements
- Eric Faulhaber wrote:
> Code review 6444b/14528:
>
> Only the "old" @Persistence.scroll@ and @Persistence.list@ m... - 05:53 AM Feature #6444: dataset improvements
- Code review 6444b/14528:
Only the "old" @Persistence.scroll@ and @Persistence.list@ methods with the @public@ acce...
04/10/2023
- 08:31 AM Feature #6444 (Review): dataset improvements
- Greg Shah wrote:
> The application Sergey is talking about has no datasets, no data relations. I would expect that ... - 07:09 AM Feature #6444: dataset improvements
- Greg Shah wrote:
> The application Sergey is talking about has no datasets, no data relations. I would expect that ... - 07:05 AM Feature #6444: dataset improvements
- The application Sergey is talking about has no datasets, no data relations. I would expect that usage of those APIs ...
- 07:03 AM Feature #6444: dataset improvements
- From Igor:
> An additional DataRelation parameter is used only for the second pass of the FILL operation. In all o... - 07:02 AM Feature #6444: dataset improvements
- From Sergey, in regard to the merged changes from 6444a:
> It seems @<customer_application_with_hand_coded_persist...
04/07/2023
- 02:26 PM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Well, the listener was added exactly for this reason, to invoke the @execute()@ method later, asynchronously from pre...
- 04:12 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Ovidiu Maxiniuc wrote:
> Rather it seems to me that the @getDelegate().notifyQueryOpenListeners(false);@ is not call... - 09:58 PM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- Alexandru Lungu wrote:
> Ovidiu, OFC, we can't mark the query as opened to avoid this. Can we at least short-circuit... - 08:39 AM Feature #7194 (WIP): Avoid generating an ORDER-BY clause if not required
- 02:10 AM Feature #6995 (Closed): possibly support NO-UNDO temporary tables directly in H2
04/06/2023
- 07:37 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
- I've added in @PreselectQuery@ a function that checks if the query will retrieve a unique finding. If so, then no @OR...
- 07:34 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- *Committed 7108a/rev.14528*. Removed @isAutoRtrimAndCi@ and replaced it with @isAutoRtrim and isAutoCi@.
I think tha... - 03:23 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> Historically speaking (in P2J/FWD terms), the @rtrim@ and @upper@ were handled together bec... - 08:45 PM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Ovidiu Maxiniuc wrote:
> > Dănuț Filimon wrote:
> > Note that, for the moment, only Maria... - 07:16 AM Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries
- I profiled the @INDEX-INFORMATION@ implementation in FWD on a POC that runs in ~10.000ms. ~10ms are spent inside @IND...
- 07:00 AM Bug #7258 (Closed): Optimize INDEX-INFORMATION with closed dynamic queries
- 04:36 AM Bug #7185: H2 in-memory lazy hydration
- Alexandru Lungu wrote:
> Radu, can you please check-out 7185a and test it against adaptive-scrolling/non-scrolling t...
04/05/2023
- 04:02 PM Feature #6444: dataset improvements
- The changes in @expressions.rules@ do not affect the code generated by the conversion.
- 04:00 PM Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > Review of 6444a/14552.
> >
> > @expressions.rules@: please u... - 03:45 PM Feature #6444: dataset improvements
- Ovidiu Maxiniuc wrote:
> Review of 6444a/14552.
>
> @expressions.rules@: please update the gap status for @KW_SYN... - 03:29 PM Feature #6444: dataset improvements
- Review of 6444a/14552.
@expressions.rules@: please update the gap status for @KW_SYNCHRON@ ("synchronize"), @KW_F_... - 02:11 PM Feature #6444: dataset improvements
- Updated history entries.
Committed to 6444a/14552.
Changes to the @rules/gaps/expressions.rules@ are also committed. - 02:25 AM Feature #6444: dataset improvements
- Branch 6444a was rebased to the trunk rev. 14525.
Pushed up to revision 14551.
- 03:46 PM Feature #6453: temp-table features
- Merged to the trunk rev. 14526.
- 01:41 PM Support #6455: XML feature(s) needing testing
- Igor,
The revision 14552 is NOT visible in @devsrv01:/opt/secure/code/p2j_repo/p2j/active/6444a@.
Is it possible ... - 08:51 AM Support #6455: XML feature(s) needing testing
- Eric Faulhaber wrote:
> As part of your final cleanup of #6444, please update the gap marking in @expressions.rules@... - 04:20 AM Support #6455 (Closed): XML feature(s) needing testing
- As part of your final cleanup of #6444, please update the gap marking in @expressions.rules@ in branch 6444a to full ...
- 04:13 AM Support #6455: XML feature(s) needing testing
- Eric Faulhaber wrote:
> Thank you, Igor. It does appear that runtime support for READ-XMLSCHEMA was updated from par... - 04:08 AM Support #6455: XML feature(s) needing testing
- Igor Skornyakov wrote:
> Eric,
> I believe that it was completely implemented in #6444. At least I've tested this f... - 04:07 AM Support #6455: XML feature(s) needing testing
- Thank you, Igor. It does appear that runtime support for READ-XMLSCHEMA was updated from partial to basic in @rules/g...
- 03:47 AM Support #6455: XML feature(s) needing testing
- Eric Faulhaber wrote:
> Igor, is this issue already covered by the work you have done for #6444? If so, how complete... - 03:42 AM Support #6455: XML feature(s) needing testing
- Igor, is this issue already covered by the work you have done for #6444? If so, how complete is the support now for t...
- 11:11 AM Bug #7235 (WIP): Avoid selecting all fields for an CAN-FIND sub-select
- 10:45 AM Bug #7185: H2 in-memory lazy hydration
- I have troubles testing 7185a. One customer application works flawlessly, while the other in hanging right at the sta...
- 09:13 AM Bug #7185: H2 in-memory lazy hydration
- Rebased 7185a with trunk (rev. 14525). 7185a is now at 14530.
- 09:01 AM Feature #7066: Implement multi-table indexed query in H2
- Tested 7066a against a customer application: most of the tests pass, but I have one that provides an unexpected outpu...
- 06:27 AM Feature #7066: Implement multi-table indexed query in H2
- Rebased 7066a with trunk rev. 14525. 7066a is now at rev. 14526.
Radu, please update 7066a and notify me if somethin... - 05:43 AM Feature #7066: Implement multi-table indexed query in H2
- *Review for 7066a_h2/rev. 14*
Most of the changes for #7066 are conceptually inside H2. I see that there are a lot... - 07:47 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Note that the changes require reconversion of the application (or at least regeneration of DDL - convert.middle and j...
- 05:00 AM Bug #7108 (Test): Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Danut, please address this issue and I will move this to test.
Never mind. This is not c... - 04:17 AM Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- I tested several applications:
* customer application POC - no regressions
* 2 customer application regression test... - 05:47 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- I think the issue is that we don't emit as lambda the OO expression. Take this test:...
- 03:24 AM Bug #6458: ensure that OO expressions resolve to query substitution parameters, like handle-based...
- Constantin, Greg informed me that you were concerned about certain OO expressions embedded in WHERE clauses not conve...
- 01:35 AM Bug #6887: improve performance of dataset/table[-handle] parameters
- We should profile and check how #6887-3 test behaves now with FWD first.
- 12:06 AM Bug #6887: improve performance of dataset/table[-handle] parameters
- Constantin Asofiei wrote:
> This is the entire JMX result for the large application:
> [...]
>
> The 3 cases fro...
Also available in: Atom