Activity
From 06/04/2023 to 07/03/2023
07/03/2023
- 03:16 PM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
- Constantin Asofiei wrote:
> Ovidiu, that looks interesting; I think is better to have the legacy field name instead ... - 03:02 PM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
- Ovidiu, that looks interesting; I think is better to have the legacy field name instead of column label or SQL field ...
- 01:31 PM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
- Please use @DataSet.getSqlData()@ and @RecordBuffer.sqlTableContent(N)@ instead. At least as a temporarily workaroun...
- 09:48 AM Bug #7334: Reclaim used sessions to improve performance
- I rebased 7334a to trunk. 7334a is now at rev. 14640.
- 03:31 AM Bug #7334: Reclaim used sessions to improve performance
- Danut, please focus on this task by testing DMO versioning. I am keen on merging 7334a asap.
In addition to #7334-... - 06:42 AM Feature #7459 (WIP): Implement BucketIndex in FWD-H2 to support multiplex
- I've done some basic implementation for this just to test out the hypothesis. I have:...
- 06:15 AM Bug #7474: FindQuery provides the wrong result because the record is not updated in the database
- Take the following example:...
- 04:59 AM Feature #7066: Implement multi-table indexed query in H2
- Hmm, I wonder if your logging also captures *multi-table @AdaptiveQuery@* that were optimized from @CQ@. My point: th...
- 04:21 AM Feature #7066: Implement multi-table indexed query in H2
- Alexandru Lungu wrote:
> * How many @CompoundQuery@ on _temp are there and how slow they are. We can use the FWD que... - 03:33 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Stefan, please focus exclusively on this task. I am planning to merge 7404a in trunk asap; but the regression should ...
- 03:17 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Alexandru Lungu wrote:
> Danut, I rebased 7138a_h2 from FWD-H2 trunk (rev. 23). Please commit a patch to avoid fake-...
07/02/2023
- 06:56 AM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
- Is this also why looking at the content of Exceptions changes the exception ? Because we just spend an entire week de...
07/01/2023
- 10:05 PM Bug #7467 (Review): join on meta table
- 10:04 PM Bug #7467: join on meta table
- Constantin Asofiei wrote:
> Ovidiu, so this means that this 'recid relation' is automatically applied only to meta o...
06/30/2023
- 08:57 AM Feature #7066: Implement multi-table indexed query in H2
- Rebased 7066a and 7066a_h2 to latest FWD_H2 and FWD trunk.
- 03:23 AM Feature #7066: Implement multi-table indexed query in H2
- The work here is hanging still for a while. I've done a reread of the changes here.
Currently, multi-table queries... - 07:41 AM Bug #7474 (WIP): FindQuery provides the wrong result because the record is not updated in the dat...
- 06:43 AM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
- Constantin Asofiei wrote:
> Current implementation relies on WRITE-JSON, which has side-effects on the default buffe... - 06:34 AM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
- Current implementation relies on WRITE-JSON, which has side-effects on the default buffer for the temp-table. This m...
- 06:32 AM Bug #7473 (Test): rewrite toString() implementation for Dataset, StaticTempTable and TempTableBui...
- 06:30 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- I added it, committed to 7026e, revision 14647.
- 05:07 AM Bug #7412 (Review): PresortQuery ORDER BY has to many clauses
- Stefan, please add a history entry to @src/com/goldencode/p2j/persist/PresortQuery.java@ regarding your changes. Don'...
- 05:57 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
- *Review of 7454a_h2/rev.24*
* I am OK with the changes. Good job!
I will start a testing + profiling round and... - 05:36 AM Bug #7454 (Review): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
- 05:50 AM Bug #7421 (Review): Check only the indexes that were changed when using Validation.checkMaxIndexS...
- > I've noticed that providing an offset that is greater or equal than 0 results in only one index being changed, this...
- 05:04 AM Bug #7389 (Test): Make fast-copy statements cachable
- Great. I will notify here when 7404a will be eventually merged.
- 05:02 AM Feature #7076 (Test): make CAN-FIND avoid hydration
- 04:55 AM Bug #7334: Reclaim used sessions to improve performance
- Alexandru Lungu wrote:
> Let me reiterate the protocol here. *Constantin, I would like a feedback on this.*
> * not... - 04:51 AM Bug #7334 (WIP): Reclaim used sessions to improve performance
- Danut, please commit them for further review.
> I also have a question, if we consider that a lifespan with the va... - 04:23 AM Bug #7138 (WIP): Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I've double checked how many fake-updates are in another customer application and indeed I've got only to 1%. The per...
- 03:32 AM Bug #7185 (Review): H2 in-memory lazy hydration
- This will go in pending for a while. Eric is already doing some parallel work on lazy hydration so we may need to syn...
- 02:49 AM Feature #7194 (Review): Avoid generating an ORDER-BY clause if not required
- Radu, can you try creating the records in different transactions. I don't have a clear perspective yet on how the tes...
06/29/2023
- 10:21 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- Done, I committed the changes on 7026e, revision 14605.
- 06:14 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- This can be optimized a bit further:
* Avoid using .size() in for - precompute it in another variable.
* Use @Sor... - 07:16 AM Bug #7389: Make fast-copy statements cachable
- Alexandru Lungu wrote:
> The changes are good. However, I think this is quite related to #7404. Danut, please move 7... - 06:24 AM Bug #7389: Make fast-copy statements cachable
- The changes are good. However, I think this is quite related to #7404. Danut, please move 7389a changes to 7404a - I ...
- 04:21 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
- *Committed 7454a_h2/rev.24* which adds the @OPTIMIZE_IGNORE_CASE@ database property, it is *false* by default.
I c... - 03:14 AM Feature #7323: Implement soft unique index in FWD-H2
- > I think we will need a statistic here. Radu, please feel free to count how many such cases actually occur in a cust...
06/28/2023
- 11:04 AM Feature #7323: Implement soft unique index in FWD-H2
- Alexandru Lungu wrote:
> I really wonder now how often this case actually occurs.
Yes, without some statistics, I... - 10:46 AM Feature #7323: Implement soft unique index in FWD-H2
- > The purpose of confirmUniqueConstraintViolation: consider that we are validating record A, which is in the FWD serv...
- 04:15 AM Bug #7467: join on meta table
- Ovidiu, so this means that this 'recid relation' is automatically applied only to meta or permanent tables. That is ...
- 08:39 PM Bug #7467: join on meta table
- I did some more research.
Indeed, in the case of TEMP-TABLES this @<parent>-recid@ lookup does not work. Here is t...
06/27/2023
- 04:58 PM Bug #7467: join on meta table
- Constantin Asofiei wrote:
> Ovidiu, @_Index-Seq@ I think is the position of the field in the index definition. Als... - 02:01 PM Bug #7467: join on meta table
- Ovidiu Maxiniuc wrote:
> > I don't have a customer app standalone test for this issue yet.
> I thought you encounte... - 01:44 PM Bug #7467: join on meta table
- Constantin Asofiei wrote:
> Ovidiu, @_Index-Seq@ I think is the position of the field in the index definition.
A... - 02:56 AM Bug #7467: join on meta table
- Ovidiu, @_Index-Seq@ I think is the position of the field in the index definition. Also, we need to limit this fix ...
- 09:05 PM Bug #7467 (WIP): join on meta table
- Constantin, please try the following patch:...
- 09:56 AM Feature #7323: Implement soft unique index in FWD-H2
- The purpose of @confirmUniqueConstraintViolation@: consider that we are validating record A, which is in the FWD serv...
- 05:36 AM Feature #7323 (WIP): Implement soft unique index in FWD-H2
- Radu, please check the following hypothesis from @Validation.validateUniqueByQuery@:...
- 05:19 AM Feature #7323: Implement soft unique index in FWD-H2
- Quite concerning, this runs slower by +0.5%. Only 2/5 profiling runs were faster than the baseline, but with just a b...
- 08:04 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- > I also tried to find out how @datetime@ and @datetime-tz@ and found that both types will always convert to the valu...
- 03:21 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- I ran a few tests using CALL and found out that there is aren't a lot of similarities between the conversion to the a...
- 06:40 AM Bug #7452: Analyze memory of the value cache from FWD-H2 and eventually increase size
- I will pend the effort here on analyzing cache size changes until #7454 is finished.
- 05:39 AM Bug #7454 (WIP): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
- Danut, I created 7454a_h2 for this task. The change is not complex, but confirming this is the right thing to do is h...
- 04:33 AM Feature #7382: Check performance of delete from vs drop table in H2
- This should be pending - #7459 may be a better way to fix this.
06/26/2023
- 03:06 PM Feature #7466: Using a different database connection to work around sequence specific issues
- Yes. Here is the quote from the official OpenEdge manual ("Working with sequences":https://docs.progress.com/bundle/o...
- 08:17 AM Feature #7466: Using a different database connection to work around sequence specific issues
- You are saying that in the 4GL, all sequence usage is outside of a transaction and never will be rolled back if there...
- 02:22 PM Bug #7467: join on meta table
- Ovidiu, this looks troublesome. 4GL may have some even more hidden fields to be able to join the meta tables, or som...
- 01:58 PM Bug #7467: join on meta table
- This seems like a problem with finding the inverse join index. In the case of these tables, the definitions are simil...
- 08:30 AM Feature #6763 (Rejected): implement configurable sizes (in the directory) for FastFindCache and O...
- 04:33 AM Feature #6763: implement configurable sizes (in the directory) for FastFindCache and ORM Session ...
- Just found out this issue. The same effort is already in-progress as part of #7388. This can be rejected.
- 08:10 AM Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
- Ștefan, please investigate why the invalidation doesn't occur when you are actually validating / saving the new recor...
- 07:58 AM Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
- The error is occurring due to invalidation of the cache. Invalidation takes place after all records have been inserte...
- 07:25 AM Bug #7334: Reclaim used sessions to improve performance
- Alexandru Lungu wrote:
> Constantin Asofiei wrote:
>> Alexandru, about the concurrency issues:
> Danut, please do ... - 03:13 AM Feature #7323: Implement soft unique index in FWD-H2
- *Review of 7323a, rev. 14590*
* This is OK.
* My only concern is related to @validatedMode ?@. I think you should...
06/25/2023
- 07:00 AM Bug #7467: join on meta table
- The customer's application has these errors:...
- 06:58 AM Bug #7467: join on meta table
- This test:...
- 06:53 AM Bug #7467 (Test): join on meta table
06/24/2023
- 08:46 PM Feature #7466: Using a different database connection to work around sequence specific issues
- This task is related to #7270 so that the approaches used for working around sequences issues can be discussed and do...
- 08:21 PM Feature #7466 (WIP): Using a different database connection to work around sequence specific issues
06/23/2023
- 09:46 AM Feature #7323: Implement soft unique index in FWD-H2
- I've implemented the logic for @insertValidateSql@ and tested with a customer application. The changes can be found o...
- 06:59 AM Feature #7323: Implement soft unique index in FWD-H2
- The profiling results are quite interesting. The average improvement is only -0.2%. *However*, I've got a run with -2...
- 06:00 AM Feature #7323: Implement soft unique index in FWD-H2
- Alexandru Lungu wrote:
> * Please add some extra javadoc to @Persister.insert@ to better understand what @validateMo... - 03:48 AM Feature #7323 (Review): Implement soft unique index in FWD-H2
- *Review of 7323a, rev. 14588*
* The changes are OK.
* Please add some extra javadoc to @Persister.insert@ to bett... - 07:42 AM Bug #7334: Reclaim used sessions to improve performance
- The agents in an appserver live for the lifetime of the FWD Server - so this Session can exist forever, if this LIFET...
- 06:29 AM Bug #7334: Reclaim used sessions to improve performance
- Constantin Asofiei wrote:
> if it executes on the @SessionCloseThread@. We need tests and make sure the @Conversati... - 05:12 AM Bug #7334: Reclaim used sessions to improve performance
- I'm not sure how we can solve this:...
- 05:09 AM Bug #7334: Reclaim used sessions to improve performance
- Constantin Asofiei wrote:
> Alexandru, about the concurrency issues:
Danut, please do the fixing.
> otherwise,... - 05:05 AM Bug #7334: Reclaim used sessions to improve performance
- Alexandru, about the concurrency issues:
* This code can execute on the @SessionCloseThread@. This is not an @Assoc... - 04:35 AM Bug #7334: Reclaim used sessions to improve performance
- > Alexandru, there are some concurrency issues
I will do a second check then. Please let me know if you already sp... - 03:55 AM Bug #7334: Reclaim used sessions to improve performance
- Alexandru, there are some concurrency issues, but my main concern is this:...
- 03:19 AM Bug #7334: Reclaim used sessions to improve performance
- *Eric, Constantin, Ovidiu*: can you provide a feedback here. The performance tests show real good results and the imp...
- 07:31 AM Feature #7320: Extend H2 tester from Hotel GUI
- The changes that I did to the H2 tester are :
* I removed the initial create;
* I removed the delete operation tha... - 03:12 AM Feature #6630 (Test): optimize return of table parameter
- This can be closed now. #6630-2 is already solved and merged into trunk at some point.
- 03:10 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Please do some forensics on that issue you have with the customer application. Do some debugging - extract the tables...
06/22/2023
- 10:00 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- After letting simpleCopy be true when the explicit signatures matched, some custom small tests looked fine, but after...
- 07:52 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- With @7404a revision 14629@ it is slightly better, but we are still 1% behind. However, I had really high variance on...
- 09:28 AM Feature #7459: Implement BucketIndex in FWD-H2 to support multiplex
- This task is inside my head for a really long time. I had an attempt at some point to implement it, but I didn't had ...
- 09:06 AM Feature #7459 (WIP): Implement BucketIndex in FWD-H2 to support multiplex
- 07:40 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- You can also try combinations like this, when using characters and octal representation:...
- 07:35 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- Dănuț Filimon wrote:
> Constantin Asofiei:
> > If you are trying to find the binary representation of different dat... - 07:34 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- Constantin Asofiei:
> If you are trying to find the binary representation of different data types, take a look @Call... - 07:23 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- Constantin Asofiei wrote:
> As a side note, this @converTo@ method has some assumptions for i.e. int64 when the OUTP... - 07:20 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- Danut, I think 4GL just reads the first two bytes from the memory address where this value is stored (as max extent s...
- 07:19 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- *Committed 7059a/rev.14633*. I added deference operators to handle @character/longchar/logical/date@ types, I did not...
- 06:05 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- Here's a decimal overview of the formulas used in each situation:
|_. Action |_. Decimal value type ... - 04:45 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- Some related questions:
* empty character results in extent 0?
* negative decimal is any different? I guess that @+... - 04:41 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- Danut, comparing to other 4GL data type, @decimal@ seems to have two values stored: @value@ and @scale@. You issue ma...
- 03:13 AM Feature #7320 (WIP): Extend H2 tester from Hotel GUI
- Stefan, please commit your extension to Hotel GUI.
AFAIK, you developed exclusively in 4GL for this task. Move you...
06/21/2023
- 08:27 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- I added the first change, and I will start working/testing the second change.
Committed to 7404a revision 14629. - 06:10 AM Feature #7404 (WIP): Trasform replace-mode into append-mode when target table is empty
- My profiling still shows slow code here - even slower than before with +1.3%. In fact, this is because of the followi...
- 05:37 AM Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- I've investigated the issue and found the following:
* for characters, the index is calculated using @(second char <... - 01:53 AM Bug #7449 (Test): unqualified _File buffer must target the first database in the connection list
- Branch 7449a was merged to trunk rev 14632 and archived.
06/20/2023
- 03:51 PM Bug #7449: unqualified _File buffer must target the first database in the connection list
- You can rebase and merge to trunk.
- 03:50 PM Bug #7449: unqualified _File buffer must target the first database in the connection list
- Code Review Task Branch 7449a Revision 14631
No objections. - 09:16 AM Bug #7452: Analyze memory of the value cache from FWD-H2 and eventually increase size
- > AFAIK, there are way more case-insensitive values than case-sensitive ones in customer applications.
Very true. - 06:06 AM Bug #7452: Analyze memory of the value cache from FWD-H2 and eventually increase size
- This is a statistic on the value cache hit ratio depending on the cache size.
|_. Size |_. Hit |_. Miss |_. Rat... - 04:14 AM Bug #7452 (WIP): Analyze memory of the value cache from FWD-H2 and eventually increase size
- FWD-H2 has a @Value.softCache@ that stores the values used by H2. Every bit of information stored by H2 is wrapped by...
- 03:59 AM Bug #7452 (WIP): Analyze memory of the value cache from FWD-H2 and eventually increase size
- 08:24 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Makes sense. However, I still feel there is some valuable logic behind @DatabaseStatistics@ that can be reused. Not n...
- 07:42 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Ovidiu Maxiniuc wrote:
> the normal way of shutting down the server (and collect the database statistics) is to 'ask... - 01:36 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Ovidiu Maxiniuc wrote:
> The SIGINT (CTRL+C) is the alternative 'hard' way.
This may be an amateur question on my... - 10:35 PM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- the normal way of shutting down the server (and collect the database statistics) is to 'asked' it nicely, using the @...
- 06:10 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
- This task is related to @setString@ parameter setting in FWD-H2. Most of the strings we are using with this option ar...
- 06:07 AM Bug #7454 (Closed): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
- 04:27 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- I added all the changes.
Committed to 7026e revision 14604. - 02:42 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- *Review of 7026e, revision 14603*
* We can go the extra mile here for performance sake
** let @recIdsSet@ be @nul... - 03:58 AM Feature #7363 (Test): Improve H2 Value caching, hashing and equals
- Completely *tested* - everything looks right.
I tested a large customer application and I got:
* 425.568 cache hi... - 02:20 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- I added the changes and committed again on 7404a revision 14628.
- 02:07 AM Feature #7404 (Review): Trasform replace-mode into append-mode when target table is empty
- *Review of 7404a revision 14626*
* I am OK with the functional changes.
* Please add a comment before the fast-co...
06/19/2023
- 01:55 PM Bug #7449 (Review): unqualified _File buffer must target the first database in the connection list
- Created task branch 7449a from trunk rev 14630.
The changes are in 7449a rev 14631. - 01:44 PM Bug #7449: unqualified _File buffer must target the first database in the connection list
- The assumptions in note #6129-28 and others, where it was found that the last connected database is used I think are ...
- 11:33 AM Bug #7449: unqualified _File buffer must target the first database in the connection list
- In OpenEdge, when running from command line, like this:...
- 11:26 AM Bug #7449 (Test): unqualified _File buffer must target the first database in the connection list
- 09:40 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Alexandru Lungu wrote:
> @DatabaseStatistics@ is a good solution for query profiling on the FWD part.
I started to ... - 09:13 AM Feature #7363 (Review): Improve H2 Value caching, hashing and equals
- *Review of 7363b_h2 revision 23*
I am OK with the changes.
Most of the testing doesn't show regressions. I am doi... - 06:01 AM Feature #7363: Improve H2 Value caching, hashing and equals
- Added the change and committed it to 7363b_h2 revision 23.
- 05:51 AM Feature #7363: Improve H2 Value caching, hashing and equals
- *Review of 7363b_h2 revision 22*
* @ValueBytes@ is not using @instanceof@ to check @obj@ of type @byte[]@. *This i... - 09:11 AM Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
- From #7363-19:...
- 09:09 AM Bug #7448 (Rejected): Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
- 09:10 AM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...
- Greg Shah wrote:
> > Marian: What work is needed to complete these tests? What is the status of the existing tests ... - 08:18 AM Feature #7323: Implement soft unique index in FWD-H2
- I've applied the changes suggested in #7323-12 for both 7323a and 7323a_h2.
I've also added tests in 7323a_h2 and fi... - 06:57 AM Feature #7447: Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
- There are several hits of @Value.compareTo@, where the operands are @ValueString@ and @ValueStringIgnoreCase@. This i...
- 06:46 AM Feature #7447 (Closed): Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
- 05:04 AM Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
- I retested the customer application using @MethodTraceAspect@ instead of @AdaptiveQueryTraceAspect@ and *8031* calls ...
- 04:49 AM Bug #7059 (WIP): FWD shouldn't raise errors for non-numeric extent indexes.
06/16/2023
- 09:12 AM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...
- > Marian: What work is needed to complete these tests? What is the status of the existing tests for table/table-hand...
- 04:17 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Committed 7416a to trunk as rev. 14626.
- 04:08 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have a potential fix for the remaining issues of the @TestWriteXmlFile.cls@, but are probably wrong:
- @BaseDataTy...
06/15/2023
- 04:49 PM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Code Review Task Branch 7416a Revision 14626
No objections. You can merge to trunk. - 10:40 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Greg Shah wrote:
> > Add a sensible flag to the configuration.
>
> Please use @sensitive@ instead of @sensible@.
... - 10:08 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- This sounds good to me. There are cases in which a query from a stack trace is basically a dynamic query. Therefore, ...
- 09:54 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- I've done two more changes that can be found on 7416a, rev. 14633:
* I've increased the number of characters printed... - 07:44 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Greg Shah wrote:
> > Add a sensible flag to the configuration.
>
> Please use @sensitive@ instead of @sensible@.
... - 07:34 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- > Add a sensible flag to the configuration.
Please use @sensitive@ instead of @sensible@. - 07:29 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Alexandru Lungu wrote:
> Add a @sensible@ flag to the configuration. If this is set, output only: @sql.substring(0, ... - 04:46 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Radu Apetrii wrote:
> If any ideas come to my mind, I will post updates.
I think we can adopt a naive way of cens... - 04:41 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Radu, please make sure you don't miss out the dirty databases as part of the SQL logging / query logging. I think the...
- 04:21 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> 1. For H2, we always proxy the statements through @TempTableDataSourceProvider@, so all...- 11:24 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- Committed to 7026e, revision 14603.
- 10:44 AM Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
- I wonder if our LTW is spoiled somehow by the GC. I mean, for a simple @setScrolling@, it is hard to believe that 750...
- 09:52 AM Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
- I tested a customer application using @AdaptiveQueryTraceAspect@. My results for @setScrolling@ were ~5.5k calls with...
- 07:57 AM Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
- Danut, can you take a look into this one?
It is quite bad that @AdaptiveQuery.setScrolling()@ works that slow. Ple... - 07:48 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
- I created a test using a temporary table with 50 fields, all being part of unique/non unique indexes. It consisted of...
- 05:18 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
- Eric Faulhaber wrote:
> @BaseRecord.getDirtyIndices@ already is invoked in several places in @Validation@. Can we re... - 05:29 AM Feature #7365: Avoid using reflection in generating BDT
- I added in @BaseDataTypeFactory@ a function @instantiate@ that also takes as a parameter the initial value that is to...
- 03:03 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> Marian: Any idea why this reports as unserializable when the class itself is marked serializable?...
06/14/2023
- 02:44 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- @progress.lang.object@ fields are not serializable. This test:...
- 02:21 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > I have problems understanding the other failures in the @TestWriteXmlFile.cls@ method @writeFileInvalid@.
> This p... - 09:33 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have problems understanding the other failures in the @TestWriteXmlFile.cls@ method @writeFileInvalid@.
This porti... - 10:11 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I added the changes.
Committed to 7363b_h2 revision 22. - 08:02 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Fixed an error and committed again on 7404a revision 14627.
- 05:48 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Committed to 7404a revision 14626.
- 04:43 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Created 7404a.
- 04:52 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- The clause is added firstly at initialization which is correct since there can be multiple clauses that may need to b...
- 04:24 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- -Danut, please prioritize this if you think it can be fixed by the end of this week. From my POV, there shouldn't be ...
- 04:42 AM Bug #7403 (WIP): Copy-temp-table with replace-mode should replace already inserted records
- 04:36 AM Feature #7365: Avoid using reflection in generating BDT
- Radu, if it doesn't take much time, please do a quick round-check of this issue and try to get this change in 7026e b...
06/13/2023
- 01:04 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Having this:...
- 11:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have implemented the changes, under rev 14621 on 4514a branch. There are still some other errors that the @TestWrit...
- 07:49 AM Bug #7421 (WIP): Check only the indexes that were changed when using Validation.checkMaxIndexSize
- 07:17 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Created 7416a.
- 06:07 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- I have two ideas here:
1. For H2, we always proxy the statements through @TempTableDataSourceProvider@, so all sta... - 06:31 AM Bug #7388: Create server configuration container for cache sizes
- *Committed 7388a.rev14619.* Added @CacheManager@ that reads the configuration cache sizes of classes and can be used ...
- 06:14 AM Feature #7323: Implement soft unique index in FWD-H2
- Radu, please focus on this after you finish the recent performance logging changes. I will like to give it a performa...
- 03:13 AM Feature #7363: Improve H2 Value caching, hashing and equals
- *Review of 7363b_h2 revision 21*
* @ValueByte.lowLevelEquals@ should use @((Byte) obj).byteValue()@ to stay consis...
06/12/2023
- 11:34 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Good.
Maciej: Please move ahead on this basis. - 11:27 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Greg Shah wrote:
> Rather than processing the error manager logging on the client, why not add the needed handling t... - 11:03 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- Rather than processing the error manager logging on the client, why not add the needed handling to @DeferredLegacyErr...
- 10:56 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- @DeferredLegacyErrorException@ is missing the case for when is thrown from the FWD client. Originally this was meant...
- 10:36 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- We already catch @DeferredLegacyErrorException@ in @BlockManager.processBody()@ and we call @BlockManager.processLega...
- 10:25 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I am not exactly sure how to handle the @DeferredLegacyErrorException@ exception, when the client throws @302@ or @46...
- 10:17 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I added the changes.
Commited to 7363b_h2 revision 21. - 05:39 AM Feature #7363: Improve H2 Value caching, hashing and equals
- *Review of 7363b_h2 revision 20.*
* Use space after @if@ keyword to separate from @(@ (according to H2 standard)
... - 09:57 AM Bug #7389 (Review): Make fast-copy statements cachable
- This is good. I am extracting your changes and add them to my profiling branch. I am curious of the improvement. Howe...
- 09:53 AM Bug #7389: Make fast-copy statements cachable
- Here is an update of the test from #7389-3:
|_. Type |_. Total |_. No append or loose mode |_. Append m... - 08:53 AM Bug #7389: Make fast-copy statements cachable
- *Committed 7389a.rev14594.* Fixed the problem mentioned in #7389-6. It was caused by missing records that were not co...
- 06:03 AM Bug #7389: Make fast-copy statements cachable
- *Review of 7389a.rev14593*
* I am OK with the changes.
* Please also consider @srcRecId@ when ruling our pk mapp... - 09:41 AM Feature #6371 (Test): implement SAVE CACHE statement
- 07:45 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Alexandru Lungu wrote:
> * *Ensure that no sensible data is logged (query parameters) in neither profiler*
I have b... - 04:38 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Radu, please make the documentation of #6970 sql profiler and #7416 query profiler (leveraging @DatabaseStatistics@) ...
- 03:13 AM Bug #7388: Create server configuration container for cache sizes
- Eric Faulhaber wrote:
> That being said, my experience with using @SoftReference@ is from several JVM generations ag...
06/09/2023
- 11:07 AM Bug #7388: Create server configuration container for cache sizes
- There may be some specific use cases where they make sense, but in general, I am not a huge fan of soft references, f...
- 10:48 AM Bug #7388: Create server configuration container for cache sizes
- Eric Faulhaber wrote:
> I don't think *every* setting should be configurable. Generally speaking, the developer will... - 10:15 AM Bug #7388: Create server configuration container for cache sizes
- Alexandru Lungu wrote:
> I am thinking bigger than only setting the size :)
Thinking beyond the current problem... - 02:55 AM Bug #7388: Create server configuration container for cache sizes
- Eric Faulhaber wrote:
> Routing this through a factory seems messy
I think it is easier to convey that a @CacheMa... - 10:52 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- We could do something similar for the dump name during conversion, if there is a unique constraint violation, so conv...
- 10:42 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- > Is this intended that server does not see any information about the error when the error is thrown in the client ?
... - 06:16 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- I have hard time implementing the @302@ and @463@ errors in FWD, as expected by 4GL in case of @tests/dataset/TestWri...
- 10:01 AM Feature #7363: Improve H2 Value caching, hashing and equals
- Committed to 7363b_h2 revision 20.
- 06:58 AM Feature #7363: Improve H2 Value caching, hashing and equals
- I made a profiler to test the new caching method.
I updated the table with the average time of 5 runs for each value... - 09:11 AM Feature #5130 (Rejected): improve management of p2jpl.jar in deployment scripts
- I'm closing this as unneeded. We are moving all customers to the native UDFs and PL/Java is deprecated at this time....
- 03:31 AM Feature #7062: Direct access to H2 internals to solve basic queries
- Merged 7062c_h2 into FWD-H2 trunk as rev. 21.
The fix will be available with the next FWD-H2 upgrade.
06/08/2023
- 11:34 AM Bug #7388: Create server configuration container for cache sizes
- Alexandru Lungu wrote:
> Constantin Asofiei wrote:
> > Yes, reading this at server startup will solve this.
> >
... - 10:19 AM Bug #7388: Create server configuration container for cache sizes
- Alexandru Lungu wrote:
> This is strange ...
A hard reload of the browser page before adding a task history entry... - 06:58 AM Bug #7388: Create server configuration container for cache sizes
- This is strange ...
- 06:57 AM Bug #7388: Create server configuration container for cache sizes
- Constantin Asofiei wrote:
> Yes, reading this at server startup will solve this.
>
> The problem is that director... - 05:26 AM Bug #7388: Create server configuration container for cache sizes
- I already committed 7388a.rev14618, but will make the changes to read the cache size values at runtime.
- 04:55 AM Bug #7388: Create server configuration container for cache sizes
- Yes, reading this at server startup will solve this.
The problem is that directory is being read while another cod... - 04:26 AM Bug #7388: Create server configuration container for cache sizes
- Constantin Asofiei wrote:
> Please see #7398 for issues we have with the admin console, related to these static cons... - 04:02 AM Bug #7388: Create server configuration container for cache sizes
- Please see #7398 for issues we have with the admin console, related to these static constructors which read from dire...
- 03:47 AM Bug #7388 (WIP): Create server configuration container for cache sizes
- I created 7388a. Please commit your changes there. If everything is alright, I will do the merge.
- 03:44 AM Bug #7388: Create server configuration container for cache sizes
- I did a few changes as you suggested:
* Changed the name of a few cache nodes;
* Simplified the directory-reading c... - 11:12 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
- Ștefan, I will put you up-to-date with the FWD implementation of @copy-temp-table@:
*4GL logic*
@copy-temp-table@... - 08:01 AM Feature #7404 (WIP): Trasform replace-mode into append-mode when target table is empty
- 11:09 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
- Good idea. @BaseRecord.getDirtyIndices@ already is invoked in several places in @Validation@. Can we re-use the value...
- 08:46 AM Bug #7421: Check only the indexes that were changed when using Validation.checkMaxIndexSize
- @Validation.checkMaxIndexSize@ is checking all indexes to detect if the maximum size was exceeded. This happens only ...
- 08:42 AM Bug #7421 (WIP): Check only the indexes that were changed when using Validation.checkMaxIndexSize
- 09:43 AM Feature #7363: Improve H2 Value caching, hashing and equals
- Ștefan, please prepare a commit on 7363b_h2 with your latest changes. Make sure you update #7363-11 accordingly. Also...
- 08:40 AM Bug #7420 (WIP): Optimize Cursor for scrolling AdaptiveQuery
- This is a task in regard to a hot-spot in @AdaptiveQuery.setScrolling()@. It is called 7506, but it takes 795ms own t...
- 08:13 AM Bug #7420 (Closed): Optimize Cursor for scrolling AdaptiveQuery
- 06:36 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- Greg Shah wrote:
> Why would the dump-name itself be the cause of a collision?
Well, the index is unique, and I ass... - 06:32 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- Why would the dump-name itself be the cause of a collision?
What happens in OE when this same @.df@ is processed? - 06:09 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- There is an unique index on the @_field._dump-name@, in the meta schema:...
- 06:07 AM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- If the 4GL doesn't care that the @DUMP-NAME@ is unique, why do we care? It seems like there is no compatibility requ...
- 05:13 AM Support #4550 (Closed): eliminate the need to place the p2jspi.jar in the JVM extension directory
- 05:08 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- @DatabaseStatistics@ is a good solution for query profiling on the FWD part. This was implemented before Hibernate an...
- 05:05 AM Feature #7416 (Closed): Reiterate DatabaseStatistics and leverage to other database profling tools
- 03:49 AM Bug #7412 (WIP): PresortQuery ORDER BY has to many clauses
- Danut, please investigate. The change should go to 7026e when ready.
06/07/2023
- 03:35 PM Bug #7388: Create server configuration container for cache sizes
- Dănuț Filimon wrote:
> I found the following to be configurable:
> * @BufferManager.convertedNames@, size is 10000;... - 09:07 AM Bug #7388: Create server configuration container for cache sizes
- I found the following to be configurable:
* @BufferManager.convertedNames@, size is 10000;
* @DynamicTablesHelper.c... - 03:13 AM Bug #7388: Create server configuration container for cache sizes
- Danut, please take time to navigate through the persistence / orm package of FWD and search for any cache which can h...
- 02:37 PM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- Constantin Asofiei wrote:
> If two tables have the same DUMP-NAME in the .df, the FWD can not start, as it enforces ... - 12:22 PM Bug #7413: DUMP-NAME is not guaranteed to be unique in the .df
- If two tables have the same DUMP-NAME in the .df, the FWD can not start, as it enforces an unique index in the meta t...
- 12:20 PM Bug #7413 (New): DUMP-NAME is not guaranteed to be unique in the .df
- 08:25 AM Feature #7365 (WIP): Avoid using reflection in generating BDT
- Radu, please check @BufferFieldImpl.changeValue@. Consider extending @BaseDataTypeFactory@ with a new method to handl...
- 08:24 AM Bug #7412: PresortQuery ORDER BY has to many clauses
- I have the following SQL generated in H2 for a @PresortQuery@:...
- 06:56 AM Bug #7412 (Closed): PresortQuery ORDER BY has to many clauses
- 08:24 AM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...
- The test failure @tests/dataset/TestTopNavQuery.cls@ method @TestSetInvalid@, throws 3 errors instead of 2.
The unex... - 04:04 AM Bug #7035 (Review): Extract query parameters from statically converted FQL
- Considering the JMX results of hit/miss before/after static query parameter extraction, I think this effort can be dr...
06/06/2023
- 11:17 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > I'm trying to re-test error handler suppoprt for MariaDB, but ca... - 10:29 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor Skornyakov wrote:
> I'm trying to re-test error handler suppoprt for MariaDB, but cannot create a database, get... - 09:55 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- I'm trying to re-test error handler suppoprt for MariaDB, but cannot create a database, getting the following errors ...
- 07:59 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Greg Shah wrote:
> It still adds the cost of UUID generation to the query. This still seems costly. Why not use a ... - 07:56 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- It still adds the cost of UUID generation to the query. This still seems costly. Why not use a sequence if you need...
- 07:45 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Greg Shah wrote:
> Are you saying that every guarded UDF execution requires a UUID to be generated? That seems expe... - 07:30 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Are you saying that every guarded UDF execution requires a UUID to be generated? That seems expensive.
- 05:05 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite differe... - 03:12 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Rebased 6628a to the trunk rev.14613
Pushed up to revision 14614. - 09:43 AM Bug #7035: Extract query parameters from statically converted FQL
- I retested the changes on a customer application as you said and the results are almost the same.
|_. JMX ... - 05:36 AM Bug #7035: Extract query parameters from statically converted FQL
- I've redone the tests with your JMX. I get the following results in Cold/Warm runs on a customer application.
|_. ... - 08:41 AM Feature #7323: Implement soft unique index in FWD-H2
- *Review to 7323a, rev. 14587*
* I don't think we should always allow @soft_unique@ right from @Dialect@. Better exte... - 07:55 AM Feature #7323: Implement soft unique index in FWD-H2
- I am checking out this right now.
I will run some tests/profiling on my own and keep you updated.
Anyway, I fe... - 05:39 AM Bug #7389: Make fast-copy statements cachable
- *Committed 7389a.rev14593.* Added @FastCopyHelper.safeTableCopyNoMapping@ that doesn't use mapping.
At the moment, t...
06/05/2023
- 03:50 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite differe... - 03:43 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor, as the Maria UDF implementation of the nested CAN-FIND error-handling is quite different than the PostgreSQL im...
Also available in: Atom