Project

General

Profile

Activity

From 09/16/2023 to 10/15/2023

10/13/2023

10:22 AM Feature #4722 (Test): data import should be able to run with only the converted application jar f...
Roger Borrello
10:22 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
4722a was merged to trunk rev 14773 and archived. Roger Borrello
09:58 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Please merge to trunk now. Greg Shah
09:32 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Is there anything we need to handle from a project migration/cfg perspective when this is merged?...
Roger Borrello
09:27 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Is there anything we need to handle from a project migration/cfg perspective when this is merged?
Roger: Can you...
Greg Shah
09:18 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14772 and is at revision 14790. Roger Borrello
07:24 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Review:
* Add history numbers to @Validation@ (and all other classes that have changes on this branch exclusively ...
Alexandru Lungu

10/11/2023

05:21 AM Feature #7416 (Review): Reiterate DatabaseStatistics and leverage to other database profling tools
Radu Apetrii
05:21 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I've done another commit in which I've fixed some of the things that I noticed during the "rereview":
* There was a ...
Radu Apetrii
03:22 AM Feature #6720: lazy hydration
Eric, I prepared some questions here last week, but it seems I missed submitting them. I was kind of waiting for feed... Alexandru Lungu

10/10/2023

12:51 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14769 and is at revision 14787. I committed an update to @import.sh@ which change... Roger Borrello
07:27 AM Feature #7416 (WIP): Reiterate DatabaseStatistics and leverage to other database profling tools
I tried to run @./gradlew.all@ in the 7416b branch, but I've encountered some errors. Thus, I've committed to 7416b, ... Radu Apetrii

10/06/2023

09:07 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> Radu, please rebase 7416b to the latest trunk. "Rereview" the changes and test them with a ...
Radu Apetrii
06:27 AM Feature #7416 (Review): Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, please rebase 7416b to the latest trunk. "Rereview" the changes and test them with a project you already have i... Alexandru Lungu

10/05/2023

05:54 AM Bug #7776 (Review): Previous regression on FWD-H2 lazy mode
This was merged to FWD-H2 trunk as rev. 28 and reached trunk as fwd-h2-1.31-trunk. Alexandru Lungu

10/04/2023

06:23 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14766 and is at revision 14783. Roger Borrello
04:13 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> I re-reviewed the changes and only have only one question: there are some commits with no f...
Roger Borrello
03:41 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Yes.
I re-reviewed the changes and only have only one question: there are some commits with no file changes (14781, ...
Ovidiu Maxiniuc
08:28 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu: Are you OK with merging? Greg Shah
08:26 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Are these changes safe to merge now?
>
> Is there anything we need to handle from a project mi...
Roger Borrello
07:55 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Are these changes safe to merge now?
Is there anything we need to handle from a project migration/cfg perspective ...
Greg Shah

10/03/2023

06:33 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch was rebased to trunk 14764 and is at revision 14781. Roger Borrello

10/02/2023

12:53 PM Feature #6720: lazy hydration
Task branch 6720b has been rebased to trunk rev 14762. New 6720b revision is 14766.
Alexandru, please review the c...
Eric Faulhaber
04:40 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
I retested the testcase from #6196-47, but instead of @for each@ I used @preselect each@.
Without the changes from #...
Andrei Bălteanu

09/29/2023

07:15 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to trunk_14758 at revision 14775. Roger Borrello
10:06 AM Bug #7667 (WIP): Support OUTER-JOIN with PRESELECT at conversion
The branch 7667a was created to solve a problem related to a *run-time* optimization. This was not the initial purpos... Andrei Bălteanu
09:58 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
What is the % Done on this task? Greg Shah
09:51 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667a was merged to trunk rev. 14757 and archived. Alexandru Lungu
09:46 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
You can merge 7667a now. Greg Shah
06:59 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei, I am OK with the changes. Still, @isConstant@ is not "integrated" into the mainWalk - there are still two wal... Alexandru Lungu
04:57 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Sure thing!
Committed the changes on 7667a revision 14760.
Andrei Bălteanu
02:35 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei, please address #7667-19 asap (including the move of your code in @mainWalk@ to avoid extra AST traversals). A... Alexandru Lungu
06:58 AM Bug #7855: Integrate fixEmptyContains into mainWalk at FQL preprocessing
There is another AST traversal done in @fixEmptyContains@ which can be integrated into @mainWalk@ for further perform... Alexandru Lungu
06:58 AM Bug #7855 (New): Integrate fixEmptyContains into mainWalk at FQL preprocessing
Alexandru Lungu

09/28/2023

05:12 PM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667 has been rebased to trunk_14756. Roger Borrello
11:05 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei Bălteanu wrote:
> Regarding the problem from #7667-9, I was thinking about the following changes:
> [...]
>...
Eric Faulhaber
10:49 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Code review 7667a/14757:
The logic looks good. A few minor issues:
* Please avoid using the @for-each@ syntax w...
Eric Faulhaber
09:26 AM Bug #7667 (Review): Support OUTER-JOIN with PRESELECT at conversion
I'm having a look... Eric Faulhaber
08:40 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Alexandru Lungu wrote:
> Note that this task is about conversion support, so 7667a is not going to address the task,...
Igor Skornyakov
08:27 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Note that this task is about conversion support, so 7667a is not going to address the task, but only fix a run-time r... Alexandru Lungu
06:30 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Modified accordingly.
There was also a parameter out of line and i fixed that too (cheers to Radu for the heads up)...
Andrei Bălteanu
05:44 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Review of 7667a:
* Fix history entry of @CompoundQuery@ (AB is on a different line than the entry description)
* Re...
Alexandru Lungu
04:52 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Regarding the problem from #7667-9, I was thinking about the following changes:... Andrei Bălteanu
05:09 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to trunk_14756. Roger Borrello

09/27/2023

01:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The benefit of the @build_db.xml@ is it falls right in line with the @ant@ build of the application and provides a le... Roger Borrello
01:25 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I'm good with that idea. Greg Shah
12:44 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I am not aware of any open issues here.
When I first created the @import.sh@ my intention was to have a faster way...
Ovidiu Maxiniuc
12:23 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
For Hotel GUI/ChUI, I would expect that the standard projects might be simplified to some degree and I would expect t... Greg Shah
08:12 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Roger: What is the migration plan? There are changes to apply for both Hotel projects? What abo...
Roger Borrello
07:40 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor/Ovidiu/Eric: Any objections or known open items?
Roger: What is the migration plan? There are changes to app...
Greg Shah
10:12 AM Bug #7797: FWD-H2 LAZY reverse index regression
Sounds good. Eric will handle the push when you are ready. Greg Shah
09:04 AM Bug #7797: FWD-H2 LAZY reverse index regression
I would like to have 7789a_h2 merged as well, before the upgrade. I finished the implementation (going to update #778... Alexandru Lungu
08:03 AM Bug #7797: FWD-H2 LAZY reverse index regression
Is this ready to be deployed on @proj.goldencode.com@? If so, is it safe to push it with the current version of trunk? Greg Shah
05:44 AM Bug #7797 (Test): FWD-H2 LAZY reverse index regression
Alexandru Lungu
05:43 AM Bug #7797 (Review): FWD-H2 LAZY reverse index regression
I am OK with the changes in 7066c_h2.
I also changed the planner a bit to score more the indexes that are reversed i...
Alexandru Lungu
03:04 AM Feature #6720: lazy hydration
This entry is intended to document the prototype implementation of lazy hydration in 6720b/14632-14634: what is imple... Eric Faulhaber

09/26/2023

06:07 PM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667a has been rebased to the latest trunk (14754). Roger Borrello
04:46 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Thanks for the review!
Modified accordingly and committed to 7667a revision 14753.
Andrei Bălteanu
05:51 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to the latest trunk (14754).
Is there anything keeping this from being merged with t...
Roger Borrello
09:06 AM Bug #7841: Invalid conversion of temp table DMO when using clob/blob fields
Sorry, there is a typo in the file @start.p@, where I forgot to rename the procedure @atable-clob.p@ to @table-clob.p... Alexandru Donica
08:57 AM Bug #7841: Invalid conversion of temp table DMO when using clob/blob fields
I created 2 temp tables, in separate procedures, with the same table name, same field types with same field names, bu... Alexandru Donica
08:51 AM Bug #7841 (Test): Invalid conversion of temp table DMO when using clob/blob fields
Alexandru Donica
04:45 AM Bug #7797: FWD-H2 LAZY reverse index regression
I've addressed the review from the previous post and committed the changes to 7066c_h2, rev. 31.
> * Why is @curre...
Radu Apetrii

09/25/2023

10:18 AM Bug #7797: FWD-H2 LAZY reverse index regression
*Review of 7066c_h2:*
* I like seeing ~20 new tests on LAZY :)
* Why is @currentSearchRow = null@ required in you...
Alexandru Lungu
09:04 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
*Review of 7667a changes:*
* Please limit this only to outer-join cases. I think it is right to join two tables if...
Alexandru Lungu
08:51 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
While trying to create a testcase that would help me solve this initial purpose of the task (changing the conversion ... Andrei Bălteanu
04:31 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Igor, I think I led you into a small misunderstanding.
The comment from #7667-5 was related to a @run-time@ optimiza...
Andrei Bălteanu

09/22/2023

02:31 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The latest revision of @import.sh@ is checked into the branch:... Roger Borrello
01:13 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Thanks, Ovidiu. I was following the MariaDB setup from @build_db.xml@ in hotel_gui. I'll update that. Right now my @i... Roger Borrello
08:33 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Should the user ID for the PatternEngine be fwd_admin?
Not mandatory. @fwd_user@ does not have enough privileges g...
Ovidiu Maxiniuc
12:12 PM Bug #7836: explicit buffer scope when defined at external program and used in an internal entry
This is an existing issue:... Constantin Asofiei
12:11 PM Bug #7836 (New): explicit buffer scope when defined at external program and used in an internal e...
Constantin Asofiei
11:18 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
I've looked at the CompoundQuery in the trunk.
For me this check for CONTAINS looks oversimplified:
# The @where@...
Igor Skornyakov
10:46 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
In what branch can I find these changes?
Thank you.
Igor Skornyakov
09:35 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
I started by looking first at the part of this task related to @CONTAINS@ and run-time optimization of multiple @Comp... Andrei Bălteanu

09/21/2023

03:19 AM Feature #6496 (Review): add equivalent support for -trig command line option
Commited branch #6496a on rev. 14743 and 14744,
with necessary changes to support -trig parameter for searching a s...
Alexandru Donica
03:02 AM Bug #7797: FWD-H2 LAZY reverse index regression
This turned out to be quite a massive set of changes. While doing some tests I noticed things that were not in order ... Radu Apetrii
09:47 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
With some updates to my @import.sh@, I am close with mariadb:... Roger Borrello
08:55 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Some things I need clarification with respect to Maria:
> * Do I need to create a @fwd_user...
Ovidiu Maxiniuc

09/20/2023

07:29 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I checked in an updated @import.sh@ which works with H2. I am still testing with Maria, which I just attempted.
So...
Roger Borrello
06:08 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I am updating the @import.sh@ script to handle all the DBs... on H2, to create the database, there are not separate c... Roger Borrello
04:14 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Try https://proj.goldencode.com/projects/p2j/wiki/Database_Server_Setup_for_MariaDb_on_Linux.
I am sure I did the ...
Ovidiu Maxiniuc
04:06 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> I do not know how this can happen. Word tables for H2 are not supposed to be implemented be...
Roger Borrello
03:40 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Igor Skornyakov wrote:
> > This can happen only if your @build_db.xml@ contains a correspon...
Igor Skornyakov
03:34 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> This can happen only if your @build_db.xml@ contains a corresponding @ScriptRunner@ call.
...
Roger Borrello
03:26 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> The updates to prevent an unneeded DDL from being generated if the dialect does not use them...
Igor Skornyakov
03:13 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The updates to prevent an unneeded DDL from being generated if the dialect does not use them is why there isn't any H... Roger Borrello
12:18 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> Roger Borrello wrote:
> > Branch 4722a has been rebased to the latest trunk (14745). It is...
Igor Skornyakov
11:21 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Branch 4722a has been rebased to the latest trunk (14745). It is at revision 14758. Ovidiu a...
Ovidiu Maxiniuc
08:24 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> @prepare_template.sh@ is only used for turning Hotel GUI into a template for a new application. ...
Roger Borrello
06:33 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
@prepare_template.sh@ is only used for turning Hotel GUI into a template for a new application. You would only ever ... Greg Shah
06:11 PM Bug #7821: Duplication of table records in schema namespace causes dynamic conversion to fail
I found that the schema dictionary is created and the private @nodes@ @List@ is populated, in certain conditions, the... Ovidiu Maxiniuc
05:46 PM Bug #7821 (New): Duplication of table records in schema namespace causes dynamic conversion to fail
Ovidiu Maxiniuc

09/19/2023

07:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
There are two events in your log:
# @data/standard.dict@ is not found in jar. In this case, FWD will try to find it ...
Ovidiu Maxiniuc
07:36 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to the latest trunk (14745). It is at revision 14758. Ovidiu and Igor, can you confirm ... Roger Borrello
07:31 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Eric Faulhaber wrote:
> Is @prepare_template.sh@ a requirement now? TBH, I haven't kept up with every change in thes...
Roger Borrello
06:59 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Hmm... I checked out revision 273, ran the @./prepare_template.sh -n < hotel.input.linux.pg@ and got a successful bui... Roger Borrello
06:41 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Thanks, Eric. Did you run any @prepare_template.sh@ varieties?
No, this was an update of ...
Eric Faulhaber
06:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> I didn't see any particular problems building. What stage should they be logged at? Log atta...
Eric Faulhaber
06:36 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Thanks, Eric. Did you run any @prepare_template.sh@ varieties? Roger Borrello
06:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I just updated to the latest Hotel GUI project (rev 273) and ran @ant clean deploy.all@, using FWD trunk rev 14723. M... Eric Faulhaber
06:21 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I didn't see any particular problems building. What stage should they be logged at? Log attached. Roger Borrello
06:06 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Never mind. I found this in the @hotel.df@ for Hotel GUI:... Eric Faulhaber
06:03 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> I committed an updated @import.sh@ to this branch which allows for the tables to be built wi...
Eric Faulhaber
05:07 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I committed an updated @import.sh@ to this branch which allows for the tables to be built without the logging warning... Roger Borrello
03:30 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The chances are these were added by me when debugging various pieces of code. Certainly, they are not a problem in ho... Ovidiu Maxiniuc
02:50 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Yes, I think we should not need the @logging.properties@.
There are also 3 instances of debug ...
Roger Borrello
02:20 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Yes, I think we should not need the @logging.properties@. Greg Shah
02:19 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> As soon as you require @logging.properties@ there is now a 2nd way to configure logging and it is...
Roger Borrello
11:05 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
As soon as you require @logging.properties@ there is now a 2nd way to configure logging and it is incompatible with o... Greg Shah
10:56 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> I don't think it opens pandora's box to assume that all our dependent libraries are in the same d...
Roger Borrello
10:48 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I don't think it opens pandora's box to assume that all our dependent libraries are in the same directory. That is t... Greg Shah
10:47 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Is that for sure next to @p2j.jar@?
In all cases today which I know of, yes.
Greg Shah
10:44 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Did you try to include @fwd-slf4j.jar@ in the classpath (described in the documentation)?
Is t...
Roger Borrello
10:20 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Did you try to include @fwd-slf4j.jar@ in the classpath (described in the documentation)? Greg Shah
10:09 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> We definitely don't want to put properties files all over the place.
>
> [[p2j:Logging#Interfe...
Roger Borrello
09:58 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
> For the @SLF4J@ issue, I included the @cfg/logging.properties@ in the @hotel.jar@, and specified @-Djava.util.loggi... Greg Shah
09:41 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> The problem caused by the fact that DDL scripts for the @hotel@ projects had DOS line endin...
Roger Borrello
04:50 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Roger Borrello wrote:
> > It hangs here, and does not proceed.
>
> I noticed I was using...
Igor Skornyakov
08:15 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I noticed the quotes around the @$db_url@. I do not think that is the main cause, but I am sure they are not removed ... Ovidiu Maxiniuc

09/18/2023

06:19 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> It hangs here, and does not proceed.
I noticed I was using @fwd_admin@ instead of @fwd_us...
Roger Borrello
06:17 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I am working on updating the import script to utilize the new options for building the database tables. I am receivin... Roger Borrello
 

Also available in: Atom