Project

General

Profile

Activity

From 09/26/2023 to 10/25/2023

10/25/2023

03:45 PM Bug #7924: add support for creating an empty database
Please replace @data.formatWithEscapedParameter("idx__%s", text)@ with the simple @text@. H2 and PostgreSQL will stil... Ovidiu Maxiniuc
08:32 AM Bug #7924: add support for creating an empty database
The additional @idx__@ is added when instantiating the index definition in @schema/import@ using @data.formatWithEsca... Dănuț Filimon
06:47 AM Bug #7924: add support for creating an empty database
Fixed a NPE at conversion time in *7924a/rev.14791*. Dănuț Filimon
05:49 AM Bug #7924: add support for creating an empty database
I extended @import.sh@ to support creation of an empty database. I've *committed 7924a/rev.14790*, the changes consis... Dănuț Filimon
02:25 PM Feature #6414: ERROR attribute for buffer, dataset and temp-table
Ovidiu Maxiniuc wrote:
> Do we have tests in xfer test suite for this attribute?
I am not aware of any. Marian, d...
Eric Faulhaber
10:49 AM Support #7963: disable dirty share database and test existing customer applications
Test the existing #7037 features and any new #7964 features with each of our existing customer applications to see if... Greg Shah
10:39 AM Support #7963 (New): disable dirty share database and test existing customer applications
Greg Shah
10:48 AM Feature #7964: investigate the benefits of disabling cross-session features of the dirty share da...
When we removed Hibernate (#4011), we implemented the record nursery which was meant to be a more efficient way to ma... Greg Shah
10:42 AM Feature #7964 (New): investigate the benefits of disabling cross-session features of the dirty sh...
Greg Shah
10:05 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
*Branch 7416b, rev. 14767-14772 summary:*
* Removed @DatabaseStatistics@ and its usages.
* In @P2JQueryStatistics@:...
Radu Apetrii
08:30 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
*Review of 7416b, rev. 14772*
* I am OK with the changes. These are not functionally changing FWD, but are quite i...
Alexandru Lungu
07:16 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> * Add history numbers to @Validation@ (and all other classes that have changes on this bran...
Radu Apetrii
07:54 AM Feature #7960: Allow query logs to be collected in a H2 database
Branch 7416b will be merged into trunk soon (good news). Those changes include the removal of @DatabaseStatistics@, m... Radu Apetrii
07:19 AM Feature #7960 (Closed): Allow query logs to be collected in a H2 database
Radu Apetrii
07:01 AM Feature #7323: Implement soft unique index in FWD-H2
Also:
* major: mind moving @stopValidating@ in a finally clause. Otherwise, an exception will miss the stopping of...
Alexandru Lungu
07:00 AM Feature #7323 (WIP): Implement soft unique index in FWD-H2
I attempted to profile 7323a and succeeded into actually running it, but the time is way off (+3-4%). After some revi... Alexandru Lungu
03:53 AM Feature #7323: Implement soft unique index in FWD-H2
Rebased 7323a to latest trunk. 7323a is now at rev. 14799. Alexandru Lungu

10/24/2023

03:54 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I committed updates to the @testcases@ project which should work better. The changes bring it closer in line to hotel... Roger Borrello
08:24 AM Bug #7924: add support for creating an empty database
It is better to augment @import.sh@ than to add a new script.
Most importantly: @import.sh@ is meant to be just a ...
Greg Shah
03:45 AM Bug #7924: add support for creating an empty database
I started working on this task, should the @import.sh@ added in trunk/rev.14773 be extended for this case or a new @c... Dănuț Filimon

10/23/2023

04:09 PM Feature #6720: lazy hydration
I like this idea. Eric Faulhaber
11:16 AM Feature #6720: lazy hydration
*Committed 6720b/rev. 14767*:
* ported some changes from 7185a designed specially for private @BaseRecord.data@ ac...
Alexandru Lungu
10:34 AM Bug #7788: NPE when assigning query to browse
I have returned to this issue. I tried modifying this piece of code:... Alexandru Donica
10:33 AM Bug #7924: add support for creating an empty database
Danut, mind that I will move this in High Priority. Even if it is part of the Database thread, it is also a feature r... Alexandru Lungu

10/21/2023

09:23 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Just sharing my experience.
It might be an easy fix: check whether the jar (which should contain the @.sql@ resour...
Ovidiu Maxiniuc
08:18 PM Feature #6414: ERROR attribute for buffer, dataset and temp-table
Since #6414-3 we have the @Errorable@ interface which groups together all @error@ attributes, regardless of object ty... Ovidiu Maxiniuc

10/20/2023

03:05 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Tijs Wickardt wrote:
> > When you run the procedure described at [[p2j:Testcases]], does yo...
Tijs Wickardt
02:51 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Tijs Wickardt wrote:
> When you run the procedure described at [[p2j:Testcases]], does your jar include them?
Sor...
Roger Borrello
02:44 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Does your jar include the @ddl@ files?
After revert?
Els can check on Monday, I'm not at...
Tijs Wickardt
02:21 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Does your jar include the @ddl@ files? Roger Borrello
01:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Hello Roger, I'm experiencing the same regression as Els in #4722-162 .
We aren't completely sure which commit after...
Tijs Wickardt
02:43 PM Feature #6414: ERROR attribute for buffer, dataset and temp-table
Ovidiu, how much effort is there to finish this? We are trying to get it done this month. Eric Faulhaber
10:19 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, please let me know when you finish with the changes here. I will like to have this reviewed, tested and merged ... Alexandru Lungu

10/19/2023

04:49 PM Feature #7943: improvements in lock management for diagnostics and release of orphaned locks
A customer with a ChUI application (see #5290) is on an older version of FWD and had issues with locks being held lon... Greg Shah
03:53 PM Feature #7943 (New): improvements in lock management for diagnostics and release of orphaned locks
Greg Shah
10:36 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Hi Roger,
We found a possible regression after the merge with trunk of this issue.
In xfer testcases I can convert ...
Els van Dun

10/17/2023

09:17 AM Bug #7924: add support for creating an empty database
Greg, thank you for the heads-up. This exact same thing I wanted to mention, but I missed it. Please note my "Two way... Alexandru Lungu
09:09 AM Bug #7924: add support for creating an empty database
Please note that the ant task is a development convenience. When deploying to production environments, there will be... Greg Shah
08:37 AM Bug #7924 (WIP): add support for creating an empty database
A summary from a customer task - mostly from Eric:
* Empty database: _A database with a fully working schema (incl...
Alexandru Lungu
08:23 AM Bug #7924 (Test): add support for creating an empty database
Alexandru Lungu

10/13/2023

10:22 AM Feature #4722 (Test): data import should be able to run with only the converted application jar f...
Roger Borrello
10:22 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
4722a was merged to trunk rev 14773 and archived. Roger Borrello
09:58 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Please merge to trunk now. Greg Shah
09:32 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Is there anything we need to handle from a project migration/cfg perspective when this is merged?...
Roger Borrello
09:27 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Is there anything we need to handle from a project migration/cfg perspective when this is merged?
Roger: Can you...
Greg Shah
09:18 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14772 and is at revision 14790. Roger Borrello
07:24 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Review:
* Add history numbers to @Validation@ (and all other classes that have changes on this branch exclusively ...
Alexandru Lungu

10/11/2023

05:21 AM Feature #7416 (Review): Reiterate DatabaseStatistics and leverage to other database profling tools
Radu Apetrii
05:21 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I've done another commit in which I've fixed some of the things that I noticed during the "rereview":
* There was a ...
Radu Apetrii
03:22 AM Feature #6720: lazy hydration
Eric, I prepared some questions here last week, but it seems I missed submitting them. I was kind of waiting for feed... Alexandru Lungu

10/10/2023

12:51 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14769 and is at revision 14787. I committed an update to @import.sh@ which change... Roger Borrello
07:27 AM Feature #7416 (WIP): Reiterate DatabaseStatistics and leverage to other database profling tools
I tried to run @./gradlew.all@ in the 7416b branch, but I've encountered some errors. Thus, I've committed to 7416b, ... Radu Apetrii

10/06/2023

09:07 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> Radu, please rebase 7416b to the latest trunk. "Rereview" the changes and test them with a ...
Radu Apetrii
06:27 AM Feature #7416 (Review): Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, please rebase 7416b to the latest trunk. "Rereview" the changes and test them with a project you already have i... Alexandru Lungu

10/05/2023

05:54 AM Bug #7776 (Review): Previous regression on FWD-H2 lazy mode
This was merged to FWD-H2 trunk as rev. 28 and reached trunk as fwd-h2-1.31-trunk. Alexandru Lungu

10/04/2023

06:23 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14766 and is at revision 14783. Roger Borrello
04:13 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> I re-reviewed the changes and only have only one question: there are some commits with no f...
Roger Borrello
03:41 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Yes.
I re-reviewed the changes and only have only one question: there are some commits with no file changes (14781, ...
Ovidiu Maxiniuc
08:28 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu: Are you OK with merging? Greg Shah
08:26 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Are these changes safe to merge now?
>
> Is there anything we need to handle from a project mi...
Roger Borrello
07:55 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Are these changes safe to merge now?
Is there anything we need to handle from a project migration/cfg perspective ...
Greg Shah

10/03/2023

06:33 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch was rebased to trunk 14764 and is at revision 14781. Roger Borrello

10/02/2023

12:53 PM Feature #6720: lazy hydration
Task branch 6720b has been rebased to trunk rev 14762. New 6720b revision is 14766.
Alexandru, please review the c...
Eric Faulhaber
04:40 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
I retested the testcase from #6196-47, but instead of @for each@ I used @preselect each@.
Without the changes from #...
Andrei Bălteanu

09/29/2023

07:15 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to trunk_14758 at revision 14775. Roger Borrello
10:06 AM Bug #7667 (WIP): Support OUTER-JOIN with PRESELECT at conversion
The branch 7667a was created to solve a problem related to a *run-time* optimization. This was not the initial purpos... Andrei Bălteanu
09:58 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
What is the % Done on this task? Greg Shah
09:51 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667a was merged to trunk rev. 14757 and archived. Alexandru Lungu
09:46 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
You can merge 7667a now. Greg Shah
06:59 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei, I am OK with the changes. Still, @isConstant@ is not "integrated" into the mainWalk - there are still two wal... Alexandru Lungu
04:57 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Sure thing!
Committed the changes on 7667a revision 14760.
Andrei Bălteanu
02:35 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei, please address #7667-19 asap (including the move of your code in @mainWalk@ to avoid extra AST traversals). A... Alexandru Lungu
06:58 AM Bug #7855: Integrate fixEmptyContains into mainWalk at FQL preprocessing
There is another AST traversal done in @fixEmptyContains@ which can be integrated into @mainWalk@ for further perform... Alexandru Lungu
06:58 AM Bug #7855 (New): Integrate fixEmptyContains into mainWalk at FQL preprocessing
Alexandru Lungu

09/28/2023

05:12 PM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667 has been rebased to trunk_14756. Roger Borrello
11:05 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei Bălteanu wrote:
> Regarding the problem from #7667-9, I was thinking about the following changes:
> [...]
>...
Eric Faulhaber
10:49 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Code review 7667a/14757:
The logic looks good. A few minor issues:
* Please avoid using the @for-each@ syntax w...
Eric Faulhaber
09:26 AM Bug #7667 (Review): Support OUTER-JOIN with PRESELECT at conversion
I'm having a look... Eric Faulhaber
08:40 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Alexandru Lungu wrote:
> Note that this task is about conversion support, so 7667a is not going to address the task,...
Igor Skornyakov
08:27 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Note that this task is about conversion support, so 7667a is not going to address the task, but only fix a run-time r... Alexandru Lungu
06:30 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Modified accordingly.
There was also a parameter out of line and i fixed that too (cheers to Radu for the heads up)...
Andrei Bălteanu
05:44 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Review of 7667a:
* Fix history entry of @CompoundQuery@ (AB is on a different line than the entry description)
* Re...
Alexandru Lungu
04:52 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Regarding the problem from #7667-9, I was thinking about the following changes:... Andrei Bălteanu
05:09 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to trunk_14756. Roger Borrello

09/27/2023

01:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The benefit of the @build_db.xml@ is it falls right in line with the @ant@ build of the application and provides a le... Roger Borrello
01:25 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I'm good with that idea. Greg Shah
12:44 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I am not aware of any open issues here.
When I first created the @import.sh@ my intention was to have a faster way...
Ovidiu Maxiniuc
12:23 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
For Hotel GUI/ChUI, I would expect that the standard projects might be simplified to some degree and I would expect t... Greg Shah
08:12 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Roger: What is the migration plan? There are changes to apply for both Hotel projects? What abo...
Roger Borrello
07:40 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor/Ovidiu/Eric: Any objections or known open items?
Roger: What is the migration plan? There are changes to app...
Greg Shah
10:12 AM Bug #7797: FWD-H2 LAZY reverse index regression
Sounds good. Eric will handle the push when you are ready. Greg Shah
09:04 AM Bug #7797: FWD-H2 LAZY reverse index regression
I would like to have 7789a_h2 merged as well, before the upgrade. I finished the implementation (going to update #778... Alexandru Lungu
08:03 AM Bug #7797: FWD-H2 LAZY reverse index regression
Is this ready to be deployed on @proj.goldencode.com@? If so, is it safe to push it with the current version of trunk? Greg Shah
05:44 AM Bug #7797 (Test): FWD-H2 LAZY reverse index regression
Alexandru Lungu
05:43 AM Bug #7797 (Review): FWD-H2 LAZY reverse index regression
I am OK with the changes in 7066c_h2.
I also changed the planner a bit to score more the indexes that are reversed i...
Alexandru Lungu
03:04 AM Feature #6720: lazy hydration
This entry is intended to document the prototype implementation of lazy hydration in 6720b/14632-14634: what is imple... Eric Faulhaber

09/26/2023

06:07 PM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667a has been rebased to the latest trunk (14754). Roger Borrello
04:46 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Thanks for the review!
Modified accordingly and committed to 7667a revision 14753.
Andrei Bălteanu
05:51 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to the latest trunk (14754).
Is there anything keeping this from being merged with t...
Roger Borrello
09:06 AM Bug #7841: Invalid conversion of temp table DMO when using clob/blob fields
Sorry, there is a typo in the file @start.p@, where I forgot to rename the procedure @atable-clob.p@ to @table-clob.p... Alexandru Donica
08:57 AM Bug #7841: Invalid conversion of temp table DMO when using clob/blob fields
I created 2 temp tables, in separate procedures, with the same table name, same field types with same field names, bu... Alexandru Donica
08:51 AM Bug #7841 (Test): Invalid conversion of temp table DMO when using clob/blob fields
Alexandru Donica
04:45 AM Bug #7797: FWD-H2 LAZY reverse index regression
I've addressed the review from the previous post and committed the changes to 7066c_h2, rev. 31.
> * Why is @curre...
Radu Apetrii
 

Also available in: Atom