FWD » Core Development » Database

11/02/2023

11:07 PM Bug #7993 (Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) o...

Review of c14813/7993a.
I am OK with the code. As described above, it should offer a bit of performance boost if t... Ovidiu Maxiniuc

11/01/2023

03:25 PM Bug #7731: performance improvements for FQLPreprocessor

Constantin Asofiei wrote:
> Is the cache configurable via directory.xml? I would leave it to 8192 as default and tu... Dănuț Filimon

09:02 AM Bug #7731: performance improvements for FQLPreprocessor

Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > OK, please set the cache size to 512k, run the test, look via ... Constantin Asofiei

08:58 AM Bug #7731: performance improvements for FQLPreprocessor

Constantin Asofiei wrote:
> OK, please set the cache size to 512k, run the test, look via the debugger and see what ... Dănuț Filimon

07:43 AM Bug #7731: performance improvements for FQLPreprocessor

Rebased 7731a to latest trunk. It is now at rev. 14811. Alexandru Lungu

06:37 AM Bug #7731: performance improvements for FQLPreprocessor

OK, please set the cache size to 512k, run the test, look via the debugger and see what the actual cache size is afte... Constantin Asofiei

06:35 AM Bug #7731: performance improvements for FQLPreprocessor

Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Dănuț Filimon wrote:
> > > So I should leave the cache s... Dănuț Filimon

06:28 AM Bug #7731: performance improvements for FQLPreprocessor

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > So I should leave the cache size to *512k* instead of *8192* a... Constantin Asofiei

11:38 AM Bug #7993 (Review): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING)...

The fast-copy process uses two intermediary tables (BEFORE__PK__MAPPING and MASTER__PK__MAPPING) to fulfill more comp... Alexandru Lungu

11:01 AM Bug #7993 (Test): Create the fast-copy mapping tables (MASTER_PK_MAPPING and BEFORE_PK_MAPPING) o...

Alexandru Lungu

11:29 AM Bug #7420 (Test): Optimize Cursor for scrolling AdaptiveQuery

Alexandru Lungu

10:45 AM Feature #7382: Check performance of delete from vs drop table in H2

Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Just found out @TRUNCATE TABLE tt@ in H2.
> Isn't this the ... Alexandru Lungu

10:40 AM Feature #7382: Check performance of delete from vs drop table in H2

Alexandru Lungu wrote:
> Just found out @TRUNCATE TABLE tt@ in H2.
Isn't this the same as @DELETE FROM tt@ without ... Constantin Asofiei

10:31 AM Feature #7382: Check performance of delete from vs drop table in H2

Just found out @TRUNCATE TABLE tt@ in H2. I was suspecting that such command should have existed, but now it is confi... Alexandru Lungu

08:53 AM Feature #7382: Check performance of delete from vs drop table in H2

With the new fwd-h2-1.33-trunk, FWD temp-tables have a special scan index that is able to distinguish between multipl... Alexandru Lungu

08:20 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

Profiled and the change has a reasonable time (it fits the time boundaries). It is neither faster nor slower.
*Eri... Alexandru Lungu

06:19 AM Feature #7323: Implement soft unique index in FWD-H2

Alexandru Lungu wrote:
> Radu, please queue this task and mark it with higher priority.
On it. I also noticed some ... Radu Apetrii

01:30 AM Feature #6414 (Review): ERROR attribute for buffer, dataset and temp-table

Task branch was rebased to trunk/14805 updated to r14807.
The latest update contains the handling of ERROR attribute... Ovidiu Maxiniuc

10/31/2023

06:20 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch 4722b was rebased to trunk_14805 and is at revision 14806. Roger Borrello

09:17 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch 4722b was rebased to trunk_14798 and is at revision 14799. Roger Borrello

08:17 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Ovidiu Maxiniuc wrote:
> Roger Borrello wrote:
> > Question... Is the @-Djava.system.class.loader=com.goldencode.as... Roger Borrello

04:49 PM Feature #6347: change the name conversion to provide a configurable option to not emit "snake case"

Can this be closed? Is there something remaining to do? Greg Shah

10/30/2023

02:48 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Roger Borrello wrote:
> Question... Is the @-Djava.system.class.loader=com.goldencode.asm.AsmClassLoader@ parameter ... Ovidiu Maxiniuc

12:10 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch 4722b was rebased to trunk_14795 and is at revision 14796. Roger Borrello

08:51 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion

Has enough testing been done to confirm that 7667b is safe?
Are any other code reviews needed? Greg Shah

07:22 AM Bug #7797 (Closed): FWD-H2 LAZY reverse index regression

Greg Shah

06:34 AM Bug #7797: FWD-H2 LAZY reverse index regression

This reached trunk in fwd-h2-1.33-trunk and can be closed. Alexandru Lungu

06:55 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible

*7567a_h2* reached FWD-H2 trunk, which ultimately is delivered with the FWD trunk as fwd-h2-1.33-trunk.
I also rebas... Alexandru Lungu

10/28/2023

12:32 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Ovidiu Maxiniuc wrote:
> Yes, Roger, I think you should fork a new branch, 4722b.
> I also have small updates relat... Roger Borrello

09:57 PM Feature #6414 (WIP): ERROR attribute for buffer, dataset and temp-table

I created 6414a and committed the first part of the changes which include only for passing the ERROR attribute with t... Ovidiu Maxiniuc

10/27/2023

06:25 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Yes, Roger, I think you should fork a new branch, 4722b.
I also have small updates related to import, not dramatic, ... Ovidiu Maxiniuc

05:18 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Roger Borrello wrote:
> I have an update to @import.sh@ which I need to get to trunk. I thought #7572 might be a goo... Roger Borrello

05:08 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

I have an update to @import.sh@ which I need to get to trunk. I thought #7572 might be a good task, since the fix in ... Roger Borrello

04:41 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Nevermind... my url did not include: @;MV_STORE=FALSE;LOG=0;CACHE_SIZE=65536;LOCK_MODE=0;UNDO_LOG=0@ Roger Borrello

04:38 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

When configuring the database using @import.sh@, the H2 creation/import doesn't seem to be working properly. When I c... Roger Borrello

01:16 PM Bug #7924: add support for creating an empty database

Dănuț Filimon wrote:
> It seems that MariaDB has a problem that is not related to the changes made here. As you ment... Ovidiu Maxiniuc

08:09 AM Bug #7924: add support for creating an empty database

> ... but I am still having issues when trying to connect to the database.
I overlooked the fact that I need to ch... Dănuț Filimon

07:58 AM Bug #7924: add support for creating an empty database

Ovidiu Maxiniuc wrote:
> I tested the import using both ant script and fwd's @import.sh@.
>
> The @import.sh@ per... Dănuț Filimon

09:22 PM Bug #7924: add support for creating an empty database

I tested the import using both ant script and fwd's @import.sh@.
The project's @build_db.xml@ needed some changes ... Ovidiu Maxiniuc

10/26/2023

10:15 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion

I just checked-out 7667b and changes are OK (#7667-13).
I suggest getting this into trunk when possible; this was ... Alexandru Lungu

05:39 AM Bug #7924: add support for creating an empty database

*Committed 7924a/rev.14792*. Fixed the additional @idx__@ and modified the import to always process the records of th... Dănuț Filimon

04:43 AM Bug #7924: add support for creating an empty database

Ovidiu Maxiniuc wrote:
> Please replace @data.formatWithEscapedParameter("idx__%s", text)@ with the simple @text@. H... Dănuț Filimon

02:19 AM Feature #6414: ERROR attribute for buffer, dataset and temp-table

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > Do we have tests in xfer test suite for this attribute?
>
> I... Marian Edu

10/25/2023

03:45 PM Bug #7924: add support for creating an empty database

Please replace @data.formatWithEscapedParameter("idx__%s", text)@ with the simple @text@. H2 and PostgreSQL will stil... Ovidiu Maxiniuc

08:32 AM Bug #7924: add support for creating an empty database

The additional @idx__@ is added when instantiating the index definition in @schema/import@ using @data.formatWithEsca... Dănuț Filimon

06:47 AM Bug #7924: add support for creating an empty database

Fixed a NPE at conversion time in *7924a/rev.14791*. Dănuț Filimon

05:49 AM Bug #7924: add support for creating an empty database

I extended @import.sh@ to support creation of an empty database. I've *committed 7924a/rev.14790*, the changes consis... Dănuț Filimon

02:25 PM Feature #6414: ERROR attribute for buffer, dataset and temp-table

Ovidiu Maxiniuc wrote:
> Do we have tests in xfer test suite for this attribute?
I am not aware of any. Marian, d... Eric Faulhaber

10:49 AM Support #7963: disable dirty share database and test existing customer applications

Test the existing #7037 features and any new #7964 features with each of our existing customer applications to see if... Greg Shah

10:39 AM Support #7963 (New): disable dirty share database and test existing customer applications

Greg Shah

10:48 AM Feature #7964: investigate the benefits of disabling cross-session features of the dirty share da...

When we removed Hibernate (#4011), we implemented the record nursery which was meant to be a more efficient way to ma... Greg Shah

10:42 AM Feature #7964 (New): investigate the benefits of disabling cross-session features of the dirty sh...

Greg Shah

10:05 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

*Branch 7416b, rev. 14767-14772 summary:*
* Removed @DatabaseStatistics@ and its usages.
* In @P2JQueryStatistics@:... Radu Apetrii

08:30 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

*Review of 7416b, rev. 14772*
* I am OK with the changes. These are not functionally changing FWD, but are quite i... Alexandru Lungu

07:16 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

Alexandru Lungu wrote:
> * Add history numbers to @Validation@ (and all other classes that have changes on this bran... Radu Apetrii

07:54 AM Feature #7960: Allow query logs to be collected in a H2 database

Branch 7416b will be merged into trunk soon (good news). Those changes include the removal of @DatabaseStatistics@, m... Radu Apetrii

07:19 AM Feature #7960 (Closed): Allow query logs to be collected in a H2 database

Radu Apetrii

07:01 AM Feature #7323: Implement soft unique index in FWD-H2

Also:
* major: mind moving @stopValidating@ in a finally clause. Otherwise, an exception will miss the stopping of... Alexandru Lungu

07:00 AM Feature #7323 (WIP): Implement soft unique index in FWD-H2

I attempted to profile 7323a and succeeded into actually running it, but the time is way off (+3-4%). After some revi... Alexandru Lungu

03:53 AM Feature #7323: Implement soft unique index in FWD-H2

Rebased 7323a to latest trunk. 7323a is now at rev. 14799. Alexandru Lungu

10/24/2023

03:54 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

I committed updates to the @testcases@ project which should work better. The changes bring it closer in line to hotel... Roger Borrello

08:24 AM Bug #7924: add support for creating an empty database

It is better to augment @import.sh@ than to add a new script.
Most importantly: @import.sh@ is meant to be just a ... Greg Shah

03:45 AM Bug #7924: add support for creating an empty database

I started working on this task, should the @import.sh@ added in trunk/rev.14773 be extended for this case or a new @c... Dănuț Filimon

10/23/2023

04:09 PM Feature #6720: lazy hydration

I like this idea. Eric Faulhaber

11:16 AM Feature #6720: lazy hydration

*Committed 6720b/rev. 14767*:
* ported some changes from 7185a designed specially for private @BaseRecord.data@ ac... Alexandru Lungu

10:34 AM Bug #7788: NPE when assigning query to browse

I have returned to this issue. I tried modifying this piece of code:... Alexandru Donica

10:33 AM Bug #7924: add support for creating an empty database

Danut, mind that I will move this in High Priority. Even if it is part of the Database thread, it is also a feature r... Alexandru Lungu

10/21/2023

09:23 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Just sharing my experience.
It might be an easy fix: check whether the jar (which should contain the @.sql@ resour... Ovidiu Maxiniuc

08:18 PM Feature #6414: ERROR attribute for buffer, dataset and temp-table

Since #6414-3 we have the @Errorable@ interface which groups together all @error@ attributes, regardless of object ty... Ovidiu Maxiniuc

10/20/2023

03:05 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Roger Borrello wrote:
> Tijs Wickardt wrote:
> > When you run the procedure described at [[p2j:Testcases]], does yo... Tijs Wickardt

02:51 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Tijs Wickardt wrote:
> When you run the procedure described at [[p2j:Testcases]], does your jar include them?
Sor... Roger Borrello

02:44 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Roger Borrello wrote:
> Does your jar include the @ddl@ files?
After revert?
Els can check on Monday, I'm not at... Tijs Wickardt

02:21 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Does your jar include the @ddl@ files? Roger Borrello

01:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Hello Roger, I'm experiencing the same regression as Els in #4722-162 .
We aren't completely sure which commit after... Tijs Wickardt

02:43 PM Feature #6414: ERROR attribute for buffer, dataset and temp-table

Ovidiu, how much effort is there to finish this? We are trying to get it done this month. Eric Faulhaber

10:19 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

Radu, please let me know when you finish with the changes here. I will like to have this reviewed, tested and merged ... Alexandru Lungu

10/19/2023

04:49 PM Feature #7943: improvements in lock management for diagnostics and release of orphaned locks

A customer with a ChUI application (see #5290) is on an older version of FWD and had issues with locks being held lon... Greg Shah

03:53 PM Feature #7943 (New): improvements in lock management for diagnostics and release of orphaned locks

Greg Shah

10:36 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Hi Roger,
We found a possible regression after the merge with trunk of this issue.
In xfer testcases I can convert ... Els van Dun

10/17/2023

09:17 AM Bug #7924: add support for creating an empty database

Greg, thank you for the heads-up. This exact same thing I wanted to mention, but I missed it. Please note my "Two way... Alexandru Lungu

09:09 AM Bug #7924: add support for creating an empty database

Please note that the ant task is a development convenience. When deploying to production environments, there will be... Greg Shah

08:37 AM Bug #7924 (WIP): add support for creating an empty database

A summary from a customer task - mostly from Eric:
* Empty database: _A database with a fully working schema (incl... Alexandru Lungu

08:23 AM Bug #7924 (Test): add support for creating an empty database

Alexandru Lungu

10/13/2023

10:22 AM Feature #4722 (Test): data import should be able to run with only the converted application jar f...

Roger Borrello

10:22 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

4722a was merged to trunk rev 14773 and archived. Roger Borrello

09:58 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Please merge to trunk now. Greg Shah

09:32 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Greg Shah wrote:
> Is there anything we need to handle from a project migration/cfg perspective when this is merged?... Roger Borrello

09:27 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

> Is there anything we need to handle from a project migration/cfg perspective when this is merged?
Roger: Can you... Greg Shah

09:18 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch 4722a was rebased with trunk_14772 and is at revision 14790. Roger Borrello

07:24 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

Review:
* Add history numbers to @Validation@ (and all other classes that have changes on this branch exclusively ... Alexandru Lungu

10/11/2023

05:21 AM Feature #7416 (Review): Reiterate DatabaseStatistics and leverage to other database profling tools

Radu Apetrii

05:21 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

I've done another commit in which I've fixed some of the things that I noticed during the "rereview":
* There was a ... Radu Apetrii

03:22 AM Feature #6720: lazy hydration

Eric, I prepared some questions here last week, but it seems I missed submitting them. I was kind of waiting for feed... Alexandru Lungu

10/10/2023

12:51 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch 4722a was rebased with trunk_14769 and is at revision 14787. I committed an update to @import.sh@ which change... Roger Borrello

07:27 AM Feature #7416 (WIP): Reiterate DatabaseStatistics and leverage to other database profling tools

I tried to run @./gradlew.all@ in the 7416b branch, but I've encountered some errors. Thus, I've committed to 7416b, ... Radu Apetrii

10/06/2023

09:07 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools

Alexandru Lungu wrote:
> Radu, please rebase 7416b to the latest trunk. "Rereview" the changes and test them with a ... Radu Apetrii

06:27 AM Feature #7416 (Review): Reiterate DatabaseStatistics and leverage to other database profling tools

Radu, please rebase 7416b to the latest trunk. "Rereview" the changes and test them with a project you already have i... Alexandru Lungu

10/05/2023

05:54 AM Bug #7776 (Review): Previous regression on FWD-H2 lazy mode

This was merged to FWD-H2 trunk as rev. 28 and reached trunk as fwd-h2-1.31-trunk. Alexandru Lungu

10/04/2023

06:23 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch 4722a was rebased with trunk_14766 and is at revision 14783. Roger Borrello

04:13 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Ovidiu Maxiniuc wrote:
> I re-reviewed the changes and only have only one question: there are some commits with no f... Roger Borrello

03:41 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Yes.
I re-reviewed the changes and only have only one question: there are some commits with no file changes (14781, ... Ovidiu Maxiniuc

08:28 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Ovidiu: Are you OK with merging? Greg Shah

08:26 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Greg Shah wrote:
> Are these changes safe to merge now?
>
> Is there anything we need to handle from a project mi... Roger Borrello

07:55 AM Feature #4722: data import should be able to run with only the converted application jar file (an...

Are these changes safe to merge now?
Is there anything we need to handle from a project migration/cfg perspective ... Greg Shah

10/03/2023

06:33 PM Feature #4722: data import should be able to run with only the converted application jar file (an...

Branch was rebased to trunk 14764 and is at revision 14781. Roger Borrello